Re: Java 7 Application freeze at sun.lwawt.macosx.CCursorManager.nativeGetCursorPosition

2013-11-18 Thread Petr Pchelko
Hello, Viral. It's known that there are some deadlocks in SWT_AWT bridge on Mac. Here's an example: https://bugs.openjdk.java.net/browse/JDK-8020165 It would be useful if you also post the dump of an Appkit thread to identify your particular case. The deadlock occurs because AWT is called on

Re: Using the Apple menu (Apple.laf.useScreenMenuBar) the menu items are always in English whatever set as Preferred Language

2013-12-25 Thread Petr Pchelko
Hello, Paul. Sorry for the delayed answer. The problem is that we are relying on Cocoa to create these menu items. However, to properly understand the locale Cocoa needs a special key in the Info.plist file (CFBundleAllowMixedLocalizations). However when you are running a java application as

Re: Dragging an image from Webpage within Firefox no longer provides it as DataFlavour java.net.URL/java.util.List on OSX with Java 7

2014-01-13 Thread Petr Pchelko
Hello, Hendrik. I just tried that as well: no difference :-( We’ve had numerous regression in datatransfer area in JDK-8 but wight now they should all be fixed. However the URI transfer on Mac OS X still does not work in some cases, it’s simply not implemented. I have a related issue:

Re: Dragging an image from Webpage within Firefox no longer provides it as DataFlavour java.net.URL/java.util.List on OSX with Java 7

2014-01-15 Thread Petr Pchelko
for noticing that something is wrong with the Finder. I think I know the reason, but anyway I've filed https://bugs.openjdk.java.net/browse/JDK-8031965 With best regards. Petr. On 15.01.2014, at 17:31, Hendrik Schreiber h...@tagtraum.com wrote: On Jan 13, 2014, at 18:36, Petr Pchelko petr.pche

Re: JFrame.setResizable(false) brings unexpected behaviour in j2sdk 8

2014-01-23 Thread Petr Pchelko
Hello, Yes, this indeed is a regression in JDK 8. I’ve created an issue for you: https://bugs.openjdk.java.net/browse/JDK-8032595 Thank you for reporting this problem. With best regards. Petr. 21 янв. 2014 г., в 6:22 до полудня, niagarasoft20-macosxport...@yahoo.com написал(а): import

Re: [9] Review request for 8031573 [macosx] Checkmarks of JCheckBoxMenuItems aren't rendered in high resolution on Retina

2014-02-24 Thread Petr Pchelko
Hello, Alexander. The fix looks good to me. With best regards. Petr. On 18.02.2014, at 16:20, Sergey Bylokhov sergey.bylok...@oracle.com wrote: Hi, Alexander. The fix looks good then. On 17.02.2014 18:38, Alexander Scherbatiy wrote: On 2/14/2014 3:16 PM, Sergey Bylokhov wrote: On

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-02-26 Thread Petr Pchelko
Hello, Alexander. I have a couple of comments: 1. You could replace the first loop with indexOfObjectPassingTest method.. Not sure if this would look cleaner, up to you. 2. I suppose JNFNewObjectArray could throw the OOM and we would get a parfait warning, could you please add

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-02-26 Thread Petr Pchelko
/2014 4:54 PM, Petr Pchelko wrote: Hello, Alexander. I have a couple of comments: 1. You could replace the first loop with indexOfObjectPassingTest method.. Not sure if this would look cleaner, up to you. Updated. There is one more way to use one loop instead of two. All of them does

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-03-04 Thread Petr Pchelko
soo long lines in these files. On 2/26/14 6:40 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8033534/webrev.03/ On 2/26/2014 4:54 PM, Petr Pchelko wrote: Hello, Alexander. I have a couple of comments: 1. You could

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-03-04 Thread Petr Pchelko
: On 3/4/2014 3:30 PM, Petr Pchelko wrote: Hello, Alexander. In CImage.m:430 - Do we really want to describe and clear the exception? May be it's better to simply return NULL and let Java handle the exception? This made sense when you were continuing the loop, but now doesn't. The exception

Re: [9] Review request for 8036598 [macosx] Create AquaIcons from image representations

2014-03-04 Thread Petr Pchelko
Hello, Alexander. I've been also looking around this code and I have a related question: when we call getThisApplicationsIcon we are drawing the Dock icon on top of a multi-resolution background image. However as I see, the dock icon image created with getThisApplicationsIcon and

Re: [9] Review request for 8035069 [macosx] Loading resolution variants by demand

2014-03-13 Thread Petr Pchelko
Hello, Alexander. 1. As Sergey always says, could you please split the long lines. 2. Instead of the MultiResolutionImageMapper you could use a BiFunctionImage, Integer, Integer 3. About the ImageCache. As it's uses an AppContext, could you please mention in the JavaDoc that is must be used

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Petr Pchelko
Hello, Sergey. After Anthony have asked all the possible questions I’m left with the only option: The fix looks good to me. BTW: I see that there’s one more bug in this method: https://bugs.openjdk.java.net/browse/JDK-8036927 Is it also resolved by this fix? With best regards. Petr. 19

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

2014-03-28 Thread Petr Pchelko
Still Looks good. With best regards. Petr. On 28.03.2014, at 18:01, Sergey Bylokhov sergey.bylok...@oracle.com wrote: Hi, Alexander. The fix looks good. On 3/28/14 4:43 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix:

Re: [9] Review Request: 8029196 Focus border of JButton.buttonType=roundRect is cut off

2014-04-01 Thread Petr Pchelko
Hello, Sergey. Does the fix work for retina thin focuses and non-retina thick? With best regards. Petr. On 01.04.2014, at 15:46, Sergey Bylokhov sergey.bylok...@oracle.com wrote: Hello. Please review the fix for jdk 9. JRS draws all component in specified bounds, but if a component is in

Re: [9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

2014-04-02 Thread Petr Pchelko
Hello, Alexander. Could you please add the @Override to the paintIcon method. Also I suggest to reuse the paintIcon in the createIcon. With best regards. Petr. On 02.04.2014, at 16:20, Alexander Scherbatiy alexandr.scherba...@oracle.com wrote: Hello, Could you review the updated

Re: [9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

2014-04-09 Thread Petr Pchelko
explicitly implements Icon interface now - getOptimizedImage() method is removed from the CachingScalingIcon because NSImage always scales an image to the requested size - @Override annotation is added. Thanks, Alexandr. On 4/2/2014 4:37 PM, Petr Pchelko wrote: Hello, Alexander. Could

Re: [9] Review request for 8040279 [macosx] Do not use the base image in the MultiResolutionBufferedImage constructor

2014-04-21 Thread Petr Pchelko
to createImage in the CImage class. Thanks, Alexandr. On 4/21/2014 2:36 PM, Petr Pchelko wrote: Hello, Alexander. Just one minor comment: In CImage createBufferedImage method does not create a BufferredImage any more, so it worths renaming. With best regards. Petr. On 15.04.2014, at 18