Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?

2015-03-23 Thread Barry Warsaw
On Mar 23, 2015, at 12:17 PM, Aurelien Bompard wrote: But there's something else: the SubscriptionWorkflow class does not seem to be used anywhere except in the current unit test. Am I missing something ? Nope. It needs to be hooked up. The branch wasn't merged because it was incomplete.

Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?

2015-03-23 Thread Aurelien Bompard
Oops. Looks like I'd forgotten to push them. They should now be available in lp:~barry/mailman/subpolicy Got it. OK, the SubscriptionWorkflow seems correct in implementation but it has almost no tests, so I'll write some. But there's something else: the SubscriptionWorkflow class does not

Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?

2015-03-23 Thread Aurelien Bompard
Nope. It needs to be hooked up. The branch wasn't merged because it was incomplete. Oh, and the _send_confirmation method is also not implemented. Could you briefly explain how does the confirmation system work? (or point me to the doc, I didn't find it) Thanks Aurélien

Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?

2015-03-23 Thread Aurelien Bompard
Nope. It needs to be hooked up. The branch wasn't merged because it was incomplete. Ah alright, I'm just adding some tests but it would probably be better you did the hooking up... (or I'll need a good amount of guidance) Thanks Aurélien ___

Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?

2015-03-21 Thread Aurelien Bompard
Have a look at the workflow illustrated in my crappy Dia file, which I think is an accurate representation of how the policy should work. Hmm, could you point me to this Dia file please, I can't find it. Thanks! Aurélien ___ Mailman-Developers

Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?

2015-03-21 Thread Barry Warsaw
On Mar 21, 2015, at 10:50 AM, Aurelien Bompard wrote: Hmm, could you point me to this Dia file please, I can't find it. Thanks! Oops. Looks like I'd forgotten to push them. They should now be available in lp:~barry/mailman/subpolicy Cheers, -Barry pgpUyR2fuW394.pgp Description: OpenPGP

Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?

2015-03-20 Thread Aurelien Bompard
Do you think I can help you work on that? Or would you prefer doing the initial branch resurrection? Anything I need to know before I start? Alright, I resurrected your branch to the best of my understanding. I hope it's more Lazarus than Reanimator.

Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?

2015-03-20 Thread Barry Warsaw
On Mar 20, 2015, at 04:39 PM, Aurelien Bompard wrote: Alright, I resurrected your branch to the best of my understanding. I hope it's more Lazarus than Reanimator. https://code.launchpad.net/~abompard/mailman/subpolicy All tests pass, but there's still a missing part: the new attribute in the

Re: [Mailman-Developers] How do I turn on/off moderation of subscription requests?

2015-03-06 Thread Andrew Stuart
@barry - after digging around further I found Aurelien had the same question a while back http://comments.gmane.org/gmane.mail.mailman.devel/19301 I also found a message from you in Dec 2014 (can’t find it now after a few minutes digging….ugh) saying that currently it’s not possible to create