Re: [Mailman-Users] Approved: password header!

2009-08-10 Thread John W. Baxter
On 8/6/09 9:08 PM, Mark Sapiro m...@msapiro.net wrote: Thus, the idea of allowing [Approved: password] in the subject header and removing only that text from the subject has appeal because it doesn't depend on any characteristics of the message body. Won't work in an environment in which

Re: [Mailman-Users] Approved: password header!

2009-08-07 Thread Barry Warsaw
On Aug 7, 2009, at 12:08 AM, Mark Sapiro wrote: The idea is to require the square brackets so a mere approved: in the subject (such as this message) doesn't trigger a match. We only match if we find Approve: or Approved: followed by a single word inside the square brackets and then we remove

Re: [Mailman-Users] Approved: password header!

2009-08-07 Thread Barry Finkel
Barry Warsaw ba...@python.org wrote: As a comparison, Launchpad's code review process allows for commands in the body of the message. It looks for specific commands prepended by a space. I don't particularly like that approach though because the space can be hard to see. Would it find a

Re: [Mailman-Users] Approved: password header!

2009-08-07 Thread Khalil Abbas
stuff.. Thanks .. Date: Thu, 6 Aug 2009 13:59:49 -0700 From: m...@msapiro.net To: khillo...@hotmail.com; mailman-users@python.org Subject: Re: [Mailman-Users] Approved: password header! Khalil Abbas wrote: my suggestion is, before I had the honor to use outlook I had

Re: [Mailman-Users] Approved: password header!

2009-08-07 Thread Mark Sapiro
Khalil Abbas wrote: well I'm sorry I didn't quite understand, what should I do with this file you sent me (approve.patch.txt) ?? where should I put it and what to name it and what to do with its permissions n stuff? I probably shouldn't tell you because if you don't know how to apply a patch,

Re: [Mailman-Users] Approved: password header!

2009-08-07 Thread Barry Warsaw
On Aug 7, 2009, at 10:59 AM, Barry Finkel wrote: Barry Warsaw ba...@python.org wrote: As a comparison, Launchpad's code review process allows for commands in the body of the message. It looks for specific commands prepended by a space. I don't particularly like that approach though because

[Mailman-Users] Approved: password header!

2009-08-06 Thread Khalil Abbas
Dear Mailman admins, I have a suggestion for you .. I'm running 42 lists for my clients, I let them use microsoft outlook to send their newletters to their customers and I do the management part .. since someone hacked into one of my lists and started posting to it using the modertor's

Re: [Mailman-Users] Approved: password header!

2009-08-06 Thread Mark Sapiro
Khalil Abbas wrote: my suggestion is, before I had the honor to use outlook I had Smartermail .. they have a cool feature of approving messages with passwords is to use it in the subject line itself : [password: PASSWORD] Subject bla bla bla.. then it removes the password part of course ..

Re: [Mailman-Users] Approved: password header!

2009-08-06 Thread Stephen J. Turnbull
Mark Sapiro writes: If your clients insist on posting HTML only messages and can't add an actual Approved: header to the message, then you can try patching Mailman/Handlers/Approve.py to recognize [Approved: password] in the Subject: header. The attached Approve.patch.txt file contains a

Re: [Mailman-Users] Approved: password header!

2009-08-06 Thread Brad Knowles
on 8/6/09 9:14 PM, Stephen J. Turnbull said: I'll consider this as a feature for Mailman 2.2 I think this is unwise. The subject header is read by everybody, and you can't just delete it, so you have to munge it. More complexity. It's not so hard to add an Approved pseudo-header. Some

Re: [Mailman-Users] Approved: password header!

2009-08-06 Thread Mark Sapiro
Brad Knowles wrote: on 8/6/09 9:14 PM, Stephen J. Turnbull said: I'll consider this as a feature for Mailman 2.2 I think this is unwise. The subject header is read by everybody, and you can't just delete it, so you have to munge it. More complexity. It's not so hard to add an Approved