Re: [Mapbuilder-devel] refresh behaviour of MapPaneOL

2007-11-09 Thread olivier.terral
Hi all, the reference to refresh=="sld" can be removed , it was used by the SLD Editor but like said Cameron , Ol guys works on a Openlayers solution. clearWidget2 was created because the refresh of MapPaneOl didn't destroy all the map div component and create 2 OpenlayersViewPort div, this

Re: [Mapbuilder-devel] refresh behaviour of MapPaneOL

2007-11-08 Thread Cameron Shorter
Andreas, your concerns are valid. We should not have SLD special cases in a general widget like MapPaneOL. I assume the sld specific code was introduced during the development of the SLD demo by Olivier and co. Since it looks like the SLD functionality is moving toward OpenLayers it may be appr

Re: [Mapbuilder-devel] refresh behaviour of MapPaneOL

2007-11-08 Thread Andreas Hocevar
Hi, On Nov 9, 2007 12:10 AM, Cameron Shorter <[EMAIL PROTECTED]> wrote: > Looking at your code snippet, (and not the code), I'm guessing that the > clearWidget2 will remove the contents of the widget before redrawing, > which will probably cause an undesirable flicker in most circumstances. Mayb

Re: [Mapbuilder-devel] refresh behaviour of MapPaneOL

2007-11-08 Thread Cameron Shorter
Looking at your code snippet, (and not the code), I'm guessing that the clearWidget2 will remove the contents of the widget before redrawing, which will probably cause an undesirable flicker in most circumstances. Andreas Hocevar wrote: > Hi, > > does anybody know the reason why we do the follo

[Mapbuilder-devel] refresh behaviour of MapPaneOL

2007-11-08 Thread Andreas Hocevar
Hi, does anybody know the reason why we do the following in lib/widget/MapPaneOL.js? 152 if(!objRef.model.map || refresh=="sld"){ 153 154if(refresh=="sld") { 155 objRef.clearWidget2(objRef); 156} IMO the refresh event should always re-parse the model, or am I missing something here