On April 14, 2014, 11:21 p.m., Dennis Nienhüser wrote:
Philippe Renon wrote:
I don't have commit rights so can't ship it :(
I'm just with a smartphone for the next weeks. Can someone push on Philippe's
behalf, please?
- Dennis
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117476/#review56119
---
Ship it!
Ship It!
- Dennis Nienhüser
On April 21, 2014
lineString() to other.lineString() and ideally also Q_ASSERT on
the needsUpdate variables being false both after calling lineString().
Alternatively ignore both variables in the equality check since they provide
redundant data.
- Dennis Nienhüser
On April 7, 2014, 8:45 a.m., Cruceru Calin-Cristian
://git.reviewboard.kde.org/r/117507/#comment39736
How would the user reset the end date (so that m_endDateSet=false) without
editing the config file after changing the end date once?
- Dennis Nienhüser
On April 12, 2014, 10:09 a.m., Marek Hakala wrote
fine. It is deleted in
~GeoDataPlacemarkPrivate which is called from ~GeoDataFeature because the
d-pointer is shared in the class hierarchy. Keeping code complexity low wasn't
high on the priority list of geodata I'm afraid :-P
- Dennis Nienhüser
On May 5, 2014, 9:16 p.m., Cruceru Calin
we developed for business use, utilised the
Marble API, is there any license fees required? I know this is open
source but wasn’t sure if this applied to commercial use.
Thanks
Emma
-Original Message-
From: Dennis Nienhüser [mailto:earthwi...@gentoo.org]
Sent: 06 May 2014 20:03
#include QSharedPointer
missing for Qt 4.8
- Dennis Nienhüser
On June 3, 2014, 12:36 p.m., Adam Dabrowski wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118495
/MarbleWidgetInputHandler.h
https://git.reviewboard.kde.org/r/118495/#comment41269
please change back to 2005
- Dennis Nienhüser
On June 5, 2014, 7:30 a.m., Adam Dabrowski wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
effects it has?
Renaming the methods like this implies that they're not used anywhere and can
be removed altogether. I kind of doubt that, and instead would expect that some
further changes would be needed which change setClipping() calls to
setClipScreen() calls.
- Dennis Nienhüser
On June 13
., Dennis Nienhüser wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118751/
---
(Updated June 15, 2014, 6:53 a.m.)
Review
unused
src/lib/marble/TourPlayback.cpp
https://git.reviewboard.kde.org/r/118755/#comment41878
i've seen this too often now... ;-)
can you add a convenience method
GeoDataAbstractView::coordinates() const which handles this?
- Dennis Nienhüser
On June 15, 2014, 8:09 a.m
---
File Attachments
squad example
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/14/2c98d4b4-129f-4da6-905e-a5b0eb938aa4__marble-squad-interpolation-1.png
Thanks,
Dennis Nienhüser
___
Marble-devel mailing list
Marble
become shorter when you introduce two slots,
updateLinesDialog and updatePolyDialog.
- Dennis Nienhüser
On June 15, 2014, 3:08 p.m., Cruceru Calin-Cristian wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://git.reviewboard.kde.org/media/uploaded/files/2014/06/14/2c98d4b4-129f-4da6-905e-a5b0eb938aa4__marble-squad-interpolation-1.png
Thanks,
Dennis Nienhüser
___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel
://git.reviewboard.kde.org/media/uploaded/files/2014/06/14/2c98d4b4-129f-4da6-905e-a5b0eb938aa4__marble-squad-interpolation-1.png
Thanks,
Dennis Nienhüser
___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel
://git.reviewboard.kde.org/r/118681/#comment42050
i wonder if we should add centerOn() with a latlonbox to MarbleMap as well
(like MarbleWidget provides which calls the very same code as here)
- Dennis Nienhüser
On June 12, 2014, 12:33 a.m., Friedrich W. H. Kossebau wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118720/#review60331
---
Ship it!
Ship It!
- Dennis Nienhüser
On June 13, 2014, 8
and the play button
and the slider next to each other horizontally.
src/lib/marble/geodata/data/GeoDataAbstractView.h
https://git.reviewboard.kde.org/r/118755/#comment42123
please move to the .cpp
- Dennis Nienhüser
On June 17, 2014, 10:16 p.m., Sanjiban Bairagya wrote
a.m.)
Review request for Marble, Dennis Nienhüser and Torsten Rahn.
Repository: marble
Description
---
As inspired by https://git.reviewboard.kde.org/r/118618/ I brushed up the
thumbnailing code I drafted almost 2 years ago in the train on my way back
from the Marble sprint
: The size of the pause icon is larger than the size of the
other icons.
- Dennis Nienhüser
On June 19, 2014, 9:52 a.m., Sanjiban Bairagya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/community/donations/ for type donation?
- Dennis Nienhüser
On June 19, 2014, 9:15 a.m., Andreas Cord-Landwehr wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118832
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118832/#review60830
---
Ship it!
Ship It!
- Dennis Nienhüser
On June 19, 2014, 4
Isn't that the default value which shouldn't be written?
- Dennis Nienhüser
On June 26, 2014, 6:36 a.m., Sanjiban Bairagya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
() == 0;
if( ( changeEmpty != otherChangeEmpty ) {
return false;
} else if( d-m_change other.d-m_change *d-m_change !=
*other.d-m_change ) {
return false;
}
return d-m_targetHref == other.d-m_targetHref;
- Dennis Nienhüser
On June 26, 2014, 8:45 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118943/#review61024
---
Ship it!
Ship It!
- Dennis Nienhüser
On June 26, 2014, 9
for the contents,
but instead have the popup behave similar to what you propose: It's contents
stick to some specified screen position (on top of the map) and only the arrow
tip follows the coordinate.
- Dennis Nienhüser
On June 22, 2014, 7:54 p.m., Bernhard Beschow wrote
On June 28, 2014, 9:38 a.m., Dennis Nienhüser wrote:
Another approach we could go for is not using a dock widget for the
contents, but instead have the popup behave similar to what you propose:
It's contents stick to some specified screen position (on top of the map)
and only
/#comment42588
balloonHidden, balloonShown, see above
src/lib/marble/TourPlayback.h
https://git.reviewboard.kde.org/r/119003/#comment42589
showBalloon( GeoDataPlacemark* )
- Dennis Nienhüser
On June 28, 2014, 7:32 p.m., Sanjiban Bairagya wrote
is to update AnimatedUpdates during
seek().
src/lib/marble/TourPlayback.cpp
https://git.reviewboard.kde.org/r/119003/#comment42591
Qt::AlignRight | Qt::AlignVCenter
- Dennis Nienhüser
On June 28, 2014, 10:21 p.m., Sanjiban Bairagya wrote
://git.reviewboard.kde.org/r/119022/#comment42638
Seems misplaced
src/lib/marble/geodata/data/GeoDataUpdate.h
https://git.reviewboard.kde.org/r/119022/#comment42639
Lets go for getDelete here if delete conflicts with the keyword
- Dennis Nienhüser
On June 29, 2014, 8:09 p.m., Sanjiban Bairagya
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119022/#review61219
---
Ship it!
Ship It!
- Dennis Nienhüser
On June 29, 2014, 8
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119069/#review61432
---
Ship it!
Ship It!
- Dennis Nienhüser
On July 1, 2014, 4
change the signature to const
QByteArray , const QString above)
- Dennis Nienhüser
On July 5, 2014, 6:25 p.m., Abhinav Gangwar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
://git.reviewboard.kde.org/r/116525/#comment43001
const QByteArray , const QString
note the for passing as a reference
- Dennis Nienhüser
On July 7, 2014, 4:03 a.m., Abhinav Gangwar wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119273/#review62331
---
Ship it!
Ship It!
- Dennis Nienhüser
On July 14, 2014, 4
will still be played, following the already gone route.
src/lib/marble/routing/RoutingWidget.cpp
https://git.reviewboard.kde.org/r/119448/#comment43841
Please remove, causes a wrong icon on the very first play click.
- Dennis Nienhüser
On July 24, 2014, 3:25 p.m., Sanjiban Bairagya wrote
anymore.
- Dennis Nienhüser
On July 26, 2014, 6:54 p.m., Sanjiban Bairagya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119448
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119354/#review64115
---
Ship it!
(on behalf of Torsten)
- Dennis Nienhüser
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119688/#review64172
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 10, 2014, 10
highlight
- Dennis Nienhüser
On Aug. 10, 2014, 12:39 p.m., Abhinav Gangwar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118717
inside the if (!m_writingPossible) {
m_recorder-startRecording();
}
block
- Dennis Nienhüser
On Aug. 10, 2014, 8:43 p.m., Sanjiban Bairagya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
is finished: Progress
set to 100 (currently goes up to 99% only), button text back to Start, and
possibly some (green?) message Video export completed. in the bottom left
label.
- Dennis Nienhüser
On Aug. 10, 2014, 9:12 p.m., Sanjiban Bairagya wrote
Hi,
catchy subject to get your attention :-)
Albert just posted a nice overview [0] of planned changes to KDE
releases which affect Marble as well. In light of that I'd like to
propose the following changes:
- switch master from KDE 4 to KDE Frameworks 5 (no backward compatibility)
- have the
, thanks for your work on it. The patch however
is growing **huge** and I see no possibility for a sane review. At the same
time I spot several architectural issues that must be addressed as soon as
possible. Can we have an IRC meeting or similar to discuss this?
Regards,
Dennis
- Dennis Nienhüser
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119922/#review65147
---
Ship it!
Looks good.
- Dennis Nienhüser
On Aug. 24, 2014
/marble/MarbleModel.h
https://git.reviewboard.kde.org/r/120013/#comment45829
let's call it setMapTheme
- Dennis Nienhüser
On Aug. 31, 2014, 10:04 a.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply
://git.reviewboard.kde.org/r/119982/#comment45837
from QFileInfo docs I assume calling endsWith is identical to calling
operator==, no?
- Dennis Nienhüser
On Aug. 28, 2014, 8:57 p.m., Thibaut Gridel wrote:
---
This is an automatically generated e
, or it will be casted whatsoever.
src/lib/marble/layers/GeometryLayer.cpp
https://git.reviewboard.kde.org/r/118717/#comment46114
Is this the right place to put this comment? Shouldn't it be where
MarbleMap connects the signal?
- Dennis Nienhüser
On Aug. 21, 2014, 12:49 p.m., Abhinav Gangwar wrote
Hi,
our current Windows package installs a 32 bit version of Marble using Qt
4.8. As an alternative to that I've setup an installer that installs a
64 bit version using Qt 5.3. You can download it from [0]. If you give
it a try, please report back if it works for you or not. I'd like to
move
Hi Paul,
does it work with Marble 1.9.1? It is available for download at
http://localhost/marble-kde-org/install.php
Regards,
Dennis
Am 01.09.2014 04:54, schrieb VM2014:
In the new version Marble 1.9.0 for Windows, the application does not
download the maps from the internet. Even manually
Hi Martin,
I see the problem you're facing and appreciate the work you put into the
patch. However I am concerned about maintaining (read: not breaking) it
in the future.
The real problem IMHO is that Qt does not (really) use namespaces in the
first place. The ability to change that
Am 26.09.2014 05:37, schrieb Dennis Nienhüser:
Hi Paul,
does it work with Marble 1.9.1? It is available for download at
http://localhost/marble-kde-org/install.php
lol... if you happen to own my computer, that is. I meant
https://marble.kde.org/install.php
of course.
Regards,
Dennis
Hi Tom,
you're right, the addGeoDataFile() method is a convenience method doing
several things at once:
- load the file in some thread in the background
- when the data is extracted successfully, show it
- center the view on the bounding area of the data
Since you'd rather have synchronous
Hi,
this year's GCI contest will run from December 1st to January 19th. KDE
might be among the participating organizations, so we'd have the chance
to get some nice things done again. In the previous years we got very
nice contributions from GCI, so I'll volunteer as a mentor again and
hope
setting that?
- Dennis Nienhüser
On Sept. 9, 2014, 3:57 p.m., Abhinav Gangwar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118717
of the dialog. Can you
set a grid layout for MonavConfigWidget also?
- Dennis Nienhüser
On Oct. 28, 2014, 9:19 a.m., Mihir Thakkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120797
here or in #marble in IRC.
Regards,
Dennis
Am 20.10.2014 02:32, schrieb Dennis Nienhüser:
Hi,
this year's GCI contest will run from December 1st to January 19th.
KDE might be among the participating organizations, so we'd have the
chance to get some nice things done again. In the previous years
://git.reviewboard.kde.org/r/121370/#comment49867
This is not correct for the linearring case.
src/plugins/runner/pn2/Pn2Runner.cpp
https://git.reviewboard.kde.org/r/121370/#comment49868
See above
- Dennis Nienhüser
On Dez. 6, 2014, 6:21 nachm., Illya Kovalevskyy wrote
afterwards on theme changes?)
- Dennis Nienhüser
On Dec. 6, 2014, 9:04 p.m., Illya Kovalevskyy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121362
that are handled by the geometry layer itself and not
known to the graphics scene.
- Dennis Nienhüser
On Dec. 7, 2014, 12:40 p.m., Illya Kovalevskyy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://git.reviewboard.kde.org/r/121395/#comment49992
why grayish and not plain white (255)?
- Dennis Nienhüser
On Dec. 10, 2014, 10:32 a.m., Illya Kovalevskyy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
Hi Torsten,
please go for it! I can tell you firsthand that it's going to be a
unique and awesome trip :-)
Regards,
Dennis
Am 31.01.2015 09:01, schrieb Valorie Zimmerman:
Hello Marble mentors,
The GCi admins have agreed that you Marble admins deserve this
invitation. Please discuss among
Hi there,
summer is approaching slowly and there'll be another Google Summer of
Code. We're slightly late already to add project ideas to
https://community.kde.org/GSoC/2015/Ideas#Marble - if you have something
in mind and want to mentor, now is the time to discuss and add project
ideas
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121827/#review73087
---
Ship it!
Ship It!
- Dennis Nienhüser
On Jan. 4, 2015, 1
::polygonTest() in
tests/TestEquality.cpp such that it fails unless your patch is applied?
- Dennis Nienhüser
On March 8, 2015, 8:01 a.m., Boris Egorov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/geodata/data/GeoDataLatLonBox.h (line 110)
https://git.reviewboard.kde.org/r/123180/#comment53595
Given the possible confusion whether input and output are radians or
degrees I'd favor separate doxygen documentation for this and the two next
methods.
- Dennis Nienhüser
On March 30, 2015, 11
documentation.
- Dennis Nienhüser
On March 30, 2015, 11:30 a.m., Adam Dabrowski wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123181
clicking on it.
- Dennis Nienhüser
On March 30, 2015, 11:35 a.m., Adam Dabrowski wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123182
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123193/#review78286
---
Ship it!
Ship It!
- Dennis Nienhüser
On März 31, 2015, 8
)
https://git.reviewboard.kde.org/r/123202/#comment53626
redundant
- Dennis Nienhüser
On April 1, 2015, 6:41 a.m., Adam Dabrowski wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org
changes the mail
address in a header (one is enough) to your company one? Just to prove the
connection between the two.
- Dennis Nienhüser
On April 1, 2015, 6:58 a.m., Adam Dabrowski wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123205/#review78327
---
Ship it!
Ship It!
- Dennis Nienhüser
On April 1, 2015, 7
On April 1, 2015, 12:37 p.m., Dennis Nienhüser wrote:
Can you do one review request from your gmail account which changes the
mail address in a header (one is enough) to your company one? Just to prove
the connection between the two.
Adam Dabrowski wrote:
I am not sure what you
Hi Simon,
first of a big thank you for creating and maintaining the Python
bindings for Marble over the years! I just read that you are now looking
for a new maintainer for PyKDE5 [1]. While I don't see myself step up to
that position I'd still be interested to learn about the technical
Hi Dávid, Marius
thanks for your work! When you write commit messages, please always add
descriptive log messages, not just the review ID, and make sure the
second line (if there is one) is empty. See [1] and [2]. When you use
keywords like the review ID (which is good), follow the template
On March 30, 2015, 1:59 p.m., Dennis Nienhüser wrote:
src/lib/marble/PlacemarkLayout.cpp, line 43
https://git.reviewboard.kde.org/r/123181/diff/1/?file=359472#file359472line43
I'd call it `hasRoomFor` for readability and pass both parameters as
const references for performance
with at the moment, but
the problems with plugin loading sound like a must-fix before shipping. Got
some details on it? Do some plugins load, or none? Is it related to the qt
version?
- Dennis Nienhüser
On Feb. 26, 2015, 6:50 nachm., Rex Dieter wrote
On Feb. 28, 2015, 4:06 p.m., Dennis Nienhüser wrote:
Makes sense generally. I do not have a system to test with at the moment,
but the problems with plugin loading sound like a must-fix before shipping.
Got some details on it? Do some plugins load, or none? Is it related to the
qt
In which case is the current index not valid? If this should not happen
really, I'd rather do nothing in that case.
- Dennis Nienhüser
On Feb. 26, 2015, 12:38 p.m., Marius Stanciu wrote:
---
This is an automatically generated e-mail
selection of the user.
- Dennis Nienhüser
On Feb. 27, 2015, 8:14 p.m., Marius Stanciu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122747
settings then).
- Dennis Nienhüser
On Feb. 25, 2015, 8:51 p.m., Marius Stanciu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122725
://git.reviewboard.kde.org/r/122686/#comment52878
Universal Transverse Mercator (UTM)
(note the additional space)
- Dennis Nienhüser
On Feb. 25, 2015, 10:03 a.m., Marius Stanciu wrote:
---
This is an automatically generated e-mail. To reply
/#comment54597
Please use curly brackets also for one liners and include the url in the
qdebug output.
- Dennis Nienhüser
On April 22, 2015, 6:28 vorm., Ana Badescu wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123343/#review79746
---
Ship it!
Ship It!
- Dennis Nienhüser
On April 27, 2015, 8
/123579/#comment54650
the the = the
src/lib/marble/geodata/data/GeoDataCoordinates.cpp (line 1509)
https://git.reviewboard.kde.org/r/123579/#comment54651
uninitilized = uninitialized
- Dennis Nienhüser
On May 2, 2015, 6:57 p.m., Alejandro García Montoro wrote
On May 3, 2015, 10:10 a.m., Dennis Nienhüser wrote:
src/lib/marble/geodata/data/GeoDataCoordinates.h, line 380
https://git.reviewboard.kde.org/r/123579/diff/2/?file=365494#file365494line380
These are not used outside GeoDataCoordinates, right? I'd move them
On May 6, 2015, 8:27 p.m., Torsten Rahn wrote:
Guys, for the refactoring also keep in mind that we should also support the
MGRS system one day ...
Please be more specific :-)
- Dennis
---
This is an automatically generated
On June 1, 2015, 3:52 p.m., Dennis Nienhüser wrote:
Ship It!
Gilbert Assaf wrote:
This RB request is still open. Anything wrong?
Nope, all fine :-) I'll commit on your behalf shortly.
- Dennis
---
This is an automatically
On June 15, 2015, 8:23 p.m., Dennis Nienhüser wrote:
src/plugins/render/annotate/AnnotatePlugin.cpp, line 354
https://git.reviewboard.kde.org/r/124099/diff/1/?file=379892#file379892line354
why not?
Marius Stanciu wrote:
not sure if it's my machine's fault or not, or if it's
/#comment56066
where is all the work done?
- Dennis Nienhüser
On June 25, 2015, 6:16 p.m., Ana Badescu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124182
naming things NullFoo, VoidFoo or DummyFoo instead of FooQtNoWebkit.
So we'd have a NullWebBrowser, for example.
- Dennis Nienhüser
On June 27, 2015, 7:22 a.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply
://git.reviewboard.kde.org/r/124189/#comment56124
is this a temporary thing? What is wrong with render plugins?
What about the webkit related changes from the older review request?
- Dennis Nienhüser
On Juni 26, 2015, 6:56 nachm., Gábor Péterffy wrote
for the empty block.
- Dennis Nienhüser
On June 10, 2015, 7:35 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124064
On June 12, 2015, 2:14 a.m., Torsten Rahn wrote:
src/lib/marble/MarbleLegendBrowser.cpp, line 411
https://git.reviewboard.kde.org/r/124064/diff/1/?file=379492#file379492line411
Eeeeww - gutting the MarbleLegendBrowser and providing an alternative
empty implementation this way
)
https://git.reviewboard.kde.org/r/124099/#comment55863
why not?
- Dennis Nienhüser
On Juni 14, 2015, 8:46 nachm., Marius Stanciu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org
Am 24.05.2015 20:05, schrieb Dennis Nienhüser:
I'd suggest to merge it to master now and fix
any remaining issues there. Please bring up any concerns with that
here within the next days, otherwise I'll go ahead.
Here we go... commit cf11588 is a squashed commit of the
kde-frameworks-5 branch
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123917/#review81052
---
Ship it!
Ship It!
- Dennis Nienhüser
On May 27, 2015, 3
(MarbleCPackOptions)
On 24 May 2015 at 11:30, Dennis Nienhüser earthwi...@gentoo.org
wrote:
Hi Jaroslaw,
Am 24.05.2015 00:10, schrieb Jaroslaw Staniek:
On 23 May 2015 at 15:39, Dennis Nienhüser earthwi...@gentoo.org
wrote:
Hi Jaroslaw,
Am 23.05.2015 00:43, schrieb Jaroslaw Staniek:
The only thing
On June 29, 2015, 2:16 p.m., Torsten Rahn wrote:
Hi Ana,
Thanks for your review request on the tests.
Some thoughts on improvements:
- Why did you attach the tests as a diff instead of adding them to the
review request? :-) ?
- Please add some more corner cases for the test
Android developer dashboard)
- Dennis Nienhüser
On July 5, 2015, 9:33 a.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124259
1 - 100 of 281 matches
Mail list logo
