Re: [matplotlib-devel] [PATCH 0/2] remove unused code

2015-04-20 Thread Thomas Caswell
Kelvin, Thank you for your work. Would it be possible for you to open a pull request on git hub with these changes (that is where we so almost all of our code review recently and is hooked in to a continuous integration service). I have not looked at the diff yet (still on my phone), but from

[matplotlib-devel] [PATCH 2/2] backends: remove unnecessary import statements

2015-04-20 Thread Kelvin Li
--- lib/matplotlib/backends/backend_agg.py | 2 -- lib/matplotlib/backends/backend_cairo.py | 5 ++-- lib/matplotlib/backends/backend_gdk.py | 9 --- lib/matplotlib/backends/backend_gtk.py | 7 +++-- lib/matplotlib/backends/backend_gtk3agg.py | 1 -

[matplotlib-devel] [PATCH 0/2] remove unused code

2015-04-20 Thread Kelvin Li
First ever patch submission. Here I propose cleaning up some unused variables and imports. Kelvin Li (2): remove unused variable cmd_split backends: remove unnecessary import statements lib/matplotlib/backends/backend_agg.py | 2 -- lib/matplotlib/backends/backend_cairo.py |

[matplotlib-devel] [PATCH 1/2] remove unused variable cmd_split

2015-04-20 Thread Kelvin Li
--- lib/matplotlib/backends/backend_ps.py | 3 --- lib/matplotlib/texmanager.py | 6 -- 2 files changed, 9 deletions(-) diff --git a/lib/matplotlib/backends/backend_ps.py b/lib/matplotlib/backends/backend_ps.py index cea707d..699d1ba 100644 ---