Re: [PATCH] mc crashes when temporary directory cannot be created

2007-01-02 Thread Jindrich Novy
Hi Pavel, On Sat, 2006-12-30 at 20:51 +0200, Pavel Tsekov wrote: There is an even simpler cure. In mc_tmpdir() when executing the fallback code pass an absolute path to mc_mkstemps(). This will prevent the loop. However I am not yet conviced that this is the best solution. I am still

Re: [PATCH] mc crashes when temporary directory cannot be created

2007-01-02 Thread Pavel Tsekov
Hello, On Tue, 2 Jan 2007, Jindrich Novy wrote: On Sat, 2006-12-30 at 20:51 +0200, Pavel Tsekov wrote: There is an even simpler cure. In mc_tmpdir() when executing the fallback code pass an absolute path to mc_mkstemps(). This will prevent the loop. However I am not yet conviced that this

Re: [PATCH] mc crashes when temporary directory cannot be created

2007-01-02 Thread Jindrich Novy
Hi Pavel, On Tue, 2007-01-02 at 16:28 +0200, Pavel Tsekov wrote: On Tue, 2 Jan 2007, Jindrich Novy wrote: On Sat, 2006-12-30 at 20:51 +0200, Pavel Tsekov wrote: There is an even simpler cure. In mc_tmpdir() when executing the fallback code pass an absolute path to mc_mkstemps(). This

Re: [PATCH] mc crashes when temporary directory cannot be created

2007-01-02 Thread Pavel Tsekov
Hello, On Tue, 2 Jan 2007, Jindrich Novy wrote: On Tue, 2007-01-02 at 16:28 +0200, Pavel Tsekov wrote: On Tue, 2 Jan 2007, Jindrich Novy wrote: On Sat, 2006-12-30 at 20:51 +0200, Pavel Tsekov wrote: There is an even simpler cure. In mc_tmpdir() when executing the fallback code pass an

Re: [PATCH] mc crashes when temporary directory cannot be created

2007-01-02 Thread Pavel Tsekov
On Tue, 2 Jan 2007, Jindrich Novy wrote: On Tue, 2007-01-02 at 16:28 +0200, Pavel Tsekov wrote: On Tue, 2 Jan 2007, Jindrich Novy wrote: On Sat, 2006-12-30 at 20:51 +0200, Pavel Tsekov wrote: There is an even simpler cure. In mc_tmpdir() when executing the fallback code pass an absolute path

Re: [PATCH] mc crashes when temporary directory cannot be created

2007-01-02 Thread Jindrich Novy
Hi Pavel, On Tue, 2007-01-02 at 16:48 +0200, Pavel Tsekov wrote: On Tue, 2 Jan 2007, Jindrich Novy wrote: On Tue, 2007-01-02 at 16:28 +0200, Pavel Tsekov wrote: On Tue, 2 Jan 2007, Jindrich Novy wrote: On Sat, 2006-12-30 at 20:51 +0200, Pavel Tsekov wrote: There is an even simpler cure.

Re: [PATCH] mc crashes when temporary directory cannot be created

2007-01-02 Thread Pavel Tsekov
On Tue, 2007-01-02 at 16:53, Jindrich Novy wrote: I am attaching a patch which passes an absolute path to mc_mkstemps() when invoked from mc_tmpdir(). What do you think about this fix ? I may add a comment why it is necessary to call mc_mkstemps() with an absolute path. By the way I

Re: [PATCH] mc crashes when temporary directory cannot be created

2006-12-30 Thread Pavel Tsekov
Hello Jindrich, On Thu, 2006-11-30 at 20:04, Pavel Tsekov wrote: On Wed, 29 Nov 2006, Leonard den Ottolander wrote: Hello Jindrich, On Tue, 2006-11-28 at 13:21 +0100, Jindrich Novy wrote: IMO only removal of the fallback will prevent the infinite loop in any case as it shouldn't call

Re: [PATCH] mc crashes when temporary directory cannot be created

2006-11-30 Thread Jindrich Novy
Hi Leonard, On Wed, 2006-11-29 at 20:59 +0100, Leonard den Ottolander wrote: Hello Jindrich, On Tue, 2006-11-28 at 13:21 +0100, Jindrich Novy wrote: IMO only removal of the fallback will prevent the infinite loop in any case as it shouldn't call mc_mkstemps() at all. That cure seems

Re: [PATCH] mc crashes when temporary directory cannot be created

2006-11-30 Thread Pavel Tsekov
On Wed, 29 Nov 2006, Leonard den Ottolander wrote: Hello Jindrich, On Tue, 2006-11-28 at 13:21 +0100, Jindrich Novy wrote: IMO only removal of the fallback will prevent the infinite loop in any case as it shouldn't call mc_mkstemps() at all. That cure seems worse than the disease. Isn't

Re: [PATCH] mc crashes when temporary directory cannot be created

2006-11-29 Thread Leonard den Ottolander
Hello Jindrich, On Tue, 2006-11-28 at 13:21 +0100, Jindrich Novy wrote: IMO only removal of the fallback will prevent the infinite loop in any case as it shouldn't call mc_mkstemps() at all. That cure seems worse than the disease. Isn't the real problem the fact that mc_mkstemps() blindly

Re: [PATCH] mc crashes when temporary directory cannot be created

2006-11-28 Thread Jindrich Novy
Hi Pavel, On Mon, 2006-11-27 at 17:37 +0200, Pavel Tsekov wrote: Hello Jindrich, On Mon, 27 Nov 2006, Jindrich Novy wrote: there is a breakage in util.c and utilunix.c related to temporary files creation. The problem is that if a directory for temporary files cannot be created mc ends

[PATCH] mc crashes when temporary directory cannot be created

2006-11-27 Thread Jindrich Novy
Hi all, there is a breakage in util.c and utilunix.c related to temporary files creation. The problem is that if a directory for temporary files cannot be created mc ends up in infinite loop caused by: tmpbase = concat_dir_and_file (mc_tmpdir (), prefix); in mc_mkstemps() which then calls

Re: [PATCH] mc crashes when temporary directory cannot be created

2006-11-27 Thread Pavel Tsekov
Hello Jindrich, On Mon, 27 Nov 2006, Jindrich Novy wrote: there is a breakage in util.c and utilunix.c related to temporary files creation. The problem is that if a directory for temporary files cannot be created mc ends up in infinite loop caused by: tmpbase = concat_dir_and_file