Re: GNU Midnight Commander 4.6.2-pre1
Hello Pavel, On Oct 20, 2007, Pavel Tsekov wrote: Hello Caj, Friday, October 19, 2007, 10:35:50 PM, you wrote: On Oct 19, 2007, Pavel Tsekov wrote: If you have a proper patch OK, but if I may just ask why key bindings are so static in mc, is the code very hard to change so that a user could define his/her own bindings for a large part of the configuration and layout? And another question just of curiosity, are the existing patches for these features not good enough for inclusion in the main code? I don't remember right now the details but usually these patches are far for complete or do not fit the rest of the code well. I know that there was a patch which adds as shortcut to change the current sort mode - I do not remember why it wasn't accepted. I'll try to find it in the archives and see what can be done about it. There is a patch in savannah too if I am not mistaken. Regarding the show hidden files key binding - I am not aware of patch which does this. If you can point me to such a patch I'll gladly review it. In any case I am not going to write new code before the 4.6.2 release. I'll review existing patches and will fix ugly bugs. That was just one thing that I had a memory of, but I could be wrong. Regarding the other request, the change sort mode more quickly-thingy, I'd very much like that in mc and I have noted that a few others have requested that feature as well. But, even more, a big improvement would have been to have an overall change in the way the user could configure his/hers keybindings. To simply have many many more actions that could be bound to different keys by the users own wish. -- Best Regards, Caj Zell ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re[2]: GNU Midnight Commander 4.6.2-pre1
Hello Caj, Friday, October 19, 2007, 10:35:50 PM, you wrote: On Oct 19, 2007, Pavel Tsekov wrote: If you have a proper patch OK, but if I may just ask why key bindings are so static in mc, is the code very hard to change so that a user could define his/her own bindings for a large part of the configuration and layout? And another question just of curiosity, are the existing patches for these features not good enough for inclusion in the main code? I don't remember right now the details but usually these patches are far for complete or do not fit the rest of the code well. I know that there was a patch which adds as shortcut to change the current sort mode - I do not remember why it wasn't accepted. I'll try to find it in the archives and see what can be done about it. There is a patch in savannah too if I am not mistaken. Regarding the show hidden files key binding - I am not aware of patch which does this. If you can point me to such a patch I'll gladly review it. In any case I am not going to write new code before the 4.6.2 release. I'll review existing patches and will fix ugly bugs. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
Is there any hope of getting 1. sort order key bindings and 2. key binding for toggling of show hidden files in the upcoming release? -- Best Regards, Caj Zell ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
On Oct 19, 2007, Pavel Tsekov wrote: If you have a proper patch OK, but if I may just ask why key bindings are so static in mc, is the code very hard to change so that a user could define his/her own bindings for a large part of the configuration and layout? And another question just of curiosity, are the existing patches for these features not good enough for inclusion in the main code? /Caj Original-Nachricht Datum: Fri, 19 Oct 2007 16:51:07 +0200 Von: Caj Zell Betreff: Re: GNU Midnight Commander 4.6.2-pre1 Is there any hope of getting 1. sort order key bindings and 2. key binding for toggling of show hidden files in the upcoming release? -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
Hello, Original-Nachricht Datum: Wed, 17 Oct 2007 23:20:06 +0200 Von: David Sterba Betreff: Re: GNU Midnight Commander 4.6.2-pre1 On Fri, Sep 28, 2007 at 11:14:47PM +0200, Pavel Tsekov wrote: I am trying to extract and describe all those changes that happened between 4.6.1 and the current cvs version. can you please write down the changes you've discovered into CVS/mc/NEWS file ? Partial list will be useful too. I've update the NEWS file in CVS but the list is incomplete more changes will be listed soon. If you think that a particular entry could be worded better, please, let me know. Thanks! -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
If you have a proper patch Original-Nachricht Datum: Fri, 19 Oct 2007 16:51:07 +0200 Von: Caj Zell Betreff: Re: GNU Midnight Commander 4.6.2-pre1 Is there any hope of getting 1. sort order key bindings and 2. key binding for toggling of show hidden files in the upcoming release? -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
Hi, On Fri, Sep 28, 2007 at 11:14:47PM +0200, Pavel Tsekov wrote: I am trying to extract and describe all those changes that happened between 4.6.1 and the current cvs version. can you please write down the changes you've discovered into CVS/mc/NEWS file ? Partial list will be useful too. Thanks, dave ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
On Sat, 29 Sep 2007 20:58:13 +0100 Denys Vlasenko [EMAIL PROTECTED] wrote: I found the following issues: Alt-O behavior changes for the worse: 4.6.1: make inactive panel show the same dir as active one 4.6.2: make inactive panel show the .. if we stand on non directory or directory we stand on. I find 4.6.1 behavior more consistent and useful. Alt-I in 4.6.2 works as Alt-O in 4.6.1. I sent a patch which fixes this by adding [skip] and [abort] buttons. In case it was missed, I attach it again now. Applies with some offsets, run-tested. The following code char *msg = g_strconcat(fmt, a, b, (char *)NULL); is short and clearly than the following one: char *msg; int n = strlen(fmt) + strlen(a) + strlen(b) + 1; msg = malloc(n); snprintf(msg, n, fmt, a, b); Regards, Andrew ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
On Sat, Sep 29, 2007 at 01:02:12AM -0500, [EMAIL PROTECTED] wrote: Me wrote: On Thu, Sep 27, 2007 at 11:01:27PM -0500, [EMAIL PROTECTED] wrote: But I am not sure if this is a desirable feature, or not. it is On what grounds? https://savannah.gnu.org/bugs/index.php?13146 just mark the text within mcedit before marking it with the mouse. Interesting. (Checking if this really works, or not ... yes it does ... ) Yes, interesting indeed. Is this documented anywhere? no, as it is more a bug that happens to turn out positive. :) i guess anybody who uses selection in mcedit will figure out quite quickly that any type of syntax highlighting disappears from selected text. making use of this observation is kind of a no-brainer for me. I will open a bug report if that is needed, i don't think it is. the respective bug report is still open and documents the shortcomings extensively. And, yes, we know that indentations in a .c or .h file are to be done with the tab key and to do code indentations with the spacebar is considered as incorrect and bad practice. that's *one* way to view it. you may find https://savannah.gnu.org/bugs/index.php?9631 instructive. But since it is incorrect and bad practice to use the space bar, it would seem to me that very few people will do that [...]. how naive. Then I ask, why is it good to copy the -s into another file with a mouse-copy? The tabs of course ought to be copied. Naturally. we are talking about shift-mouse selections. this selects the *actual screen content* - mcedit is completely ignorant of these actions. proper interaction with the x selection/clipboard is another issue - https://savannah.gnu.org/bugs/index.php?13751 3. If you want to introduce new phenomena in the software, then it is good if these things are documented somewhere. oh, really?! ;-) ps: please cut your word count by ~80%. -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
On Fri, 28 Sep 2007, Pavel Tsekov wrote: Hello, Original-Nachricht Datum: Fri, 28 Sep 2007 22:51:05 +0200 Von: Oswald Buddenhagen Betreff: Re: GNU Midnight Commander 4.6.2-pre1 On Thu, Sep 27, 2007 at 11:01:27PM -0500, [EMAIL PROTECTED] wrote: Notice the -- things in what I just copied? I can kindof see why this was introduced. Presumably, it is an indication that the TAB key has been used while the file from which I copied was being written. yes But I am not sure if this is a desirable feature, or not. it is Oswald, On what grounds? I said I can kindof see why this was introduced. You are saying it not only has some kind of logic behind it that I could kindof see but it is indeed a good idea. Why? If it is a good idea then there is no doubt a good explanation. Jesus, it is written, broke bread with the disciples, as did his forefathers with their families and guests. Nowadays, we chase the bread with a knife, or subject it to a slicing machine. We are more complicated and sophisticated and require lots more technology to deal with the bread. Does our bread taste better or is its nutritional content improved? Does this analogy fit? That is also a good question. I can easily think that, if I want to copy a block of C code from one file to another using the mouse, I would feel quite frustrated if this is what actually happens with every line where the tab key got used. just mark the text within mcedit before marking it with the mouse. Interesting. (Checking if this really works, or not ... yes it does ... ) Yes, interesting indeed. Is this documented anywhere? but yes, this needs a fix. ctrl-w was supposed to toggle this *temporarily*, just like ctrl-s toggles syntax highlighting (not temporarily, which is a bug, imo). more on this can be found in the respective patch tracker entry. Are these key combinations documented anywhere? I have looked rather carefully and I have not found any mention of them in the man page for mcedit, nor in the F1 help for mcedit, nor in the pulldown menus which the F1 help says to look at, nor in the Syntax file which users are encouraged in the F1 help to look at, nor in the c.syntax file in /usr/share/mc/syntax. Is the documentation in some other location which I should have checked? I'll fix these... I just need some time. I am trying to extract and describe all those changes that happened between 4.6.1 and the current cvs version. I am also trying to fix the copyright notices in all files. You can open an bug report in the tracker if you want... Pavel, I can understand your problems, as in a small way I have to deal with similar things occasionally, and I am not even one of the project leaders over at gphoto. So by all means take the appropriate time and get it all right. One never shoots at the piano player, because then the music stops. I will open a bug report if that is needed, so you can be the judge about that. Or Oswald could do it. As he was so kind as to answer my questions, he may be much more knowledgeable and closer to the MC project than I am. OTOH there is the perhaps deeper question about whether one is dealing with a bug or a feature, which is the focus of what follows. For, if it is a feature then it is no bug, though it still may be or may not be a feature in need of some improvement. I do have some (possibly naive) things to say about this, though, purely as a user. Perhaps someone with sufficient knowledge _and_ with the time to answer could address these things. Therefore, what follows is directed to the list, not to the maintainer and release manager who may be at this point up to his ass in alligators and not have time to think about much of anything at all except impending deadlines. 1. Perhaps the --- stuff for tabs is good. Me, I liked better the old syntax which used a red, colored bar but that I did not see except in a Makefile. I mean, there was no particular syntax construction to distinguish a tab or two from the repeated use of the spacebar if one was looking at a .c or .h file. And, yes, we know that indentations in a .c or .h file are to be done with the tab key and to do code indentations with the spacebar is considered as incorrect and bad practice. But since it is incorrect and bad practice to use the space bar, it would seem to me that very few people will do that (and sinners and ignoramuses will get caught and educated by the project manager the first time that they submit code, as happened to me a few years ago). So why is it exactly needed to put into an editor a special mark showing that the tab has been used? As I said, I can see why it might be thought a clever feature, but is it actually necessary? And if not necessary is it desirable? Mind, I do not have the answers nor claim to have the answers. I am merely asking the questions. I hope I am not stomping on the toes of someone, just by asking
Re: GNU Midnight Commander 4.6.2-pre1
On Thursday 13 September 2007 09:30, Pavel Tsekov wrote:
Hello,
I've prepared the fist pre-release of GNU Midnight Commander 4.6.2 . Please,
download it and give it a try.
I found the following issues:
Alt-O behavior changes for the worse:
4.6.1: make inactive panel show the same dir as active one
4.6.2: make inactive panel show the .. if we stand on non directory
or directory we stand on.
I find 4.6.1 behavior more consistent and useful.
F5-copying a file on itself bring Error: FILE and FILE are the same file
without buttons. Pressing ESC dismisses it
But if you did this on a big directory (e.g. kernel source tree),
you will get Error: FILE2 and FILE2 are the same file, then
Error: FILE3 and FILE3 are the same file
Error: FILE91476981243 and FILE91476981243 are the same file
...
without the possibility to stop the stream of messages.
mc insists on making you see them all.
On big directory, you may need to hold ESC depressed for minutes
in order to dismiss them all.
I sent a patch which fixes this by adding [skip] and [abort] buttons.
In case it was missed, I attach it again now. Applies with some offsets,
run-tested.
I am pleased with some new and improved features. For example, Find file
how has [x] Regular expression. Good work, thanks!
--
vda
diff -urpN mc-4.6.1.org/src/file.c mc-4.6.1.cp/src/file.c
--- mc-4.6.1.org/src/file.c 2005-05-27 16:19:18.0 +0200
+++ mc-4.6.1.cp/src/file.c 2007-05-18 16:00:23.0 +0200
@@ -458,6 +458,25 @@ enum {
DEST_FULL /* Created, fully copied */
};
+static int warn_same_file(const char *fmt, const char *a, const char *b)
+{
+char *msg;
+/* We don't expect %d etc, just %s, so strlen(fmt) should be ok */
+int n = strlen(fmt) + strlen(a) + strlen(b) + 1;
+
+msg = malloc(n);
+if (msg) {
+ snprintf(msg, n, fmt, a, b);
+ n = query_dialog (MSG_ERROR, msg,
+ D_ERROR, 2, _(Skip), _(Abort));
+ free(msg);
+ do_refresh ();
+ if (n) /* 1 == Abort */
+ return FILE_ABORT;
+}
+return FILE_SKIP;
+}
+
int
copy_file_file (FileOpContext *ctx, const char *src_path, const char *dst_path,
int ask_overwrite, off_t *progress_count,
@@ -512,12 +531,9 @@ copy_file_file (FileOpContext *ctx, cons
if (dst_exists) {
/* Destination already exists */
- if (sb.st_dev == sb2.st_dev sb.st_ino == sb2.st_ino) {
- message (1, MSG_ERROR,
- _( `%s' and `%s' are the same file ), src_path, dst_path);
- do_refresh ();
- return FILE_SKIP;
- }
+ if (sb.st_dev == sb2.st_dev sb.st_ino == sb2.st_ino)
+ return warn_same_file(_( `%s' and `%s' are the same file ),
+src_path, dst_path);
/* Should we replace destination? */
if (ask_overwrite) {
@@ -1043,22 +1059,8 @@ move_file_file (FileOpContext *ctx, cons
if (mc_lstat (d, dst_stats) == 0) {
if (src_stats.st_dev == dst_stats.st_dev
- src_stats.st_ino == dst_stats.st_ino) {
- int msize = COLS - 36;
- char st[MC_MAXPATHLEN];
- char dt[MC_MAXPATHLEN];
-
- if (msize 0)
- msize = 40;
- msize /= 2;
-
- strcpy (st, path_trunc (s, msize));
- strcpy (dt, path_trunc (d, msize));
- message (1, MSG_ERROR,
- _( `%s' and `%s' are the same file ), st, dt);
- do_refresh ();
- return FILE_SKIP;
- }
+ src_stats.st_ino == dst_stats.st_ino)
+ return warn_same_file(_( `%s' and `%s' are the same file ), s, d);
if (S_ISDIR (dst_stats.st_mode)) {
message (1, MSG_ERROR,
@@ -1161,22 +1163,8 @@ move_dir_dir (FileOpContext *ctx, const
} else
destdir = concat_dir_and_file (d, x_basename (s));
-if (sbuf.st_dev == dbuf.st_dev sbuf.st_ino == dbuf.st_ino) {
- int msize = COLS - 36;
- char st[MC_MAXPATHLEN];
- char dt[MC_MAXPATHLEN];
-
- if (msize 0)
- msize = 40;
- msize /= 2;
-
- strcpy (st, path_trunc (s, msize));
- strcpy (dt, path_trunc (d, msize));
- message (1, MSG_ERROR,
- _( `%s' and `%s' are the same directory ), st, dt);
- do_refresh ();
- return FILE_SKIP;
-}
+if (sbuf.st_dev == dbuf.st_dev sbuf.st_ino == dbuf.st_ino)
+ return warn_same_file(_( `%s' and `%s' are the same directory ), s, d);
/* Check if the user inputted an existing dir */
retry_dst_stat:
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
Pavel,
I have tested this release and it does seem to remedy the search bug in
the internal editor. Thanks.
I do have one other question, though. You noticed, probably, that I tried
just now to answer someone's question about how to use the extension file
in MC. I hope I answered his question, but here is one of my own, given
rise to by what I just sent to the other gentleman.
To write my reply to him I mouse-copied something from another window.
Here is the actual result of the mouse-copying, which I edited afterward
to make it look decent.
include/image
#-Open=if [ $DISPLAY = ]; then zgv %f; else (gqview %f ); fi
--Open=if [ $DISPLAY = ]; then zgv %f; else (/usr/bin/display
%f );
#-Open=display %f.
--View=%view{ascii} identify %f
--#View=%view{ascii} asciiview %f
Notice the -- things in what I just copied? Well, I edited them out
in the other letter, just now.
I can kindof see why this was introduced. Presumably, it is an indication
that the TAB key has been used while the file from which I copied was
being written. But I am not sure if this is a desirable feature, or not. I
can easily think that, if I want to copy a block of C code from one file
to another using the mouse, I would feel quite frustrated if this is what
actually happens with every line where the tab key got used.
Another example follows, an excerpt from
libgphoto2/camlibs/digigr8/library.c opened with F3 (view)
{Vivitar Vivicam35, GP_DRIVER_STATUS_EXPERIMENTAL, 0x2770,
0x905c},
{Praktica Slimpix,GP_DRIVER_STATUS_EXPERIMENTAL, 0x2770,
0x905c},
{ZINA Mini Digital Keychain Camera,
GP_DRIVER_STATUS_EXPERIMENTAL,
0x2770,
0x905c},
{Pixie Princess Jelly-Soft,GP_DRIVER_STATUS_EXPERIMENTAL,
0x2770,
0x905c},
{Disney pix micro,GP_DRIVER_STATUS_EXPERIMENTAL, 0x2770,
0x9050},
{Suprema Digital Keychain Camera,
GP_DRIVER_STATUS_EXPERIMENTAL,
0x2770,
0x913d},
OK, I was viewing the file, not editing it, so it seems that all worked as
it should. Now I open the same file with F4 and copy approximately the
same lines...
--{Nexxtech Mini Digital Camera, GP_DRIVER_STATUS_EXPERIMENTAL,
0x2770,.
--0x905c},
{Vivitar Vivicam35, GP_DRIVER_STATUS_EXPERIMENTAL, 0x2770,
0x905c},
{Praktica Slimpix,GP_DRIVER_STATUS_EXPERIMENTAL, 0x2770,
0x905c},
{ZINA Mini Digital Keychain Camera,
GP_DRIVER_STATUS_EXPERIMENTAL,.
--0x2770,
0x905c},
{Pixie Princess Jelly-Soft,GP_DRIVER_STATUS_EXPERIMENTAL,.
--0x2770,
0x905c},
{Disney pix micro,GP_DRIVER_STATUS_EXPERIMENTAL, 0x2770,
0x9050},.
{Suprema Digital Keychain Camera,
GP_DRIVER_STATUS_EXPERIMENTAL,.
0x2770,
0x913d},
--{NULL,0,0,0}
You see what I mean? Ouch. If this were a real piece of C code I would
really be having fun now, wouldn't I?
I guess there are times when it might be nice to have this as a feature. I
can not think of any, but I am sure that somebody thought it is a good
idea. So it would be really nice if there is a way to turn this on or off
at will. Or, maybe, it was not such a good idea in the first place. It
must be in some syntax file, but which and where?
Incidentally, I must also say that I am not sure where this all came from.
I was previously using the standard Slack 12.0 package called
mc-4.6.1_20070309-i486-2.tgz
which had the search bug in it.
Another place I saw a dramatic difference was in looking at a Makefile.
One used to see there a bar of red if a line started with a tab. Now, it
is the -- thing again. So it looks weird if one was accustomed
to the other way. And, again, to copy with the mouse leads to
funny-looking things happening which it seems to me ought not to happen.
Comments? Suggestions?
Theodore Kilgore
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
Original-Nachricht Datum: Thu, 13 Sep 2007 16:21:35 -0400 Von: Miguel de Icaza Betreff: Re: GNU Midnight Commander 4.6.2-pre1 Hello Pavel, Do you have a list of changes in this release? No. It's all in the ChangeLog files anyway. This is release is mostly a bugfix release and some new features. Perhaps I could compile a list of changes if I get some free time... -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
GNU Midnight Commander 4.6.2-pre1
Hello, I've prepared the fist pre-release of GNU Midnight Commander 4.6.2 . Please, download it and give it a try. I've been waiting for several days to get access to ftp.gnu.org so that I can upload the pre-release there, but it seems like it's going to take a while. I am not willing to hold this pre-release any longer so I've uploaded it to my private web space - you can get it from there: http://ptsekov.fixity.net/mc/mc-4.6.2-pre1.tar.gz http://ptsekov.fixity.net/mc/mc-4.6.2-pre1.tar.gz.asc Once I have access to ftp.gnu.org I'll upload there too. Alternatively, you can fetch it from cvs - use the MC_4_6_2_pre1 tag. Thanks! P.S. The public key fingerprint is: 611B 04F9 776E E02B 4AA3 5192 140E C4C2 85DA C198 The public key id is: 85DAC198 -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: GNU Midnight Commander 4.6.2-pre1
Hello Pavel, Do you have a list of changes in this release? Hello, I've prepared the fist pre-release of GNU Midnight Commander 4.6.2 . Please, download it and give it a try. I've been waiting for several days to get access to ftp.gnu.org so that I can upload the pre-release there, but it seems like it's going to take a while. I am not willing to hold this pre-release any longer so I've uploaded it to my private web space - you can get it from there: http://ptsekov.fixity.net/mc/mc-4.6.2-pre1.tar.gz http://ptsekov.fixity.net/mc/mc-4.6.2-pre1.tar.gz.asc Once I have access to ftp.gnu.org I'll upload there too. Alternatively, you can fetch it from cvs - use the MC_4_6_2_pre1 tag. Thanks! P.S. The public key fingerprint is: 611B 04F9 776E E02B 4AA3 5192 140E C4C2 85DA C198 The public key id is: 85DAC198 ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
