Hi Brian,
On Tuesday, October 18, 2011 17:05:53 Brian Paul wrote:
This was brought up a few weeks ago by someone else. I had posted the
start of a patch to fix it. I'm attaching an updated version that I
think is pretty clean. But there's a few lines missing and it's
totally untested.
Looks good to me.
Bryan
On 10/18/2011 05:20 PM, Kenneth Graunke wrote:
Setting MaxIfDepth to UINT_MAX effectively means don't lower anything.
Explicitly checking for this common case allows us to avoid walking the
IR, computing nesting levels, and so on.
Signed-off-by: Kenneth Graunke
Missed this back in the arb_robustness branch
6b329b9274b18c50f4177eef7ee087d50ebc1525.
---
src/mesa/main/texgetimage.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
index f911886..e6edb45 100644
---
The return value here is a) always zero, b) never used.
---
src/mesa/main/image.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/src/mesa/main/image.c b/src/mesa/main/image.c
index 7d95dd6..ca5771c 100644
--- a/src/mesa/main/image.c
+++ b/src/mesa/main/image.c
@@
NULL as an error indicator is meaningless, since it will return NULL
on success anyway if the caller passes in zero as the image's address
and asks to calculate the offset of the first pixel. For example,
_mesa_validate_pbo_access() does this.
This also matches the code in the non-GL_BITMAP
---
src/mesa/main/image.c | 67
src/mesa/main/image.h |7 +
2 files changed, 57 insertions(+), 17 deletions(-)
diff --git a/src/mesa/main/image.c b/src/mesa/main/image.c
index 3e0ca05..ba66c8a 100644
--- a/src/mesa/main/image.c
+++
This avoids forming invalid pointers needlessly, which even if
never dereferenced is undefined behavior. It also makes
_mesa_validate_pbo_access() more comprehensible.
---
src/mesa/drivers/dri/intel/intel_pixel_read.c |5 +++--
src/mesa/main/pbo.c | 25
On 10/19/2011 05:54 AM, nobled wrote:
Missed this back in the arb_robustness branch
6b329b9274b18c50f4177eef7ee087d50ebc1525.
---
src/mesa/main/texgetimage.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
On 10/19/2011 06:02 AM, nobled wrote:
NULL as an error indicator is meaningless, since it will return NULL
on success anyway if the caller passes in zero as the image's address
and asks to calculate the offset of the first pixel. For example,
_mesa_validate_pbo_access() does this.
This also
On 10/19/2011 06:03 AM, nobled wrote:
---
src/mesa/main/image.c | 67
src/mesa/main/image.h |7 +
2 files changed, 57 insertions(+), 17 deletions(-)
Reviewed-by: Brian Paul bri...@vmware.com
On 10/19/2011 06:03 AM, nobled wrote:
This avoids forming invalid pointers needlessly, which even if
never dereferenced is undefined behavior. It also makes
_mesa_validate_pbo_access() more comprehensible.
Reviewed-by: Brian Paul bri...@vmware.com
BTW, be sure to test these changes with the
https://bugs.freedesktop.org/show_bug.cgi?id=41999
Bug #: 41999
Summary: GL_OES_mapbuffer is advertised but calling
glMapBufferOES throws a warning
Classification: Unclassified
Product: Mesa
Version: git
Platform:
from osmesa, radeon and r600 classic drivers.diff --git a/src/mesa/drivers/dri/r600/evergreen_fragprog.c b/src/mesa/drivers/dri/r600/evergreen_fragprog.c
index cc584ca..10c88d7 100644
--- a/src/mesa/drivers/dri/r600/evergreen_fragprog.c
+++ b/src/mesa/drivers/dri/r600/evergreen_fragprog.c
@@
Not sure this needs it, but LGTM. You might want to add yourself to the
Authors comment, but *shrug*.
-tom
On 10/18/2011 06:33 PM, Eric Anholt wrote:
From: tom fogaltfo...@sci.utah.edu
v2: lots of hacking by anholt to make it look more like a normal
piglit test and make all results
On Wed, 2011-10-19 at 10:49 -0400, Tom Stellard wrote:
On Fri, 2011-10-07 at 10:14 -0400, Vadim Girlin wrote:
Hi,
Recently I've been working on the shader optimization for r600g, and now
I have the initial working implementation of simple alu scheduler and
register allocator. It has no
On Tue, 18 Oct 2011 17:05:28 -0700, Kenneth Graunke kenn...@whitecape.org
wrote:
We definitely want CACHE_NEW_WM_PROG, not CACHE_NEW_VS_PROG.
NOTE: This is a candidate for the 7.11 branch.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
This series is Reviewed-by: Eric Anholt
When there is no ARB_vertex_program program enabled, the Current
pointer points at a default program, so we were always using
VERTEX_PROGRAM_TWO_SIDE, even for fixed function lighting.
Fixes piglit two-sided-lighting*
---
src/mesa/main/state.c |2 +-
1 files changed, 1 insertions(+), 1
https://bugs.freedesktop.org/show_bug.cgi?id=34401
Michal Suchanek hramr...@gmail.com changed:
What|Removed |Added
CC||hramr...@gmail.com
On 10/19/2011 10:49 AM, Eric Anholt wrote:
When there is no ARB_vertex_program program enabled, the Current
pointer points at a default program, so we were always using
VERTEX_PROGRAM_TWO_SIDE, even for fixed function lighting.
Fixes piglit two-sided-lighting*
---
src/mesa/main/state.c |2
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/18/2011 03:51 PM, Eric Anholt wrote:
On Mon, 17 Oct 2011 07:40:27 -0700, Chad Versace c...@chad-versace.us wrote:
This function allocates the HiZ region and initializes the HiZ control
state for a depthbuffer.
It is wise to define the logic
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/18/2011 03:57 PM, Eric Anholt wrote:
On Mon, 17 Oct 2011 07:40:28 -0700, Chad Versace c...@chad-versace.us wrote:
Replace it with intel_renderbuffer::region::hiz::region.
Signed-off-by: Chad Versace c...@chad-versace.us
---
On 18 October 2011 17:33, Eric Anholt e...@anholt.net wrote:
A driver trying to set up builtin uniforms is faced with a problem:
How do I walk the ir_variable structure (representing an array of
structs, or array of matrices, or struct, or whatever), and set up
driver structures so that
On 18 October 2011 18:07, Brian Paul brian.e.p...@gmail.com wrote:
From: Brian Paul bri...@vmware.com
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
On 18 October 2011 18:07, Brian Paul brian.e.p...@gmail.com wrote:
From: Brian Paul bri...@vmware.com
---
.../drivers/dri/i965/brw_vec4_reg_allocate.cpp |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_reg_allocate.cpp
On 10/19/2011 01:53 PM, Paul Berry wrote:
On 18 October 2011 18:07, Brian Paul brian.e.p...@gmail.com
mailto:brian.e.p...@gmail.com wrote:
From: Brian Paul bri...@vmware.com mailto:bri...@vmware.com
---
.../drivers/dri/i965/brw_vec4_reg_allocate.cpp |2 +-
1 files
On 18 October 2011 17:33, Eric Anholt e...@anholt.net wrote:
From: tom fogal tfo...@sci.utah.edu
v2: lots of hacking by anholt to make it look more like a normal
piglit test and make all results visible at once.
---
tests/all.tests |1 +
On 19 October 2011 12:58, Brian Paul bri...@vmware.com wrote:
On 10/19/2011 01:53 PM, Paul Berry wrote:
On 18 October 2011 18:07, Brian Paul brian.e.p...@gmail.com
mailto:brian.e.p...@gmail.com** wrote:
From: Brian Paul bri...@vmware.com mailto:bri...@vmware.com
---
I had a colleague hitting issues compiling with an old gcc3.2
system. These patches got them through.
---
include/GL/gl.h |2 +-
src/mesa/main/compiler.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/GL/gl.h b/include/GL/gl.h
index
---
src/gallium/state_trackers/wgl/SConscript |1 +
src/gallium/state_trackers/wgl/stw_context.c | 39 ++--
.../state_trackers/wgl/stw_getprocaddress.c|3 ++
src/gallium/state_trackers/wgl/stw_icd.h |8
4 files changed, 48
- Original Message -
---
src/gallium/state_trackers/wgl/SConscript |1 +
src/gallium/state_trackers/wgl/stw_context.c | 39
++--
.../state_trackers/wgl/stw_getprocaddress.c|3 ++
src/gallium/state_trackers/wgl/stw_icd.h |
On 10/19/11 13:44, Tom Fogal wrote:
I had a colleague hitting issues compiling with an old gcc3.2
system. These patches got them through.
---
include/GL/gl.h |2 +-
src/mesa/main/compiler.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
NULL as an error indicator is meaningless, since it will return NULL
on success anyway if the caller passes in zero as the image's address
and asks to calculate the offset of the first pixel. For example,
_mesa_validate_pbo_access() does this.
This also matches the code in the non-GL_BITMAP
This avoids forming invalid pointers needlessly, which even if
never dereferenced is undefined behavior. It also makes
_mesa_validate_pbo_access() more comprehensible.
---
v2: Now rebased on top of the recent commit 9024d8af0ae.
src/mesa/drivers/dri/intel/intel_pixel_read.c |5 ++-
---
src/gallium/state_trackers/dri/sw/dri_drawable.c | 72 --
1 files changed, 40 insertions(+), 32 deletions(-)
diff --git a/src/gallium/state_trackers/dri/sw/dri_drawable.c
b/src/gallium/state_trackers/dri/sw/dri_drawable.c
index 05c64b6..66997fb 100644
---
This moves drisw-specific code into drisw.c, making it
possible to eliminate the extra copy of dri_drawable.c.
---
.../state_trackers/dri/common/dri_context.h|4 ++
src/gallium/state_trackers/dri/drm/dri2.c | 26 +-
src/gallium/state_trackers/dri/sw/dri_drawable.c
The sw copy needs to go away. It's already missing several
new patches to the original.
---
.../state_trackers/dri/common/dri_drawable.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/gallium/state_trackers/dri/common/dri_drawable.c
This reverts commit 569bde1fa7d03fb7688d0d391b32e61e857ad44e.
---
src/gallium/state_trackers/dri/sw/dri_drawable.c | 274 +-
1 files changed, 1 insertions(+), 273 deletions(-)
mode change 100644 = 12 src/gallium/state_trackers/dri/sw/dri_drawable.c
diff --git
On 10/19/2011 02:24 PM, Paul Berry wrote:
On 19 October 2011 12:58, Brian Paul bri...@vmware.com
mailto:bri...@vmware.com wrote:
On 10/19/2011 01:53 PM, Paul Berry wrote:
On 18 October 2011 18:07, Brian Paul brian.e.p...@gmail.com
mailto:brian.e.p...@gmail.com
On Wed, 19 Oct 2011 11:28:42 -0600, Brian Paul bri...@vmware.com wrote:
On 10/19/2011 10:49 AM, Eric Anholt wrote:
When there is no ARB_vertex_program program enabled, the Current
pointer points at a default program, so we were always using
VERTEX_PROGRAM_TWO_SIDE, even for fixed function
On Wed, Oct 19, 2011 at 6:10 PM, nobled nob...@dreamwidth.org wrote:
NULL as an error indicator is meaningless, since it will return NULL
on success anyway if the caller passes in zero as the image's address
and asks to calculate the offset of the first pixel. For example,
On Wed, Oct 19, 2011 at 6:13 PM, nobled nob...@dreamwidth.org wrote:
This avoids forming invalid pointers needlessly, which even if
never dereferenced is undefined behavior. It also makes
_mesa_validate_pbo_access() more comprehensible.
---
v2: Now rebased on top of the recent commit
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/gallium/include/pipe/p_config.h |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/src/gallium/include/pipe/p_config.h
b/src/gallium/include/pipe/p_config.h
index b3a7b33..7cd42c6 100644
---
On Sat, Aug 27, 2011 at 03:23, Kenneth Graunke kenn...@whitecape.org wrote:
This is a port of vec4_visitor::try_rewrite_rhs_to_dst to fs_visitor.
Not only is this technique less invasive and more robust, it also
generates better code. Over and above the previous technique, this
reduced
43 matches
Mail list logo
