[Mesa-dev] [PATCH] intel: don't call unmap pbo if pbo is not mapped

2011-11-02 Thread Yuanhan Liu
_mesa_validate_pbo_teximage may fail, result the pbo not mapped. If then unmap function is called, an abort would be triggered by assert(obj-Pointer). This would fix: https://bugs.freedesktop.org/show_bug.cgi?id=42268 NOTE: this is just for 7.11 stable branch Signed-off-by: Yuanhan Liu

Re: [Mesa-dev] Legacy Drivers

2011-11-02 Thread Kenneth Graunke
On 11/01/2011 06:19 PM, Don Cupp wrote: Please forgive if this is the wrong list for these questions or if they have already been asked and answered. I am trying to figure out where the unichrome driver went in the 7.12-devel branch and if it is coming back. Anybody have some clues for me?

[Mesa-dev] [PATCH] r600g: take into account PSIZE output for spi mapping

2011-11-02 Thread Vadim Girlin
Skip PSIZE and POSITION when counting VS outputs. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=42435 Tested without regressions on evergreen. Signed-off-by: Vadim Girlin vadimgir...@gmail.com --- src/gallium/drivers/r600/r600_shader.c |9 ++--- 1 files changed, 6 insertions(+), 3

[Mesa-dev] [PATCH 1/5] mesa: remove the redundant check

2011-11-02 Thread Yuanhan Liu
Signed-off-by: Yuanhan Liu yuanhan@linux.intel.com --- src/mesa/main/texparam.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index dc5ee33..b031e18 100644 --- a/src/mesa/main/texparam.c +++

[Mesa-dev] [PATCH 2/5] mesa: complete the GL_TEXTURE_SWIZZLE* setup

2011-11-02 Thread Yuanhan Liu
The ARB_texture_swizzle spec says: The error INVALID_OPERATION is generated if TexParameteri, TexParameterf, TexParameteriv, or TexParameterfv, parameter pname is TEXTURE_SWIZZLE_R, TEXTURE_SWIZZLE_G, TEXTURE_SWIZZLE_B, or TEXTURE_SWIZZLE_A, and param is not RED, GREEN, BLUE,

[Mesa-dev] [PATCH 3/5] mesa: fix inital value for new renderbuffer

2011-11-02 Thread Yuanhan Liu
EXT_framebuffer_object bspec says: Get Value TypeGet Command Initial Value ----- --- --- RENDERBUFFER_INTERNAL_FORMAT_EXT Z+ GetRenderbufferParameterivEXT RGBA

[Mesa-dev] [PATCH 4/5] mesa: fix the low limit of width and height for glRenderbufferStorage

2011-11-02 Thread Yuanhan Liu
glRenderbufferStorage man page says: GL_INVALID_VALUE is generated if either of width or height is negative, or greater than the value of GL_MAX_RENDERBUFFER_SIZE. Signed-off-by: Yuanhan Liu yuanhan@linux.intel.com --- src/mesa/main/fbobject.c |4 ++-- 1 files changed, 2

[Mesa-dev] [PATCH 5/5] swrast: simply the condition test for _swrast_choose_texture_sample_func

2011-11-02 Thread Yuanhan Liu
remove another long if condition test. I don't feel a strong need of this patch. But for it make the code a little simpler(I do think so), I send it out. Signed-off-by: Yuanhan Liu yuanhan@linux.intel.com --- src/mesa/swrast/s_texfilter.c | 22 +- 1 files changed, 9

Re: [Mesa-dev] [PATCH] Mesa-demos: add wglcontext to test the creation of a context through WGL_ARB_create_context

2011-11-02 Thread Jose Fonseca
I've pushed, but it doesn't work on nvidia. It fails with error 0xc0072096. Have you tried with different implementations? Jose - Original Message - --- src/wgl/CMakeLists.txt |1 + src/wgl/wglcontext.c | 274 2 files

Re: [Mesa-dev] [PATCH 1/5] mesa: remove the redundant check

2011-11-02 Thread Brian Paul
On 11/02/2011 03:56 AM, Yuanhan Liu wrote: Signed-off-by: Yuanhan Liuyuanhan@linux.intel.com --- src/mesa/main/texparam.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index dc5ee33..b031e18 100644

Re: [Mesa-dev] [PATCH 2/5] mesa: complete the GL_TEXTURE_SWIZZLE* setup

2011-11-02 Thread Brian Paul
On 11/02/2011 03:56 AM, Yuanhan Liu wrote: The ARB_texture_swizzle spec says: The error INVALID_OPERATION is generated if TexParameteri, TexParameterf, TexParameteriv, or TexParameterfv, parameterpname is TEXTURE_SWIZZLE_R, TEXTURE_SWIZZLE_G, TEXTURE_SWIZZLE_B, or

Re: [Mesa-dev] [PATCH 3/5] mesa: fix inital value for new renderbuffer

2011-11-02 Thread Brian Paul
On 11/02/2011 03:56 AM, Yuanhan Liu wrote: EXT_framebuffer_object bspec says: Get Value TypeGet Command Initial Value ----- --- --- RENDERBUFFER_INTERNAL_FORMAT_EXT Z+

Re: [Mesa-dev] [PATCH 4/5] mesa: fix the low limit of width and height for glRenderbufferStorage

2011-11-02 Thread Brian Paul
On 11/02/2011 03:56 AM, Yuanhan Liu wrote: glRenderbufferStorage man page says: GL_INVALID_VALUE is generated if either of width or height is negative, or greater than the value of GL_MAX_RENDERBUFFER_SIZE. Signed-off-by: Yuanhan Liuyuanhan@linux.intel.com ---

Re: [Mesa-dev] [PATCH 5/5] swrast: simply the condition test for _swrast_choose_texture_sample_func

2011-11-02 Thread Brian Paul
On 11/02/2011 03:57 AM, Yuanhan Liu wrote: remove another long if condition test. I don't feel a strong need of this patch. But for it make the code a little simpler(I do think so), I send it out. Signed-off-by: Yuanhan Liuyuanhan@linux.intel.com Reviewed-by: Brian Paul bri...@vmware.com

[Mesa-dev] swrast tfp cleanup

2011-11-02 Thread George Sapountzis
Hi, [please cc: me in any replies] I rebased (with minor cleanups) the patches submitted by Benjamin Franzke and put them at: http://cgit.freedesktop.org/~gsap7/mesa/log/?h=tfp The commits contain links to relevant emails. I tested the patches on xephyr, please review and test that it still

[Mesa-dev] [PATCH] radeon: fix some regressions in texturing code.

2011-11-02 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com On a piglit run vs 7.11 this fixes 23 tests. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/drivers/dri/radeon/radeon_span.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [Bug 42516] New: Assertion `src.File != TGSI_FILE_NULL' failed with llvmpipe renderer

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42516 Bug #: 42516 Summary: Assertion `src.File != TGSI_FILE_NULL' failed with llvmpipe renderer Classification: Unclassified Product: Mesa Version: 7.11 Platform: x86-64

[Mesa-dev] [Bug 42517] New: Abort with llvmpipe renderer: ir_swizzle @ 0x2e8f0a0 specifies a channel not present in the value.

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42517 Bug #: 42517 Summary: Abort with llvmpipe renderer: ir_swizzle @ 0x2e8f0a0 specifies a channel not present in the value. Classification: Unclassified Product: Mesa Version:

[Mesa-dev] [Bug 42516] Assertion `src.File != TGSI_FILE_NULL' failed with llvmpipe renderer

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42516 Christian Holler (:decoder) chol...@mozilla.com changed: What|Removed |Added Blocks||42517

Re: [Mesa-dev] swrast tfp cleanup

2011-11-02 Thread Jose Fonseca
I haven't had the time to pay with the dir/swrast tfp yet, so I can't really comment the technical details. But, code de-duplication is always nice. So as long as there is no known regressions introduced for this, I'm thumbs up. Jose - Original Message - Hi, [please cc: me in any

Re: [Mesa-dev] swrast tfp cleanup

2011-11-02 Thread Benjamin Franzke
2011/11/2 George Sapountzis gsapount...@gmail.com: Hi, [please cc: me in any replies] I rebased (with minor cleanups) the patches submitted by Benjamin Franzke and put them at: Thanks for reminding. I wanted to wait for feedback, but there was no answer (same as for my comments on the

Re: [Mesa-dev] swrast tfp cleanup

2011-11-02 Thread George Sapountzis
On Wed, Nov 2, 2011 at 4:42 PM, Benjamin Franzke benjaminfran...@googlemail.com wrote: It would have been fair, when you'd have used git-am for applying the patches to keep me as author. So if you are ok, I'm going to push my original patches. ok by me, go ahead

Re: [Mesa-dev] [PATCH] Mesa-demos: add wglcontext to test the creation of a context through WGL_ARB_create_context

2011-11-02 Thread Morgan Armand
I got this error too on nvidia when requesting a context with a version = 3.2, but from what I understand from the spec, this is not the correct behavior. The 0x2096 part corresponds to ERROR_INVALID_PROFILE_ARB (I don't know what is the meaning of the 0xc007 part and if it is nvidia specific

[Mesa-dev] [Bug 42516] Assertion `src.File != TGSI_FILE_NULL' failed with llvmpipe renderer

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42516 José Fonseca jfons...@vmware.com changed: What|Removed |Added CC||jfons...@vmware.com

Re: [Mesa-dev] Mesa (master): 27 new commits

2011-11-02 Thread Jose Fonseca
Hi Kristian, I got this log from a build daemon: [...truncated 3700 lines...] dri2.c:716:4: error: unknown field ‘WaitForMSC’ specified in initializer dri2.c:718:4: error: unknown field ‘SwapBuffers’ specified in initializer dri2.c:718:4: warning: excess elements in struct initializer

Re: [Mesa-dev] Mesa (master): 27 new commits

2011-11-02 Thread Kristian Høgsberg
On Wed, Nov 2, 2011 at 11:43 AM, Jose Fonseca jfons...@vmware.com wrote: Hi Kristian, Jose, Sorry about that, I just pushed a commit to fix these issues. Kristian I got this log from a build daemon: [...truncated 3700 lines...] dri2.c:716:4: error: unknown field ‘WaitForMSC’ specified in

Re: [Mesa-dev] Mesa (master): 27 new commits

2011-11-02 Thread Jose Fonseca
- Original Message - On Wed, Nov 2, 2011 at 11:43 AM, Jose Fonseca jfons...@vmware.com wrote: Hi Kristian, Jose, Sorry about that, I just pushed a commit to fix these issues. Kristian No prob. That's why build daemons are for. They are happy again now! Jose

Re: [Mesa-dev] [PATCH] i965: Fix constant propagation into 32-bit integer MUL.

2011-11-02 Thread Eric Anholt
On Tue, 1 Nov 2011 20:58:16 -0700, Paul Berry stereotype...@gmail.com wrote: i965's MUL instruction can't take an immediate value as its first argument. So normally, if constant propagation wants to propagate a constant into the first argument of a MUL instruction, it swaps the order of the

[Mesa-dev] unify common/dri_util common/drisw_util

2011-11-02 Thread George Sapountzis
Hi [please cc: me in any replies] After the nice cleanups wrt to DRI, I think it's possible to unify the two dri helper files. Has anyone already done this ? See any reason against this ? I'll git it a try otherwise. regards, George. ___ mesa-dev

[Mesa-dev] [Bug 42487] Teapot visual artifact

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42487 vincent v...@ovi.com changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from

[Mesa-dev] [PATCH 2/2] r300g: Fix queries on big endian hosts.

2011-11-02 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/r300/r300_query.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r300/r300_query.c b/src/gallium/drivers/r300/r300_query.c index

[Mesa-dev] [PATCH 1/2] gallium/util: Add macros for converting from little endian to CPU byte order.

2011-11-02 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/auxiliary/util/u_math.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h

Re: [Mesa-dev] [PATCH 2/2] r300g: Fix queries on big endian hosts.

2011-11-02 Thread Corbin Simpson
2011/11/2 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com ---  src/gallium/drivers/r300/r300_query.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] gallium/util: Add macros for converting from little endian to CPU byte order.

2011-11-02 Thread Jose Fonseca
Looks good to me, Michel. Jose - Original Message - From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/auxiliary/util/u_math.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] r300g: Fix queries on big endian hosts.

2011-11-02 Thread Michel Dänzer
On Mit, 2011-11-02 at 10:36 -0700, Corbin Simpson wrote: 2011/11/2 Michel Dänzer mic...@daenzer.net: From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/r300/r300_query.c |2 +- 1 files changed, 1 insertions(+),

Re: [Mesa-dev] intel GPU freeze with master, with apitrace log

2011-11-02 Thread tom fogal
Ping? -tom tom fogal tfo...@sci.utah.edu writes: Hi all, Our application has a render mode which is causing a Sandybridge-based system to hang for a second with Mesa master. In dmesg I see: [drm:i915_hangcheck_elapsed] *ERROR* Hangcheck timer elapsed... GPU hung

Re: [Mesa-dev] intel GPU freeze with master, with apitrace log

2011-11-02 Thread Daniel Vetter
On Wed, Nov 02, 2011 at 12:14:10PM -0600, tom fogal wrote: Our application has a render mode which is causing a Sandybridge-based system to hang for a second with Mesa master. In dmesg I see: [drm:i915_hangcheck_elapsed] *ERROR* Hangcheck timer elapsed... GPU hung

[Mesa-dev] 7.11.1 release, and picking NormalMatrix fix

2011-11-02 Thread tom fogal
It's been three months since 7.11 came out. Have there been any thoughts on a 7.11.1 release date? Also, any qualms about me cherry-picking the 'NormalMatrix' fix below into 7.11? Thanks, -tom commit cc4ddc3a1e4bbe5fccd03b39b3590368be8c172f Author: Eric Anholt e...@anholt.net Date: Tue Oct

[Mesa-dev] [PATCH] wglSetPixelFormat should ignore the ppfd parameter

2011-11-02 Thread Morgan Armand
The patch should be correctly formatted, but I attached it anyway to be sure for this time. --- src/gallium/state_trackers/wgl/stw_wgl.c |3 +-- src/mesa/drivers/windows/gdi/wgl.c |6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] 7.11.1 release, and picking NormalMatrix fix

2011-11-02 Thread Ian Romanick
On 11/02/2011 12:04 PM, tom fogal wrote: It's been three months since 7.11 came out. Have there been any thoughts on a 7.11.1 release date? Soon. After the last big round of cherry picking that I did, our internal QA has been running the full round of tests, and they've found one or two

Re: [Mesa-dev] [PATCH] wglSetPixelFormat should ignore the ppfd parameter

2011-11-02 Thread Jose Fonseca
- Original Message - The patch should be correctly formatted, but I attached it anyway to be sure for this time. Actually, it failed when I tried the apply the full mail: $ git am -3 ~/tmp/patch.txt Applying: wglSetPixelFormat should ignore the ppfd parameter Using index info to

Re: [Mesa-dev] intel GPU freeze with master, with apitrace log

2011-11-02 Thread Daniel Vetter
On Wed, Nov 02, 2011 at 12:40:30PM -0600, tom fogal wrote: Thanks Daniel! That log is attached (gzipped, as it's almost 900k otherwise). I grabbed it right after running glretrace as the original email described. However I also took a look at it before running glretrace again and it had

[Mesa-dev] [Bug 42461] Render error when there is no vertex shader

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42461 Ian Romanick i...@freedesktop.org changed: What|Removed |Added AssignedTo|i...@freedesktop.org

Re: [Mesa-dev] [PATCH 2/2] intel: make sure hardware choose the right filter mode

2011-11-02 Thread Eric Anholt
On Wed, 2 Nov 2011 11:12:07 +0800, Yuanhan Liu yuanhan@linux.intel.com wrote: On Tue, Nov 01, 2011 at 05:57:36PM +0800, Yuanhan Liu wrote: According to bspec, MIPCnt(was set to intelObj-_MaxLevel) was used for min/mag filter mode determination. For a normal case with no mipmap like

[Mesa-dev] [Bug 42461] Render error when there is no vertex shader

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42461 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED

Re: [Mesa-dev] [PATCH 1/2] driconf: updated de.po

2011-11-02 Thread Eric Anholt
On Tue, 30 Aug 2011 11:46:00 +0200, Carl-Philip Haensch cphaen...@googlemail.com wrote: --- src/mesa/drivers/dri/common/xmlpool/de.po | 138 ++--- 1 files changed, 88 insertions(+), 50 deletions(-) Found these still marked +todo in notmuch, and pushed them out

[Mesa-dev] [PATCH] radeon: Check an error return instead of assigning it to a dead variable.

2011-11-02 Thread Eric Anholt
Fixes gcc set-but-unused-variable warning. --- .../drivers/dri/radeon/radeon_common_context.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_common_context.c b/src/mesa/drivers/dri/radeon/radeon_common_context.c

Re: [Mesa-dev] [PATCH 2/2] i965: Avoid generating MOVs for most ir_assignment handling.

2011-11-02 Thread Eric Anholt
On Wed, 19 Oct 2011 19:27:54 -0700, Stéphane Marchesin stephane.marche...@gmail.com wrote: On Sat, Aug 27, 2011 at 03:23, Kenneth Graunke kenn...@whitecape.org wrote: This is a port of vec4_visitor::try_rewrite_rhs_to_dst to fs_visitor. Not only is this technique less invasive and more

Re: [Mesa-dev] [PATCH] radeon: Check an error return instead of assigning it to a dead variable.

2011-11-02 Thread Alex Deucher
On Wed, Nov 2, 2011 at 5:40 PM, Eric Anholt e...@anholt.net wrote: Fixes gcc set-but-unused-variable warning. Reviewed-by: Alex Deucher alexdeuc...@gmail.com ---  .../drivers/dri/radeon/radeon_common_context.c     |   18 +-  1 files changed, 13 insertions(+), 5 deletions(-)

[Mesa-dev] [Bug 29033] can't build dri drivers with just GLES

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29033 --- Comment #2 from Anuj Phogat anuj.pho...@gmail.com 2011-11-02 15:35:52 PDT --- It builds fine on current Mesa git. OpenGL version string: 1.4 (2.1 Mesa 7.11) build string: ./configure --enable-gles2 --enable-gles1 --disable-opengl

[Mesa-dev] [Bug 41571] libglapi.so.0: undefined symbol: is_selinux_enabled

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41571 Alexandre Demers alexandre.f.dem...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] intel GPU freeze with master, with apitrace log

2011-11-02 Thread Kenneth Graunke
On 11/02/2011 11:14 AM, tom fogal wrote: Ping? -tom Tom, You'll probably want to open a bug report on this just so it doesn't get lost. Sorry it's been taking so long. I was able to reproduce the hang on SNB by replaying your apitrace file. Nothing jumped out at me from the error state.

[Mesa-dev] [Bug 41571] libglapi.so.0: undefined symbol: is_selinux_enabled

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41571 Alexandre Demers alexandre.f.dem...@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED

Re: [Mesa-dev] intel GPU freeze with master, with apitrace log

2011-11-02 Thread tom fogal
Kenneth Graunke kenn...@whitecape.org writes: On 11/02/2011 11:14 AM, tom fogal wrote: Ping? You'll probably want to open a bug report on this just so it doesn't get lost. Okay. https://bugs.freedesktop.org/show_bug.cgi?id=42538 Sorry it's been taking so long. No need to apologize!

Re: [Mesa-dev] 7.11.1 release, and picking NormalMatrix fix

2011-11-02 Thread Yuanhan Liu
On Wed, Nov 02, 2011 at 12:48:23PM -0700, Ian Romanick wrote: On 11/02/2011 12:04 PM, tom fogal wrote: It's been three months since 7.11 came out. Have there been any thoughts on a 7.11.1 release date? Soon. After the last big round of cherry picking that I did, our internal QA has been

Re: [Mesa-dev] [PATCH 2/2] intel: make sure hardware choose the right filter mode

2011-11-02 Thread Yuanhan Liu
On Wed, Nov 02, 2011 at 02:18:46PM -0700, Eric Anholt wrote: On Wed, 2 Nov 2011 11:12:07 +0800, Yuanhan Liu yuanhan@linux.intel.com wrote: On Tue, Nov 01, 2011 at 05:57:36PM +0800, Yuanhan Liu wrote: According to bspec, MIPCnt(was set to intelObj-_MaxLevel) was used for min/mag

[Mesa-dev] [Bug 42540] New: glxgears segfaults on POWER / Xvnc

2011-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42540 Bug #: 42540 Summary: glxgears segfaults on POWER / Xvnc Classification: Unclassified Product: Mesa Version: 7.11 Platform: PowerPC OS/Version: Linux (All) Status: