Re: [Mesa-dev] [PATCH] intel: use bytes instead of pixels intel_create_image_from_name

2013-01-28 Thread Eric Anholt
Tapani Pälli tapani.pa...@intel.com writes: Signed-off-by: Tapani Pälli tapani.pa...@intel.com Reviewed-by: Eric Anholt e...@anholt.net pgpyvjRe5kwE1.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 59967] New: [regression] configure: error: Could not find llvm shared libraries

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59967 Priority: medium Bug ID: 59967 CC: tstel...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: [regression] configure: error: Could not find llvm shared

[Mesa-dev] Gallium pixel formats on big-endian

2013-01-28 Thread Adam Jackson
I've been looking at untangling the pixel format code for big-endian. My current theory is that blindly byte-swapping values is just wrong. Data coming from the application is never in the wrong order. Consider the first non-trivial format emitted in u_format_table.c: /* taken from an x86

Re: [Mesa-dev] [PATCH 2/2] gallivm, draw, llvmpipe: mass rename of unit-texture_unit/sampler_unit

2013-01-28 Thread Jose Fonseca
Thanks Roland. I'd do s/texture_unit/resource_unit/g, as buffers bindings are/will be accepted. Either way: Reviewed-by: Jose Fonseca jfons...@vmware.com Jose - Original Message - From: Roland Scheidegger srol...@vmware.com Make it obvious what unit this is (no change in

[Mesa-dev] [Bug 59879] reducing symbol visibility of shared objects / static libstdc++

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59879 José Fonseca jfons...@vmware.com changed: What|Removed |Added CC||jfons...@vmware.com

[Mesa-dev] [Bug 59879] reducing symbol visibility of shared objects / static libstdc++

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59879 --- Comment #2 from José Fonseca jfons...@vmware.com --- Ignore the lib32 above. I meant lib -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

Re: [Mesa-dev] Gallium pixel formats on big-endian

2013-01-28 Thread Michel Dänzer
On Mon, 2013-01-28 at 06:56 -0500, Adam Jackson wrote: I've been looking at untangling the pixel format code for big-endian. My current theory is that blindly byte-swapping values is just wrong. Certainly. :) I think you're discovering that this hasn't really been thought through beyond what's

Re: [Mesa-dev] [PATCH] i965: Compile the driver with -march=core2.

2013-01-28 Thread Roland Scheidegger
Am 26.01.2013 18:26, schrieb Daniel Vetter: On Fri, Jan 25, 2013 at 11:03:35PM -0800, Kenneth Graunke wrote: On 01/25/2013 03:13 PM, Roland Scheidegger wrote: I'm quite sure there are g965 boards around which indeed support Pentium 4 (and P4-based Celerons) (but yes I guess cmov and at least

Re: [Mesa-dev] [PATCH 3/3] R600: fix assumption in the CFG structurizers loop handling

2013-01-28 Thread Michel Dänzer
On Don, 2013-01-24 at 13:46 +0100, Christian König wrote: From: Christian König christian.koe...@amd.com The loop handling in the CFG structurizer incorrectly assumed that only BasicBlock nodes can have a back edge, but that is also possible for the exit edges of subregions. Fixing 4

Re: [Mesa-dev] [PATCH 8/9] mesa: add RGBX formats for existing GL RGB texture formats

2013-01-28 Thread Marek Olšák
Sorry, I don't build swrast and I incorrectly assumed that adding new formats which swrast doesn't use wouldn't break compiling. I didn't update _mesa_choose_tex_format, because it's not part of the vertical slice I'm implementing. I'll send a corrected patch shortly. Marek On Mon, Jan 28, 2013

[Mesa-dev] [PATCH 8/9] mesa: add RGBX formats for existing GL RGB texture formats

2013-01-28 Thread Marek Olšák
v2: fix compilation of swrast --- src/mesa/main/format_pack.c | 186 ++ src/mesa/main/format_unpack.c | 297 + src/mesa/main/formats.c | 207 src/mesa/main/formats.h | 16 +++

[Mesa-dev] [PATCH] r600g: don't emit WAIT_UNTIL on cayman/TN (v2)

2013-01-28 Thread alexdeucher
From: Alex Deucher alexander.deuc...@amd.com It shouldn't be needed and older kernels don't support it. v2: Replace with PS partial flush as before. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=59945 Signed-off-by: Alex Deucher alexander.deuc...@amd.com ---

Re: [Mesa-dev] [Piglit] [PATCH] ext_framebuffer_multisample: check for num_samples=1

2013-01-28 Thread Brian Paul
[cross-posting this reply to the mesa-dev list] On 01/27/2013 09:07 AM, Brian Paul wrote: On Sun, Jan 27, 2013 at 2:51 AM, Eric Anholte...@anholt.net wrote: Brian Paulbri...@vmware.com writes: Even if GL_ARB_multisample is advertised, it's OK for the max number of samples to be zero.

Re: [Mesa-dev] [Piglit] [PATCH] ext_framebuffer_multisample: check for num_samples=1

2013-01-28 Thread Marek Olšák
On Mon, Jan 28, 2013 at 4:54 PM, Brian Paul bri...@vmware.com wrote: [cross-posting this reply to the mesa-dev list] On 01/27/2013 09:07 AM, Brian Paul wrote: On Sun, Jan 27, 2013 at 2:51 AM, Eric Anholte...@anholt.net wrote: Brian Paulbri...@vmware.com writes: Even if

Re: [Mesa-dev] [PATCH] r600g: don't emit WAIT_UNTIL on cayman/TN (v2)

2013-01-28 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com Marek On Mon, Jan 28, 2013 at 4:55 PM, alexdeuc...@gmail.com wrote: From: Alex Deucher alexander.deuc...@amd.com It shouldn't be needed and older kernels don't support it. v2: Replace with PS partial flush as before. Fixes:

Re: [Mesa-dev] [Piglit] [PATCH] ext_framebuffer_multisample: check for num_samples=1

2013-01-28 Thread Brian Paul
On Mon, Jan 28, 2013 at 9:17 AM, Marek Olšák mar...@gmail.com wrote: On Mon, Jan 28, 2013 at 4:54 PM, Brian Paul bri...@vmware.com wrote: [cross-posting this reply to the mesa-dev list] On 01/27/2013 09:07 AM, Brian Paul wrote: On Sun, Jan 27, 2013 at 2:51 AM, Eric Anholte...@anholt.net

Re: [Mesa-dev] Mesa (master): gallium/u_upload_mgr: fix a serious memory leak

2013-01-28 Thread Brian Paul
On 01/27/2013 06:52 PM, Marek Olšák wrote: Module: Mesa Branch: master Commit: 87592cff57feef29565150b9203e220b50623f30 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=87592cff57feef29565150b9203e220b50623f30 Author: Marek Olšákmar...@gmail.com Date: Mon Jan 28 02:47:24 2013 +0100

Re: [Mesa-dev] Mesa (master): gallium/u_upload_mgr: fix a serious memory leak

2013-01-28 Thread Marek Olšák
On Mon, Jan 28, 2013 at 6:18 PM, Brian Paul bri...@vmware.com wrote: On 01/27/2013 06:52 PM, Marek Olšák wrote: Module: Mesa Branch: master Commit: 87592cff57feef29565150b9203e220b50623f30 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=87592cff57feef29565150b9203e220b50623f30

[Mesa-dev] [Bug 59967] [regression] configure: error: Could not find llvm shared libraries

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59967 Michel Dänzer mic...@daenzer.net changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 59967] [regression] configure: error: Could not find llvm shared libraries

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59967 Michel Dänzer mic...@daenzer.net changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] [Piglit] [PATCH] ext_framebuffer_multisample: check for num_samples=1

2013-01-28 Thread Paul Berry
On 28 January 2013 09:00, Brian Paul brian.e.p...@gmail.com wrote: On Mon, Jan 28, 2013 at 9:17 AM, Marek Olšák mar...@gmail.com wrote: On Mon, Jan 28, 2013 at 4:54 PM, Brian Paul bri...@vmware.com wrote: [cross-posting this reply to the mesa-dev list] On 01/27/2013 09:07 AM, Brian

[Mesa-dev] [Bug 59967] [regression] configure: error: Could not find llvm shared libraries

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59967 --- Comment #3 from Tom Stellard tstel...@gmail.com --- (In reply to comment #1) (In reply to comment #1) Full build log here: https://launchpadlibrarian.net/129750443/buildlog_ubuntu-quantal-i386.mesa_9.

[Mesa-dev] [PATCH 1/2] mesa: don't enable GL_EXT_framebuffer_multisample for software drivers

2013-01-28 Thread Brian Paul
Note: This is a candidate for the 9.0 branch. --- src/mesa/main/extensions.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 7ae07fb..7a8195a 100644 --- a/src/mesa/main/extensions.c +++

[Mesa-dev] [PATCH 2/2] st/mesa: only enable GL_EXT_framebuffer_multisample if GL_MAX_SAMPLES = 2

2013-01-28 Thread Brian Paul
We never really have multisampling with one sample per pixel. See also http://bugs.freedesktop.org/show_bug.cgi?id=59873 Note: This is a candidate for the 9.0 branch. --- src/mesa/state_tracker/st_extensions.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[Mesa-dev] [PATCH] xlib: fix incorrect GL_ANGLE_texture_compression_dxt enable

2013-01-28 Thread Brian Paul
--- src/mesa/drivers/x11/xm_api.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/x11/xm_api.c b/src/mesa/drivers/x11/xm_api.c index 5931f5b..739e8ac 100644 --- a/src/mesa/drivers/x11/xm_api.c +++ b/src/mesa/drivers/x11/xm_api.c @@ -929,7 +929,8 @@

[Mesa-dev] [Bug 59967] [regression] configure: error: Could not find llvm shared libraries

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59967 --- Comment #4 from Michel Dänzer mic...@daenzer.net --- (In reply to comment #3) There are AC_CHECK_LIB and AC_SEARCH_LIBS macros, but there doesn't seem to be a way to pass extra library paths to it, so I think this would fail if the shared

Re: [Mesa-dev] [PATCH] mesa: implement GL_ARB_texture_buffer_range v5

2013-01-28 Thread Ian Romanick
On 01/27/2013 12:19 PM, Eric Anholt wrote: Christoph Bumiller e0425...@student.tuwien.ac.at writes: On 27.01.2013 00:58, Eric Anholt wrote: Christoph Bumiller e0425...@student.tuwien.ac.at writes: diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 31a559e..e71f6e1 100644

[Mesa-dev] [Bug 59967] [regression] configure: error: Could not find llvm shared libraries

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59967 --- Comment #5 from Matt Turner matts...@gmail.com --- http://www.gnu.org/software/autoconf-archive/ax_ext_have_lib.html looks like a potential solution. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] xlib: fix incorrect GL_ANGLE_texture_compression_dxt enable

2013-01-28 Thread Ian Romanick
On 01/28/2013 10:46 AM, Brian Paul wrote: --- src/mesa/drivers/x11/xm_api.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/x11/xm_api.c b/src/mesa/drivers/x11/xm_api.c index 5931f5b..739e8ac 100644 --- a/src/mesa/drivers/x11/xm_api.c +++

Re: [Mesa-dev] [PATCH] docs: List new extensions added in Mesa 9.1

2013-01-28 Thread Ian Romanick
On 01/26/2013 05:39 AM, Marek Olšák wrote: On Sat, Jan 26, 2013 at 3:16 AM, Matt Turner matts...@gmail.com wrote: On Fri, Jan 25, 2013 at 6:02 PM, Marek Olšák mar...@gmail.com wrote: These extensions are not new in Mesa: - ARB_base_instance (since 9.0) - ARB_vertex_type_2_10_10_10_rev (since

[Mesa-dev] [PATCH] llvmpipe: Support Z16_UNORM as depth-stencil format.

2013-01-28 Thread jfonseca
From: José Fonseca jfons...@vmware.com Simply by adjusting the vector element width after/before reading/writing the depth-stencil values. Ran several GL_DEPTH_COMPONENT16 piglit tests without regressions. --- src/gallium/drivers/llvmpipe/lp_bld_depth.c | 46 ---

Re: [Mesa-dev] [PATCH] mesa: implement GL_ARB_texture_buffer_range v5

2013-01-28 Thread Christoph Bumiller
On 28.01.2013 19:54, Ian Romanick wrote: On 01/27/2013 12:19 PM, Eric Anholt wrote: Christoph Bumiller e0425...@student.tuwien.ac.at writes: On 27.01.2013 00:58, Eric Anholt wrote: Christoph Bumiller e0425...@student.tuwien.ac.at writes: diff --git a/src/mesa/main/teximage.c

[Mesa-dev] [Bug 59877] Build fail since r600g: Don't build llvm_wrapper.cpp when we aren't using LLVM

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59877 --- Comment #6 from Johannes Obermayr johannesoberm...@gmx.de --- Created attachment 73792 -- https://bugs.freedesktop.org/attachment.cgi?id=73792action=edit Right attempt to fix it on current master -- You are receiving this mail because:

Re: [Mesa-dev] [PATCH] xlib: fix incorrect GL_ANGLE_texture_compression_dxt enable

2013-01-28 Thread Brian Paul
On 01/28/2013 11:56 AM, Ian Romanick wrote: On 01/28/2013 10:46 AM, Brian Paul wrote: --- src/mesa/drivers/x11/xm_api.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/x11/xm_api.c b/src/mesa/drivers/x11/xm_api.c index 5931f5b..739e8ac 100644 ---

[Mesa-dev] [PATCH] xlib: stop use _mesa_enable_extension(), just set the boolean flags

2013-01-28 Thread Brian Paul
--- src/mesa/drivers/x11/xm_api.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/x11/xm_api.c b/src/mesa/drivers/x11/xm_api.c index 739e8ac..f23755e 100644 --- a/src/mesa/drivers/x11/xm_api.c +++ b/src/mesa/drivers/x11/xm_api.c @@ -928,13 +928,12

Re: [Mesa-dev] [PATCH] llvmpipe: Support Z16_UNORM as depth-stencil format.

2013-01-28 Thread Brian Paul
On 01/28/2013 12:10 PM, jfons...@vmware.com wrote: From: José Fonsecajfons...@vmware.com Simply by adjusting the vector element width after/before reading/writing the depth-stencil values. Ran several GL_DEPTH_COMPONENT16 piglit tests without regressions. ---

[Mesa-dev] [Bug 59877] Build fail since r600g: Don't build llvm_wrapper.cpp when we aren't using LLVM

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59877 Tom Stellard tstel...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED

Re: [Mesa-dev] [PATCH] intel: Fix ReadPixels on buffers whose width = 32kbytes

2013-01-28 Thread Paul Berry
On 24 January 2013 13:59, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: Yeah, you're right. I was being lazy. How's this: * Furthermore, intelEmitCopyBlit (which is called by * intel_miptree_map_blit) uses a signed 16-bit integer to represent

Re: [Mesa-dev] [PATCH] mesa: implement GL_ARB_texture_buffer_range v5

2013-01-28 Thread Eric Anholt
Christoph Bumiller e0425...@student.tuwien.ac.at writes: On 28.01.2013 19:54, Ian Romanick wrote: On 01/27/2013 12:19 PM, Eric Anholt wrote: Christoph Bumiller e0425...@student.tuwien.ac.at writes: On 27.01.2013 00:58, Eric Anholt wrote: Christoph Bumiller e0425...@student.tuwien.ac.at

Re: [Mesa-dev] [PATCH] xlib: stop use _mesa_enable_extension(), just set the boolean flags

2013-01-28 Thread Ian Romanick
On 01/28/2013 12:00 PM, Brian Paul wrote: This and the previous are Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/x11/xm_api.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/x11/xm_api.c

Re: [Mesa-dev] [PATCH 1/9] mesa: fixup inconsistent naming of RG16 formats

2013-01-28 Thread Brian Paul
On 01/27/2013 01:52 PM, Marek Olšák wrote: --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c |4 ++-- src/mesa/drivers/dri/intel/intel_mipmap_tree.c |2 +- src/mesa/main/format_pack.c | 16 src/mesa/main/format_unpack.c

Re: [Mesa-dev] [PATCH V6 0/8] intel: add support for EGL_KHR_gl_image

2013-01-28 Thread Eric Anholt
Abdiel Janulgue abdiel.janul...@linux.intel.com writes: - Rename draw_x/y to tile_x/y in dri image struct. These are now used as adjustment pixels from our stored aligned offset to the exported image instead of the entire x/y offset from the base address. - Take into consideration the

Re: [Mesa-dev] [PATCH] android: use gralloc_drm_get_gem_handle api

2013-01-28 Thread Chad Versace
On 01/23/2013 11:56 PM, Tapani Pälli wrote: currently a gralloc internal structure is exposed to mesa, use a query function instead to maintain ABI compatibility. Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/egl/drivers/dri2/platform_android.c | 8 ++--

Re: [Mesa-dev] [PATCH] android interface change

2013-01-28 Thread Chad Versace
On 01/23/2013 11:56 PM, Tapani Pälli wrote: Hello; Following patch introduces API change between Mesa and gralloc module. Gralloc module with appropriate change is available at 01.org Android repository. This change is not compatible with current android-x86 project gralloc. As this kind

Re: [Mesa-dev] [PATCH] android interface change

2013-01-28 Thread Chad Versace
On 01/28/2013 12:58 PM, Chad Versace wrote: On 01/23/2013 11:56 PM, Tapani Pälli wrote: Hello; Following patch introduces API change between Mesa and gralloc module. Gralloc module with appropriate change is available at 01.org Android repository. This change is not compatible with

[Mesa-dev] [Bug 59877] Build fail since r600g: Don't build llvm_wrapper.cpp when we aren't using LLVM

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59877 Johannes Obermayr johannesoberm...@gmx.de changed: What|Removed |Added Attachment #73792|0 |1 is

[Mesa-dev] [Bug 59877] Build fail since r600g: Don't build llvm_wrapper.cpp when we aren't using LLVM

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59877 --- Comment #9 from Tom Stellard tstel...@gmail.com --- (In reply to comment #8) Created attachment 73796 [details] [review] v2: Right attempt to fix it on current master It shouldn't fail because of: if USE_R600_LLVM_COMPILER if

Re: [Mesa-dev] [PATCH] i965: Fix assignment instead of comparison in asserts.

2013-01-28 Thread Chad Versace
Committed. Thanks for fixing my bug :) On 01/25/2013 11:27 PM, Vinson Lee wrote: Fixes side effect in assertion defects reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/mesa/drivers/dri/i965/brw_fs_emit.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2

[Mesa-dev] [PATCH] mesa: remove erroneous check for API_OPENGL_CORE in _mesa_TexBuffer

2013-01-28 Thread Christoph Bumiller
From: Christoph Bumiller christoph.bumil...@speed.at Only the test of the extension enable should be relevant. --- src/mesa/main/teximage.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 31a559e..5a27797 100644

Re: [Mesa-dev] [PATCH RFC v1] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-28 Thread Kenneth Graunke
On 01/20/2013 02:15 PM, Paul Berry wrote: [snip] As an alternative to those fixes, here's my refactoring suggestion: drop this function entirely, and instead, in brw_blorp_copytexsubimage(), create a temporary intel_renderbuffer to wrap around dst_image, and just call do_blorp_blit() directly.

[Mesa-dev] [PATCH v2] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-28 Thread Kenneth Graunke
The BLT engine has many limitations. Currently, it can only blit X-tiled buffers (since we don't have a kernel API to whack the BLT tiling mode register), which means all depth/stencil operations get punted to meta code, which can be very CPU-intensive. Even if we used the BLT engine, it can't

Re: [Mesa-dev] [PATCH] mesa: remove erroneous check for API_OPENGL_CORE in _mesa_TexBuffer

2013-01-28 Thread Chad Versace
On 01/28/2013 02:01 PM, Christoph Bumiller wrote: From: Christoph Bumiller christoph.bumil...@speed.at Only the test of the extension enable should be relevant. I don't think this change is correct. For most extensions, including GL_ARB_texture_buffer_object, the Intel driver enables the

Re: [Mesa-dev] [PATCH] mesa: remove erroneous check for API_OPENGL_CORE in _mesa_TexBuffer

2013-01-28 Thread Christoph Bumiller
On 28.01.2013 23:37, Chad Versace wrote: On 01/28/2013 02:01 PM, Christoph Bumiller wrote: From: Christoph Bumiller christoph.bumil...@speed.at Only the test of the extension enable should be relevant. I don't think this change is correct. So, maybe I misinterpreted the advice in the mesa:

[Mesa-dev] [PATCH] draw: fix draw_llvm_variant_key struct padding to avoid recompiles

2013-01-28 Thread sroland
From: Roland Scheidegger srol...@vmware.com The struct padding got broken by c789b981b244333cfc903bcd1e2fefc010500013. This caused serious performance regression because part of the key was unitialized and hence the shader always recompiled (at least on release builds...). While here also fix key

[Mesa-dev] [PATCH] glx: Check that swap_buffers_reply is non-NULL before using it

2013-01-28 Thread Stéphane Marchesin
Check that the return value from xcb_dri2_swap_buffers_reply is non-NULL before accessing the struct members. --- src/glx/dri2_glx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index a51716f..78a2a42 100644 ---

Re: [Mesa-dev] [PATCH] mesa: remove erroneous check for API_OPENGL_CORE in _mesa_TexBuffer

2013-01-28 Thread Ian Romanick
On 01/28/2013 02:43 PM, Christoph Bumiller wrote: On 28.01.2013 23:37, Chad Versace wrote: On 01/28/2013 02:01 PM, Christoph Bumiller wrote: From: Christoph Bumiller christoph.bumil...@speed.at Only the test of the extension enable should be relevant. I don't think this change is correct.

Re: [Mesa-dev] [PATCH] glx: Check that swap_buffers_reply is non-NULL before using it

2013-01-28 Thread Brian Paul
On 01/28/2013 04:11 PM, Stéphane Marchesin wrote: Check that the return value from xcb_dri2_swap_buffers_reply is non-NULL before accessing the struct members. --- src/glx/dri2_glx.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/glx/dri2_glx.c

[Mesa-dev] [Bug 59994] New: autogen.sh can't find libclc package

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59994 Priority: medium Bug ID: 59994 Assignee: mesa-dev@lists.freedesktop.org Summary: autogen.sh can't find libclc package Severity: normal Classification: Unclassified OS: Linux

[Mesa-dev] [Bug 59880] piglit arb_uniform_buffer_object-dlist regression

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59880 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment

[Mesa-dev] [Bug 59994] autogen.sh can't find libclc package

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59994 --- Comment #1 from LoneVVolf lonew...@xs4all.nl --- FYI : liclcl nor CLANG are installed, LLVM from tstellar tree with amdgpu is present -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH] draw: fix draw_llvm_variant_key struct padding to avoid recompiles

2013-01-28 Thread Brian Paul
On 01/28/2013 03:45 PM, srol...@vmware.com wrote: From: Roland Scheideggersrol...@vmware.com The struct padding got broken by c789b981b244333cfc903bcd1e2fefc010500013. This caused serious performance regression because part of the key was unitialized and hence the shader always recompiled (at

[Mesa-dev] [PATCH] mesa: implement GL_ARB_texture_buffer_range v6

2013-01-28 Thread Christoph Bumiller
v2: Record texObj.BufferSize as -1 in TexBuffer(non-Range) instead of the buffer's current size so we know we always have to use the full size of the buffer object (i.e. even if it changes without the user calling TexBuffer again) for the texture. Clarify invalid offset alignment error message.

[Mesa-dev] [Bug 59688] piglit glsl-uniform-out-of-bounds-2 regression

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59688 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |ASSIGNED

Re: [Mesa-dev] [PATCH v2] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-28 Thread Carl Worth
Kenneth Graunke kenn...@whitecape.org writes: Previously, BLORP only handled BlitFramebuffer. This patch adds an additional frontend for doing CopyTexSubImage. It also makes it the default. Reading through the patch, it looks like there are two independent things happening here---extending

[Mesa-dev] [Bug 59833] [swrast] piglit glx-swap-pixmap regression

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59833 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |ASSIGNED

[Mesa-dev] [PATCH] i965: Compile the driver with -march/-mtune appropriate for the HW.

2013-01-28 Thread Eric Anholt
While most of our development and testing is on x86-64, some of our major consumers of the driver are on i386 still. On i386, the compiler defaults to maximum compatibility, so we aren't taking advantage of cmov instructions or SSE for floating point math, unless the user went out of their way to

[Mesa-dev] [PATCH 1/2] intel: fail to compile in case of bad uniform access

2013-01-28 Thread Frank Henigman
An assertion in fs_visitor::remove_dead_constants() would fail on code like this, which accesses a non-existent uniform: uniform vec u[1]; ... a += u[0] + u[1]; Shader code is checked for that error, but apparently only before transformations like loop unrolling. So the following code would

[Mesa-dev] [PATCH 2/2] intel: initialize fs_visitor::params_remap in constructor

2013-01-28 Thread Frank Henigman
Set fs_visitor::params_remap to NULL in the constructor. This variable was potentially tested in fs_visitor::remove_dead_constants() before being set. Signed-off-by: Frank Henigman fjhenig...@google.com --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 ++ 1 file changed, 2 insertions(+)

[Mesa-dev] [Bug 59331] piglit arb_uniform_buffer_object-getintegeri_v regression

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59331 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment

Re: [Mesa-dev] [PATCH] i965: Compile the driver with -march/-mtune appropriate for the HW.

2013-01-28 Thread Carl Worth
Eric Anholt e...@anholt.net writes: for tracking down the actual worst-case CPUwe'. Looks like some typo there. CPUs? Otherwise: Reviewed-by: Carl Worth cwo...@cworth.org -Carl -- carl.d.wo...@intel.com pgpmMzh1o7xZH.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH 1/2] intel: fail to compile in case of bad uniform access

2013-01-28 Thread Ian Romanick
On 01/28/2013 05:06 PM, Frank Henigman wrote: An assertion in fs_visitor::remove_dead_constants() would fail on code like this, which accesses a non-existent uniform: uniform vec u[1]; ... a += u[0] + u[1]; Shader code is checked for that error, but apparently only before

Re: [Mesa-dev] [PATCH 2/2] intel: initialize fs_visitor::params_remap in constructor

2013-01-28 Thread Ian Romanick
On 01/28/2013 05:06 PM, Frank Henigman wrote: Set fs_visitor::params_remap to NULL in the constructor. This variable was potentially tested in fs_visitor::remove_dead_constants() before being set. Signed-off-by: Frank Henigman fjhenig...@google.com This patch is Reviewed-by: Ian Romanick

Re: [Mesa-dev] [PATCH] mesa: implement GL_ARB_texture_buffer_range v6

2013-01-28 Thread Ian Romanick
On 01/28/2013 04:02 PM, Christoph Bumiller wrote: v2: Record texObj.BufferSize as -1 in TexBuffer(non-Range) instead of the buffer's current size so we know we always have to use the full size of the buffer object (i.e. even if it changes without the user calling TexBuffer again) for the

[Mesa-dev] [PATCH 01/10] i915: Convert state-draw/depth_region to a BO pointer.

2013-01-28 Thread Eric Anholt
We don't need any of the other fields at that point. --- src/mesa/drivers/dri/i915/i830_context.h | 10 - src/mesa/drivers/dri/i915/i830_vtbl.c| 33 + src/mesa/drivers/dri/i915/i915_context.h | 13 src/mesa/drivers/dri/i915/i915_vtbl.c

[Mesa-dev] [PATCH 02/10] i915: Make the set_draw_region hook static and not vtabled.

2013-01-28 Thread Eric Anholt
It's now always called from the same file. --- src/mesa/drivers/dri/i915/i830_vtbl.c | 17 +++-- src/mesa/drivers/dri/i915/i915_vtbl.c | 17 +++-- src/mesa/drivers/dri/intel/intel_context.h |4 3 files changed, 14 insertions(+), 24 deletions(-) diff

[Mesa-dev] intel: Progress toward removing struct intel_region

2013-01-28 Thread Eric Anholt
Part of my motivation here was the number of cache misses we have in the first reference of a region after referencing the miptree wrapping it, for things that should all live in the first cacheline of one struct. I think I've made it as far into killing the region as I want to go before Abdiel

[Mesa-dev] [PATCH 03/10] intel: Remove the struct intel_region reuse hash table.

2013-01-28 Thread Eric Anholt
I don't see any reason for it -- it was introduced with the DRI2 invalidate work by krh in 2010 with no explanation. I suspect it was something about wanting the same drm_intel_bo struct underneath multiple openings of the BO within one process, but that's covered by libdrm at this point. As far

[Mesa-dev] [PATCH 07/10] intel: Improve the test for readpixels blit path format checking.

2013-01-28 Thread Eric Anholt
We were allowing things like copying RG1616 to a user's ARGB format, while we were denying anything that wasn't ARGB or RGB565. --- src/mesa/drivers/dri/intel/intel_pixel.c | 32 - src/mesa/drivers/dri/intel/intel_pixel.h |4

[Mesa-dev] [PATCH 04/10] intel: Remove num_mapped_regions tracking.

2013-01-28 Thread Eric Anholt
The point of tracking the value was removed in February 2012 (65b096aeddd9b45ca038f44cc9adfff86c8c48b2), and this should have been removed at the same time. --- src/mesa/drivers/dri/intel/intel_context.h |8 src/mesa/drivers/dri/intel/intel_regions.c |6 -- 2 files changed,

[Mesa-dev] [PATCH 09/10] i830: Stop tracking an array of color regions if we only use element 0.

2013-01-28 Thread Eric Anholt
--- src/mesa/drivers/dri/i915/i830_vtbl.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i915/i830_vtbl.c b/src/mesa/drivers/dri/i915/i830_vtbl.c index 1d02c2c..67b4c96 100644 --- a/src/mesa/drivers/dri/i915/i830_vtbl.c +++

[Mesa-dev] [PATCH 08/10] intel: Improve the matching (more formats!) for TexImage from PBOs.

2013-01-28 Thread Eric Anholt
Mesa core is the place for encoding what format/type matches a mesa format, so rely on that. --- src/mesa/drivers/dri/intel/intel_tex_image.c | 28 +++--- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_tex_image.c

[Mesa-dev] [PATCH 05/10] intel: Transition intel_region_map() to being a miptree operation.

2013-01-28 Thread Eric Anholt
I'm trying to move us away from the region structure, and all the callers are currently dereferencing a miptree to get the region. In this change, the map_refcount is dropped. However, the bo-virtual is itself map refcounted, so that's already dealt with. ---

[Mesa-dev] [PATCH 06/10] intel: Fold intel_region_copy() into its one caller.

2013-01-28 Thread Eric Anholt
This is similar code to intel_miptree_copy_slice, but the knobs are all set differently. --- src/mesa/drivers/dri/intel/intel_pixel_copy.c | 18 ++--- src/mesa/drivers/dri/intel/intel_regions.c| 34 - src/mesa/drivers/dri/intel/intel_regions.h| 13

[Mesa-dev] [PATCH 10/10] i915: Finish switching i915 to using miptrees instead of regions.

2013-01-28 Thread Eric Anholt
--- src/mesa/drivers/dri/i915/i830_vtbl.c | 52 - src/mesa/drivers/dri/i915/i915_vtbl.c | 58 ++-- src/mesa/drivers/dri/intel/intel_context.h |5 ++- 3 files changed, 58 insertions(+), 57 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] draw: fix draw_llvm_variant_key struct padding to avoid recompiles

2013-01-28 Thread Jose Fonseca
- Original Message - On 01/28/2013 03:45 PM, srol...@vmware.com wrote: From: Roland Scheideggersrol...@vmware.com The struct padding got broken by c789b981b244333cfc903bcd1e2fefc010500013. This caused serious performance regression because part of the key was unitialized and

[Mesa-dev] [Bug 46528] Compilation fail with LLVM under Windows 7 x64 in release

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=46528 José Fonseca jfons...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 44743] Rendering artefacts with llvmpipe

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=44743 --- Comment #7 from José Fonseca jfons...@vmware.com --- Does this still happen? If so please provide /proc/cpuinfo, as it is possible that it is tied to your particular processor settings. -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH v2] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-01-28 Thread Kenneth Graunke
On 01/28/2013 02:34 PM, Kenneth Graunke wrote: The BLT engine has many limitations. Currently, it can only blit X-tiled buffers (since we don't have a kernel API to whack the BLT tiling mode register), which means all depth/stencil operations get punted to meta code, which can be very

[Mesa-dev] [Bug 59701] lp_test_arit fails on non-sse41 capable machines, breaking make check

2013-01-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59701 José Fonseca jfons...@vmware.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |jfons...@vmware.com