Re: [Mesa-dev] [PATCH 1/3] mesa: Restore GL_FOG_COORD_SRC on glPopAttrib(GL_FOG_BIT).

2013-02-06 Thread Kenneth Graunke
On 02/05/2013 11:09 PM, Kenneth Graunke wrote: According to the OpenGL 2.1 specification, Table 6.11 (Coloring), GL_FOG_COORD_SRC is supposed to be in the fog attribute. NOTE: This is a candidate for stable branches. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [Bug 60143] gbm_dri_bo_create fails to initialize bo-base.base.format

2013-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60143 --- Comment #2 from Daniel van Vugt daniel.van.v...@canonical.com --- Created attachment 74279 -- https://bugs.freedesktop.org/attachment.cgi?id=74279action=edit gbm_dri_bo_create: Remember to initialize format -- You are receiving this mail

Re: [Mesa-dev] [PATCH] i965: Fix Vertex URB Read Length calculation in 3DSTATE_SF on Gen6.

2013-02-06 Thread Daniel Vetter
On Tue, Feb 05, 2013 at 10:40:28PM +0100, Martin Steigerwald wrote: Am Dienstag, 5. Februar 2013 schrieb Daniel Vetter: On Sat, Feb 02, 2013 at 09:22:55PM +0100, Martin Steigerwald wrote: About these messages: Uhm, bingo: merkaba:~ zgrep -i GPU hung /var/log/kern.log*

Re: [Mesa-dev] [PATCH] gallivm: fix up size queries for dx10 sviewinfo opcode

2013-02-06 Thread Jose Fonseca
Reviewed-by: Jose Fonseca jfons...@vmware.com - Original Message - From: Roland Scheidegger srol...@vmware.com Need to calculate the number of mip levels (if it would be worthwile could store it in dynamic state). While here, the query code also used chan 2 for the lod value. This

Re: [Mesa-dev] [PATCH 2/4 v4] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

2013-02-06 Thread Paul Berry
On 5 February 2013 22:40, Kenneth Graunke kenn...@whitecape.org wrote: The BLT engine has many limitations. Currently, it can only blit X-tiled buffers (since we don't have a kernel API to whack the BLT tiling mode register), which means all depth/stencil operations get punted to meta code,

Re: [Mesa-dev] [PATCH V2 15/22] mesa: implement TexImage*Multisample

2013-02-06 Thread Paul Berry
On 4 February 2013 21:48, Chris Forbes chr...@ijw.co.nz wrote: V2: - fix formatting issues - generate GL_OUT_OF_MEMORY if teximage cannot be allocated - fix for state moving from texobj to image Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/mesa/main/teximage.c | 153

Re: [Mesa-dev] [PATCH V2 18/22] i965: take the target into account for Gen7 MSAA modes

2013-02-06 Thread Paul Berry
On 4 February 2013 21:48, Chris Forbes chr...@ijw.co.nz wrote: Gen7 has an erratum affecting the ld_mcs message, making it unsafe to use when the surface doesn't have an associated MCS. Would you mind quoting the exact text of the erratum here (and citing the page number)? With that

Re: [Mesa-dev] [PATCH] R600/SI: cleanup VGPR encoding

2013-02-06 Thread Tom Stellard
On Tue, Feb 05, 2013 at 11:16:05PM +0100, Christian König wrote: From: Christian König christian.koe...@amd.com Remove all the unused code. Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Christian König christian.koe...@amd.com --- lib/Target/R600/AMDGPUAsmPrinter.cpp

Re: [Mesa-dev] [PATCH V2 20/22] i965/vs: add support for ir_txf_ms on Gen6+

2013-02-06 Thread Paul Berry
On 4 February 2013 21:48, Chris Forbes chr...@ijw.co.nz wrote: On Gen6, lower this to `ld` with lod=0 and an extra sample_index parameter. On Gen7, use `ld2dms`. This takes an additional MCS parameter to support compressed multisample surfaces, but we're not enabling them for multisample

[Mesa-dev] [PATCH] radeonsi: Use unique names for referring to texture sampling intrinsics.

2013-02-06 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Append the overloaded vector type used for passing in the addressing parameters. Without this, LLVM uses the same function signature for all those types, which cannot work. Fixes problems e.g. with FlightGear and Red Eclipse. Signed-off-by: Michel

Re: [Mesa-dev] [PATCH V2 21/22] i965/fs: add support for ir_txf_ms on Gen6+

2013-02-06 Thread Paul Berry
On 4 February 2013 21:48, Chris Forbes chr...@ijw.co.nz wrote: On Gen6, lower this to `ld` with lod=0 and an extra sample_index parameter. On Gen7, use `ld2dms`. We don't support CMS yet for multisample textures, so we use MCS=0, which does the right thing for both IMS and UMS surfaces.

Re: [Mesa-dev] [PATCH 1/3] mesa: Restore GL_FOG_COORD_SRC on glPopAttrib(GL_FOG_BIT).

2013-02-06 Thread Brian Paul
On 02/06/2013 01:28 AM, Kenneth Graunke wrote: On 02/05/2013 11:09 PM, Kenneth Graunke wrote: According to the OpenGL 2.1 specification, Table 6.11 (Coloring), GL_FOG_COORD_SRC is supposed to be in the fog attribute. NOTE: This is a candidate for stable branches. Signed-off-by: Kenneth

Re: [Mesa-dev] [PATCH V2 00/22] Add ARB_texture_multisample support

2013-02-06 Thread Paul Berry
On 5 February 2013 11:34, Paul Berry stereotype...@gmail.com wrote: On 4 February 2013 21:48, Chris Forbes chr...@ijw.co.nz wrote: This series adds the core mesa bits and i965 driver support for ARB_texture_multisample. Big changes from V1: - Generally cleaner - GLSL texelFetch()

[Mesa-dev] [PATCH] radeonsi: Handle scaled and integer formats for samplers and vertex elements.

2013-02-06 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Also, add assertions to stress that render targets don't support scaled formats. 20 more little piglits. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- Updated, more extensive patch for 2 extra little piglits.

[Mesa-dev] [PATCH] R600: Do not fold modifier/litterals in vector inst

2013-02-06 Thread Vincent Lejeune
This fixes a couple of regressions on (probably not just) cayman --- lib/Target/R600/AMDILISelDAGToDAG.cpp | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Target/R600/AMDILISelDAGToDAG.cpp b/lib/Target/R600/AMDILISelDAGToDAG.cpp index 84223f6..7fc3a2f 100644 ---

[Mesa-dev] [PATCH 2/2] softpipe: fix using optimized filter function

2013-02-06 Thread sroland
From: Roland Scheidegger srol...@vmware.com This optimized filter (when using repeat wrap modes, linear min/mag/mip filters, pot textures) only applies to 2d textures, but nothing prevented it from being used for other textures (likely leading to very bogus sample results). Note: This is a

[Mesa-dev] [PATCH 1/2] softpipe: clean up lod computation

2013-02-06 Thread sroland
From: Roland Scheidegger srol...@vmware.com This should handle the new lod_zero modifier more correctly. The runtime-conditional is a bit more complex however we now also do scalar lod computation when appropriate which should more than make up for it. The refactoring should also fix an issue

[Mesa-dev] [PATCH] Consolidate some redundant definitions of ARRAY_SIZE() macro.

2013-02-06 Thread Paul Berry
Previous to this patch, there were 13 identical definitions of this macro in Mesa source. That's ridiculous. This patch consolidates 6 of them to a single definition in src/mesa/main/macros.h. Unfortunately, I wasn't able to eliminate the remaining definitions, since they occur in places that

Re: [Mesa-dev] [PATCH] Consolidate some redundant definitions of ARRAY_SIZE() macro.

2013-02-06 Thread Kenneth Graunke
On 02/06/2013 10:43 AM, Paul Berry wrote: Previous to this patch, there were 13 identical definitions of this macro in Mesa source. That's ridiculous. This patch consolidates 6 of them to a single definition in src/mesa/main/macros.h. Unfortunately, I wasn't able to eliminate the remaining

[Mesa-dev] [PATCH] intel/pre-gen6: Disable EXT_framebuffer_multisample.

2013-02-06 Thread Paul Berry
Previously, the i965 driver enabled EXT_framebuffer_multisample even on pre-gen6 chipsets. However, since we don't support multisampling on these chips, we set GL_MAX_SAMPLES=1 (the minimum allowed by EXT_framebuffer_multisample), and if the client ever requested a multisample buffer, we quietly

Re: [Mesa-dev] [PATCH 1/2] intel: fail to compile in case of bad uniform access

2013-02-06 Thread Frank Henigman
On Mon, Jan 28, 2013 at 9:50 PM, Ian Romanick i...@freedesktop.org wrote: On 01/28/2013 05:06 PM, Frank Henigman wrote: An assertion in fs_visitor::remove_dead_**constants() would fail on code like this, which accesses a non-existent uniform: uniform vec u[1]; ... a += u[0] +

[Mesa-dev] [Bug 60086] Wayland platform backend crashes if there's no back buffer during dri2_swap_buffers

2013-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60086 Kristian Høgsberg k...@bitplanet.net changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |k...@bitplanet.net

Re: [Mesa-dev] [PATCH] mesa: Always assume EXT_fog_coord support.

2013-02-06 Thread Matt Turner
On Wed, Feb 6, 2013 at 11:42 AM, Kenneth Graunke kenn...@whitecape.org wrote: All drivers (Gallium, classic i915, i965, radeon, r200, nouveau, and swrast) supported it. This patch enables it universally and removes the gl_extensions enable bit in favor of dummy_true. Signed-off-by: Kenneth

[Mesa-dev] [Bug 60143] gbm_dri_bo_create fails to initialize bo-base.base.format

2013-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60143 --- Comment #3 from Kristian Høgsberg k...@bitplanet.net --- (In reply to comment #2) Created attachment 74279 [details] [review] gbm_dri_bo_create: Remember to initialize format That looks good, but please also fix create_dumb() and attach

Re: [Mesa-dev] [PATCH] egl/dri: Don't invoke dri2_dpy-flush if it's NULL.

2013-02-06 Thread Kristian Høgsberg
On Tue, Feb 5, 2013 at 8:43 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com I'd like to test Mesa OpenGL ES along side with NVIDIA libGL drivers. But without this change, I get a NULL pointer dereference. Which DRI driver doesn't support the flush extension? EGL is

Re: [Mesa-dev] [PATCH] egl/dri: Don't invoke dri2_dpy-flush if it's NULL.

2013-02-06 Thread Kristian Høgsberg
On Wed, Feb 6, 2013 at 4:30 PM, Kristian Høgsberg k...@bitplanet.net wrote: On Tue, Feb 5, 2013 at 8:43 AM, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com I'd like to test Mesa OpenGL ES along side with NVIDIA libGL drivers. But without this change, I get a NULL pointer

Re: [Mesa-dev] [PATCH] mesa: Always assume EXT_fog_coord support.

2013-02-06 Thread Anuj Phogat
On Wed, Feb 6, 2013 at 11:42 AM, Kenneth Graunke kenn...@whitecape.org wrote: All drivers (Gallium, classic i915, i965, radeon, r200, nouveau, and swrast) supported it. This patch enables it universally and removes the gl_extensions enable bit in favor of dummy_true. Signed-off-by: Kenneth

[Mesa-dev] RFC: Considering changing Mesa's interpretation of when is the flat keyword is required.

2013-02-06 Thread Paul Berry
Background: All of the GLSL specs from GLSL 1.30 (and GLSL ES 3.00) onward contain language requiring certain integer variables to be declared with the flat keyword, but they differ in exactly *when* the rule is enforced: (a) GLSL 1.30 and 1.40 say that vertex shader outputs having integral type

[Mesa-dev] [Bug 49779] Extra line segments in GL_LINE_LOOP

2013-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49779 Eric Anholt e...@anholt.net changed: What|Removed |Added Priority|medium |low

Re: [Mesa-dev] [PATCH] intel/pre-gen6: Disable EXT_framebuffer_multisample.

2013-02-06 Thread Eric Anholt
Paul Berry stereotype...@gmail.com writes: Previously, the i965 driver enabled EXT_framebuffer_multisample even on pre-gen6 chipsets. However, since we don't support multisampling on these chips, we set GL_MAX_SAMPLES=1 (the minimum allowed by EXT_framebuffer_multisample), and if the client

[Mesa-dev] [PATCH 1/3] mesa: don't use _mesa_base_tex_format for format parameter of GetTexImage

2013-02-06 Thread Marek Olšák
_mesa_base_tex_format doesn't accept GL_BGR and GL_ABGR_EXT. NOTE: This is a candidate for the stable branches. --- src/mesa/main/texgetimage.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index

[Mesa-dev] [PATCH 2/3] mesa: don't use memcpy fast path for GetTexImage if base format is different

2013-02-06 Thread Marek Olšák
The Mesa format can be RGBA_REV, the format/type can be GL_RGBA/GL_UNSIGNED_BYTE, but the actual texture internal format can be LUMINANCE_ALPHA, INTENSITY, etc. Therefore we should look at the base internal format as well. NOTE: This is a candidate for the stable branches. ---

[Mesa-dev] [PATCH 3/3] mesa: fix GetTexImage if mesa format and internal format don't match

2013-02-06 Thread Marek Olšák
Tested with softpipe only exposing RGBA formats. NOTE: This is a candidate for the stable branches. --- src/mesa/main/pack.c| 26 + src/mesa/main/texgetimage.c | 45 +++ 2 files changed, 71 insertions(+) diff --git

[Mesa-dev] [PATCH 4/6] i965: Remove writemask support from brw_SAMPLE().

2013-02-06 Thread Eric Anholt
The code was rather broken for non-XYZW on 8-wide, but all of our callers were using XYZW anyway. For my experiments with using writemask on texturing, I've been using manual header setup in the compiler backends, since we want to actually know what registers are written for optimization and

[Mesa-dev] [PATCH 5/6] i965: Re-enable the -RHW workaround for original gen4 chips.

2013-02-06 Thread Eric Anholt
Fixes broken clipping in supertuxkart and presumably many other applications. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51471 NOTE: Candidate for the stable branches. --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 20 1 file changed, 8 insertions(+), 12

Re: [Mesa-dev] RFC: Considering changing Mesa's interpretation of when is the flat keyword is required.

2013-02-06 Thread Kenneth Graunke
On 02/06/2013 02:10 PM, Paul Berry wrote: Background: All of the GLSL specs from GLSL 1.30 (and GLSL ES 3.00) onward contain language requiring certain integer variables to be declared with the flat keyword, but they differ in exactly *when* the rule is enforced: (a) GLSL 1.30 and 1.40 say

Re: [Mesa-dev] [PATCH 1/3] R600: fix PHI value adding in the structurizer

2013-02-06 Thread Tom Stellard
Hi Christian, I'm still unable to get the glsl1-while-loop with continue test to pass on R600 with the new structurizer. For this test, the structurizer is producing strange code and I'm not sure if it is correct. I have attached the full before and after dumps to this email. Here is the

[Mesa-dev] [Bug 60395] Developer account request

2013-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60395 --- Comment #1 from commanderan...@yahoo.com --- Created attachment 74318 -- https://bugs.freedesktop.org/attachment.cgi?id=74318action=edit GPG Key -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 60395] New: Developer account request

2013-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60395 Priority: medium Bug ID: 60395 Assignee: mesa-dev@lists.freedesktop.org Summary: Developer account request Severity: normal Classification: Unclassified OS: All

[Mesa-dev] [PATCH] nv30: Fix memory leak.

2013-02-06 Thread Vinson Lee
Fixes resource leak defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/drivers/nv30/nv30_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nv30/nv30_screen.c b/src/gallium/drivers/nv30/nv30_screen.c index f3faf8a..7825697

[Mesa-dev] [Bug 60395] Developer account request

2013-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60395 --- Comment #2 from Matt Turner matts...@gmail.com --- Have you contributed to Mesa before? Usually we want a history of contributions. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [PATCH 1/3] i965: Fix INTEL_DEBUG=shader_time for Haswell.

2013-02-06 Thread Kenneth Graunke
Haswell's Data Cache data port is a single unit, but split into two SFIDs to allow for more message types without adding more bits in the message descriptor. Untyped Atomic Operations are now message 0010 in the second data cache data port, rather than 6 in the first. NOTE: This is a candidate

[Mesa-dev] (no subject)

2013-02-06 Thread Kenneth Graunke
This mini-series fixes some bugs I discovered with INTEL_DEBUG=shader_time. Patch 1 is critical: without it, enabling shader time caused GPU hangs on Haswell because we were sending the wrong message to the wrong shared function. Patches 2 and 3 are less clear cut. From my reading of the

[Mesa-dev] [PATCH 2/3] i965: Specialize SURFACE_STATE creation for shader time.

2013-02-06 Thread Kenneth Graunke
This is basically a copy and paste of gen7_create_constant_surface, but with the parameters filled in to offer a simpler interface. It will diverge shortly. I didn't bother adding it to the vtable for now since shader time is only exposed on Gen7+. NOTE: This is a candidate for the 9.1 branch.

[Mesa-dev] [PATCH 3/3] i965: Make INTEL_DEBUG=shader_time use the RAW surface format.

2013-02-06 Thread Kenneth Graunke
Untyped Atomic Operation messages are illegal for non-RAW formats. I have no idea why it worked before; the documentation claims it shouldn't be allowed and the simulator enforces it. Some arithmetic sleight of hand happens in this patch: Previously, we allocated a R32G32B32A32 buffer. However,