[Mesa-dev] [PATCH] u_blitter: don't create illegal shaders for 1D/3D/RECT/CUBE MSAA

2013-03-04 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com I hit an assert playing with softpipe and texture MSAA today, makes me think we might need something like this to stop creating illegal shaders. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/auxiliary/util/u_blitter.c | 5 + 1 file

Re: [Mesa-dev] [RFC] OES_external_image for i965

2013-03-04 Thread Pohjolainen, Topi
On Fri, Mar 01, 2013 at 10:03:45AM -0500, Kristian H?gsberg wrote: On Fri, Mar 1, 2013 at 3:51 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Tue, Feb 26, 2013 at 04:05:25PM +, Tom Cooksey wrote: Hi Topi, The second more or less questionable part is the support for

Re: [Mesa-dev] [PATCH 2/2] st/mesa: add switch case for ir_txf_ms to silence warning

2013-03-04 Thread Roland Scheidegger
Am 02.03.2013 04:26, schrieb Dave Airlie: On Sat, Mar 2, 2013 at 12:02 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2013 01:36, schrieb Brian Paul: --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

Re: [Mesa-dev] multisample clears

2013-03-04 Thread Roland Scheidegger
Am 04.03.2013 04:54, schrieb Dave Airlie: I've been playing with softpipe msaa on and off, but I hit a problem with the clears and am just wondering if the state tracker should be doing something like this. Or maybe only if any bound buffer has nr_samples 1, or fallback to the non-quad

Re: [Mesa-dev] [PATCH 1/4] gallium: add get_sample_position interface

2013-03-04 Thread Roland Scheidegger
Am 03.03.2013 21:27, schrieb Dave Airlie: From: Dave Airlie airl...@redhat.com This is to be used to implement glGet GL_SAMPLE_POSITION. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/include/pipe/p_context.h | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [Bug 61764] invalid enum in glEnable, glConvolutionFilter, glSeparableFilter, glColorTable

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61764 Roland Scheidegger srol...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 61761] glPolygonOffsetEXT, OFFSET_BIAS incorrectly set to a huge number

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61761 --- Comment #1 from Roland Scheidegger srol...@vmware.com --- Looks like when using PolygonOffsetEXT() mesa will multiply the bias value by _DepthMaxF to set offset units (hence the same as calling PolygonOffset(). But the get will just return

Re: [Mesa-dev] [PATCH 2/2] st/mesa: add switch case for ir_txf_ms to silence warning

2013-03-04 Thread Marek Olšák
On Mon, Mar 4, 2013 at 11:53 AM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2013 04:26, schrieb Dave Airlie: On Sat, Mar 2, 2013 at 12:02 PM, Roland Scheidegger srol...@vmware.com wrote: Am 02.03.2013 01:36, schrieb Brian Paul: --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |

Re: [Mesa-dev] [PATCH] u_blitter: don't create illegal shaders for 1D/3D/RECT/CUBE MSAA

2013-03-04 Thread Marek Olšák
The conditional should be if (i 1 ..; with that fixed, this is: Reviewed-by: Marek Olšák mar...@gmail.com Marek On Mon, Mar 4, 2013 at 9:02 AM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com I hit an assert playing with softpipe and texture MSAA today, makes me

Re: [Mesa-dev] [PATCH 4/4] r600g: add support for remaining bits for multisample texture

2013-03-04 Thread Marek Olšák
The sample positions can be found in r600_emit_msaa_state, evergreen_emit_msaa_state, and cayman_emit_msaa_state, though extracting them from the arrays might not be so straightforward. Marek On Sun, Mar 3, 2013 at 9:27 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie

Re: [Mesa-dev] multisample clears

2013-03-04 Thread Marek Olšák
On Mon, Mar 4, 2013 at 4:54 AM, Dave Airlie airl...@gmail.com wrote: I've been playing with softpipe msaa on and off, but I hit a problem with the clears and am just wondering if the state tracker should be doing something like this. Or maybe only if any bound buffer has nr_samples 1, or

[Mesa-dev] [PATCH 1/2] dri: Support depth-15 Visuals

2013-03-04 Thread Chris Wilson
Note: This is a candidate for the stable branches. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- src/mesa/drivers/dri/common/utils.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/utils.c index

[Mesa-dev] [PATCH 2/2] intel: Support depth-15 Visuals

2013-03-04 Thread Chris Wilson
Note: This is a candidate for the stable branches. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- src/mesa/drivers/dri/intel/intel_screen.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c

Re: [Mesa-dev] [PATCH 3/4] st/mesa: add support for ARB_texture_multisample

2013-03-04 Thread Marek Olšák
On Sun, Mar 3, 2013 at 9:27 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This adds support to the mesa state tracker for ARB_texture_multisample. hardware doesn't seem to use a different texture instructions, so I don't think we need to create one for TGSI at

[Mesa-dev] [Bug 60121] build - libvdpau_softpipe fails at runtime.

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60121 Andy Furniss li...@andyfurniss.entadsl.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 61764] invalid enum in glEnable, glConvolutionFilter, glSeparableFilter, glColorTable

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61764 --- Comment #2 from Blaž Hrastnik speed.the.b...@gmail.com --- I'd still argue that this is a bug. If the extensions were removed, their implementation should be fully removed (as in, these functions, especially the EXT/ARB versions of them

Re: [Mesa-dev] [PATCH 2/6] r600g: cleanup #include recursion between r600_pipe.h and evergreen_compute.h

2013-03-04 Thread Tom Stellard
On Fri, Mar 01, 2013 at 05:55:31PM +0100, Marek Olšák wrote: Patches 2-4 are: Reviewed-by: Tom Stellard thomas.stell...@amd.com Thanks for working on this, it is a nice improvement. -Tom --- src/gallium/drivers/r600/compute_memory_pool.c|1 +

Re: [Mesa-dev] [RFC] OES_external_image for i965

2013-03-04 Thread Kristian Høgsberg
On Mon, Mar 4, 2013 at 4:55 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Fri, Mar 01, 2013 at 10:03:45AM -0500, Kristian H?gsberg wrote: On Fri, Mar 1, 2013 at 3:51 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Tue, Feb 26, 2013 at 04:05:25PM +, Tom Cooksey

Re: [Mesa-dev] [RFC] OES_external_image for i965

2013-03-04 Thread Pohjolainen, Topi
On Mon, Mar 04, 2013 at 09:56:34AM -0500, Kristian H?gsberg wrote: On Mon, Mar 4, 2013 at 4:55 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Fri, Mar 01, 2013 at 10:03:45AM -0500, Kristian H?gsberg wrote: On Fri, Mar 1, 2013 at 3:51 AM, Pohjolainen, Topi

Re: [Mesa-dev] [PATCH] r600g: allocate FMASK right after the texture, so that it's aligned with it

2013-03-04 Thread Jerome Glisse
On Sun, Mar 3, 2013 at 9:13 AM, Marek Olšák mar...@gmail.com wrote: This avoids the kernel CS checker errors with MSAA textures. Reviewed-by: Jerome Glisse jgli...@redhat.com --- src/gallium/drivers/r600/r600_texture.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/6] r600g: inline r600_pipe_shader function

2013-03-04 Thread Jerome Glisse
On Sun, Mar 3, 2013 at 8:39 AM, Marek Olšák mar...@gmail.com wrote: also change names of other functions, so that they make sense For the serie: Reviewed-by: Jerome Glisse jgli...@redhat.com --- src/gallium/drivers/r600/evergreen_state.c |4 +- src/gallium/drivers/r600/r600_pipe.h

Re: [Mesa-dev] [PATCH 1/5] r600g: unify vgt states

2013-03-04 Thread Jerome Glisse
On Wed, Feb 27, 2013 at 6:11 PM, Marek Olšák mar...@gmail.com wrote: The states were split because we thought it caused a hardlock. Now we know the hardlock was caused by something else and has since been fixed. For the serie: Reviewed-by: Jerome Glisse jgli...@redhat.com ---

[Mesa-dev] [Bug 61395] glEdgeFlag can't be set to false

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61395 Brian Paul bri...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [RFC] OES_external_image for i965

2013-03-04 Thread Kristian Høgsberg
On Mon, Mar 4, 2013 at 10:11 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Mon, Mar 04, 2013 at 09:56:34AM -0500, Kristian H?gsberg wrote: On Mon, Mar 4, 2013 at 4:55 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Fri, Mar 01, 2013 at 10:03:45AM -0500, Kristian

[Mesa-dev] [Bug 61764] invalid enum in glEnable, glConvolutionFilter, glSeparableFilter, glColorTable

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61764 --- Comment #3 from Roland Scheidegger srol...@vmware.com --- (In reply to comment #2) I'd still argue that this is a bug. If the extensions were removed, their implementation should be fully removed (as in, these functions, especially the

Re: [Mesa-dev] [PATCH 2/4] st/mesa: add support for get sample position

2013-03-04 Thread Brian Paul
Just minor formatting nits below. On 03/03/2013 01:27 PM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com This just calls into the gallium interface. Signed-off-by: Dave Airlieairl...@redhat.com --- src/mesa/sources.mak| 1 + src/mesa/state_tracker/st_cb_msaa.c | 52

Re: [Mesa-dev] [PATCH 1/4] gallium: add get_sample_position interface

2013-03-04 Thread Brian Paul
On 03/03/2013 01:27 PM, Dave Airlie wrote: From: Dave Airlieairl...@redhat.com This is to be used to implement glGet GL_SAMPLE_POSITION. Signed-off-by: Dave Airlieairl...@redhat.com --- src/gallium/include/pipe/p_context.h | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [Bug 61764] invalid enum in glEnable, glConvolutionFilter, glSeparableFilter, glColorTable

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61764 --- Comment #4 from Blaž Hrastnik speed.the.b...@gmail.com --- Ah yes, I have found that bit later in the documentation. Thank you for clarification! -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 61761] glPolygonOffsetEXT, OFFSET_BIAS incorrectly set to a huge number

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61761 --- Comment #2 from Brian Paul bri...@vmware.com --- I wonder if we should just drop the GL_EXT_polygon_offset extension. I see that NVIDIA doesn't advertise it. -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 61761] glPolygonOffsetEXT, OFFSET_BIAS incorrectly set to a huge number

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61761 --- Comment #3 from Roland Scheidegger srol...@vmware.com --- I guess if nvidia doesn't advertize it (and by the looks of it they never did) it should be safe to remove (and amd doesn't seem to advertize it neither in their closed-source

[Mesa-dev] [PATCH 2/2] configure.ac: Remove stale comment about --x-* arguments.

2013-03-04 Thread Matt Turner
Should have been removed with e273ed37. --- configure.ac |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 1b13d06..ea56a04 100644 --- a/configure.ac +++ b/configure.ac @@ -832,12 +832,6 @@ if test x$enable_dri = xyes; then fi fi

Re: [Mesa-dev] [PATCH] Fix build of swrast only without libdrm

2013-03-04 Thread Matt Turner
On Thu, Feb 28, 2013 at 10:39 AM, Daniel Martin consume.no...@gmail.com wrote: Signed-off-by: Daniel Martin consume.no...@gmail.com --- There's a small logic error preventing mesa to be build with swrast only and not having libdrm. v2: || test replaced by -a configure.ac | 2 +- 1 file

Re: [Mesa-dev] [PATCH] r600g/radeonsi: unreference previous fence in flush

2013-03-04 Thread Michel Dänzer
On Mon, 2013-03-04 at 13:17 -0500, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com Some code calling the flush function gave a fence pointer that point to an old fence and should be unreference to avoid leaking fence. Candidate for 9.1 Signed-off-by: Jerome Glisse

Re: [Mesa-dev] [PATCH] r600g/radeonsi: unreference previous fence in flush

2013-03-04 Thread Jerome Glisse
On Mon, Mar 4, 2013 at 2:05 PM, Michel Dänzer mic...@daenzer.net wrote: On Mon, 2013-03-04 at 13:17 -0500, j.gli...@gmail.com wrote: From: Jerome Glisse jgli...@redhat.com Some code calling the flush function gave a fence pointer that point to an old fence and should be unreference to avoid

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't check for X11 unconditionally.

2013-03-04 Thread Brian Paul
On 03/04/2013 11:31 AM, Matt Turner wrote: X11 is already checked conditionally below. Fixes OSMesa-only configurations to not require X11. --- configure.ac |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 7852595..1b13d06

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Don't check for X11 unconditionally.

2013-03-04 Thread Matt Turner
On Mon, Mar 4, 2013 at 11:14 AM, Brian Paul bri...@vmware.com wrote: On 03/04/2013 11:31 AM, Matt Turner wrote: X11 is already checked conditionally below. Fixes OSMesa-only configurations to not require X11. --- configure.ac |8 1 files changed, 0 insertions(+), 8

[Mesa-dev] [PATCH] mesa: Allow ETC2/EAC formats with ARB_ES3_compatibility.

2013-03-04 Thread Matt Turner
Reported-by: Marek Olšák mar...@gmail.com --- src/mesa/main/teximage.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 0dcf88a..e5260d1 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@

Re: [Mesa-dev] [PATCH] mesa: Allow ETC2/EAC formats with ARB_ES3_compatibility.

2013-03-04 Thread Ian Romanick
On 03/04/2013 11:38 AM, Matt Turner wrote: Reported-by: Marek Olšák mar...@gmail.com Do our ETC2 piglit tests run in this mode? It would be good to see this change actually fix a bug by making a failing test pass. :) --- src/mesa/main/teximage.c |2 +- 1 files changed, 1

[Mesa-dev] [PATCH] mesa: don't allocate a texture if width or height is 0 in CopyTexImage

2013-03-04 Thread Marek Olšák
--- src/mesa/main/teximage.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 0dcf88a..a7b88d1 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -3494,19 +3494,21 @@

Re: [Mesa-dev] [PATCH] mesa: Allow ETC2/EAC formats with ARB_ES3_compatibility.

2013-03-04 Thread Anuj Phogat
On Mon, Mar 4, 2013 at 11:38 AM, Matt Turner matts...@gmail.com wrote: Reported-by: Marek Olšák mar...@gmail.com --- src/mesa/main/teximage.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 0dcf88a..e5260d1

[Mesa-dev] [PATCH 2/3] llvmpipe: add some scene limit sanity check assertions

2013-03-04 Thread Brian Paul
Note: This is a candidate for the stable branches. --- src/gallium/drivers/llvmpipe/lp_scene.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_scene.c b/src/gallium/drivers/llvmpipe/lp_scene.c index fec2f74..8056906

[Mesa-dev] [PATCH 1/3] llvmpipe: tweak CMD_BLOCK_MAX and LP_SCENE_MAX_SIZE

2013-03-04 Thread Brian Paul
We advertise a max texture/surfaces size of 8K x 8K but the old values for these limits didn't actually allow us to handle that surface size. For 8K x 8K we'll have 16384 bins. Each bin needs at least one cmd_block object which was 2192 bytes in size. Since 16384 * 2192 exceeded

[Mesa-dev] [PATCH 3/3] llvmpipe: remove unused cmd_block_list struct

2013-03-04 Thread Brian Paul
--- src/gallium/drivers/llvmpipe/lp_scene.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_scene.h b/src/gallium/drivers/llvmpipe/lp_scene.h index 801829d..1d0cd0e 100644 --- a/src/gallium/drivers/llvmpipe/lp_scene.h +++

[Mesa-dev] [PATCH 1/2] i965: Fix off-by-one in query object result gathering.

2013-03-04 Thread Kenneth Graunke
If we've written N pairs of values to the buffer, then last_index = N, but the values are 0 .. N-1. Thus, we need to use , not =. This worked anyway because we fill the buffer with zeroes, so we just added an extra (0 - 0) to our results. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [PATCH 2/2] i965: Don't fill buffer with zeroes.

2013-03-04 Thread Kenneth Graunke
This was only necessary because our bounds checking was off by one, and thus we read an extra pair of values. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_queryobj.c | 6 -- 1 file changed, 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: Allow ETC2/EAC formats with ARB_ES3_compatibility.

2013-03-04 Thread Anuj Phogat
On Mon, Mar 4, 2013 at 11:41 AM, Ian Romanick i...@freedesktop.org wrote: On 03/04/2013 11:38 AM, Matt Turner wrote: Reported-by: Marek Olšák mar...@gmail.com Do our ETC2 piglit tests run in this mode? It would be good to see this change actually fix a bug by making a failing test pass. :)

Re: [Mesa-dev] [PATCH 2/3] llvmpipe: add some scene limit sanity check assertions

2013-03-04 Thread Roland Scheidegger
Am 04.03.2013 23:04, schrieb Brian Paul: Note: This is a candidate for the stable branches. --- src/gallium/drivers/llvmpipe/lp_scene.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_scene.c

Re: [Mesa-dev] [PATCH 1/2] i965: Fix off-by-one in query object result gathering.

2013-03-04 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: If we've written N pairs of values to the buffer, then last_index = N, but the values are 0 .. N-1. Thus, we need to use , not =. This worked anyway because we fill the buffer with zeroes, so we just added an extra (0 - 0) to our results. This

[Mesa-dev] [Bug 61827] New: [softpipe] piglit fbo-clear-formats GL_ARB_depth_buffer_float stencil regression

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61827 Priority: medium Bug ID: 61827 Keywords: regression CC: anuj.pho...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe] piglit fbo-clear-formats

[Mesa-dev] [Bug 61828] New: [softpipe] tgsi/tgsi_exec.c:1936:exec_tex: Assertion `modifier != 1' failed.

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61828 Priority: medium Bug ID: 61828 Keywords: have-backtrace, regression CC: srol...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [softpipe]

[Mesa-dev] [Bug 61828] [softpipe] tgsi/tgsi_exec.c:1936:exec_tex: Assertion `modifier != 1' failed.

2013-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61828 --- Comment #1 from Roland Scheidegger srol...@vmware.com --- Whoa I thought noone ever defined TXP for array textures. But it turns out I was wrong since apparently GL_MESA_texture_array supports array textures even with fixed function hence

Re: [Mesa-dev] [PATCH] texobj: add verbose api trace messages to several routines

2013-03-04 Thread Carl Worth
Jose Fonseca jfons...@vmware.com writes: I see. But one can use apitrace through LD_LIBRARY_PATH instead of LD_PRELOAD. Steam is not the first app to have issues with LD_PRELOAD. I spend some time looking at this issue today. First, things aren't as bad as I had first thought. I had

[Mesa-dev] [RFC] egl/dri2: Add Mir platform backend

2013-03-04 Thread christopher . halse . rogers
From: Christopher James Halse Rogers r...@ubuntu.com A first pass at a Mir platform for EGL. This is RFC mainly because I hope to shortly make Mir's API less painfully pointless-callback-based. There's no point in committing this as-is, but it's hopefully still useful to review. ---