[Mesa-dev] [PATCH] st/mesa: fix temp texture bindings in st_CopyPixels()

2013-06-13 Thread Chia-I Wu
The temporary texture should have either PIPE_BIND_RENDER_TARGET or PIPE_BIND_DEPTH_STENCIL set in addition to PIPE_BIND_SAMPLER_VIEW. Signed-off-by: Chia-I Wu olva...@gmail.com --- src/mesa/state_tracker/st_cb_drawpixels.c | 30 + 1 file changed, 13 insertions(+),

Re: [Mesa-dev] [PATCH] st/mesa: fix temp texture bindings in st_CopyPixels()

2013-06-13 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com Marek On Thu, Jun 13, 2013 at 11:11 AM, Chia-I Wu olva...@gmail.com wrote: The temporary texture should have either PIPE_BIND_RENDER_TARGET or PIPE_BIND_DEPTH_STENCIL set in addition to PIPE_BIND_SAMPLER_VIEW. Signed-off-by: Chia-I Wu

[Mesa-dev] [PATCH 0/6] Eliminating unused built-in varyings

2013-06-13 Thread Marek Olšák
Hi everyone, this series adds a new GLSL compiler optimization pass which eliminates unused and set-but-unused built-in varyings and adds a few improvements to the GLSL linker in the process. Before I show you how it works, I wanna say that there are patches which are related to and will most

[Mesa-dev] [PATCH 1/6] mesa, gallium: renumber shader indices according to their placement in pipeline

2013-06-13 Thread Marek Olšák
See my explanation in mtypes.h. --- src/gallium/include/pipe/p_defines.h |7 --- src/glsl/linker.cpp| 16 src/mesa/drivers/dri/i965/brw_shader.cpp |8 ++-- src/mesa/main/mtypes.h |8 ++--

[Mesa-dev] [PATCH 2/6] glsl/linker: link shaders in the opposite order (from fragment to vertex)

2013-06-13 Thread Marek Olšák
This ensures that inter-shader outputs and inputs are properly eliminated across 3 or more shader stages. The behavior is unchanged with 2 or less shader stages. For example, elimination of unused FS inputs causes elimination of matching GS outputs, which causes elimination of the GS inputs that

[Mesa-dev] [PATCH 3/6] glsl/linker: check against varying limit after unused varyings are eliminated

2013-06-13 Thread Marek Olšák
We counted even the varyings which were later eliminated, which was suboptimal. --- src/glsl/link_varyings.cpp | 35 --- src/glsl/link_varyings.h |5 + src/glsl/linker.cpp|4 3 files changed, 33 insertions(+), 11 deletions(-) diff

[Mesa-dev] [PATCH 4/6] glsl/linker: eliminate unused and set-but-unused built-in varyings

2013-06-13 Thread Marek Olšák
This eliminates built-in varyings such as gl_Color, gl_SecondaryColor, gl_TexCoord, and gl_FogFragCoord if they are unused by the next stage or not written at all (e.g. gl_TexCoord elements). The gl_TexCoord array is broken down into separate vec4s if needed. --- src/glsl/Makefile.sources

[Mesa-dev] [PATCH 5/6] st/mesa: disable EXT_separate_shader_objects

2013-06-13 Thread Marek Olšák
The extension disallows elimination of set-but-unused varyings. --- docs/relnotes/9.2.html |3 +++ src/mesa/state_tracker/st_extensions.c |9 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/docs/relnotes/9.2.html b/docs/relnotes/9.2.html index

[Mesa-dev] [PATCH 6/6] mesa, glsl, gallium: remove GLSLSkipStrictMaxVaryingLimitCheck and dependencies

2013-06-13 Thread Marek Olšák
Not needed with do_dead_builtin_varyings. --- src/gallium/drivers/freedreno/freedreno_screen.c |1 - src/gallium/drivers/i915/i915_screen.c |1 - src/gallium/drivers/ilo/ilo_screen.c |1 - src/gallium/drivers/llvmpipe/lp_screen.c |1 -

Re: [Mesa-dev] [PATCH 7/8] util: Expand the comment above the channel[] array

2013-06-13 Thread Richard Sandiford
Michel Dänzer mic...@daenzer.net writes: On Die, 2013-06-11 at 16:26 +0100, Richard Sandiford wrote: Signed-off-by: Richard Sandiford rsand...@linux.vnet.ibm.com --- src/gallium/auxiliary/util/u_format.h | 42 ++- 1 file changed, 41 insertions(+), 1

[Mesa-dev] [Bug 65714] New: Champions of Regnum dont show characters!

2013-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65714 Priority: medium Bug ID: 65714 Assignee: mesa-dev@lists.freedesktop.org Summary: Champions of Regnum dont show characters! Severity: normal Classification: Unclassified OS:

Re: [Mesa-dev] R600 Patches: Add support for the local address space

2013-06-13 Thread Tom Stellard
On Wed, Jun 12, 2013 at 06:37:39PM -0700, Matt Arsenault wrote: On 06/12/2013 05:42 PM, Tom Stellard wrote: Hi, The attached patches add support for local address space on Evergreen / Northern Islands GPUs. Please Review. -Tom + def int_AMDGPU_barrier_local : Intrinsic[], [], [];

[Mesa-dev] [Bug 65714] Champions of Regnum dont show characters!

2013-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65714 --- Comment #1 from Alex Deucher ag...@yahoo.com --- Does the ppa enable LLVM? If so does setting env var R600_LLVM=0 help? -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 65714] Champions of Regnum dont show characters!

2013-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65714 Alex Deucher ag...@yahoo.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 1/6] mesa, gallium: renumber shader indices according to their placement in pipeline

2013-06-13 Thread Brian Paul
On 06/13/2013 06:25 AM, Marek Olšák wrote: See my explanation in mtypes.h. --- src/gallium/include/pipe/p_defines.h |7 --- src/glsl/linker.cpp| 16 src/mesa/drivers/dri/i965/brw_shader.cpp |8 ++-- src/mesa/main/mtypes.h

[Mesa-dev] [PATCH] draw: fix a regression in computing max elt

2013-06-13 Thread Zack Rusin
gl can use elts without setting indices, in which case our eltMax was set to 0 and always invoking the overflow condition. So by default set eltMax to maximum, it will be curbed by draw_set_indexes (if it ever comes) and if not then it will let gl's glVertexPointer/glDrawArrays work correctly.

Re: [Mesa-dev] [PATCH] draw: fix a regression in computing max elt

2013-06-13 Thread Jose Fonseca
Sounds good. Thanks for tracking this down! Jose - Original Message - gl can use elts without setting indices, in which case our eltMax was set to 0 and always invoking the overflow condition. So by default set eltMax to maximum, it will be curbed by draw_set_indexes (if it ever

[Mesa-dev] [PATCH] i965/vs: Combine code generation's inst-opcode switch statements.

2013-06-13 Thread Kenneth Graunke
vec4_visitor::generate_code() switches on vec4_instruction::opcode and calls into the brw_eu_emit.c layer to generate code for some of them. It then has a default case which calls generate_vec4_instruction() to handle the rest...which switches on opcode and handles the rest of the cases. The

Re: [Mesa-dev] [PATCH 7/8] util: Expand the comment above the channel[] array

2013-06-13 Thread Will Schmidt
On Thu, 2013-06-13 at 14:50 +0100, Richard Sandiford wrote: The entirety of the comment looks pretty good to me. :-) One question, and this is mostly curiosity on my part, I'm not specifically asking for another revision. * (This is the same as C bitfield layout on most ABIs.) Do we

Re: [Mesa-dev] [PATCH] mesa: per-texture locking

2013-06-13 Thread Ian Romanick
On 06/12/2013 04:08 PM, Dave Airlie wrote: On Thu, Jun 13, 2013 at 3:33 AM, Eric Anholt e...@anholt.net wrote: Frank Henigman fjhenig...@google.com writes: On Tue, Jun 11, 2013 at 1:10 PM, Eric Anholt e...@anholt.net wrote: Frank Henigman fjhenig...@google.com writes: Replace the one

[Mesa-dev] XDC2013 - Announcement

2013-06-13 Thread Keith Packard
Now that we have everything in place we can finally make it official and announce it: XDC2013 will take place from September 23th to September 25th in Portland, Oregon at the University Place Hotel and Conference Center Ian Romanick, Bart Massey, and I will be orgainzing this event. The initial

[Mesa-dev] XDC2013 - Call for Proposals

2013-06-13 Thread Keith Packard
# Call For Proposals **2013 X.Org Developers Conference (XDC 2013)** **23-25 September 2013** **Portland, Oregon USA** The [2013 X.Org Developers Conference] (http://www.x.org/wiki/Events/XDC2013) is the annual technical meeting for [X Window System](http://x.org) and [Free

[Mesa-dev] [Bug 52167] llvmpipe test programs link fails when ld --as-needed option is used

2013-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52167 Olivier Blin freedesk...@blino.org changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 1/2] i965: Add back strict type assertions for MAD and LRP.

2013-06-13 Thread Kenneth Graunke
Commit 526ffdfc033ab01cf133cb7e8290c65d12ccc9be relaxed the type assertions in brw_alu3 to allow D/UD types (required by BFE and BFI2). This lost us the strict type checking for MAD and LRP, which require all four types to be float. This patch adds a new ALU3F wrapper which checks these once

[Mesa-dev] [PATCH 2/2] i965: Remove broken source type assertions from brw_alu3().

2013-06-13 Thread Kenneth Graunke
Commit 526ffdfc033ab01cf133cb7e8290c65d12ccc9be attempted to generalize the source register type assertions to allow D and UD. However, the src1 and src2 assertions actually checked src0.type against D and UD due to a copy and paste bug. It also began setting the source and destination register

[Mesa-dev] [Bug 47824] osmesa using --enable-shared-glapi depends on libgl

2013-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47824 Anssi Hannula an...@mageia.org changed: What|Removed |Added CC||an...@mageia.org --

[Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-13 Thread Zack Rusin
Since draw auto fetches the count from the buffers, we can't just clear them on bind, we need to wait until the actual stream out is performed. Otherwise the count for draw auto will be zero. Plus is cleaner to have draw do it rather than drivers having to mess with draw's internals.

Re: [Mesa-dev] [PATCH libclc] Implement barrier() builtin

2013-06-13 Thread Aaron Watry
FYI: I've applied your related piglit test and R600 back-end patches and tested this on a CEDAR (HD5400). Note: I had some trouble applying patches 4 and 5 of the R600 patches but after chopping out the unit tests and creating those files by hand (and using --ignore-whitespace), everything is

Re: [Mesa-dev] [PATCH 1/2] r600g/compute: Move compute_shader_create() function into evergreen_compute.c

2013-06-13 Thread Aaron Watry
On Wed, Jun 12, 2013 at 7:34 PM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/r600/evergreen_compute.c | 23 +++- src/gallium/drivers/r600/r600_shader.c | 32 2 files changed, 22

Re: [Mesa-dev] [PATCH 1/2] r600g/compute: Move compute_shader_create() function into evergreen_compute.c

2013-06-13 Thread Tom Stellard
On Thu, Jun 13, 2013 at 05:51:49PM -0500, Aaron Watry wrote: On Wed, Jun 12, 2013 at 7:34 PM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com --- src/gallium/drivers/r600/evergreen_compute.c | 23 +++-

Re: [Mesa-dev] [PATCH 2/2] r600g/compute: Accept LDS size from the LLVM backend

2013-06-13 Thread Aaron Watry
For both patches in this series, the original files use tabs for indentation, not the spaces that the patches introduce. Might want to fix that for consistency. I'm not familiar enough with the register poking to give a qualified review, but everything else looks reasonable to me. Tested-by:

Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-13 Thread Roland Scheidegger
Am 14.06.2013 00:04, schrieb Zack Rusin: Since draw auto fetches the count from the buffers, we can't just clear them on bind, we need to wait until the actual stream out is performed. Otherwise the count for draw auto will be zero. Plus is cleaner to have draw do it rather than drivers

Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-13 Thread Zack Rusin
Though I find stream output very confusing... I agree. I was digging a bit more and I think I was correct the first time. The D3D spec is very clear that a buffer cannot be bound as both an input and an output at the same time, so I think the current behavior is correct, or at least one of

Re: [Mesa-dev] [PATCH] draw: don't clear the so targets until we stream out

2013-06-13 Thread Zack Rusin
Though I find stream output very confusing... I agree. I was digging a bit more and I think I was correct the first time. The D3D spec is very clear that a buffer cannot be bound as both an input and an output at the same time, so I think the current behavior is correct, or at least one of

[Mesa-dev] Pull request for 1.50 GS layout qualifiers

2013-06-13 Thread Eric Anholt
Hey Paul! I got the layout qualifiers working. It's unblocked things so I can finish off a bunch of testcases I've been working on, so I'd like to get it in your gs branch so we can all enjoy testcases together. There's one not-for-upstream commit in here, and do note the TODO in the last