Re: [Mesa-dev] Introductory projects in r600/radeonsi

2014-02-28 Thread Timothy Arceri
Hi Sean, There are a couple of projects left to do on the Newbie page that will help you get started contributing to mesa and piglit [1] NV_non_square_matrices is done but the other two haven't been worked on yet as far as I can tell. They are not to glamorous but should give you a way to get

Re: [Mesa-dev] Introductory projects in r600/radeonsi

2014-02-28 Thread Fabian Bieler
On 2014-02-28 11:27, Timothy Arceri wrote: Hi Sean, There are a couple of projects left to do on the Newbie page that will help you get started contributing to mesa and piglit [1] NV_non_square_matrices is done but the other two haven't been worked on yet as far as I can tell. The tests for

Re: [Mesa-dev] [PATCH] gallium/util: add missing u_math include

2014-02-28 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, Feb 28, 2014 at 7:10 AM, Ilia Mirkin imir...@alum.mit.edu wrote: This is needed for MIN2/MAX2 Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- src/gallium/auxiliary/util/u_range.h | 2 ++ 1 file changed, 2 insertions(+) diff

[Mesa-dev] [PATCH] mesa: add unpacking code for MESA_FORMAT_Z32_FLOAT_S8X24_UINT

2014-02-28 Thread Brian Paul
Fixes glGetTexImage() when converting from MESA_FORMAT_Z32_FLOAT_S8X24_UINT to GL_UNSIGNED_INT_24_8. Hit by the piglit ext_packed_depth_stencil-getteximage test. --- src/mesa/main/format_unpack.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[Mesa-dev] Add GPU BLIT of texture image to PBO in Intel driver

2014-02-28 Thread Jon Ashburn
Can someone from Vmware look at this very important patch? It yields hugh performance gains on benchmarks in at least one virtualized environment. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH] i965: Add GPU BLIT of texture image to PBO in Intel driver

2014-02-28 Thread Jon Ashburn
Add Intel driver hook for glGetTexImage to accelerate the case of reading texture image into a PBO. This case gets huge performance gains by using GPU BLIT directly to PBO rather than GPU BLIT to temporary texture followed by memcpy. No regressions on Piglit tests with Intel driver. Performance

Re: [Mesa-dev] [PATCH 05/25] glx/dri3: add support for DRI2rendererQueryExtension

2014-02-28 Thread Ian Romanick
On 02/21/2014 07:03 PM, Emil Velikov wrote: The extension is used to implement GLX_MESA_query_renderer. Currently untested, due to lack of dri3 enabled drivers. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Ian Romanick ian.d.roman...@intel.com Tested-by: Keith Packard

Re: [Mesa-dev] [Mesa-stable] [PATCH 12/25] dri/i9*5: correctly calculate the amount of system memory

2014-02-28 Thread Ian Romanick
On 02/21/2014 07:04 PM, Emil Velikov wrote: The variable name states megabytes, while we calculate the amount in kilobytes. Correct this by dividing with the correct amount. Cc: 10.0 10.1 mesa-sta...@lists.freedesktop.org Cc: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH] mesa: update packed format layout comments

2014-02-28 Thread Brian Paul
Update the comments for the packed formats to accurately reflect the layout of the bits in the pixel. For example, for the packed format MESA_FORMAT_R8G8B8A8, R is in the least significant position while A is in the most-significant position of the 32-bit word. --- src/mesa/main/formats.h | 98

[Mesa-dev] another newbie project: function renaming in format_(un)pack.c

2014-02-28 Thread Brian Paul
Since the MESA_FORMAT_ enums were renamed last month, the names of the functions in the format_pack.c and format_unpack.c are out of sync. The idea is the pack/unpack function for MESA_FORMAT_FOO should be called pack_FOO() or unpack_FOO(). As an example, unpack_RGBA() should really be

Re: [Mesa-dev] [PATCH] mesa: add unpacking code for MESA_FORMAT_Z32_FLOAT_S8X24_UINT

2014-02-28 Thread Kenneth Graunke
On 02/28/2014 06:58 AM, Brian Paul wrote: Fixes glGetTexImage() when converting from MESA_FORMAT_Z32_FLOAT_S8X24_UINT to GL_UNSIGNED_INT_24_8. Hit by the piglit ext_packed_depth_stencil-getteximage test. --- src/mesa/main/format_unpack.c | 22 ++ 1 file changed, 22

Re: [Mesa-dev] another newbie project: function renaming in format_(un)pack.c

2014-02-28 Thread Ian Romanick
On 02/28/2014 10:06 AM, Brian Paul wrote: Since the MESA_FORMAT_ enums were renamed last month, the names of the functions in the format_pack.c and format_unpack.c are out of sync. The idea is the pack/unpack function for MESA_FORMAT_FOO should be called pack_FOO() or unpack_FOO(). As an

Re: [Mesa-dev] [PATCH] glx: load dri driver with RTLD_LOCAL so dlclose never fails to unload

2014-02-28 Thread Ian Romanick
On 02/27/2014 11:52 PM, Eric Anholt wrote: j.gli...@gmail.com writes: From: Jerome Glisse jgli...@redhat.com There is no reason anymore to load with RTLD_GLOBAL and for some driver this even result in dlclose failing to unload leading to catastrophic failure with swrast fallback. I don't

Re: [Mesa-dev] [PATCH 0/2] v5: Fix array overrun with too many uniforms

2014-02-28 Thread Ian Romanick
On 02/27/2014 06:15 AM, Petri Latvala wrote: Fixing https://bugs.freedesktop.org/show_bug.cgi?id=71254 once again. Rebased for current master, plumbing-class changes to patch 1/2. Fixed one of the asserts in patch 2/2. Full piglit run shows no regressions. Petri Latvala (2): i965: Allocate

Re: [Mesa-dev] [PATCH 03/25] glx: move dri2_convert_glx_query_renderer_attribs into a common place

2014-02-28 Thread Ian Romanick
On 02/21/2014 07:03 PM, Emil Velikov wrote: This way we can reuse it for drisw and dri3. Squash a couple minor whitespace fixes while we're here. Now I remember why I put this all in its own file... there are unit tests in src/glx/tests that link with these functions. If they have to link

[Mesa-dev] [PATCH V3 1/4] glsl: Compile error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-28 Thread Anuj Phogat
GLSL 1.50 spec says: If gl_FragCoord is redeclared in any fragment shader in a program, it must be redeclared in all the fragment shaders in that program that have a static use gl_FragCoord. All redeclarations of gl_FragCoord in all fragment shaders in a single program must have

[Mesa-dev] [PATCH V3 4/4] glsl: Apply the link error conditions to GL_ARB_fragment_coord_conventions

2014-02-28 Thread Anuj Phogat
Link error conditions added in previous patch are equally applicable to GL_ARB_fragment_coord_conventions implementation. Extension's spec says: If gl_FragCoord is redeclared in any fragment shader in a program, it must be redeclared in all the fragment shaders in that program that have

[Mesa-dev] [PATCH V3 3/4] glsl: Link error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-28 Thread Anuj Phogat
GLSL 1.50 spec says: If gl_FragCoord is redeclared in any fragment shader in a program, it must be redeclared in all the fragment shaders in that program that have a static use gl_FragCoord. All redeclarations of gl_FragCoord in all fragment shaders in a single program must have

[Mesa-dev] [PATCH V3 2/4] glsl: Compile error if fs uses gl_FragCoord before first redeclaration

2014-02-28 Thread Anuj Phogat
Section 4.3.8.1, page 39 of GLSL 1.50 spec says: Within any shader, the first redeclarations of gl_FragCoord must appear before any use of gl_FragCoord. GLSL compiler should generate an error in following case: vec4 p = gl_FragCoord; layout(origin_upper_left) in vec4 gl_FragCoord; void

Re: [Mesa-dev] [PATCH] i965: Add GPU BLIT of texture image to PBO in Intel driver

2014-02-28 Thread Ian Romanick
On 02/28/2014 08:08 AM, Jon Ashburn wrote: Add Intel driver hook for glGetTexImage to accelerate the case of reading texture image into a PBO. This case gets huge performance gains by using GPU BLIT directly to PBO rather than GPU BLIT to temporary texture followed by memcpy. No regressions on

[Mesa-dev] [PATCH 2/2] configure.ac: consolidate dependencies version check

2014-02-28 Thread Fabio Pedretti
--- configure.ac | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 0e0fd18..a6ce794 100644 --- a/configure.ac +++ b/configure.ac @@ -38,6 +38,13 @@ DRI3PROTO_REQUIRED=1.0 PRESENTPROTO_REQUIRED=1.0 LIBUDEV_REQUIRED=151

[Mesa-dev] [PATCH 1/2] glx/dri2: fix FTBFS on hurd

2014-02-28 Thread Fabio Pedretti
From: Julien Cristau jcris...@debian.org --- src/glx/dri2_query_renderer.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glx/dri2_query_renderer.c b/src/glx/dri2_query_renderer.c index b50a202..95560cb 100644 --- a/src/glx/dri2_query_renderer.c +++ b/src/glx/dri2_query_renderer.c

Re: [Mesa-dev] [PATCH 2/2] configure.ac: consolidate dependencies version check

2014-02-28 Thread Matt Turner
On Fri, Feb 28, 2014 at 12:13 PM, Fabio Pedretti fabio@libero.it wrote: --- configure.ac | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/configure.ac b/configure.ac index 0e0fd18..a6ce794 100644 --- a/configure.ac +++ b/configure.ac @@ -38,6

Re: [Mesa-dev] [PATCH 1/3] r300g/tests: Added missing fclose for FILE resource.

2014-02-28 Thread Kristian Høgsberg
On Mon, Feb 10, 2014 at 01:28:14PM +0330, Siavash Eliasi wrote: Oops, we almost lost these three fixes. Reviewed and pushed all three. Kristian --- src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-02-28 Thread Courtney Goeltzenleuchter
No, I do not believe this commit has made it. Courtney On Wed, Feb 26, 2014 at 11:44 AM, Ian Romanick i...@freedesktop.org wrote: On 02/17/2014 09:43 AM, Courtney Goeltzenleuchter wrote: Thanks for the feedback. I've updated the patch to integrate Ian's comments. Did the updated patch

Re: [Mesa-dev] [PATCH 0/8] use hwdb in loader v4

2014-02-28 Thread Kristian Høgsberg
On Fri, Feb 07, 2014 at 12:46:46AM +, Emil Velikov wrote: Helo Kristian, Rather than nitpicking like an old bat, I took the liberty of respinning your patchset. Most patches are left as is, minus a reshuffle in their order + rebase. Available in the hwdb-loader-v4 branch at

Re: [Mesa-dev] [PATCH 3/4] configure: error out when building xa only with swrast

2014-02-28 Thread Emil Velikov
On 27/02/14 20:39, Emil Velikov wrote: On 25/02/14 08:24, Matt Turner wrote: On Mon, Feb 24, 2014 at 3:05 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Building to provide accelration using swrast does not make sense. Note: update your build script to explicitly mention svga in the

Re: [Mesa-dev] [PATCH 1/2] glx/dri2: fix FTBFS on hurd

2014-02-28 Thread Ian Romanick
What is FTBFS? On 02/28/2014 12:13 PM, Fabio Pedretti wrote: From: Julien Cristau jcris...@debian.org --- src/glx/dri2_query_renderer.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glx/dri2_query_renderer.c b/src/glx/dri2_query_renderer.c index b50a202..95560cb 100644 ---

Re: [Mesa-dev] [PATCH] i965: Avoid dependency hints on math opcodes

2014-02-28 Thread Mike Stroyan
Matt, You haven't replied to my mail with an updated shader test that shows the math instructions alone causing trouble. Do you now agree that my patch avoiding math instructions in opt_set_dependency_control is the appropriate fix? On Fri, Feb 21, 2014 at 11:30 AM, Mike Stroyan

Re: [Mesa-dev] [PATCH 2/2] i915: Allocate the sys_buffer using _mesa_align_malloc

2014-02-28 Thread Matt Turner
Both are Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] r300g/tests: Added missing fclose for FILE resource.

2014-02-28 Thread Ian Romanick
On 02/28/2014 12:32 PM, Kristian Høgsberg wrote: On Mon, Feb 10, 2014 at 01:28:14PM +0330, Siavash Eliasi wrote: Oops, we almost lost these three fixes. Reviewed and pushed all three. Sould any / all of these be on the 10.1 list? Kristian ---

Re: [Mesa-dev] [PATCH 1/3] r300g/tests: Added missing fclose for FILE resource.

2014-02-28 Thread Kristian Høgsberg
On Fri, Feb 28, 2014 at 2:54 PM, Ian Romanick i...@freedesktop.org wrote: On 02/28/2014 12:32 PM, Kristian Høgsberg wrote: On Mon, Feb 10, 2014 at 01:28:14PM +0330, Siavash Eliasi wrote: Oops, we almost lost these three fixes. Reviewed and pushed all three. Sould any / all of these be on

[Mesa-dev] [Bug 75528] export gbm_device_is_format_supported

2014-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75528 Emil Velikov emil.l.veli...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 75584] Request write access to mesa repository

2014-02-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75584 Brian Paul bri...@vmware.com changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 2/2] i915: Allocate the sys_buffer using _mesa_align_malloc

2014-02-28 Thread Kenneth Graunke
On 02/26/2014 01:49 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Though it won't matter on Linux, use _mesa_align_free to release it. Since i965 doesn't have sys_buffer, I overlooked this in the GL_ARB_map_buffer_alignment work a few months ago. Fixes i915 (and

Re: [Mesa-dev] [PATCH 1/2] glx/dri2: fix FTBFS on hurd

2014-02-28 Thread Matt Turner
On Fri, Feb 28, 2014 at 2:27 PM, Ian Romanick i...@freedesktop.org wrote: What is FTBFS? Fails to build from source. Would be nice to not have such initialisms in the commit summary. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 0/8] use hwdb in loader v4

2014-02-28 Thread Emil Velikov
On 28/02/14 21:01, Kristian Høgsberg wrote: On Fri, Feb 07, 2014 at 12:46:46AM +, Emil Velikov wrote: Helo Kristian, Rather than nitpicking like an old bat, I took the liberty of respinning your patchset. Most patches are left as is, minus a reshuffle in their order + rebase. Available

Re: [Mesa-dev] [PATCH 1/2] glx/dri2: fix FTBFS on hurd

2014-02-28 Thread Ian Romanick
On 02/28/2014 03:42 PM, Matt Turner wrote: On Fri, Feb 28, 2014 at 2:27 PM, Ian Romanick i...@freedesktop.org wrote: What is FTBFS? Fails to build from source. Would be nice to not have such initialisms in the commit summary. Agreed... how about glx/dri2: Fix build failure on HURD for the

Re: [Mesa-dev] [PATCH 1/3] r300g/tests: Added missing fclose for FILE resource.

2014-02-28 Thread Ian Romanick
On 02/28/2014 12:32 PM, Kristian Høgsberg wrote: On Mon, Feb 10, 2014 at 01:28:14PM +0330, Siavash Eliasi wrote: Oops, we almost lost these three fixes. Reviewed and pushed all three. Did you actually push? :) I don't see them in origin/master... Kristian ---

Re: [Mesa-dev] [PATCH 1/3] r300g/tests: Added missing fclose for FILE resource.

2014-02-28 Thread Kristian Høgsberg
On Fri, Feb 28, 2014 at 3:46 PM, Ian Romanick i...@freedesktop.org wrote: On 02/28/2014 12:32 PM, Kristian Høgsberg wrote: On Mon, Feb 10, 2014 at 01:28:14PM +0330, Siavash Eliasi wrote: Oops, we almost lost these three fixes. Reviewed and pushed all three. Did you actually push? :) I

Re: [Mesa-dev] [PATCH 0/8] use hwdb in loader v4

2014-02-28 Thread Kristian Høgsberg
On Fri, Feb 28, 2014 at 3:46 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 28/02/14 21:01, Kristian Høgsberg wrote: On Fri, Feb 07, 2014 at 12:46:46AM +, Emil Velikov wrote: Helo Kristian, Rather than nitpicking like an old bat, I took the liberty of respinning your patchset. Most

Re: [Mesa-dev] [PATCH 0/8] use hwdb in loader v4

2014-02-28 Thread Emil Velikov
On 01/03/14 00:27, Kristian Høgsberg wrote: [snip] I hate to keep picking on this, but those are not the same defines. They all key off of different conditions and guard different code, they just happen to all have the same name. If anything, it's part of the dri_interface.h API, in that

Re: [Mesa-dev] [Mesa-stable] [PATCH 12/25] dri/i9*5: correctly calculate the amount of system memory

2014-02-28 Thread Emil Velikov
On 28/02/14 17:32, Ian Romanick wrote: On 02/21/2014 07:04 PM, Emil Velikov wrote: The variable name states megabytes, while we calculate the amount in kilobytes. Correct this by dividing with the correct amount. Cc: 10.0 10.1 mesa-sta...@lists.freedesktop.org Cc: Ian Romanick

Re: [Mesa-dev] [PATCH 3/4] configure: error out when building xa only with swrast

2014-02-28 Thread Jon TURNEY
On 28/02/2014 21:38, Emil Velikov wrote: Here is a very nice example of what I'm trying to prevent: Jon Turney has a tinderbox setup [1] at fd.org. For his needs he builds gallium swrast+llvm on top of a indirect rendered libGL. For unknown reason he has --enable-xa, which was causing

Re: [Mesa-dev] [PATCH 03/25] glx: move dri2_convert_glx_query_renderer_attribs into a common place

2014-02-28 Thread Emil Velikov
On 28/02/14 19:27, Ian Romanick wrote: On 02/21/2014 07:03 PM, Emil Velikov wrote: This way we can reuse it for drisw and dri3. Squash a couple minor whitespace fixes while we're here. Now I remember why I put this all in its own file... there are unit tests in src/glx/tests that link with

[Mesa-dev] [PATCH] nv50,nvc0: add 11f_11f_10f vertex support

2014-02-28 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Tested on nv96 with Chris Forbes's piglit tests (on list, but not checked in yet)... only assuming about nvc0, but it seems reasonable since all the other attributes are the same. docs/GL3.txt| 2 +-