Re: [Mesa-dev] [PATCH v2] glsl: Add without_array type predicate

2014-07-30 Thread Timothy Arceri
On Tue, 2014-07-29 at 16:14 -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Returns the type without any arrays. This will be used in later patches in this series. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Suggested-by: Timothy Arceri

Re: [Mesa-dev] [PATCH v2] glsl: Use the without_array predicate to simplify some code

2014-07-30 Thread Timothy Arceri
On Tue, 2014-07-29 at 16:15 -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Matt Turner matts...@gmail.com [v1] Cc: Timothy Arceri t_arc...@yahoo.com.au --- src/glsl/ast_to_hir.cpp| 3 +--

Re: [Mesa-dev] [PATCH v2] glsl: Add without_array type predicate

2014-07-30 Thread Timothy Arceri
On Tue, 2014-07-29 at 16:14 -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Returns the type without any arrays. This will be used in later patches in this series. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Suggested-by: Timothy Arceri

[Mesa-dev] [Bug 81834] TGSI constant buffer overrun causes assertion failure

2014-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81834 --- Comment #5 from Michel Dänzer mic...@daenzer.net --- (In reply to comment #4) Should I create a new bug report? Yes, please. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 10/13] glsl: Add a lowering pass for gl_VertexID

2014-07-30 Thread Tapani Pälli
On 06/21/2014 04:01 AM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Converts gl_VertexID to (gl_VertexIDMESA + gl_BaseVertex). gl_VertexIDMESA is backed by SYSTEM_VALUE_VERTEX_ID_ZERO_BASE, and gl_BaseVertex is backed by a built-in uniform from {STATE_INTERNAL,

Re: [Mesa-dev] [PATCH 00/13] Fix gl_VertexID on i965

2014-07-30 Thread Tapani Pälli
Patches 5..10 Reviewed-by: Tapani Pälli tapani.pa...@intel.com Also tested that these fix the new Piglit tests and esconform3 test. I made a little proposal for patch 10 but not sure if this change would be worth the trouble. On 06/21/2014 04:00 AM, Ian Romanick wrote: This patch series fixes

Re: [Mesa-dev] SandyBridge not handling GL_TRIANGLE_STRIP_ADJACENCY with repeating vertex indices correctly

2014-07-30 Thread Iago Toral Quiroga
On mar, 2014-07-29 at 10:16 -0700, Kenneth Graunke wrote: On Tuesday, July 29, 2014 10:12:23 AM Iago Toral Quiroga wrote: Hi, running the piglit tests on my implementation of geometry shaders for Sandy Bridge produces a GPU hang for the following test:

Re: [Mesa-dev] [PATCH] egl: Fix OpenGL ES version checks in _eglParseContextAttribList()

2014-07-30 Thread Tapani
Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 06/19/2014 03:49 AM, Anuj Phogat wrote: Fixes gles3 Khronos CTS test: egl_create_context.egl_create_context Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/egl/main/eglcontext.c | 11

Re: [Mesa-dev] [PATCH 09/23] i965: Make brw_upload_sampler_state_table handle Gen7+ as well.

2014-07-30 Thread Pohjolainen, Topi
On Tue, Jul 29, 2014 at 04:29:14PM -0700, Kenneth Graunke wrote: This copies a few changes from gen7_upload_sampler_state_table; the next patch will delete that function. Gen7+ has per-stage sampler state pointer update packets, so we emit them as soon as we emit a new table for a stage. On

Re: [Mesa-dev] [PATCH 12/23] i965: Add #defines for SAMPLER_STATE fields.

2014-07-30 Thread Pohjolainen, Topi
On Tue, Jul 29, 2014 at 04:29:17PM -0700, Kenneth Graunke wrote: We'll use these to replace the existing structures. I've adopted the convention that BRW applies to all hardware, and GENX applies starting with generation X, but might be replaced by some later generation. Signed-off-by:

Re: [Mesa-dev] [PATCH 13/23] i965: Introduce a function to emit a SAMPLER_STATE structure.

2014-07-30 Thread Pohjolainen, Topi
On Tue, Jul 29, 2014 at 04:29:18PM -0700, Kenneth Graunke wrote: This simply assembles all the SAMPLER_STATE fields into their proper bit locations. Making it work on all generations was easy enough; some of the fields are even in the same place. Not used by anything yet, but will be soon.

Re: [Mesa-dev] [PATCH 18/23] i965: Delete redundant sampler state dumping code.

2014-07-30 Thread Pohjolainen, Topi
On Tue, Jul 29, 2014 at 04:29:23PM -0700, Kenneth Graunke wrote: Although the Gen4-6 and Gen7+ variants used different structure types, they didn't use any of the fields - only the size, which is identical. So both decoders did exactly the same thing. Someday we should implement useful

Re: [Mesa-dev] [PATCH 20/23] i965: Drop sizeof(struct brw_sampler_state) from estimated prim size.

2014-07-30 Thread Pohjolainen, Topi
On Tue, Jul 29, 2014 at 04:29:25PM -0700, Kenneth Graunke wrote: This is the last user of the structure. Hardcoding 16 is poor style, but this code is already a senseless mess, so it's not that much worse. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

Re: [Mesa-dev] i965 sampler state cleanups

2014-07-30 Thread Pohjolainen, Topi
On Tue, Jul 29, 2014 at 04:29:05PM -0700, Kenneth Graunke wrote: A while back, I wrote a patch to skip border color upload, and got annoyed by having to write it twice - once for the Gen4-6 code, and once for Gen7+. So I decided to clean that up. 23 patches and a bug fix later, I've unified

Re: [Mesa-dev] [PATCH 14/23] i965: Make brw_update_sampler_state() use brw_emit_sampler_state().

2014-07-30 Thread Pohjolainen, Topi
On Tue, Jul 29, 2014 at 04:29:19PM -0700, Kenneth Graunke wrote: Instead of stuffing bits directly into the brw_sampler_state structure, we now store them in local variables, then use brw_emit_sampler_state() to assemble the packet. This separates the decision about what values to use from

[Mesa-dev] [PATCH] glsl/glcpp: Rename ERROR to ERROR_TOKEN.

2014-07-30 Thread jfonseca
From: José Fonseca jfons...@vmware.com To prevent collision with wingdi.h's ERROR define, using the same _TOKEN suffix already forsome other tokens due to similar reasons. PS: Name collisions will be rife with single capitalized words. And using _TOKEN suffix for only some of the tokens is not

Re: [Mesa-dev] [PATCH] glsl/glcpp: Rename ERROR to ERROR_TOKEN.

2014-07-30 Thread Jose Fonseca
On 30/07/14 10:42, jfons...@vmware.com wrote: From: José Fonseca jfons...@vmware.com To prevent collision with wingdi.h's ERROR define, using the same _TOKEN suffix already forsome other tokens due to similar reasons. PS: Name collisions will be rife with single capitalized words. And using

Re: [Mesa-dev] [PATCH] glsl/glcpp: rename ERROR to ERROR_TOKEN to fix MSVC build

2014-07-30 Thread Jose Fonseca
On 30/07/14 03:42, Kenneth Graunke wrote: On Tuesday, July 29, 2014 05:02:39 PM Brian Paul wrote: ERROR is a #define in the MSVC WinGDI.h header file. Add the _TOKEN suffix as we do for a few other lexer tokens. Brian, sorry I missed your review and ended up duplicating it byte per byte!

[Mesa-dev] [PATCH] glsl: support unsigned increment in ir_loop controls

2014-07-30 Thread Tapani Pälli
Current version can create ir_expression where operands have different base type, patch adds support for unsigned type. Signed-off-by: Tapani Pälli tapani.pa...@intel.com https://bugs.freedesktop.org/show_bug.cgi?id=80880 --- src/glsl/loop_controls.cpp | 18 +++--- 1 file changed, 15

Re: [Mesa-dev] [PATCH] gallivm: fix up out-of-bounds level when using conformant out-of-bound behavior

2014-07-30 Thread Jose Fonseca
On 30/07/14 04:08, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com When using (d3d10) conformant out-of-bound behavior for texel fetching (currently always enabled) the level still needs to be set to a safe value even though the offset in the end won't get used because the

[Mesa-dev] [Bug 78773] Doom3 BFG doesnt start

2014-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78773 --- Comment #13 from Tapani Pälli lem...@gmail.com --- Jan, please try if it works for you -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

[Mesa-dev] [Bug 80848] [dri3] Building mesa fails with dri3 enabled

2014-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80848 --- Comment #17 from Juha-Pekka Heikkilä juhapekka.heikk...@gmail.com --- I did continue poking at this one today. I notice if I revert 3ecd9e1a93817180fa5b280e5fe11c903cca38ba I can compile with dri3 but don't yet know why is it so. I did try

Re: [Mesa-dev] Clover Platform Naming

2014-07-30 Thread Tom Stellard
On Tue, Jul 29, 2014 at 09:50:23AM -0500, Aaron Watry wrote: Hi list, I was starting to look into getting cppamp-driver-ng working with mesa/clover, and I quickly ran into a question... cppamp-driver-ng explicitly lists which platforms are supported in its OpenCL back-end's source code. I

Re: [Mesa-dev] Clover Platform Naming

2014-07-30 Thread Aaron Watry
These are the platforms recognized by cppamp-driver-ng, and what I'd need to add currently to get clover working on radeonsi (assuming we supported all the necessary built-ins and also enabled the static storage class specifier in clang successfully): Label I've assigned: Vendor String / Platform

Re: [Mesa-dev] [PATCH 6/6] gallium: remove PIPE_CAP_BUFFER_SHARE cap and get_param sw_winsys hook

2014-07-30 Thread Emil Velikov
On 30/07/14 08:14, Giovanni Campagna wrote: On Jul 29, 2014 7:42 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 24/07/14 01:43, Emil Velikov wrote: The kms_swrast driver has a separate InitScreen hook for its DriverAPI from the rest of the DRI2 drivers, all of which capable of buffer

[Mesa-dev] [PATCH] glsl/glcp: Rename all token names to have a _TOK suffix

2014-07-30 Thread Carl Worth
Previously, we tried to have unadorned token names, (NEWLINE, SPACE, PASTE, etc.). But occasionally we would run into conflicts with lexer start conditions or with system header files that would define identical symbols, (such as the lexer start condition HASH or a Windows header symbol ERROR).

Re: [Mesa-dev] [PATCH] glsl/glcp: Rename all token names to have a _TOK suffix

2014-07-30 Thread Brian Paul
On 07/30/2014 10:29 AM, Carl Worth wrote: Previously, we tried to have unadorned token names, (NEWLINE, SPACE, PASTE, etc.). But occasionally we would run into conflicts with lexer start conditions or with system header files that would define identical symbols, (such as the lexer start

[Mesa-dev] [RFC] i965: Attempt to merge some surface state setup logic

2014-07-30 Thread Topi Pohjolainen
First five patches refactor common decision making found in depth, texture and renderbuffer surface setup logic. In principle, there is opportunity to share code between texture and renderbuffer setup logic (Kenneth has experimented with this earlier [1]). On the other hand there is also a lot of

[Mesa-dev] [RFC 1/7] i965: Refactor render target type resolving

2014-07-30 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_state.h | 8 src/mesa/drivers/dri/i965/gen6_depth_state.c | 8 +++- src/mesa/drivers/dri/i965/gen6_surface_state.c| 3 +-- src/mesa/drivers/dri/i965/gen7_misc_state.c

[Mesa-dev] [RFC 2/7] i965/blorp: Refactor depth override

2014-07-30 Thread Topi Pohjolainen
It would be more natural to have this, for example, in brw_state.h but unfortunately this is later needed when resolving renderbuffer depth (in intel_fbo.h). Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_context.h | 12

[Mesa-dev] [RFC 3/7] i965: Refactor renderbuffer depth override

2014-07-30 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/gen6_depth_state.c | 6 +- src/mesa/drivers/dri/i965/gen6_surface_state.c| 3 +-- src/mesa/drivers/dri/i965/gen7_misc_state.c | 10 +-

[Mesa-dev] [RFC 7/7] i965: Merge common bits of gen7/8 renderbuffer surface setup

2014-07-30 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_state.h | 3 + src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 119 -- src/mesa/drivers/dri/i965/gen8_surface_state.c| 59 +-- 3 files changed, 73

[Mesa-dev] [RFC 4/7] i965: Refactor renderbuffer target override

2014-07-30 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_state.h | 1 + src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 16 src/mesa/drivers/dri/i965/gen6_blorp.cpp | 17 +

[Mesa-dev] [RFC 6/7] i965/gen7: Add support for gen8 tiling

2014-07-30 Thread Topi Pohjolainen
Prepares for merging common bits of gen7/8 renderbuffer surface setup. Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_state.h | 2 +- src/mesa/drivers/dri/i965/gen7_blorp.cpp | 2 +-

[Mesa-dev] [RFC 5/7] i965: Refactor array type resolving

2014-07-30 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_state.h | 9 + src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 14 +- src/mesa/drivers/dri/i965/gen8_surface_state.c| 13 + 3 files changed, 11

[Mesa-dev] [PATCH] mesa: make vertex array type error checking a little more efficient

2014-07-30 Thread Brian Paul
Compute the bitmask of supported array types once instead of every time we call a GL vertex array function. --- src/mesa/main/mtypes.h |3 ++ src/mesa/main/varray.c | 86 +++- 2 files changed, 59 insertions(+), 30 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] egl: Fix OpenGL ES version checks in _eglParseContextAttribList()

2014-07-30 Thread Ian Romanick
On 06/18/2014 05:49 PM, Anuj Phogat wrote: Fixes gles3 Khronos CTS test: egl_create_context.egl_create_context Gak... I totally missed this when you sent it a month ago. :( Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/egl/main/eglcontext.c

Re: [Mesa-dev] [PATCH v2] glsl: Add without_array type predicate

2014-07-30 Thread Ian Romanick
On 07/29/2014 11:18 PM, Timothy Arceri wrote: On Tue, 2014-07-29 at 16:14 -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Returns the type without any arrays. This will be used in later patches in this series. Signed-off-by: Ian Romanick ian.d.roman...@intel.com

Re: [Mesa-dev] [PATCH] glsl/glcpp: rename ERROR to ERROR_TOKEN to fix MSVC build

2014-07-30 Thread Kenneth Graunke
On Wednesday, July 30, 2014 11:31:19 AM Jose Fonseca wrote: On 30/07/14 03:42, Kenneth Graunke wrote: On Tuesday, July 29, 2014 05:02:39 PM Brian Paul wrote: ERROR is a #define in the MSVC WinGDI.h header file. Add the _TOKEN suffix as we do for a few other lexer tokens. Brian, sorry I

Re: [Mesa-dev] [RFC 5/7] i965: Refactor array type resolving

2014-07-30 Thread Roland Scheidegger
Am 30.07.2014 19:04, schrieb Topi Pohjolainen: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_state.h | 9 + src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 14 +-

Re: [Mesa-dev] [PATCH 09/23] i965: Make brw_upload_sampler_state_table handle Gen7+ as well.

2014-07-30 Thread Kenneth Graunke
On Wednesday, July 30, 2014 10:32:12 AM Pohjolainen, Topi wrote: On Tue, Jul 29, 2014 at 04:29:14PM -0700, Kenneth Graunke wrote: This copies a few changes from gen7_upload_sampler_state_table; the next patch will delete that function. Gen7+ has per-stage sampler state pointer update

Re: [Mesa-dev] [PATCH 14/23] i965: Make brw_update_sampler_state() use brw_emit_sampler_state().

2014-07-30 Thread Kenneth Graunke
On Wednesday, July 30, 2014 11:38:28 AM Pohjolainen, Topi wrote: On Tue, Jul 29, 2014 at 04:29:19PM -0700, Kenneth Graunke wrote: Instead of stuffing bits directly into the brw_sampler_state structure, we now store them in local variables, then use brw_emit_sampler_state() to assemble the

Re: [Mesa-dev] [PATCH 18/23] i965: Delete redundant sampler state dumping code.

2014-07-30 Thread Kenneth Graunke
On Wednesday, July 30, 2014 11:24:24 AM Pohjolainen, Topi wrote: On Tue, Jul 29, 2014 at 04:29:23PM -0700, Kenneth Graunke wrote: Although the Gen4-6 and Gen7+ variants used different structure types, they didn't use any of the fields - only the size, which is identical. So both decoders

Re: [Mesa-dev] [PATCH 20/23] i965: Drop sizeof(struct brw_sampler_state) from estimated prim size.

2014-07-30 Thread Kenneth Graunke
On Wednesday, July 30, 2014 11:28:00 AM Pohjolainen, Topi wrote: On Tue, Jul 29, 2014 at 04:29:25PM -0700, Kenneth Graunke wrote: This is the last user of the structure. Hardcoding 16 is poor style, but this code is already a senseless mess, so it's not that much worse. Signed-off-by:

Re: [Mesa-dev] [PATCH 06/15] mesa: Turn target_can_be_compressed() in to a utility function

2014-07-30 Thread Anuj Phogat
On Tue, Jul 29, 2014 at 5:01 PM, Jason Ekstrand ja...@jlekstrand.net wrote: If we're going to make a utility function declared in glformats.h, let's move the function body to glformats.c. or just move the function declaration to teximage.h? That looks like a better place to declare texture

Re: [Mesa-dev] [PATCH 07/15] mesa: Add error condition for using compressed internalformat in glTexStorage3D()

2014-07-30 Thread Ian Romanick
On 07/29/2014 05:02 PM, Jason Ekstrand wrote: On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com mailto:anuj.pho...@gmail.com wrote: Fixes gles3 Khronos CTS test: texture_storage_texture_internal_formats Cc: mesa-sta...@lists.freedesktop.org

[Mesa-dev] [Bug 81500] wrong color in flightgear for the c172p if Atmospheric light scattering is used

2014-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81500 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEEDINFO|ASSIGNED

Re: [Mesa-dev] [PATCH 06/15] mesa: Turn target_can_be_compressed() in to a utility function

2014-07-30 Thread Jason Ekstrand
On Wed, Jul 30, 2014 at 2:04 PM, Anuj Phogat anuj.pho...@gmail.com wrote: On Tue, Jul 29, 2014 at 5:01 PM, Jason Ekstrand ja...@jlekstrand.net wrote: If we're going to make a utility function declared in glformats.h, let's move the function body to glformats.c. or just move the function

Re: [Mesa-dev] [PATCH] glsl/glcp: Rename all token names to have a _TOK suffix

2014-07-30 Thread Carl Worth
Brian Paul bri...@vmware.com writes: I was going to test this with MSVC but the patch doesn't cleanly apply on master. Ah, sorry about that. I'll resend this once the rest of my glcpp-fixup branch has landed on master. (This minor change is worth landing now and causing me to rebase all of my

Re: [Mesa-dev] [PATCH 07/15] mesa: Add error condition for using compressed internalformat in glTexStorage3D()

2014-07-30 Thread Roland Scheidegger
Am 30.07.2014 23:29, schrieb Ian Romanick: On 07/29/2014 05:02 PM, Jason Ekstrand wrote: On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com mailto:anuj.pho...@gmail.com wrote: Fixes gles3 Khronos CTS test: texture_storage_texture_internal_formats Cc:

[Mesa-dev] [PATCH] exec_list: add a list_foreach_typed_reverse() macro

2014-07-30 Thread Connor Abbott
Signed-off-by: Connor Abbott connor.abb...@intel.com --- src/glsl/list.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/list.h b/src/glsl/list.h index 3ee6cda..c402f48 100644 --- a/src/glsl/list.h +++ b/src/glsl/list.h @@ -644,6 +644,12 @@ inline void

Re: [Mesa-dev] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-07-30 Thread Carl Worth
Ian Romanick i...@freedesktop.org writes: Anuj: Can you verify this does not regress proxy_textures_invalid_size? ... Cc: 10.2 mesa-sta...@lists.freedesktop.org Iana (or Anuj), is there an outstanding question of a regression here that should still be answered before this patch is picked over

[Mesa-dev] [PATCH 1/1] r600: Use llvm intrinsic to read work dimension information

2014-07-30 Thread Jan Vesely
Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- generic/include/clc/workitem/get_work_dim.h | 1 + r600/lib/SOURCES| 1 + r600/lib/workitem/get_work_dim.ll | 6 ++ 3 files changed, 8 insertions(+) create mode 100644

[Mesa-dev] [PATCH 1/1] R600: Add new intrinsic to read work dimensions

2014-07-30 Thread Jan Vesely
CC: Tom Stellard t...@stellard.net CC: Matt Arsenault matthew.arsena...@amd.com Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- include/llvm/IR/IntrinsicsR600.td| 2 ++ lib/Target/R600/R600ISelLowering.cpp | 6 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] gallium: Add dimension parameter to launch_grid

2014-07-30 Thread Jan Vesely
This is needed for OpenCL CC: Francisco Jerez curroje...@riseup.net CC: Tom Stellard t...@stellard.net Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- I tried to find another way how to get the information, but in the end there is no way to distinguish between 1,1,1 dim 1, and 1,1,1 dim 2

[Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-30 Thread Jan Vesely
Make the function static. This needs corresponding change in LLVM otherwise it breaks parameter passing CC: Tom Stellard t...@stellard.net CC: Matt Arsenault matthew.arsena...@amd.com Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- src/gallium/drivers/r600/evergreen_compute.c | 26

Re: [Mesa-dev] [PATCH 3/3] ra: optimistically color only one node at a time

2014-07-30 Thread Eric Anholt
Connor Abbott cwabbo...@gmail.com writes: Before, when we encountered a situation where we had to optimistically color a node, we would immediately give up and push all the remaining nodes on the stack in the order of their index - which is a random, and potentially not optimal, order.

[Mesa-dev] [PATCH V2] mesa: Turn target_can_be_compressed() in to a utility function

2014-07-30 Thread Anuj Phogat
V2: Declare the function in teximage.h Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/main/teximage.c | 12 ++-- src/mesa/main/teximage.h | 3 +++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 4/5] meta: Fix datatype computation in get_temp_image_type()

2014-07-30 Thread Anuj Phogat
Changes in the patch will cause datatype to be computed correctly for 8 and 16 bit integer formats. For example: GL_RG8I, GL_RG16I etc. Fixes many failures in gles3 Khronos CTS test: copy_tex_image_conversions_required copy_tex_image_conversions_forbidden Cc: mesa-sta...@lists.freedesktop.org

[Mesa-dev] [PATCH 2/5] meta: Use _mesa_get_format_bits() to get the GL_RED_BITS

2014-07-30 Thread Anuj Phogat
We currently get red bits from ctx-DrawBuffer-Visual.redBits by making a false assumption that the texture we're writing to (in glCopyTexImage2D()) is used as a DrawBuffer. Fixes many failures in gles3 Khronos CTS test: copy_tex_image_conversions_required Cc: mesa-sta...@lists.freedesktop.org

[Mesa-dev] [PATCH 3/5] meta: Move the call to _mesa_get_format_datatype() out of switch

2014-07-30 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/common/meta.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index ba84eb8..e94 100644 --- a/src/mesa/drivers/common/meta.c +++

[Mesa-dev] [PATCH 1/5] meta: Initialize the variable in declaration statement

2014-07-30 Thread Anuj Phogat
Saves one line of code :) Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- Realized today that I never really sent this series out to the list. src/mesa/drivers/common/meta.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 5/5] meta: Add an assertion check for datatype of integer formats

2014-07-30 Thread Anuj Phogat
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/drivers/common/meta.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index fdac546..78bfd57 100644 --- a/src/mesa/drivers/common/meta.c +++

Re: [Mesa-dev] [PATCH 1/1] r600: Use llvm intrinsic to read work dimension information

2014-07-30 Thread Matt Arsenault
On Jul 30, 2014, at 4:11 PM, Jan Vesely jan.ves...@rutgers.edu wrote: +define i32 @get_work_dim() nounwind readnone alwaysinline { + %x = call i32 @llvm.r600.read.workdim() nounwind readnone + ret i32 %x +} -- Maybe this should have range metadata attached now that it applies to

Re: [Mesa-dev] [PATCH 1/1] R600: Add new intrinsic to read work dimensions

2014-07-30 Thread Matt Arsenault
On 07/30/2014 04:11 PM, Jan Vesely wrote: CC: Tom Stellard t...@stellard.net CC: Matt Arsenault matthew.arsena...@amd.com Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- include/llvm/IR/IntrinsicsR600.td| 2 ++ lib/Target/R600/R600ISelLowering.cpp | 6 -- 2 files changed, 6

Re: [Mesa-dev] [PATCH 6/6] gallium: remove PIPE_CAP_BUFFER_SHARE cap and get_param sw_winsys hook

2014-07-30 Thread Giovanni Campagna
On Jul 29, 2014 7:42 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 24/07/14 01:43, Emil Velikov wrote: The kms_swrast driver has a separate InitScreen hook for its DriverAPI from the rest of the DRI2 drivers, all of which capable of buffer sharing. As such we no longer need to dive

Re: [Mesa-dev] [PATCH 10/15] mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3

2014-07-30 Thread Anuj Phogat
On Tue, Jul 29, 2014 at 5:04 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Fixes few failures in gles3 Khronos CTS test: packed_pixels Cc: 10.2 mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCH 11/15] mesa: Add a helper function _mesa_is_enum_format_unsized()

2014-07-30 Thread Anuj Phogat
On Tue, Jul 29, 2014 at 5:02 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Function is utilized by next patch in the series. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com

[Mesa-dev] [PATCH v2 1/4] ra: cleanup the public API

2014-07-30 Thread Connor Abbott
Previously, there were 3 entrypoints into parts of the actual allocator, and an API called ra_allocate_no_spills() that called all 3. Nobody would ever want to call any of the 3 entrypoints by themselves, so everybody just used ra_allocate_no_spills(). So just make them static functions, and while

[Mesa-dev] [PATCH v2 2/4] ra: make the p, q test more efficient

2014-07-30 Thread Connor Abbott
We can store the q total that pq_test() would've calculated in the node itself, updating it when we add a node to the stack. This way, we only have to walk the adjacency list when we push a node on the stack (i.e. when the p, q test succeeds) instead of every time we do the p, q test. No

[Mesa-dev] [PATCH v2 4/4] ra: optimistically color only one node at a time

2014-07-30 Thread Connor Abbott
Before, when we encountered a situation where we had to optimistically color a node, we would immediately give up and push all the remaining nodes on the stack in the order of their index - which is a random, and potentially not optimal, order. Instead, choose one node to optimistically color in

[Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-30 Thread Connor Abbott
Before, we would only consider nodes for spilling if they were optimistically pushed onto the stack. But the logic for this was complicated, and duplicated some things; also, we might want to spill nodes that are not optimistically colored if our heuristic says we should. This becomes a problem

[Mesa-dev] [PATCH v2 0/4] Some register allocator cleanups and optimizations

2014-07-30 Thread Connor Abbott
This patch series contains some improvements to the register allocator used by the i965 fs and vec4 backends and r300g. The most important patch is the last one, which causes many fragment shaders to gain SIMD16 as we make smarter decisions in the allocator. Full shader-db results are reproduced

[Mesa-dev] Patches queued up for upcoming 10.2.5 release

2014-07-30 Thread Carl Worth
I've just pushed some updates to the 10.2 branch in preparation for an upcoming stable release. The patches that are queued (as well as those that have been nominated but aren't yet on master) can be seen here: http://cworth.org/~cworth/mesa-stable-queue/ As always, I would really

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-30 Thread Eric Anholt
Connor Abbott cwabbo...@gmail.com writes: Before, we would only consider nodes for spilling if they were optimistically pushed onto the stack. But the logic for this was complicated, and duplicated some things; also, we might want to spill nodes that are not optimistically colored if our

Re: [Mesa-dev] [PATCH v2 4/4] ra: optimistically color only one node at a time

2014-07-30 Thread Eric Anholt
Connor Abbott cwabbo...@gmail.com writes: Before, when we encountered a situation where we had to optimistically color a node, we would immediately give up and push all the remaining nodes on the stack in the order of their index - which is a random, and potentially not optimal, order.