[Mesa-dev] [PATCH 1/2] i965/vec4: Don't segfault when debug-logging a null program

2014-09-01 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 5f8f399..ebe1216 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++

[Mesa-dev] [PATCH] main: Don't leak temporary texture rows

2014-09-01 Thread Jason Ekstrand
--- src/mesa/main/texstore.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index f2eb0de..4b8158a 100644 --- a/src/mesa/main/texstore.c +++ b/src/mesa/main/texstore.c @@ -1634,6 +1634,8 @@ texstore_via_float(TEXSTORE_PARAMS) }

[Mesa-dev] [PATCH 2/2] i965/fs: Don't segfault when debug-logging a null program

2014-09-01 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 43aee66..8b76c3e 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++

[Mesa-dev] [PATCH] loader: fds can be 0

2014-09-01 Thread Dave Airlie
Possible resource leak reported by coverity. Reported-by: Coverity scanner. Signed-off-by: Dave Airlie airl...@redhat.com --- src/loader/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/loader/loader.c b/src/loader/loader.c index 47e1f58..bdd3906 100644 ---

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Compile dummy pixel shader on demand

2014-09-01 Thread Marek Olšák
On Wed, Aug 27, 2014 at 10:57 AM, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com It's never used under normal circumstances. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/si_pipe.c | 7 ---

Re: [Mesa-dev] [PATCH 2/7] radeon/compute: Report a value for PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE

2014-09-01 Thread Marek Olšák
PIPE_SHADER_MAX_CONST_BUFFER_SIZE replaced MAX_CONSTS. The former is in bytes, while the latter was in vec4s (16 bytes). Marek On Wed, Aug 27, 2014 at 8:05 AM, Dave Airlie airl...@gmail.com wrote: I think Tom cc'ed the wrong stable maybe, not sure, 10.2 doesn't have

Re: [Mesa-dev] [PATCH] mesa: Convert NewDriverState to 64-bits

2014-09-01 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Aug 28, 2014 at 6:44 AM, Jordan Justen jordan.l.jus...@intel.com wrote: i965 will have more than 32 bits when BRW_STATE_COMPUTE_PROGRAM is added. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- Ken, How about this to

Re: [Mesa-dev] [PATCH] r600g, radeonsi: Inform the kernel if a BO will likely be accessed by the CPU

2014-09-01 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Aug 28, 2014 at 8:56 AM, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com This allows the kernel to prevent such BOs from ever being stored in the CPU inaccessible part of VRAM. Signed-off-by:

Re: [Mesa-dev] [PATCH] r600g, radeonsi: Always use GTT again for PIPE_USAGE_STREAM buffers

2014-09-01 Thread Marek Olšák
Perhaps Valley uses scattered writes, which the write-combining cache doesn't like? u_upload_mgr mostly uses sequential writes, so I think it could still benefit from VRAM placement. Just guessing. Does the STREAM flag which causes problems come from Valley (glBufferData) or from Mesa

Re: [Mesa-dev] [PATCH] mesa: fix fallback texture for cube map array

2014-09-01 Thread Marek Olšák
On Thu, Aug 28, 2014 at 3:36 PM, Roland Scheidegger srol...@vmware.com wrote: Oops there's a bug in there, I'll send out a new version (we only pass a one pixel sized array). FWIW the msaa case also has its issues (generates a warning in store_texsubimage, I guess that's pretty harmless though

[Mesa-dev] [PATCH] Revert mesa: fix make tarballs

2014-09-01 Thread Emil Velikov
This reverts commit 0fbb9a599df898d4e1166d6d6f00cb34a0524bea. Rather than adding hacks around the issue drop the sources from the final tarball, and re-add them back with 'make dist'. This fixes a problem when running parallel 'make install' fails as it recreates sources and triggers partial

[Mesa-dev] [Bug 76188] EGL_EXT_image_dma_buf_import fd ownership is incorrect

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=76188 --- Comment #11 from Pekka Paalanen ppaala...@gmail.com --- Sent to Mesa-stable: http://lists.freedesktop.org/archives/mesa-stable/2014-September/001683.html -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 79662] [DRI3 all Bisected] Many webglc cases fail and X fails on PNV

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79662 Eero Tamminen eero.t.tammi...@intel.com changed: What|Removed |Added CC|

[Mesa-dev] [Bug 83355] New: FTBFS: src/mesa/program/program_lexer.l:122:64: error: unknown type name 'YYSTYPE'

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83355 Priority: medium Bug ID: 83355 Assignee: mesa-dev@lists.freedesktop.org Summary: FTBFS: src/mesa/program/program_lexer.l:122:64: error: unknown type name 'YYSTYPE' Severity:

[Mesa-dev] [Bug 83355] FTBFS: src/mesa/program/program_lexer.l:122:64: error: unknown type name 'YYSTYPE'

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83355 --- Comment #1 from Emil Velikov emil.l.veli...@gmail.com --- Parallel 'make install' was never tested to work (see the release announcements). With that aside a the following patch [1] will revert the commit and resolve the original issue in

[Mesa-dev] [Bug 83355] FTBFS: src/mesa/program/program_lexer.l:122:64: error: unknown type name 'YYSTYPE'

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83355 --- Comment #2 from Kai k...@dev.carbon-project.org --- Thanks Emil, the patch fixes the build again. You can have my Tested-by: Kai Wasserbäch k...@dev.carbon-project.org With regards to the parallel build: I always build in parallel and

[Mesa-dev] [Bug 83355] FTBFS: src/mesa/program/program_lexer.l:122:64: error: unknown type name 'YYSTYPE'

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83355 --- Comment #3 from Emil Velikov emil.l.veli...@gmail.com --- (In reply to comment #2) Thanks Emil, the patch fixes the build again. You can have my Tested-by: Kai Wasserbäch k...@dev.carbon-project.org Thanks. With regards to the

[Mesa-dev] [PATCH] nv50/ir: avoid creating instructions that can't be emitted

2014-09-01 Thread Ilia Mirkin
When constant folding a MAD operation, we first fold the multiply and generate an ADD. However we do so without making sure that the immediate can be handled in the saturate case. If it can't, load the immediate in a separate instruction. Reported-by: Tiziano Bacocco tizb...@gmail.com

Re: [Mesa-dev] The long road to 'make dist' (gallium#2)

2014-09-01 Thread Roland Scheidegger
Am 30.08.2014 01:44, schrieb Emil Velikov: Hello list, Another boring yet important series, if we are to have properly working solution to package a mesa release tarball via 'make dist'. This series covers a few state-tracker files missed out previously, picks up all the gallium tests,

Re: [Mesa-dev] The long road to 'make dist' (gallium#2)

2014-09-01 Thread Emil Velikov
On 01/09/14 16:31, Roland Scheidegger wrote: Am 30.08.2014 01:44, schrieb Emil Velikov: Hello list, Another boring yet important series, if we are to have properly working solution to package a mesa release tarball via 'make dist'. This series covers a few state-tracker files missed out

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-01 Thread Roland Scheidegger
Am 29.08.2014 22:44, schrieb Ilia Mirkin: Hello, I've been thinking a bit about how to properly implement TCS outputs in TGSI. As a quick reminder, there are per-vertex (i.e. invocation) and per-patch outputs in TCS. And while you can only write to the current invocation's per-vertex

Re: [Mesa-dev] The long road to 'make dist' (gallium#2)

2014-09-01 Thread Matt Turner
On Mon, Sep 1, 2014 at 8:31 AM, Roland Scheidegger srol...@vmware.com wrote: Am 30.08.2014 01:44, schrieb Emil Velikov: Hello list, Another boring yet important series, if we are to have properly working solution to package a mesa release tarball via 'make dist'. This series covers a few

[Mesa-dev] [PATCH] automake: check if the linker supports --dynamic-list

2014-09-01 Thread Jonathan Gray
As older versions of gnu ld did not support --dynamic-list check to see if it is supported before using it. Non gnu linkers such the apple one likely lack this option as well. Fixes the build on OpenBSD which has binutils 2.15 and 2.17. The --dynamic-list option seems to been have introduced

Re: [Mesa-dev] The long road to 'make dist' (gallium#2)

2014-09-01 Thread Roland Scheidegger
Am 01.09.2014 17:55, schrieb Emil Velikov: On 01/09/14 16:31, Roland Scheidegger wrote: Am 30.08.2014 01:44, schrieb Emil Velikov: Hello list, Another boring yet important series, if we are to have properly working solution to package a mesa release tarball via 'make dist'. This series

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-01 Thread Ilia Mirkin
On Mon, Sep 1, 2014 at 12:00 PM, Roland Scheidegger srol...@vmware.com wrote: Am 29.08.2014 22:44, schrieb Ilia Mirkin: Hello, I've been thinking a bit about how to properly implement TCS outputs in TGSI. As a quick reminder, there are per-vertex (i.e. invocation) and per-patch outputs in

[Mesa-dev] [PATCH 04/14] i965/scalar_visitor: Add init function

2014-09-01 Thread Jordan Justen
This common init routine can be used by constructors for multiple program types. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_scalar.h | 1 + src/mesa/drivers/dri/i965/brw_scalar_visitor.cpp | 6 ++ 2 files changed, 7 insertions(+) diff

[Mesa-dev] [PATCH 07/14] i965: Add brw_scalar_prog_key structure

2014-09-01 Thread Jordan Justen
All fields were migrated from brw_wm_prog_key. In future updates, we can move these FS specific fields back into brw_wm_prog_key. The scalar_visitor and scalar_generator class mainly use these structures now. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com ---

[Mesa-dev] [PATCH 11/14] i965: Add uses_kill to brw_scalar_prog_data

2014-09-01 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_context.h| 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_scalar_generator.cpp | 2 +- src/mesa/drivers/dri/i965/brw_scalar_visitor.cpp | 12

[Mesa-dev] [PATCH 14/14] i965: Don't store gl_fragment_program in scalar_visitor

2014-09-01 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 8 ++-- src/mesa/drivers/dri/i965/brw_scalar.h | 1 - src/mesa/drivers/dri/i965/brw_scalar_visitor.cpp | 1 - src/mesa/drivers/dri/i965/brw_wm_iz.cpp | 2 ++ 4

[Mesa-dev] [PATCH 13/14] i965: Remove gl_fragment_program dependence in scalar_generator

2014-09-01 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_scalar.h | 4 ++-- src/mesa/drivers/dri/i965/brw_scalar_generator.cpp | 10 +- 3 files changed, 8 insertions(+), 8 deletions(-)

[Mesa-dev] [PATCH 05/14] i965: Allow brw_scalar.h to be included in C files

2014-09-01 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_scalar.h | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_scalar.h b/src/mesa/drivers/dri/i965/brw_scalar.h index 7d3ebdb..be71101 100644

[Mesa-dev] [PATCH 09/14] i965/scalar_visitor: Use prog rather than fp-Base

2014-09-01 Thread Jordan Justen
Reduce scalar_visitor's dependence on gl_fragment_program. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_fs.cpp | 28 src/mesa/drivers/dri/i965/brw_scalar_visitor.cpp | 2 +- 2 files changed, 15 insertions(+), 15

[Mesa-dev] [PATCH 10/14] i965/fs: Use gl_program* rather than fp-Base

2014-09-01 Thread Jordan Justen
Reduce brw_fs_precompile's dependence on gl_fragment_program. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_fs.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [PATCH 08/14] i965/scalar_visitor: Use stage_prog_data instead of prog_data-base

2014-09-01 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_scalar_visitor.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_scalar_visitor.cpp b/src/mesa/drivers/dri/i965/brw_scalar_visitor.cpp index

[Mesa-dev] [PATCH 01/14] i965: Rename brw_fs.h to brw_scalar.h

2014-09-01 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 2 +- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs.h | 699 -

[Mesa-dev] [PATCH 00/14] First steps to generalize scalar code gen

2014-09-01 Thread Jordan Justen
This starts the process of generalizing the scalar code gen so it can be used for other stages beyond FS. These changes are enough to allow code for a basic compute shader to be generated. (With some more CS patches added...) No piglit regressions were seen on gen7.

[Mesa-dev] [PATCH 06/14] i965: Add brw_scalar_prog_data structure

2014-09-01 Thread Jordan Justen
All fields were migrated from brw_wm_prog_data. In future updates, we can move these FS specific fields back into brw_wm_prog_data. The scalar_visitor and scalar_generator class mainly use these structures now. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com ---

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-01 Thread Roland Scheidegger
Am 01.09.2014 18:19, schrieb Ilia Mirkin: On Mon, Sep 1, 2014 at 12:00 PM, Roland Scheidegger srol...@vmware.com wrote: Am 29.08.2014 22:44, schrieb Ilia Mirkin: Hello, I've been thinking a bit about how to properly implement TCS outputs in TGSI. As a quick reminder, there are per-vertex

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-01 Thread Ilia Mirkin
On Mon, Sep 1, 2014 at 12:47 PM, Roland Scheidegger srol...@vmware.com wrote: Am 01.09.2014 18:19, schrieb Ilia Mirkin: On Mon, Sep 1, 2014 at 12:00 PM, Roland Scheidegger srol...@vmware.com wrote: Am 29.08.2014 22:44, schrieb Ilia Mirkin: Hello, I've been thinking a bit about how to

[Mesa-dev] [PATCH 2/3] nv50: mt address may not be the underlying bo's start address

2014-09-01 Thread Ilia Mirkin
With VP2, nv50_miptree is faked because the underlying bo's have to be laid out in a certain way. This is done by adjusting the address. Make sure that blits (and everything else for consistency) use the mt address rather than the bo address as a base. This fixes retrieving chroma plane with

[Mesa-dev] [PATCH 1/3] nv50: set the miptree address when clearing bo's in vp2 init

2014-09-01 Thread Ilia Mirkin
The mt address is about to be used more, make sure it's set appropriately. Reported-by: Emil Velikov emil.l.veli...@gmail.com Tested-by: Emil Velikov emil.l.veli...@gmail.com Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.2 10.3 mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 3/3] nv50: attach the buffer bo to the miptree structures

2014-09-01 Thread Ilia Mirkin
The current code... makes no sense. Use nouveau_bo_ref to attach the bo to the exposed resource so as to have the proper lifetime guarantees. Tested-by: Emil Velikov emil.l.veli...@gmail.com Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Cc: 10.2 10.3 mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Don't segfault when debug-logging a null program

2014-09-01 Thread Kenneth Graunke
On Monday, September 01, 2014 01:36:16 AM Jason Ekstrand wrote: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 43aee66..8b76c3e 100644 ---

Re: [Mesa-dev] [PATCH] loader: fds can be 0

2014-09-01 Thread Kenneth Graunke
On Monday, September 01, 2014 07:45:26 PM Dave Airlie wrote: Possible resource leak reported by coverity. Reported-by: Coverity scanner. Signed-off-by: Dave Airlie airl...@redhat.com --- src/loader/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 13/37] i965/gen6/gs: Implement GS_OPCODE_SET_DWORD_2.

2014-09-01 Thread Kenneth Graunke
On Thursday, August 14, 2014 01:11:45 PM Iago Toral Quiroga wrote: We have GS_OPCODE_SET_DWORD_2_IMMED but this requires its source argument to be an immediate. In gen6 we need to set dword 2 of the URB write message header from values stored in separate register, so we need something more

Re: [Mesa-dev] TGSI and Tessellation Control Shader outputs

2014-09-01 Thread Roland Scheidegger
Am 01.09.2014 18:53, schrieb Ilia Mirkin: On Mon, Sep 1, 2014 at 12:47 PM, Roland Scheidegger srol...@vmware.com wrote: Am 01.09.2014 18:19, schrieb Ilia Mirkin: On Mon, Sep 1, 2014 at 12:00 PM, Roland Scheidegger srol...@vmware.com wrote: Am 29.08.2014 22:44, schrieb Ilia Mirkin: Hello,

[Mesa-dev] [PATCH] mesa: invalidate draw state in glPopClientAttrib

2014-09-01 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82538 Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/attrib.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index c656845..2e289b6

Re: [Mesa-dev] [PATCH 07/37] i965/gen6/gs: Implement GS_OPCODE_FF_SYNC.

2014-09-01 Thread Kenneth Graunke
On Thursday, August 14, 2014 01:11:39 PM Iago Toral Quiroga wrote: This implements the FF_SYNC message required in gen6 geometry shaders to get the initial URB handle. --- src/mesa/drivers/dri/i965/brw_defines.h | 14 + src/mesa/drivers/dri/i965/brw_shader.cpp | 2

[Mesa-dev] [PATCH] nv50/ir: use unordered_set instead of list to keep track of var defs

2014-09-01 Thread Tobias Klausmann
The set of variable defs does not need to be ordered in any way, and removing/adding elements is a fairly common operation in various optimization passes. This shortens runtime of piglit test fp-long-alu to ~11s from ~22s No piglit regressions observed on nvc0! Signed-off-by: Tobias Klausmann

[Mesa-dev] [Bug 66184] src/mesa/state_tracker/st_glsl_to_tgsi.cpp:3216:simplify_cmp: Assertion `inst-dst.index 4096' failed.

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=66184 Marek Olšák mar...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] r600g: Implement sm5 geometry shader instancing

2014-09-01 Thread Marek Olšák
Pushed, thanks. Marek On Mon, Aug 25, 2014 at 11:05 AM, Glenn Kennard glenn.kenn...@gmail.com wrote: Requires Evergreen or later hardware. Signed-off-by: Glenn Kennard glenn.kenn...@gmail.com --- docs/GL3.txt | 2 +-

[Mesa-dev] [PATCH] r600g: Implement sm5 interpolation functions

2014-09-01 Thread Glenn Kennard
Requires evergreen/cayman Signed-off-by: Glenn Kennard glenn.kenn...@gmail.com --- This patch depends on r600g: Implement GL_ARB_sample_shading Implementation note: interpolateAtSample/Offset is doing affine rather than perspective correct reverse projection, I think for the small intra-pixel

Re: [Mesa-dev] [Mesa-stable] [PATCH v4] winsys/radeon: fix nop packet padding for hawaii

2014-09-01 Thread Marek Olšák
Hi Emil, The first attachment is the patch for 10.2. The other two patches fix build with latest LLVM for 10.2. Marek On Tue, Aug 26, 2014 at 10:09 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 06/08/14 17:16, Alex Deucher wrote: On Mon, Aug 4, 2014 at 6:48 AM, Andreas Boll

Re: [Mesa-dev] [PATCH v2 00/14] i965/gen7+ hiz cleanup + gen8 hiz improvements

2014-09-01 Thread Jordan Justen
Ken, I think you were concerned about: [PATCH v2 06/14] i965/gen8: Enable hiz for all depth levels but, you weren't able to reproduce any issues with it. Should we try this series on master now that 10.3 has branched? -Jordan On Mon, Jul 21, 2014 at 11:00 PM, Jordan Justen

[Mesa-dev] [PATCH] vdpau: unlock the mutex on error paths in attribute setting.

2014-09-01 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Coverity pointed out we never dropped the lock here, so fix it by using a common exit path. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/state_trackers/vdpau/mixer.c | 38 ++-- 1 file changed, 26 insertions(+), 12

[Mesa-dev] [PATCH] nouveau: don't leak dec struct on error

2014-09-01 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This one path doesn't goto fail, so it seems to leak dec. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/drivers/nouveau/nouveau_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] i965: possible typo in ir_unop_f2b case.

2014-09-01 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Coverity reported this, I'm not sure this patch is correct, but I'm sure someone who knows can fix this or push my fix. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] nouveau: don't leak dec struct on error

2014-09-01 Thread Ilia Mirkin
On Mon, Sep 1, 2014 at 7:08 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com This one path doesn't goto fail, so it seems to leak dec. Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Ilia Mirkin imir...@alum.mit.edu ---

[Mesa-dev] [PATCH] r300g: pointless assignment of info.indexed

2014-09-01 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Did this code mean to do something else, you tell me! Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/drivers/r300/r300_render.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/drivers/r300/r300_render.c

[Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

2014-09-01 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Coverity reported this, and I think this is the right solution, since cache-items is struct cache_item ** not struct cache_item *, we also realloc it using struct cache_item * at some point. Signed-off-by: Dave Airlie airl...@redhat.com ---

Re: [Mesa-dev] [PATCH 0/3] cl workdim v2

2014-09-01 Thread Jan Vesely
On Sat, 2014-08-16 at 13:13 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: On Thu, 2014-08-07 at 16:02 +0300, Francisco Jerez wrote: Jan Vesely jan.ves...@rutgers.edu writes: This respin includes Francisco's approach of providing implicit in the arg vector

[Mesa-dev] [PATCH] omx/h264: remove stray semicolon after if

2014-09-01 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Coverity reported this, looks wrong to me. Signed-off-by: Dave Airlie airl...@redhat.com --- src/gallium/state_trackers/omx/vid_dec_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/omx/vid_dec_h264.c

[Mesa-dev] uninitialised fields in ir_variable::ir_variable

2014-09-01 Thread Dave Airlie
coverity gives out that we initialize a bunch of fields in the ir_variable constructor, but we don't initialize a bunch more of them, precise, assigned etc. Someone should probably take a look who knows C++ better than me :-) Dave. ___ mesa-dev

[Mesa-dev] [PATCH] glsl: free uniform_map on failure path.

2014-09-01 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com If we fails in reserve_explicit_locations, we leak uniform_map. Reported-by: coverity scanner. Signed-off-by: Dave Airlie airl...@redhat.com --- src/glsl/linker.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/linker.cpp

[Mesa-dev] [PATCH] i965: add missing parens in vec4 visitor

2014-09-01 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com coverity reported this, Matt said it look like missing parens, not bad identing, so lets try that. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH] i965: add missing parens in vec4 visitor

2014-09-01 Thread Chris Forbes
Oops. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Sep 2, 2014 at 12:14 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com coverity reported this, Matt said it look like missing parens, not bad identing, so lets try that. Signed-off-by: Dave Airlie

[Mesa-dev] [Bug 83381] New: dri_screen.c:72:10: error: expected '}'

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83381 Priority: medium Bug ID: 83381 Assignee: mesa-dev@lists.freedesktop.org Summary: dri_screen.c:72:10: error: expected '}' Severity: normal Classification: Unclassified OS:

[Mesa-dev] [Bug 83382] New: /usr/include/string.h:82:1: error: unknown type name '__extern_always_inline'

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83382 Priority: medium Bug ID: 83382 Assignee: mesa-dev@lists.freedesktop.org Summary: /usr/include/string.h:82:1: error: unknown type name '__extern_always_inline' Severity:

[Mesa-dev] [Bug 82327] FAIL: glcpp/tests/glcpp-test-cr-lf

2014-09-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82327 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED