[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #5 from Emil Velikov emil.l.veli...@gmail.com --- (In reply to Christian König from comment #3) Most likely we end up with the implementation with the dummy symbols loaded first (e.g. kodi loads OGL first the VDPAU). This results in

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 Emil Velikov emil.l.veli...@gmail.com changed: What|Removed |Added CC|

[Mesa-dev] [PATCH] r300g: implement ARR opcode

2014-12-19 Thread David Heidelberg
Same as ARL, just has extra rounding. Useful for st/nine. Tested-by: Pavel Ondračka pavel.ondra...@email.cz Reviewed-by: Marek Olšák marek.ol...@amd.com Signed-off-by: David Heidelberg da...@ixit.cz --- src/gallium/drivers/r300/compiler/r3xx_vertprog.c | 7 ---

[Mesa-dev] [PATCH] st/nine: fix DBG typo (trivial)

2014-12-19 Thread David Heidelberg
Signed-off-by: David Heidelberg da...@ixit.cz --- src/gallium/state_trackers/nine/device9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c index b0e42eb..1d97688 100644 ---

[Mesa-dev] [PATCH] auxiliary/vl: move most sources back into the aux library

2014-12-19 Thread Emil Velikov
Due to the current implementation of the gl-vdpau interop, we depend on the dri module having a working set of util VL functions. Otherwise we will end up calling the stubs. This commit partially reverts the following commits: f093c1c8ec1(auxiliary/vl: add galliumvl_stub.la)

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 Emil Velikov emil.l.veli...@gmail.com changed: What|Removed |Added URL|

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 Christian König deathsim...@vodafone.de changed: What|Removed |Added URL|http://patchwork.freedeskto |

Re: [Mesa-dev] [PATCH] st/nine: fix DBG typo (trivial)

2014-12-19 Thread Alex Deucher
On Fri, Dec 19, 2014 at 8:13 AM, David Heidelberg da...@ixit.cz wrote: Signed-off-by: David Heidelberg da...@ixit.cz Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- src/gallium/state_trackers/nine/device9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] r300g: implement ARR opcode

2014-12-19 Thread Alex Deucher
On Fri, Dec 19, 2014 at 8:11 AM, David Heidelberg da...@ixit.cz wrote: Same as ARL, just has extra rounding. Useful for st/nine. Tested-by: Pavel Ondračka pavel.ondra...@email.cz Reviewed-by: Marek Olšák marek.ol...@amd.com Signed-off-by: David Heidelberg da...@ixit.cz Reviewed-by: Alex

[Mesa-dev] [PATCH 1/2] clover: support CL_PROGRAM_BINARY_TYPE (CL1.2)

2014-12-19 Thread EdB
CL_PROGRAM_BINARY_TYPE have been added to clGetProgramBuildInfo in CL1.2 --- src/gallium/state_trackers/clover/api/program.cpp | 4 +++ src/gallium/state_trackers/clover/core/program.cpp | 31 +- src/gallium/state_trackers/clover/core/program.hpp | 1 + 3 files changed, 29

[Mesa-dev] [PATCH 2/2] clover: add missing clGetDeviceInfo CL1.2 queries

2014-12-19 Thread EdB
--- src/gallium/state_trackers/clover/api/device.cpp | 21 + src/gallium/state_trackers/clover/core/device.cpp | 11 +++ src/gallium/state_trackers/clover/core/device.hpp | 2 ++ 3 files changed, 34 insertions(+) diff --git

[Mesa-dev] [PATCH 0/2] Add support for some of the missing CL1.2 queries

2014-12-19 Thread EdB
patch 1 depends on clLinkProgram serie patch 2 should be fine on master EdB (2): clover: support CL_PROGRAM_BINARY_TYPE (CL1.2) clover: add missing clGetDeviceInfo CL1.2 queries src/gallium/state_trackers/clover/api/device.cpp | 21 +++

Re: [Mesa-dev] [PATCH] auxiliary/vl: move most sources back into the aux library

2014-12-19 Thread Christian König
Am 19.12.2014 um 15:04 schrieb Emil Velikov: Due to the current implementation of the gl-vdpau interop, we depend on the dri module having a working set of util VL functions. Otherwise we will end up calling the stubs. This commit partially reverts the following commits:

[Mesa-dev] [PATCH 1/2] gallivm: silence a couple compiler warnings

2014-12-19 Thread Brian Paul
Silence warnings about possibly uninitialized variables when making a release build. --- src/gallium/auxiliary/gallivm/lp_bld_sample.c | 3 +++ src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] draw: silence uninitialized variable warning

2014-12-19 Thread Brian Paul
--- src/gallium/auxiliary/draw/draw_gs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/draw/draw_gs.c b/src/gallium/auxiliary/draw/draw_gs.c index 40f7ed3..7b1cc0b 100644 --- a/src/gallium/auxiliary/draw/draw_gs.c +++ b/src/gallium/auxiliary/draw/draw_gs.c @@ -733,6

Re: [Mesa-dev] [PATCH 1/2] gallivm: silence a couple compiler warnings

2014-12-19 Thread Jose Fonseca
On 19/12/14 16:37, Brian Paul wrote: Silence warnings about possibly uninitialized variables when making a release build. --- src/gallium/auxiliary/gallivm/lp_bld_sample.c | 3 +++ src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] draw: silence uninitialized variable warning

2014-12-19 Thread Brian Paul
v2: move initialization of llvm_gs to declaration. --- src/gallium/auxiliary/draw/draw_gs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_gs.c b/src/gallium/auxiliary/draw/draw_gs.c index 40f7ed3..6375d41 100644 ---

Re: [Mesa-dev] [PATCH 005/133] nir: add core helper functions

2014-12-19 Thread Jason Ekstrand
On Tue, Dec 16, 2014 at 3:47 PM, Eric Anholt e...@anholt.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: From: Connor Abbott connor.abb...@intel.com These include functions for adding and removing various bits of IR and helpers for iterating over all the sources and destinations

Re: [Mesa-dev] [PATCH] draw: silence uninitialized variable warning

2014-12-19 Thread Roland Scheidegger
Am 19.12.2014 um 18:37 schrieb Brian Paul: v2: move initialization of llvm_gs to declaration. --- src/gallium/auxiliary/draw/draw_gs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_gs.c b/src/gallium/auxiliary/draw/draw_gs.c index

Re: [Mesa-dev] [PATCH 4/4] i965: Use safer pointer arithmetic in gather_oa_results()

2014-12-19 Thread Ian Romanick
On 12/18/2014 10:14 PM, Kenneth Graunke wrote: On Tuesday, November 18, 2014 09:11:26 PM Chad Versace wrote: This patch reduces the likelihood of pointer arithmetic overflow bugs in gather_oa_results(), like the one fixed by b69c7c5dac. I haven't yet encountered any overflow bugs in the wild

[Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Rob Clark
From: Rob Clark robcl...@freedesktop.org This emulates alpha-test with a compare + KILL_IF. The alpha-ref value is passed to the shader via constant tagged with new ALPHAREF semantic. For example: FRAG PROPERTY FS_COLOR0_WRITES_ALL_CBUFS 1 DCL IN[0], COLOR, COLOR DCL OUT[0], COLOR

Re: [Mesa-dev] [PATCH 007/133] nir: add a validation pass

2014-12-19 Thread Eric Anholt
Connor Abbott cwabbo...@gmail.com writes: On Thu, Dec 18, 2014 at 1:49 PM, Eric Anholt e...@anholt.net wrote: Connor Abbott cwabbo...@gmail.com writes: On Thu, Dec 18, 2014 at 2:01 AM, Eric Anholt e...@anholt.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: From: Connor Abbott

Re: [Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

2014-12-19 Thread Kenneth Graunke
On Sunday, December 14, 2014 03:06:41 PM Emil Velikov wrote: On 11/12/14 21:51, Carl Worth wrote: From: Kristian Høgsberg k...@bitplanet.net The upcoming shader cache uses the SHA-1 algorithm for cryptographic naming. These new mesa_sha1 functions are implemented with the nettle

Re: [Mesa-dev] [PATCH 142/133] nir/print: Various cleanups recommended by Eric

2014-12-19 Thread Eric Anholt
Jason Ekstrand ja...@jlekstrand.net writes: Cc: Eric Anholt e...@anholt.net Nice. With this squashed in, and maybe a s/var_defs/var_decls/, that patch is: Reviewed-by: Eric Anholt e...@anholt.net signature.asc Description: PGP signature ___

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Ilia Mirkin
On Fri, Dec 19, 2014 at 2:11 PM, Rob Clark robdcl...@gmail.com wrote: From: Rob Clark robcl...@freedesktop.org This emulates alpha-test with a compare + KILL_IF. The alpha-ref value is passed to the shader via constant tagged with new ALPHAREF semantic. For example: FRAG PROPERTY

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Rob Clark
On Fri, Dec 19, 2014 at 3:50 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 2:11 PM, Rob Clark robdcl...@gmail.com wrote: From: Rob Clark robcl...@freedesktop.org This emulates alpha-test with a compare + KILL_IF. The alpha-ref value is passed to the shader via constant

Re: [Mesa-dev] [PATCH 2/7] clover: Dump the OpenCL C code earlier

2014-12-19 Thread Tom Stellard
On Sun, Dec 14, 2014 at 11:31:22AM +0100, EdB wrote: --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp

Re: [Mesa-dev] [PATCH 3/7] clover: split module::section::text

2014-12-19 Thread Tom Stellard
On Sun, Dec 14, 2014 at 11:31:23AM +0100, EdB wrote: OpenCL 1.2 make distinction between 3 binaries kind: executable as produce by clBuildProgram and clLinkProgam compiled as produce by clCompileProgram library as produce by clLinkProgam with -create-library option s/produce/produced/

Re: [Mesa-dev] [PATCH 2/7] clover: Dump the OpenCL C code earlier

2014-12-19 Thread EdB
On Friday, December 19, 2014 01:08:31 PM Tom Stellard wrote: On Sun, Dec 14, 2014 at 11:31:22AM +0100, EdB wrote: --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/7] clover: Dump the OpenCL C code earlier

2014-12-19 Thread Tom Stellard
On Fri, Dec 19, 2014 at 10:21:59PM +0100, EdB wrote: On Friday, December 19, 2014 01:08:31 PM Tom Stellard wrote: On Sun, Dec 14, 2014 at 11:31:22AM +0100, EdB wrote: --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [Mesa-dev] [PATCH 3/7] clover: split module::section::text

2014-12-19 Thread EdB
On Friday, December 19, 2014 01:14:47 PM Tom Stellard wrote: On Sun, Dec 14, 2014 at 11:31:23AM +0100, EdB wrote: OpenCL 1.2 make distinction between 3 binaries kind: executable as produce by clBuildProgram and clLinkProgam compiled as produce by clCompileProgram library as produce by

Re: [Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-19 Thread Glenn Kennard
On Tue, 16 Dec 2014 07:04:14 +0100, Jason Ekstrand ja...@jlekstrand.net wrote: From: Connor Abbott connor.abb...@intel.com This includes all the instructions, ifs, loops, functions, etc. This is similar to the information in ir.h. v2: Jason Ekstrand jason.ekstr...@intel.com: Include

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Ilia Mirkin
On Fri, Dec 19, 2014 at 4:04 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, Dec 19, 2014 at 3:50 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 2:11 PM, Rob Clark robdcl...@gmail.com wrote: From: Rob Clark robcl...@freedesktop.org This emulates alpha-test with a compare

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Rob Clark
On Fri, Dec 19, 2014 at 4:26 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 4:04 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, Dec 19, 2014 at 3:50 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 2:11 PM, Rob Clark robdcl...@gmail.com wrote: From:

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Brian Paul
On 12/19/2014 02:47 PM, Rob Clark wrote: On Fri, Dec 19, 2014 at 4:26 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 4:04 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, Dec 19, 2014 at 3:50 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 2:11 PM, Rob

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Ilia Mirkin
On Fri, Dec 19, 2014 at 4:47 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, Dec 19, 2014 at 4:26 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 4:04 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, Dec 19, 2014 at 3:50 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri,

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Rob Clark
On Fri, Dec 19, 2014 at 5:06 PM, Brian Paul bri...@vmware.com wrote: On 12/19/2014 02:47 PM, Rob Clark wrote: On Fri, Dec 19, 2014 at 4:26 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, Dec 19, 2014 at 4:04 PM, Rob Clark robdcl...@gmail.com wrote: On Fri, Dec 19, 2014 at 3:50 PM, Ilia

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Chris Forbes
On Sat, Dec 20, 2014 at 8:11 AM, Rob Clark robdcl...@gmail.com wrote: @@ -1452,6 +1593,20 @@ tgsi_transform_lowering(const struct tgsi_lowering_config *config, } } + if ((info-processor == TGSI_PROCESSOR_FRAGMENT) + config-lower_alpha_test + (config-alpha_func

[Mesa-dev] [PATCH 3/8] i965: Store the atoms directly in the context

2014-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Instead of having an extra pointer indirection in one of the hottest loops in the driver. On Bay Trail-D using Fedora 20 compile flags (-m64 -O2 -mtune=generic for 64-bit and -m32 -march=i686 -mtune=atom for 32-bit), affects Gl32Batch7: 32-bit:

[Mesa-dev] [PATCH 1/8] meta: Put _mesa_meta_in_progress in the header file

2014-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com ...so that it can be inlined in the two places that call it. On Bay Trail-D using Fedora 20 compile flags (-m64 -O2 -mtune=generic for 64-bit and -m32 -march=i686 -mtune=atom for 32-bit), affects Gl32Batch7: 32-bit: No difference proven at 95.0%

[Mesa-dev] [PATCH 8/8] mesa: Micro-optimize _mesa_is_valid_prim_mode

2014-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com You would not believe the mess GCC 4.8.3 generated for the old switch-statement. On Bay Trail-D using Fedora 20 compile flags (-m64 -O2 -mtune=generic for 64-bit and -m32 -march=i686 -mtune=atom for 32-bit), affects Gl32Batch7: 32-bit: Difference at

[Mesa-dev] [PATCH 2/8] i965: Micro-optimize brw_get_index_type

2014-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com With the switch-statement, GCC 4.8.3 produces a small pile of code with a branch. brw_get_index_type: 00: 8b 54 24 04 mov0x4(%esp),%edx 04: b8 01 00 00 00 mov$0x1,%eax 09: 81 fa

[Mesa-dev] [PATCH 5/8] mesa: Only check for a current vertex shader in core profile

2014-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This doesn't affect performance, but it feels more correct. On Bay Trail-D using Fedora 20 compile flags (-m64 -O2 -mtune=generic for 64-bit and -m32 -march=i686 -mtune=atom for 32-bit), affects Gl32Batch7: 32-bit: No difference proven at 95.0%

[Mesa-dev] [PATCH 4/8] mesa: Only validate shaders that can exist in the context

2014-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com On Bay Trail-D using Fedora 20 compile flags (-m64 -O2 -mtune=generic for 64-bit and -m32 -march=i686 -mtune=atom for 32-bit), affects Gl32Batch7: 32-bit: Difference at 95.0% confidence 0.495267% +/- 0.202063% (n=40) 64-bit: Difference at 95.0%

[Mesa-dev] [PATCH 7/8] mesa: Check for vertex program the same way in desktop GL and ES

2014-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com On Bay Trail-D using Fedora 20 compile flags (-m64 -O2 -mtune=generic for 64-bit and -m32 -march=i686 -mtune=atom for 32-bit), affects Gl32Multithread: 32-bit: Difference at 95.0% confidence 0.416027% +/- 0.163529% (n=40) 64-bit: Difference at 95.0%

[Mesa-dev] [PATCH 6/8] mesa: Drop index buffer bounds check

2014-12-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The previous check was insufficient (as it did not take 'indices' into consideration), and DX10 hardware does not need this check anyway. Since index_bytes is no longer used, remove it. On Bay Trail-D using Fedora 20 compile flags (-m64 -O2

Re: [Mesa-dev] [PATCH 1/8] meta: Put _mesa_meta_in_progress in the header file

2014-12-19 Thread Ian Romanick
I should have also mentioned that this series is on the byt-cpu-optimizations branch of my fd.o tree. On 12/19/2014 02:20 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com ...so that it can be inlined in the two places that call it. On Bay Trail-D using Fedora 20 compile

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Rob Clark
On Fri, Dec 19, 2014 at 5:18 PM, Chris Forbes chr...@ijw.co.nz wrote: On Sat, Dec 20, 2014 at 8:11 AM, Rob Clark robdcl...@gmail.com wrote: @@ -1452,6 +1593,20 @@ tgsi_transform_lowering(const struct tgsi_lowering_config *config, } } + if ((info-processor ==

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Roland Scheidegger
I'm not a fan of using semantics for consts (fwiw I think it would probably be a good idea to use different namespaces for system values and inputs too but that's another topic). I don't quite share the concerns about possibly indirectly addressing such a const though (because if const buffers are

[Mesa-dev] [PATCH v2 134/133] nir/opcodes: Add algebraic properties metadata

2014-12-19 Thread Jason Ekstrand
This commit adds some algebraic properties to the metadata of each opcode in NIR. In particular, you now know, just from the metadata, if a given opcode is commutative or associative. This will be useful for algebraic transformation passes that want to be able to match a + b as well as b + a in

[Mesa-dev] [Bug 87516] glProgramBinary violates spec

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87516 Bug ID: 87516 Summary: glProgramBinary violates spec Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: major Priority:

[Mesa-dev] [Bug 87516] glProgramBinary violates spec

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87516 Leith Bade le...@mapbox.com changed: What|Removed |Added Priority|medium |high -- You are receiving

[Mesa-dev] [PATCH] main: Don't advertise ARB/OES_get_program_binary

2014-12-19 Thread Jason Ekstrand
All we have right now are stub implementations of these that do nothing. Let's avoid confusing apps by advertising an extension we don't actually support. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87516 --- src/mesa/main/extensions.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Mesa-dev] [PATCH] main: Don't advertise ARB/OES_get_program_binary

2014-12-19 Thread Jason Ekstrand
scratch that... We need it for ES 3.0. I'll look at the bug more. On Fri, Dec 19, 2014 at 4:36 PM, Jason Ekstrand ja...@jlekstrand.net wrote: All we have right now are stub implementations of these that do nothing. Let's avoid confusing apps by advertising an extension we don't actually

[Mesa-dev] [Bug 87516] glProgramBinary violates spec

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87516 Jason Ekstrand ja...@jlekstrand.net changed: What|Removed |Added Priority|high|medium

[Mesa-dev] [PATCH 146/133] nir: Use static inlines instead of macros for list getters

2014-12-19 Thread Jason Ekstrand
This should make debugging a lot easier as GDB handles static inlines much better than macros. Also, static inlines are typesafe. --- src/glsl/nir/nir.h | 109 +++-- 1 file changed, 81 insertions(+), 28 deletions(-) diff --git a/src/glsl/nir/nir.h

[Mesa-dev] [PATCH 145/133] nir/variable: Remove the constant_value field

2014-12-19 Thread Jason Ekstrand
This was a left-over relic of GLSL IR that we aren't using for anything. If we ever want that value again, we can add it back, but NIR constant folding should be just as good as GLSL IR's if not better pretty soon, so I'm not worried about it. --- src/glsl/nir/glsl_to_nir.cpp | 6 ++

[Mesa-dev] [PATCH 147/133] nir: Make intrinsic flags into an enum

2014-12-19 Thread Jason Ekstrand
This should be much better for debugging as GDB will pick up on the fact that it's an enum and actually tell you what you're looking at instead of giving you some arbitrary hex value you have to go look up. --- src/glsl/nir/nir.h | 28 ++-- 1 file changed, 14

Re: [Mesa-dev] [PATCH] tgsi: lowering support for alpha test

2014-12-19 Thread Rob Clark
On Fri, Dec 19, 2014 at 5:35 PM, Roland Scheidegger srol...@vmware.com wrote: I'm not a fan of using semantics for consts (fwiw I think it would probably be a good idea to use different namespaces for system values and inputs too but that's another topic). I don't quite share the concerns

[Mesa-dev] [PATCH v3 134/133] nir/opcodes: Add algebraic properties metadata

2014-12-19 Thread Jason Ekstrand
This commit adds some algebraic properties to the metadata of each opcode in NIR. In particular, you now know, just from the metadata, if a given opcode is commutative or associative. This will be useful for algebraic transformation passes that want to be able to match a + b as well as b + a in

Re: [Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-19 Thread Jason Ekstrand
Glenn, Thanks for taking the time to look over things. On Fri, Dec 19, 2014 at 1:24 PM, Glenn Kennard glenn.kenn...@gmail.com wrote: On Tue, 16 Dec 2014 07:04:14 +0100, Jason Ekstrand ja...@jlekstrand.net wrote: From: Connor Abbott connor.abb...@intel.com This includes all the

[Mesa-dev] [Bug 87516] glProgramBinary violates spec

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87516 --- Comment #1 from Ian Romanick i...@freedesktop.org --- (In reply to Leith Bade from comment #0) The current implementation of ARB_get_program_binary is incomplete and currently violates the spec. Specifically these are the major issues:

[Mesa-dev] [Bug 87516] glProgramBinary violates spec

2014-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87516 --- Comment #2 from Leith Bade le...@mapbox.com --- Yeah the spec is a bit ambiguous. It is almost as if they can't see why anyone would implement ARB_get_program_binary without supporting at least one binaryFormat. Of course they then made it

Re: [Mesa-dev] [PATCH 146/133] nir: Use static inlines instead of macros for list getters

2014-12-19 Thread Glenn Kennard
On Sat, 20 Dec 2014 02:02:27 +0100, Jason Ekstrand ja...@jlekstrand.net wrote: This should make debugging a lot easier as GDB handles static inlines much better than macros. Also, static inlines are typesafe. --- src/glsl/nir/nir.h | 109

Re: [Mesa-dev] [PATCH v3 134/133] nir/opcodes: Add algebraic properties metadata

2014-12-19 Thread Matt Turner
On Fri, Dec 19, 2014 at 5:04 PM, Jason Ekstrand ja...@jlekstrand.net wrote: v3: fmin and fmax technically aren't commutative or associative. Things get funny when one of the arguments is a NaN. I have a difficult time believing that the GLSL definitions of min() and max() intentionally

Re: [Mesa-dev] [PATCH v3 134/133] nir/opcodes: Add algebraic properties metadata

2014-12-19 Thread Jason Ekstrand
On Fri, Dec 19, 2014 at 6:02 PM, Matt Turner matts...@gmail.com wrote: On Fri, Dec 19, 2014 at 5:04 PM, Jason Ekstrand ja...@jlekstrand.net wrote: v3: fmin and fmax technically aren't commutative or associative. Things get funny when one of the arguments is a NaN. I have a difficult

Re: [Mesa-dev] [PATCH 1/8] meta: Put _mesa_meta_in_progress in the header file

2014-12-19 Thread Matt Turner
On Fri, Dec 19, 2014 at 2:20 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com ...so that it can be inlined in the two places that call it. if (brw-meta_in_progress != _mesa_meta_in_progress(ctx)) { brw-meta_in_progress =

Re: [Mesa-dev] [PATCH 2/8] i965: Micro-optimize brw_get_index_type

2014-12-19 Thread Matt Turner
On Fri, Dec 19, 2014 at 2:20 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com With the switch-statement, GCC 4.8.3 produces a small pile of code with a branch. brw_get_index_type: 00: 8b 54 24 04 mov0x4(%esp),%edx

Re: [Mesa-dev] [PATCH] mesa: Add mesa SHA-1 functions

2014-12-19 Thread Carl Worth
On Fri, Dec 12 2014, Jose Fonseca wrote: Yes, ideally we'd have something small that we could bundle into mesa source tree, for sake of non Linux OSes. Ken has pointed to an implementation that might be suitable for this. I haven't reviewed that code myself, nor am I signing up to maintain a

[Mesa-dev] [PATCH 1/2] mesa: Add mesa SHA-1 functions

2014-12-19 Thread Carl Worth
The upcoming shader cache uses the SHA-1 algorithm for cryptographic naming. These new mesa_sha1 functions are implemented with any one of several differeny cryptographics libraries. This code was copied from the xserver repository, (where it has apparently been functioning well on a variety of

[Mesa-dev] [PATCH 2/2] configure: Add machinery for --enable-shader-cache (and --disable-shader-cache)

2014-12-19 Thread Carl Worth
We don't actually have the code for the shader cache just yet, but this configure machinery puts everything in place so that the shader cache can be optionally compiled in. Specifically, if the user passes no option (neither --disable-shader-cache, nor --enable-shader-cache), then this feature

Re: [Mesa-dev] [PATCH] main: Don't advertise ARB/OES_get_program_binary

2014-12-19 Thread Kenneth Graunke
On Friday, December 19, 2014 04:36:55 PM Jason Ekstrand wrote: All we have right now are stub implementations of these that do nothing. Let's avoid confusing apps by advertising an extension we don't actually support. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87516 ---