[Mesa-dev] [Bug 86651] [i965 Bisected]Piglit glx_glx-pixmap-multi fails, with DRI3 disabled

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86651 Chris Wilson ch...@chris-wilson.co.uk changed: What|Removed |Added Component|GLX |tests

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon on Source games

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 Eero Tamminen eero.t.tammi...@intel.com changed: What|Removed |Added Status|NEW |NEEDINFO ---

[Mesa-dev] [Bug 87913] CPU cacheline size of 0 can be returned by CPUID leaf 0x80000006 in some virtual machines

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87913 Bug ID: 87913 Summary: CPU cacheline size of 0 can be returned by CPUID leaf 0x8006 in some virtual machines Product: Mesa Version: unspecified Hardware: x86-64

[Mesa-dev] [Bug 87913] CPU cacheline size of 0 can be returned by CPUID leaf 0x80000006 in some virtual machines

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87913 Leonid Shatz leonid.sh...@ravellosystems.com changed: What|Removed |Added CC|

[Mesa-dev] [Bug 87913] CPU cacheline size of 0 can be returned by CPUID leaf 0x80000006 in some virtual machines

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87913 --- Comment #2 from Leonid Shatz leonid.sh...@ravellosystems.com --- Sorry, the correct code would be something like: if (regs[0] = 0x8006) { cpuid(0x8006, regs2); + if ((regs2[2] 0xFF) 0)

[Mesa-dev] [Bug 87658] [llvmpipe] SEGV in sse2_has_daz on ancient Pentium4-M

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87658 --- Comment #21 from Roland Scheidegger srol...@vmware.com --- (In reply to Chris Paulson-Ellis from comment #20) (In reply to Roland Scheidegger from comment #19) Maybe using PIPE_ALIGN_STACK static INLINE boolean sse2_has_daz(void) would

[Mesa-dev] [Bug 87913] CPU cacheline size of 0 can be returned by CPUID leaf 0x80000006 in some virtual machines

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87913 --- Comment #3 from Roland Scheidegger srol...@vmware.com --- I'm wondering if we actually should use this detection method if the other one (which queries clflush size in fact) is also available. I guess though there's some (amd) cpus where the

[Mesa-dev] [PATCH 1/2] gallium/util: fix crash with daz detection on x86

2014-12-31 Thread sroland
From: Roland Scheidegger srol...@vmware.com The code used PIPE_ALIGN_VAR for the variable used by fxsave, however this does not work if the stack isn't aligned. Hence use PIPE_ALIGN_STACK function decoration to fix the segfault which can happen if stack alignment is only 4 bytes. This fixes

[Mesa-dev] [PATCH 2/2] gallium/util: make sure cache line size is not zero

2014-12-31 Thread sroland
From: Leonid Shatz leonid.sh...@ravellosystems.com The normal detection (querying clflush size) already made sure it is non-zero, however another method did not. This lead to crashes if this value happened to be zero (apparently can happen in virtualized environments at least). This fixes

Re: [Mesa-dev] [PATCH 28/41] main: Nameless texture creation and deletion. Does not affect normal creation and deletion paths.

2014-12-31 Thread Anuj Phogat
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand la...@jlekstrand.net wrote: In implementing ARB_DIRECT_STATE_ACCESS functions, it is often necessary to abstract the functionality of a traditional GL API function into a backend that both the traditional and dsa API functions can share. For

Re: [Mesa-dev] [PATCH] i965: Fix start/base_vertex_location for 1 prims but !BRW_NEW_VERTICES.

2014-12-31 Thread Chris Forbes
Seems reasonable to me. Reviewed-by: Chris Forbes chr...@ijw.co.nz On Fri, Dec 19, 2014 at 1:45 AM, Kenneth Graunke kenn...@whitecape.org wrote: This is a partial revert of c89306983c07e5a88c0d636267e5ccf263cb4213. It split the {start,base}_vertex_location handling into several steps: 1. Set

Re: [Mesa-dev] [PATCH 29/41] main: Added entry point for glGetTextureImage.

2014-12-31 Thread Anuj Phogat
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand la...@jlekstrand.net wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 9 + src/mesa/main/texgetimage.c| 315 +++-- src/mesa/main/texgetimage.h| 9 + 3 files changed,

Re: [Mesa-dev] [PATCH 30/41] main: Added entry point for glGetCompressedTextureImage.

2014-12-31 Thread Anuj Phogat
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand la...@jlekstrand.net wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 + src/mesa/main/texgetimage.c| 169 ++--- src/mesa/main/texgetimage.h| 12 ++ 3 files changed,

Re: [Mesa-dev] [PATCH 29/41] main: Added entry point for glGetTextureImage.

2014-12-31 Thread Anuj Phogat
On Wed, Dec 31, 2014 at 11:21 AM, Anuj Phogat anuj.pho...@gmail.com wrote: On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand la...@jlekstrand.net wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 9 + src/mesa/main/texgetimage.c| 315 +++--

Re: [Mesa-dev] [PATCH 32/41] main: Added entry point for glGenerateTextureMipmap.

2014-12-31 Thread Anuj Phogat
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand la...@jlekstrand.net wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 4 ++ src/mesa/main/genmipmap.c | 73 +++--- src/mesa/main/genmipmap.h | 6 +++ 3 files changed,

Re: [Mesa-dev] [PATCH 4/4] st/mesa: add EXT_polygon_offset_clamp support

2014-12-31 Thread Eric Anholt
Ilia Mirkin imir...@alum.mit.edu writes: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu VC4 doesn't support this, so it shouldn't be enabled by default. signature.asc Description: PGP signature ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 34/41] main: Fixed _mesa_texture_image_multisample so that it updates the texObj-Immutable flag correctly.

2014-12-31 Thread Anuj Phogat
Use shorter commit messages in present tense: main: Fix texObj-Immutable flag update in _mesa_texture_image_multisample On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand la...@jlekstrand.net wrote: --- src/mesa/main/teximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 4/4] st/mesa: add EXT_polygon_offset_clamp support

2014-12-31 Thread Ilia Mirkin
On Wed, Dec 31, 2014 at 3:03 PM, Eric Anholt e...@anholt.net wrote: Ilia Mirkin imir...@alum.mit.edu writes: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu VC4 doesn't support this, so it shouldn't be enabled by default. VC4 also doesn't support core contexts. The extension is supposed to

Re: [Mesa-dev] [PATCH 40/41] main: Checking for cube completeness in GetTextureImage.

2014-12-31 Thread Anuj Phogat
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand la...@jlekstrand.net wrote: This is part of a potential solution to Khronos Bug 13223. Cube completeness is a concept from glGenerateMipmap, but it seems reasonable to check for it in GetTextureImage when the target is GL_TEXTURE_CUBE_MAP. Add

[Mesa-dev] [PATCH 1/2] glsl: Add define for ARB_shader_precision

2014-12-31 Thread Micah Fedke
--- src/glsl/glcpp/glcpp-parse.y| 3 +++ src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 5 files changed, 8 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y

[Mesa-dev] [PATCH 2/2] glapi: Add (empty) glapi for ARB_shader_precision

2014-12-31 Thread Micah Fedke
--- src/mapi/glapi/gen/gl_API.xml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index e1b1246..d7d0627 100644 --- a/src/mapi/glapi/gen/gl_API.xml +++ b/src/mapi/glapi/gen/gl_API.xml @@ -8247,7 +8247,11 @@

[Mesa-dev] [PATCH] gallium/state_tracker: Rewrite Haiku's state tracker

2014-12-31 Thread Alexander von Gluck IV
* More gallium-like * Leverage stamps properly and don't call mesa functions --- src/gallium/state_trackers/hgl/hgl.c | 338 +++- src/gallium/state_trackers/hgl/hgl_context.h | 13 +- .../targets/haiku-softpipe/GalliumContext.cpp | 59 +++--

Re: [Mesa-dev] [PATCH 40/41] main: Checking for cube completeness in GetTextureImage.

2014-12-31 Thread Laura Ekstrand
I began adding to my comment as you suggested, but found out that cube completeness only applies to the base level of a cube map. So I had to modify this patch to check for cube completeness of an arbitrary level. I will be sending out a new patch Checking for cube completeness in

[Mesa-dev] [PATCH 2/2] i965: Fix INTEL_DEBUG=optimizer with VF types.

2014-12-31 Thread Kenneth Graunke
Hardcoding stderr is wrong; INTEL_DEBUG=optimizer uses other files. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] i965: Show opt_vector_float() and later passes in INTEL_DEBUG=optimizer.

2014-12-31 Thread Kenneth Graunke
In order to support calling opt_vector_float() inside a condition, this patch makes OPT() a statement expression: https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html We've used that elsewhere already. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 85529, which changed state. Bug 85529 Summary: Surfaces not drawn in Unvanquished https://bugs.freedesktop.org/show_bug.cgi?id=85529 What|Removed |Added

Re: [Mesa-dev] [PATCH 2/2] i965: Fix INTEL_DEBUG=optimizer with VF types.

2014-12-31 Thread Matt Turner
On Wed, Dec 31, 2014 at 4:59 PM, Kenneth Graunke kenn...@whitecape.org wrote: Hardcoding stderr is wrong; INTEL_DEBUG=optimizer uses other files. Whoops! Thanks Ken. Both are Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list

[Mesa-dev] [PATCH 1/3] main: Added _mesa_cube_level_complete to check for the completeness of an arbitrary cube map level.

2014-12-31 Thread Laura Ekstrand
--- src/mesa/main/texobj.c | 23 ++- src/mesa/main/texobj.h | 4 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 126b523..82d52c5 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@

[Mesa-dev] [PATCH 3/3] main: Checking for cube completeness in TextureSubImage.

2014-12-31 Thread Laura Ekstrand
This is part of a potential solution to Khronos Bug 13223. Cube completeness is a concept from glGenerateMipmap, but it seems reasonable to check for it in TextureSubImage when target=GL_TEXTURE_CUBE_MAP. --- src/mesa/main/teximage.c | 42 +- 1 file

[Mesa-dev] [PATCH 0/3] ARB_direct_state_access: Checking for cube completeness.

2014-12-31 Thread Laura Ekstrand
When trying to address Anuj Phogat's comment on Patch 40/41 of my direct state access textures patch series, I realized that the concept of cube completeness only checks the base level of a cube map for consistency among formats and sizes. This series checks an arbitrary level of a cube map for

[Mesa-dev] [PATCH 2/3] main: Checking for cube completeness in GetTextureImage.

2014-12-31 Thread Laura Ekstrand
This is part of a potential solution to Khronos Bug 13223. Cube completeness is a concept from glGenerateMipmap, but it seems reasonable to check for it in GetTextureImage when the target is GL_TEXTURE_CUBE_MAP. --- src/mesa/main/texgetimage.c | 41 + 1

Re: [Mesa-dev] [PATCH 40/41] main: Checking for cube completeness in GetTextureImage.

2014-12-31 Thread Anuj Phogat
On Wed, Dec 31, 2014 at 4:42 PM, Laura Ekstrand la...@jlekstrand.net wrote: I began adding to my comment as you suggested, but found out that cube completeness only applies to the base level of a cube map. So I had to modify this patch to check for cube completeness of an arbitrary level. I

Re: [Mesa-dev] [PATCH 1/3] main: Added _mesa_cube_level_complete to check for the completeness of an arbitrary cube map level.

2014-12-31 Thread Anuj Phogat
On Wed, Dec 31, 2014 at 5:26 PM, Laura Ekstrand la...@jlekstrand.net wrote: --- src/mesa/main/texobj.c | 23 ++- src/mesa/main/texobj.h | 4 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index

Re: [Mesa-dev] [PATCH 11/41] main: Added entry points for glTextureStorage*D.

2014-12-31 Thread Anuj Phogat
On Tue, Dec 16, 2014 at 10:59 AM, Laura Ekstrand la...@jlekstrand.net wrote: This happens almost everywhere. I prefer to call _mesa_error(ctx, glTex%sStorage rather than _mesa_error(ctx, %s because it's more obvious when reading the code which API function you're in (texture storage

[Mesa-dev] [Bug 87926] [softpipe] SIGSEGV draw/draw_pt_fetch_shade_pipeline.c:161

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87926 Bug ID: 87926 Summary: [softpipe] SIGSEGV draw/draw_pt_fetch_shade_pipeline.c:161 Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

[Mesa-dev] [Bug 79471] [llvmpipe] [softpipe] state_tracker/st_glsl_to_tgsi.cpp:4495:translate_src: Assertion `src_reg-file != PROGRAM_TEMPORARY' failed.

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79471 Vinson Lee v...@freedesktop.org changed: What|Removed |Added CC||bri...@vmware.com,

[Mesa-dev] [Bug 52465] lp_test_conv failure with llvm-3.0

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52465 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH 2/2] i965: Copy shader-shadow_samplers to prog-ShadowSamplers.

2014-12-31 Thread Kenneth Graunke
ir_to_mesa does this - apparently we just forgot or something. Without this, we'll guess the wrong texture swizzle (XYZW for color instead of XXX1 for depth) when doing precompiles. This cuts 26 shader recompiles in a time demo of Counter Strike: Global Offensive (58 - 32) on Sandybridge.

[Mesa-dev] [PATCH 1/2] i965: Make the precompile ignore DEPTH_TEXTURE_MODE on Gen7.5+.

2014-12-31 Thread Kenneth Graunke
Gen7.5+ platforms that support the Shader Channel Select feature leave key-tex.swizzles[i] as SWIZZLE_NOOP except when GL_DEPTH_TEXTURE_MODE is GL_ALPHA (which is really uncommon). So, the precompile should leave them as SWIZZLE_NOOP (aka SWIZZLE_XYZW) as well. We didn't notice this because

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon on Source games

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #3 from Kenneth Graunke kenn...@whitecape.org --- I discovered a bug in the i965 driver: the precompile was guessing the texture swizzle incorrectly. These two patches should cut around 40% of the recompiles:

Re: [Mesa-dev] [PATCH 2/2] i965: Copy shader-shadow_samplers to prog-ShadowSamplers.

2014-12-31 Thread Matt Turner
On Wed, Dec 31, 2014 at 8:04 PM, Kenneth Graunke kenn...@whitecape.org wrote: ir_to_mesa does this - apparently we just forgot or something. Without this, we'll guess the wrong texture swizzle (XYZW for color instead of XXX1 for depth) when doing precompiles. This cuts 26 shader recompiles

Re: [Mesa-dev] [PATCH 1/2] i965: Make the precompile ignore DEPTH_TEXTURE_MODE on Gen7.5+.

2014-12-31 Thread Chris Forbes
Nice! Both are Reviewed-by: Chris Forbes chr...@ijw.co.nz On Jan 1, 2015 5:04 PM, Kenneth Graunke kenn...@whitecape.org wrote: Gen7.5+ platforms that support the Shader Channel Select feature leave key-tex.swizzles[i] as SWIZZLE_NOOP except when GL_DEPTH_TEXTURE_MODE is GL_ALPHA (which is

[Mesa-dev] [PATCH] nv50/ir: fold MAD when one of the multiplicands is const

2014-12-31 Thread Ilia Mirkin
Fold MAD dst, src0, immed, src2 (or src0/immed swapped) when - immed = 0 - MOV dst, src2 - immed = +/- 1 - ADD dst, src0, src2 These types of MAD pattersn were observed in some st/nine shaders. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- Haven't tested this enough to push yet, but

[Mesa-dev] [PATCH 2/2] i965: Support MESA_FORMAT_R8G8B8X8_SRGB.

2014-12-31 Thread Kenneth Graunke
Valve games use GL_SRGB8 textures. Instead of supporting that properly, we fell back to MESA_FORMAT_R8G8B8A8_SRGB (with an alpha channel), which meant that we had to use texture swizzling to override the alpha to 1.0 when sampling. This meant shader recompiles on Gen 7.5 platforms. By

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon on Source games

2014-12-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #4 from Kenneth Graunke kenn...@whitecape.org --- And it turns out we can eliminate the rest of them pretty easily too: http://lists.freedesktop.org/archives/mesa-dev/2014-December/073490.html