Re: [Mesa-dev] [PATCH 10/10] glsl: fail when a shader's input var has not an equivalent out var in previous

2015-03-27 Thread Ben Widawsky
On Mon, Dec 01, 2014 at 02:04:50PM +0100, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com GLSL ES 3.00 spec, 4.3.10 (Linking of Vertex Outputs and Fragment Inputs), page 45 says the following: The type of vertex outputs and fragment input with the same name

Re: [Mesa-dev] State of Geometry shader instancing on radeonsi

2015-03-27 Thread Alexandre Demers
Good to have your input. I'll work on it. Marek Olšák mar...@gmail.com wrote: I think I didn't tell you how I'd like the viewport and scissor states to be implemented. Here it is: 1 r600_atom for all 16 viewports 1 r600_atom for all 16 scissors Each atom should have a bitmask saying which

Re: [Mesa-dev] [PATCH 10/10] glsl: fail when a shader's input var has not an equivalent out var in previous

2015-03-27 Thread Timothy Arceri
On Thu, 2015-03-26 at 23:10 -0700, Ben Widawsky wrote: On Mon, Dec 01, 2014 at 02:04:50PM +0100, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com GLSL ES 3.00 spec, 4.3.10 (Linking of Vertex Outputs and Fragment Inputs), page 45 says the following: The

Re: [Mesa-dev] [PATCH 10/10] glsl: fail when a shader's input var has not an equivalent out var in previous

2015-03-27 Thread Samuel Iglesias Gonsálvez
On Thursday 26 March 2015 23:10:53 Ben Widawsky wrote: On Mon, Dec 01, 2014 at 02:04:50PM +0100, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com GLSL ES 3.00 spec, 4.3.10 (Linking of Vertex Outputs and Fragment Inputs), page 45 says the following: The

Re: [Mesa-dev] [PATCH] docs: note that classic osmesa/libEGL no longer builds with scons

2015-03-27 Thread Jose Fonseca
On 25/03/15 20:12, Emil Velikov wrote: Plus nuke final note of osmesa from README.WIN32 Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- docs/README.WIN32 | 4 docs/relnotes/10.6.0.html | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 14/16] main: Added entry point for glCreateRenderbuffers

2015-03-27 Thread Martin Peres
On 27/03/15 07:13, Ilia Mirkin wrote: On Fri, Mar 27, 2015 at 1:06 AM, Vinson Lee v...@freedesktop.org wrote: On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres martin.pe...@linux.intel.com wrote: @@ -1404,14 +1405,36 @@ _mesa_GenRenderbuffers(GLsizei n, GLuint *renderbuffers) for (i = 0; i

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Jordan Justen
On 2015-03-26 20:52:33, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The CSE algorithm will continuously allocate new ae_entry objects. As each new basic block is exited, all of the previously allocated objects are dumped. Instead, put them in a free list and re-use them

[Mesa-dev] [PATCH] gbm: Add GBM_BO_USE_LINEAR flag

2015-03-27 Thread Michel Dänzer
From: Flora Cui flora@amd.com Signed-off-by: Flora Cui flora@amd.com Reviewed-by: Jammy Zhou jammy.z...@amd.com Reviewed-by: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gbm/backends/dri/gbm_dri.c | 2 ++ src/gbm/main/gbm.h

Re: [Mesa-dev] [PATCH 8/8] i965/fs: Relax type check in cmod propagation.

2015-03-27 Thread Jason Ekstrand
On Mar 26, 2015 6:58 PM, Matt Turner matts...@gmail.com wrote: On Thu, Mar 26, 2015 at 1:35 PM, Jason Ekstrand ja...@jlekstrand.net wrote: What about other datatypes such as D or UW? Perhaps we should have some sort of is_integer function and just do is_integer(a) != is_integer(b)? I

Re: [Mesa-dev] [PATCH 10/10] glsl: fail when a shader's input var has not an equivalent out var in previous

2015-03-27 Thread Timothy Arceri
On Fri, 2015-03-27 at 18:07 +1100, Timothy Arceri wrote: On Thu, 2015-03-26 at 23:10 -0700, Ben Widawsky wrote: On Mon, Dec 01, 2014 at 02:04:50PM +0100, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com GLSL ES 3.00 spec, 4.3.10 (Linking of Vertex Outputs

[Mesa-dev] [PATCH] glsl: mark uniform and input interface blocks as read only

2015-03-27 Thread Timothy Arceri
--- Piglit tests: http://lists.freedesktop.org/archives/piglit/2015-March/015369.html src/glsl/ast_to_hir.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index d9ce6c9..49bddc4 100644 --- a/src/glsl/ast_to_hir.cpp +++

Re: [Mesa-dev] New stable-branch 10.5 candidate pushed

2015-03-27 Thread Emil Velikov
Hi Bernd, On 26 March 2015 at 22:44, Bernd Kuhls bernd.ku...@t-online.de wrote: Emil Velikov emil.l.veli...@gmail.com wrote in news:55136BE1.6090001 @gmail.com: and no longer requires python/mako in order to build. Hi, I am a bit confused, quoting the commit

Re: [Mesa-dev] [PATCH] radeonsi: Cache LLVMTargetMachineRef in context instead of in screen

2015-03-27 Thread Tom Stellard
On Fri, Mar 27, 2015 at 10:05:06AM +0900, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com Fixes a crash in genymotion with several threads compiling shaders concurrently. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89746 Cc: 10.5

Re: [Mesa-dev] [PATCH] gbm: Add GBM_BO_USE_LINEAR flag

2015-03-27 Thread Alex Deucher
On Fri, Mar 27, 2015 at 4:58 AM, Michel Dänzer mic...@daenzer.net wrote: From: Flora Cui flora@amd.com Signed-off-by: Flora Cui flora@amd.com Reviewed-by: Jammy Zhou jammy.z...@amd.com Reviewed-by: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer

Re: [Mesa-dev] [PATCH 14/16] main: Added entry point for glCreateRenderbuffers

2015-03-27 Thread Ilia Mirkin
On Fri, Mar 27, 2015 at 4:19 AM, Martin Peres martin.pe...@linux.intel.com wrote: On 27/03/15 07:13, Ilia Mirkin wrote: On Fri, Mar 27, 2015 at 1:06 AM, Vinson Lee v...@freedesktop.org wrote: On Mon, Feb 16, 2015 at 6:14 AM, Martin Peres martin.pe...@linux.intel.com wrote: @@ -1404,14

[Mesa-dev] [PATCH] llvmpipe: simplify address calculation for 4x4 blocks

2015-03-27 Thread sroland
From: Roland Scheidegger srol...@vmware.com These functions looked quite complicated, even though what they actually did was trivial (ever since we dropped swizzled rendering). Also drop lookup of format block per bytes done for each block, and do it once per scene instead. This improves

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: On Thursday, March 26, 2015 08:52:33 PM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The CSE algorithm will continuously allocate new ae_entry objects. As each new basic block is exited, all of the previously allocated

Re: [Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-03-27 Thread Ilia Mirkin
What's the use-case for applying a different version to a shader with an explicit #version? On Fri, Mar 27, 2015 at 2:13 PM, Brian Paul bri...@vmware.com wrote: Previously, the ctx-Const.ForceGLSLVersion setting only worked if the shader lacked a #version directive. Now, the ForceGLSLVersion

Re: [Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-03-27 Thread Brian Paul
The Geeks3d GpuTest GiMark test for Windows has several shaders with #version 330 that don't actually use any 3.30 features. Other shaders in the test use #version 130. Furthermore, when a context is created, only a 3.0 context is requested. We don't support GL 3.0 w/ 3.30 shaders but if

Re: [Mesa-dev] [PATCH v2 15/15] nvc0: all queries use an unsigned 64-bits integer by default

2015-03-27 Thread Ilia Mirkin
Patches 11-15 are all Reviewed-by: Ilia Mirkin imir...@alum.mit.edu but please fix up patch #13 with that small bit I mentioned. On Sun, Mar 22, 2015 at 11:35 AM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com ---

Re: [Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-03-27 Thread Ilia Mirkin
On Fri, Mar 27, 2015 at 2:44 PM, Brian Paul bri...@vmware.com wrote: The Geeks3d GpuTest GiMark test for Windows has several shaders with #version 330 that don't actually use any 3.30 features. Other shaders in the test use #version 130. Furthermore, when a context is created, only a 3.0

Re: [Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-03-27 Thread Brian Paul
On 03/27/2015 12:49 PM, Ilia Mirkin wrote: On Fri, Mar 27, 2015 at 2:44 PM, Brian Paul bri...@vmware.com wrote: The Geeks3d GpuTest GiMark test for Windows has several shaders with #version 330 that don't actually use any 3.30 features. Other shaders in the test use #version 130.

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Kenneth Graunke
On Thursday, March 26, 2015 08:52:33 PM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The CSE algorithm will continuously allocate new ae_entry objects. As each new basic block is exited, all of the previously allocated objects are dumped. Instead, put them in a free list

Re: [Mesa-dev] [PATCH v2 13/15] nvc0: expose more driver-specific query groups

2015-03-27 Thread Ilia Mirkin
It's really confusing to have MP_COUNTER_GROUP being 0 or 1 depending on the setting of DEBUG. Please make them the same. On Sun, Mar 22, 2015 at 11:35 AM, Samuel Pitoiset samuel.pitoi...@gmail.com wrote: This patch exposes Driver statistics and MP counters groups. Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 5/8] nir: Add addition/multiplication identities of exp/log.

2015-03-27 Thread Eric Anholt
Matt Turner matts...@gmail.com writes: instructions in affected programs: 2858 - 2808 (-1.75%) helped:12 --- src/glsl/nir/nir_opt_algebraic.py | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/nir/nir_opt_algebraic.py

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Thomas Helland
This looks good to me, and matches a solution I found online the other day for reducing memory allocation overhead. Reviewed-by: Thomas Helland thomashellan...@gmail.com Did you happen to profile this? Did you identify other places that could need a similar treatment? I'm about to do a last

[Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-03-27 Thread Brian Paul
Previously, the ctx-Const.ForceGLSLVersion setting only worked if the shader lacked a #version directive. Now, the ForceGLSLVersion setting will override the #version directive too. This change should be safe since it should be rare to have an app that has a mix of shader versions and we only

Re: [Mesa-dev] [PATCH] glsl: mark uniform and input interface blocks as read only

2015-03-27 Thread Mark Janes
Reviewed-by: Mark Janes mark.a.ja...@intel.com Timothy Arceri t_arc...@yahoo.com.au writes: --- Piglit tests: http://lists.freedesktop.org/archives/piglit/2015-March/015369.html src/glsl/ast_to_hir.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 2/3] nir: Convert to using pipeline.h.

2015-03-27 Thread Eric Anholt
One file that actually grubs through gl_shader_programs is left. --- src/glsl/nir/nir_lower_system_values.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_lower_system_values.c b/src/glsl/nir/nir_lower_system_values.c index a6eec65..75db08d 100644 ---

[Mesa-dev] [PATCH 3/3] gallium: Add tgsi_to_nir to get a nir_shader for a TGSI shader.

2015-03-27 Thread Eric Anholt
This will be used by the VC4 driver for doing device-independent optimization, and hopefully eventually replacing its whole IR. It also may be useful to other drivers for the same reason. v2: Add all of the instructions I was relying on tgsi_lowering to remove, and more. v3: Rebase on SSA

[Mesa-dev] [PATCH 1/3] mesa: Make a shared header for 3D pipeline enum / #defines.

2015-03-27 Thread Eric Anholt
NIR uses these enums/#defines in nir_variables and associated intrinsics, but I want to be able to use them from TGSI-NIR and NIR-TGSI. Otherwise, we had to pull in all of mtypes.h. This doesn't cover all of the enums we might want from a shared compiler core (like varying slots or vert attribs),

Re: [Mesa-dev] [PATCH 1/3] mesa: Make a shared header for 3D pipeline enum / #defines.

2015-03-27 Thread Ilia Mirkin
On Fri, Mar 27, 2015 at 4:54 PM, Eric Anholt e...@anholt.net wrote: NIR uses these enums/#defines in nir_variables and associated intrinsics, but I want to be able to use them from TGSI-NIR and NIR-TGSI. Otherwise, we had to pull in all of mtypes.h. This doesn't cover all of the enums we

Re: [Mesa-dev] [PATCH] glsl: allow ForceGLSLVersion to override #version directives

2015-03-27 Thread Ilia Mirkin
On Fri, Mar 27, 2015 at 3:00 PM, Brian Paul bri...@vmware.com wrote: On 03/27/2015 12:49 PM, Ilia Mirkin wrote: On Fri, Mar 27, 2015 at 2:44 PM, Brian Paul bri...@vmware.com wrote: The Geeks3d GpuTest GiMark test for Windows has several shaders with #version 330 that don't actually use any

Re: [Mesa-dev] [PATCH 3/3] gallium: Add tgsi_to_nir to get a nir_shader for a TGSI shader.

2015-03-27 Thread Ilia Mirkin
On Fri, Mar 27, 2015 at 4:54 PM, Eric Anholt e...@anholt.net wrote: diff --git a/src/gallium/auxiliary/Makefile.sources b/src/gallium/auxiliary/Makefile.sources index 09496fa..08e4e4c 100644 --- a/src/gallium/auxiliary/Makefile.sources +++ b/src/gallium/auxiliary/Makefile.sources @@ -69,6

Re: [Mesa-dev] [PATCH 1/3] mesa: Make a shared header for 3D pipeline enum / #defines.

2015-03-27 Thread Kenneth Graunke
On Friday, March 27, 2015 01:54:30 PM Eric Anholt wrote: NIR uses these enums/#defines in nir_variables and associated intrinsics, but I want to be able to use them from TGSI-NIR and NIR-TGSI. Otherwise, we had to pull in all of mtypes.h. This doesn't cover all of the enums we might want

Re: [Mesa-dev] [PATCH] llvmpipe: simplify address calculation for 4x4 blocks

2015-03-27 Thread Jose Fonseca
Reviewed-by: Jose Fonseca jfons...@vmware.com On 27/03/15 15:53, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com These functions looked quite complicated, even though what they actually did was trivial (ever since we dropped swizzled rendering). Also drop lookup of format

Re: [Mesa-dev] [PATCH 1/3] mesa: Make a shared header for 3D pipeline enum / #defines.

2015-03-27 Thread Kenneth Graunke
On Friday, March 27, 2015 04:57:45 PM Ilia Mirkin wrote: On Fri, Mar 27, 2015 at 4:54 PM, Eric Anholt e...@anholt.net wrote: [snip] +#ifndef PIPELINE_H +#define PIPELINE_H + +/** + * Bitflags for system values. + */ +#define SYSTEM_BIT_SAMPLE_ID

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Ian Romanick
On 03/27/2015 11:33 AM, Kenneth Graunke wrote: On Thursday, March 26, 2015 08:52:33 PM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com The CSE algorithm will continuously allocate new ae_entry objects. As each new basic block is exited, all of the previously allocated objects

Re: [Mesa-dev] [PATCH] glsl/cse: Maintain a list of free ae_entry objects

2015-03-27 Thread Ian Romanick
On 03/27/2015 11:56 AM, Thomas Helland wrote: This looks good to me, and matches a solution I found online the other day for reducing memory allocation overhead. Reviewed-by: Thomas Helland thomashellan...@gmail.com Did you happen to profile this? Did you identify other places that could

Re: [Mesa-dev] [PATCH 1/1] gallivm: Fix build since llvm r233411

2015-03-27 Thread Tom Stellard
On Fri, Mar 27, 2015 at 06:46:43PM -0400, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Reviewed-by: Tom Stellard thomas.stell...@amd.com --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 1 file changed, 4 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 3/3] gallium: Add tgsi_to_nir to get a nir_shader for a TGSI shader.

2015-03-27 Thread Kenneth Graunke
On Friday, March 27, 2015 01:54:32 PM Eric Anholt wrote: This will be used by the VC4 driver for doing device-independent optimization, and hopefully eventually replacing its whole IR. It also may be useful to other drivers for the same reason. v2: Add all of the instructions I was relying

[Mesa-dev] [PATCH 1/1] gallivm: Fix build since llvm r233411

2015-03-27 Thread Jan Vesely
Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp index bf6268b..d4d453d 100644 ---

Re: [Mesa-dev] [PATCH 5/8] nir: Add addition/multiplication identities of exp/log.

2015-03-27 Thread Matt Turner
On Fri, Mar 27, 2015 at 11:56 AM, Eric Anholt e...@anholt.net wrote: Matt Turner matts...@gmail.com writes: instructions in affected programs: 2858 - 2808 (-1.75%) helped:12 --- src/glsl/nir/nir_opt_algebraic.py | 8 1 file changed, 8

Re: [Mesa-dev] [PATCH 06/16] glsl: fix assignment of multiple scalar and vecs to matrices.

2015-03-27 Thread Ben Widawsky
On Thu, Dec 11, 2014 at 11:34:12PM +0100, Eduardo Lima Mitev wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com When a vec has more elements than row components in a matrix, the code could end up failing an assert inside assign_to_matrix_column(). This patch makes sure that when

[Mesa-dev] [PATCH] nir: Fix copy and pasted error message in nir_validate.

2015-03-27 Thread Kenneth Graunke
These are nir_cf_nodes, not ALU instructions. Also, use unreachable() to preempt said review feedback. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/nir/nir_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_validate.c

Re: [Mesa-dev] [PATCH] glsl: support unsigned increment in ir_loop controls

2015-03-27 Thread Ilia Mirkin
On Wed, Aug 6, 2014 at 10:46 AM, Ian Romanick i...@freedesktop.org wrote: On 07/30/2014 04:11 AM, Tapani Pälli wrote: Current version can create ir_expression where operands have different base type, patch adds support for unsigned type. Signed-off-by: Tapani Pälli tapani.pa...@intel.com

Re: [Mesa-dev] [PATCH 31/41] i965/fs: Use instruction execution sizes to set compression state

2015-03-27 Thread Ilia Mirkin
On Tue, Sep 23, 2014 at 2:14 PM, Matt Turner matts...@gmail.com wrote: On Sat, Sep 20, 2014 at 10:23 AM, Jason Ekstrand ja...@jlekstrand.net wrote: Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 23 ++- 1 file

[Mesa-dev] [PATCH 1/3] glsl: Factor out a get_mul_type() function.

2015-03-27 Thread Matt Turner
--- src/glsl/ast_to_hir.cpp | 62 - src/glsl/glsl_types.cpp | 67 + src/glsl/glsl_types.h | 6 + 3 files changed, 78 insertions(+), 57 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 2/3] glsl: Implement type inferencing of matrix types.

2015-03-27 Thread Matt Turner
--- src/glsl/ir.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index 54656f8..4b8ca9b 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -380,10 +380,12 @@ ir_expression::ir_expression(int op, ir_rvalue *op0, ir_rvalue

[Mesa-dev] [PATCH 3/3] glsl: Reassociate multiplication of mat*mat*vec.

2015-03-27 Thread Matt Turner
The typical case of mat4*mat4*vec4 is 80 scalar multiplications, but mat4*(mat4*vec4) is only 32. On HSW (with vec4 vertex shaders): instructions in affected programs: 4420 - 3194 (-27.74%) On BDW (with scalar vertex shaders): instructions in affected programs: 12756 - 6726 (-47.27%)

Re: [Mesa-dev] [PATCH] nir: Fix copy and pasted error message in nir_validate.

2015-03-27 Thread Ilia Mirkin
On Sat, Mar 28, 2015 at 12:23 AM, Kenneth Graunke kenn...@whitecape.org wrote: These are nir_cf_nodes, not ALU instructions. Also, use unreachable() to preempt said review feedback. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/nir/nir_validate.c | 2 +- 1 file changed,