On Fri, 2015-07-17 at 10:36 -0700, Anuj Phogat wrote:
Iago, Jason: Patches 2 and 5 in this series depend on patches 1 and 4
respectively, Since you guys reviewed 2 and 5, would you also like to
review 1, 4 and/or other patches in this series?
Thanks
-Anuj
Sure, I'll have a look at the
Make the assumption that there's a 1:1 TIC - TSC connection, and
increase min/max lod by the relevant texture's base level. Also if
there's no mipfilter, we have to enable it while forcing min/max lod to
the base level.
This fixes many, but not all, tex-miplevel-selection tests on G80.
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
This utility function is used in a later patch.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/main/readpix.c | 32 ++--
src/mesa/main/readpix.h | 4
On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote:
On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand ja...@jlekstrand.net wrote:
On Jun 16, 2015 11:15, Anuj Phogat anuj.pho...@gmail.com wrote:
Without this patch, piglit test fbo_integer_readpixels_sint_uint fails,
when
forced to use
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
This utility function is utilized in a later patch.
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
Cc: mesa-sta...@lists.freedesktop.org
---
Jenkins showed no piglit regressions with this series.
src/mesa/main/readpix.c | 14
On Tue, 2015-06-16 at 11:15 -0700, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat anuj.pho...@gmail.com
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/main/readpix.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
index
We only consider a vgrf defined by a given block if the block writes to it
unconditionally. So far we have been checking this by testing that the
instruction is not predicated, however, in the case of BRW_OPCODE_SEL,
the predication is used to select the value to write, not to decide if
the write
Iago Toral Quiroga ito...@igalia.com writes:
We only consider a vgrf defined by a given block if the block writes to it
unconditionally. So far we have been checking this by testing that the
instruction is not predicated, however, in the case of BRW_OPCODE_SEL,
the predication is used to
Hi,
On Thu, 2015-07-16 at 08:15 -0700, Jason Ekstrand wrote:
On Jul 15, 2015 11:20 PM, Iago Toral ito...@igalia.com wrote:
On Wed, 2015-07-15 at 11:02 -0700, Connor Abbott wrote:
On Wed, Jul 15, 2015 at 7:49 AM, Iago Toral ito...@igalia.com
wrote:
Hi,
when we sent the
Reviewed-by: Samuel Pitoiset samuel.pitoi...@gmail.com
On 07/20/2015 09:26 AM, Ilia Mirkin wrote:
Make the assumption that there's a 1:1 TIC - TSC connection, and
increase min/max lod by the relevant texture's base level. Also if
there's no mipfilter, we have to enable it while forcing min/max
This seems rather silly and would lead to memory corruption if the
size of a VGRF was allowed to be zero.
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
Francisco Jerez curroje...@riseup.net writes:
This seems rather silly and would lead to memory corruption if the
size of a VGRF was allowed to be zero.
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
On 18/07/15 16:02, samuel.pitoiset wrote:
On 17/07/2015 23:08, Ilia Mirkin wrote:
On Fri, Jul 17, 2015 at 5:02 PM, Emil Velikov
emil.l.veli...@gmail.com wrote:
On 16/07/15 22:39, Samuel Pitoiset wrote:
Signed-off-by: Samuel Pitoiset samuel.pitoi...@gmail.com
---
This fixes crashes in some piglit tests on radeonsi that use the draw
module, and llvmpipe is likely completely broken without this on LLVM
3.8.
This is just a temporary solution. The correct solution will require
creating a TargetMachine during gallivm initialization and pulling the
DataLayout
On 07/09/2015 01:12 PM, Emil Velikov wrote:
On 9 July 2015 at 18:50, Ian Romanick i...@freedesktop.org wrote:
On 07/08/2015 10:07 AM, Emil Velikov wrote:
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
include/GL/internal/dri_interface.h | 11 ---
1 file changed, 11
On 07/17/2015 02:14 PM, Emil Velikov wrote:
On 17 July 2015 at 20:22, Brian Paul bri...@vmware.com wrote:
Can you elaborate in the commit message why this is being done or why the
HAVE_SYS_TYPES_H definition is not needed? That saves me time having to
research the issue myself.
I'm not sure
https://bugs.freedesktop.org/show_bug.cgi?id=83631
--- Comment #8 from Emil Velikov emil.l.veli...@gmail.com ---
With all due respect guys, should one take a closer look and remove the need
for GL_GLEXT_LEGACY and its friends GL_GLEXT_PROTOTYPES/GLX_GLXEXT_PROTOTYPES.
Iirc those were added as a
On Sat, Jul 18, 2015 at 1:24 AM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Fri, Jul 17, 2015 at 05:12:54PM -0700, Anuj Phogat wrote:
On Mon, Jul 6, 2015 at 3:33 AM, Chris Wilson ch...@chris-wilson.co.uk
wrote:
+ do {
+ /* The pitch given to the GPU must be DWORD aligned, and
On Mon, Jul 20, 2015 at 03:35:26PM +0200, Iago Toral wrote:
Hi,
On Thu, 2015-07-16 at 08:15 -0700, Jason Ekstrand wrote:
On Jul 15, 2015 11:20 PM, Iago Toral ito...@igalia.com wrote:
On Wed, 2015-07-15 at 11:02 -0700, Connor Abbott wrote:
On Wed, Jul 15, 2015 at 7:49 AM, Iago
https://bugs.freedesktop.org/show_bug.cgi?id=83631
Ian Romanick i...@freedesktop.org changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment
On 07/17/2015 05:48 PM, Brian Paul wrote:
Skip memcpy() calls, etc. if the matrix is already the identity. Return
true/false to indicate if we're really changing the matrix or not.
---
src/mesa/math/m_matrix.c | 23 +++
src/mesa/math/m_matrix.h | 2 +-
2 files changed,
On 07/06/2015 03:33 AM, Chris Wilson wrote:
Since we can distinguish when mapping between READ and WRITE, we can
pass along the map mode to avoid stalls and flushes where possible.
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 28
All LLVM API calls that require an ostream object have been removed from
the disassemble() function, so we don't need to use this class to wrap
_debug_printf() we can just call this function directly.
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 27 +-
1 file
Its only use is to implement a custom version of LLVMDumpValue
on some Windows and embedded platforms.
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
---
src/mesa/swrast/s_texfilter.c | 56 +--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/src/mesa/swrast/s_texfilter.c b/src/mesa/swrast/s_texfilter.c
index abc1727..cd6395f 100644
--- a/src/mesa/swrast/s_texfilter.c
+++
On Mon, Jul 20, 2015 at 11:28 AM, Brian Paul bri...@vmware.com wrote:
---
src/mesa/swrast/s_texfilter.c | 56
+--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/src/mesa/swrast/s_texfilter.c b/src/mesa/swrast/s_texfilter.c
index
Hi Brian,
You marked off ARB_copy_image (and ARB_clear_texture) as in-progress
by VMware some months ago -- has there been any movement on that? It
appears that Bioshock Infinite requires ARB_copy_image so might be
nice to get that added in.
The complication in implementing ARB_copy_image was
Brian Paul bri...@vmware.com writes:
---
src/mesa/swrast/s_texfilter.c | 56
+--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/src/mesa/swrast/s_texfilter.c b/src/mesa/swrast/s_texfilter.c
index abc1727..cd6395f 100644
---
On Mon, Jul 20, 2015 at 5:10 AM, Iago Toral ito...@igalia.com wrote:
On Fri, 2015-06-19 at 13:40 -0700, Anuj Phogat wrote:
On Tue, Jun 16, 2015 at 9:21 PM, Jason Ekstrand ja...@jlekstrand.net wrote:
On Jun 16, 2015 11:15, Anuj Phogat anuj.pho...@gmail.com wrote:
Without this patch,
On Fri, Jul 17, 2015 at 5:48 PM, Brian Paul bri...@vmware.com wrote:
Google Earth often calls glLoadMatrixf() with an identity matrix instead
of glLoadIdentity() to set the modelview and texture matrices. In many
cases, the matrix is already the identity so the calls are redundant.
By being
Patches 1, 2, and 3 are
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
The other patches look correct too, but the whole series is
optimizations, so do you have any before / after performance data?
On 07/17/2015 05:48 PM, Brian Paul wrote:
If the new mode matches the current mode, there
Brian Paul bri...@vmware.com writes:
---
src/mesa/main/light.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/light.c b/src/mesa/main/light.c
index 4021dbe..f215c93 100644
--- a/src/mesa/main/light.c
+++ b/src/mesa/main/light.c
@@ -44,14 +44,14 @@
This will be used to pass image meta-data to the shader when we cannot
use typed surface reads and writes. All entries except surface_idx
and size are otherwise unused and will get eliminated by the uniform
packing pass. size will be used for bounds checking with some image
formats and will be
On 18 July 2015 at 23:13, Jonathan Gray j...@jsg.id.au wrote:
$(RM) is set to 'rm -f' by GNU make, this is not true of other versions
of make and RM is not one of the macros required by POSIX.
Slightly unfortunate but I think we can live with it. Would like to
see if Matt/other have objections
Looks OK to me. Thanks for doing this.
Reviewed-by: Brian Paul bri...@vmware.com
On 07/18/2015 02:36 AM, Kenneth Graunke wrote:
Generated by sed; no manual changes.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
We talked about doing this back in 2013, but the patches never
quite
v2: Add CS support. Move the image_params array back to
brw_stage_prog_data.
---
src/mesa/drivers/dri/i965/brw_context.h | 10 +++-
src/mesa/drivers/dri/i965/brw_gs_surface_state.c | 25
src/mesa/drivers/dri/i965/brw_state.h| 4 ++
v2: Add CS support.
---
src/mesa/drivers/dri/i965/brw_cs.cpp | 3 ++-
src/mesa/drivers/dri/i965/brw_gs.c | 1 +
src/mesa/drivers/dri/i965/brw_vs.c | 3 ++-
src/mesa/drivers/dri/i965/brw_wm.c | 3 ++-
4 files changed, 7 insertions(+), 3 deletions(-)
diff --git
Hi,
On 20 July 2015 at 17:40, Emil Velikov emil.l.veli...@gmail.com wrote:
On 18 July 2015 at 23:13, Jonathan Gray j...@jsg.id.au wrote:
$(RM) is set to 'rm -f' by GNU make, this is not true of other versions
of make and RM is not one of the macros required by POSIX.
Slightly unfortunate but
On Monday, July 20, 2015 03:14:14 PM Iago Toral Quiroga wrote:
We only consider a vgrf defined by a given block if the block writes to it
unconditionally. So far we have been checking this by testing that the
instruction is not predicated, however, in the case of BRW_OPCODE_SEL,
the
2015-07-10 19:48 GMT+02:00 Emil Velikov emil.l.veli...@gmail.com:
... and update the documentation to reflect reality.
null and gdi are gone, and surfaceless is a recent addition.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
configure.ac | 3 ---
docs/egl.html | 6 +++---
2
On Mon, Jul 20, 2015 at 3:53 PM, Brian Paul bri...@vmware.com wrote:
On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
Hi Brian,
You marked off ARB_copy_image (and ARB_clear_texture) as in-progress
by VMware some months ago
This looks a lot better.
The patch is:
Reviewed-by: Thomas Helland thomashellan...@gmail.com
2015-07-10 19:49 GMT+02:00 Emil Velikov emil.l.veli...@gmail.com:
Move the code around rather than having it scattered. No functional
change.
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
[resend without the patch to not anger the mailing list]
On Mon, Jul 20, 2015 at 5:25 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
In many places you end up changing comments where I think the full
boolean word makes more sense. e.g.
- /* Deal with AND 1.0 here since nv50 can't fold into
On 07/20/2015 12:27 PM, Ian Romanick wrote:
Patches 1, 2, and 3 are
Reviewed-by: Ian Romanick ian.d.roman...@intel.com
The other patches look correct too, but the whole series is
optimizations, so do you have any before / after performance data?
No, I don't. I happened across these while
On 20/07/15 18:35, Tom Stellard wrote:
All LLVM API calls that require an ostream object have been removed from
the disassemble() function, so we don't need to use this class to wrap
_debug_printf() we can just call this function directly.
---
src/gallium/auxiliary/gallivm/lp_bld_debug.cpp |
On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
Hi Brian,
You marked off ARB_copy_image (and ARB_clear_texture) as in-progress
by VMware some months ago -- has there been any movement on that? It
appears that Bioshock Infinite requires ARB_copy_image so might be
nice
Am 20.07.2015 um 19:35 schrieb Tom Stellard:
This fixes crashes in some piglit tests on radeonsi that use the draw
module, and llvmpipe is likely completely broken without this on LLVM
3.8.
Yes, see https://llvm.org/bugs/show_bug.cgi?id=24172
This is just a temporary solution. The correct
Theoretically resource_copy_region should be the right function for
that. Both ARB_copy_image and d3d10 ResourceCopyRegion define this as
essentially the equivalent of memcpy.
I guess the difficulty is that GL's view classes are a bit different
compared to d3d10 typeless groups - d3d10 doesn't
On Fri 17 Jul 2015, Emil Velikov wrote:
On 17 July 2015 at 19:11, Ilia Mirkin imir...@alum.mit.edu wrote:
On Fri, Jul 17, 2015 at 2:11 PM, Eric Anholt e...@anholt.net wrote:
Matt Turner matts...@gmail.com writes:
On Fri, Jul 17, 2015 at 10:17 AM, Emil Velikov emil.l.veli...@gmail.com
On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
Hi Brian,
You marked off ARB_copy_image (and ARB_clear_texture) as in-progress
by VMware some months ago -- has there been any movement on that? It
appears that Bioshock Infinite
https://bugs.freedesktop.org/show_bug.cgi?id=91387
--- Comment #1 from Brian Paul bri...@vmware.com ---
Can you debug this a bit to see where this is happening and what the texture
target is?
I don't see how this would directly lead to a segfault in Mesa. After the
error message we select the
On Thu, Jul 9, 2015 at 9:17 AM, Dave Airlie airl...@gmail.com wrote:
From: Dave Airlie airl...@redhat.com
This fleshes out the ARB_program_query support for the
APIs that ARB_shader_subroutine introduces, leaving
some TODOs for later addition.
Signed-off-by: Dave Airlie airl...@redhat.com
If the extension is core only, we can rip out the checks, but the
checks that test ctx-API == API_OPEGL_CORE should stay (if they are
missing, they should be added).
Marek
On Thu, Jul 9, 2015 at 3:27 PM, Roland Scheidegger srol...@vmware.com wrote:
Should expose that only if hw has glsl 130
Hi Emil,
I looked at the whole series, but didn't really feel qualified
to review the whole bunch. I've sent reviews on the patches
I felt I had a good take on. If you don't get anyone else to
review the remainder then shout out and I'll give it a shot.
- Thomas
2015-07-17 22:57 GMT+02:00 Emil
Am 21.07.2015 um 02:10 schrieb Ilia Mirkin:
On Mon, Jul 20, 2015 at 7:53 PM, Roland Scheidegger srol...@vmware.com
wrote:
Am 20.07.2015 um 22:46 schrieb Ilia Mirkin:
On Mon, Jul 20, 2015 at 3:53 PM, Brian Paul bri...@vmware.com wrote:
On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
On Mon, Jul
This patch is:
Reviewed-by: Thomas Helland thomashellan...@gmail.com
2015-07-10 19:49 GMT+02:00 Emil Velikov emil.l.veli...@gmail.com:
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
src/egl/drivers/dri2/platform_wayland.c | 26 +-
1 file changed, 13
Generated by running:
git grep -l INLINE src/gallium/ | xargs sed -i 's/\bINLINE\b/inline/g'
git grep -l INLINE src/mesa/state_tracker/ | xargs sed -i
's/\bINLINE\b/inline/g'
git checkout src/gallium/state_trackers/clover/Doxyfile
and manual edits to
src/gallium/include/pipe/p_compiler.h
On Thu, Jul 9, 2015 at 9:17 AM, Dave Airlie airl...@gmail.com wrote:
From: Dave Airlie airl...@redhat.com
This adds linker support for subroutine uniforms, they
have some subtle differences from real uniforms, we also hide
them and they are given internal uniform names.
This also adds the
On Tue, Jul 14, 2015 at 3:08 PM, Thomas Helland
thomashellan...@gmail.com wrote:
The deadline for GSoC is aproaching a bit faster than I'm
comfortable with, so I need to get this out on the list
for some review-action. It's not yet complete, but I think
it's getting there. At least it should
Am 20.07.2015 um 22:46 schrieb Ilia Mirkin:
On Mon, Jul 20, 2015 at 3:53 PM, Brian Paul bri...@vmware.com wrote:
On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin imir...@alum.mit.edu wrote:
Hi Brian,
You marked off ARB_copy_image (and
On Mon, Jul 20, 2015 at 7:53 PM, Roland Scheidegger srol...@vmware.com wrote:
Am 20.07.2015 um 22:46 schrieb Ilia Mirkin:
On Mon, Jul 20, 2015 at 3:53 PM, Brian Paul bri...@vmware.com wrote:
On 07/20/2015 01:19 PM, Ilia Mirkin wrote:
On Mon, Jul 20, 2015 at 2:44 PM, Ilia Mirkin
https://bugs.freedesktop.org/show_bug.cgi?id=91254
--- Comment #7 from Jordan Justen jljus...@gmail.com ---
(In reply to Tomasz C. from comment #0)
* config and/or log files etc.
GLX Renderer: Mesa DRI Intel Ironlake Mobile GLX Version: 2.1 Mesa 10.6.0
The problem is on Intel Core i5 M 450 -
Match the attributes currently checked in configure.ac.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
scons/gallium.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/scons/gallium.py b/scons/gallium.py
index 51b84d7..af30c09 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@
On Tue, Jul 14, 2015 at 11:45 AM, Eric Anholt e...@anholt.net wrote:
These are really useful hints to the compiler in the absence of link-time
optimization, and I'm going to use them in VC4.
I've made the const attribute be ATTRIBUTE_CONST unlike other function
attributes, because we have
On 21 July 2015 at 08:50, Marek Olšák mar...@gmail.com wrote:
If the extension is core only, we can rip out the checks, but the
checks that test ctx-API == API_OPEGL_CORE should stay (if they are
missing, they should be added).
I've reconsidered this, and I'm sticking with my original plan,
You're adding this extension as core-only, so the functions should
only be accessible in core contexts. I believe that Ian added some
magical way to get the dispatch logic to handle this.
On Tue, Jul 21, 2015 at 1:19 AM, Dave Airlie airl...@gmail.com wrote:
From: Chris Forbes chr...@ijw.co.nz
On Tue, Jul 21, 2015 at 1:19 AM, Dave Airlie airl...@gmail.com wrote:
From: Dave Airlie airl...@redhat.com
This handles converting the shader stages to the internal
prefix along with the program resource interfaces.
Reviewed-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by: Dave Airlie
I could be missing it, but does anything restrict the availability of
this define to core contexts? I believe you have comparable issues
elsewhere in the change (where you only look at the extension being
enabled vs also looking at the API).
On Tue, Jul 21, 2015 at 1:19 AM, Dave Airlie
On Tue, Jul 21, 2015 at 1:19 AM, Dave Airlie airl...@gmail.com wrote:
@@ -366,18 +411,25 @@ _mesa_GetProgramResourceLocation(GLuint program, GLenum
programInterface,
case GL_PROGRAM_OUTPUT:
break;
+ case GL_VERTEX_SUBROUTINE_UNIFORM:
+ case GL_FRAGMENT_SUBROUTINE_UNIFORM:
+
Silence a release build warning.
st_glsl_to_tgsi.cpp: In function 'pipe_error st_translate_program(gl_context*,
uint, ureg_program*, glsl_to_tgsi_visitor*, const gl_program*, GLuint, const
GLuint*, const GLuint*, const ubyte*, const ubyte*, const GLuint*, const
GLuint*, GLuint, const GLuint*,
From: Dave Airlie airl...@redhat.com
This handles converting the shader stages to the internal
prefix along with the program resource interfaces.
Reviewed-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/main/shaderobj.h | 84
From: Dave Airlie airl...@redhat.com
This stops dead code from removing subroutines types,
we need these for the queries to work properly.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/glsl/opt_dead_code.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git
From: Chris Forbes chr...@ijw.co.nz
v2: [airlied]: merge version check update.
Reviewed-by: Tapani Pälli tapani.pa...@intel.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
Signed-off-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by: Dave Airlie airl...@redhat.com
---
From: Dave Airlie airl...@redhat.com
This adds linker support for subroutine uniforms, they
have some subtle differences from real uniforms, we also hide
them and they are given internal uniform names.
This also adds the subroutine locations and subroutine uniforms
to the program resource
From: Dave Airlie airl...@redhat.com
This lowers the enhanced ir_call using the lookaside table
of subroutines into an if ladder. This initially was done
at the AST level but it caused some ordering issues so a separate
pass was required.
v2: clone return value derefs.
v2.1: update for
From: Dave Airlie airl...@redhat.com
This adds a ir_variable which contains the subroutine uniform
and an array rvalue for the deref of that uniform, these
are stored in the ir_call and lowered later.
Reviewed-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by: Dave Airlie airl...@redhat.com
---
From: Dave Airlie airl...@redhat.com
This is the guts of the GLSL parser and AST support for
shader subroutines.
The code creates a subroutine type in the parser, and
uses that there to validate the identifiers. The parser
also distinguishes between subroutine types/function prototypes
/uniforms
From: Chris Forbes chr...@ijw.co.nz
Reviewed-by: Tapani Pälli tapani.pa...@intel.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
Signed-off-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/glsl/glcpp/glcpp-parse.y| 3 +++
From: Dave Airlie airl...@redhat.com
We need to store two sets of info into the ir_function,
if this is a function definition with a subroutine list
(subroutine_def) or if it a subroutine prototype.
v1.1: add some more documentation.
Reviewed-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by:
So I revisited ARB_shader_subroutine again today, and noticed
it was lacking wrt ARB_explicit_uniform_location thanks to some
piglits from Igalia/Intel.
So I've added support for that, cleaned up some things,
like calculating the compatible shaders for a uniform at link
time, stopped the dead
From: Dave Airlie airl...@redhat.com
This type will be used to store the name of subroutine types
as in subroutine void myfunc(void);
will store myfunc into a subroutine type.
This is required to the parser can identify a subroutine
type in a uniform decleration as a valid type, and also for
From: Chris Forbes chr...@ijw.co.nz
v2: fix output=true and LENGTH typo
Reviewed-by: Tapani Pälli tapani.pa...@intel.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
Signed-off-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by: Dave Airlie airl...@redhat.com
---
From: Chris Forbes chr...@ijw.co.nz
Reviewed-by: Tapani Pälli tapani.pa...@intel.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
Signed-off-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/glsl/glsl_lexer.ll | 2 +-
1 file changed, 1 insertion(+), 1
From: Dave Airlie airl...@redhat.com
This fleshes out the APIs, using the program resource
APIs where they should match.
It also sets the default values to valid subroutines.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/main/shaderapi.c | 450
From: Dave Airlie airl...@redhat.com
This fleshes out the ARB_program_query support for the
APIs that ARB_shader_subroutine introduces, leaving
some TODOs for later addition.
v2: reworked for lots of the ARB_program_interface_query
entry points and tests
Signed-off-by: Dave Airlie
From: Dave Airlie airl...@redhat.com
Add support for the subroutine uniform type ir-mesa.cpp
v1.1: add subroutine to int to switch
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/program/ir_to_mesa.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git
From: Dave Airlie airl...@redhat.com
This adds the necessary storage for subroutine info to gl_shader.
v2: add comments, rename one member
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/main/mtypes.h | 28
1 file changed, 28 insertions(+)
diff --git
From: Dave Airlie airl...@redhat.com
Just add support for the subroutine type to the
glsl-tgsi convertor.
v1.1: add subroutine to int support.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Dave Airlie airl...@redhat.com
since this touches drivers, only enable it on gallium
for now for drivers reporting GLSL 1.30 or above.
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/state_tracker/st_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git
From: Chris Forbes chr...@ijw.co.nz
Reviewed-by: Tapani Pälli tapani.pa...@intel.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
Signed-off-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/main/config.h | 6 ++
From: Chris Forbes chr...@ijw.co.nz
Reviewed-by: Tapani Pälli tapani.pa...@intel.com
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
Signed-off-by: Chris Forbes chr...@ijw.co.nz
Signed-off-by: Dave Airlie airl...@redhat.com
---
src/mesa/main/shaderapi.c | 63
91 matches
Mail list logo
