Re: [Mesa-dev] [PATCH] main: fix basename match's check if it's an array or struct

On 28/10/15 13:41, Tapani Pälli wrote: > On 10/28/2015 12:16 PM, Samuel Iglesias Gonsálvez wrote: >> >> On 28/10/15 11:13, Samuel Iglesias Gonsálvez wrote: >>> >>> On 28/10/15 10:31, Tapani Pälli wrote: On 10/28/2015 09:09 AM, Samuel Iglesias Gonsálvez wrote: > On 28/10/15 06:53, Tapani

[Mesa-dev] [Bug 92706] glBlitFramebuffer refuses to blit RGBA to RGB with MSAA

https://bugs.freedesktop.org/show_bug.cgi?id=92706 Neil Roberts changed: What|Removed |Added CC|

[Mesa-dev] [Bug 92706] glBlitFramebuffer refuses to blit RGBA to RGB with MSAA

https://bugs.freedesktop.org/show_bug.cgi?id=92706 --- Comment #1 from Neil Roberts --- It looks like in GL 4.4 they have completely removed the restriction that MSAA resolve blits need to have the same format. In the section entitled “Changes in the released Specification

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: fix error type for GetFramebufferAttachmentParameteriv

On 10/27/2015 06:42 PM, Ian Romanick wrote: On 10/27/2015 12:11 AM, Tapani Pälli wrote: Fixes following failing dEQP test: dEQP-GLES3.functional.fbo.api.attachment_query_empty_fbo Signed-off-by: Tapani Pälli Bugzilla:

[Mesa-dev] [PATCH] clover: fix building fix clang-3.8

https://bugs.freedesktop.org/show_bug.cgi?id=92705 Signed-off-by: Laurent Carlier --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp

Re: [Mesa-dev] [PATCH 1/6] i965: fix cycle estimates when there's a pipeline stall

On Wed, Oct 21, 2015 at 7:04 PM, Jason Ekstrand wrote: > I'm not 100% sure if this actually matches the hardware. It's > possible that some of the issue time is used to determine interference > and do the thread switch in which case, there may be some overlap. > However,

Re: [Mesa-dev] [PATCH 3/3] nir: Store PatchInputsRead and PatchOutputsWritten in nir_shader_info.

On Wed, 2015-10-28 at 03:37 -0700, Kenneth Graunke wrote: > These tessellation shader related fields need plumbing through NIR. > > Signed-off-by: Kenneth Graunke > --- > src/glsl/nir/glsl_to_nir.cpp | 2 ++ > src/glsl/nir/nir.h | 5 + > 2 files changed, 7

Re: [Mesa-dev] [PATCH] main: fix basename match's check if it's an array or struct

On 10/28/2015 12:16 PM, Samuel Iglesias Gonsálvez wrote: On 28/10/15 11:13, Samuel Iglesias Gonsálvez wrote: On 28/10/15 10:31, Tapani Pälli wrote: On 10/28/2015 09:09 AM, Samuel Iglesias Gonsálvez wrote: On 28/10/15 06:53, Tapani Pälli wrote: On 10/27/2015 04:04 PM, Samuel Iglesias

[Mesa-dev] [PATCH v2] st/mesa: fix mipmap generation for immutable textures with incomplete pyramids

Without the clamping by NumLevels, the state tracker would reallocate the texture storage (incorrect) and even fail to copy the base level image after reallocation, leading to the graphical glitch of https://bugs.freedesktop.org/show_bug.cgi?id=91993 . A piglit test has been submitted for review

Re: [Mesa-dev] [PATCH] clover: fix building fix clang-3.8

Laurent Carlier writes: > https://bugs.freedesktop.org/show_bug.cgi?id=92705 > > Signed-off-by: Laurent Carlier > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git

[Mesa-dev] [PATCH v2 07/13] st/va: add headless support, i.e. VA_DISPLAY_DRM

This patch allows to use gallium vaapi without requiring a X server running for your second graphic card. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/Makefile.am | 9 src/gallium/state_trackers/va/context.c | 70 --- 2

[Mesa-dev] [PATCH] clover: fix building fix clang-3.8

https://bugs.freedesktop.org/show_bug.cgi?id=92705 v2: use Linker::Flags::None instead of 0 Signed-off-by: Laurent Carlier --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] clover: fix building fix clang-3.8

Laurent Carlier writes: > https://bugs.freedesktop.org/show_bug.cgi?id=92705 > > v2.1: use Linker::Flags::None instead of 0 and emplace_back() > Thanks, Reviewed-by: Francisco Jerez > Signed-off-by: Laurent Carlier > --- >

Re: [Mesa-dev] [PATCH] clover: fix building fix clang-3.8

Laurent Carlier writes: > https://bugs.freedesktop.org/show_bug.cgi?id=92705 > > v2: use Linker::Flags::None instead of 0 > > Signed-off-by: Laurent Carlier > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +- > 1 file changed, 5

[Mesa-dev] [PATCH] clover: fix building fix clang-3.8

https://bugs.freedesktop.org/show_bug.cgi?id=92705 v2.1: use Linker::Flags::None instead of 0 and emplace_back() Signed-off-by: Laurent Carlier --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] mesa: rename UniformBlockStageIndex to InterfaceBlockStageIndex

On Wed, 2015-10-28 at 09:11 +0100, Iago Toral wrote: > Yeah, this makes things more consistent: > Reviewed-by: Iago Toral Quiroga I meant: Reviewed-by: Iago Toral Quiroga > > On Tue, 2015-10-27 at 22:38 -0700, Jordan Justen wrote: > > Signed-off-by:

Re: [Mesa-dev] [PATCH 1/3] mesa: rename UniformBlockStageIndex to InterfaceBlockStageIndex

Yeah, this makes things more consistent: Reviewed-by: Iago Toral Quiroga On Tue, 2015-10-27 at 22:38 -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > Cc: Samuel Iglesias Gonsálvez > Cc: Iago Toral Quiroga

Re: [Mesa-dev] [PATCH 3/3] mesa: Use UBO/SSBO indices during binding

On Tue, 2015-10-27 at 22:38 -0700, Jordan Justen wrote: > Previously we were treating the binding index for Uniform Buffer > Objects and Shader Storage Buffer Objects as being part of the > combined BufferInterfaceBlocks array. > > Fixes ES31-CTS.compute_shader.resource-ubo on i965. > >

Re: [Mesa-dev] [PATCH 1/4] nir/instr_set: Add an allow_loads field

On Tue, 2015-10-27 at 14:33 +0200, Pohjolainen, Topi wrote: > On Tue, Oct 27, 2015 at 10:28:58AM +0100, Iago Toral Quiroga wrote: > > We need this so we can configure different behaviors for passes that > > cannot deal with side-effectful instructions (CSE) and passes that can > > (we will add a

Re: [Mesa-dev] [PATCH 18/20] i965: Program the push constants state using the gather table

On 10/27/2015 03:18 PM, Francisco Jerez wrote: > Francisco Jerez writes: > >> Abdiel Janulgue writes: >> >>> Use the gather table generated from the uniform uploads and >>> ir_binop_ubo_load to gather and pack the constants to the gather

Re: [Mesa-dev] [PATCH] main: fix basename match's check if it's an array or struct

On 28/10/15 06:53, Tapani Pälli wrote: > On 10/27/2015 04:04 PM, Samuel Iglesias Gonsalvez wrote: >> Commit 4565b6f did not update the basename match's check for >> the case that string would exactly match the name of the >> variable if the suffix "[0]" were appended to it. >> >> Fixes two

Re: [Mesa-dev] [PATCH 1/2] gbm: Add a flag to enable creation of rotated scanout buffers

On 27.10.2015 22:13, Ville Syrjälä wrote: > On Fri, Oct 23, 2015 at 06:25:55PM -0700, Vivek Kasireddy wrote: >> On Fri, 23 Oct 2015 15:29:08 +0300 >> Ville Syrjälä wrote: >> >>> On Fri, Oct 23, 2015 at 12:18:39PM +0900, Michel Dänzer wrote: On 23.10.2015 10:44,

Re: [Mesa-dev] [PATCH 2/3] mesa: Map program UBOs and SSBOs to Interface Blocks

On Tue, 2015-10-27 at 22:38 -0700, Jordan Justen wrote: > Signed-off-by: Jordan Justen > Cc: Samuel Iglesias Gonsálvez > Cc: Iago Toral Quiroga > --- > src/glsl/linker.cpp | 14 ++ >

Re: [Mesa-dev] [PATCH v2 12/11] i965: Add scalar geometry shader support.

On Tuesday, October 27, 2015 04:40:19 PM Kristian Høgsberg wrote: > On Mon, Oct 12, 2015 at 02:55:32PM -0700, Kenneth Graunke wrote: > > Signed-off-by: Kenneth Graunke > > --- > > src/mesa/drivers/dri/i965/brw_fs.cpp | 174 ++ > >

Re: [Mesa-dev] [PATCH] main: fix basename match's check if it's an array or struct

On 28/10/15 10:31, Tapani Pälli wrote: > On 10/28/2015 09:09 AM, Samuel Iglesias Gonsálvez wrote: >> >> On 28/10/15 06:53, Tapani Pälli wrote: >>> On 10/27/2015 04:04 PM, Samuel Iglesias Gonsalvez wrote: Commit 4565b6f did not update the basename match's check for the case that string

Re: [Mesa-dev] [PATCH] main: fix basename match's check if it's an array or struct

On 28/10/15 11:13, Samuel Iglesias Gonsálvez wrote: > > > On 28/10/15 10:31, Tapani Pälli wrote: >> On 10/28/2015 09:09 AM, Samuel Iglesias Gonsálvez wrote: >>> >>> On 28/10/15 06:53, Tapani Pälli wrote: On 10/27/2015 04:04 PM, Samuel Iglesias Gonsalvez wrote: > Commit 4565b6f did not

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Sat, Oct 24, 2015 at 10:08 AM, Rob Clark wrote: > From: Rob Clark > > Convenient place to put in some extra sanity checking, without making > things messy for the drivers running the passes. In the short-term this seems to work (at least for

Re: [Mesa-dev] [PATCH] texgetimage: fix regression with shadow 1d array

On 10/27/2015 08:26 PM, Dave Airlie wrote: From: Dave Airlie since 1ad305b612f389fb04c6d51847427d5ec72fae03 Brian Paul Date: Tue Jul 21 18:35:38 2015 -0600 mesa: plumb offset/size parameters through GetTexSubImage code I found this testing virgl

Re: [Mesa-dev] [PATCH 3/3] st/mesa: implement ARB_copy_image

On Sun, Oct 25, 2015 at 1:25 PM, Marek Olšák wrote: > +static void > +st_CopyImageSubData(struct gl_context *ctx, > +struct gl_texture_image *src_image, > +struct gl_renderbuffer *src_renderbuffer, > +int src_x, int

[Mesa-dev] [PATCH] mesa/teximage: Fix ASTC-caused S3TC regression

From: Nanley Chery The ASTC spec forbids other compressed formats from being used against the targets: TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Because other compressed formats were previously supported for these targets in desktop GL, it's considered to be a spec bug and

[Mesa-dev] [PATCH] nvc0: expose a group of performance metrics on Fermi

This allows to monitor those performance metrics through GL_AMD_performance_monitor. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 14 +- src/gallium/drivers/nouveau/nvc0/nvc0_query.h | 3 ++-

Re: [Mesa-dev] [PATCH v2 1/7] nvc0: fix crash when nv50_miptree_from_handle fails

On 10/26/2015 01:44 PM, Julien Isorce wrote: On 25 October 2015 at 21:38, Samuel Pitoiset > wrote: Do you need someone to push this patch? Yes please Pushed. ___ mesa-dev

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Wed, Oct 28, 2015 at 12:09 PM, Jason Ekstrand wrote: > On Sat, Oct 24, 2015 at 10:08 AM, Rob Clark wrote: >> From: Rob Clark >> >> Convenient place to put in some extra sanity checking, without making >> things messy for

[Mesa-dev] [PATCH v2 3/4] nv50: move HW queries to nv50_query_hw.c/h files

Changes since v2: - remove unused 'nv50_hw_query_funcs' struct Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources | 2 + src/gallium/drivers/nouveau/nv50/nv50_query.c | 354 ++-

Re: [Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

On Wed, Oct 28, 2015 at 10:01:40AM +0100, Samuel Iglesias Gonsálvez wrote: > There is no opinions about this issue or reviews of the proposed patch > after one week. > > This is just a reminder in case you have missed it :-) Thanks for the reminder! How about something like this instead? diff

Re: [Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_*_PROG_DATA flagging caused by cache reuse.

On Wed, Oct 28, 2015 at 1:58 AM, Kenneth Graunke wrote: > Consider the case of two nearly identical GLSL fragment shaders: > >out vec4 color; >void main() { color = vec4(1); } > > and > >layout(early_fragment_tests) in; >out vec4 color; >void main() {

[Mesa-dev] [PATCH v2 4/4] nv50: do not create an invalid HW query type

While we are at it, store the rotate offset for occlusion queries to nv50_hw_query like on nvc0. Changes since v2: - remove useless 'space' variable Signed-off-by: Samuel Pitoiset Reviewed-by: Pierre Moreau ---

Re: [Mesa-dev] [PATCH v2 12/11] i965: Add scalar geometry shader support.

On Wed, Oct 28, 2015 at 3:08 AM, Kenneth Graunke wrote: > On Tuesday, October 27, 2015 04:40:19 PM Kristian Høgsberg wrote: >> On Mon, Oct 12, 2015 at 02:55:32PM -0700, Kenneth Graunke wrote: >> > Signed-off-by: Kenneth Graunke >> > --- >> >

Re: [Mesa-dev] [PATCH] mesa/teximage: Fix ASTC-caused S3TC regression

Reviewed-by: Mark Janes Tested-by: Mark Janes Nanley Chery writes: > From: Nanley Chery > > The ASTC spec forbids other compressed formats from being used against > the targets:

Re: [Mesa-dev] [PATCH] clover: fix building fix clang-3.8

Fixes the build for me here, and cl-program-tester from piglit seems to work just fine for the few tests I just ran. --Aaron On Wed, Oct 28, 2015 at 9:47 AM, Laurent Carlier wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=92705 > > v2.1: use Linker::Flags::None

[Mesa-dev] [Bug 92706] glBlitFramebuffer refuses to blit RGBA to RGB with MSAA

https://bugs.freedesktop.org/show_bug.cgi?id=92706 --- Comment #3 from Ian Romanick --- The biggest task will be updating existing piglit tests and adding new ones. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 92706] glBlitFramebuffer refuses to blit RGBA to RGB with MSAA

https://bugs.freedesktop.org/show_bug.cgi?id=92706 --- Comment #2 from Ian Romanick --- (In reply to Neil Roberts from comment #1) > It looks like in GL 4.4 they have completely removed the restriction that > MSAA resolve blits need to have the same format. In the section

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Wed, Oct 28, 2015 at 10:37 AM, Rob Clark wrote: > On Wed, Oct 28, 2015 at 12:09 PM, Jason Ekstrand wrote: >> On Sat, Oct 24, 2015 at 10:08 AM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Convenient

Re: [Mesa-dev] [PATCH] mesa/teximage: Fix ASTC-caused S3TC regression

On 10/28/2015 09:52 AM, Nanley Chery wrote: > From: Nanley Chery > > The ASTC spec forbids other compressed formats from being used against > the targets: TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Because other I apologize for not paying very much attention to this

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Wed, Oct 28, 2015 at 3:40 PM, Jason Ekstrand wrote: > On Wed, Oct 28, 2015 at 10:37 AM, Rob Clark wrote: >> On Wed, Oct 28, 2015 at 12:09 PM, Jason Ekstrand >> wrote: >>> On Sat, Oct 24, 2015 at 10:08 AM, Rob Clark

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On Wed, Oct 28, 2015 at 8:51 PM, Jason Ekstrand wrote: > On Wed, Oct 28, 2015 at 5:41 PM, Connor Abbott wrote: >> On Wed, Oct 28, 2015 at 8:00 PM, Jason Ekstrand wrote: >>> On Wed, Oct 28, 2015 at 4:26 PM, Connor Abbott

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On Wednesday, October 28, 2015 05:04:07 PM Ian Romanick wrote: > On 10/28/2015 04:43 PM, Connor Abbott wrote: > > On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: > >> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > >>> --- > >>> src/glsl/nir/nir.h | 19

Re: [Mesa-dev] [PATCH] clover: fix building fix clang-3.8

On 28.10.2015 23:54, Francisco Jerez wrote: > Laurent Carlier writes: > >> https://bugs.freedesktop.org/show_bug.cgi?id=92705 >> >> v2.1: use Linker::Flags::None instead of 0 and emplace_back() >> > Thanks, > > Reviewed-by: Francisco Jerez Pushed,

Re: [Mesa-dev] [PATCH 00/11] nir: Add a pass management framework

On Oct 28, 2015 9:12 PM, "Kenneth Graunke" wrote: > > On Wednesday, October 28, 2015 02:58:07 PM Kristian Høgsberg wrote: > > On Wed, Oct 28, 2015 at 2:34 PM, Jason Ekstrand wrote: > > > On Wed, Oct 28, 2015 at 2:32 PM, Jason Ekstrand

[Mesa-dev] [Bug 92705] [clover] fail to build with llvm-svn/clang-svn 3.8

https://bugs.freedesktop.org/show_bug.cgi?id=92705 Laurent carlier changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 00/11] nir: Add a pass management framework

On Wednesday, October 28, 2015 02:58:07 PM Kristian Høgsberg wrote: > On Wed, Oct 28, 2015 at 2:34 PM, Jason Ekstrand wrote: > > On Wed, Oct 28, 2015 at 2:32 PM, Jason Ekstrand > > wrote: > >> This series adds a nir_pass datastructure and some helpers

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On Wed, Oct 28, 2015 at 8:04 PM, Ian Romanick wrote: > People often complain about the way that open-source projects are so nit > picky about coding standards. It's a necessary survival tactic. Mesa > is 22 years old. It has had dozens of contributors. Imagine how much

Re: [Mesa-dev] [PATCH v2 3/4] nv50: move HW queries to nv50_query_hw.c/h files

Reviewed-by: Pierre Moreau On 06:24 PM - Oct 28 2015, Samuel Pitoiset wrote: > Changes since v2: > - remove unused 'nv50_hw_query_funcs' struct > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/Makefile.sources | 2

Re: [Mesa-dev] [PATCH 00/11] nir: Add a pass management framework

On Wed, Oct 28, 2015 at 2:32 PM, Jason Ekstrand wrote: > This series adds a nir_pass datastructure and some helpers for managing > optimization and lowering passes. I've been meaning to get around to this > for some time. There are a couple of primary benifits to this: > >

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Wed, Oct 28, 2015 at 5:24 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 1:37 PM, Rob Clark wrote: >> On Wed, Oct 28, 2015 at 12:09 PM, Jason Ekstrand >> wrote: >>> On Sat, Oct 24, 2015 at 10:08 AM, Rob Clark

[Mesa-dev] Manipulate GALLIUM_HUD post-launch (interactively)

I have found myself desiring the ability to manipulate the GALLIUM_HUD variable while an application is running. At the most basic simply being able to toggle the hud on and off would be great. Otherwise, one has to relaunch an application and get back to the same state which may not always be

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Wed, Oct 28, 2015 at 1:37 PM, Rob Clark wrote: > On Wed, Oct 28, 2015 at 12:09 PM, Jason Ekstrand wrote: >> On Sat, Oct 24, 2015 at 10:08 AM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Convenient

[Mesa-dev] [PATCH 05/11] nir/phis_to_scalar: Use the nir_pass framework internally

--- src/glsl/nir/nir_lower_phis_to_scalar.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c b/src/glsl/nir/nir_lower_phis_to_scalar.c index aa124d9..909a743 100644 --- a/src/glsl/nir/nir_lower_phis_to_scalar.c

[Mesa-dev] [PATCH 10/11] ir3: Use nir_pass for lower_if_else

Cc: Rob Clark --- .../drivers/freedreno/ir3/ir3_compiler_nir.c | 2 +- src/gallium/drivers/freedreno/ir3/ir3_nir.h| 2 +- .../drivers/freedreno/ir3/ir3_nir_lower_if_else.c | 22 ++ 3 files changed, 8 insertions(+), 18 deletions(-)

[Mesa-dev] [PATCH 01/11] nir: Move nir_metadata.c to nir_pass.c

We're about to put more pass management stuff in here so it needs a better name. --- src/glsl/Makefile.sources | 2 +- src/glsl/nir/nir_metadata.c | 54 - src/glsl/nir/nir_pass.c | 54 + 3 files

[Mesa-dev] [PATCH 07/11] nir: Use the nir_pass framework internally for copy_prop, dce, and cse

--- src/glsl/nir/nir_opt_copy_propagate.c | 17 - src/glsl/nir/nir_opt_cse.c| 21 - src/glsl/nir/nir_opt_dce.c| 20 3 files changed, 24 insertions(+), 34 deletions(-) diff --git

[Mesa-dev] [PATCH 06/11] nir/lower_vars_to_ssa: Use the nir_pass framework internally

--- src/glsl/nir/nir_lower_vars_to_ssa.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/glsl/nir/nir_lower_vars_to_ssa.c b/src/glsl/nir/nir_lower_vars_to_ssa.c index 5971507..b9215d0 100644 --- a/src/glsl/nir/nir_lower_vars_to_ssa.c +++

[Mesa-dev] [PATCH 04/11] nir/alu_to_scalar: Use the nir_pass framework internally

--- src/glsl/nir/nir_lower_alu_to_scalar.c | 56 ++ 1 file changed, 37 insertions(+), 19 deletions(-) diff --git a/src/glsl/nir/nir_lower_alu_to_scalar.c b/src/glsl/nir/nir_lower_alu_to_scalar.c index 9313fc0..e4d247f 100644 ---

[Mesa-dev] [PATCH 09/11] nir: Use the nir_pass framework internally for more passes

In particular, this commit adds it for: - nir_opt_constant_folding - nir_opt_dead_cf - nor_opt_peephole_select - nir_opt_remove_phis - nir_opt_undef --- src/glsl/nir/nir_opt_constant_folding.c | 21 - src/glsl/nir/nir_opt_dead_cf.c | 23 +--

[Mesa-dev] [PATCH 1/2] st/mesa: create temporary textures with the same nr_samples as source

Not sure if this is actually reachable in practice (to have a complex copy with MS textures). Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_cb_copyimage.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] nvc0: add ARB_copy_image support

Signed-off-by: Ilia Mirkin --- docs/GL3.txt| 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 12 3 files changed, 10 insertions(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa/teximage: Fix ASTC-caused S3TC regression

Am 28.10.2015 um 20:48 schrieb Ian Romanick: > On 10/28/2015 09:52 AM, Nanley Chery wrote: >> From: Nanley Chery >> >> The ASTC spec forbids other compressed formats from being used against >> the targets: TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Because other > > I

[Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

--- src/glsl/nir/nir.h | 19 +++ src/glsl/nir/nir_pass.c | 64 - 2 files changed, 82 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index e3777f9..069c7c1 100644 --- a/src/glsl/nir/nir.h +++

[Mesa-dev] [PATCH 08/11] nir/algebraic: Use the nir_pass framework internally

--- src/glsl/nir/nir_algebraic.py | 35 +++ 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/src/glsl/nir/nir_algebraic.py b/src/glsl/nir/nir_algebraic.py index bbf4f08..f0c2dcf 100644 --- a/src/glsl/nir/nir_algebraic.py +++

[Mesa-dev] [PATCH 03/11] nir: Unexpose _impl versions of copy_prop and dce

--- src/glsl/nir/nir.h| 2 -- src/glsl/nir/nir_opt_copy_propagate.c | 2 +- src/glsl/nir/nir_opt_dce.c| 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 069c7c1..a1ae043 100644 ---

[Mesa-dev] [PATCH 00/11] nir: Add a pass management framework

This series adds a nir_pass datastructure and some helpers for managing optimization and lowering passes. I've been meaning to get around to this for some time. There are a couple of primary benifits to this: First, this gives us a central place to put things such as validating the shader,

[Mesa-dev] [PATCH v2] mesa/teximage: Fix S3TC regression due to ASTC interaction

From: Nanley Chery A prior, literal reading of the ASTC spec led to the prohibition of some compressed formats being used against the targets: TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Since the spec does not specify interactions with other extensions for specific

Re: [Mesa-dev] [PATCH 2/4] nv50: move nva0_so_target_save_offset() to its correct location

Reviewed-by: Pierre Moreau On 11:30 PM - Oct 18 2015, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv50_query.c | 18 -- > src/gallium/drivers/nouveau/nv50/nv50_query.h | 3

Re: [Mesa-dev] [PATCH 00/11] nir: Add a pass management framework

On Wed, Oct 28, 2015 at 2:34 PM, Jason Ekstrand wrote: > On Wed, Oct 28, 2015 at 2:32 PM, Jason Ekstrand wrote: >> This series adds a nir_pass datastructure and some helpers for managing >> optimization and lowering passes. I've been meaning to get

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Wed, Oct 28, 2015 at 2:49 PM, Rob Clark wrote: > On Wed, Oct 28, 2015 at 5:24 PM, Connor Abbott wrote: >> On Wed, Oct 28, 2015 at 1:37 PM, Rob Clark wrote: >>> On Wed, Oct 28, 2015 at 12:09 PM, Jason Ekstrand

[Mesa-dev] FYI: Pull-through optimization for NIR

Hi all, Just thought I'd inform you of my experiments and findings this weekend. This summer I discussed a possible optimization pass with Connor that I've simply named "pull-through" for the lack of a better name. This tries to reorder operations of the type min(sqrt(a), sqrt(b)) into

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Wed, Oct 28, 2015 at 6:01 PM, Jason Ekstrand wrote: > On Wed, Oct 28, 2015 at 2:49 PM, Rob Clark wrote: >> On Wed, Oct 28, 2015 at 5:24 PM, Connor Abbott wrote: >>> On Wed, Oct 28, 2015 at 1:37 PM, Rob Clark

Re: [Mesa-dev] [PATCH 7/7] nir: add helper macros for running NIR passes

On Wed, Oct 28, 2015 at 3:13 PM, Rob Clark wrote: > On Wed, Oct 28, 2015 at 6:01 PM, Jason Ekstrand wrote: >> On Wed, Oct 28, 2015 at 2:49 PM, Rob Clark wrote: >>> On Wed, Oct 28, 2015 at 5:24 PM, Connor Abbott

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir.h | 19 +++ > src/glsl/nir/nir_pass.c | 64 > - > 2 files changed, 82 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h >

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

While it works for now, I'm not so sure about how we're conflating the definition of a pass and its dynamic instantiation. Eventually we'll want to have passes refer to each other ("please run pass B after pass A to clean up its mess", etc.), and in that case we need to be able to have to the pass

Re: [Mesa-dev] [PATCH 07/11] nir: Use the nir_pass framework internally for copy_prop, dce, and cse

On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_opt_copy_propagate.c | 17 - > src/glsl/nir/nir_opt_cse.c| 21 - > src/glsl/nir/nir_opt_dce.c| 20 > 3 files changed, 24 insertions(+), 34

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On Wed, Oct 28, 2015 at 4:43 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >>> --- >>> src/glsl/nir/nir.h | 19 +++ >>> src/glsl/nir/nir_pass.c | 64

Re: [Mesa-dev] [PATCH v2 12/11] i965: Add scalar geometry shader support.

On Mon, Oct 12, 2015 at 02:55:32PM -0700, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke A few comments below, but Reviewed-by: Kristian Høgsberg > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 174 ++ >

Re: [Mesa-dev] [PATCH 05/11] nir/phis_to_scalar: Use the nir_pass framework internally

On 10/28/2015 02:32 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_lower_phis_to_scalar.c | 25 - > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/src/glsl/nir/nir_lower_phis_to_scalar.c > b/src/glsl/nir/nir_lower_phis_to_scalar.c > index

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: > On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >> --- >> src/glsl/nir/nir.h | 19 +++ >> src/glsl/nir/nir_pass.c | 64 >> - >> 2 files changed, 82

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On Wed, Oct 28, 2015 at 4:26 PM, Connor Abbott wrote: > While it works for now, I'm not so sure about how we're conflating the > definition of a pass and its dynamic instantiation. Eventually we'll > want to have passes refer to each other ("please run pass B after pass > A

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass-running infastructure

On 10/28/2015 04:43 PM, Connor Abbott wrote: > On Wed, Oct 28, 2015 at 7:06 PM, Ian Romanick wrote: >> On 10/28/2015 02:32 PM, Jason Ekstrand wrote: >>> --- >>> src/glsl/nir/nir.h | 19 +++ >>> src/glsl/nir/nir_pass.c | 64 >>>

[Mesa-dev] [Bug 92705] [clover] fail to build with llvm-svn/clang-svn 3.8

https://bugs.freedesktop.org/show_bug.cgi?id=92705 Bug ID: 92705 Summary: [clover] fail to build with llvm-svn/clang-svn 3.8 Product: Mesa Version: git Hardware: All OS: Linux (All) Status: NEW Severity:

Re: [Mesa-dev] i965: Invalid memory accesses after resizing brw_codegen's store table

There is no opinions about this issue or reviews of the proposed patch after one week. This is just a reminder in case you have missed it :-) Sam On 21/10/15 12:23, Iago Toral wrote: > Hi, > > The problem is with code like this (see brw_send_indirect_message): > > setup = brw_OR(p, addr,

[Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_*_PROG_DATA flagging caused by cache reuse.

Consider the case of two nearly identical GLSL fragment shaders: out vec4 color; void main() { color = vec4(1); } and layout(early_fragment_tests) in; out vec4 color; void main() { color = vec4(1); } These shaders compile to the exact same assembly, but have distinct values for

Re: [Mesa-dev] [PATCH 2/2] glsl: fix GL_BUFFER_DATA_SIZE value for shader storage blocks with unsize arrays

This is a reminder that this patch is still unreviewed. Sam On 22/10/15 11:01, Samuel Iglesias Gonsalvez wrote: > From ARB_program_interface_query: > > "For the property of BUFFER_DATA_SIZE, then the implementation-dependent > minimum total buffer object size, in basic machine units, required

Re: [Mesa-dev] [PATCH] i965: Fix missing BRW_NEW_*_PROG_DATA flagging caused by cache reuse.

On Wed, Oct 28, 2015 at 01:58:41AM -0700, Kenneth Graunke wrote: > Consider the case of two nearly identical GLSL fragment shaders: > >out vec4 color; >void main() { color = vec4(1); } > > and > >layout(early_fragment_tests) in; >out vec4 color; >void main() { color =

Re: [Mesa-dev] [PATCH 2/2] glsl: fix GL_BUFFER_DATA_SIZE value for shader storage blocks with unsize arrays

On Thu, 2015-10-22 at 11:01 +0200, Samuel Iglesias Gonsalvez wrote: > From ARB_program_interface_query: > > "For the property of BUFFER_DATA_SIZE, then the implementation-dependent > minimum total buffer object size, in basic machine units, required to hold > all active variables associated

Re: [Mesa-dev] [PATCH] main: fix basename match's check if it's an array or struct

On 10/28/2015 09:09 AM, Samuel Iglesias Gonsálvez wrote: On 28/10/15 06:53, Tapani Pälli wrote: On 10/27/2015 04:04 PM, Samuel Iglesias Gonsalvez wrote: Commit 4565b6f did not update the basename match's check for the case that string would exactly match the name of the variable if the suffix

Re: [Mesa-dev] [PATCH 3/9] i965: Don't consider control flow instructions to have sources.

On Wed, 2015-10-21 at 15:58 -0700, Matt Turner wrote: > And why did IFF have a destination? > > I suspect that once upon a time the disassembler used this information > to know which fields to find the jump targets in. The jump targets have > moved, so the disassembler has to know how to handle

Re: [Mesa-dev] [PATCH 2/2] glsl: fix GL_BUFFER_DATA_SIZE value for shader storage blocks with unsize arrays

On 28/10/15 10:32, Iago Toral wrote: > On Thu, 2015-10-22 at 11:01 +0200, Samuel Iglesias Gonsalvez wrote: >> From ARB_program_interface_query: >> >> "For the property of BUFFER_DATA_SIZE, then the implementation-dependent >> minimum total buffer object size, in basic machine units, required to

[Mesa-dev] [Bug 92706] glBlitFramebuffer refuses to blit RGBA to RGB with MSAA

https://bugs.freedesktop.org/show_bug.cgi?id=92706 Bug ID: 92706 Summary: glBlitFramebuffer refuses to blit RGBA to RGB with MSAA Product: Mesa Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All)

[Mesa-dev] [PATCH 1/3] nir: Add intrinsics for tessellation shader system values.

nir_intrinsic_load_patch_vertices_in corresponds to gl_PatchVerticesIn, a special input in both the TCS and TES stages. nir_intrinsic_load_tess_coord corresponds to gl_TessCoord, a special tessellation evaluation shader input. nir_intrinsic_load_tess_level_outer/inner correspond to the

[Mesa-dev] [PATCH 2/3] nir: Copy "patch" flag from ir_variable to nir_variable.

This was introduced in GLSL IR after NIR development had branched. Signed-off-by: Kenneth Graunke --- src/glsl/nir/glsl_to_nir.cpp | 1 + src/glsl/nir/nir.h | 1 + src/glsl/nir/nir_print.c | 5 +++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 3/3] nir: Store PatchInputsRead and PatchOutputsWritten in nir_shader_info.

These tessellation shader related fields need plumbing through NIR. Signed-off-by: Kenneth Graunke --- src/glsl/nir/glsl_to_nir.cpp | 2 ++ src/glsl/nir/nir.h | 5 + 2 files changed, 7 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp

  1   2   >