Re: [Mesa-dev] [PATCH 7/7] nir: add nir_ssa_for_alu_src()

On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark wrote: > From: Rob Clark > > Using something like: > >numer = nir_ssa_for_src(bld, alu->src[0].src, >nir_ssa_alu_instr_src_components(alu, 0)); > > for alu src's with swizzle,

Re: [Mesa-dev] [PATCH 2/7] nir: remove nir_variable::max_ifc_array_access

Yes, please! Reviewed-by: Jason Ekstrand On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark wrote: > From: Rob Clark > > No users. > > Signed-off-by: Rob Clark > --- > src/glsl/nir/glsl_to_nir.cpp | 9

Re: [Mesa-dev] [PATCH 4/7] nir/print: show shader name/label if set

Reviewed-by: Jason Ekstrand On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/glsl/nir/nir_print.c | 6 ++ > 1 file changed, 6

Re: [Mesa-dev] [PATCH mesa 0/5] nouveau: codegen: Make use of double immediates

Hi Hans, All pushed. I made a few additional fixes and improvement to fp64 immediate handling along the way, but all your commits were fine as-is. (Except that they enabled fp64 immediates on nv50 implicitly which is wrong -- there are no immediate-taking variants on nv50, so I fixed that glitch.

[Mesa-dev] [PATCH v2 6/9] i965: Add annotation_insert_error() and support for printing errors.

Will allow annotations to contain error messages (indicating an instruction violates a rule for instance) that are printed after the disassembly of the block. --- src/mesa/drivers/dri/i965/intel_asm_annotation.c | 71 +--- src/mesa/drivers/dri/i965/intel_asm_annotation.h | 7

Re: [Mesa-dev] [PATCH 1/7] nir: add nir_var_all enum

On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark wrote: > Otherwise, passing -1 gets you: > > error: invalid conversion from 'int' to 'nir_variable_mode' [-fpermissive] > > Signed-off-by: Rob Clark > --- > I was going to convert the enum values to

Re: [Mesa-dev] [PATCH 6/9] i965: Add annotation_insert_error() and support for printing errors.

On Tue, Nov 3, 2015 at 10:44 PM, Kenneth Graunke wrote: > On Tuesday, November 03, 2015 10:20:26 PM Matt Turner wrote: >> On Tue, Nov 3, 2015 at 9:47 PM, Kenneth Graunke >> wrote: >> > memmove(cur + 1, cur, >> >

Re: [Mesa-dev] [PATCH 6/7] nir: fix missing increments of num_inputs/num_outputs

On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/glsl/nir/nir_lower_clip.c| 2 ++ > src/glsl/nir/nir_lower_two_sided_color.c | 2 ++ > 2 files

Re: [Mesa-dev] [PATCH] glsl: remove redundant function inout assignments

On Tue, 2015-11-03 at 20:42 -0500, Ilia Mirkin wrote: > On Tue, Nov 3, 2015 at 8:23 PM, Timothy Arceri > wrote: > > On Wed, 2015-11-04 at 12:12 +1100, Timothy Arceri wrote: > > > On Tue, 2015-11-03 at 19:39 -0500, Ilia Mirkin wrote: > > > > On Tue, Nov 3, 2015 at

Re: [Mesa-dev] [PATCH 6/7] nir: fix missing increments of num_inputs/num_outputs

On Fri, Nov 6, 2015 at 6:39 PM, Rob Clark wrote: > On Fri, Nov 6, 2015 at 6:23 PM, Jason Ekstrand wrote: >> On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Signed-off-by: Rob

[Mesa-dev] [PATCH] i965/skl/gt4: Fix URB programming restriction.

The comment in the code details the restriction. Thanks to Ken for having a very helpful conversation with me, and spotting the blurb in the link I sent him :P. There are still stability problems for me on GT4, but this definitely helps with some of the failures. Cc: Kenneth Graunke

[Mesa-dev] [PATCH 1/2] dri_interface: Introduce __DRI_IMAGE_USE_SCANOUT_ROTATION_* flags (v2)

These flags can be used by the DRI driver to set additional requirements such as tiling while creating buffers. v2: Added a brief comment to explain the rotation orientation. Cc: Michel Danzer Signed-off-by: Vivek Kasireddy ---

[Mesa-dev] [PATCH 2/2] gbm: Add flags to enable creation of rotated scanout buffers (v4)

For certain platforms that support rotated scanout buffers, currently, there is no way to create them with the GBM DRI interface. These flags will instruct the DRI driver to create the buffer by setting additional requirements such as tiling mode. v2: Reserve a bit per angle. (Ville and Michel)

[Mesa-dev] [PATCH 1/3] glsl: Parse shared keyword for compute shader variables

Signed-off-by: Jordan Justen --- Notes: git://people.freedesktop.org/~jljusten/mesa cs-parse-shared-vars-v1 http://patchwork.freedesktop.org/bundle/jljusten/cs-parse-shared-vars-v1 With these environment overrides: export

[Mesa-dev] [PATCH 3/3] glsl: Use shared storage variable type for shared variables

Signed-off-by: Jordan Justen --- src/glsl/ast_to_hir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index dd5ba4e..4ef770f 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2790,6 +2790,8

[Mesa-dev] [PATCH 2/3] glsl: Add shared variable type

Shared variables are stored in a common pool accessible by all threads in a compute shader local work group. These variables are similar to OpenCL's local/__local variables. Signed-off-by: Jordan Justen --- src/glsl/ir.h | 15 ---

Re: [Mesa-dev] [PATCH 4/6] glsl: add support for complie-time constant expressions

On Fri, 2015-11-06 at 14:17 +, Emil Velikov wrote: > Hi Tim, Hi Emil, Thanks for taking a look over these. > > In my (limited) experience going through the glsl code, I've noticed > that in a few cases we tend to do the same "flags.q.foo && > validate_foo()" in a number of occasions. In

Re: [Mesa-dev] [PATCH 6/7] nir: fix missing increments of num_inputs/num_outputs

On Fri, Nov 6, 2015 at 6:23 PM, Jason Ekstrand wrote: > On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark wrote: >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> src/glsl/nir/nir_lower_clip.c

[Mesa-dev] [PATCH] glsl: simplify interface block stream qualifier validation

Qualifiers on member variables are redundent all we need to do if check if it matches the stream associated with the block and throw an error if its not. Cc: Samuel Iglesias Gonsalvez Cc: Emil Velikov --- src/glsl/ast_to_hir.cpp | 27

Re: [Mesa-dev] [PATCH] android: fix LOCAL_C_INCLUDES to find glsl_types.h

Hi Emil, by exporting the path of glsl nir headers, mesa builds without problems. You can find in the attachment the formatted patch. Thanks Mauro 2015-11-06 18:26 GMT+01:00 Emil Velikov : > Hi Mauro > > On 6 November 2015 at 03:31, Mauro Rossi

Re: [Mesa-dev] [PATCH] i965/skl/gt4: Fix URB programming restriction.

On 2015-11-06 18:12:27, Ben Widawsky wrote: > The comment in the code details the restriction. Thanks to Ken for having a > very > helpful conversation with me, and spotting the blurb in the link I sent him > :P. > > There are still stability problems for me on GT4, but this definitely helps >

Re: [Mesa-dev] [PATCH 1/3] glsl: Parse shared keyword for compute shader variables

On Fri, 2015-11-06 at 17:56 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > > Notes: > git://people.freedesktop.org/~jljusten/mesa cs-parse-shared-vars-v1 > http://patchwork.freedesktop.org/bundle/jljusten/cs-parse-shared-vars-v1 > >

Re: [Mesa-dev] [PATCH 3/3] glsl: Use shared storage variable type for shared variables

On Fri, 2015-11-06 at 17:56 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/glsl/ast_to_hir.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > index dd5ba4e..4ef770f 100644 > ---

Re: [Mesa-dev] [PATCH] i965/skl/gt4: Fix URB programming restriction.

On Friday, November 06, 2015 06:12:27 PM Ben Widawsky wrote: > The comment in the code details the restriction. Thanks to Ken for having a > very > helpful conversation with me, and spotting the blurb in the link I sent him > :P. > > There are still stability problems for me on GT4, but this

Re: [Mesa-dev] [PATCH 6/7] nir: fix missing increments of num_inputs/num_outputs

On Fri, Nov 6, 2015 at 5:10 PM, Rob Clark wrote: > On Fri, Nov 6, 2015 at 6:39 PM, Rob Clark wrote: >> On Fri, Nov 6, 2015 at 6:23 PM, Jason Ekstrand wrote: >>> On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark wrote:

Re: [Mesa-dev] [PATCH 1/3] glsl: Parse shared keyword for compute shader variables

On Fri, 2015-11-06 at 17:56 -0800, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > > Notes: > git://people.freedesktop.org/~jljusten/mesa cs-parse-shared-vars-v1 > http://patchwork.freedesktop.org/bundle/jljusten/cs-parse-shared-vars-v1 > >

Re: [Mesa-dev] [PATCH 2/3] glsl: Add shared variable type

On Fri, 2015-11-06 at 17:56 -0800, Jordan Justen wrote: > Shared variables are stored in a common pool accessible by all threads > in a compute shader local work group. > > These variables are similar to OpenCL's local/__local variables. > > Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH 2/2] gbm: Add flags to enable creation of rotated scanout buffers (v4)

Am 07.11.2015 04:05, schrieb Vivek Kasireddy: For certain platforms that support rotated scanout buffers, currently, there is no way to create them with the GBM DRI interface. These flags will instruct the DRI driver to create the buffer by setting additional requirements such as tiling mode.

Re: [Mesa-dev] [PATCH 2/2] gbm: Add flags to enable creation of rotated scanout buffers (v3)

On 06.11.2015 12:08, Vivek Kasireddy wrote: > For certain platforms that support rotated scanout buffers, currently, > there is no way to create them with the GBM DRI interface. These flags > will instruct the DRI driver to create the buffer by setting > additional requirements such as tiling

Re: [Mesa-dev] [PATCH] nvc0: enable compute support on Fermi

Hi, On 06-11-15 00:51, Samuel Pitoiset wrote: On 11/06/2015 12:43 AM, Ilia Mirkin wrote: On Thu, Nov 5, 2015 at 6:41 PM, Samuel Pitoiset wrote: Altough the compute support is still not complete because textures and surfaces need to be implemented, it allows to

Re: [Mesa-dev] [PATCH v3 1/3] glsl: Add new barrier functions for compute shaders

Jordan Justen writes: > When these functions are called in GLSL code, we create an intrinsic > function call: > > * groupMemoryBarrier => __intrinsic_group_memory_barrier > * memoryBarrierAtomicCounter => __intrinsic_memory_barrier_atomic_counter > *

[Mesa-dev] [PATCH v2 3/4] vl/buffers: add RGBX and BGRX to the supported formats

Useful is one wants to create RGBX or BGRX surfaces. The infrastructure is such that it required just a few definitions to support these formats. Signed-off-by: Julien Isorce --- src/gallium/auxiliary/vl/vl_video_buffer.c | 18 ++ 1 file changed, 18

[Mesa-dev] [PATCH v2 2/4] st/va: properly use brackets in vlVaAcquireBufferHandle's switch

In "switch (mem_type)" the brackets were surrounding "case+default" instead of "case" only. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/buffer.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH v2 1/4] st/va: properly indent buffer.c, config.c, image.c and picture.c

Some lines were using 4 indentation spaces instead of 3. The switch in vlVaAcquireBufferHandle actually had wrong brackets surrounding case+default. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/buffer.c | 14 +++---

[Mesa-dev] [PATCH v2 4/4] st/va: add support for RGBX and BGRX in VPP

Before it was only possible to convert a NV12 surface to RGBA or BGRA. This patch uses the same post processing function, "handleVAProcPipelineParameterBufferType", but add definitions for RGBX and BGRX. This patch also makes vlVaQuerySurfaceAttributes more generic to avoid copy and pasting the

[Mesa-dev] [PATCH] radeon/uvd: add H.265/HEVC to legal notes

From: Christian König Signed-off-by: Christian König --- docs/README.UVD | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/README.UVD b/docs/README.UVD index 38ea864..b0f4b9d 100644 --- a/docs/README.UVD +++

Re: [Mesa-dev] memoryBarrier + SSBO

On Tue, Nov 3, 2015 at 8:40 PM, Ilia Mirkin wrote: > Ian, any comment on this? > > On Fri, Sep 25, 2015 at 1:32 PM, Ilia Mirkin wrote: >> Hi Ian (and other spec experts), >> >> The ARB_ssbo spec mentions the following: >> >> OpenGL 4.0 (either core or

Re: [Mesa-dev] [PATCH] nvc0: enable compute support on Fermi

On 11/06/2015 11:23 AM, Hans de Goede wrote: Hi, On 06-11-15 00:51, Samuel Pitoiset wrote: On 11/06/2015 12:43 AM, Ilia Mirkin wrote: On Thu, Nov 5, 2015 at 6:41 PM, Samuel Pitoiset wrote: Altough the compute support is still not complete because textures and

[Mesa-dev] [PATCH 2/2] radeon/uvd: fix VC-1 simple/main profile decode v2

From: Boyuan Zhang We just needed to set the extra width/height fields to get this working. v2 (chk): rebased, CC stable added, commit message added, fixed coding style Signed-off-by: Boyuan Zhang Signed-off-by: Christian König

[Mesa-dev] [PATCH 1/2] st/vaapi: fix vaapi VC-1 simple/main corruption v2

From: Boyuan Zhang Apply the start code fix only to advanced profile. v2 (chk): add commit message Signed-off-by: Boyuan Zhang Reviewed-by: Christian König Cc: "10.6 11.0" ---

[Mesa-dev] fix VC-1 simple/main profile

Hi list, we haven't fixed all the issues yet, but this is a clearly step in the right direction. If nobody has any more objections I'm going to push these by the end of today. Regards, Christian. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] winsys/radeon: Use CPU page size instead of hardcoding 4096 bytes v2

On Wed, Nov 4, 2015 at 11:05 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes GPUVM conflicts with non-4K page size. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92738 > > v2: Replace sanitization of VM base address alignment with

Re: [Mesa-dev] [PATCH v3 3/3] i965/nir/fs: Implement new barrier functions for compute shaders

Jordan Justen writes: > For these nir intrinsics, we emit the same code as > nir_intrinsic_memory_barrier: > > * nir_intrinsic_memory_barrier_atomic_counter > * nir_intrinsic_memory_barrier_buffer > * nir_intrinsic_memory_barrier_image > > We treat these nir

Re: [Mesa-dev] [PATCH 1/6] mesa: add ARB_enhanced_layouts

Hi Tim, A few comments below On 5 November 2015 at 11:17, Timothy Arceri wrote: > From: Timothy Arceri > > Set to dummy_false until the remaining features are added. > --- > src/glsl/glcpp/glcpp-parse.y| 1 + >

[Mesa-dev] [PATCH] i965/fs: Use regs_read/written for post-RA scheduling in calculate_deps

Previously, we were assuming that everything read/wrote exactly 1 logical GRF (1 in SIMD8 and 2 in SIMD16). This isn't actually true. In particular, the PLN instruction reads 2 logical registers in one of the components. This commit changes post-RA scheduling to use regs_read and regs_written

Re: [Mesa-dev] [PATCH] nvc0: enable compute support on Fermi

On Fri, Nov 6, 2015 at 5:23 AM, Hans de Goede wrote: > On 06-11-15 00:51, Samuel Pitoiset wrote: >> On 11/06/2015 12:43 AM, Ilia Mirkin wrote: >>> Of course this also enables it for NVF0_3D_CLASS. Pretty sure compute >>> doesn't work there for some dumb reason (like we're

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

On Fri, Nov 6, 2015 at 1:48 PM, Zhang, Boyuan wrote: > Hi Emil, > > Please see the following information about this patch. > > - Issue: For Mpeg4, the VOP and GOV headers were truncated. With the existing > workaround in st/va, playback shows massive corruptions. > - This

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

On 06.11.2015 20:10, Ilia Mirkin wrote: On Fri, Nov 6, 2015 at 1:48 PM, Zhang, Boyuan wrote: Hi Emil, Please see the following information about this patch. - Issue: For Mpeg4, the VOP and GOV headers were truncated. With the existing workaround in st/va, playback

Re: [Mesa-dev] [PATCH] egl/dri2: expose srgb configs when KHR_gl_colorspace is available

On Thu, Oct 15, 2015 at 2:28 PM, Emil Velikov wrote: > On 3 October 2015 at 12:19, Emil Velikov wrote: >> On 3 October 2015 at 02:12, Marek Olšák wrote: >>> I'm not sure if this is correct or if we should just return NULL in

Re: [Mesa-dev] [PATCH] egl/dri2: expose srgb configs when KHR_gl_colorspace is available

On Fri, Nov 6, 2015 at 8:24 PM, Marek Olšák wrote: > On Thu, Oct 15, 2015 at 2:28 PM, Emil Velikov > wrote: >> On 3 October 2015 at 12:19, Emil Velikov wrote: >>> On 3 October 2015 at 02:12, Marek Olšák

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

On Fri, Nov 6, 2015 at 2:15 PM, Christian König wrote: > On 06.11.2015 20:10, Ilia Mirkin wrote: >> >> On Fri, Nov 6, 2015 at 1:48 PM, Zhang, Boyuan >> wrote: >>> >>> Hi Emil, >>> >>> Please see the following information about this patch. >>> >>> -

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

Hi Emil, Please see the following information about this patch. - Issue: For Mpeg4, the VOP and GOV headers were truncated. With the existing workaround in st/va, playback shows massive corruptions. - This Patch: Provide another way to get the truncated headers back. Massive corruptions are

Re: [Mesa-dev] [PATCH v3 3/8] glsl: Add support for the new builtins that EXT_blend_func_extended provides.

On Fri, Nov 6, 2015 at 1:10 PM, Ian Romanick wrote: > On 11/05/2015 06:47 PM, Ryan Houdek wrote: >> gl_MaxDualSourceDrawBuffersEXT - Maximum DS draw buffers supported >> >> Only for ESSL 1.0 it provides two builtins since you can't have user-defined >> color output variables

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

Hi Emil, >Shorten the variable name - OMX_RENDER_NODE ? debug_get_option is only >available on debug builds so better use getenv. > The debug_get_*_option() functions are used all around mesa, and functions are explicitly preferred to working with getenv() directly. Regards, Leo

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

On 6 November 2015 at 03:19, Liu, Leo wrote: >>-Original Message- >>From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >>Sent: Thursday, November 05, 2015 6:30 PM >>To: Liu, Leo >>Cc: ML mesa-dev >>Subject: Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support >> >>On

[Mesa-dev] [PATCH 2/7] nir: remove nir_variable::max_ifc_array_access

From: Rob Clark No users. Signed-off-by: Rob Clark --- src/glsl/nir/glsl_to_nir.cpp | 9 - src/glsl/nir/nir.h | 13 - 2 files changed, 22 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp

[Mesa-dev] [PATCH 4/7] nir/print: show shader name/label if set

From: Rob Clark Signed-off-by: Rob Clark --- src/glsl/nir/nir_print.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c index 30220c5..bde7535 100644 --- a/src/glsl/nir/nir_print.c

[Mesa-dev] [PATCH 5/7] nir/print: show # of uniforms/inputs/outputs

From: Rob Clark Signed-off-by: Rob Clark --- src/glsl/nir/nir_print.c | 4 1 file changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c index bde7535..a110945 100644 --- a/src/glsl/nir/nir_print.c +++

[Mesa-dev] [PATCH 7/7] nir: add nir_ssa_for_alu_src()

From: Rob Clark Using something like: numer = nir_ssa_for_src(bld, alu->src[0].src, nir_ssa_alu_instr_src_components(alu, 0)); for alu src's with swizzle, like: vec1 ssa_10 = intrinsic load_uniform () () (0, 0) vec2 ssa_11 =

[Mesa-dev] [PATCH 6/7] nir: fix missing increments of num_inputs/num_outputs

From: Rob Clark Signed-off-by: Rob Clark --- src/glsl/nir/nir_lower_clip.c| 2 ++ src/glsl/nir/nir_lower_two_sided_color.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/glsl/nir/nir_lower_clip.c

[Mesa-dev] [PATCH 3/7] nir: add array length field

From: Rob Clark This will simplify things somewhat in clone. Signed-off-by: Rob Clark --- src/glsl/nir/glsl_to_nir.cpp | 5 + src/glsl/nir/nir.h | 5 + 2 files changed, 10 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 4/4] st/omx: add headless support

Hello Leo, On 6 November 2015 at 16:00, Liu, Leo wrote: > Hi Emil, > >>Shorten the variable name - OMX_RENDER_NODE ? debug_get_option is only >>available on debug builds so better use getenv. >> > > The debug_get_*_option() functions are used all around mesa, and functions >

[Mesa-dev] [PATCH] nir/glsl_to_nir: use _mesa_fls() to compute num_textures

Replace the current loop by a direct call to _mesa_fls() function. It also fixes an implicit bug in the current code where num_textures seems to be one value less than it should be when sh->Program->SamplersUsed > 0. For instance, num_textures is 0 instead of 1 when sh->Program->SamplersUsed is

Re: [Mesa-dev] [PATCH] vbo: fix another GL_LINE_LOOP bug

Hi Brian, On 31 October 2015 at 13:38, Brian Paul wrote: > Very long line loops which spanned 3 or more vertex buffers were not > handled correctly and could result in stray lines. > > The piglit lineloop test draws 1 vertices by default, and is not > long enough to

[Mesa-dev] [PATCH 1/7] nir: add nir_var_all enum

Otherwise, passing -1 gets you: error: invalid conversion from 'int' to 'nir_variable_mode' [-fpermissive] Signed-off-by: Rob Clark --- I was going to convert the enum values to bitmask/flags which could be OR'd, but that doesn't play nicely w/ nir_variable::data which

[Mesa-dev] [PATCH 0/7] nir: few small patches that I've been collecting..

From: Rob Clark From my ongoing clone + gallium glsl_to_nir branch.. figured I should tidy them up and send to list. Rob Clark (7): nir: add nir_var_all enum nir: remove nir_variable::max_ifc_array_access nir: add array length field nir/print: show shader

[Mesa-dev] [PATCH v2 4/4] st/omx: add headless support

This will allow dec/enc/transcode without X v2: -use env override even with X, -use loader_open_device instead of open Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/state_trackers/omx/entrypoint.c | 37

Re: [Mesa-dev] [PATCH v2 4/4] st/omx: add headless support

Hi Leo, I've suggested a few things before, yet I might have been too subtle. Let me try again. On 6 November 2015 at 16:40, Leo Liu wrote: > This will allow dec/enc/transcode without X Please add "running" in the above sentence "... without running X" or similar. > > v2:

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

On 5 November 2015 at 18:47, Leo Liu wrote: > This will allow the state trackers to use render nodes > with screen creation > > Signed-off-by: Leo Liu > --- > src/gallium/auxiliary/Makefile.sources | 3 +- > src/gallium/auxiliary/vl/vl_winsys.h | 6 +++

Re: [Mesa-dev] [PATCH 2/2] gbm: Add flags to enable creation of rotated scanout buffers (v3)

On Fri, Nov 06, 2015 at 06:56:13PM +0900, Michel Dänzer wrote: > On 06.11.2015 12:08, Vivek Kasireddy wrote: > > For certain platforms that support rotated scanout buffers, currently, > > there is no way to create them with the GBM DRI interface. These flags > > will instruct the DRI driver to

Re: [Mesa-dev] [PATCH 4/6] glsl: add support for complie-time constant expressions

Hi Tim, In my (limited) experience going through the glsl code, I've noticed that in a few cases we tend to do the same "flags.q.foo && validate_foo()" in a number of occasions. In some cases we silently ignore errors, while on others we omit checking the return value of validate_foo() all

[Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

From: Iago Toral Quiroga We will need this later on when we implement proper support for precision qualifiers in the drivers and also to do link time checks for uniforms as indicated by the spec. This patch also adds compile-time checks for variables without precision

Re: [Mesa-dev] [PATCH] android: fix LOCAL_C_INCLUDES to find glsl_types.h

Hi Mauro On 6 November 2015 at 03:31, Mauro Rossi wrote: > These changes are necessary to avoid building errors in glsl and i965 > --- > src/glsl/Android.mk | 6 -- > src/mesa/drivers/dri/i965/Android.mk | 3 ++- > 2 files changed, 6 insertions(+), 3

Re: [Mesa-dev] [PATCH v2 1/4] st/va: properly indent buffer.c, config.c, image.c and picture.c

On 06.11.2015 11:33, Julien Isorce wrote: Some lines were using 4 indentation spaces instead of 3. The switch in vlVaAcquireBufferHandle actually had wrong brackets surrounding case+default. Signed-off-by: Julien Isorce Well you should probably remove the note about

Re: [Mesa-dev] [PATCH 3/6] glsl: move layout qualifier validation out of the parser

On 5 November 2015 at 11:17, Timothy Arceri wrote: > From: Timothy Arceri > > This is in preperation for compile-time constant support. typo "preparation" > > Also fix up the locations for some of the extension checking > error messages in

Re: [Mesa-dev] [PATCH] glsl: Relax requirement on Centroid matching between shader stages

On 11/04/2015 01:04 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > In OpenGL 4.4, section 4.5, the requirement for interpolation > qualifiers to match over shader stages was removed. > In OpenGL ES 3.1, section 9.2.1 there is a table showing that > centroid does

Re: [Mesa-dev] [PATCH] vbo: fix another GL_LINE_LOOP bug

On 11/06/2015 09:40 AM, Emil Velikov wrote: Hi Brian, On 31 October 2015 at 13:38, Brian Paul wrote: Very long line loops which spanned 3 or more vertex buffers were not handled correctly and could result in stray lines. The piglit lineloop test draws 1 vertices by

Re: [Mesa-dev] [PATCH v3 1/8] glapi: Add EXT_blend_func_extended XML definitions

On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > src/mapi/glapi/gen/EXT_gpu_shader4.xml | 3 ++- > src/mapi/glapi/gen/es_EXT.xml | 26 ++ > src/mesa/main/tests/dispatch_sanity.cpp | 8 > 3 files changed, 36 insertions(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

>> +#if GALLIUM_STATIC_TARGETS >> + vscreen->pscreen = dd_create_screen(fd); >> +#else >> + if (pipe_loader_drm_probe_fd(>dev, fd)) { >Add a dup() in the above. So that it reads > >if (pipe_loader_drm_probe_fd(>dev, dup(fd))) { > The dup is handled is in st/va/context.c before calling

Re: [Mesa-dev] [PATCH v3 7/8] mesa: Allow MAX_DUAL_SOURCE_DRAW_BUFFERS to be available to ES

This patch is Reviewed-by: Ian Romanick On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > src/mesa/main/get_hash_params.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/get_hash_params.py >

Re: [Mesa-dev] [PATCH v3 4/8] glsl: Add GL_EXT_blend_func_extended preprocessor define

This patch is Reviewed-by: Ian Romanick On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > src/glsl/glcpp/glcpp-parse.y | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y > index 4acccf7..10bf83f

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

On 6 November 2015 at 18:01, Liu, Leo wrote: > >>> +#if GALLIUM_STATIC_TARGETS >>> + vscreen->pscreen = dd_create_screen(fd); >>> +#else >>> + if (pipe_loader_drm_probe_fd(>dev, fd)) { >>Add a dup() in the above. So that it reads >> >>if (pipe_loader_drm_probe_fd(>dev,

Re: [Mesa-dev] [PATCH v3 1/8] glapi: Add EXT_blend_func_extended XML definitions

Yes this is correct. These functions are only available in ES 3.0+ profiles. The only things that ES 2.0 gets is the new builtins for the shading language. On Fri, Nov 6, 2015 at 12:49 PM, Ian Romanick wrote: > On 11/05/2015 06:47 PM, Ryan Houdek wrote: > > --- > >

[Mesa-dev] [PATCH v2 2/4] vl: add drm support for vl_screen

This will allow the state trackers to use render nodes with screen creation v2 -dup fd for pipe loader Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/auxiliary/Makefile.sources | 3 +- src/gallium/auxiliary/vl/vl_winsys.h

[Mesa-dev] [PATCH v3 4/4] st/omx: add headless support

This will allow dec/enc/transcode without X v2: -use env override even with X, -use loader_open_device instead of open v3: -cleanup Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/state_trackers/omx/entrypoint.c | 45

Re: [Mesa-dev] [PATCH 2/2] radeon/uvd: fix VC-1 simple/main profile decode v2

On Fri, Nov 6, 2015 at 5:58 AM, Christian König wrote: > From: Boyuan Zhang > > We just needed to set the extra width/height fields to get this working. > > v2 (chk): rebased, CC stable added, commit message added, fixed coding style > >

[Mesa-dev] [PATCH v2 3/4] st/va: use vl screen drm support from vl_wys_drm

v2: -move the dup to vl_wys_drm for pipe loader Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/state_trackers/va/context.c | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] radeon/uvd: add H.265/HEVC to legal notes

On Fri, Nov 6, 2015 at 5:45 AM, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König CC stable? Was HEVC in 11? Reviewed-by: Alex Deucher > --- >

Re: [Mesa-dev] [PATCH v3 6/8] mesa: Enable usage of blend_func_extended blend factors

On 11/05/2015 06:47 PM, Ryan Houdek wrote: > --- > src/mesa/main/blend.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c > index 20aa498..185e30e 100644 > --- a/src/mesa/main/blend.c > +++ b/src/mesa/main/blend.c > @@

Re: [Mesa-dev] [PATCH v3 5/8] glsl: Add a parse check to check for the index layout qualifier

On 11/05/2015 06:47 PM, Ryan Houdek wrote: > This can only be used if EXT_blend_func_extended is enabled > --- > src/glsl/glsl_parser.yy | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy > index 4636435..40e60e5 100644 > ---

Re: [Mesa-dev] [PATCH v3 3/8] glsl: Add support for the new builtins that EXT_blend_func_extended provides.

On 11/05/2015 06:47 PM, Ryan Houdek wrote: > gl_MaxDualSourceDrawBuffersEXT - Maximum DS draw buffers supported > > Only for ESSL 1.0 it provides two builtins since you can't have user-defined > color output variables > gl_SecondaryFragColorEXT and gl_SecondaryFragDataEXT[MaxDSDrawBuffers] > ---

Re: [Mesa-dev] [PATCH] i965/fs: Use regs_read/written for post-RA scheduling in calculate_deps

On Fri, Nov 6, 2015 at 10:59 AM, Jason Ekstrand wrote: > Previously, we were assuming that everything read/wrote exactly 1 logical > GRF (1 in SIMD8 and 2 in SIMD16). This isn't actually true. In > particular, the PLN instruction reads 2 logical registers in one of the >

Re: [Mesa-dev] [PATCH] nir/glsl_to_nir: use _mesa_fls() to compute num_textures

On Fri, Nov 6, 2015 at 8:27 AM, Juan A. Suarez Romero wrote: > Replace the current loop by a direct call to _mesa_fls() function. > > It also fixes an implicit bug in the current code where num_textures > seems to be one value less than it should be when

Re: [Mesa-dev] [PATCH 00/24] i965: Refactor register classes

Hi Matt, A short summary [PATCH 06/24] i965: Add and use enum brw_reg_file. s/GRF/BRW_ARCHITECTURE_REGISTER_FILE/ - already addressed in your branch. [PATCH 12/24] i965: Initialize registers' file to BAD_FILE. With the fs_visitor::init() hunk dropped and memset(this->outputs, 0...) removed.

Re: [Mesa-dev] fix VC-1 simple/main profile

On 6 November 2015 at 10:58, Christian König wrote: > Hi list, > > we haven't fixed all the issues yet, but this is a clearly step in the > right direction. > > If nobody has any more objections I'm going to push these by the end of today. > On behalf of everyone using

Re: [Mesa-dev] [PATCH] i965/fs: Use regs_read/written for post-RA scheduling in calculate_deps

Reviewed-by: Connor Abbott On Fri, Nov 6, 2015 at 1:59 PM, Jason Ekstrand wrote: > Previously, we were assuming that everything read/wrote exactly 1 logical > GRF (1 in SIMD8 and 2 in SIMD16). This isn't actually true. In > particular, the PLN

Re: [Mesa-dev] [PATCH v2 0/3] Lower UBO/SSBO access early

Nice work. Thanks for fixing this one! Series Reviewed-by: Jordan Justen On 2015-11-05 21:44:29, Kristian Høgsberg Kristensen wrote: > Here's v2 of the series I sent out yesterday. Nothing changed in what > we're trying to do, but I figured out the shader-db

Re: [Mesa-dev] [PATCH 1/6] mesa: add ARB_enhanced_layouts

On Fri, 2015-11-06 at 13:02 +, Emil Velikov wrote: > Hi Tim, > > A few comments below > > On 5 November 2015 at 11:17, Timothy Arceri wrote: > > From: Timothy Arceri > > > > Set to dummy_false until the remaining features are added. > >

Re: [Mesa-dev] [PATCH 3/6] glsl: move layout qualifier validation out of the parser

On Fri, 2015-11-06 at 13:16 +, Emil Velikov wrote: > On 5 November 2015 at 11:17, Timothy Arceri wrote: > > From: Timothy Arceri > > > > This is in preperation for compile-time constant support. > typo "preparation" > > > > > Also fix

Re: [Mesa-dev] [PATCH v3 3/3] i965/nir/fs: Implement new barrier functions for compute shaders

On 2015-11-06 04:48:00, Francisco Jerez wrote: > Jordan Justen writes: > > > For these nir intrinsics, we emit the same code as > > nir_intrinsic_memory_barrier: > > > > * nir_intrinsic_memory_barrier_atomic_counter > > * nir_intrinsic_memory_barrier_buffer > > *

  1   2   >