Re: [Mesa-dev] [PATCH 08/17] tgsi/ureg: add shared variables support for compute shaders

2016-01-26 Thread Marek Olšák
I think it would be better to add a new TGSI file for shared variables. Marek On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > This adds a new SHARED attribute to TGSI_FILE_BUFFER. Only > one shared buffer can be declared and its size is defined by >

Re: [Mesa-dev] [PATCH 15/17] st/mesa: add a state tracker for compute

2016-01-26 Thread Marek Olšák
On Mon, Jan 25, 2016 at 4:02 PM, Ilia Mirkin wrote: > How about > > st/mesa: add compute program dispatch callbacks > > or something along those lines. I don't think "state tracker" is the > right term to use. With that done: Reviewed-by: Marek Olšák

Re: [Mesa-dev] [PATCH 18/18] trace: add all compute related functions

2016-01-26 Thread Marek Olšák
On Sun, Jan 24, 2016 at 10:18 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > > I have forgot this one... > > src/gallium/drivers/trace/tr_context.c| 80 > +++ >

Re: [Mesa-dev] [PATCH 02/17] mesa: do not use a constant for MAX_COMPUTE_SHARED_SIZE

2016-01-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > This will allow to query the underlying drivers for the maximum > total storage size of all variables declared as with > PIPE_COMPUTE_CAP_MAX_LOCAL_SIZE. >

Re: [Mesa-dev] [PATCH 1/2] winsys/amdgpu: Handle RADEON_FLAG_NO_CPU_ACCESS

2016-01-26 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Jan 26, 2016 at 8:40 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Failing to do this was resulting in the kernel driver unnecessarily > leaving open the possibility

Re: [Mesa-dev] [PATCH 01/17] mesa: make compute maximums reflect driver-provided values

2016-01-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > From: Ilia Mirkin > > Looks like the various max's were never plumbed through. > > Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH 03/17] gallium/cso: add support for compute shaders

2016-01-26 Thread Marek Olšák
Functions cso_save_compute_shader & cso_restore_compute_shader, and the compute_shader_saved variable can be removed. There is no use for them as far as I can see. Marek On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH 05/17] gallium: reserve one shader buffer for shared storage

2016-01-26 Thread Marek Olšák
I don't understand this. Can you explain it? AFAIK, shared variables don't need a backing buffer. Thanks, Marek On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > At least, one shader buffer must be available for compute shaders. > > Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH 07/17] gallium: add indirect compute parameters to pipe_grid_info

2016-01-26 Thread Marek Olšák
With Ilia's suggestion applied: Reviewed-by: Marek Olšák Marek On Mon, Jan 25, 2016 at 3:28 PM, Ilia Mirkin wrote: > On Sun, Jan 24, 2016 at 4:09 PM, Samuel Pitoiset > wrote: >> Like indirect draw, we need to store a

Re: [Mesa-dev] [PATCH 14/17] st/mesa: add state validation for compute shaders

2016-01-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > This binds atomics, constants, samplers, ssbos, textures and ubos. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH] radeonsi: use llvm.amdgcn.s.barrier instead of llvm.AMDGPU.barrier.local

2016-01-26 Thread Marek Olšák
On Mon, Jan 25, 2016 at 10:49 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The new name for the intrinsic was introduced in LLVM r258558. > --- > src/gallium/drivers/radeonsi/si_shader.c | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: [Mesa-dev] [PATCH 04/17] gallium: disable compute shaders for meta ops

2016-01-26 Thread Marek Olšák
On Tue, Jan 26, 2016 at 6:17 AM, Alex Deucher wrote: > On Mon, Jan 25, 2016 at 6:35 PM, Nicolai Hähnle wrote: >> On 24.01.2016 16:09, Samuel Pitoiset wrote: >>> >>> Loosely based on tessellation shaders. >> >> >> Do we actually need this? The graphics

Re: [Mesa-dev] [PATCH 10/17] st/mesa: add compute shader states

2016-01-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/state_tracker/st_atom.c| 2 +- > src/mesa/state_tracker/st_atom.h

Re: [Mesa-dev] [PATCH 2/2] gallium/ddebug: add 'verbose' option

2016-01-26 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Mon, Jan 25, 2016 at 6:00 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This currently just writes out the name of dump files, which can be useful > to easily correlate

[Mesa-dev] [Bug 54600] pbuffer_reference_openvg_image() not implemented (egl_g3d_st.c)

2016-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54600 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] gallium r300 driver for PowerPC

2016-01-26 Thread Michel Dänzer
On 25.01.2016 10:56, Herminio Hernandez, Jr. wrote: > So I believe I have all the debugging symbols installed. From what I > am seeing in gdb and valgrind I am still thinking the issue is in the > glx branch. For gdb I ran it twice and stopped it during it attempt > to load the r300 driver and in

Re: [Mesa-dev] gallium r300 driver for PowerPC

2016-01-26 Thread Herminio Hernandez Jr.
Would the same thing apply swrast driver? I see glxgears trying to fall back to it and relieving the same error. Sent from my iPhone > On Jan 26, 2016, at 3:31 AM, Michel Dänzer wrote: > >> On 25.01.2016 10:56, Herminio Hernandez, Jr. wrote: >> So I believe I have all the

Re: [Mesa-dev] [PATCH 09/17] st/mesa: add a second pipeline for compute

2016-01-26 Thread Marek Olšák
On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > Compute needs a new and different validation path. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/include/state_tracker/st_api.h | 8 + >

Re: [Mesa-dev] [PATCH v2] glsl: add GL_OES_geometry_point_size and conditionalize gl_PointSize

2016-01-26 Thread Lofstedt, Marta
Reviewed-by: Marta Lofstedt > -Original Message- > From: Ilia Mirkin [mailto:ibmir...@gmail.com] On Behalf Of Ilia Mirkin > Sent: Friday, January 22, 2016 9:24 PM > To: mesa-dev@lists.freedesktop.org > Cc: Lofstedt, Marta; Ilia Mirkin > Subject: [PATCH v2]

Re: [Mesa-dev] [PATCH 06/17] gallium: add a new interface for pipe_context::launch_grid()

2016-01-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > This introduces pipe_grid_info which contains all information to > describe a launch_grid call. This will be used to implement indirect > compute in the

Re: [Mesa-dev] [PATCH 16/17] st/mesa: implement limits for ARB_compute_shader

2016-01-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Jan 24, 2016 at 10:09 PM, Samuel Pitoiset wrote: > According to the spec, this also increases the following minimum values: > - MAX_COMBINED_TEXTURE_IMAGE_UNITS 96 (6*16), was 80 > -

[Mesa-dev] [Bug 62046] [nouveau] Power Point Viewer crashed at start

2016-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=62046 Timothy Arceri changed: What|Removed |Added Summary|Power Point Viewer crashed |[nouveau] Power

Re: [Mesa-dev] [PATCH v5] mesa: enable enums for OES_geometry_shader

2016-01-26 Thread Lofstedt, Marta
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ilia Mirkin > Sent: Tuesday, January 26, 2016 6:01 PM > To: Marta Lofstedt > Cc: mesa-dev@lists.freedesktop.org; Marek Olšák > Subject: Re: [Mesa-dev] [PATCH v5] mesa: enable enums for >

Re: [Mesa-dev] [PATCH] i965/skl: Utilize new 5th bit for gateway messages

2016-01-26 Thread Jordan Justen
Reviewed-by: Jordan Justen On 2016-01-26 15:44:01, Ben Widawsky wrote: > Cc: Jordan Justen > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 +++- > 1 file changed, 3

Re: [Mesa-dev] [PATCH V3 1/2] glsl: don't attempt to link empty program

2016-01-26 Thread Timothy Arceri
On Tue, 2016-01-26 at 13:33 +1100, Timothy Arceri wrote: > On Mon, 2016-01-25 at 16:58 -0800, Ian Romanick wrote: > > On 01/25/2016 04:46 PM, Timothy Arceri wrote: > > > Previously an empty program would go through the entire > > > link_shaders() function and we would have to be careful > > > not

Re: [Mesa-dev] [PATCH v2] glsl: fix consumer_stage restriction to separate shader objects

2016-01-26 Thread Tapani Pälli
On 01/26/2016 05:59 AM, Timothy Arceri wrote: On Tue, 2016-01-19 at 07:20 +0100, Samuel Iglesias Gonsálvez wrote: Commit 781d278 did not restrict consumer_stage only to separate shader objects, which is when we don't know if the consumer stage would be a fragment shader added later. In normal

Re: [Mesa-dev] [PATCH 2/4] mesa: enable enums for OES_geometry_shader

2016-01-26 Thread Lofstedt, Marta
I am sorry for this. I am sending up a v5 where I have accounted for that check_extra doesn't evaluate lazily FYI I believe that the the EXTRA_EXT_*_TESS tokens may need to be looked over, since they are bound to cause similar trouble when we enable oes_tesselation_shader for GLES 3.1. I

[Mesa-dev] [PATCH v5] mesa: enable enums for OES_geometry_shader

2016-01-26 Thread Marta Lofstedt
From: Marta Lofstedt Enable GL_OES_geometry_shader enums for OpenGL ES 3.1. V4: EXTRA tokens updated according to comments from Ilia Mirkin. V5: Account for check_extra does not evaluate "or" lazy. Fix issues with EXTRA_EXT_FB_NO_ATTACH_CS. Signed-off-by: Marta

Re: [Mesa-dev] [PATCH 1/2] winsys/amdgpu: Handle RADEON_FLAG_NO_CPU_ACCESS

2016-01-26 Thread Christian König
Am 26.01.2016 um 08:40 schrieb Michel Dänzer: From: Michel Dänzer Failing to do this was resulting in the kernel driver unnecessarily leaving open the possibility of CPU access to tiled BOs. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93862 (This change

Re: [Mesa-dev] [PATCH 04/17] gallium: disable compute shaders for meta ops

2016-01-26 Thread Ilia Mirkin
On Tue, Jan 26, 2016 at 5:28 AM, Marek Olšák wrote: > On Tue, Jan 26, 2016 at 6:17 AM, Alex Deucher wrote: >> On Mon, Jan 25, 2016 at 6:35 PM, Nicolai Hähnle wrote: >>> On 24.01.2016 16:09, Samuel Pitoiset wrote: Loosely

Re: [Mesa-dev] [PATCH 08/17] tgsi/ureg: add shared variables support for compute shaders

2016-01-26 Thread Ilia Mirkin
I'd be fine with a new TGSI_FILE_MEMORY which provided options for shared, global, and local(/private?) memory. I believe the old TGSI_FILE_RESOURCE had support for these in a hacky way, this would be the clean way of doing it. On Tue, Jan 26, 2016 at 5:52 AM, Marek Olšák

[Mesa-dev] [PATCH] nv50/ir: fix minor memory corpution when RA does another round

2016-01-26 Thread Karol Herbst
From: Karol Herbst sometimes an application might crash with a message like this: ERROR: no viable spill candidates left this is due to a memory corruption wich only manifest when there is another RA round this fixes this Signed-off-by: Karol Herbst

Re: [Mesa-dev] [PATCH 2/2] winsys/amdgpu: Process RADEON_FLAG_* independently from RADEON_DOMAIN_*

2016-01-26 Thread Alex Deucher
On Tue, Jan 26, 2016 at 2:40 AM, Michel Dänzer wrote: > From: Michel Dänzer > > In particular, AMDGPU_GEM_CREATE_CPU_GTT_USWC can affect even BOs created > in VRAM if they get evicted to GTT. In general there's no need to > restrict any of the flags to

Re: [Mesa-dev] [PATCH 08/17] tgsi/ureg: add shared variables support for compute shaders

2016-01-26 Thread Ilia Mirkin
On Tue, Jan 26, 2016 at 8:57 AM, Marek Olšák wrote: > On Tue, Jan 26, 2016 at 2:25 PM, Ilia Mirkin wrote: >> I'd be fine with a new TGSI_FILE_MEMORY which provided options for >> shared, global, and local(/private?) memory. I believe the old >>

Re: [Mesa-dev] [PATCH v2 1/4] mesa: add GREMEDY_string_marker

2016-01-26 Thread Jose Fonseca
On 20/01/16 19:48, Rob Clark wrote: On Wed, Jan 20, 2016 at 2:44 PM, Ilia Mirkin wrote: On Wed, Jan 20, 2016 at 2:32 PM, Rob Clark wrote: From: Rob Clark Signed-off-by: Rob Clark ---

Re: [Mesa-dev] [PATCH] trace: fix a segfault when tracing indirect draw calls

2016-01-26 Thread Samuel Pitoiset
On 01/25/2016 08:07 PM, Marek Olšák wrote: On Sun, Jan 24, 2016 at 4:47 PM, Samuel Pitoiset wrote: Like other resources, the indirect draw buffer must be unwrapped. Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH 03/17] gallium/cso: add support for compute shaders

2016-01-26 Thread Samuel Pitoiset
On 01/26/2016 11:30 AM, Marek Olšák wrote: Functions cso_save_compute_shader & cso_restore_compute_shader, and the compute_shader_saved variable can be removed. There is no use for them as far as I can see. Yeah, because the next patch ("gallium: disable compute shaders for meta ops") is

Re: [Mesa-dev] [PATCH] radeonsi: use llvm.amdgcn.s.barrier instead of llvm.AMDGPU.barrier.local

2016-01-26 Thread Nicolai Hähnle
On 26.01.2016 06:55, Marek Olšák wrote: On Mon, Jan 25, 2016 at 10:49 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle The new name for the intrinsic was introduced in LLVM r258558. --- src/gallium/drivers/radeonsi/si_shader.c | 7 ++- 1 file

Re: [Mesa-dev] [PATCH 07/17] gallium: add indirect compute parameters to pipe_grid_info

2016-01-26 Thread Samuel Pitoiset
On 01/25/2016 03:28 PM, Ilia Mirkin wrote: On Sun, Jan 24, 2016 at 4:09 PM, Samuel Pitoiset wrote: Like indirect draw, we need to store a resource and an offset that needs to be 4 byte aligned. When indirect is used, the size of the grid (in blocks) is stored with

Re: [Mesa-dev] [PATCH 18/18] trace: add all compute related functions

2016-01-26 Thread Samuel Pitoiset
On 01/26/2016 12:47 PM, Marek Olšák wrote: On Sun, Jan 24, 2016 at 10:18 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- I have forgot this one... src/gallium/drivers/trace/tr_context.c| 80

Re: [Mesa-dev] [PATCH 04/17] gallium: disable compute shaders for meta ops

2016-01-26 Thread Samuel Pitoiset
On 01/26/2016 02:22 PM, Ilia Mirkin wrote: On Tue, Jan 26, 2016 at 5:28 AM, Marek Olšák wrote: On Tue, Jan 26, 2016 at 6:17 AM, Alex Deucher wrote: On Mon, Jan 25, 2016 at 6:35 PM, Nicolai Hähnle wrote: On 24.01.2016 16:09,

Re: [Mesa-dev] [PATCH 15/17] st/mesa: add a state tracker for compute

2016-01-26 Thread Samuel Pitoiset
On 01/25/2016 04:02 PM, Ilia Mirkin wrote: How about st/mesa: add compute program dispatch callbacks or something along those lines. I don't think "state tracker" is the right term to use. Fine by me, thanks for the suggestion. On Sun, Jan 24, 2016 at 4:09 PM, Samuel Pitoiset

Re: [Mesa-dev] [PATCH 08/17] tgsi/ureg: add shared variables support for compute shaders

2016-01-26 Thread Samuel Pitoiset
On 01/26/2016 02:57 PM, Marek Olšák wrote: On Tue, Jan 26, 2016 at 2:25 PM, Ilia Mirkin wrote: I'd be fine with a new TGSI_FILE_MEMORY which provided options for shared, global, and local(/private?) memory. I believe the old TGSI_FILE_RESOURCE had support for these in a

Re: [Mesa-dev] [PATCH 17/17] st/mesa: expose ARB_compute_shader when compute is supported

2016-01-26 Thread Samuel Pitoiset
On 01/26/2016 05:45 AM, Ilia Mirkin wrote: On Mon, Jan 25, 2016 at 11:00 PM, Michel Dänzer wrote: On 26.01.2016 01:17, Nicolai Hähnle wrote: On 25.01.2016 10:04, Ilia Mirkin wrote: Yeah so this isn't going to fly. r600/radeonsi both expose PIPE_CAP_COMPUTE, for clover,

Re: [Mesa-dev] [PATCH 17/17] st/mesa: expose ARB_compute_shader when compute is supported

2016-01-26 Thread Nicolai Hähnle
On 25.01.2016 23:45, Ilia Mirkin wrote: On Mon, Jan 25, 2016 at 11:00 PM, Michel Dänzer wrote: On 26.01.2016 01:17, Nicolai Hähnle wrote: On 25.01.2016 10:04, Ilia Mirkin wrote: Yeah so this isn't going to fly. r600/radeonsi both expose PIPE_CAP_COMPUTE, for clover, but

Re: [Mesa-dev] [PATCH 05/17] gallium: reserve one shader buffer for shared storage

2016-01-26 Thread Samuel Pitoiset
On 01/26/2016 11:36 AM, Marek Olšák wrote: I don't understand this. Can you explain it? This shader buffer for shared storage is actually a fake buffer. Only one shared "fake" buffer can be used and it will contain all shared variables which are defined in the compute shaders. Its size is

Re: [Mesa-dev] [PATCH 00/12] i965+nir: Do pack/unpack lowering in NIR

2016-01-26 Thread Iago Toral
Patches 1 to 4 are, Reviewed-by: Iago Toral Quiroga I intend to review the remaining patches tomorrow as well if nobody else beats me to it. Iago On Mon, 2016-01-25 at 15:18 -0800, Matt Turner wrote: > This series adds NIR support for lowering pack/unpack opcodes and >

[Mesa-dev] [PATCH] gallium: fix the documentation of PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE

2016-01-26 Thread Nicolai Hähnle
From: Nicolai Hähnle This parameter is equivalent to the corresponding OpenGL implementation limit which is in texels, not bytes. --- Based on a discussion in IRC; I plan to push it with the rest of the series on PBO uploads. src/gallium/docs/source/screen.rst | 2 +-

Re: [Mesa-dev] [PATCH] gallium: fix the documentation of PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE

2016-01-26 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Jan 26, 2016 at 11:06 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This parameter is equivalent to the corresponding OpenGL implementation > limit which is in texels, not bytes. > --- >

Re: [Mesa-dev] [PATCH v5] mesa: enable enums for OES_geometry_shader

2016-01-26 Thread Ilia Mirkin
On Tue, Jan 26, 2016 at 3:48 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Enable GL_OES_geometry_shader enums for OpenGL ES 3.1. > > V4: EXTRA tokens updated according to comments from Ilia Mirkin. > > V5: Account for check_extra

Re: [Mesa-dev] [PATCH 3/4] radeonsi: add max waves / SIMD to shader stats (v2)

2016-01-26 Thread Marek Olšák
On Tue, Jan 26, 2016 at 1:47 AM, Tom Stellard wrote: > On Fri, Jan 22, 2016 at 03:18:12PM +0100, Marek Olšák wrote: >> From: Marek Olšák >> >> v2: account for LDS usage in PS >> the limit is per SIMD, not per CU >> --- >>

Re: [Mesa-dev] [PATCH] Fix locking of GLsync objects

2016-01-26 Thread Marek Olšák
On Mon, Jan 11, 2016 at 1:31 AM, Steinar H. Gunderson wrote: > On Wed, Dec 09, 2015 at 11:42:59AM +0100, Steinar H. Gunderson wrote: >>> Might be worth keeping _mesa_ref_sync_object(), even if it's an inline >>> wrapper around the above. As things get a bit confusing -

Re: [Mesa-dev] [PATCH 00/12] i965+nir: Do pack/unpack lowering in NIR

2016-01-26 Thread Eric Anholt
Matt Turner writes: > This series adds NIR support for lowering pack/unpack opcodes and > switches i965 over to using that. The only place we still use the > GLSL IR lower_packing_builtins.cpp is for the half-precision functions > on Sandybridge. > > As a result, I get to

Re: [Mesa-dev] [PATCH 2/2] r600,compute: Plug few memory leaks

2016-01-26 Thread Marek Olšák
I've pushed this series. Thanks. Marek On Thu, Jan 21, 2016 at 5:17 PM, Jan Vesely wrote: > v2: drop inline keyword > drop radeon_llvm_dispose_kernel_module wrapper > > v3: move definitions to .c file > use in radeonsi > > Signed-off-by: Jan Vesely

[Mesa-dev] [Bug 89599] symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2016-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89599 --- Comment #9 from Vinson Lee --- (In reply to Matt Turner from comment #6) > What do I have to do to reproduce this? Mesa builds with clang (3.7.0) > fine for me. I've built with clang occasionally for a few years and >

Re: [Mesa-dev] [PATCH 00/12] i965+nir: Do pack/unpack lowering in NIR

2016-01-26 Thread Matt Turner
On Tue, Jan 26, 2016 at 10:05 AM, Eric Anholt wrote: > Matt Turner writes: > >> This series adds NIR support for lowering pack/unpack opcodes and >> switches i965 over to using that. The only place we still use the >> GLSL IR lower_packing_builtins.cpp is for

Re: [Mesa-dev] [PATCH] trace: fix a segfault when tracing indirect draw calls

2016-01-26 Thread Marek Olšák
On Tue, Jan 26, 2016 at 3:53 PM, Samuel Pitoiset wrote: > > > On 01/25/2016 08:07 PM, Marek Olšák wrote: >> >> On Sun, Jan 24, 2016 at 4:47 PM, Samuel Pitoiset >> wrote: >>> >>> Like other resources, the indirect draw buffer must be

Re: [Mesa-dev] [PATCH 05/17] gallium: reserve one shader buffer for shared storage

2016-01-26 Thread Marek Olšák
On Tue, Jan 26, 2016 at 4:21 PM, Samuel Pitoiset wrote: > > > On 01/26/2016 11:36 AM, Marek Olšák wrote: >> >> I don't understand this. Can you explain it? > > > This shader buffer for shared storage is actually a fake buffer. Only one > shared "fake" buffer can be used

Re: [Mesa-dev] [PATCH 08/17] tgsi/ureg: add shared variables support for compute shaders

2016-01-26 Thread Marek Olšák
On Tue, Jan 26, 2016 at 3:12 PM, Ilia Mirkin wrote: > On Tue, Jan 26, 2016 at 8:57 AM, Marek Olšák wrote: >> On Tue, Jan 26, 2016 at 2:25 PM, Ilia Mirkin wrote: >>> I'd be fine with a new TGSI_FILE_MEMORY which provided options for

Re: [Mesa-dev] [PATCH] gallium: fix the documentation of PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE

2016-01-26 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Jan 26, 2016 at 5:06 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This parameter is equivalent to the corresponding OpenGL implementation > limit which is in texels, not bytes. >

[Mesa-dev] [PATCH] tgsi/scan: add tgsi_shader_info::reads_samplemask

2016-01-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 7a02e27..687fb54 100644

Re: [Mesa-dev] [PATCH 08/17] tgsi/ureg: add shared variables support for compute shaders

2016-01-26 Thread Ilia Mirkin
On Tue, Jan 26, 2016 at 3:23 PM, Marek Olšák wrote: > On Tue, Jan 26, 2016 at 3:12 PM, Ilia Mirkin wrote: >> On Tue, Jan 26, 2016 at 8:57 AM, Marek Olšák wrote: >>> On Tue, Jan 26, 2016 at 2:25 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH 1/9] gallium: Add PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY

2016-01-26 Thread Fredrik Höglund
On Wednesday 20 January 2016, Fredrik Höglund wrote: > On Tuesday 19 January 2016, Nicolai Hähnle wrote: > > On 19.01.2016 10:45, Fredrik Höglund wrote: > > > On Tuesday 19 January 2016, Nicolai Hähnle wrote: > > >> > > >> On 18.01.2016 18:50, Ilia Mirkin wrote: > > >>> On Mon, Jan 18, 2016 at

[Mesa-dev] [Bug 93878] [llvmpipe][softpipe] piglit arb_gpu_shader_fp64-double-gettransformfeedbackvarying regression

2016-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93878 Bug ID: 93878 Summary: [llvmpipe][softpipe] piglit arb_gpu_shader_fp64-double-gettransformfeedbackvarying regression Product: Mesa Version: git

[Mesa-dev] [PATCH 1/2] mesa: bump required GCC version to 4.4.0

2016-01-26 Thread Timothy Arceri
From: Timothy Arceri The last time this was bumped we settled on 4.2.0 because OpenBSD wasn't willing to ship anything greater than 4.2.1 (as that was the last GPLv2 licensed version) however they now ship 4.9.3. As far as I can tell the oldest distro still using a

[Mesa-dev] [PATCH 2/2] util: remove support for GCC older than 4.3.0

2016-01-26 Thread Timothy Arceri
From: Timothy Arceri --- src/util/macros.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/macros.h b/src/util/macros.h index 0c8958f..55d5424 100644 --- a/src/util/macros.h +++ b/src/util/macros.h @@ -160,9 +160,7 @@ do {

Re: [Mesa-dev] [PATCH 1/2] mesa: bump required GCC version to 4.4.0

2016-01-26 Thread Matt Turner
On Tue, Jan 26, 2016 at 2:04 PM, Timothy Arceri wrote: > The last time this was bumped we settled on 4.2.0 because OpenBSD > wasn't willing to ship anything greater than 4.2.1 (as that was the > last GPLv2 licensed version) however they now ship 4.9.3. I suspect

Re: [Mesa-dev] [PATCH] Fix locking of GLsync objects

2016-01-26 Thread Steinar H. Gunderson
On Tue, Jan 26, 2016 at 07:00:20PM +0100, Marek Olšák wrote: Might be worth keeping _mesa_ref_sync_object(), even if it's an inline wrapper around the above. As things get a bit confusing - foo_get vs foo_unref. >>> What about _mesa_get_and_ref_sync()? > Sounds good to me. Attached

Re: [Mesa-dev] [PATCH 2/6] nv50/ir: swap sources in PostRaConstantFolding when src0 is imm

2016-01-26 Thread Karol Herbst
> Ilia Mirkin hat am 26. Januar 2016 um 04:53 > geschrieben: > > On Mon, Jan 25, 2016 at 9:57 AM, Karol Herbst wrote: > > From: Karol Herbst > > > > helps some shaders in multiple games > > > > total instructions in shared

Re: [Mesa-dev] [PATCH 1/2] mesa: bump required GCC version to 4.4.0

2016-01-26 Thread Timothy Arceri
On Tue, 2016-01-26 at 14:24 -0800, Matt Turner wrote: > On Tue, Jan 26, 2016 at 2:04 PM, Timothy Arceri > wrote: > > The last time this was bumped we settled on 4.2.0 because OpenBSD > > wasn't willing to ship anything greater than 4.2.1 (as that was the > > last

[Mesa-dev] [PATCH] i965/skl: Utilize new 5th bit for gateway messages

2016-01-26 Thread Ben Widawsky
Cc: Jordan Justen Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp

Re: [Mesa-dev] [PATCH 1/2] mesa: bump required GCC version to 4.4.0

2016-01-26 Thread Dave Airlie
On 27 January 2016 at 08:04, Timothy Arceri wrote: > From: Timothy Arceri > > The last time this was bumped we settled on 4.2.0 because OpenBSD > wasn't willing to ship anything greater than 4.2.1 (as that was the > last GPLv2 licensed

Re: [Mesa-dev] [PATCH] i965/skl: Utilize new 5th bit for gateway messages

2016-01-26 Thread Chris Forbes
Might be a good idea to update the comment above the second hunk. It's very precise about which bits, and so now wrong. - Chris On Wed, Jan 27, 2016 at 12:44 PM, Ben Widawsky wrote: > Cc: Jordan Justen > Signed-off-by: Ben Widawsky

Re: [Mesa-dev] [PATCH 08/17] tgsi/ureg: add shared variables support for compute shaders

2016-01-26 Thread Marek Olšák
On Tue, Jan 26, 2016 at 9:48 PM, Ilia Mirkin wrote: > On Tue, Jan 26, 2016 at 3:23 PM, Marek Olšák wrote: >> On Tue, Jan 26, 2016 at 3:12 PM, Ilia Mirkin wrote: >>> On Tue, Jan 26, 2016 at 8:57 AM, Marek Olšák

Re: [Mesa-dev] [PATCH 08/17] tgsi/ureg: add shared variables support for compute shaders

2016-01-26 Thread Ilia Mirkin
On Tue, Jan 26, 2016 at 7:05 PM, Marek Olšák wrote: > On Tue, Jan 26, 2016 at 9:48 PM, Ilia Mirkin wrote: >> On Tue, Jan 26, 2016 at 3:23 PM, Marek Olšák wrote: >>> On Tue, Jan 26, 2016 at 3:12 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH] i965/skl: Utilize new 5th bit for gateway messages

2016-01-26 Thread Matt Turner
On Tue, Jan 26, 2016 at 3:44 PM, Ben Widawsky wrote: > Cc: Jordan Justen > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [Mesa-dev] [PATCH 1/2] mesa: bump required GCC version to 4.4.0

2016-01-26 Thread Jonathan Gray
On Tue, Jan 26, 2016 at 02:24:34PM -0800, Matt Turner wrote: > On Tue, Jan 26, 2016 at 2:04 PM, Timothy Arceri > wrote: > > The last time this was bumped we settled on 4.2.0 because OpenBSD > > wasn't willing to ship anything greater than 4.2.1 (as that was the > >

Re: [Mesa-dev] [PATCH 1/2] mesa: bump required GCC version to 4.4.0

2016-01-26 Thread Timothy Arceri
On Wed, 2016-01-27 at 11:35 +1100, Jonathan Gray wrote: > On Tue, Jan 26, 2016 at 02:24:34PM -0800, Matt Turner wrote: > > On Tue, Jan 26, 2016 at 2:04 PM, Timothy Arceri > > wrote: > > > The last time this was bumped we settled on 4.2.0 because OpenBSD > > > wasn't

Re: [Mesa-dev] [PATCH 1/2] mesa: bump required GCC version to 4.4.0

2016-01-26 Thread Ilia Mirkin
On Tue, Jan 26, 2016 at 7:35 PM, Jonathan Gray wrote: > I would be interested to hear specifics as to what post gcc 4.2.1 > extensions/changes people are interested in using. Lack of C++11 has been a bit of an annoyance in nouveau - I've been using tr1 versions of things, but

Re: [Mesa-dev] [PATCH 1/2] mesa: bump required GCC version to 4.4.0

2016-01-26 Thread Jonathan Gray
On Tue, Jan 26, 2016 at 07:51:06PM -0500, Ilia Mirkin wrote: > On Tue, Jan 26, 2016 at 7:35 PM, Jonathan Gray wrote: > > I would be interested to hear specifics as to what post gcc 4.2.1 > > extensions/changes people are interested in using. > > Lack of C++11 has been a bit of an

Re: [Mesa-dev] gallium r300 driver for PowerPC

2016-01-26 Thread Michel Dänzer
On 26.01.2016 19:15, Herminio Hernandez Jr. wrote: > Would the same thing apply swrast driver? I see glxgears trying to > fall back to it and relieving the same error. Possibly, though that's a bit weird indeed. Anyway, trace the code execution (e.g. in gdb) and see. -- Earthling Michel

[Mesa-dev] [Bug 61364] LLVM assertion when starting X11

2016-01-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61364 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED