Re: [Mesa-dev] [PATCH 11/11] program: Remove extra reference_program()

Reviewed-by: Marek Olšák Marek On Wed, Dec 16, 2015 at 12:05 AM, Miklós Máté wrote: > It was already done in get_mesa_program() > --- > src/mesa/program/ir_to_mesa.cpp | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/3] radeonsi: implement PK2H and UP2H opcodes

On 03.02.2016 18:29, Marek Olšák wrote: > On Wed, Feb 3, 2016 at 10:19 AM, Michel Dänzer wrote: >> On 03.02.2016 05:15, Marek Olšák wrote: >>> On Sat, Jan 30, 2016 at 12:46 AM, Marek Olšák wrote: From: Marek Olšák Based

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #17 from Timothy Arceri --- (In reply to Michael Harder from comment #15) > It worked for a few days but now I get this: > > [Thread debugging using libthread_db enabled] > Using host libthread_db library

Re: [Mesa-dev] [PATCH v2 07/11] gallium: add a way to store query result into buffer

On Sun, Jan 31, 2016 at 9:32 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/docs/source/context.rst | 5 + > src/gallium/include/pipe/p_context.h | 22 ++ > src/gallium/include/pipe/p_defines.h | 10

Re: [Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

I think this is not enough. Do we even have layered rendering and sample shading tests with no attachments? Marek On Sun, Jan 31, 2016 at 7:25 AM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- >

Re: [Mesa-dev] [PATCH 1/7] gallium: Add PIPE_CAP_FRAMEBUFFER_LAYERS

On 31.01.2016 15:11, Ilia Mirkin wrote: This seems odd. When would this not just be MaxArrayTextureLayers? IMO a plain enable cap, like PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENTS makes more sense here. From the GL_ARB_framebuffer_no_attachments spec overview: Additionally, this extension provides

Re: [Mesa-dev] [PATCH v2 06/11] mesa: add core implementation of ARB_query_buffer_object

On Sun, Jan 31, 2016 at 9:31 PM, Ilia Mirkin wrote: > Forwards query result writes to drivers. > > Signed-off-by: Ilia Mirkin > --- > src/mesa/main/queryobj.c | 280 > ++- > 1 file changed, 133

Re: [Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

Actually, it seems enough, but it's hard to tell without tests. Marek On Wed, Feb 3, 2016 at 10:16 AM, Marek Olšák wrote: > I think this is not enough. Do we even have layered rendering and > sample shading tests with no attachments? > > Marek > > On Sun, Jan 31, 2016 at 7:25

Re: [Mesa-dev] [PATCH 0/5] Memory info extensions

On Wed, Feb 3, 2016 at 11:01 AM, Nicolai Hähnle wrote: > On 02.02.2016 14:44, Marek Olšák wrote: >> >> Hi, >> >> The motivation behind this is to allow games that use proprietary >> extensions to query the amount of VRAM to be able to query it with Mesa too. >> Such games are

Re: [Mesa-dev] [PATCH 4/4] radeonsi: fix Hyper-Z on Stoney

On 01.02.2016 15:16, Marek Olšák wrote: On Fri, Jan 29, 2016 at 7:46 PM, Marek Olšák wrote: On Fri, Jan 29, 2016 at 4:15 PM, Nicolai Hähnle wrote: On 29.01.2016 15:02, Marek Olšák wrote: From: Marek Olšák Cc: 10.0 10.1

[Mesa-dev] [PATCH 1/2] i965: in brw_link_shader() react to low memory

Check _mesa_new_parameter_list() returned other than null. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/brw_link.cpp | 4 src/mesa/main/ff_fragment_shader.cpp | 6 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] glsl: Check for null pointer at ir_variable_refcount_visitor()

Look after calloc give memory address. Signed-off-by: Juha-Pekka Heikkila --- src/compiler/glsl/ir_variable_refcount.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compiler/glsl/ir_variable_refcount.cpp

[Mesa-dev] [PATCH 0/2] Simple Klocwork patches

I'm thinking these things maybe could be wrapped up inside something like "#ifdef windows" or so in the future. At least for Android and Linux these are normally quite useless. /Juha-Pekka Juha-Pekka Heikkila (2): i965: in brw_link_shader() react to low memory glsl: Check for null pointer at

Re: [Mesa-dev] [PATCH 4/3] mesa: use default geometry's samples when there are no attachments

Reviewed-by: Marek Olšák On Sun, Jan 31, 2016 at 7:11 AM, Ilia Mirkin wrote: > Whether multisampling is turned on depends, in part, on whether > attachments are themselves multisample surfaces. However when there are > no attachments, we should rely on

Re: [Mesa-dev] [PATCH 2/3] radeonsi: implement PK2H and UP2H opcodes

On Wed, Feb 3, 2016 at 10:19 AM, Michel Dänzer wrote: > On 03.02.2016 05:15, Marek Olšák wrote: >> On Sat, Jan 30, 2016 at 12:46 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> Based on a gallivm patch by Ilia Mirkin. >>> >>> +8

[Mesa-dev] [v3] i965: Restore vbo after color resolve during brw_try_draw_prims()

Part of brw_try_draw_prims() is a check to validate textures (brw_validate_textures()). In case of textures that currently have only level zero but are marked for mipmap generation, i965 driver will decide to replace the underlying buffer with a larger one capable of holding also the additional

Re: [Mesa-dev] [PATCH 0/5] Memory info extensions

On 02.02.2016 14:44, Marek Olšák wrote: Hi, The motivation behind this is to allow games that use proprietary extensions to query the amount of VRAM to be able to query it with Mesa too. Such games are unlikely to use GLX_MESA_query_renderer in the foreseeable feature. Unreal Engine 3 does

[Mesa-dev] [Bug 93977] Clover does not respect alignment of pointer arguments

https://bugs.freedesktop.org/show_bug.cgi?id=93977 Bug ID: 93977 Summary: Clover does not respect alignment of pointer arguments Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

I've sent a few tests to cover samples, but haven't quite been able to work out the implication of layered vs non. On Feb 3, 2016 4:18 AM, "Marek Olšák" wrote: > Actually, it seems enough, but it's hard to tell without tests. > > Marek > > On Wed, Feb 3, 2016 at 10:16 AM, Marek

[Mesa-dev] [PATCH 0/4] radeonsi: experimental support for GPUPerfStudio

Hi, this bunch of patches meets GPUPerfStudio half-way in supporting the timing features on CI+ hardware. The latest version of GPUPerfStudio is required. With these patches, GPUPerfStudio should recognize our driver as supported and offer its frame profiling features without crashing. It should

[Mesa-dev] [PATCH 3/4] radeonsi: re-order the SQ_xx performance counter blocks

From: Nicolai Hähnle This is yet another change motivated by appeasing AMD GPUPerfStudio's hardcoding of performance counter group numbers. --- src/gallium/drivers/radeon/r600_perfcounter.c | 38 --- src/gallium/drivers/radeon/r600_query.h

[Mesa-dev] [PATCH 4/4] radeonsi: add placeholder MC and SRBM performance counter groups

From: Nicolai Hähnle Yet another change motivated by AMD GPUPerfStudio compatibility. These groups are not directly accessible from userspace, and AMD GPUPerfStudio does not actually query them - it just requires them to be there. Hence, adding a placeholder for now. ---

[Mesa-dev] [PATCH 2/4] radeonsi: re-order the perfcounter hardware blocks

From: Nicolai Hähnle As documented in the comment, AMD GPUPerfStudio unfortunately hardcodes the order of performance counter groups. Let's do the pragmatic thing and present the same order as Catalyst/Crimson. --- src/gallium/drivers/radeonsi/si_perfcounter.c | 30

[Mesa-dev] [PATCH 1/4] gallium/radeon: add GPIN driver query group

From: Nicolai Hähnle This group was used by older versions of AMD GPUPerfStudio (via AMD_performance_monitor) to identify the GPU family, and GPUPerfStudio still complains when it isn't available. --- src/gallium/drivers/radeon/r600_query.c | 80

Re: [Mesa-dev] [PATCH 2/3] radeonsi: implement PK2H and UP2H opcodes

On 03.02.2016 05:15, Marek Olšák wrote: > On Sat, Jan 30, 2016 at 12:46 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> Based on a gallivm patch by Ilia Mirkin. >> >> +8 piglit regressions due to precision issues You're saying this patch causes 8 piglit

Re: [Mesa-dev] [PATCH v2 09/11] st/mesa: use the occlusion predicate query for GL_ANY_SAMPLES

On Sun, Jan 31, 2016 at 9:56 PM, Ilia Mirkin wrote: > On Sun, Jan 31, 2016 at 3:32 PM, Ilia Mirkin wrote: >> This is supposed to return GL_TRUE or GL_FALSE, not the full counter >> value. >> >> Signed-off-by: Ilia Mirkin >> --- >

Re: [Mesa-dev] [PATCH v2] nv50: avoid freeing the symbols if they're about to be stored

On Wed, Feb 3, 2016 at 3:47 PM, Samuel Pitoiset wrote: > > > On 02/03/2016 08:00 PM, Ilia Mirkin wrote: >> >> Spotted by Coverity >> >> Signed-off-by: Ilia Mirkin >> --- >> >> v1 -> v2: forgot to remove the original free... >> >>

[Mesa-dev] [PATCH] mesa: Use SSE prefetch instructions rather than 3DNow instructions

From: Patrick Baggett 64-bit Pentium 4 CPUs don't have the 3DNow prefetch instructions which results in an Illegal instruction crash. Cc: Roland Scheidegger Tested-by: Timothy Arceri

Re: [Mesa-dev] [PATCH] st/mesa: fix potential null deref if no shader is passed in

Reviewed-by: Samuel Pitoiset On 02/03/2016 07:53 PM, Ilia Mirkin wrote: Spotted by Coverity Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_atom_storagebuf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 05/11] [RFC] mesa: allow binding framebuffer without depth

On 02/01/2016 03:51 PM, Miklós Máté wrote: On 12/19/2015 12:24 AM, Marek Olšák wrote: On Fri, Dec 18, 2015 at 11:45 PM, Miklós Máté wrote: On 12/17/2015 01:06 PM, Marek Olšák wrote: On Wed, Dec 16, 2015 at 11:30 PM, Miklós Máté wrote: On

Re: [Mesa-dev] [PATCH v2] nv50: avoid freeing the symbols if they're about to be stored

On 02/03/2016 09:55 PM, Ilia Mirkin wrote: On Wed, Feb 3, 2016 at 3:47 PM, Samuel Pitoiset wrote: On 02/03/2016 08:00 PM, Ilia Mirkin wrote: Spotted by Coverity Signed-off-by: Ilia Mirkin --- v1 -> v2: forgot to remove the original

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #19 from Timothy Arceri --- (In reply to Roland Scheidegger from comment #18) > > That doesn't make sense to me. The offset is just part of the memory > operand. Unless the assembler encodes it wrong I can't

[Mesa-dev] [Bug 92869] OpenGL ES 3.0 context creation failure

https://bugs.freedesktop.org/show_bug.cgi?id=92869 --- Comment #5 from Ilia Mirkin --- To be clear, an Xorg patch is also necessary: http://cgit.freedesktop.org/xorg/xserver/commit/?id=bc415fb1e0031ad23bda6e9c3f4664532876a0e5 It appears to be included in the 1.18 backport

Re: [Mesa-dev] [PATCH v2] nv50: avoid freeing the symbols if they're about to be stored

On 02/03/2016 08:00 PM, Ilia Mirkin wrote: Spotted by Coverity Signed-off-by: Ilia Mirkin --- v1 -> v2: forgot to remove the original free... src/gallium/drivers/nouveau/nv50/nv50_program.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: Use SSE prefetch instructions rather than 3DNow instructions

I don't see much point in replacing the ones in the _mesa_3dnow_xx functions, but I suppose it's better than missing some, and it shouldn't hurt neither. (There are 3dnow capable cpus not supporting prefetcht1 but supporting prefetch, but there aren't any x64_64 cpus not supporting prefetcht1, so

Re: [Mesa-dev] [PATCH 0/4] radeonsi: experimental support for GPUPerfStudio

Can't see any serious issues here and a non-verified `working' instance of GPUPerfStudio is sure better than a crashing one! This series is, Reviewed-by: Edward O'Callaghan On 2016-02-04 00:52, Nicolai Hähnle wrote: Hi, this bunch of patches meets

[Mesa-dev] [Bug 92869] OpenGL ES 3.0 context creation failure

https://bugs.freedesktop.org/show_bug.cgi?id=92869 Jose Fonseca changed: What|Removed |Added CC||imir...@alum.mit.edu

[Mesa-dev] [PATCH 00/65] ARB_internalformat_query2 support for Mesa and i965

Hi, This is a patch series adding support for the ARB_internalformat-query2 extension: https://www.opengl.org/registry/specs/ARB/internalformat_query2.txt The corresponding bug is being tracked at: https://bugs.freedesktop.org/show_bug.cgi?id=92687 The patch-set is structured as follows: *

Re: [Mesa-dev] [PATCH v2 09/11] st/mesa: use the occlusion predicate query for GL_ANY_SAMPLES

On Wed, Feb 3, 2016 at 5:11 AM, Marek Olšák wrote: > On Sun, Jan 31, 2016 at 9:56 PM, Ilia Mirkin wrote: >> On Sun, Jan 31, 2016 at 3:32 PM, Ilia Mirkin wrote: >>> This is supposed to return GL_TRUE or GL_FALSE, not the full counter

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

Hi Juha, I don't know why checking for this might be more relevant in Windows, but in any case: There are a ton of other places in mesa where we allocate memory via calloc/malloc and we don't check that the allocation actually succeeded so I am not sure that fixing a couple of instances of

[Mesa-dev] [PATCH v3] glx: update to updated version of EXT_create_context_es2_profile

The EXT spec has been updated to: - logically combine the es2_profile and es_profile exts - allow any legal version to be requested dEQP tests request a specific ES version when using GLX, so this allows dEQP upstream to run against GLX with the appropriate X server patch (which had similar

Re: [Mesa-dev] [PATCH v3] glx: update to updated version of EXT_create_context_es2_profile

On Wed, 2016-02-03 at 09:52 -0500, Ilia Mirkin wrote: > The EXT spec has been updated to: >  - logically combine the es2_profile and es_profile exts >  - allow any legal version to be requested > > dEQP tests request a specific ES version when using GLX, so this allows > dEQP upstream to run

Re: [Mesa-dev] [PATCH 1/2] virgl: reuse screen when fd is already open

On 2 February 2016 at 17:55, Rob Clark wrote: > On Tue, Feb 2, 2016 at 12:13 PM, Emil Velikov > wrote: >> On 31 January 2016 at 19:40, Rob Clark wrote: >>> On Sun, Jan 31, 2016 at 6:18 AM, Emil Velikov

Re: [Mesa-dev] [PATCH] radeonsi: Dump LLVM IR before optimization passes

Reviewed-by: Edward O'Callaghan On 2016-02-04 13:28, Michel Dänzer wrote: From: Michel Dänzer Otherwise it's not possible to diagnose problems caused by optimization passes. Signed-off-by: Michel Dänzer ---

Re: [Mesa-dev] [PATCH] radeonsi: Dump LLVM IR before optimization passes

On 04.02.2016 11:28, Michel Dänzer wrote: > From: Michel Dänzer > > Otherwise it's not possible to diagnose problems caused by optimization > passes. Unfortunately, this also seems to dump before some transformation passes which are necessary for the dumped IR to be

[Mesa-dev] [PATCH] glsl: simplify setting of image access qualifiers

Cc: Francisco Jerez --- src/compiler/glsl/link_uniforms.cpp | 73 - 1 file changed, 16 insertions(+), 57 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index da39941..fc46ba2 100644

[Mesa-dev] [PATCH] radeonsi: Dump LLVM IR before optimization passes

From: Michel Dänzer Otherwise it's not possible to diagnose problems caused by optimization passes. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 20 ++-- 1 file changed, 14 insertions(+), 6

[Mesa-dev] [PATCH 24/65] mesa/formatquery: Added INTERNALFORMAT_PREFERRED pname

--- src/mesa/main/formatquery.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 73eeba4..39ac07e 100644 --- a/src/mesa/main/formatquery.c +++ b/src/mesa/main/formatquery.c @@ -577,6 +577,10 @@

[Mesa-dev] [PATCH 25/65] mesa/main: Make legal_get_tex_level_parameter_target public

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to check if the target is valid for those that are said in the spec that should return the same values than the 'glGetTexLevelParameter{if}v' function: - INTERNALFORMAT_RED_SIZE -

[Mesa-dev] [PATCH 23/65] mesa/formatquery: Added the INTERNALFORMAT_SUPPORTED query

From: Antia Puentes --- src/mesa/main/formatquery.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 4ce1709..73eeba4 100644 --- a/src/mesa/main/formatquery.c +++

[Mesa-dev] [PATCH 22/65] mesa/formatquery: Added a func to check supported

From: Antia Puentes From the ARB_internalformat_query2 specification: "The INTERNALFORMAT_SUPPORTED can be used to determine if the internal format is supported, and the other are defined in terms of whether or not the format is supported." ---

[Mesa-dev] [PATCH 15/65] mesa/formatquery: Added boilerplate code to extend GetInternalformativ

From: Antia Puentes The goal is to extend the GetInternalformativ query to implement the ARB_internalformat_query2 specification, keeping the behaviour defined by the ARB_internalformat_query if ARB_internalformat_query2 is not supported. --- src/mesa/main/formatquery.c |

[Mesa-dev] [PATCH 11/65] mesa/main: Add extension tracking bit for ARB_internalformat_query2

From: Antia Puentes --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index ad5dc60..dc6dbe4 100644 ---

[Mesa-dev] [PATCH 16/65] mesa: Add dispatch and extension XML for GL_ARB_internalformat_query2

From: Alejandro Piñeiro Equivalent to commit bda540 (that added GL_ARB_internalformat_query) v2: include the new xml to to API_XML list at Makefile.am (Emil Velikov) --- src/mapi/glapi/gen/ARB_internalformat_query2.xml | 119 +++

[Mesa-dev] [PATCH 19/65] mesa/teximage: Make _mesa_format_no_online_compression public

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to check if a certain compressed 'internalformat' is supported by texture 'targets'. --- src/mesa/main/teximage.c | 2 +- src/mesa/main/teximage.h | 3 +++ 2 files changed, 4 insertions(+),

[Mesa-dev] [PATCH 14/65] mesa/formatquery: Added a func to check if the is supported

From: Antia Puentes From the ARB_internalformat_query2 spec: "If the particular and combination do not make sense, or if a particular type of is not supported by the implementation the "unsupported" answer should be given. This is not an error." This function

[Mesa-dev] [PATCH 04/65] i965: Move brw_query_samples_for_format() to brw_queryformat.c

Now that there is a dedicated source file for internal format queries, this function belongs there. --- src/mesa/drivers/dri/i965/brw_context.c | 38 src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_formatquery.c | 39

[Mesa-dev] [PATCH 18/65] mesa/teximage: make public is_renderable_texture_format

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to check if the 'internalformat' passed is supported by texture MULTISAMPLE 'targets'. --- src/mesa/main/teximage.c | 6 +++--- src/mesa/main/teximage.h | 3 +++ 2 files changed, 6

[Mesa-dev] [PATCH 10/65] mesa: Completely remove QuerySamplesForFormat from driver func table

At this point, all uses have been replaced by the more general hook QueryInternalFormat, introduced by ARB_internalformat_query2. --- src/mesa/drivers/common/driverfuncs.c | 1 - src/mesa/main/dd.h| 18 -- src/mesa/main/formatquery.c | 14

[Mesa-dev] [PATCH 17/65] mesa/main: Added empty skeleton of glGetInternalformati64v

From: Antia Puentes --- src/mesa/main/formatquery.c | 16 src/mesa/main/formatquery.h | 4 2 files changed, 20 insertions(+) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index b64469b..60cbb90 100644 ---

[Mesa-dev] [PATCH 07/65] mesa/multisample: Check sample count using the new driver hook

Use QueryInternalFormat instead of QuerySamplesForFormat to obtain the highest supported sample. QuerySamplesForFormat is to be removed. --- src/mesa/main/multisample.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/multisample.c

[Mesa-dev] [PATCH v2 63/65] mesa/glformats: Consider DEPTH/STENCIL when resolving a mesa_format

_mesa_format_from_format_and_type() is currently not considering DEPTH and STENCIL formats, which are not array formats and are not handled anywhere. This patch adds cases for common combinations of DEPTH/STENCIL format and types. --- src/mesa/main/glformats.c | 21 + 1 file

[Mesa-dev] [PATCH 62/65] mesa/formatquery: Add (GET_)TEXTURE_IMAGE_TYPE pnames

These basically reuse the default implementation of GL_READ_PIXELS_TYPE. --- src/mesa/main/formatquery.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index d378d1d..953d2a0 100644 ---

[Mesa-dev] [PATCH 49/65] mesa/formatquery: Added simultaneous texture and depth/stencil queries

From: Antia Puentes From the ARB_internalformat_query2 specification: "- SIMULTANEOUS_TEXTURE_AND_DEPTH_TEST: The support for using the resource both as a source for texture sampling while it is bound as a buffer for depth test is written to . For example, a

[Mesa-dev] [PATCH 61/65] mesa/formatquery: Add (GET_)TEXTURE_IMAGE_FORMAT pnames

--- src/mesa/main/formatquery.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 0b09c70..d378d1d 100644 --- a/src/mesa/main/formatquery.c +++ b/src/mesa/main/formatquery.c @@ -649,6

[Mesa-dev] [PATCH 45/65] mesa/shaderimage: Make is_image_format_supported public

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to implement queries related to the ARB_shader_image_load_store extension. --- src/mesa/main/shaderimage.c | 13 + src/mesa/main/shaderimage.h | 8 2 files changed, 13

[Mesa-dev] [PATCH 58/65] mesa/formatquery: Add support for READ_PIXELS query

This is supported since very early version of OpenGL, but we still call the driver to give it the opportunity to report caveat or no support. --- src/mesa/main/formatquery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/formatquery.c

[Mesa-dev] [PATCH 39/65] mesa/formatquery: Added mipmap related queries

From: Antia Puentes Specifically MIPMAP, MANUAL_GENERATE_MIPMAP and AUTO_GENERATE_MIPMAP queries. From the ARB_internalformat_query2 specification: "- MIPMAP: If the resource supports mipmaps, TRUE is returned in . If the resource is not supported, or if mipmaps

[Mesa-dev] [PATCH 35/65] mesa/formatquery: Added {COLOR, DEPTH, STENCIL}_COMPONENTS queries

From: Antia Puentes --- src/mesa/main/formatquery.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 571af91..966d210 100644 --- a/src/mesa/main/formatquery.c

[Mesa-dev] [PATCH 47/65] mesa/shaderimage: Added func to get the GL_IMAGE_CLASS from the format

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to implement the IMAGE_COMPATIBILITY_CLASS query. --- src/mesa/main/shaderimage.c | 45 + src/mesa/main/shaderimage.h | 6 ++ 2 files

[Mesa-dev] [PATCH 48/65] mesa/formatquery: Added queries related to image textures

From: Antia Puentes From the ARB_internalformat_query2 specification: "- IMAGE_TEXEL_SIZE: The size of a texel when the resource when used as an image texture is returned in . This is the value from the /Size/ column in Table 3.22. If the resource is not

[Mesa-dev] [PATCH 50/65] mesa/formatquery: Added compressed texture related queries

From: Antia Puentes From the ARB_internalformat_query2 specification: "- TEXTURE_COMPRESSED: If is a compressed format that is supported for this type of resource, TRUE is returned in . If the internal format is not compressed, or the type of resource

[Mesa-dev] [PATCH 53/65] mesa/formatquery: Added texture view related queries

From: Antia Puentes From the ARB_internalformat_query2 specification: "- TEXTURE_VIEW: The support for using the resource with the TextureView command is returned in . Possible values returned are FULL_SUPPORT, CAVEAT_SUPPORT, or NONE. If the resource

[Mesa-dev] [PATCH 51/65] mesa/formatquery: Added CLEAR_BUFFER query

From: Antia Puentes From the ARB_internalformat_query2 specification: "- CLEAR_BUFFER: The support for using the resource with ClearBuffer*Data commands is returned in . Possible values returned are FULL_SUPPORT, CAVEAT_SUPPORT, or NONE. If the resource

[Mesa-dev] [PATCH 55/65] mesa/formatquery: Added framebuffer renderability related queries

From: Antia Puentes From the ARB_internalformat_query2 specification: "- FRAMEBUFFER_RENDERABLE: The support for rendering to the resource via framebuffer attachment is returned in . - FRAMEBUFFER_RENDERABLE_LAYERED: The support for layered rendering to

[Mesa-dev] [PATCH 46/65] mesa/formatquery: Added SHADER_IMAGE_{LOAD, STORE, ATOMIC} queries

From: Antia Puentes From the ARB_internalformat_query2 specification: "- SHADER_IMAGE_LOAD: The support for using the resource with image load operations in shaders is written to . In this case the is the value of the parameter that would be passed

[Mesa-dev] [PATCH 57/65] mesa/formatquery: added FILTER pname support

From: Alejandro Piñeiro It discards out the targets and internalformats that explicitly mention (per-spec) that doesn't support filter types other than NEAREST or NEAREST_MIPMAP_NEAREST. Those are: * Texture buffers target * Multisample targets * Any integer

[Mesa-dev] [PATCH 52/65] mesa/textureview: Make _lookup_view_class public

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to implement the VIEW_COMPATIBILITY_CLASS query. --- src/mesa/main/textureview.c | 12 src/mesa/main/textureview.h | 8 2 files changed, 12 insertions(+), 8

[Mesa-dev] [PATCH 43/65] mesa/formatquery: Added SRGB_DECODE_ARB query

From: Antia Puentes From the ARB_internalformat_query2 specification: "- SRGB_DECODE_ARB: The support for toggling whether sRGB decode happens at sampling time (see EXT/ARB_texture_sRGB_decode) for the resource is returned in . Possible values returned

[Mesa-dev] [PATCH 26/65] mesa/main: Extend _mesa_base_format_has_channel to accept new pnames

From: Antia Puentes The new pnames accepted by the function are: - INTERNALFORMAT_RED_SIZE - INTERNALFORMAT_GREEN_SIZE - INTERNALFORMAT_BLUE_SIZE - INTERNALFORMAT_ALPHA_SIZE - INTERNALFORMAT_DEPTH_SIZE -

[Mesa-dev] [PATCH 12/65] mesa/formatquery: Added function to validate parameters

From: Antia Puentes Handles the cases where an error should be returned according to the ARB_internalformat_query and ARB_internalformat_query2 specifications. --- src/mesa/main/formatquery.c | 227 1 file changed, 227

[Mesa-dev] [PATCH 20/65] mesa/main: not fill mesa_error on _mesa_legal_texture_base_format_for_target

From: Alejandro Piñeiro This would allow to use this method if you are just querying if it is allowed, like for arb_internalformat_query2. --- src/mesa/main/teximage.c | 18 +- src/mesa/main/teximage.h | 4 +--- src/mesa/main/texstorage.c | 8

Re: [Mesa-dev] [PATCH 63/65] mesa/glformats: Consider DEPTH/STENCIL when resolving a mesa_format

On Wed, Feb 3, 2016 at 10:45 AM, Eduardo Lima Mitev wrote: > _mesa_format_from_format_and_type() is currently not considering DEPTH and > STENCIL formats, which are not array formats and are not handled anywhere. > > This patch adds cases for common combinations of DEPTH/STENCIL

Re: [Mesa-dev] [PATCH v2 07/11] gallium: add a way to store query result into buffer

On Wed, Feb 3, 2016 at 5:07 AM, Marek Olšák wrote: > On Sun, Jan 31, 2016 at 9:32 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> src/gallium/docs/source/context.rst | 5 + >>

[Mesa-dev] [PATCH 32/65] main/formatquery: support for MAX_{WIDTH/HEIGHT/DEPTH/LAYERS}

From: Alejandro Piñeiro Implemented by calling GetIntegerv with the equivalent pname and handling individually the exceptions related to dimensions. All those pnames are used to get the maximum value for each dimension of the given target. The only difference between this

[Mesa-dev] [PATCH 28/65] mesa/formatquery: Added INTERNALFORMAT_{X}_{SIZE, TYPE} queries

From: Antia Puentes From the ARB_internalformat_query2 spec: "- INTERNALFORMAT_RED_SIZE - INTERNALFORMAT_GREEN_SIZE - INTERNALFORMAT_BLUE_SIZE - INTERNALFORMAT_ALPHA_SIZE - INTERNALFORMAT_DEPTH_SIZE - INTERNALFORMAT_STENCIL_SIZE -

[Mesa-dev] [PATCH 40/65] mesa/glformats: Add a helper function _mesa_is_srgb_format()

Returns true if the passed format is an sRGB format, false otherwise. --- src/mesa/main/glformats.c | 45 + src/mesa/main/glformats.h | 3 +++ 2 files changed, 48 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index

[Mesa-dev] [PATCH 38/65] mesa/genmipmap: Added a function to validate the internalformat

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to implement mipmap related queries. --- src/mesa/main/genmipmap.c | 16 src/mesa/main/genmipmap.h | 3 +++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 31/65] mesa/formatquery: support for IMAGE_FORMAT_COMPATIBILITY_TYPE

From: Alejandro Piñeiro From arb_internalformat_query2 spec: "IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the resource when used as an image textures is returned in . This is equivalent to calling GetTexParameter with set to

[Mesa-dev] [PATCH 37/65] mesa/genmipmap: Added a function to check if the target is valid

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to implement mipmap related queries. --- src/mesa/main/genmipmap.c | 34 +- src/mesa/main/genmipmap.h | 3 +++ 2 files changed, 24 insertions(+), 13

[Mesa-dev] [PATCH 33/65] mesa/teximage: add _mesa_is_cube_map_texture utility method

--- src/mesa/main/teximage.c | 18 ++ src/mesa/main/teximage.h | 4 2 files changed, 22 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 250d758..4cca396 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -256,6

[Mesa-dev] [PATCH 41/65] mesa/formatquery: Added COLOR_ENCODING query.

From: Antia Puentes From the ARB_internalformat_query2 specification: "- COLOR_ENCODING: The color encoding for the resource is returned in . Possible values for color buffers are LINEAR or SRGB, for linear or sRGB-encoded color components, respectively. For

[Mesa-dev] [PATCH 30/65] mesa/formatquery: handle unmodified buffer for SAMPLES on the 64-bit query

From: Alejandro Piñeiro From arb_internalformat_query2 spec: " If is not color-renderable, depth-renderable, or stencil-renderable (as defined in section 4.4.4), or if does not support multiple samples (ie other than TEXTURE_2D_MULTISAMPLE,

[Mesa-dev] [PATCH 29/65] mesa/formatquery: initial implementation for GetInternalformati64v

From: Alejandro Piñeiro It just does a wrapping on the existing 32-bit GetInternalformativ. We will maintain the 32-bit query as default as it is likely that it would be the one most used. --- src/mesa/main/formatquery.c | 8 +++- 1 file changed, 7 insertions(+), 1

[Mesa-dev] [PATCH 27/65] mesa/main: Extend _mesa_get_format_bits to accept new pnames

From: Antia Puentes The new pnames accepted by the function are: - INTERNALFORMAT_RED_SIZE - INTERNALFORMAT_GREEN_SIZE - INTERNALFORMAT_BLUE_SIZE - INTERNALFORMAT_ALPHA_SIZE - INTERNALFORMAT_DEPTH_SIZE -

[Mesa-dev] [PATCH 21/65] mesa/formatquery: Added func to check if the 'resource' is supported

From: Antia Puentes Checks that the 'resource', as defined by the ARB_internalformat_query2 specification, is supported by the implementation for those 'pnames' that require this check. --- src/mesa/main/formatquery.c | 91 - 1

[Mesa-dev] [PATCH 34/65] mesa/formatquery: support for MAX_COMBINED_DIMENSIONS

From: Alejandro Piñeiro It is implemented combining the values returned by calls to the 32-bit query _mesa_GetInternalformati32v. The main reason is simplicity. The other option would be C how we implemented the support of GL_MAX_{WIDTH/HEIGHT/DEPTH} and GL_SAMPLES.

[Mesa-dev] [PATCH 36/65] mesa/formatquery: Added {COLOR, DEPTH, STENCIL}_RENDERABLE queries

From: Antia Puentes --- src/mesa/main/formatquery.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 966d210..8b523a0 100644 --- a/src/mesa/main/formatquery.c +++

Re: [Mesa-dev] [PATCH 7/7] radeonsi: Enable ARB_framebuffer_no_attachments

On Wed, Feb 3, 2016 at 1:09 PM, Ilia Mirkin wrote: > I've sent a few tests to cover samples, but haven't quite been able to work > out the implication of layered vs non. I guess the main thing is to assure that primitives with gl_Layer >= 0 aren't discarded by the

Re: [Mesa-dev] [PATCH 2/3] radeonsi: implement PK2H and UP2H opcodes

Am 03.02.2016 um 10:38 schrieb Michel Dänzer: > On 03.02.2016 18:29, Marek Olšák wrote: >> On Wed, Feb 3, 2016 at 10:19 AM, Michel Dänzer wrote: >>> On 03.02.2016 05:15, Marek Olšák wrote: On Sat, Jan 30, 2016 at 12:46 AM, Marek Olšák wrote: > From:

  1   2   >