[Mesa-dev] [PATCH v2] workarounds: Update workaround names and platforms

Update the format in which workarounds are documented in the source code. This allows mesa to be parsed by the list-workarounds utility in intel-gpu-tools. Signed-off-by: Sameer Kibey --- changed byt to vlv for consistency. src/mesa/drivers/dri/i965/brw_binding_tables.c

Re: [Mesa-dev] [PATCH] meta: Fix the pbo usage in meta for GLES{1, 2} contexts

On Fri, Feb 5, 2016 at 11:30 AM, Ian Romanick wrote: > > On 12/24/2015 01:04 PM, Anuj Phogat wrote: > > OpenGL ES 1.0 doesn't support using GL_STREAM_DRAW and both > > ES 1.0 and 2.0 don't support GL_STREAM_READ in glBufferData(). > > So, handle it correctly by calling the

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On Fri, Feb 5, 2016 at 1:11 PM, Miklós Máté wrote: > v2: fix arithmetic for special opcodes > (based on comments from Marek and Ilia), > fix fog state, cleanup > --- > src/mesa/Makefile.sources | 1 + > src/mesa/program/program.h| 2 + >

Re: [Mesa-dev] [PATCH 1/4] tgsi: break gigantic tgsi_scan_shader() function into pieces

This series is, Reviewed-by: Edward O'Callaghan On 2016-02-06 11:56, Brian Paul wrote: New functions for examining instructions, declarations, etc. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 739 + 1 file changed, 375

[Mesa-dev] [PATCH] mesa/extensions: Fix NVX_gpu_memory_info lexicographical order.

Fixes MesaExtensionsTest.AlphabeticallySorted. Fixes: 1d79b9958090 ("mesa: implement GL_NVX_gpu_memory_info (v2)") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94016 Signed-off-by: Vinson Lee --- src/mesa/main/extensions_table.h | 3 ++- 1 file changed, 2

Re: [Mesa-dev] [PATCH v2 6/9] radeonsi: Enable ARB_framebuffer_no_attachments

On Fri, Feb 5, 2016 at 12:44 PM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/3] radeon/llvm: Set the target triple on the module

On Thu, Feb 04, 2016 at 02:42:15PM -0800, Matt Arsenault wrote: > > > On Feb 4, 2016, at 13:02, Tom Stellard wrote: > > > > + LLVMSetTarget(ctx->gallivm.module, > > + > > +#if HAVE_LLVM < 0x0306 > > + "r600--"); > > +#else > > +

Re: [Mesa-dev] [Piglit] [PATCH] Add (un)packHalf tests which don't fail on GCN

On Fri, Feb 5, 2016 at 3:56 PM, Roland Scheidegger wrote: > Am 05.02.2016 um 15:44 schrieb Marek Olšák: >> On Fri, Feb 5, 2016 at 10:57 AM, Marek Olšák wrote: >>> On Fri, Feb 5, 2016 at 1:55 AM, Matt Turner wrote: On Thu, Feb 4,

Re: [Mesa-dev] [PATCH v2 3/9] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

On Fri, Feb 5, 2016 at 12:44 PM, Edward O'Callaghan wrote: > Here we store the number of samples and layers directly in the > pipe_framebuffer_state so that in the case of > ARB_framebuffer_no_attachment we may make use of them directly. > > Further, we adjust

Re: [Mesa-dev] [Piglit] [PATCH] Add (un)packHalf tests which don't fail on GCN

On Fri, Feb 5, 2016 at 10:48 AM, Roland Scheidegger wrote: > But I think you're right glsl shouldn't require them (albeit it is > pretty silent on that topic as far as I can tell - certainly doesn't > require them for fp32). Perhaps it doesn't require them, but at least

Re: [Mesa-dev] [PATCH v2 6/9] radeonsi: Enable ARB_framebuffer_no_attachments

On Fri, Feb 5, 2016 at 5:46 PM, Ilia Mirkin wrote: > On Fri, Feb 5, 2016 at 11:43 AM, Marek Olšák wrote: >> On Fri, Feb 5, 2016 at 12:44 PM, Edward O'Callaghan >> wrote: >>> Signed-off-by: Edward O'Callaghan

[Mesa-dev] [PATCH 1/1] r600g: Ignore format for PIPE_BUFFER targets

Fixes compute since 7dd31b81fee7fe40bd09cf3fbc324fcc32782479 gallium/radeon: support PIPE_CAP_SURFACE_REINTERPRET_BLOCKS Signed-off-by: Jan Vesely --- src/gallium/drivers/radeon/r600_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v2 3/9] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

On Fri, Feb 5, 2016 at 6:44 AM, Edward O'Callaghan wrote: > Here we store the number of samples and layers directly in the > pipe_framebuffer_state so that in the case of > ARB_framebuffer_no_attachment we may make use of them directly. > > Further, we adjust various

Re: [Mesa-dev] [PATCH v2 1/9] gallium: Add PIPE_CAP_FRAMEBUFFER_LAYERS

So... it seems like you've rejected all the feedback that you received, at least on patches 1 and 3. Any explanation for that? Pretty sure some of the things I pointed out were legitimate. On Fri, Feb 5, 2016 at 6:44 AM, Edward O'Callaghan wrote: > Add PIPE_CAP to

Re: [Mesa-dev] [PATCH 4/4] st/mesa: enable AoA for gallium drivers reporting GLSL 1.30

Hey Dave, can you mention Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92059 A large part of the problems with Middle-earth: Shadow of Mordor stem from radeonsi not having AoA, which should be fixed by this, right? Cheers, Kai Dave Airlie wrote on 05.02.2016 04:40: > From: Dave

Re: [Mesa-dev] [Piglit] [PATCH] Add (un)packHalf tests which don't fail on GCN

Am 05.02.2016 um 15:44 schrieb Marek Olšák: > On Fri, Feb 5, 2016 at 10:57 AM, Marek Olšák wrote: >> On Fri, Feb 5, 2016 at 1:55 AM, Matt Turner wrote: >>> On Thu, Feb 4, 2016 at 10:50 AM, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH v2 1/9] gallium: Add PIPE_CAP_FRAMEBUFFER_LAYERS

On 02/05/2016 04:44 AM, Edward O'Callaghan wrote: Add PIPE_CAP to determine the number of layers for a framebuffer for GL_ARB_framebuffer_no_attachments. Signed-off-by: Edward O'Callaghan --- src/gallium/docs/source/screen.rst | 2 ++

Re: [Mesa-dev] [Piglit] [PATCH] Add (un)packHalf tests which don't fail on GCN

Am 05.02.2016 um 16:08 schrieb Marek Olšák: > On Fri, Feb 5, 2016 at 3:56 PM, Roland Scheidegger wrote: >> Am 05.02.2016 um 15:44 schrieb Marek Olšák: >>> On Fri, Feb 5, 2016 at 10:57 AM, Marek Olšák wrote: On Fri, Feb 5, 2016 at 1:55 AM, Matt Turner

Re: [Mesa-dev] [PATCH v2 9/9] GL3.txt: Mark ARB_framebuffer_no_attachments as done

Please update the release notes as well. Marek On Fri, Feb 5, 2016 at 12:44 PM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > docs/GL3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [Piglit] [PATCH] Add (un)packHalf tests which don't fail on GCN

On Fri, Feb 5, 2016 at 4:48 PM, Roland Scheidegger wrote: > Am 05.02.2016 um 16:08 schrieb Marek Olšák: >> On Fri, Feb 5, 2016 at 3:56 PM, Roland Scheidegger >> wrote: >>> Am 05.02.2016 um 15:44 schrieb Marek Olšák: On Fri, Feb 5, 2016 at 10:57 AM,

Re: [Mesa-dev] [Piglit] [PATCH] Add (un)packHalf tests which don't fail on GCN

Am 05.02.2016 um 17:04 schrieb Marek Olšák: > On Fri, Feb 5, 2016 at 4:48 PM, Roland Scheidegger wrote: >> Am 05.02.2016 um 16:08 schrieb Marek Olšák: >>> On Fri, Feb 5, 2016 at 3:56 PM, Roland Scheidegger >>> wrote: Am 05.02.2016 um 15:44 schrieb

Re: [Mesa-dev] [PATCH 1/1] r600g: Ignore format for PIPE_BUFFER targets

Pushed, thanks. Marek On Fri, Feb 5, 2016 at 6:01 PM, Jan Vesely wrote: > Fixes compute since 7dd31b81fee7fe40bd09cf3fbc324fcc32782479 > gallium/radeon: support PIPE_CAP_SURFACE_REINTERPRET_BLOCKS > > Signed-off-by: Jan Vesely > --- >

[Mesa-dev] [PATCH 06/18] radeonsi: implement forcing per-sample_interpolation using the shader key only

From: Marek Olšák It was partly a state and partly emulated by shader code, but since we want to do this in a fragment shader prolog, we need to put it into the shader key, which will be used to generate the prolog. This also removes the spi_ps_input states and moves the

[Mesa-dev] [PATCH 08/18] radeonsi: don't force gl_SampleMaskIn to 1 for smoothing

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index d9006bc..68ce387 100644 ---

[Mesa-dev] [PATCH 05/18] radeonsi: remove si_shader::ps_input_interpolate

From: Marek Olšák tgsi_shader_info has this too. --- src/gallium/drivers/radeonsi/si_shader.c | 8 +++- src/gallium/drivers/radeonsi/si_shader.h | 1 - 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 07/18] radeonsi: split PS input interpolation code into its own function

From: Marek Olšák This will be used by the fragment shader prolog. --- src/gallium/drivers/radeonsi/si_shader.c | 127 +-- 1 file changed, 71 insertions(+), 56 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 12/18] radeonsi: remove useless code that handles dx10_clamp_mode

From: Marek Olšák "enable-no-nans-fp-math" is a wrong string and there was a disagreement about fixing it. --- src/gallium/drivers/radeonsi/si_shader.c| 7 --- src/gallium/drivers/radeonsi/si_shader.h| 1 -

[Mesa-dev] [PATCH 10/18] radeonsi: dump SPI_PS_INPUT values along with shader stats

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 85203e0..bd45d4a 100644 ---

[Mesa-dev] [PATCH 01/18] radeonsi: move si_shader_context initialization into a separate function

From: Marek Olšák This will be re-used later. --- src/gallium/drivers/radeonsi/si_shader.c | 103 ++- 1 file changed, 60 insertions(+), 43 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 04/18] radeonsi: move BCOLOR PS input locations after all other inputs

From: Marek Olšák BCOLOR inputs were immediately after COLOR inputs. Thus, all following inputs were offset by 1 if color_two_side was enabled, and not offset if it was not enabled, which is a variation that's problematic if we want to have 1 variant per shader and the

[Mesa-dev] [PATCH 03/18] radeonsi: move SPI_PS_INPUT_CNTL value computation to a separate function

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 74 + 1 file changed, 40 insertions(+), 34 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index

[Mesa-dev] [PATCH 00/18] RadeonSI: Restructuring shader codegen part 3

Hi, This is the last part of restructuring needed for having one shader variant per shader. Summary: - a lot of changes are about PS inputs and interpolation - code movements, cleanups Behavior changes: - removed unnecessary MRT_NULL exports - geometry shaders aren't compiled on demand Please

Re: [Mesa-dev] [PATCH] list-workarounds: Extend the script to Mesa

> -Original Message- > From: Lespiau, Damien > Sent: Friday, February 05, 2016 4:16 AM > To: Kibey, Sameer > Cc: intel-...@lists.freedesktop.org; mesa-dev@lists.freedesktop.org; Sharp, > Sarah A; Widawsky, Benjamin > Subject: Re: [PATCH] list-workarounds: Extend the script to Mesa > > On

Re: [Mesa-dev] [PATCH v2 5/9] mesa/st: Update framebuffer state with no.of samples, layers

On Fri, Feb 5, 2016 at 6:44 AM, Edward O'Callaghan wrote: > Handle the case of ARB_framebuffer_no_attachment. > Also, kill off a dead debug printf() call while we are here. > > Signed-off-by: Edward O'Callaghan > Reviewed-by: Ilia

Re: [Mesa-dev] [Piglit] [PATCH] Add (un)packHalf tests which don't fail on GCN

On Fri, Feb 5, 2016 at 7:11 PM, Roland Scheidegger wrote: > Am 05.02.2016 um 17:04 schrieb Marek Olšák: >> On Fri, Feb 5, 2016 at 4:48 PM, Roland Scheidegger >> wrote: >>> Am 05.02.2016 um 16:08 schrieb Marek Olšák: On Fri, Feb 5, 2016 at 3:56 PM,

[Mesa-dev] [PATCH 16/18] radeonsi: split out code for deleting si_shader

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 65 ++--- 1 file changed, 36 insertions(+), 29 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index

[Mesa-dev] [PATCH 15/18] radeonsi: move code writing tess factors into a separate function

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 6379ba4..0f10460

[Mesa-dev] [PATCH 11/18] radeonsi: don't emit unnecessary NULL exports for unbound targets

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 63 +--- 1 file changed, 50 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index bd45d4a..18e4ab9

[Mesa-dev] [PATCH 09/18] radeonsi: read SPI_PS_INPUT_ADDR from LLVM if it returns it

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c| 5 - src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 3 ++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 14/18] radeonsi: make LLVM IR dumping less messy

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_compute.c | 3 ++- src/gallium/drivers/radeonsi/si_shader.c | 18 +++--- src/gallium/drivers/radeonsi/si_shader.h | 3 ++- 3 files changed, 15 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 13/18] radeonsi: move a few r600_can_dump_shader calls to where they're needed

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index b28e1d7..c19e4a9 100644 ---

[Mesa-dev] [PATCH 02/18] radeonsi: generate a color_two_side variant only if the shader reads colors

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index bbef429..8613af2 100644 ---

[Mesa-dev] [PATCH 17/18] radeonsi: compile geometry shaders immediately

From: Marek Olšák they have only 1 variant --- src/gallium/drivers/radeonsi/si_state_shaders.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index

[Mesa-dev] [PATCH 18/18] gallium/radeon: add a function for adding llvm function attributes

From: Marek Olšák This will be used for setting the new InitialPSInputAddr attribute. --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 13 + src/gallium/drivers/radeon/radeon_llvm_emit.h | 1 + 2 files changed, 10 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Allow dumping LLVM IR before optimization passes

On Fri, Feb 05, 2016 at 08:55:17AM -0500, Nicolai Hähnle wrote: > On 04.02.2016 13:52, Tom Stellard wrote: > > On Thu, Feb 04, 2016 at 09:15:26AM +0100, Nicolai Hähnle wrote: > >> From: Nicolai Hähnle > >> > >> Set R600_DEBUG=preoptir to dump the LLVM IR before

Re: [Mesa-dev] [PATCH v2 6/9] radeonsi: Enable ARB_framebuffer_no_attachments

On Fri, Feb 5, 2016 at 11:43 AM, Marek Olšák wrote: > On Fri, Feb 5, 2016 at 12:44 PM, Edward O'Callaghan > wrote: >> Signed-off-by: Edward O'Callaghan >> --- >> src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- >> 1

Re: [Mesa-dev] [PATCH] meta: Fix the pbo usage in meta for GLES{1, 2} contexts

On 12/24/2015 01:04 PM, Anuj Phogat wrote: > OpenGL ES 1.0 doesn't support using GL_STREAM_DRAW and both > ES 1.0 and 2.0 don't support GL_STREAM_READ in glBufferData(). > So, handle it correctly by calling the _mesa_meta_begin() > before create_texture_for_pbo(). > > Cc: "11.1"

Re: [Mesa-dev] [PATCH 03/18] radeonsi: move SPI_PS_INPUT_CNTL value computation to a separate function

On 05.02.2016 14:20, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 74 + 1 file changed, 40 insertions(+), 34 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c

Re: [Mesa-dev] [PATCH 11/18] radeonsi: don't emit unnecessary NULL exports for unbound targets

On 05.02.2016 14:20, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 63 +--- 1 file changed, 50 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

v2: fix arithmetic for special opcodes (based on comments from Marek and Ilia), fix fog state, cleanup --- src/mesa/Makefile.sources | 1 + src/mesa/program/program.h| 2 + src/mesa/state_tracker/st_atifs_to_tgsi.c | 734 ++

[Mesa-dev] [PATCH 5/7] st/mesa: fix handling the fallback texture

v2: fix const-ness --- src/mesa/state_tracker/st_atom_sampler.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_sampler.c b/src/mesa/state_tracker/st_atom_sampler.c index 94231cf..7c8fa13 100644 ---

[Mesa-dev] [PATCH 6/7] glx: remove incorrect refcounting of DRIdrawable

dri drawables must never be released when unbound from a context as long as their corresponding glx objects (window, pixmap, pbuffer) still exist this fixes fd.o bug #93955 and disappearing characters in KotOR when soft shadows are enabled --- src/glx/dri2_glx.c | 4 src/glx/dri3_glx.c

[Mesa-dev] [PATCH 3/7] st/mesa: enable GL_ATI_fragment_shader

--- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index f25bd74..a2caa11 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c

[Mesa-dev] [PATCH 0/7] Fixes for SW:KotOR (v2)

Hi, this series is the second version of my patch set, which aims to improve the looks of Star Wars: Knights of the Old Republic (via Wine). The main feature is the implementation of GL_ATI_fragment_shader for all Gallium divers (though I could only test it with radeonsi, llvmpipe, and

[Mesa-dev] [PATCH 1/7] mesa: optionally associate a gl_program to ati_fragment_shader

the state tracker will use it --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/atifragshader.c | 13 - src/mesa/main/dd.h| 7 ++- src/mesa/main/mtypes.h| 1 + src/mesa/main/state.c | 14 +-

[Mesa-dev] [PATCH 7/7] mesa: optimize out the realloc from glCopyTexImagexD()

v2: comment about the purpose of the code --- src/mesa/main/teximage.c | 32 1 file changed, 32 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 50141be..cac05d5 100644 --- a/src/mesa/main/teximage.c +++

[Mesa-dev] [PATCH v2 i-g-t] igt/list-workarounds: Extend the script to Mesa

Updated the list-workarounds script so that it can parse Mesa directory if provided. Moved the common code to a separate function to allow reuse for both kernel and mesa. The new command line is: Usage: list-workarounds [options] path-to-kernel -k path-to-kernel -m path-to-mesa The legacy

Re: [Mesa-dev] [PATCH 01/11] mesa: Refactor _mesa_framebuffer_renderbuffer

On Fri, Feb 5, 2016 at 1:04 PM, Ian Romanick wrote: > From: Ian Romanick > > This function previously was only used in fbobject.c and contained a > bunch of API validation. Split the function into > framebuffer_renderbuffer that is static and

Re: [Mesa-dev] [PATCH 1/7] mesa: optionally associate a gl_program to ati_fragment_shader

On Fri, Feb 5, 2016 at 1:11 PM, Miklós Máté wrote: > the state tracker will use it > --- > src/mesa/drivers/common/driverfuncs.c | 3 +++ > src/mesa/main/atifragshader.c | 13 - > src/mesa/main/dd.h| 7 ++- > src/mesa/main/mtypes.h

[Mesa-dev] [PATCH] radeonsi: don't emit unnecessary NULL exports for unbound targets (v2)

From: Marek Olšák v2: remove semantic index == 0 checks add the else statement to remove shadowing of args --- src/gallium/drivers/radeonsi/si_shader.c | 88 ++-- 1 file changed, 62 insertions(+), 26 deletions(-) diff --git

[Mesa-dev] [PATCH 1/1] r600, compute: Do not overwrite pipe_resource.screen

found by inspection. Signed-off-by: Jan Vesely --- src/gallium/drivers/r600/evergreen_compute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/evergreen_compute.c b/src/gallium/drivers/r600/evergreen_compute.c index

Re: [Mesa-dev] [PATCH 0/7] Fixes for SW:KotOR (v2)

Thanks a ton for contributing this. This is really cool. I've replied to a couple of patches with a lot of style comments. These issues appear in a lot of places I didn't point out (it was getting a bit repetitive). A summary is - Use spaces around operators - Use BSD-style function

Re: [Mesa-dev] MesaGL <-> non-Mesa OpenCL interop interface

Hi, On 04.02.2016 17:25, Marek Olšák wrote: I would like to start a discussion about an OpenGL-OpenCL interop interface where OpenCL is not part of Mesa. I think the only way to do this is to have Mesa export functions that convert Mesa OpenGL objects into DMABUF handles. Such functions can be

Re: [Mesa-dev] [PATCH v2 1/9] gallium: Add PIPE_CAP_FRAMEBUFFER_LAYERS

On 05.02.2016 10:31, Brian Paul wrote: On 02/05/2016 04:44 AM, Edward O'Callaghan wrote: Add PIPE_CAP to determine the number of layers for a framebuffer for GL_ARB_framebuffer_no_attachments. Signed-off-by: Edward O'Callaghan ---

[Mesa-dev] [PATCH 4/7] mesa: remove check_compatible() in make_current

this was marked for removal since 2007 ctx::Visual is also removed, since this was its only legit user --- .../drivers/dri/radeon/radeon_common_context.c | 2 +- src/mesa/main/blend.c | 4 +- src/mesa/main/blend.h | 4 +-

Re: [Mesa-dev] [PATCH 00/18] RadeonSI: Restructuring shader codegen part 3

Patches 4-10 and 12-18 are also Reviewed-by: Nicolai Hähnle On 05.02.2016 14:20, Marek Olšák wrote: Hi, This is the last part of restructuring needed for having one shader variant per shader. Summary: - a lot of changes are about PS inputs and interpolation - code

Re: [Mesa-dev] [PATCH 7/7] mesa: optimize out the realloc from glCopyTexImagexD()

On Fri, Feb 5, 2016 at 4:11 PM, Miklós Máté wrote: > v2: comment about the purpose of the code > --- > src/mesa/main/teximage.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c > index

Re: [Mesa-dev] [PATCH 1/2] mesa: call build_program_resource_list inside Driver.LinkShader

On 01/30/2016 06:48 AM, Marek Olšák wrote: > From: Marek Olšák > > to allow LinkShader to free the GLSL IR. > --- > src/compiler/glsl/program.h| 5 - > src/mesa/drivers/dri/i965/brw_link.cpp | 2 ++ I think i915 should get the same treatment, right?

Re: [Mesa-dev] [Mesa-stable] [PATCH v3] glx: update to updated version of EXT_create_context_es2_profile

On 02/04/2016 07:54 AM, Ilia Mirkin wrote: > On Thu, Feb 4, 2016 at 10:50 AM, Emil Velikov > wrote: >> Hi Ilia, >> >> On 3 February 2016 at 14:52, Ilia Mirkin wrote: >>> The EXT spec has been updated to: >>> - logically combine the es2_profile

Re: [Mesa-dev] [PATCH 2/2] st/mesa: release GLSL IR in LinkShader after it's not needed

On Fri, Feb 5, 2016 at 8:46 PM, Ian Romanick wrote: > On 01/30/2016 06:48 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git

[Mesa-dev] [PATCH 11/11] meta/decompress: Don't pollute the renderbuffer namespace

From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match

[Mesa-dev] [PATCH 07/11] i965/meta: Use internal functions for renderbuffer access

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 5 ++--- src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 8 src/mesa/drivers/dri/i965/brw_meta_updownsample.c | 6 ++ 3

[Mesa-dev] [PATCH 06/11] i965/meta: Return struct gl_renderbuffer* from brw_get_rb_for_slice instead of GL API handle

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_context.h | 7 --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 9 + src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 18

[Mesa-dev] [PATCH 04/11] meta: Use _mesa_CreateRenderbuffers instead of _mesa_GenRenderbuffers and _mesa_BindRenderbuffer

From: Ian Romanick This has the advantage that it does not pollute the global binding state. It also enables later patches that will stop calling _mesa_GenRenderbuffers / _mesa_CreateRenderbuffers which pollute the renderbuffer namespace. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 08/11] i965/meta: Don't pollute the renderbuffer namespace

From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match

[Mesa-dev] [PATCH 02/11] mesa: Refactor renderbuffer_storage to make _mesa_renderbuffer_storage

From: Ian Romanick Pulls the parts of renderbuffer_storage that aren't just parameter validation out into a function that can be called from other parts of Mesa (e.g., meta). Signed-off-by: Ian Romanick --- src/mesa/main/fbobject.c | 97

[Mesa-dev] [PATCH 09/11] meta/decompress: Track renderbuffer using gl_renderbuffer instead of GL API object handle

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 13 + src/mesa/drivers/common/meta.h | 3 ++- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 10/11] meta: Use internal functions for renderbuffer access

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c| 10 -- src/mesa/drivers/common/meta_copy_image.c | 12 2 files changed, 8 insertions(+), 14 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On Fri, Feb 5, 2016 at 4:11 PM, Miklós Máté wrote: > v2: fix arithmetic for special opcodes > (based on comments from Marek and Ilia), > fix fog state, cleanup > --- > src/mesa/Makefile.sources | 1 + > src/mesa/program/program.h| 2 + >

Re: [Mesa-dev] [PATCH 2/2] st/mesa: release GLSL IR in LinkShader after it's not needed

On 01/30/2016 06:48 AM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp >

Re: [Mesa-dev] [Piglit] [PATCH] Add (un)packHalf tests which don't fail on GCN

On 02/05/2016 08:04 AM, Marek Olšák wrote: > On Fri, Feb 5, 2016 at 4:48 PM, Roland Scheidegger wrote: >> Am 05.02.2016 um 16:08 schrieb Marek Olšák: >>> On Fri, Feb 5, 2016 at 3:56 PM, Roland Scheidegger >>> wrote: Am 05.02.2016 um 15:44 schrieb

[Mesa-dev] [PATCH 03/11] i965/meta: Use _mesa_CreateRenderbuffers instead of _mesa_GenRenderbuffers and _mesa_BindRenderbuffer

From: Ian Romanick This has the advantage that it does not pollute the global binding state. It also enables later patches that will stop calling _mesa_GenRenderbuffers / _mesa_CreateRenderbuffers which pollute the renderbuffer namespace. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 01/11] mesa: Refactor _mesa_framebuffer_renderbuffer

From: Ian Romanick This function previously was only used in fbobject.c and contained a bunch of API validation. Split the function into framebuffer_renderbuffer that is static and contains the validation, and _mesa_framebuffer_renderbuffer that is suitable for calling

[Mesa-dev] [PATCH 05/11] meta: Don't save or restore the renderbuffer binding

From: Ian Romanick Nothing left in meta does anything with the RBO binding, so we don't need to save or restore it. The FBO binding is still modified. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 6 --

Re: [Mesa-dev] MesaGL <-> non-Mesa OpenCL interop interface

On Fri, Feb 5, 2016 at 8:31 PM, Nicolai Hähnle wrote: > Hi, > > > On 04.02.2016 17:25, Marek Olšák wrote: >> >> I would like to start a discussion about an OpenGL-OpenCL interop >> interface where OpenCL is not part of Mesa. >> >> I think the only way to do this is to have

Re: [Mesa-dev] [PATCH 2/2] mesa: remove hack to fix up GL_ANY_SAMPLES_PASSED results

For the series: Reviewed-by: Marek Olšák Marek On Fri, Feb 5, 2016 at 7:16 AM, Ilia Mirkin wrote: > Both st/mesa and i965 should return a true/false result now, and the > only other driver implementing queries (radeon) doesn't support >

Re: [Mesa-dev] [PATCH 4/4] st/mesa: bail out of try_pbo_upload_common when constant upload fails

For the series: Reviewed-by: Marek Olšák Marek On Wed, Feb 3, 2016 at 6:09 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Also fixes a resource leak when an upload_mgr is used for constants. > --- >

Re: [Mesa-dev] [PATCH] Add (un)packHalf tests which don't fail on GCN

On Fri, Feb 5, 2016 at 1:55 AM, Matt Turner wrote: > On Thu, Feb 4, 2016 at 10:50 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> This is a subset of the generated tests which are known to fail >> on everything except CPU emulation

Re: [Mesa-dev] [llvm] r259796 - [X86][SSE] Add general 32-bit LOAD + VZEXT_MOVL support to EltsFromConsecutiveLoads

Hi Simon, On 05.02.2016 01:12, Simon Pilgrim via llvm-commits wrote: > Author: rksimon > Date: Thu Feb 4 10:12:56 2016 > New Revision: 259796 > > URL: http://llvm.org/viewvc/llvm-project?rev=259796=rev > Log: > [X86][SSE] Add general 32-bit LOAD + VZEXT_MOVL support to >

Re: [Mesa-dev] [PATCH 1/3] gallivm: Add helpers for creating and destroying TargetLibraryInfo

For the series: Reviewed-by: Marek Olšák Marek On Thu, Feb 4, 2016 at 10:02 PM, Tom Stellard wrote: > This functionality is not exposed via the LLVM C API. > --- > src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 30 > +++ >

Re: [Mesa-dev] [PATCH 3/3] nv50: add PIPE_QUERY_OCCLUSION_PREDICATE support

This won't fly because you forgot to add PIPE_QUERY_OCCLUSION_PREDICATE in many places in nv50_query_hw.c (begin_query(), end_query()...). On 02/04/2016 06:52 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_query_hw.c | 3 +++

[Mesa-dev] [PATCH v2 2/9] mesa/st: Use _mesa_geometric_ functions appropriately

Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometric_ convenience functions for those places where the geometry of the gl_framebuffer is needed. This is in contrast to the geometry of the intersection of the attachments of the

[Mesa-dev] [PATCH v2 8/9] nvc0: handle the case where there are no framebuffer attachments

From: Ilia Mirkin Signed-off-by: Ilia Mirkin Reviewed-by: Edward O'Callaghan --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 7 +++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +-

[Mesa-dev] [PATCH v2 7/9] r600g: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 36297f3..28b34de 100644 ---

[Mesa-dev] [PATCH v2 6/9] radeonsi: Enable ARB_framebuffer_no_attachments

Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index d3f3677..a58a9d5 100644 ---

Re: [Mesa-dev] [PATCH] list-workarounds: Extend the script to Mesa

On Thu, Feb 04, 2016 at 06:14:02PM +, Kibey, Sameer wrote: > Updated the list-workarounds script so that it > can parse Mesa directory if provided. Moved the > common code to a separate function to allow > reuse for both kernel and mesa. > > The new command line is: > Usage: list-workarounds

[Mesa-dev] [PATCH v2 9/9] GL3.txt: Mark ARB_framebuffer_no_attachments as done

Signed-off-by: Edward O'Callaghan --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 257fc73..350462f 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -157,7 +157,7 @@ GL 4.3, GLSL 4.30:

[Mesa-dev] [PATCH v2 5/9] mesa/st: Update framebuffer state with no.of samples, layers

Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. Signed-off-by: Edward O'Callaghan Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_atom_framebuffer.c | 8 +--- 1 file changed, 5

[Mesa-dev] [PATCH v2 1/9] gallium: Add PIPE_CAP_FRAMEBUFFER_LAYERS

Add PIPE_CAP to determine the number of layers for a framebuffer for GL_ARB_framebuffer_no_attachments. Signed-off-by: Edward O'Callaghan --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 +

[Mesa-dev] [PATCH v2 4/9] gallium/trace: Dump no.of samples and layers in fb state

Signed-off-by: Edward O'Callaghan Reviewed-by: Ilia Mirkin --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/trace/tr_dump_state.c b/src/gallium/drivers/trace/tr_dump_state.c index

  1   2   >