[Mesa-dev] [PATCH] nv50/ir: fix quadop emission in the presence of predication

When there's a predicate, it just goes onto the sources list. If the quadop only has a single regular source, we will end up thinking that the predicate is the second source. Check explicitly for the predSrc so that we don't accidentally emit the wrong thing. This fixes a bunch of

Re: [Mesa-dev] [PATCH] glsl: set user defined varyings to smooth by default in ES

On Tue, 2016-02-16 at 11:03 +1100, Timothy Arceri wrote: > This is usually handled by the backends in order to handle the > various interactions with the gl_*Color built-ins. > > The problem is this means linking will fail if one side on the > interface adds the smooth qualifier to the varying

Re: [Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

On Fri, Feb 12, 2016 at 10:01:21AM +0100, Jochen Rollwagen wrote: > Hi, > > i think i found & fixed a bug in mesa concerning tests for big-endian > machines. The defines tested don't exist or are wrongly defined so the test > (probably) never fires. The gcc defines on my machine concerning

Re: [Mesa-dev] [PATCH] Handle removal of LLVMAddTargetData in SVN revision 260919

On 16.02.2016 15:25, Matthew Dawson wrote: > LLVM removed LLVMAddTargetData for the 3.9 release in r260919. For the two > places in mesa where this is called, only enable the lines when compiling > for less then 3.9. > > For the radeon driver, I'm not sure how to check if any other LLVM calls

[Mesa-dev] [PATCH] st/mesa: fix up result_src.type when doing i2u/u2i conversions

Even though it's a no-op, it's important to keep track of the type so that we can pick the properly-signed op later on. This fixes dEQP-GLES3.functional.shaders.precision.uint.highp_div_fragment, which ended up using IDIV instead of UDIV. Signed-off-by: Ilia Mirkin Cc:

Re: [Mesa-dev] [PATCH 2/5] android: radeonsi: fix building error in si_shader.c

On 14.02.2016 23:41, Mauro Rossi wrote: > > From: Mauro Rossi > > Date: Sun, 14 Feb 2016 15:34:16 +0100 > Subject: [PATCH 1/2] android: add support for strchrnul > > Android Bionic has no strchrnul in string functions, > radeonsi uses

[Mesa-dev] [PATCH] Handle removal of LLVMAddTargetData in SVN revision 260919

LLVM removed LLVMAddTargetData for the 3.9 release in r260919. For the two places in mesa where this is called, only enable the lines when compiling for less then 3.9. For the radeon driver, I'm not sure how to check if any other LLVM calls need to be adjusted. I think since the target data

[Mesa-dev] [PATCH 1/4] mesa: gl_NumSamples should always be at least one

From ARB_sample_shading: "gl_NumSamples is the total number of samples in the framebuffer, or one if rendering to a non-multisample framebuffer" So make sure to always pass in at least 1. Signed-off-by: Ilia Mirkin --- src/mesa/program/prog_statevars.c | 2 +- 1

[Mesa-dev] [PATCH 3/4] glsl: enable OES_sample_variables features

Add gl_MaxSamples, and enable the various other variables when this extension or ESSL 3.20 are set. Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 15 --- src/compiler/glsl/glsl_parser_extras.cpp | 4

[Mesa-dev] [PATCH 4/4] st/mesa: add OES_sample_variables support

Basically the same thing as ARB_sample_shading except that it also needs gl_SampleMaskIn support as well as not enable per-sample interpolation whenever doing per-sample shading. This is done explicitly in another extension. Signed-off-by: Ilia Mirkin --- I get 16 failures

[Mesa-dev] [PATCH 2/4] mesa: add OES_sample_variables to extension table, add enable bit

Signed-off-by: Ilia Mirkin --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index bcd12a2..196a0c6 100644 ---

Re: [Mesa-dev] [v2 18/19] i965: Add helper for lossless compression support

On Mon, Feb 15, 2016 at 01:27:19PM -0800, Ben Widawsky wrote: > On Thu, Feb 11, 2016 at 08:34:11PM +0200, Topi Pohjolainen wrote: > > v2: Use explicitly against base type of GL_FLOAT instead of > > using _mesa_is_format_integer_color(). Otherwise we miss > > GL_UNSIGNED_NORMALIZED. > > >

Re: [Mesa-dev] [v2 14/19] i965/gen9: Prepare surface state setup for lossless compression

On Mon, Feb 15, 2016 at 12:55:28PM -0800, Ben Widawsky wrote: > On Thu, Feb 11, 2016 at 08:34:07PM +0200, Topi Pohjolainen wrote: > > v2 (Ben): Use combination of msaa_layout and number of samples > > instead of introducing explicit type for lossless > > compression

[Mesa-dev] [PATCH] mesa: add GL_OES_texture_stencil8 support

It's basically the same thing as GL_ARB_texture_stencil8 except that glCopyTexImage isn't supported, so add STENCIL_INDEX to the list of invalid GLES formats for glCopyTexImage. Signed-off-by: Ilia Mirkin --- Seems to pass the few dEQP tests that are there. The ext is

[Mesa-dev] [Bug 94168] Incorrect rendering when running Populous 3 on wine using DDraw->WineD3D->OpenGL wrapper [apitrace]

https://bugs.freedesktop.org/show_bug.cgi?id=94168 Michel Dänzer changed: What|Removed |Added Component|GLX |Mesa core -- You

Re: [Mesa-dev] [PATCH] st/mesa: count shader images in MaxCombinedShaderOutputResources

On Mon, Feb 15, 2016 at 10:07 PM, Ilia Mirkin wrote: > On Mon, Feb 15, 2016 at 10:00 PM, Nicolai Hähnle wrote: >> From: Nicolai Hähnle >> >> --- >> This is on top of Ilia's Gallium images series. Ilia, I think it makes sense >>

Re: [Mesa-dev] [PATCH] mesa: add GL_OES_copy_image support

On Mon, Feb 15, 2016 at 8:41 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > I ran this with the dEQP tests, and other than the caveats below, they seem to > mostly work. > > The biggest caveat is that this can't actually be enabled for

Re: [Mesa-dev] [PATCH 10/25] radeonsi: add code for dumping all shader parts together

On 16.02.2016 08:59, Marek Olšák wrote: > From: Marek Olšák [...] > @@ -4199,13 +4200,27 @@ static void si_shader_dump_stats(struct si_screen > *sscreen, > void si_shader_dump(struct si_screen *sscreen, struct si_shader *shader, > struct

Re: [Mesa-dev] [PATCH] st/mesa: count shader images in MaxCombinedShaderOutputResources

On Mon, Feb 15, 2016 at 10:00 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > This is on top of Ilia's Gallium images series. Ilia, I think it makes sense > for you to include this in your initial push if you agree. I don't disagree, but

[Mesa-dev] [PATCH] st/mesa: count shader images in MaxCombinedShaderOutputResources

From: Nicolai Hähnle --- This is on top of Ilia's Gallium images series. Ilia, I think it makes sense for you to include this in your initial push if you agree. src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

On 16.02.2016 06:38, Matt Turner wrote: > On Mon, Feb 15, 2016 at 12:50 PM, Ilia Mirkin wrote: >> In a few places your indentation is off -- please look at the 'git >> diff' output, it should be pretty obvious. You used 2 spaces instead >> of 3 (in just a handful of places).

[Mesa-dev] [PATCH] mesa: add GL_OES_copy_image support

Signed-off-by: Ilia Mirkin --- I ran this with the dEQP tests, and other than the caveats below, they seem to mostly work. The biggest caveat is that this can't actually be enabled for any drivers that don't implement ETC2 in hardware. So really that's just freedreno and

Re: [Mesa-dev] black background on android-x86-5.1

On Mon, Feb 15, 2016 at 12:49 AM, qinshao...@phoenixos.com wrote: > > Hi Mauro, > > I've heard a lot about you, I have a question for you Derm. > my laptop is lenovo B460, the gpu chipset GT218, family is NV50 . on kitkat, > wallpaper can be displayed. but on

Re: [Mesa-dev] [PATCH v2] vc4: Correct typo setting 'handled_qinst_cond'

On 15 February 2016 at 20:17, Eric Anholt wrote: > Rhys Kidd writes: > > > Variable was previously always set to true. Accordingly, the later > > assert() served no active purpose. > > > > Found with GCC warning and code inspection: > > > >

Re: [Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

Am 15.02.2016 um 15:53 schrieb Oded Gabbay: Sent with MailTrack On Sat, Feb 13, 2016 at 2:39 AM, Roland Scheidegger wrote: Am 12.02.2016 um 10:01 schrieb Jochen Rollwagen: Hi, i think i found & fixed a bug in mesa concerning tests for big-endian machines. The defines

Re: [Mesa-dev] [PATCH v2] vc4: Correct typo setting 'handled_qinst_cond'

Rhys Kidd writes: > Variable was previously always set to true. Accordingly, the later > assert() served no active purpose. > > Found with GCC warning and code inspection: > > mesa/src/gallium/drivers/vc4/vc4_qpu_emit.c: In function'vc4_generate_code': >

Re: [Mesa-dev] [PATCH] st/mesa: empty buffer binding if the buffer's not really there

Reviewed-by: Marek Olšák Marek On Sun, Feb 14, 2016 at 1:25 AM, Ilia Mirkin wrote: > This can happen with 0-sized buffers. > > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_atom_atomicbuf.c | 8 +--- > 1 file

Re: [Mesa-dev] [PATCH 2/2] st/mesa: use new CSO_BITS_ALL_SHADERS

For the series: Reviewed-by: Marek Olšák Marek On Mon, Feb 15, 2016 at 6:06 PM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_cb_bitmap.c | 9 +++-- > src/mesa/state_tracker/st_cb_clear.c | 8 ++-- >

Re: [Mesa-dev] [PATCH 2/6] st/mesa: overhaul vertex setup for clearing, glDrawPixels, glBitmap

On Sun, Feb 14, 2016 at 3:47 PM, Brian Paul wrote: > On 02/13/2016 01:03 PM, Ilia Mirkin wrote: >> >> On Fri, Feb 12, 2016 at 10:43 AM, Brian Paul wrote: >>> >>> diff --git a/src/mesa/state_tracker/st_context.c >>> b/src/mesa/state_tracker/st_context.c >>>

[Mesa-dev] [PATCH] mesa: add GL_OES_texture_border_clamp support

Only minor differences to the existing ARB_texture_border_clamp support. Signed-off-by: Ilia Mirkin --- I get 53 failures (and 548 passes) in the dEQP tests, they appear to expect all-red for depth texturing while gallium apparently returns gray. Haven't figured out if

Re: [Mesa-dev] [PATCH 2/2] glsl: set user defined varyings to smooth by default

On Tue, 2016-02-16 at 09:04 +1100, Timothy Arceri wrote: > On Mon, 2016-02-15 at 16:12 +0100, Iago Toral wrote: > > On Mon, 2016-02-15 at 18:38 +1100, Timothy Arceri wrote: > > > This is usually handled by the backends in order to handle the > > > various interactions with the gl_*Color built-ins.

[Mesa-dev] [PATCH] glsl: set user defined varyings to smooth by default in ES

This is usually handled by the backends in order to handle the various interactions with the gl_*Color built-ins. The problem is this means linking will fail if one side on the interface adds the smooth qualifier to the varying and the other side just uses the default even though they match.

[Mesa-dev] [PATCH 20/25] radeonsi: enable compiling one variant per shader

From: Marek Olšák Shader stats from VERDE: Default scheduler: Totals: SGPRS: 491272 -> 488672 (-0.53 %) VGPRS: 289980 -> 311093 (7.28 %) Code Size: 11091656 -> 11219948 (1.16 %) bytes LDS: 97 -> 97 (0.00 %) blocks Scratch: 1732608 -> 2246656 (29.67 %) bytes per wave Max

[Mesa-dev] [PATCH 18/25] radeonsi: compile non-GS middle parts of shaders immediately if enabled

From: Marek Olšák Still disabled. Only prologs & epilogs are compiled in draw calls, but each variant of those is compiled only once per process. VS is always compiled as hw VS. TES is always compiled as hw VS. LS and ES stages are always compiled on demand. ---

[Mesa-dev] [PATCH 09/25] radeonsi: add code for combining and uploading shaders from 3 shader parts

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 35 src/gallium/drivers/radeonsi/si_shader.h | 9 2 files changed, 36 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 12/25] radeonsi: add VS prolog

From: Marek Olšák This is disabled with use_monolithic_shaders = true. --- src/gallium/drivers/radeonsi/si_pipe.c | 19 +++ src/gallium/drivers/radeonsi/si_pipe.h | 3 + src/gallium/drivers/radeonsi/si_shader.c | 236 ++-

[Mesa-dev] [PATCH 17/25] radeonsi: rework polygon stippling for PS prolog

From: Marek Olšák Don't use the pstipple module. --- src/gallium/drivers/radeonsi/si_shader.c | 149 +++ 1 file changed, 110 insertions(+), 39 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 15/25] radeonsi: add PS epilog

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 289 ++- src/gallium/drivers/radeonsi/si_shader.h | 7 + 4 files changed, 296

[Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_shader.c| 324 +++- src/gallium/drivers/radeonsi/si_shader.h| 14 +-

[Mesa-dev] [PATCH 21/25] radeonsi: use smaller types for some si_shader members

From: Marek Olšák in order to decrease the shader size for a shader cache. --- src/gallium/drivers/radeonsi/si_shader.c | 3 +++ src/gallium/drivers/radeonsi/si_shader.h | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 25/25] radeonsi: implement binary shaders & shader cache in memory

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 5 +- src/gallium/drivers/radeonsi/si_pipe.h | 16 ++ src/gallium/drivers/radeonsi/si_shader.h| 4 +- src/gallium/drivers/radeonsi/si_state.h | 2 +

[Mesa-dev] [PATCH 24/25] gallium/radeon: remove unused radeon_shader_binary_free_* functions

From: Marek Olšák --- src/gallium/drivers/radeon/radeon_elf_util.c | 19 --- src/gallium/drivers/radeon/radeon_elf_util.h | 14 -- 2 files changed, 33 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_elf_util.c

[Mesa-dev] [PATCH 23/25] radeonsi: make radeon_shader_reloc name string fixed-sized

From: Marek Olšák This will simplify implementations of binary shaders. --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/radeon_elf_util.c | 7 ++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 14/25] radeonsi: add TCS epilog

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 163 --- src/gallium/drivers/radeonsi/si_shader.h | 3 + 4 files changed, 155

[Mesa-dev] [PATCH 22/25] radeonsi: move some struct si_shader members to new struct si_shader_info

From: Marek Olšák This will be part of shader binaries. --- src/gallium/drivers/radeonsi/si_shader.c| 100 src/gallium/drivers/radeonsi/si_shader.h| 21 ++--- src/gallium/drivers/radeonsi/si_state_shaders.c | 18 ++--- 3 files

[Mesa-dev] [PATCH 11/25] radeonsi: first bits for non-monolithic shaders

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + src/gallium/drivers/radeonsi/si_pipe.h | 3 ++ src/gallium/drivers/radeonsi/si_shader.c | 53 src/gallium/drivers/radeonsi/si_shader.h | 2 +- 4 files changed, 45

[Mesa-dev] [PATCH 13/25] radeonsi: add VS epilog

From: Marek Olšák It only exports the primitive ID. Also used by TES when it's compiled as VS. The VS input location of the primitive ID input is v2. --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.h | 1 +

[Mesa-dev] [PATCH 19/25] radeonsi: print full shader name before disassembly

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 34 +++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 20069b4..2789788

[Mesa-dev] [PATCH 10/25] radeonsi: add code for dumping all shader parts together

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index a6a0984..b058019

[Mesa-dev] [PATCH 02/25] radeonsi: compute how many input SGPRs and VGPRs shaders have

From: Marek Olšák Prologs (shader binaries inserted before the API shader binary) need to know this, so that they won't change the input registers unintentionally. --- src/gallium/drivers/radeonsi/si_shader.c | 32

[Mesa-dev] [PATCH 08/25] radeonsi: fail compilation if non-GS non-CS shaders have rodata

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 4bb7ece..dbb9217 100644 ---

[Mesa-dev] [PATCH 05/25] radeonsi: add start_instance parameter to get_instance_index_for_fetch

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 48996b4..858f8cf 100644 ---

[Mesa-dev] [PATCH 07/25] radeonsi: separate 2 pieces of code from create_function

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 82 1 file changed, 51 insertions(+), 31 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 02bfeea..4bb7ece

[Mesa-dev] [PATCH 06/25] radeonsi: add samplemask parameter to si_export_mrt_color

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 858f8cf..02bfeea 100644 ---

[Mesa-dev] [PATCH 01/25] gallium/radeon: add basic code for setting shader return values

From: Marek Olšák LLVMBuildInsertValue will be used on return_value. --- src/gallium/drivers/r600/r600_llvm.c| 2 +- src/gallium/drivers/radeon/radeon_llvm.h| 4 +++- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 14 +++---

[Mesa-dev] [PATCH 04/25] radeonsi: separate out shader key bits for prologs & epilogs

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c| 70 ++- src/gallium/drivers/radeonsi/si_shader.h| 77 +++-- src/gallium/drivers/radeonsi/si_state.c | 2 +-

[Mesa-dev] [PATCH 03/25] radeonsi: compute how many input VGPRs fragment shaders have

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 41 src/gallium/drivers/radeonsi/si_shader.h | 2 ++ 2 files changed, 43 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 00/25] RadeonSI: 1 variant per shader & shader cache in memory

Hi, This patch series implements a new compilation mode that compiles shaders to hw bytecode only once with the assumption that any state-dependent code will be attached at the beginning or end of the bytecode to implement emulated features such as vertex buffer addressing, two-side color

[Mesa-dev] [Bug 94168] Incorrect rendering when running Populous 3 on wine using DDraw->WineD3D->OpenGL wrapper [apitrace]

https://bugs.freedesktop.org/show_bug.cgi?id=94168 Bug ID: 94168 Summary: Incorrect rendering when running Populous 3 on wine using DDraw->WineD3D->OpenGL wrapper [apitrace] Product: Mesa Version: git Hardware: x86 (IA32)

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

On Mon, 2016-02-15 at 10:49 -0500, Nicolai Hähnle wrote: > > On 12.02.2016 17:53, Timothy Arceri wrote: > > On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: > > > This fixes > > > > > > dEQP-GLES31.functional.uniform_location.negative.atomic_fragment > > >

Re: [Mesa-dev] [PATCH 2/2] glsl: set user defined varyings to smooth by default

On Mon, 2016-02-15 at 16:12 +0100, Iago Toral wrote: > On Mon, 2016-02-15 at 18:38 +1100, Timothy Arceri wrote: > > This is usually handled by the backends in order to handle the > > various interactions with the gl_*Color built-ins. > > > > The problem is this means linking will fail if one side

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

On Mon, Feb 15, 2016 at 4:38 PM, Matt Turner wrote: > On Mon, Feb 15, 2016 at 12:50 PM, Ilia Mirkin wrote: >> In a few places your indentation is off -- please look at the 'git >> diff' output, it should be pretty obvious. You used 2 spaces instead >> of

Re: [Mesa-dev] [PATCH v2] st/mesa: do not init limits when compute shaders are not supported

On 15.02.2016 22:44, Samuel Pitoiset wrote: When the number of uniform blocks is less than 12, ARB_uniform_buffer_object can't be enabled and the maximum GL version is not even 3.1... This fixes a regression introduced in 7c79c1e (st/mesa: add compute shader state) if the maximum number of

Re: [Mesa-dev] [PATCH v2] st/mesa: do not init limits when compute shaders are not supported

On Mon, Feb 15, 2016 at 4:44 PM, Samuel Pitoiset wrote: > When the number of uniform blocks is less than 12, > ARB_uniform_buffer_object can't be enabled and the maximum GL version > is not even 3.1... > > This fixes a regression introduced in 7c79c1e (st/mesa: add

[Mesa-dev] [PATCH v2] st/mesa: do not init limits when compute shaders are not supported

When the number of uniform blocks is less than 12, ARB_uniform_buffer_object can't be enabled and the maximum GL version is not even 3.1... This fixes a regression introduced in 7c79c1e (st/mesa: add compute shader state) if the maximum number of uniform blocks allowed for compute shaders is less

Re: [Mesa-dev] [PATCH] st/mesa: do not init limits when compute shaders are not supported

On 02/15/2016 10:40 PM, Samuel Pitoiset wrote: When the number of uniform blocks is less than 12, ARB_uniform_buffer_object can't be enabled and the maximum GL version is not even 3.1... This fixes a regression introduced in 7c79c1e (st/mesa: add compute shader state) if the maximum number of

[Mesa-dev] [PATCH] st/mesa: do not init limits when compute shaders are not supported

When the number of uniform blocks is less than 12, ARB_uniform_buffer_object can't be enabled and the maximum GL version is not even 3.1... This fixes a regression introduced in 7c79c1e (st/mesa: add compute shader state) if the maximum number of uniform blocks allowed for compute shaders is less

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

On Mon, Feb 15, 2016 at 12:50 PM, Ilia Mirkin wrote: > In a few places your indentation is off -- please look at the 'git > diff' output, it should be pretty obvious. You used 2 spaces instead > of 3 (in just a handful of places). If you use vim, you can put something like

Re: [Mesa-dev] [v2] Compression support for single-sampled

On Thu, Feb 11, 2016 at 08:33:53PM +0200, Topi Pohjolainen wrote: > This series enables compression for single sampled color surfaces, > also referred to as "lossless compression". This is yet only for > driver internal use easing pressure on memory bandwidth and caches > when writing, blending

Re: [Mesa-dev] [v2 18/19] i965: Add helper for lossless compression support

On Thu, Feb 11, 2016 at 08:34:11PM +0200, Topi Pohjolainen wrote: > v2: Use explicitly against base type of GL_FLOAT instead of > using _mesa_is_format_integer_color(). Otherwise we miss > GL_UNSIGNED_NORMALIZED. > > Signed-off-by: Topi Pohjolainen > --- >

Re: [Mesa-dev] [v2 16/19] i965: Expose logic telling if non-msrt mcs is supported

On Thu, Feb 11, 2016 at 08:34:09PM +0200, Topi Pohjolainen wrote: > Alos use the opportunity to mark inputs constant. (Context has to be Also > given as read-write to intel_miptree_supports_non_msrt_fast_clear() > to support debug output). > > Signed-off-by: Topi Pohjolainen

Re: [Mesa-dev] [v2 14/19] i965/gen9: Prepare surface state setup for lossless compression

On Thu, Feb 11, 2016 at 08:34:07PM +0200, Topi Pohjolainen wrote: > v2 (Ben): Use combination of msaa_layout and number of samples > instead of introducing explicit type for lossless > compression (intel_miptree_is_lossless_compressed()). > > Signed-off-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

In a few places your indentation is off -- please look at the 'git diff' output, it should be pretty obvious. You used 2 spaces instead of 3 (in just a handful of places). On Fri, Feb 12, 2016 at 7:38 AM, Plamena Manolova wrote: > This patch moves the calculation of

Re: [Mesa-dev] [v2 13/19] i965: Set buffer cleared after actually clearing it

On Thu, Feb 11, 2016 at 08:34:06PM +0200, Topi Pohjolainen wrote: > Subsequent patch will modify the surface state to set state to > unresolved whenever the surface is used as render target. Color > resolve itself will use the same surface setup path and marking > the buffer as cleared after the

Re: [Mesa-dev] [PATCH] mesa: add always-false-for-now enables for GL 4.3, 4.4, 4.5.

ping? Ian, did you have a chance to look over my answers? Were you hoping something more thorough would get done for these checks? On Fri, Jan 8, 2016 at 6:24 PM, Ilia Mirkin wrote: > On Fri, Jan 8, 2016 at 6:19 PM, Ian Romanick wrote: >> On

Re: [Mesa-dev] [v2 05/19] i965: Add helper for detecting lossless compression

On Sat, Feb 13, 2016 at 09:36:01AM +0200, Pohjolainen, Topi wrote: > On Thu, Feb 11, 2016 at 01:48:18PM -0800, Ben Widawsky wrote: > > On Thu, Feb 11, 2016 at 08:33:58PM +0200, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > >

Re: [Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

On Mon, Feb 15, 2016 at 8:33 PM, Jochen Rollwagen wrote: > Am 15.02.2016 um 15:53 schrieb Oded Gabbay: >> >> Sent with MailTrack >> >> On Sat, Feb 13, 2016 at 2:39 AM, Roland Scheidegger >> wrote: >>> >>> Am 12.02.2016 um 10:01 schrieb Jochen Rollwagen:

Re: [Mesa-dev] [PATCH 2/6] st/mesa: overhaul vertex setup for clearing, glDrawPixels, glBitmap

On 02/14/2016 10:44 AM, Ilia Mirkin wrote: On Sun, Feb 14, 2016 at 9:47 AM, Brian Paul wrote: On 02/13/2016 01:03 PM, Ilia Mirkin wrote: On Fri, Feb 12, 2016 at 10:43 AM, Brian Paul wrote: diff --git a/src/mesa/state_tracker/st_context.c

[Mesa-dev] [PATCH 1/2] cso: add CSO_BITS_ALL_SHADERS

For saving/restoring all shader stages. --- src/gallium/auxiliary/cso_cache/cso_context.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.h b/src/gallium/auxiliary/cso_cache/cso_context.h index 0305451..a3563d8 100644 ---

[Mesa-dev] [PATCH 2/2] st/mesa: use new CSO_BITS_ALL_SHADERS

--- src/mesa/state_tracker/st_cb_bitmap.c | 9 +++-- src/mesa/state_tracker/st_cb_clear.c | 8 ++-- src/mesa/state_tracker/st_cb_drawpixels.c | 8 ++-- src/mesa/state_tracker/st_cb_texture.c| 8 ++-- 4 files changed, 9 insertions(+), 24 deletions(-) diff --git

[Mesa-dev] [PATCH] mesa: implement a display list / glBitmap texture atlas

This improves the performance of applications which use glXUseXFont() or wglUseFontBitmaps() and glCallLists() to draw bitmap text. Basically, we collect all the glBitmap images from the display lists and put them into a texture atlas. To render the bitmaps for a glCallLists() command, we render

Re: [Mesa-dev] [PATCH 1/2] mesa: implement a display list / glBitmap texture atlas

On 15.02.2016 11:31, Brian Paul wrote: On 02/15/2016 08:45 AM, Nicolai Hähnle wrote: On 12.02.2016 20:07, Brian Paul wrote: This improves the performance of applications which use glXUseXFont() or wglUseFontBitmaps() and glCallLists() to draw bitmap text. Basically, we collect all the

Re: [Mesa-dev] [PATCH 1/2] mesa: implement a display list / glBitmap texture atlas

On 02/15/2016 08:45 AM, Nicolai Hähnle wrote: On 12.02.2016 20:07, Brian Paul wrote: This improves the performance of applications which use glXUseXFont() or wglUseFontBitmaps() and glCallLists() to draw bitmap text. Basically, we collect all the glBitmap images from the display lists and

Re: [Mesa-dev] [PATCH] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

On Feb 15, 2016 3:24 AM, "Pekka Paalanen" wrote: > > On Thu, 11 Feb 2016 10:34:10 -0600 > Derek Foreman wrote: > > > Since commit d1314de293e9e4a63c35f094c3893aaaed8580b4 we ignore > > damage passed to SwapBuffersWithDamage. > > > > Wayland 1.10 now

Re: [Mesa-dev] [PATCH] mesa/glformats: Bypass resolving effective internal format for GL_BGRA

Anyone willing to take a look? Thanks! Eduardo On 02/10/2016 02:57 PM, Eduardo Lima Mitev wrote: > Currently, when validating format and type on ES3, we treat GL_BGRA as a > special case when obtaining the effective internal format from the format > and type. This is because

Re: [Mesa-dev] [PATCH] glsl: reject explicit location on atomic counter uniforms

On 12.02.2016 17:53, Timothy Arceri wrote: On Thu, 2016-02-11 at 20:10 -0500, Ilia Mirkin wrote: This fixes dEQP-GLES31.functional.uniform_location.negative.atomic_fragment dEQP-GLES31.functional.uniform_location.negative.atomic_vertex Both of which have lines like layout(location = 3,

Re: [Mesa-dev] [PATCH 1/2] mesa: implement a display list / glBitmap texture atlas

On 12.02.2016 20:07, Brian Paul wrote: This improves the performance of applications which use glXUseXFont() or wglUseFontBitmaps() and glCallLists() to draw bitmap text. Basically, we collect all the glBitmap images from the display lists and put them into a texture atlas. To render the

Re: [Mesa-dev] [PATCH 2/2] st/mesa: new st_DrawAtlasBitmaps() function for drawing bitmap text

On 12.02.2016 20:07, Brian Paul wrote: This basically saves the current pipeline state, sets up state for rendering, constructs a set of textured quads, renders, then restores the previous pipeline state. It shouldn't be hard to implement a similar function for non-gallium drives. With some

Re: [Mesa-dev] [PATCH] glsl: warn in GL as well as ES when varying not written

Reviewed-by: Iago Toral Quiroga On Mon, 2016-02-15 at 14:06 +1100, Timothy Arceri wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93339 > --- > src/compiler/glsl/link_varyings.cpp | 23 +++ > 1 file changed, 7 insertions(+), 16 deletions(-)

Re: [Mesa-dev] [PATCH 1/1] configure: Bail out on llvm-config component error

On 12.02.2016 19:41, Jan Vesely wrote: Signed-off-by: Jan Vesely --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 2750d4d..57330cb 100644 --- a/configure.ac +++ b/configure.ac @@ -2295,6 +2295,9 @@ dnl in

Re: [Mesa-dev] [PATCH 2/2] glsl: set user defined varyings to smooth by default

On Mon, 2016-02-15 at 18:38 +1100, Timothy Arceri wrote: > This is usually handled by the backends in order to handle the > various interactions with the gl_*Color built-ins. > > The problem is this means linking will fail if one side on the > interface adds the smooth qualifier to the varying

Re: [Mesa-dev] [PATCH v2 2/4] Android: Fix building secondary arch in mixed 32/64-bit builds

2016-02-03 4:45 GMT+08:00 Rob Herring : > TARGET_CC is not defined for the secondary arch on combined 32/64-bit > builds. The build system uses 2ND_TARGET_CC instead and it is not meant > to be used in module makefiles. LOCAL_CC was used to provide C only > flags as -std=c99 is

Re: [Mesa-dev] [PATCH v2 3/4] Android: enable building on arm64

2016-02-03 4:45 GMT+08:00 Rob Herring : > Use the LOCAL_CFLAGS_{32/64} instead of arch specific variants to define > the DEFAULT_DRIVER_DIR. This enables building for arm64. > > Cc: Emil Velikov > Cc: Chih-Wei Huang >

Re: [Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

Sent with MailTrack On Sat, Feb 13, 2016 at 2:39 AM, Roland Scheidegger wrote: > > Am 12.02.2016 um 10:01 schrieb Jochen Rollwagen: > > Hi, > > > > i think i found & fixed a bug in mesa concerning tests for big-endian > > machines. The defines tested don't exist or are

Re: [Mesa-dev] [PATCH 1/2] glsl: remove unused helper

Reviewed-by: Iago Toral Quiroga On Mon, 2016-02-15 at 18:38 +1100, Timothy Arceri wrote: > Seems to have become unused when i965 moved to NIR. > --- > src/compiler/glsl/ir.cpp | 15 --- > src/compiler/glsl/ir.h | 11 --- > 2 files changed, 26

Re: [Mesa-dev] [PATCH v2] Android: fix build break in libmesa_program

Looks good to me. Sorry about breaking it. Reviewed-by: Neil Roberts - Neil Rob Herring writes: > Commit 5fd848f6c9ee ("program: Use _mesa_geometric_samples to calculate > gl_NumSamples") broken Android builds. Add the missing include path "main" > to

[Mesa-dev] [PATCH v2] Android: fix build break in libmesa_program

Commit 5fd848f6c9ee ("program: Use _mesa_geometric_samples to calculate gl_NumSamples") broken Android builds. Add the missing include path "main" to framebuffer.h like other includes in prog_statevars.c. Cc: Neil Roberts Cc: Ilia Mirkin

Re: [Mesa-dev] [PATCH] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

On Thu, 11 Feb 2016 10:34:10 -0600 Derek Foreman wrote: > Since commit d1314de293e9e4a63c35f094c3893aaaed8580b4 we ignore > damage passed to SwapBuffersWithDamage. > > Wayland 1.10 now has functionality that allows us to properly > process those damage rectangles, and a

[Mesa-dev] [PATCH] egl: support EGL_LARGEST_PBUFFER in eglCreatePbufferSurface(...)

From: Daniel Czarnowski Patch provides a 'sane default' for a set pbuffer surface size when EGL_LARGEST_PBUFFER is used by the client. MIN2 macro is moved to egldefines so that it can be shared. Fixes following Piglit test: egl-create-largest-pbuffer-surface

[Mesa-dev] [PATCH] Revert "i965: Restore vbo after color resolve during brw_try_draw_prims()"

This got pushed accidentally in the first place but wasn't reverted as it didn't regress piglit but instead fixed one newly introduced test exercising a corner in case in i965 driver. However, saving and restoring vertex buffer context is complicated and requires more thought. Bugzilla:

  1   2   >