Re: [Mesa-dev] [PATCH 1/4] mesa: gl_NumSamples should always be at least one

Reviewed-by: Edward O`Callaghan I had the same issue also. On 2016-02-16 17:31, Ilia Mirkin wrote: From ARB_sample_shading: "gl_NumSamples is the total number of samples in the framebuffer, or one if rendering to a non-multisample framebuffer" So make

Re: [Mesa-dev] [PATCH] st/mesa: fix pbo uploads

On Thu, Feb 18, 2016 at 1:07 AM, Ilia Mirkin wrote: > - LOD must be provided in .w for TXF (even for buffer textures) > - User buffer must be valid at draw time > - Must have a sampler associated with the sampler view > > This makes PBO uploads work again on nouveau. > >

Re: [Mesa-dev] [PATCH] mesa/dri/r200: Refrain from using symbol links in repo

Disregard, apparently this breaks out-of-tree builds. There perhaps is maybe no good solution here so i`ll refrain from this can of worms for now. On 2016-02-18 15:46, Edward O'Callaghan wrote: Just use the relative path in the Makefile.source over symbol links that are not necessarily

[Mesa-dev] [PATCH] st/mesa: fix pbo uploads

- LOD must be provided in .w for TXF (even for buffer textures) - User buffer must be valid at draw time - Must have a sampler associated with the sampler view This makes PBO uploads work again on nouveau. Signed-off-by: Ilia Mirkin ---

Re: [Mesa-dev] [PATCH] compiler/glsl: Fix uniform location counting.

On 02/17/2016 04:27 PM, Manolova, Plamena wrote: Thank you for reviewing. The change has been run through both Piglit and CTS. I'll ask Tapani to take another look just in case. LGTM and passes all the tests, nice work! On Wed, Feb 17, 2016 at 4:20 PM, Ilia Mirkin

Re: [Mesa-dev] ANNOUNCE: An open-source Vulkan driver for Intel hardware

Ok, I'll do that, thanks :-) No matter what, I'll learn interesting things. OG. On Wed, Feb 17, 2016 at 4:31 PM, Jason Ekstrand wrote: > On Tue, Feb 16, 2016 at 11:22 PM, Olivier Galibert > wrote: >> >> I'm actually interested about how one goes

[Mesa-dev] [PATCH] mesa/dri/r200: Refrain from using symbol links in repo

Just use the relative path in the Makefile.source over symbol links that are not necessarily portable. Untested as I don't have this old hardware. Signed-off-by: Edward O'Callaghan --- src/mesa/drivers/dri/r200/Makefile.sources| 58 +++

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

On Wed, 2016-02-17 at 16:10 -0800, Anuj Phogat wrote: > Timothy, I looked at the patch and feel that I'm not the right person > to review > it. I know very little about tessellation. Maybe Ken has some useful > comments. No problem :) Thanks for looking at everything else. I'll see if I can find

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

On Thu, Feb 18, 2016 at 02:07:25AM +0100, Roland Scheidegger wrote: > Am 17.02.2016 um 22:09 schrieb Rowley, Timothy O: > >> On Nov 18, 2015, at 12:34 PM, Emil Velikov > >> wrote: I have no objections against > >> getting this merged, although here are a couple of things

Re: [Mesa-dev] [PATCH] mesa: check fbo completeness based on internal format, not driver format

On 02/17/2016 06:35 PM, Ilia Mirkin wrote: The underlying format can be anything. Specifically in the stencil-only case, it might be a depth/stencil format. However we still want to refuse such an attachment when bound to GL_DEPTH, so we must check the base format that the texture was created

Re: [Mesa-dev] gl_render_buffer->_BaseFormat

On 02/17/2016 06:20 PM, Ilia Mirkin wrote: Hi Brian, In commit commit 45e76d2665b38ba3787548310efc59e969124c01 Author: Brian Paul Date: Thu Oct 8 20:27:27 2009 -0600 mesa: remove a bunch of gl_renderbuffer fields _ActualFormat is replaced by Format

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

Thanks for running that thru CI.. if you have a chance, I wouldn't mind a review on v2 of 01/10 (since that one is by far the most noisy gcc6 warning, and would be nice to get that clean-up in before the branch point) BR, -R On Wed, Feb 17, 2016 at 8:43 PM, Ian Romanick

[Mesa-dev] [PATCH 16/22] meta/blit: Generate MSAA-MSAA shader with a single ralloc_asprintf call

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c

[Mesa-dev] [PATCH 11/22] meta/blit: Use correct offsets for MSAA-MSAA copy blits of integer data

From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94142 --- src/mesa/drivers/common/meta_blit.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 14/22] meta/blit: Fix up #extension lines

From: Ian Romanick GL_ARB_texture_multisample is required for MSAA-MSAA and MSAA-SS blits. GL_ARB_sample_shading is required for MSAA-MSAA blits, but it is not used for MSAA-SS blits. GL_ARB_gpu_shader5 is required for some MSAA-MSAA blits, but it is not used for

[Mesa-dev] [PATCH 01/22] i965/meta: Delete unused layer shader uniform

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c

[Mesa-dev] [PATCH 22/22] meta/blit: Use GL_EXT_shader_samples_identical in MSAA-SS resolve blit

From: Ian Romanick Somewhat surprisingly, this didn't have any affect on performance in the benchmarks that Martin tried for me. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 10 +- 1 file changed, 9

[Mesa-dev] [PATCH 13/22] meta/blit: Generate separate shaders for MSAA-MSAA and MSAA-SS blits

From: Ian Romanick This just copies and pastes the same code to both places. The next patches will clean it up. This was done to ease reviewing. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 65

[Mesa-dev] [PATCH 19/22] meta/blit: Don't dynamically select the MSAA "merge" function

From: Ian Romanick Just include all 3 versions in the shader. The GLSL type system will pick the correct one. This simplifies the code a bit, and it helps pave the way for additional simplifications. Signed-off-by: Ian Romanick ---

[Mesa-dev] [PATCH 07/22] i965/meta: Store source scale and offset as vec2s

From: Ian Romanick This has a few small benefits. 1. Reduces the size (and the tracking size) of the shaders. This should basically undo the text expansion done previously. 2. Reduces the number of _mesa_Uniform* calls from 4 to 2. This means half as much time spent

[Mesa-dev] [PATCH 12/22] meta/blit: Use explicit uniform locations in scaled MSAA blit shader

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c

[Mesa-dev] [PATCH 15/22] meta/blit: MSAA-MSAA blit doesn't need a merge function

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta_blit.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index

[Mesa-dev] [PATCH 17/22] meta/blit: Don't use a vector second operand to shift operations

From: Ian Romanick The GLSL spec says: "The shift operators (<<) and (>>) One operand can be signed while the other is unsigned. In all cases, the resulting type will be the same type as the left operand. If the first operand is a scalar, the second

[Mesa-dev] [PATCH 02/22] i965/meta: Small refactor to eliminate duplicated code

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 37 - 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c

[Mesa-dev] [PATCH 04/22] i965/meta: Silence unused parameter warnings

From: Ian Romanick The brw and irb parameters to get_buffer_rect appear to be unused since the function was introduced in 2f28a0d. They seem unnecessary, and this was probably just something Kristian overlooked. The ctx parameter to brw_meta_mirror_clip_and_scissor

[Mesa-dev] [PATCH 06/22] i965/meta: Clean up return type of setup_program

From: Ian Romanick After the previous commit, the return type is not used. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 18/22] meta/blit: Replace the gl_FragColor write

From: Ian Romanick Explicitly write to each output. This also resolves the issue from commit a6022e54 for integer and uint targets too. Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 7 -

[Mesa-dev] [PATCH 20/22] meta/blit: Don't dynamically select the MSAA "emit" function

From: Ian Romanick Just include all 3 versions in the shader. The GLSL type system will pick the correct one. This simplifies the code a bit, and it helps pave the way for additional simplifications. For vec4 outputs, we have to make out_color not be a shader output.

[Mesa-dev] [PATCH 09/22] i965/meta: Store destination bounding rectangle as a vec4

From: Ian Romanick This has a few small benefits. 1. Reduces the size (and the tracking size) of the shaders. This should basically undo the text expansion done previously. 2. Reduces the number of _mesa_Uniform* calls from 4 to 1. This means half as much time spent

[Mesa-dev] [PATCH 10/22] i965/meta: Unscalarize some calculations

From: Ian Romanick After the previous changes, it just looked weird. Everyone that saw it would wonder whether there was some magic reason it had to be that way. At the end of the day, it should produce identical code. textdata bss dec hex filename

[Mesa-dev] [PATCH 21/22] meta/blit: Use a single, master shader template for MSAA-SS blits

From: Ian Romanick This changes the text of the shader quite significantly, but it should produce the same (or nearly same) code. This makes the shader much easier to understand because the code is now all in one place instead of being scattered about the C code. This

[Mesa-dev] [PATCH 03/22] i965/meta: Use explicit uniform locations in fast clear shader

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c

[Mesa-dev] [PATCH 08/22] i965/meta: Store destination offset and scale as a vec2s

From: Ian Romanick This has a few small benefits. 1. Reduces the size (and the tracking size) of the shaders. This should basically undo the text expansion done previously. 2. Reduces the number of _mesa_Uniform* calls from 4 to 2. This means half as much time spent

[Mesa-dev] [PATCH 05/22] i965/meta: Use explicit uniform locations in stencil blit shaders

From: Ian Romanick Skip all this _mesa_GetUniformLocation nonsense. We can just tell the linker where to put the uniforms. This makes the text size slightly larger (at least on x64) because "layout(location=X)" is quite a few characters, and it is repeated 13 times.

[Mesa-dev] [PATCH 4/4] OpenSWR build changes

--- configure.ac | 18 scons/custom.py | 2 +- scons/llvm.py | 8 +- src/gallium/Makefile.am | 6 ++ src/gallium/SConscript| 3 +

[Mesa-dev] [PATCH 3/4] Mesa changes for adding OpenSWR

C++ protection on gallium functions needed for a C++ driver. Add swr driver as a software target. --- src/gallium/auxiliary/gallivm/lp_bld_flow.h| 7 ++ src/gallium/auxiliary/gallivm/lp_bld_init.h| 7 ++ src/gallium/auxiliary/gallivm/lp_bld_sample.h | 6 +

[Mesa-dev] [PATCH 0/4] OpenSWR driver addition

This patch series adds the OpenSWR driver, a new software rasterizer project by Intel. The goal of this project is to create a high performance, highly scalable renderer targeted towards visualization workloads. For geometry heavy workloads we see a considerable speedup over llvmpipe, which is

[Mesa-dev] [PATCH v2 1/2] mesa: add GL_OES_texture_border_clamp support

Only minor differences to the existing ARB_texture_border_clamp support. Signed-off-by: Ilia Mirkin --- v1 -> v2: added a patch to add the EXT version of this extension docs/GL3.txt| 2 +- src/mapi/glapi/gen/es_EXT.xml | 58

[Mesa-dev] [PATCH v2 2/2] mesa: add GL_EXT_texture_border_clamp support

This extension is identical to GL_OES_texture_border_clamp. But dEQP has tests that want the EXT variant. Signed-off-by: Ilia Mirkin --- src/mapi/glapi/gen/EXT_texture_integer.xml | 8 src/mapi/glapi/gen/es_EXT.xml | 30 ++

Re: [Mesa-dev] [PATCH] glcpp: Disallow "defined" as a macro name.

Yes please. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

I ran this through our CI, and I didn't see any regressions cause by it. I think this is correct, so this patch is Reviewed-by: Ian Romanick On 02/17/2016 01:35 PM, Rob Clark wrote: > src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >

[Mesa-dev] [PATCH] mesa: check fbo completeness based on internal format, not driver format

The underlying format can be anything. Specifically in the stencil-only case, it might be a depth/stencil format. However we still want to refuse such an attachment when bound to GL_DEPTH, so we must check the base format that the texture was created with, rather than backed out from the

Re: [Mesa-dev] [PATCH] mesa: implement a display list / glBitmap texture atlas

On 15.02.2016 11:52, Brian Paul wrote: This improves the performance of applications which use glXUseXFont() or wglUseFontBitmaps() and glCallLists() to draw bitmap text. Basically, we collect all the glBitmap images from the display lists and put them into a texture atlas. To render the

[Mesa-dev] [PATCH v2] mesa: add GL_OES_texture_stencil8 support

It's basically the same thing as GL_ARB_texture_stencil8 except that glCopyTexImage isn't supported, so add STENCIL_INDEX to the list of invalid GLES formats for glCopyTexImage. Signed-off-by: Ilia Mirkin --- v1 -> v2: add checking to es3_error_check_format_and_type. I

[Mesa-dev] gl_render_buffer->_BaseFormat

Hi Brian, In commit commit 45e76d2665b38ba3787548310efc59e969124c01 Author: Brian Paul Date: Thu Oct 8 20:27:27 2009 -0600 mesa: remove a bunch of gl_renderbuffer fields _ActualFormat is replaced by Format (MESA_FORMAT_x). ColorEncoding, ComponentType,

[Mesa-dev] [PATCH] glcpp: Disallow "defined" as a macro name.

Both GCC and Clang disallow this, and glslang has recently started disallowing it as well. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94188 Signed-off-by: Kenneth Graunke --- src/compiler/glsl/glcpp/glcpp-parse.y | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

Am 17.02.2016 um 22:09 schrieb Rowley, Timothy O: >> On Nov 18, 2015, at 12:34 PM, Emil Velikov >> wrote: I have no objections against >> getting this merged, although here are a couple of things that >> should be sorted. Some of these are just reiteration from others: >

Re: [Mesa-dev] [PATCH] mesa: default DepthMode to GL_RED on ES 3.0

On Wed, Feb 17, 2016 at 4:00 PM, Ian Romanick wrote: > I think we need to change DepthMode in GLES when the texture image is > set (by glTexImage or glTexStorage). I think doing the mode swizzle in > the driver means glGetTexParameteriv(GL_DEPTH_MODE) will return the >

Re: [Mesa-dev] [PATCH] nv50/ir: emit VOTE instruction

On Wed, Feb 17, 2016 at 6:16 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 > .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 24 + >

Re: [Mesa-dev] [PATCH 26/28] glsl: lower tessellation varyings packed with component layout qualifier

Timothy, I looked at the patch and feel that I'm not the right person to review it. I know very little about tessellation. Maybe Ken has some useful comments. On Fri, Feb 5, 2016 at 5:12 PM, Timothy Arceri wrote: > Hi Anuj/anyone who feels like reviewing, > > As

Re: [Mesa-dev] [PATCH v2] mesa: allow multisampled format info to be returned on GLES 3.1

On Wed, 2016-02-17 at 14:51 -0500, Ilia Mirkin wrote: > The restriction on multisampled integer texture formats only applies > to > GLES 3.0, so don't apply it to GLES 3.1 contexts. This fixes a slew > of > > dEQP-GLES31.functional.state_query.internal_format.* > > tests, which now all pass. >

[Mesa-dev] [PATCH] gallium/cso: only enable compute shaders when TGSI is supported

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94186 Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.c

[Mesa-dev] [PATCH] nv50/ir: emit VOTE instruction

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 4 .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 24 + .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 25 ++

Re: [Mesa-dev] [PATCH 6/7] glx: remove incorrect refcounting of DRIdrawable

On 02/14/2016 02:46 AM, Ian Romanick wrote: On 02/11/2016 12:58 PM, Miklós Máté wrote: On 02/09/2016 05:02 PM, Ian Romanick wrote: On 02/08/2016 05:11 PM, Ian Romanick wrote: On 02/05/2016 01:11 PM, Miklós Máté wrote: dri drawables must never be released when unbound from a context as long

[Mesa-dev] [PATCH] i965: Push most TES inputs in vec4 mode.

(This is commit 4a1c8a3037cd29938b2a6e2c680c341e9903cfbe for vec4 mode.) Using the push model for inputs is much more efficient than pulling inputs - the hardware can simply copy a large chunk into URB registers at thread creation time, rather than having the thread send messages to request data

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

On Wed, Feb 17, 2016 at 4:40 PM, Patrick Baggett wrote: > On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >>

Re: [Mesa-dev] Gallium Vulkan state tracker?

> This category of ideas is something that I have given a bit of thought. The > tentative conclusion I've come to is that it would be possible to implement > GL on Vulkan given a few extensions and a few carefully chosen assumptions > about the underlying Vulkan driver. For instance, we could

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark wrote: > src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status > {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined > but not used [-Wunused-function] >

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

On 02/17/2016 10:36 PM, Ilia Mirkin wrote: On Wed, Feb 17, 2016 at 4:36 PM, Samuel Pitoiset wrote: On 02/17/2016 10:33 PM, Ilia Mirkin wrote: Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? Perhaps just not implemented yet...) Pretty

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

On Wed, Feb 17, 2016 at 4:36 PM, Samuel Pitoiset wrote: > > > On 02/17/2016 10:33 PM, Ilia Mirkin wrote: >> >> Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? >> Perhaps just not implemented yet...) > > > Pretty sure that SELP won't be useful for

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

On 02/17/2016 10:33 PM, Ilia Mirkin wrote: Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? Perhaps just not implemented yet...) Pretty sure that SELP won't be useful for shared+atomics on GK110+ because I don't use it GK104 IIRC. On Wed, Feb 17, 2016 at 4:27 PM,

Re: [Mesa-dev] [PATCH] gallivm, tgsi: provide fake sample_i_ms implementations

On 17/02/16 19:42, srol...@vmware.com wrote: From: Roland Scheidegger Just like the rest of the msaa "implementation" it's just fake for now... --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 7 ++- src/gallium/auxiliary/tgsi/tgsi_exec.c | 8 +---

[Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined but not used [-Wunused-function] lower_discard_flow_visitor::visit_enter(ir_loop_jump *ir) ^~ The base class method

Re: [Mesa-dev] ANNOUNCE: An open-source Vulkan driver for Intel hardware

17. feb. 2016 16.37 skrev "Jason Ekstrand" : > > On Tue, Feb 16, 2016 at 11:41 PM, Iago Toral wrote: >> >> Hey Jason, >> >> this is awesome news, congrats to all the people involved! > > > Thanks! > >> >> Did you have a chance to try the new driver with

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? Perhaps just not implemented yet...) On Wed, Feb 17, 2016 at 4:27 PM, Samuel Pitoiset wrote: > This OP_SELP insn will be used to handle compare and swap subops. > > Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH] glsl: fix standalone compiler

From: Rob Clark Need to set some non-zero limits for MaxCombinedUniformComponents, otherwise we hit an "Too many shader uniform components" error in the linker. Signed-off-by: Rob Clark --- src/compiler/glsl/main.cpp | 12 1

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

On Tue, Feb 16, 2016 at 2:32 PM, Ian Romanick wrote: > On 02/16/2016 10:58 AM, Rob Clark wrote: >> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning: ‘ir_visitor_status >> {anonymous}::lower_discard_flow_visitor::visit_enter(ir_loop_jump*)’ defined >> but not used

[Mesa-dev] [PATCH v3 13/14] nv50/ir: add atomics support on shared memory for Fermi

Changes from v2: - make sure the op is OP_SELP when emitting the predicate and add one assert - use bld.getSSA() for mkOp2() - add cross edge between tryLockAndSetBB and joinBB Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp

[Mesa-dev] [PATCH v3 04/14] nvc0: bind driver constbuf for compute on Fermi

Changes from v3: - add new validation state for COMPUTE driver constbuf Changes from v2: - always bind the driver consts even if user params come in via clover Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c| 18

[Mesa-dev] [PATCH v3 10/14] nv50/ir: use s[] addr space for shared buffers

Shared memory address space (FILE_MEMORY_SHARED) must be used instead of global memory when a shared memory area is declared. Changes from v2: - oops, do not remove TGSI_FILE_BUFFER in a switch in nv50_ir_from_tgsi.cpp Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v3 09/14] nvc0: reduce likelihood of collision for real buffers on Fermi

Reduce likelihood of collision with real buffers by placing the hole at the top of the 4G area. This fixes some indirect draw+compute tests with large buffers. Suggested by Ilia Mirkin. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v3 03/14] nvc0: add a new validation state for 3D driver constbuf

This will be used to invalidate 3D driver constbuf when using COMPUTE and vice-versa. This is needed because this CB contains a bunch of useful information like the addrs of shader buffers. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v3 08/14] nvc0: invalidate compute state when switching pipe contexts

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c

[Mesa-dev] [PATCH v3 05/14] nvc0: bind shader buffers for compute on Fermi

This is loosely based on 3D. Shader buffers are bound on c15 (the driver constbuf) at offset 0x200. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 34 + src/gallium/drivers/nouveau/nvc0/nvc0_context.c | 11

[Mesa-dev] [PATCH v3 14/14] nvc0: enable compute shaders on Fermi

Kepler compute support is really different than Fermi and it's not ready yet. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v3 11/14] nv50/ir: add lock/unlock subops for load/store

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h| 2 ++ .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp| 16 ++-- src/gallium/drivers/nouveau/codegen/nv50_ir_print.cpp| 10 ++ 3 files

[Mesa-dev] [PATCH v3 02/14] nvc0: bind constant buffers for compute on Fermi

Loosely based on 3D. Changs from v3: - invalidate COMPUTE CBs after validating 3D CBs because they are aliased Changes from v2: - get rid of the 's' param to nvc0_cb_bo_push() because it doesn't matter to upload constbufs for compute using the 3d chan Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v3 06/14] nvc0: bind textures/samplers for compute on Fermi

Textures and samplers don't seem to be aliased between COMPUTE and 3D. Changes from v2: - refactor the code to share (almost) the same logic between 3d and compute Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 38

[Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

This OP_SELP insn will be used to handle compare and swap subops. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 8 src/gallium/drivers/nouveau/codegen/nv50_ir_inlines.h | 4 ++-- 2 files changed, 6

[Mesa-dev] [PATCH v3 07/14] nvc0: add support for indirect compute on Fermi

When indirect compute is used, the size of the grid (in blocks) is stored as three integers inside a buffer. This requires a macro to set up GRIDDIM_YX and GRIDDIM_Z. Changes from v2: - do not launch the grid if the number of groups for a dimension is 0 Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v3 00/14] nvc0: add compute shaders on Fermi

Hi, This series adds support for ARB_compute_shader only on Fermi. Kepler compute support is really different and I need to fix a bunch of things to make it work correctly. Almost all piglit/dEQP tests pass. The list of fails is available below. Samuel Pitoiset (14): nvc0: allocate an area

[Mesa-dev] [PATCH v3 01/14] nvc0: allocate an area for compute user constbufs

For compute shaders, we might need to upload uniforms. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 14 +++--- src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 12 ++--

[Mesa-dev] [PATCH 1/2] nv50/ir: add PostRADCE Pass

helps shaders in Saints Row IV, bioshock infinite and shadow warrior no change in default shader-db changes in my shader-db total instructions in shared programs : 1801054 -> 1794281 (-0.38%) total gprs used in shared programs: 233059 -> 233059 (0.00%) total local used in shared programs :

[Mesa-dev] [PATCH 2/2] nv50/ir: optimize sub(a, 0) to a

helps a 0ad shader in default shader-db: total instructions in shared programs : 102863 -> 102861 (-0.00%) total gprs used in shared programs: 14725 -> 14725 (0.00%) total local used in shared programs : 129 -> 129 (0.00%) total bytes used in shared programs : 943944 -> 943928 (-0.00%)

[Mesa-dev] [PATCH 0/2] more nouveau optimisations

Karol Herbst (2): nv50/ir: add PostRADCE Pass nv50/ir: optimize sub(a, 0) to a src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 +- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 77 ++ 2 files changed, 52 insertions(+), 27 deletions(-) -- 2.7.1

Re: [Mesa-dev] Introducing OpenSWR: High performance software rasterizer

> On Nov 18, 2015, at 12:34 PM, Emil Velikov wrote: > I have no objections against getting this merged, although here are a > couple of things that should be sorted. Some of these are just > reiteration from others: Sorry about the delay responding to this; we’ve been

Re: [Mesa-dev] [PATCH] mesa: default DepthMode to GL_RED on ES 3.0

On 02/16/2016 11:14 PM, Kenneth Graunke wrote: > On Tuesday, February 16, 2016 6:29:39 PM PST Ilia Mirkin wrote: >> See commit 9db2098d which did it internally to the i965 driver. No >> reason not to have this more globally set though. >> >> This fixes depth in a bunch of dEQP

[Mesa-dev] [Bug 94193] [llvmpipe] Line antialiasing looks different when GL_LINE_STIPPLE is enabled with pattern 0xffff

https://bugs.freedesktop.org/show_bug.cgi?id=94193 --- Comment #3 from Brian Paul --- (In reply to Roland Scheidegger from comment #2) > So if I understand this right, there's really two issues here: > 1) smooth lines don't quite work when line stippling is enabled > 2) we

Re: [Mesa-dev] [PATCH] gallivm, tgsi: provide fake sample_i_ms implementations

On 02/17/2016 12:42 PM, srol...@vmware.com wrote: From: Roland Scheidegger Just like the rest of the msaa "implementation" it's just fake for now... --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 7 ++- src/gallium/auxiliary/tgsi/tgsi_exec.c | 8

Re: [Mesa-dev] [PATCH] st/mesa: force depth mode to GL_RED for sized depth/stencil formats

On Wednesday, February 17, 2016 8:21:32 AM PST Ilia Mirkin wrote: > See commit 9db2098d for the i965 version of this. > > This fixes depth in a bunch of dEQP EXT_texture_border_clamp tests. And > probably other ones as well. > > Signed-off-by: Ilia Mirkin > Cc: Ian

[Mesa-dev] [PATCH v2] mesa: allow multisampled format info to be returned on GLES 3.1

The restriction on multisampled integer texture formats only applies to GLES 3.0, so don't apply it to GLES 3.1 contexts. This fixes a slew of dEQP-GLES31.functional.state_query.internal_format.* tests, which now all pass. Signed-off-by: Ilia Mirkin Cc: Timothy Arceri

Re: [Mesa-dev] [PATCH] mesa: allow multisampled format info to be returned on GLES 3.1

On Sun, Feb 14, 2016 at 1:28 PM, Ilia Mirkin wrote: > On Sun, Feb 14, 2016 at 5:36 AM, Timothy Arceri > wrote: >> On Sat, 2016-02-13 at 23:50 -0500, Ilia Mirkin wrote: >>> Marta, perhaps you can have a look? It's pretty similar to your >>>

[Mesa-dev] [PATCH] gallivm, tgsi: provide fake sample_i_ms implementations

From: Roland Scheidegger Just like the rest of the msaa "implementation" it's just fake for now... --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 7 ++- src/gallium/auxiliary/tgsi/tgsi_exec.c | 8 +--- 2 files changed, 11 insertions(+), 4 deletions(-)

Re: [Mesa-dev] [PATCH 2/3] i965: Lower min/max after optimization on Gen4/5.

Matt Turner writes: > On Sat, Feb 13, 2016 at 4:47 PM, Matt Turner wrote: >> On Sat, Feb 13, 2016 at 3:30 PM, Francisco Jerez >> wrote: >>> Matt Turner writes: >>> On Sat, Feb 13, 2016 at 2:02 PM,

Re: [Mesa-dev] MesaGL <-> non-Mesa OpenCL interop interface

On Sat, Feb 6, 2016 at 10:43 PM, Marek Olšák wrote: > On Sat, Feb 6, 2016 at 6:53 PM, Jason Ekstrand wrote: >> I'm adding Chad to the Cc. At some point, it would be good to get Beignet >> playing well with mesa. Personally, I have substantial

[Mesa-dev] [PATCH] i965: Allow fast-path for glReadPixels sub-rectangle case

From: Nanley Chery Since _mesa_image_row_stride() is used to calculate the destination's row stride, we can read pixels into a destination sub-rectangle (whose width is smaller than the destination buffer). Signed-off-by: Nanley Chery ---

[Mesa-dev] [Bug 94193] [llvmpipe] Line antialiasing looks different when GL_LINE_STIPPLE is enabled with pattern 0xffff

https://bugs.freedesktop.org/show_bug.cgi?id=94193 --- Comment #2 from Roland Scheidegger --- So if I understand this right, there's really two issues here: 1) smooth lines don't quite work when line stippling is enabled 2) we don't optimize fake-enabled line stippling away

Re: [Mesa-dev] [PATCH 2/3] i965: Lower min/max after optimization on Gen4/5.

On Sat, Feb 13, 2016 at 4:47 PM, Matt Turner wrote: > On Sat, Feb 13, 2016 at 3:30 PM, Francisco Jerez > wrote: >> Matt Turner writes: >> >>> On Sat, Feb 13, 2016 at 2:02 PM, Francisco Jerez >>> wrote:

Re: [Mesa-dev] [PATCH v2] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

On Wed, Feb 17, 2016 at 8:00 AM, Derek Foreman wrote: > On 16/02/16 10:37 AM, Daniel Stone wrote: > > Hi, > > > > On 16 February 2016 at 16:34, Derek Foreman > wrote: > >> +try_damage_buffer(struct dri2_egl_surface *dri2_surf, > >> +

Re: [Mesa-dev] [PATCH] [v3] i965/skl: Add two missing device IDs

On Wed, 2016-02-17 at 10:06 -0800, Ben Widawsky wrote: > The Iris part is left unbranded because we did not have these with > original SKL. > > v2: 0x192d is gt3, not gt4 > > v3: Forgot to update the temporary brand string when I did v2. > > Cc: "11.0 11.1"

  1   2   >