Re: [Mesa-dev] [PATCH 03/22] i965/meta: Use explicit uniform locations in fast clear shader

On Thu, 2016-02-18 at 10:34 -0800, Ian Romanick wrote: > On 02/18/2016 07:01 AM, Iago Toral wrote: > > On Wed, 2016-02-17 at 17:57 -0800, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> Signed-off-by: Ian Romanick > >> --- > >>

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl: support EGL_LARGEST_PBUFFER in eglCreatePbufferSurface(...)

On 02/19/2016 07:34 AM, Tapani Pälli wrote: On 02/18/2016 08:19 PM, Emil Velikov wrote: Hi guys, On 15 February 2016 at 10:54, Tapani Pälli wrote: From: Daniel Czarnowski Patch provides a 'sane default' for a set pbuffer surface size

Re: [Mesa-dev] [PATCH v2] egl_dri2: set correct error code if swapbuffers fails

Pinging Emil with this one .. On 02/15/2016 09:31 AM, Tapani Pälli wrote: From: Daniel Czarnowski A return value of '-1' means that there was error during swap with a window drawable, in this case we set error as EGL_BAD_NATIVE_WINDOW. v2: coding style cleanup,

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl: support EGL_LARGEST_PBUFFER in eglCreatePbufferSurface(...)

On 02/18/2016 08:19 PM, Emil Velikov wrote: Hi guys, On 15 February 2016 at 10:54, Tapani Pälli wrote: From: Daniel Czarnowski Patch provides a 'sane default' for a set pbuffer surface size when Perhaps too cheeky of a question but "who

[Mesa-dev] [PATCH v2 3/6] __cplusplus exports around more gallium utilities

--- src/gallium/auxiliary/gallivm/lp_bld_flow.h | 7 +++ src/gallium/auxiliary/gallivm/lp_bld_init.h | 7 +++ src/gallium/auxiliary/gallivm/lp_bld_sample.h | 6 ++ src/gallium/auxiliary/gallivm/lp_bld_tgsi.h | 8 src/gallium/auxiliary/util/u_dl.h | 6 ++

[Mesa-dev] [PATCH v2 6/6] OpenSWR documentation

--- src/gallium/docs/source/openswr.rst | 21 src/gallium/docs/source/openswr/faq.rst | 141 ++ src/gallium/docs/source/openswr/knobs.rst | 114 + src/gallium/docs/source/openswr/profiling.rst | 67

[Mesa-dev] [PATCH v2 4/6] OpenSWR added to mesa software renderers

--- .../auxiliary/target-helpers/inline_sw_helper.h| 11 + .../target-helpers/inline_wrapper_sw_helper.h | 2 +- src/gallium/targets/libgl-gdi/libgl_gdi.c | 28 ++ 3 files changed, 36 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH v2 0/6] OpenSWR driver addition

Thanks for review comments. Changes since v1: * split patch 3/4 (mesa changes) into two patches * restore llvmpipe as the default software renderer * add documentation Not resending old patches still current: * 1/4 (OpenSWR driver) * 2/4 (OpenSWR rasterizer) * 4/4 (OpenSWR build

Re: [Mesa-dev] [PATCH 1/2] gallium/os: Add CPU time functions

On Fri, Feb 19, 2016 at 12:59:18AM +0100, Bas Nieuwenhuizen wrote: > Adds functions to query the elapsed CPU time of the current process > or thread. Implements Linux support only. > > To be used by the gallium HUD. Wouldn't this be better gated by a configure test? clock_gettime(2) is

Re: [Mesa-dev] [PATCH 3/4] Mesa changes for adding OpenSWR

Switching the default renderer to swr was part of our development so that we could get users to test our driver without accidentally forgetting to change the driver and ending up with llvmpipe. I was thinking we might be able to leave that change in since swr isn’t in the default automake

Re: [Mesa-dev] [PATCH 25/25] radeonsi: implement binary shaders & shader cache in memory

Reviewed-by: Nicolai Hähnle On 18.02.2016 16:10, Marek Olšák wrote: A new version of the patch is attached. Please review. Marek On Tue, Feb 16, 2016 at 6:02 PM, Nicolai Hähnle wrote: On 15.02.2016 18:59, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH 10/25] radeonsi: add code for dumping all shader parts together

On 19.02.2016 03:22, Marek Olšák wrote: > A new version of the patch is attached. Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [Mesa-dev] [PATCH 0/4] OpenSWR driver addition

On Thu, Feb 18, 2016 at 6:46 PM, Brian Paul wrote: > On 02/17/2016 06:53 PM, Tim Rowley wrote: >> >> This patch series adds the OpenSWR driver, a new software rasterizer >> project by Intel. The goal of this project is to create a high >> performance, highly scalable renderer

[Mesa-dev] [PATCH 2/2] trace: assorted whitespace and formatting fixes

--- src/gallium/drivers/trace/tr_context.c | 60 ++ 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/src/gallium/drivers/trace/tr_context.c b/src/gallium/drivers/trace/tr_context.c index db6ad40..57f8518 100644 ---

[Mesa-dev] [PATCH 1/2] trace: remove unneeded inline qualifiers

--- src/gallium/drivers/trace/tr_context.c | 92 +- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/src/gallium/drivers/trace/tr_context.c b/src/gallium/drivers/trace/tr_context.c index 0028377..db6ad40 100644 ---

Re: [Mesa-dev] [PATCH 22/22] meta/blit: Use GL_EXT_shader_samples_identical in MSAA-SS resolve blit

On 02/18/2016 01:47 PM, Ian Romanick wrote: > On 02/18/2016 08:44 AM, Neil Roberts wrote: >> I made a pathological test case (attached) which repeatedly renders into >> an MSAA FBO and then blits it to the screen and measures the framerate. >> It checks it with a range of different sample counts.

[Mesa-dev] [PATCH 2/2] gallium/hud: Add a frame time query

Implements a query that tracks the time between frames. It can track three things: - wall clock time - elapsed time of the process - elapsed time of the current thread The last option is bogus when the context is passed around between threads, but is still very useful for the many

[Mesa-dev] [PATCH 1/2] gallium/os: Add CPU time functions

Adds functions to query the elapsed CPU time of the current process or thread. Implements Linux support only. To be used by the gallium HUD. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/auxiliary/os/os_time.c | 48 ++

Re: [Mesa-dev] [PATCH 0/4] OpenSWR driver addition

On 02/17/2016 06:53 PM, Tim Rowley wrote: This patch series adds the OpenSWR driver, a new software rasterizer project by Intel. The goal of this project is to create a high performance, highly scalable renderer targeted towards visualization workloads. For geometry heavy workloads we see a

Re: [Mesa-dev] GLSL error

On Thu, Feb 18, 2016 at 5:01 PM, Fu, Sheng wrote: > Hi all, > > > > I ran into a GLSL error when run my GLSL shader. I use Mesa llvm driver. > > The following is the error message I got: > > > >> src/mesa/state_tracker/st_glsl_to_tgsi.cpp:2194: virtual void > >>

Re: [Mesa-dev] [PATCH] mesa: add special case ubyte[4] / BGRA conversion function

On 02/18/2016 03:03 PM, Roland Scheidegger wrote: Looks ok to me, albeit the sse2 code I posted a while ago for handling swizzled stores probably would be faster still (though only with x86 sse2...). At least I think it would hit this (if not the next patch in the series should...). It would

Re: [Mesa-dev] GLSL error

On 02/18/2016 03:01 PM, Fu, Sheng wrote: Hi all, I ran into a GLSL error when run my GLSL shader. I use Mesa llvm driver. The following is the error message I got: > src/mesa/state_tracker/st_glsl_to_tgsi.cpp:2194: virtual void > glsl_to_tgsi_visitor::visit(ir_expression*): Assertion

Re: [Mesa-dev] [PATCH 3/4] Mesa changes for adding OpenSWR

One comment inline... Am 18.02.2016 um 02:53 schrieb Tim Rowley: > C++ protection on gallium functions needed for a C++ driver. > Add swr driver as a software target. > --- > src/gallium/auxiliary/gallivm/lp_bld_flow.h| 7 ++ > src/gallium/auxiliary/gallivm/lp_bld_init.h| 7

Re: [Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, February 18, 2016 12:30 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: allow non-contiguous VS input declarations This

Re: [Mesa-dev] [PATCH] st/mesa: fix pbo uploads

On 18.02.2016 01:26, Ilia Mirkin wrote: On Thu, Feb 18, 2016 at 1:07 AM, Ilia Mirkin wrote: - LOD must be provided in .w for TXF (even for buffer textures) - User buffer must be valid at draw time Good catch. - Must have a sampler associated with the sampler

Re: [Mesa-dev] [PATCH 2/2] gallivm: Check whether to stop disassemble only for x86

Am 18.02.2016 um 17:23 schrieb Oded Gabbay: > Because the if statement that checks whether we have a return > statement is valid only on x86, surround it with X86 or X86-64 > arch defines > > Signed-off-by: Oded Gabbay > --- >

Re: [Mesa-dev] [PATCH] mesa: add special case ubyte[4] / BGRA conversion function

Looks ok to me, albeit the sse2 code I posted a while ago for handling swizzled stores probably would be faster still (though only with x86 sse2...). At least I think it would hit this (if not the next patch in the series should...). Matt Turner reviewed the first 2 patches in the series (albeit I

[Mesa-dev] GLSL error

Hi all, I ran into a GLSL error when run my GLSL shader. I use Mesa llvm driver. The following is the error message I got: > src/mesa/state_tracker/st_glsl_to_tgsi.cpp:2194: virtual void > glsl_to_tgsi_visitor::visit(ir_expression*): Assertion `!"Invalid ir > opcode in

[Mesa-dev] [Bug 83631] /usr/include/GL/glxext.h:480:143: error: 'GLintptr' has not been declared

https://bugs.freedesktop.org/show_bug.cgi?id=83631 Orion Poplawski changed: What|Removed |Added Status|NEEDINFO|RESOLVED

Re: [Mesa-dev] [PATCH 22/22] meta/blit: Use GL_EXT_shader_samples_identical in MSAA-SS resolve blit

On 02/18/2016 08:44 AM, Neil Roberts wrote: > I made a pathological test case (attached) which repeatedly renders into > an MSAA FBO and then blits it to the screen and measures the framerate. > It checks it with a range of different sample counts. The rendering is > done either by rendering two

Re: [Mesa-dev] [PATCH 25/25] radeonsi: implement binary shaders & shader cache in memory

A new version of the patch is attached. Please review. Marek On Tue, Feb 16, 2016 at 6:02 PM, Nicolai Hähnle wrote: > On 15.02.2016 18:59, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_pipe.c | 5 +-

Re: [Mesa-dev] [PATCH 1/2] gallivm: use sstream for dissasembling

On 18/02/16 16:23, Oded Gabbay wrote: Currently, disassemble() directly prints to stdout. This has broke the profiling support for llvmpipe JIT code. This patch redirects the output to an sstream object, which is then either gets printed to stdout (for assembly debugging) or gets written to a

Re: [Mesa-dev] [PATCH] mesa: add special case ubyte[4] / BGRA conversion function

On 18/02/16 15:52, Brian Paul wrote: This reduces a glTexImage(GL_RGBA, GL_UNSIGNED_BYTE) hot spot in when storing the texture as BGRA. --- src/mesa/main/format_utils.c | 74 +--- 1 file changed, 69 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

This fixes a glDrawPixels regression since b63fe0552b5f. The new quad-drawing utility code uses 3 vertex attributes (xyz, rgba, st). For glDrawPixels path we don't use the rgba attribute so there's a gap in the TGSI VS input declarations (INPUT[0] = pos, INPUT[2] = texcoord). The TGSI->VGPU10

Re: [Mesa-dev] [PATCH] st/mesa: disable depth/stencil/alpha tests in PBO upload

Reviewed-by: Marek Olšák Marek On Thu, Feb 18, 2016 at 8:34 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Noticed by Brian Paul. > --- > src/mesa/state_tracker/st_cb_texture.c | 8 > 1 file changed, 8

[Mesa-dev] [PATCH] st/mesa: disable depth/stencil/alpha tests in PBO upload

From: Nicolai Hähnle Noticed by Brian Paul. --- src/mesa/state_tracker/st_cb_texture.c | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index d09c360..8ee95d2 100644 ---

Re: [Mesa-dev] [PATCH] mesa/dri/r200: Refrain from using symbol links in repo

On 18 February 2016 at 06:23, wrote: > Disregard, apparently this breaks out-of-tree builds. There perhaps is maybe > no good solution here so i`ll refrain from this can of worms for now. > I've shared a rough plan [1] how to resolve things not too long ago. Feel

Re: [Mesa-dev] [PATCH] gallium: introduce load_pipe_screen()

On 18 February 2016 at 17:47, Rob Clark wrote: > On Thu, Feb 18, 2016 at 11:48 AM, Emil Velikov > wrote: >> Hi Rob, >> >> On 10 February 2016 at 22:56, Rob Herring wrote: >>> Introduce load_pipe_screen() public entry point for

Re: [Mesa-dev] [PATCH v2] egl/wayland: Try to use wl_surface.damage_buffer for SwapBuffersWithDamage

On 16 February 2016 at 16:37, Daniel Stone wrote: > Hi, > > On 16 February 2016 at 16:34, Derek Foreman wrote: >> +try_damage_buffer(struct dri2_egl_surface *dri2_surf, >> + const EGLint *rects, >> + EGLint n_rects)

Re: [Mesa-dev] [PATCH 01/10] util: fix new gcc6 warnings

This patch is Reviewed-by: Ian Romanick On 02/17/2016 09:34 AM, Rob Clark wrote: > src/util/hash_table.h:111:23: warning: ‘_mesa_fnv32_1a_offset_bias’ defined > but not used [-Wunused-const-variable] > static const uint32_t _mesa_fnv32_1a_offset_bias = 2166136261u; >

Re: [Mesa-dev] [PATCH] mesa: add GL_OES_copy_image support

On 02/15/2016 05:41 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > > I ran this with the dEQP tests, and other than the caveats below, they seem to > mostly work. > > The biggest caveat is that this can't actually be enabled for any drivers that > don't

Re: [Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

On 02/18/2016 11:36 AM, Charmaine Lee wrote: From: Brian Paul Sent: Thursday, February 18, 2016 7:51 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: allow non-contiguous VS input declarations This fixes a glDrawPixels regression since

Re: [Mesa-dev] [PATCH 08/10] glsl: fix new gcc6 warnings

On 17 February 2016 at 22:43, Rob Clark wrote: > On Wed, Feb 17, 2016 at 4:40 PM, Patrick Baggett > wrote: >> On Wed, Feb 17, 2016 at 3:35 PM, Rob Clark wrote: >>> src/compiler/glsl/lower_discard_flow.cpp:79:1: warning:

[Mesa-dev] [Bug 93965] Please backport OSMesaCreateContextAttribs to 11.1

https://bugs.freedesktop.org/show_bug.cgi?id=93965 --- Comment #4 from Dennis Schridde --- I am personally already using a custom build of a Git snapshot of Mesa 11.2 anyway (commit 24ea81a, mimicking the current Fedora Rawhide package, with a minor configure

Re: [Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

>From: Brian Paul >Sent: Thursday, February 18, 2016 7:51 AM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH] svga: allow non-contiguous VS input declarations > >This fixes a glDrawPixels regression since b63fe0552b5f. The new >quad-drawing utility

Re: [Mesa-dev] [PATCH 03/22] i965/meta: Use explicit uniform locations in fast clear shader

On 02/18/2016 07:01 AM, Iago Toral wrote: > On Wed, 2016-02-17 at 17:57 -0800, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 14 -- >> 1 file

[Mesa-dev] [Bug 93965] Please backport OSMesaCreateContextAttribs to 11.1

https://bugs.freedesktop.org/show_bug.cgi?id=93965 --- Comment #3 from Emil Velikov --- s/will be tomorrow/will be out tomorrow/ With the final 11.2.0 around 3-4 weeks after that. -- You are receiving this mail because: You are the assignee for the bug. You are the

[Mesa-dev] [Bug 93965] Please backport OSMesaCreateContextAttribs to 11.1

https://bugs.freedesktop.org/show_bug.cgi?id=93965 --- Comment #2 from Emil Velikov --- Hi Dennis, while getting this new functionality in older mesa releases will be great, I really like to avoid adding features in a stable/bugfix only releases. I'm wondering if you

Re: [Mesa-dev] [PATCH] mesa: add GL_OES_copy_image support

On Thu, Feb 18, 2016 at 1:14 PM, Ian Romanick wrote: > On 02/15/2016 05:41 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> >> I ran this with the dEQP tests, and other than the caveats below, they seem >> to >> mostly work. >> >> The

Re: [Mesa-dev] [PATCH 04/22] i965/meta: Silence unused parameter warnings

On 02/18/2016 07:18 AM, Iago Toral wrote: > On Wed, 2016-02-17 at 17:57 -0800, Ian Romanick wrote: >> From: Ian Romanick >> >> The brw and irb parameters to get_buffer_rect appear to be unused since >> the function was introduced in 2f28a0d. They seem unnecessary, and

Re: [Mesa-dev] [PATCH 10/25] radeonsi: add code for dumping all shader parts together

A new version of the patch is attached. Marek On Tue, Feb 16, 2016 at 4:12 AM, Michel Dänzer wrote: > On 16.02.2016 08:59, Marek Olšák wrote: >> From: Marek Olšák > > [...] > >> @@ -4199,13 +4200,27 @@ static void si_shader_dump_stats(struct si_screen

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl: support EGL_LARGEST_PBUFFER in eglCreatePbufferSurface(...)

Hi guys, On 15 February 2016 at 10:54, Tapani Pälli wrote: > From: Daniel Czarnowski > > Patch provides a 'sane default' for a set pbuffer surface size when Perhaps too cheeky of a question but "who is to determine these 'sane defaults'" ?

Re: [Mesa-dev] [PATCH] st/mesa: implement a simple cache for glDrawPixels

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, February 18, 2016 7:52 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] st/mesa: implement a simple cache for glDrawPixels

Re: [Mesa-dev] [PATCH] gallium: introduce load_pipe_screen()

On Thu, Feb 18, 2016 at 11:48 AM, Emil Velikov wrote: > Hi Rob, > > On 10 February 2016 at 22:56, Rob Herring wrote: >> Introduce load_pipe_screen() public entry point for other code which >> dlopen()'s gralloc_dri.so for purposes of loading a

Re: [Mesa-dev] [PATCH v2 4/4] Android: disable unused-parameter warning

Hi Rob, On 2 February 2016 at 20:45, Rob Herring wrote: > Android builds with -Wunused-parameter enabled which results in spewing > lots of warnings. Disable it so more meaningful warnings are more visible. > > Signed-off-by: Rob Herring > Reviewed-by: Emil

Re: [Mesa-dev] [PATCH 1/4] mesa: gl_NumSamples should always be at least one

On Thu, Feb 18, 2016 at 7:07 AM, Neil Roberts wrote: > Looks good to me. Interestingly we have a test for it in Piglit which > gets run with samples=0 and it is currently passing so presumably it is > broken. Indeed. I sent a patch for this last night as well. I'll push it

Re: [Mesa-dev] [PATCH v2 1/4] Android: fix x86 gallium builds

Hi Rob, On 2 February 2016 at 20:45, Rob Herring wrote: > Builds with gallium enabled fail on x86 with linker error: > > external/mesa3d/src/mesa/vbo/vbo_exec_array.c:127: error: undefined reference > to '_mesa_uint_array_min_max' > > The problem is sse_minmax.c is not included

Re: [Mesa-dev] [PATCH v2 1/5] egl: Add EGL_FRAMEBUFFER_TARGET_ANDROID attribute

Hi Rob, On 2 February 2016 at 20:23, Rob Herring wrote: > This is used by Android to select an eglconfig compatible with HWComposer. > > Signed-off-by: Rob Herring > --- > v2: > - Also add reporting the extension string > > src/egl/main/eglapi.c | 1 + >

Re: [Mesa-dev] [PATCH] gallium: introduce load_pipe_screen()

Hi Rob, On 10 February 2016 at 22:56, Rob Herring wrote: > Introduce load_pipe_screen() public entry point for other code which > dlopen()'s gralloc_dri.so for purposes of loading a pipe_screen. This way > drm_gralloc can avoid static linking of each gallium winsys and driver, >

Re: [Mesa-dev] [PATCH] st/mesa: fix pbo uploads

On Thu, Feb 18, 2016 at 11:36 AM, Nicolai Hähnle wrote: > On 18.02.2016 01:26, Ilia Mirkin wrote: >> >> On Thu, Feb 18, 2016 at 1:07 AM, Ilia Mirkin wrote: >>> >>> - LOD must be provided in .w for TXF (even for buffer textures) >>> - User buffer

Re: [Mesa-dev] [PATCH 22/22] meta/blit: Use GL_EXT_shader_samples_identical in MSAA-SS resolve blit

I made a pathological test case (attached) which repeatedly renders into an MSAA FBO and then blits it to the screen and measures the framerate. It checks it with a range of different sample counts. The rendering is done either by rendering two triangles to fill the framebuffer or by calling

[Mesa-dev] [PATCH 2/2] gallivm: Check whether to stop disassemble only for x86

Because the if statement that checks whether we have a return statement is valid only on x86, surround it with X86 or X86-64 arch defines Signed-off-by: Oded Gabbay --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 1/2] gallivm: use sstream for dissasembling

Currently, disassemble() directly prints to stdout. This has broke the profiling support for llvmpipe JIT code. This patch redirects the output to an sstream object, which is then either gets printed to stdout (for assembly debugging) or gets written to a file in /tmp/ (for profiling support).

Re: [Mesa-dev] [PATCH] llvmpipe: add a few const qualifiers

Am 18.02.2016 um 16:52 schrieb Brian Paul: > --- > src/gallium/drivers/llvmpipe/lp_setup_context.h | 4 ++-- > src/gallium/drivers/llvmpipe/lp_setup_line.c| 2 +- > src/gallium/drivers/llvmpipe/lp_setup_tri.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] st/mesa: fix pbo uploads

Am 18.02.2016 um 16:34 schrieb Ilia Mirkin: > On Feb 18, 2016 6:16 AM, "Marek Olšák" > wrote: >> >> On Thu, Feb 18, 2016 at 7:07 AM, Ilia Mirkin > wrote: >> > - LOD must be provided in .w for TXF

[Mesa-dev] [PATCH] mesa: add special case ubyte[4] / BGRA conversion function

This reduces a glTexImage(GL_RGBA, GL_UNSIGNED_BYTE) hot spot in when storing the texture as BGRA. --- src/mesa/main/format_utils.c | 74 +--- 1 file changed, 69 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/format_utils.c

[Mesa-dev] [PATCH] mesa: small optimization of _mesa_expand_bitmap()

Avoid a per-pixel multiply. --- src/mesa/main/image.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/image.c b/src/mesa/main/image.c index 99f253c..4d6ab6f 100644 --- a/src/mesa/main/image.c +++ b/src/mesa/main/image.c @@ -408,9 +408,7 @@

[Mesa-dev] [PATCH] st/mesa: implement a simple cache for glDrawPixels

Instead of discarding the texture we created, keep it around in case the next glDrawPixels draws the same image again. This is intended to help application which draw the same image several times in a row, either within a frame or subsequent frames. --- src/mesa/state_tracker/st_cb_drawpixels.c

[Mesa-dev] [PATCH] llvmpipe: add a few const qualifiers

--- src/gallium/drivers/llvmpipe/lp_setup_context.h | 4 ++-- src/gallium/drivers/llvmpipe/lp_setup_line.c| 2 +- src/gallium/drivers/llvmpipe/lp_setup_tri.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_setup_context.h

[Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

This fixes a glDrawPixels regression since b63fe0552b5f. The new quad-drawing utility code uses 3 vertex attributes (xyz, rgba, st). For glDrawPixels path we don't use the rgba attribute so there's a gap in the TGSI VS input declarations (INPUT[0] = pos, INPUT[2] = texcoord). The TGSI->VGPU10

Re: [Mesa-dev] [PATCH 01/22] i965/meta: Delete unused layer shader uniform

I sent minor comments to patches 3 and 4. I think you should fix the commit log for the latter at least. Otherwise, patches 1-6 are: Reviewed-by: Iago Toral Quiroga On Wed, 2016-02-17 at 17:57 -0800, Ian Romanick wrote: > From: Ian Romanick > >

Re: [Mesa-dev] [PATCH 05/22] i965/meta: Use explicit uniform locations in stencil blit shaders

On Thu, 2016-02-18 at 16:34 +0100, Iago Toral wrote: > On Wed, 2016-02-17 at 17:57 -0800, Ian Romanick wrote: > > From: Ian Romanick > > > > Skip all this _mesa_GetUniformLocation nonsense. We can just tell the > > linker where to put the uniforms. > > > > This makes

Re: [Mesa-dev] [PATCH 05/22] i965/meta: Use explicit uniform locations in stencil blit shaders

On Wed, 2016-02-17 at 17:57 -0800, Ian Romanick wrote: > From: Ian Romanick > > Skip all this _mesa_GetUniformLocation nonsense. We can just tell the > linker where to put the uniforms. > > This makes the text size slightly larger (at least on x64) because >

Re: [Mesa-dev] [PATCH] st/mesa: fix pbo uploads

On Feb 18, 2016 6:16 AM, "Marek Olšák" wrote: > > On Thu, Feb 18, 2016 at 7:07 AM, Ilia Mirkin wrote: > > - LOD must be provided in .w for TXF (even for buffer textures) > > TXF on BUFFER should ignore the LOD. No such exception in the docs. Nouveau

[Mesa-dev] Google Summer of Code 2016

Hi, It's time to start thinking about the Google Summer of Code for 2016! The Xorg GSoC project is open to all projects related to graphics, windowing systems, and related technologies (Mesa, Wayland, X, input, kernel, OpenGL, OpenCL, etc.). For mentors and developers, please start thinking of

Re: [Mesa-dev] [PATCH 04/22] i965/meta: Silence unused parameter warnings

On Wed, 2016-02-17 at 17:57 -0800, Ian Romanick wrote: > From: Ian Romanick > > The brw and irb parameters to get_buffer_rect appear to be unused since > the function was introduced in 2f28a0d. They seem unnecessary, and this > was probably just something Kristian

Re: [Mesa-dev] [PATCH 03/22] i965/meta: Use explicit uniform locations in fast clear shader

On Wed, 2016-02-17 at 17:57 -0800, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > >

Re: [Mesa-dev] [PATCH 1/4] mesa: gl_NumSamples should always be at least one

Looks good to me. Interestingly we have a test for it in Piglit which gets run with samples=0 and it is currently passing so presumably it is broken. Reviewed-by: Neil Roberts - Neil Ilia Mirkin writes: > From ARB_sample_shading: > >

[Mesa-dev] [PATCH] i965/fs: fix copy propagation from sources with stride 0

We should not offset into them based on the relative offset of our source and the destination of the instruction we are copy propagating from, so we don't turn this: mov(16) vgrf6:F, vgrf7+0.0<0>:F (...) load_payload(8) vgrf28:F, vgrf6+1.0:F 2ndhalf mov(8) vgrf29:DF, vgrf28:F 2ndhalf into:

Re: [Mesa-dev] [PATCH] st/mesa: fix pbo uploads

On Thu, Feb 18, 2016 at 7:07 AM, Ilia Mirkin wrote: > - LOD must be provided in .w for TXF (even for buffer textures) TXF on BUFFER should ignore the LOD. > - User buffer must be valid at draw time > - Must have a sampler associated with the sampler view TXF doesn't

Re: [Mesa-dev] [PATCH] gallium/cso: only enable compute shaders when TGSI is supported

Reviewed-by: Marek Olšák Marek On Thu, Feb 18, 2016 at 12:18 AM, Samuel Pitoiset wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94186 > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] Shader-cache status and transition

On Fri, 2015-07-10 at 10:53 -0700, Carl Worth wrote: > Hi folks, > > I've pushed the latest version of my shader-cache work to a branch > named > "shader-cache" at: > > git://people.freedesktop.org/~cworth/mesa Hi all, Just a heads up in case someone has done/intended to do any work on