Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On 02/25/2016 02:37 AM, Brian Paul wrote: I think this patch could be broken up a bit... Yes, I agree that this is very long, but I couldn't decide on how to split it up. On 02/24/2016 04:35 PM, Miklós Máté wrote: v2: fix arithmetic for special opcodes, fix fog state, cleanup v3:

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On 02/25/2016 11:40 AM, Marek Olšák wrote: On Thu, Feb 25, 2016 at 12:35 AM, Miklós Máté wrote: v2: fix arithmetic for special opcodes, fix fog state, cleanup v3: simplify handling of special opcodes, fix rebinding with different textargets or fog equation, lots of

Re: [Mesa-dev] [PATCH] perf: fix snprintf() problem on Windows for glsl-compile-time.c

On 02/25/2016 12:58 AM, Kenneth Graunke wrote: On Wednesday, February 24, 2016 4:45:42 PM PST Brian Paul wrote: Use the typical _snprintf work-around. --- src/perf/glsl-compile-time.c | 4 1 file changed, 4 insertions(+) diff --git a/src/perf/glsl-compile-time.c

[Mesa-dev] [Bug 94291] llvmpipe tests fail if built on skylake i7-6700k

https://bugs.freedesktop.org/show_bug.cgi?id=94291 Bug ID: 94291 Summary: llvmpipe tests fail if built on skylake i7-6700k Product: Mesa Version: 11.2 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 1/2] winsys/svga: Fix an uninitialized return value

On 02/25/2016 03:02 AM, Thomas Hellstrom wrote: Reported-by: Brian Paul Signed-off-by: Thomas Hellstrom Reviwed-by: Brian Paul "Reviewed" Cc: "11.0 11.1" ---

Re: [Mesa-dev] [PATCH] perf: fix snprintf() problem on Windows for glsl-compile-time.c

On 24/02/16 23:45, Brian Paul wrote: Use the typical _snprintf work-around. --- src/perf/glsl-compile-time.c | 4 1 file changed, 4 insertions(+) diff --git a/src/perf/glsl-compile-time.c b/src/perf/glsl-compile-time.c index 917073c..a8e774f 100644 --- a/src/perf/glsl-compile-time.c +++

[Mesa-dev] [Bug 89590] Crash in glLinkProgram with shaders with multiple constant arrays

https://bugs.freedesktop.org/show_bug.cgi?id=89590 James Legg changed: What|Removed |Added Status|RESOLVED|VERIFIED --

[Mesa-dev] [Bug 93813] Incorrect viewport range when GL_CLIP_ORIGIN is GL_UPPER_LEFT

https://bugs.freedesktop.org/show_bug.cgi?id=93813 James Legg changed: What|Removed |Added Status|RESOLVED|VERIFIED --

Re: [Mesa-dev] [RFC 3/3] glsl: raise warning when using uninitialized variables

On 25/02/16 11:54, Timothy Arceri wrote: > On Thu, 2016-02-25 at 11:08 +0100, Alejandro Piñeiro wrote: >> On 25/02/16 10:41, Timothy Arceri wrote: >>> On Thu, 2016-02-25 at 09:09 +0100, Alejandro Piñeiro wrote: On 25/02/16 00:27, Timothy Arceri wrote: > On Wed, 2016-02-24 at 20:04 +0100,

[Mesa-dev] [PATCH] build/nir: Remove unused Makefile.sources from nir folder

NIR sources are added in src/compiler/Makefile.sources. --- src/compiler/nir/Makefile.sources | 71 --- 1 file changed, 71 deletions(-) delete mode 100644 src/compiler/nir/Makefile.sources diff --git a/src/compiler/nir/Makefile.sources

Re: [Mesa-dev] [RFC 3/3] glsl: raise warning when using uninitialized variables

On Thu, 2016-02-25 at 11:08 +0100, Alejandro Piñeiro wrote: > On 25/02/16 10:41, Timothy Arceri wrote: > > On Thu, 2016-02-25 at 09:09 +0100, Alejandro Piñeiro wrote: > > > On 25/02/16 00:27, Timothy Arceri wrote: > > > > On Wed, 2016-02-24 at 20:04 +0100, Alejandro Piñeiro wrote: > > > > >

Re: [Mesa-dev] [PATCH 2/7] st/mesa: implement GL_ATI_fragment_shader

On Thu, Feb 25, 2016 at 12:35 AM, Miklós Máté wrote: > v2: fix arithmetic for special opcodes, > fix fog state, cleanup > v3: simplify handling of special opcodes, > fix rebinding with different textargets or fog equation, > lots of formatting fixes > > Signed-off-by: Miklós

[Mesa-dev] [PATCH 1/2] i965/fs: fix precision of f2b

From the OpenGL 4.2 spec: "When a constructor is used to convert any integer or floating-point type to a bool, 0 and 0.0 are converted to false, and non-zero values are converted to true." Thus, even the smallest non-zero floating value should be translated to true. This behavior has been

[Mesa-dev] [PATCH 2/2] i965/vec4: fix precision of f2b

From the OpenGL 4.2 spec: "When a constructor is used to convert any integer or floating-point type to a bool, 0 and 0.0 are converted to false, and non-zero values are converted to true." Thus, even the smallest non-zero floating value should be translated to true. This behavior has been

Re: [Mesa-dev] [RFC 3/3] glsl: raise warning when using uninitialized variables

On 25/02/16 10:41, Timothy Arceri wrote: > On Thu, 2016-02-25 at 09:09 +0100, Alejandro Piñeiro wrote: >> On 25/02/16 00:27, Timothy Arceri wrote: >>> On Wed, 2016-02-24 at 20:04 +0100, Alejandro Piñeiro wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94129 ---

[Mesa-dev] [PATCH 2/2] winsys/svga: Increase the fence timeout

If running with a software renderer backend, the timeout may be insufficient, and we don't want to release busy buffers too early. In practice, SVGA gpu lockups are extremely rare. Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul Cc: "11.0 11.1"

[Mesa-dev] [PATCH 1/2] winsys/svga: Fix an uninitialized return value

Reported-by: Brian Paul Signed-off-by: Thomas Hellstrom Reviwed-by: Brian Paul Cc: "11.0 11.1" --- src/gallium/winsys/svga/drm/vmw_surface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [v3 2/5] i965/gen8: Set render state for lossless compressed

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_draw.c| 7 ++- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 5 - 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c

[Mesa-dev] [v3 5/5] i965/gen9: Enable lossless compression

I tried first creating the auxiliary buffer the same time with the color buffer. That, however, led me into a situation where we would later create the rest of the mip-levels and the compression would need to be disabled (it is only supported for single level buffers). Here we try to create it on

[Mesa-dev] [v3 1/5] i965/gen9: Prepare surface state setup for lossless compression

v2 (Ben): Use combination of msaa_layout and number of samples instead of introducing explicit type for lossless compression (intel_miptree_is_lossless_compressed()). v3 (Ben): Do not set fast claer state in surface state setup. Moved into

[Mesa-dev] [v3 4/5] i965: Add helper for lossless compression support

v2: Check explicitly against base type of GL_FLOAT instead of using _mesa_is_format_integer_color(). Otherwise we miss GL_UNSIGNED_NORMALIZED. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 22 ++

[Mesa-dev] [v3] Compression support for single-sampled

This revision changes the way buffer state is tracked. Instead of setting the state in surface-state setup, the state is now set as part of brw_postdraw_set_buffers_need_resolve(). And separately for rep-cleared buffers in set_render_buffers_state(). Topi Pohjolainen (5): i965/gen9: Prepare

[Mesa-dev] [PATCH 12/14] i965/meta: Introduce custom pipeline

Meta gives core state upload a set of emit overrides programming vertex fetcher without core vbo support. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h | 3 + src/mesa/drivers/dri/i965/brw_meta_util.c | 216

[Mesa-dev] [PATCH 14/14] i965: Don't add fast cleared buffers to render cache

Color buffers are not really written and therefore there is no reason to flush the caches. (Render cache is a set of buffer object pointers controlling brw_render_cache_set_check_flush()). Signed-off-by: Topi Pohjolainen ---

[Mesa-dev] [PATCH 09/14] i965/gen8: Expose emission for system generated values

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_draw.h | 6 ++ src/mesa/drivers/dri/i965/gen8_draw_upload.c | 101 +++ 2 files changed, 63 insertions(+), 44 deletions(-) diff --git

[Mesa-dev] [PATCH 05/14] i965/blorp: Refactor batch buffer save/restore

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 41 ++--- src/mesa/drivers/dri/i965/brw_context.h | 10 +++ src/mesa/drivers/dri/i965/brw_meta_util.c | 50 +++

[Mesa-dev] [PATCH 13/14] i965/meta: Setup vertices for fast clear without core vbo support

Meta operations will setup vertices directly instead of interfering with core content vertex buffer object state. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94181 Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.c | 2 +

[Mesa-dev] [PATCH 07/14] i965/blorp: Move clipper disabling to meta util

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.h | 3 --- src/mesa/drivers/dri/i965/brw_meta_util.c | 23 +++ src/mesa/drivers/dri/i965/brw_meta_util.h | 2 ++ src/mesa/drivers/dri/i965/gen6_blorp.cpp | 28

[Mesa-dev] [PATCH 11/14] i965: Introduce enumeration for atoms

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_atoms.h| 265 + src/mesa/drivers/dri/i965/brw_state_upload.c | 556 ++- 2 files changed, 556 insertions(+), 265 deletions(-) create mode 100644

[Mesa-dev] [PATCH 10/14] i965: Add means to override individual pipeline parts

This will allow meta programming to provide gl-state agnostic emitters. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_state.h| 7 +++ src/mesa/drivers/dri/i965/brw_state_upload.c | 29 2 files changed, 28

[Mesa-dev] [PATCH 06/14] i965/blorp: Move vertex buffer setup to meta util

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_meta_util.c | 32 + src/mesa/drivers/dri/i965/brw_meta_util.h | 5 src/mesa/drivers/dri/i965/gen6_blorp.cpp | 39 --- 3 files changed, 41

[Mesa-dev] i965/meta: Bypass core vertex buffer setup

This series introduces custom pipeline state upload for fast, rep and resolve clears. For now only vertex buffer and vertex fetcher state uploads are overrided. The base mechanism, however, makes it possible to reduce the dependence to core context gradually by one atom at a time if desired. I

[Mesa-dev] [PATCH 08/14] i965/meta: Prepare vertex buffer setup for gen8

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_meta_util.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_meta_util.c b/src/mesa/drivers/dri/i965/brw_meta_util.c

[Mesa-dev] [PATCH 01/14] i965: Reduce scope of indirect draw flag

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_draw.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index c295d91..323253e 100644 ---

[Mesa-dev] [PATCH 04/14] i965/blorp: Use meta utility for primitive emission

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 3 +++ src/mesa/drivers/dri/i965/brw_meta_util.c | 17 + src/mesa/drivers/dri/i965/brw_meta_util.h | 4 src/mesa/drivers/dri/i965/gen6_blorp.cpp | 18

[Mesa-dev] [PATCH 02/14] i965: Reduce scope of vertex access type

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_draw.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index 323253e..c8a083c 100644 ---

[Mesa-dev] [PATCH 03/14] i965: Expose draw primitive formatting

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_draw.c | 82 ++-- src/mesa/drivers/dri/i965/brw_draw.h | 7 +++ 2 files changed, 58 insertions(+), 31 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c

Re: [Mesa-dev] [RFC 3/3] glsl: raise warning when using uninitialized variables

On Thu, 2016-02-25 at 09:09 +0100, Alejandro Piñeiro wrote: > On 25/02/16 00:27, Timothy Arceri wrote: > > On Wed, 2016-02-24 at 20:04 +0100, Alejandro Piñeiro wrote: > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94129 > > > --- > > >  src/compiler/glsl/ast_to_hir.cpp | 7 +++ >

Re: [Mesa-dev] [RFC 1/3] glsl: add an assignment_recipient parameter on ast_expression

On 24/02/16 23:43, Timothy Arceri wrote: > On Wed, 2016-02-24 at 20:04 +0100, Alejandro Piñeiro wrote: >> The idea is pass through the ast-to-hir conversion if the current >> expression is the recipient of the assignment or not. Default >> value is false (so default value is being rhs). >> >>

Re: [Mesa-dev] [RFC 3/3] glsl: raise warning when using uninitialized variables

On 25/02/16 00:27, Timothy Arceri wrote: > On Wed, 2016-02-24 at 20:04 +0100, Alejandro Piñeiro wrote: >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94129 >> --- >> src/compiler/glsl/ast_to_hir.cpp | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git

<    1   2