[Mesa-dev] [PATCH 2/3] gallium/radeon: remove use_reusable_pool parameter from r600_init_resource

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle All callers set it to true. --- src/gallium/drivers/r600/r600_state_common.c| 2 +- src/gallium/drivers/radeon/r600_buffer_common.c | 7 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 3 +-- src/gallium/drivers/radeon/r600_texture.c

[Mesa-dev] [PATCH 3/3] winsys/radeon: remove use_reusable_pool parameter from buffer_create

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle All callers set this parameter to true. --- src/gallium/drivers/r300/r300_query.c | 2 +- src/gallium/drivers/r300/r300_render.c | 2 +- src/gallium/drivers/r300/r300_screen_buffer.c | 4 ++--

[Mesa-dev] [PATCH 1/3] radeon/video: always use the reusable buffer pool

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle A semantic error was introduced in a past refactoring that caused the bind parameter to be passed into the use_reusable_pool parameter of buffer_create. Since this clearly makes no sense, and there is no clear reason why the cache _shouldn't_ be

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-22 Thread Rob Herring
On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov wrote: > Hi Rob, > > On 22 April 2016 at 16:50, Rob Herring wrote: >> This adds map and unmap functions to GBM utilizing the DRIimage extension >> mapImage/unmapImage functions or existing internal mapping

Re: [Mesa-dev] [PATCH v2] anv_device: Set the compressed texture feature flags correctly

2016-04-22 Thread Jason Ekstrand
On Fri, Apr 22, 2016 at 6:58 PM, Nanley Chery wrote: > On Fri, Apr 22, 2016 at 05:22:13PM -0700, Jason Ekstrand wrote: > > On Fri, Apr 22, 2016 at 4:38 PM, Nanley Chery > wrote: > > > > > From: Nanley Chery > > > > > >

Re: [Mesa-dev] [PATCH v2] anv_device: Set the compressed texture feature flags correctly

2016-04-22 Thread Nanley Chery
On Fri, Apr 22, 2016 at 05:22:13PM -0700, Jason Ekstrand wrote: > On Fri, Apr 22, 2016 at 4:38 PM, Nanley Chery wrote: > > > From: Nanley Chery > > > > Sampling from an ETC2 texture is supported on Bay Trail and > > from Gen8 onwards. While

Re: [Mesa-dev] [PATCH 1/4] gbm: Add Android build support

2016-04-22 Thread Rob Herring
On Fri, Apr 22, 2016 at 5:57 PM, Emil Velikov wrote: > Hi Rob, > > On 22 April 2016 at 16:50, Rob Herring wrote: > >> --- /dev/null >> +++ b/src/gbm/Android.mk > >> +LOCAL_EXPORT_C_INCLUDE_DIRS := \ >> + $(LOCAL_PATH)/main >> + > You don't need

Re: [Mesa-dev] [PATCH 10/13] i965/blorp: Make all of brw_blorp.h accessable to C

2016-04-22 Thread Matt Turner
Subject: s/accessable/accessible/ ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] anv_device: Set the compressed texture feature flags correctly

2016-04-22 Thread Jason Ekstrand
On Fri, Apr 22, 2016 at 4:38 PM, Nanley Chery wrote: > From: Nanley Chery > > Sampling from an ETC2 texture is supported on Bay Trail and > from Gen8 onwards. While ASTC_LDR is supported on Gen9, the > logic to handle such formats has not yet

[Mesa-dev] [PATCH v2] anv_device: Set the compressed texture feature flags correctly

2016-04-22 Thread Nanley Chery
From: Nanley Chery Sampling from an ETC2 texture is supported on Bay Trail and from Gen8 onwards. While ASTC_LDR is supported on Gen9, the logic to handle such formats has not yet been implemented in the driver. Fixes

Re: [Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-04-22 Thread Jason Ekstrand
On Apr 22, 2016 11:05, "Emil Velikov" wrote: > > On 22 April 2016 at 18:58, Jason Ekstrand wrote: > > I'm not sure what I think of this. I don't think dev_icd is the only icd > > file we're going to need to build. Right now, we don't build the

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-22 Thread Emil Velikov
Hi Rob, On 22 April 2016 at 16:50, Rob Herring wrote: > This adds map and unmap functions to GBM utilizing the DRIimage extension > mapImage/unmapImage functions or existing internal mapping for dumb > buffers. Ftr that this is quite sensitive and apart from the obvious breakage

Re: [Mesa-dev] [PATCH] i965: Disable KHR_texture_compression_astc_hdr on Gen9

2016-04-22 Thread Kenneth Graunke
On Tuesday, April 12, 2016 5:34:49 PM PDT Nanley Chery wrote: > From: Nanley Chery > > Although Gen9 samples from most HDR ASTC surfaces of correctly, > there currently are no software workarounds to fix the incorrect > sampling that occurs in others of certain color

Re: [Mesa-dev] [PATCH 2/2] i965/tex_image: Flush certain subnormal ASTC channel values

2016-04-22 Thread Kenneth Graunke
On Tuesday, April 12, 2016 3:30:14 PM PDT Nanley Chery wrote: > From: Nanley Chery > > When uploading a linear, void-extent, ASTC LDR block on Skylake, we are > required to flush to zero the UNORM16 channel values that would be > denormalized. This is specifically

[Mesa-dev] [PATCH 04/13] i965/blorp: Remove the hiz params class

2016-04-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp.cpp | 58 + src/mesa/drivers/dri/i965/brw_blorp.h | 21 +++- 2 files changed, 42 insertions(+), 37 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.cpp b/src/mesa/drivers/dri/i965/brw_blorp.cpp index

[Mesa-dev] [PATCH 11/13] i965/blorp: Convert brw_blorp.cpp to a C file

2016-04-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/Makefile.sources | 2 +- src/mesa/drivers/dri/i965/brw_blorp.c | 344 src/mesa/drivers/dri/i965/brw_blorp.cpp| 347 - 3 files changed, 345 insertions(+), 348 deletions(-) create mode 100644

[Mesa-dev] [PATCH 01/13] i965/blorp: Refactor to get rid of the get_wm_prog virtual function

2016-04-22 Thread Jason Ekstrand
Instead of having a virtual member function for getting the WM/PS kernel, we simply add fields for prog_data and the kernel to brw_blorp_parms and always make sure those get set as part of the different constructors. --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 12 ++-

[Mesa-dev] [PATCH 06/13] i965/blorp: Roll mip_info into surface_info

2016-04-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp.cpp | 26 -- src/mesa/drivers/dri/i965/brw_blorp.h | 28 +--- 2 files changed, 17 insertions(+), 37 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.cpp

[Mesa-dev] [PATCH 09/13] i965/blorp: Turn brw_blorp_params into a C-stlye struct

2016-04-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp.cpp | 35 -- src/mesa/drivers/dri/i965/brw_blorp.h | 43 +-- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 3 +- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 6 ++--

[Mesa-dev] [PATCH 05/13] i965/blorp: Get rid of the blorp_blit_params class

2016-04-22 Thread Jason Ekstrand
It was really just a wrapper around the function that constructed it. --- src/mesa/drivers/dri/i965/brw_blorp.h| 20 -- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 276 +-- 2 files changed, 130 insertions(+), 166 deletions(-) diff --git

[Mesa-dev] [PATCH 02/13] i965/blorp: Remove the arguments to brw_blorp_params()

2016-04-22 Thread Jason Ekstrand
No one was using anything other than the defaults. --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 10 -- src/mesa/drivers/dri/i965/brw_blorp.h | 4 +--- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.cpp

[Mesa-dev] [PATCH 08/13] i965/blorp: Turn coord_transform into a C-stlye struct

2016-04-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp.h| 10 +++--- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 23 +-- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers/dri/i965/brw_blorp.h index

[Mesa-dev] [PATCH 12/13] i965/blorp: Make state setup C-safe

2016-04-22 Thread Jason Ekstrand
Previously they (very rarely) used C++isms that prevented them from being compiled as C. As of this commit, they can be compiled as either C or C++. --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 4 ++-- src/mesa/drivers/dri/i965/gen7_blorp.cpp | 2 +- src/mesa/drivers/dri/i965/gen8_blorp.cpp |

[Mesa-dev] [PATCH 10/13] i965/blorp: Make all of brw_blorp.h accessable to C

2016-04-22 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp.h | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers/dri/i965/brw_blorp.h index e9db063..3953955 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.h +++

[Mesa-dev] [PATCH 03/13] i965/blorp: Remove the clear params classes

2016-04-22 Thread Jason Ekstrand
They didn't really add anything other than a key and extra layers of function calls. This commit just inlines the extra functions and gets rid of the extra classes. --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 224 ++ 1 file changed, 87 insertions(+), 137

[Mesa-dev] [PATCH 07/13] i965/blorp: Turn blorp_surface_info into a C-style struct

2016-04-22 Thread Jason Ekstrand
This commit is mostly mechanical except that it changes where we set the swizzle. Previously, the blorp_surface_info constructor defaulted the swizzle to SWIZZLE_XYZW. Now, we memset to zero and fill out the swizzle when we setup the rest of the struct. ---

Re: [Mesa-dev] [PATCH] anv_device: Set the compressed texture feature flags correctly

2016-04-22 Thread Kenneth Graunke
On Monday, April 18, 2016 2:33:38 PM PDT Nanley Chery wrote: > From: Nanley Chery > > Sampling from an ETC2 texture is supported from Gen8 onwards. > While ASTC_LDR is supported on Gen9, the logic to handle such > formats has not yet been implemented in the driver. > >

Re: [Mesa-dev] [PATCH 00/11] update swr rasterizer

2016-04-22 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak On Apr 14, 2016, at 2:53 PM, Tim Rowley wrote: > > Another batch of updates to the swr rasterizer. No huge new features, > but should fix at least one of the coverity flagged issues. > > Tim Rowley (11): >

Re: [Mesa-dev] [PATCH 1/4] gbm: Add Android build support

2016-04-22 Thread Emil Velikov
Hi Rob, On 22 April 2016 at 16:50, Rob Herring wrote: > --- /dev/null > +++ b/src/gbm/Android.mk > +LOCAL_EXPORT_C_INCLUDE_DIRS := \ > + $(LOCAL_PATH)/main > + You don't need this. > +LOCAL_C_INCLUDES := \ > + $(LOCAL_PATH)/main > + > +ifeq

Re: [Mesa-dev] [PATCH 1/3] configure.ac: search for and set PYTHON3

2016-04-22 Thread Kenneth Graunke
On Saturday, April 23, 2016 5:34:33 AM PDT Jonathan Gray wrote: > On Fri, Apr 22, 2016 at 11:09:52AM -0700, Kenneth Graunke wrote: > > On Saturday, April 23, 2016 1:21:38 AM PDT Jonathan Gray wrote: > > > src/intel/genxml/gen_pack_header.py requires python3. > > > > > > Signed-off-by: Jonathan

Re: [Mesa-dev] [PATCH v2] swr: fix clang warnings

2016-04-22 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Apr 21, 2016, at 11:50 AM, Tim Rowley > wrote: v2: use alternate logic version in swr_check_render_cond ---

[Mesa-dev] [PATCH 6/9] radeonsi: only decompress the required ZS planes from si_blit

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle This happens to "fix" a rendering bug in KotOR2, because it avoids a still not quite understood bug with MSAA fast stencil clear decompress. For the stencil clear bug, I have sent a piglit test (arb_texture_multisample-stencil-clear). Bugzilla:

[Mesa-dev] [PATCH 2/9] radeonsi: fix brace style

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_blit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 7b028c1..2b00da9 100644 ---

[Mesa-dev] [PATCH 7/9] radeonsi: si_blit_decompress_depth is only used for staging

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_blit.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 39ef98e..09f3207 100644

[Mesa-dev] [PATCH 4/9] radeonsi: early out of si_blit_decompress_depth_in_place based on dirty mask

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle Avoid dirtying the db_render_state atom when possible. --- src/gallium/drivers/radeonsi/si_blit.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c

[Mesa-dev] [PATCH 8/9] radeonsi: use level mask for early out in si_blit_decompress_color

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle Mostly for consistency with the other decompress functions, but note that in the non-DCC decompress case, the function can now early-out in slightly more (albeit probably rare) cases. --- src/gallium/drivers/radeonsi/si_blit.c | 14 -- 1

[Mesa-dev] [PATCH 5/9] radeonsi: decompress Z & S planes in one pass

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_blit.c | 101 - 1 file changed, 73 insertions(+), 28 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index

[Mesa-dev] [PATCH 9/9] radeonsi: move blend choice out of loop in si_blit_decompress_color

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle It does not depend on the level or layer. --- src/gallium/drivers/radeonsi/si_blit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c

[Mesa-dev] [PATCH 3/9] radeonsi: use MIN2 instead of expanded ?: operator

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_blit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index 2b00da9..6db73f7 100644 ---

[Mesa-dev] [PATCH 1/9] gallium/util: add u_bit_consecutive for generating a consecutive range of bits

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle There are some undefined behavior subtleties, so having a function to match the u_bit_scan_consecutive_range makes sense. --- src/gallium/auxiliary/util/u_math.h | 12 1 file changed, 12 insertions(+) diff --git

[Mesa-dev] [PATCH 0/9] radeonsi: decompression cleanups and ZS optimization

2016-04-22 Thread Nicolai Hähnle
Hi, this series contains a bunch of minor cleanups to the various decompression routines. The biggest functional change is that we decompress Z & S in-place simultaneously now when asked for decompressing both, while at the same time being slightly more precise about which of the two we

[Mesa-dev] [PATCH 1/2] radeonsi: expclear must be disabled on first Z/S clear

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle The documentation and the HW team say so. --- src/gallium/drivers/radeonsi/si_blit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gallium/drivers/radeonsi/si_blit.c index

[Mesa-dev] [PATCH 2/2] radeonsi: work around an MSAA fast stencil clear problem

2016-04-22 Thread Nicolai Hähnle
From: Nicolai Hähnle A piglit test (arb_texture_multisample-stencil-clear) has been sent. This problem was discovered analyzing Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93767 --- src/gallium/drivers/radeonsi/si_state.c | 18 +++--- 1 file

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-22 Thread Marek Olšák
On Fri, Apr 22, 2016 at 11:28 PM, Nicolai Hähnle wrote: > On 22.04.2016 12:29, Nicolai Hähnle wrote: >> >> On 20.04.2016 23:02, Michel Dänzer wrote: >>> >>> On 21.04.2016 02:42, Marek Olšák wrote: On Thu, Apr 14, 2016 at 9:29 AM, Michel Dänzer

Re: [Mesa-dev] [PATCH 09/13] nir/lower_double_ops: lower round_even()

2016-04-22 Thread Jason Ekstrand
Matt, Care to take this one? I'm not that familiar with roundeven. --Jason On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Iago Toral Quiroga > > At least i965 hardware does not have native support for round_even() on >

Re: [Mesa-dev] [PATCH 03/13] nir/builder: add nir_imm_double()

2016-04-22 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Connor Abbott > > --- > src/compiler/nir/nir_builder.h | 8 > 1 file changed, 8 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 07/13] nir/lower_double_ops: lower ceil()

2016-04-22 Thread Jason Ekstrand
On Tue, Apr 19, 2016 at 3:48 PM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > >> From: Iago Toral Quiroga >> >> At least i965

Re: [Mesa-dev] [PATCH 06/13] nir/lower_double_ops: lower floor()

2016-04-22 Thread Jason Ekstrand
On Fri, Apr 22, 2016 at 3:13 PM, Jason Ekstrand wrote: > > > On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > >> From: Iago Toral Quiroga >> >> At least i965 hardware does not have native support for floor on

Re: [Mesa-dev] [PATCH 06/13] nir/lower_double_ops: lower floor()

2016-04-22 Thread Jason Ekstrand
On Tue, Apr 12, 2016 at 1:05 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Iago Toral Quiroga > > At least i965 hardware does not have native support for floor on doubles. > --- > src/compiler/nir/nir.h | 1 + >

Re: [Mesa-dev] [PATCH v2] nir/lower_double_ops: lower trunc()

2016-04-22 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Did the v2 fix anything other than newly added tests? --Jason On Thu, Apr 21, 2016 at 10:13 PM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > From: Iago Toral Quiroga > > At least i965 hardware does not have

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-22 Thread Rob Herring
On Fri, Apr 22, 2016 at 1:21 PM, Eric Anholt wrote: > Rob Herring writes: > >> This adds map and unmap functions to GBM utilizing the DRIimage extension >> mapImage/unmapImage functions or existing internal mapping for dumb >> buffers. Unlike prior attempts,

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-22 Thread Nicolai Hähnle
On 22.04.2016 12:29, Nicolai Hähnle wrote: On 20.04.2016 23:02, Michel Dänzer wrote: On 21.04.2016 02:42, Marek Olšák wrote: On Thu, Apr 14, 2016 at 9:29 AM, Michel Dänzer wrote: On 14.04.2016 11:37, Michel Dänzer wrote: On 12.04.2016 21:33, Marek

Re: [Mesa-dev] [PATCH v3 4/4] r600g: use do_endian_swap in texture swapping function

2016-04-22 Thread Marek Olšák
On Thu, Apr 21, 2016 at 4:39 PM, Oded Gabbay wrote: > For some texture formats we need to take "do_endian_swap" into account > when configuring their swizzling. > > Signed-off-by: Oded Gabbay > --- > src/gallium/drivers/r600/r600_state_common.c | 35

Re: [Mesa-dev] [PATCH v3 3/4] r600g: use do_endian_swap in color swapping functions

2016-04-22 Thread Marek Olšák
On Thu, Apr 21, 2016 at 4:39 PM, Oded Gabbay wrote: > For some formats we need to take "do_endian_swap" into account when > configuring swapping for color buffers. > > Signed-off-by: Oded Gabbay > --- > src/gallium/drivers/r600/r600_state_common.c |

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

2016-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #20 from Roland Scheidegger --- (In reply to Bruce Cherniak from comment #19) > Thanks Roland! You patch fixes the segv I get when running both llvmpipe > and OpenSWR; and the test itself now passes on llvmpipe.

Re: [Mesa-dev] [PATCH mesa v2] nouveau: codegen: combineLd/St do not combine indirect loads

2016-04-22 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Fri, Apr 22, 2016 at 7:07 AM, Hans de Goede wrote: > combineLd/St would combine, i.e. : > > st u32 # g[$r2+0x0] $r2 > st u32 # g[$r2+0x4] $r3 > > into: > > st u64 # g[$r2+0x0] $r2d > > But this is only valid if r2

Re: [Mesa-dev] [PATCH 1/3] configure.ac: search for and set PYTHON3

2016-04-22 Thread Jonathan Gray
On Fri, Apr 22, 2016 at 11:09:52AM -0700, Kenneth Graunke wrote: > On Saturday, April 23, 2016 1:21:38 AM PDT Jonathan Gray wrote: > > src/intel/genxml/gen_pack_header.py requires python3. > > > > Signed-off-by: Jonathan Gray > > --- > > configure.ac | 2 ++ > > 1 file changed,

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

2016-04-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #19 from Bruce Cherniak --- Thanks Roland! You patch fixes the segv I get when running both llvmpipe and OpenSWR; and the test itself now passes on llvmpipe. -- You are receiving this mail because: You

Re: [Mesa-dev] [PATCH v3 2/4] r600g: set endianess of 16/32-bit buffers according to do_endian_swap

2016-04-22 Thread Marek Olšák
On Thu, Apr 21, 2016 at 4:39 PM, Oded Gabbay wrote: > This patch modifies r600_colorformat_endian_swap(), so for 16-bit and for > 32-bit buffers, the endianess configuration will be determined not only > by the color/texture format, but also by the do_endian_swap parameter.

Re: [Mesa-dev] [PATCH 1/4] scons: Move fallback HAVE_* definitions to headers.

2016-04-22 Thread Jose Fonseca
On 22/04/16 15:03, Roland Scheidegger wrote: Am 22.04.2016 um 10:35 schrieb Jose Fonseca: These were being defined in SCons, but it's not practical: - we actually need to include Gallium headers from external source trees, with completely disjoint build infrastructure, and it's unsustainable

Re: [Mesa-dev] [PATCH v3 1/4] r600g/radeonsi: send endian info to format translation functions

2016-04-22 Thread Marek Olšák
On Thu, Apr 21, 2016 at 4:39 PM, Oded Gabbay wrote: > Because r600 GPUs can't do swap in their DB unit, we need to disable > endianess swapping for textures that are handled by DB. > > There are four format translation functions in r600g driver: > > -

Re: [Mesa-dev] [v2 7/7] i965/blorp: Do not tricker re-emission of base state address

2016-04-22 Thread Pohjolainen, Topi
On Fri, Apr 22, 2016 at 11:59:47AM -0700, Matt Turner wrote: > On Fri, Apr 22, 2016 at 11:05 AM, Topi Pohjolainen > wrote: > > In case blorp needs to configure it will be just as if render or > > compute pipeline had configured it. > > s/tricker/trigger/ in the title.

Re: [Mesa-dev] [v2 7/7] i965/blorp: Do not tricker re-emission of base state address

2016-04-22 Thread Matt Turner
On Fri, Apr 22, 2016 at 11:05 AM, Topi Pohjolainen wrote: > In case blorp needs to configure it will be just as if render or > compute pipeline had configured it. s/tricker/trigger/ in the title. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 01/13] i965: Add a dependency on libisl

2016-04-22 Thread Jonathan Gray
On Fri, Apr 22, 2016 at 10:50:33AM -0700, Jason Ekstrand wrote: > On Fri, Apr 22, 2016 at 10:15 AM, Jonathan Gray wrote: > > > On Fri, Apr 22, 2016 at 05:31:29PM +0100, Emil Velikov wrote: > > > On 22 April 2016 at 16:08, Jonathan Gray wrote: > > > > It is worth

Re: [Mesa-dev] [PATCH] gallivm: make sampling more robust against bogus coordinates

2016-04-22 Thread Cherniak, Bruce
Tested-by: Bruce Cherniak On 4/22/16, 8:33 AM, "mesa-dev on behalf of srol...@vmware.com" wrote: >From: Roland Scheidegger > >Some cases (especially these using fract for

Re: [Mesa-dev] [v2] i965/blorp: State emission optimizations

2016-04-22 Thread Kenneth Graunke
On Friday, April 22, 2016 9:05:22 PM PDT Topi Pohjolainen wrote: > Ken came up with an idea to introduce new state flag for blorp and > to use it instead of trashing all the other bits. This series > introduces the flag and makes every atom to track it by default. > Finally blorp is made to track

Re: [Mesa-dev] [PATCH 1/4] gallium: add bool return to pipe_context::end_query

2016-04-22 Thread Roland Scheidegger
Am 22.04.2016 um 19:28 schrieb Nicolai Hähnle: > On 22.04.2016 11:52, Roland Scheidegger wrote: >> Am 22.04.2016 um 18:22 schrieb Nicolai Hähnle: >>> On 22.04.2016 08:56, Roland Scheidegger wrote: I don't quite understand why this is necessary. Couldn't you just handle such failures in

Re: [Mesa-dev] [v2 3/7] i965: Introduce state flag for blorp

2016-04-22 Thread Kenneth Graunke
On Friday, April 22, 2016 9:05:25 PM PDT Topi Pohjolainen wrote: > CC: Kenneth Graunke > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 ++ > src/mesa/drivers/dri/i965/brw_state_upload.c | 1 + > 2

Re: [Mesa-dev] [PATCH] vid_enc: Fix resource leak on OMX_ErrorNone

2016-04-22 Thread Emil Velikov
On 21 April 2016 at 22:49, wrote: > From: Robert Foss > > Avoid leaking buffer allocated for task if an > error has occured. > s|vid_env|st/omx| in the commit message and s|occured|occurred| in the message. > Coverity id: 1213929 >

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-22 Thread Eric Anholt
Rob Herring writes: > This adds map and unmap functions to GBM utilizing the DRIimage extension > mapImage/unmapImage functions or existing internal mapping for dumb > buffers. Unlike prior attempts, this version provides a region to map and > usage flags for the mapping. The

Re: [Mesa-dev] [PATCH 01/13] i965: Add a dependency on libisl

2016-04-22 Thread Chad Versace
On 04/22/2016 10:50 AM, Jason Ekstrand wrote: > > > On Fri, Apr 22, 2016 at 10:15 AM, Jonathan Gray > wrote: > > On Fri, Apr 22, 2016 at 05:31:29PM +0100, Emil Velikov wrote: >> On 22 April 2016 at 16:08, Jonathan Gray >

Re: [Mesa-dev] [PATCH 3/4] st/dri: Add support for DRIimage extension mapImage/unmapImage

2016-04-22 Thread Eric Anholt
Rob Herring writes: > Implement support for mapImage/unmapImage functions in version 12 of the > DRIimage extension. > > Signed-off-by: Rob Herring This looks good to me, other than my previous comment about looking at the read flag. Once we sort that out,

Re: [Mesa-dev] [PATCH 2/4] DRI: Add DRIimage map and unmap functions

2016-04-22 Thread Eric Anholt
Rob Herring writes: > Add mapImage and unmapImage functions to DRIimage extension for mapping > and unmapping DRIimages for CPU access. The caller provides the region of > the image to map and is returned a pointer to the beginning of the region > and the stride (which could be

Re: [Mesa-dev] [PATCH 1/3] configure.ac: search for and set PYTHON3

2016-04-22 Thread Kenneth Graunke
On Saturday, April 23, 2016 1:21:38 AM PDT Jonathan Gray wrote: > src/intel/genxml/gen_pack_header.py requires python3. > > Signed-off-by: Jonathan Gray > --- > configure.ac | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/configure.ac b/configure.ac > index

Re: [Mesa-dev] [PATCH] i965/blorb: remove dead code in brw_blorp_const_color_program::compile()

2016-04-22 Thread Matt Turner
On Fri, Apr 22, 2016 at 5:01 AM, Juha-Pekka Heikkila wrote: > base_mrf is unsigned, checking if its greater or equal to zero will > not fail. Please s/blorb/blorp/ in the commit title before pushing. ___ mesa-dev mailing

[Mesa-dev] [v2 4/7] i965: Make all atoms to track BRW_NEW_BLORP by default

2016-04-22 Thread Topi Pohjolainen
From: Kenneth Graunke From: Kenneth Graunke Signed-off-by: Topi Pohjolainen

[Mesa-dev] [v2 7/7] i965/blorp: Do not tricker re-emission of base state address

2016-04-22 Thread Topi Pohjolainen
In case blorp needs to configure it will be just as if render or compute pipeline had configured it. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 1 - src/mesa/drivers/dri/i965/gen8_misc_state.c | 1 - 2 files changed, 2

[Mesa-dev] [v2 6/7] i965/blorp: Reconfigure base state address only if needed

2016-04-22 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen6_blorp.cpp | 3 ++- src/mesa/drivers/dri/i965/gen7_blorp.cpp | 3 ++- src/mesa/drivers/dri/i965/gen8_blorp.cpp | 4 +++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [v2 5/7] i965/blorp: Use BRW_NEW_BLORP instead of trashing all state bits

2016-04-22 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_blorp.cpp | 4 +--- src/mesa/drivers/dri/i965/gen7_urb.c| 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.cpp

[Mesa-dev] [v2 2/7] i965/blorp/gen6: Use normal base state address setup

2016-04-22 Thread Topi Pohjolainen
This is identical to the blorp version which only differs in case fragment shader isn't used. In that case blorp would reset batch buffer address to zero. This is not really needed, and having blorp to use base state address setup that is compatible with normal upload allows one to skip resetting

[Mesa-dev] [v2] i965/blorp: State emission optimizations

2016-04-22 Thread Topi Pohjolainen
Ken came up with an idea to introduce new state flag for blorp and to use it instead of trashing all the other bits. This series introduces the flag and makes every atom to track it by default. Finally blorp is made to track base state address and urb setup allowing one to skip unnecessary

[Mesa-dev] [v2 3/7] i965: Introduce state flag for blorp

2016-04-22 Thread Topi Pohjolainen
CC: Kenneth Graunke Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_state_upload.c | 1 + 2 files changed, 3 insertions(+) diff --git

[Mesa-dev] [v2 1/7] i965: Remove pointers to non-existing atoms

2016-04-22 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_state.h | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/src/mesa/drivers/dri/i965/brw_state.h index 9f15326..e89b388 100644 ---

Re: [Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-04-22 Thread Emil Velikov
On 22 April 2016 at 18:58, Jason Ekstrand wrote: > I'm not sure what I think of this. I don't think dev_icd is the only icd > file we're going to need to build. Right now, we don't build the regular > ICD but I think we want to eventually in which case having a general

Re: [Mesa-dev] [PATCH 20/25] anv: minor tweak in the generation script

2016-04-22 Thread Emil Velikov
On 22 April 2016 at 18:52, Jason Ekstrand wrote: > On Fri, Apr 22, 2016 at 10:27 AM, Emil Velikov > wrote: >> >> On 22 April 2016 at 04:36, Kristian Høgsberg wrote: >> > On Thu, Apr 21, 2016 at 5:18 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] i965/blorp: Fix clear code for ignoring colormask for XRGB formats on Gen9+

2016-04-22 Thread Kenneth Graunke
On Friday, April 22, 2016 11:49:03 AM PDT Topi Pohjolainen wrote: > This is equivalent of 73b01e2711ff45a1f313d5372d6c8fa4fe55d4d2 > for blorp. > > CC: Iago Toral Quiroga > CC: Kenneth Graunke > Signed-off-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-04-22 Thread Jason Ekstrand
I'm not sure what I think of this. I don't think dev_icd is the only icd file we're going to need to build. Right now, we don't build the regular ICD but I think we want to eventually in which case having a general rule is a good thing. On Fri, Apr 22, 2016 at 11:55 AM, Emil Velikov

[Mesa-dev] [PATCH v2 03/25] anv: tweak the %.json rule

2016-04-22 Thread Emil Velikov
From: Emil Velikov It's used only by dev_icd.json so just call it that way. While we're here, manually expand $< (as it might cause issue on some systems) and drop the unneeded install_libdir substitution. Cc: Jason Ekstrand Signed-off-by: Emil

Re: [Mesa-dev] [PATCH v2 02/25] anv: add a comment about dev_icd.json

2016-04-22 Thread Jason Ekstrand
R-B On Fri, Apr 22, 2016 at 11:54 AM, Emil Velikov wrote: > From: Emil Velikov > > Cc: Jason Ekstrand > Signed-off-by: Emil Velikov > --- > This patch replaces "anv: remove unused

[Mesa-dev] [PATCH v2 02/25] anv: add a comment about dev_icd.json

2016-04-22 Thread Emil Velikov
From: Emil Velikov Cc: Jason Ekstrand Signed-off-by: Emil Velikov --- This patch replaces "anv: remove unused dev_icd.json" --- src/intel/vulkan/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH v2 01/25] genxml: ship all the files needed in the tarball

2016-04-22 Thread Emil Velikov
From: Emil Velikov v2: The xml files are not called "gen*_pack.xml" (Jason) Signed-off-by: Emil Velikov Acked-by: Jason Ekstrand (v1) --- src/intel/genxml/Makefile.am | 11 +++ 1 file changed, 11

Re: [Mesa-dev] [PATCH 20/25] anv: minor tweak in the generation script

2016-04-22 Thread Jason Ekstrand
On Fri, Apr 22, 2016 at 10:27 AM, Emil Velikov wrote: > On 22 April 2016 at 04:36, Kristian Høgsberg wrote: > > On Thu, Apr 21, 2016 at 5:18 PM, Emil Velikov > wrote: > >> On 21 April 2016 at 22:50, Jason Ekstrand

Re: [Mesa-dev] [PATCH] i965/blorb: remove dead code in brw_blorp_const_color_program::compile()

2016-04-22 Thread Pohjolainen, Topi
On Fri, Apr 22, 2016 at 10:39:37AM -0700, Kenneth Graunke wrote: > On Friday, April 22, 2016 3:01:27 PM PDT Juha-Pekka Heikkila wrote: > > base_mrf is unsigned, checking if its greater or equal to zero will > > not fail. > > > > Signed-off-by: Juha-Pekka Heikkila >

Re: [Mesa-dev] [PATCH 01/13] i965: Add a dependency on libisl

2016-04-22 Thread Jason Ekstrand
On Fri, Apr 22, 2016 at 10:15 AM, Jonathan Gray wrote: > On Fri, Apr 22, 2016 at 05:31:29PM +0100, Emil Velikov wrote: > > On 22 April 2016 at 16:08, Jonathan Gray wrote: > > > It is worth noting that the isl code extensively requires designated > > >

Re: [Mesa-dev] [PATCH] i965/blorb: remove dead code in brw_blorp_const_color_program::compile()

2016-04-22 Thread Kenneth Graunke
On Friday, April 22, 2016 3:01:27 PM PDT Juha-Pekka Heikkila wrote: > base_mrf is unsigned, checking if its greater or equal to zero will > not fail. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 2 +- > 1 file

Re: [Mesa-dev] Mesa (master): 29 new commits

2016-04-22 Thread Nicolai Hähnle
On 20.04.2016 23:02, Michel Dänzer wrote: On 21.04.2016 02:42, Marek Olšák wrote: On Thu, Apr 14, 2016 at 9:29 AM, Michel Dänzer wrote: On 14.04.2016 11:37, Michel Dänzer wrote: On 12.04.2016 21:33, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: URL:

Re: [Mesa-dev] [PATCH 1/4] gallium: add bool return to pipe_context::end_query

2016-04-22 Thread Nicolai Hähnle
On 22.04.2016 11:52, Roland Scheidegger wrote: Am 22.04.2016 um 18:22 schrieb Nicolai Hähnle: On 22.04.2016 08:56, Roland Scheidegger wrote: I don't quite understand why this is necessary. Couldn't you just handle such failures in the driver easily? How? When we need a new query buffer due

Re: [Mesa-dev] [PATCH 20/25] anv: minor tweak in the generation script

2016-04-22 Thread Emil Velikov
On 22 April 2016 at 04:36, Kristian Høgsberg wrote: > On Thu, Apr 21, 2016 at 5:18 PM, Emil Velikov > wrote: >> On 21 April 2016 at 22:50, Jason Ekstrand wrote: >>> On Thu, Apr 21, 2016 at 6:16 AM, Emil Velikov

Re: [Mesa-dev] [PATCH 01/13] i965: Add a dependency on libisl

2016-04-22 Thread Jonathan Gray
On Fri, Apr 22, 2016 at 05:31:29PM +0100, Emil Velikov wrote: > On 22 April 2016 at 16:08, Jonathan Gray wrote: > > It is worth noting that the isl code extensively requires designated > > initialisers on anonymous structs. It isn't clear to me when gcc introduced > > support for

Re: [Mesa-dev] [PATCH] i965: Disable channel expressions for scalar GS, TCS, TES.

2016-04-22 Thread Matt Turner
Looks good to me: Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

  1   2   >