Re: [Mesa-dev] [PATCH 3/3] nir/opt_algebraic: lower mod() with doubles operands if lower_fmod64 is enabled

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 29/04/16 20:26, Jordan Justen wrote: > On 2016-04-28 04:19:18, Samuel Iglesias Gonsálvez wrote: >> Make this distintion as the drivers might need to lower it inside NIR . >> >> Signed-off-by: Samuel Iglesias Gonsálvez >>

Re: [Mesa-dev] [PATCH 2/3] mesa: rename lower_fmod to lower_fmod32

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 29/04/16 20:43, Jason Ekstrand wrote: > Why not just squash 2 and 3 and call it "Separate 32 and 64-bit > fmod lowering" or something like that. > OK, I like it. Sam > > On Thu, Apr 28, 2016 at 4:19 AM, Samuel Iglesias Gonsálvez < >

[Mesa-dev] [PATCH 2/2] glsl/ast: don't accept function calls as constructors.

From: Dave Airlie This fixes a crash in GL43-CTS.shader_subroutine.subroutines_not_allowed_as_variables_constructors_and_argument_or_return_types Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_function.cpp | 5 - 1 file changed, 4

[Mesa-dev] [PATCH 1/2] glsl: subroutine types cannot be used in constructors.

From: Dave Airlie This fixes two of the cases in GL43-CTS.shader_subroutine.subroutines_not_allowed_as_variables_constructors_and_argument_or_return_types Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_function.cpp | 6 ++ 1 file changed, 6

Re: [Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

Samuel Iglesias Gonsálvez writes: > Hello, > > This patch series continues adding arb_gpu_shader_fp64 support to the > Intel driver. Specifically, this targets the i965 scalar backend for > BDW+ hardware (vec4 is still under research and gen7 has its own > issues which we

[Mesa-dev] [Bug 95246] Segfault in glBindFramebuffer()

https://bugs.freedesktop.org/show_bug.cgi?id=95246 --- Comment #1 from Daniel Scharrer --- Backtrace: #0 driver_RenderTexture_is_safe (att=att@entry=0xb33570) at /var/tmp/portage/media-libs/mesa-/work/mesa-/src/mesa/main/fbobject.c:392 #1 0x729aabc3

[Mesa-dev] [Bug 95246] Segfault in glBindFramebuffer()

https://bugs.freedesktop.org/show_bug.cgi?id=95246 Bug ID: 95246 Summary: Segfault in glBindFramebuffer() Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] gallium: Specific configuration for generic elements?

With classic DRI drivers, the DRI Configuration Infrastructure can be used to read driver-specific parameters from XML files. The i965 driver (src/mesa/drivers/dri/i965/intel_screen.c) uses this feature for instance. In Gallium, the DRI Configuration Infrastructure is used to set common options

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

Samuel Iglesias Gonsálvez writes: > From: Connor Abbott > > Similar to retype() and offset(). > --- > src/mesa/drivers/dri/i965/brw_ir_fs.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_ir_fs.h >

[Mesa-dev] [PATCH] main: uses casts to silence some _mesa_debug() format warnings

Silences warnings with 32-bit Linux gcc builds and MinGW which doesn't recognize the ‘t’ conversion character. --- src/mesa/main/bufferobj.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 731b62e..e60a8ea

Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

On 05/02/2016 06:15 PM, Ilia Mirkin wrote: I know I've been sticking commas at the end of enums left and right for the past several years, and haven't heard any complaints. The nice thing about the trailing comma is that you avoid having to change unrelated lines when adding entries. This leads

Re: [Mesa-dev] [PATCH] genxml: avoid using a GNU make pattern rule

On Mon, May 02, 2016 at 11:44:35AM -0700, Jason Ekstrand wrote: > On Mon, May 2, 2016 at 2:27 AM, Jonathan Gray wrote: > > > On Mon, May 02, 2016 at 02:23:46AM -0700, Jason Ekstrand wrote: > > > On May 1, 2016 11:24 PM, "Jonathan Gray" wrote: > > > > > > > > %

Re: [Mesa-dev] [PATCH 3/3] egl: android: remove explicit glFlush call

On Sun, May 1, 2016 at 6:42 AM, Emil Velikov wrote: > The DRI flush extension should already do the same thing. > > Cc: Rob Herring > Signed-off-by: Emil Velikov > --- > NOTE: Untested, although based on my humble

Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

I know I've been sticking commas at the end of enums left and right for the past several years, and haven't heard any complaints. The nice thing about the trailing comma is that you avoid having to change unrelated lines when adding entries. This leads to cleaner per-line histories, which can be

Re: [Mesa-dev] [PATCH] cso: null-out previously bound sampler states

On Mon, May 2, 2016 at 8:02 PM, Brian Paul wrote: > If, for example, we previously had 2 sampler states bound and now we > are binding one, we'd leave the second sampler state unchanged. > This change nulls-out the second sampler state in this situation. > We're already doing

Re: [Mesa-dev] [PATCH 4/5] freedreno: s/Elements/ARRAY_SIZE/

On Mon, May 2, 2016 at 8:02 PM, Brian Paul wrote: > Reviewed-by: Rob Clark > --- > src/gallium/drivers/freedreno/ir3/ir3_cmdline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/freedreno/ir3/ir3_cmdline.c

[Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

Silences warnings from -Wpedantic: In file included from ../../src/compiler/glsl/glsl_symbol_table.h:34:0, from ../../src/compiler/glsl/glsl_parser_extras.h:35, from nir/glsl_to_nir.h:29, from nir/glsl_to_nir.cpp:51:

[Mesa-dev] [PATCH 5/5] rbug: s/Elements/ARRAY_SIZE/

--- src/gallium/drivers/rbug/rbug_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/rbug/rbug_context.c b/src/gallium/drivers/rbug/rbug_context.c index 38dee74..54564c1 100644 --- a/src/gallium/drivers/rbug/rbug_context.c +++

[Mesa-dev] [PATCH 4/5] freedreno: s/Elements/ARRAY_SIZE/

--- src/gallium/drivers/freedreno/ir3/ir3_cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_cmdline.c b/src/gallium/drivers/freedreno/ir3/ir3_cmdline.c index b8b9e4a..7007d20 100644 ---

[Mesa-dev] [PATCH 3/5] trace: s/Elements/ARRAY_SIZE/

--- src/gallium/drivers/trace/tr_dump_state.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/trace/tr_dump_state.c b/src/gallium/drivers/trace/tr_dump_state.c index 591ca79..bc129e0 100644 --- a/src/gallium/drivers/trace/tr_dump_state.c +++

[Mesa-dev] [PATCH 2/5] ilo: s/Elements/ARRAY_SIZE/

--- src/gallium/drivers/ilo/ilo_blit.h| 2 +- src/gallium/drivers/ilo/ilo_render.c | 2 +- src/gallium/drivers/ilo/ilo_render_dynamic.c | 8 src/gallium/drivers/ilo/ilo_render_surface.c | 4 ++-- src/gallium/drivers/ilo/ilo_screen.c

[Mesa-dev] [PATCH] cso: null-out previously bound sampler states

If, for example, we previously had 2 sampler states bound and now we are binding one, we'd leave the second sampler state unchanged. This change nulls-out the second sampler state in this situation. We're already doing the same thing for sampler views. This silences an occasional warning issued

[Mesa-dev] [PATCH 1/5] i915g: s/Elements/ARRAY_SIZE/

--- src/gallium/drivers/i915/i915_fpc_translate.c| 4 ++-- src/gallium/drivers/i915/i915_resource_texture.c | 4 ++-- src/gallium/drivers/i915/i915_state.c| 8 src/gallium/drivers/i915/i915_state_dynamic.c| 2 +- src/gallium/drivers/i915/i915_state_emit.c | 4

Re: [Mesa-dev] [PATCH 59/59] i965/fs: fix MOV_INDIRECT exec_size for doubles

On 2016-05-02 00:31:41, Iago Toral wrote: > On Sun, 2016-05-01 at 20:04 -0700, Jordan Justen wrote: > > On 2016-04-29 04:29:56, Samuel Iglesias Gonsálvez wrote: > > > In that case, the writes need two times the size of a 32-bit value. > > > We need to adjust the exec_size, so it is not breaking

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

On Monday, May 2, 2016 4:10:38 PM PDT Kenneth Graunke wrote: > The idea of "upload all the 64-bit things first, add 0 or 1 padding > slots, then upload all the 32-bit things" also seems like it could > simplify this code a lot. Sorry, I misspoke - if you upload all the 64-bit things first, then

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

On Friday, April 29, 2016 1:29:53 PM PDT Samuel Iglesias Gonsálvez wrote: > When there is a mix of definitions of uniforms with 32-bit or 64-bit > data type sizes, the driver ends up doing misaligned access to double > based variables in the push constant buffer. > > To fix this, the driver adds

Re: [Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

On 2016-05-01 22:47:40, Jordan Justen wrote: > 7-10, 12-20, 36-43, 57-58: > Reviewed-by: Jordan Justen 34-35 Reviewed-by: Jordan Justen > > I also sent questions about 56 & 59. > > On 2016-04-29 04:28:57, Samuel Iglesias Gonsálvez wrote:

Re: [Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

I neglected to include a cpu test in my list of regressions: piglit.spec.glsl-1_10.compiler.vector-dereference-in-dereference.frag asserts with "glslparsertest: src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp:422: virtual ir_visitor_status

Re: [Mesa-dev] [PATCH 00/59] Initial arb_gpu_shader_fp64 support to the i965 scalar backend

Samuel Iglesias Gonsálvez writes: > Hello, > > This patch series continues adding arb_gpu_shader_fp64 support to the > Intel driver. Specifically, this targets the i965 scalar backend for > BDW+ hardware (vec4 is still under research and gen7 has its own > issues which we

Re: [Mesa-dev] [PATCH 29/59] i965/fs: add a pass for lowering PACK opcodes

On Monday, May 2, 2016 9:15:53 AM PDT Iago Toral wrote: > On Sat, 2016-04-30 at 00:50 -0700, Kenneth Graunke wrote: > > On Friday, April 29, 2016 1:29:26 PM PDT Samuel Iglesias Gonsálvez wrote: > > > From: Connor Abbott > > > > > > --- > > >

[Mesa-dev] [PATCH] radeonsi: mark descriptor loads as using dynamically uniform indices

From: Nicolai Hähnle This tells LLVM to always use SMEM loads for descriptors. It fixes a regression in piglit's arb_shader_storage_buffer_object/execution/indirect.shader_test that was caused by LLVM r268259 (but the proper fix is really here in Mesa). ---

Re: [Mesa-dev] [PATCH] gallium, utils: Fix trivial sign compare warnings

Reviewed-by: Jakob Sinclair On 2016-05-02 07:15, Jan Vesely wrote: From: Jan Vesely Signed-off-by: Jan Vesely --- src/gallium/auxiliary/util/u_blitter.c| 10 +-

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

On Mon, May 2, 2016 at 9:51 PM, Rob Clark wrote: > On Mon, May 2, 2016 at 3:21 PM, Marek Olšák wrote: >> On Mon, May 2, 2016 at 9:05 PM, Rob Clark wrote: >>> This is for the non-zero-copy case.. for example pixels live in gl >>>

[Mesa-dev] [PATCH 4/4] nvc0: compute a percentage for metric-achieved_occupancy

metric-issue_slot_utilization and metric-branch_efficiency are already computed as percentages. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_metric.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 1/4] nvc0: fix exposing of metric-issue_slots for SM21/SM30

This is most likely a copy-paste error when I reworked this area few weeks ago. For SM20, metric-issue_slots is equal to inst_issued because there is only one pipeline, so the metric is not exposed there. Signed-off-by: Samuel Pitoiset Reported-by: Karol Herbst

[Mesa-dev] [PATCH 2/4] nvc0: store the driver query type for performance metrics

This will allow to use percentages for some metrics because the Gallium HUD doesn't allow to display floating point numbers and 0 is printed instead. Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/nvc0/nvc0_query_hw_metric.c| 40 -- 1

[Mesa-dev] [PATCH 3/4] nvc0: display some performance metrics with a percentage

This makes more sense for them. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_metric.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_metric.c

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

On Mon, May 2, 2016 at 3:21 PM, Marek Olšák wrote: > On Mon, May 2, 2016 at 9:05 PM, Rob Clark wrote: >> This is for the non-zero-copy case.. for example pixels live in gl >> texture in host (vmwgfx/virtgl), or in vram for discrete gpu perhaps >> (or some

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

On Mon, May 2, 2016 at 9:05 PM, Rob Clark wrote: > This is for the non-zero-copy case.. for example pixels live in gl > texture in host (vmwgfx/virtgl), or in vram for discrete gpu perhaps > (or some tiled format, etc). > > Since in those cases, you have to copy part of the

Re: [Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

Same comment about missing the check for a non-SSA source. On Fri, Apr 29, 2016 at 7:29 AM, Samuel Iglesias Gonsálvez wrote: > From: Iago Toral Quiroga > > When we are actually unpacking from a double that we have previously > packed from its 32-bit

Re: [Mesa-dev] [PATCH 31/59] i965/fs: optimize pack double

On Fri, Apr 29, 2016 at 7:29 AM, Samuel Iglesias Gonsálvez wrote: > From: Iago Toral Quiroga > > When we are actually creating a double using values obtained from a > previous unpack operation we can bypass the unpack and source from > the original double

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

This is for the non-zero-copy case.. for example pixels live in gl texture in host (vmwgfx/virtgl), or in vram for discrete gpu perhaps (or some tiled format, etc). Since in those cases, you have to copy part of the buffer, as specified by the bounding box, to and/or from staging buffer (based

[Mesa-dev] [Bug 95215] ARB_shading_language_include is not implemented

https://bugs.freedesktop.org/show_bug.cgi?id=95215 --- Comment #9 from farmboy0+freedesk...@googlemail.com --- (In reply to Kenneth Graunke from comment #8) > FWIW, I would prefer not to implement ARB_shading_language_include. Why not? -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [PATCH] genxml: avoid using a GNU make pattern rule

On Mon, May 2, 2016 at 2:27 AM, Jonathan Gray wrote: > On Mon, May 02, 2016 at 02:23:46AM -0700, Jason Ekstrand wrote: > > On May 1, 2016 11:24 PM, "Jonathan Gray" wrote: > > > > > > % pattern rules are a GNU extension. Convert the use of one to a > > > suffix

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

On 05/01/2016 11:58 PM, Daniel Vetter wrote: Adding Greg Hackmann from the Android side. Greg, please add anyone else who might be relevant. On Sat, Apr 30, 2016 at 2:54 PM, Rob Clark wrote: On Sat, Apr 30, 2016 at 8:26 AM, Marek Olšák wrote: On Sat,

Re: [Mesa-dev] [PATCH] gallium, utils: Fix trivial sign compare warnings

Reviewed-by: Nicolai Hähnle On 02.05.2016 00:15, Jan Vesely wrote: From: Jan Vesely Signed-off-by: Jan Vesely --- src/gallium/auxiliary/util/u_blitter.c| 10 +-

Re: [Mesa-dev] [PATCH 00/10] RadeonSI: Cleanup tiling-related code

Patches 2-10: Reviewed-by: Nicolai Hähnle On 01.05.2016 08:51, Marek Olšák wrote: Hi, This series drops SI support for kernels < 3.10, and CIK support for kernels < 3.13. All code that tries to guess tile mode parameters is removed. Everything is changed to use

Re: [Mesa-dev] [PATCH] st/mesa: fix blit-based GetTexImage for non-finalized textures

Reviewed-by: Nicolai Hähnle On 01.05.2016 08:35, Marek Olšák wrote: From: Marek Olšák This fixes getteximage-depth piglit failures on radeonsi. Cc: 11.1 11.2 --- src/mesa/state_tracker/st_cb_texture.c | 3

Re: [Mesa-dev] [PATCH 1/4] radeonsi: when parsing dmesg, skip empty lines

For the series: Reviewed-by: Nicolai Hähnle On 01.05.2016 08:35, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_debug.c

Re: [Mesa-dev] [PATCH] radeonsi: use the hw MSAA resolving if formats are compatible

Reviewed-by: Nicolai Hähnle On 01.05.2016 08:33, Marek Olšák wrote: From: Marek Olšák This allows resolving RGBA into RGBX. This should improve HL2 Lost Coast performance. --- src/gallium/drivers/radeonsi/si_blit.c | 3 ++- 1 file changed, 2

Re: [Mesa-dev] [PATCH 02/59] vc4: lower lrp when operating with double operands

Samuel Iglesias Gonsálvez writes: > Lower lrp when operating with double operands because float version of > lrp is also lowered. Kind of silly since there will never be double operands on vc4. I'd drop the patch, but if you'd like it for consistency: Acked-by: Eric

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

On Mon, 2016-05-02 at 10:30 +0300, Pohjolainen, Topi wrote: > On Fri, Apr 29, 2016 at 01:29:24PM +0200, Samuel Iglesias Gons?lvez wrote: > > From: Connor Abbott > > > > Similar to retype() and offset(). > > --- > > src/mesa/drivers/dri/i965/brw_ir_fs.h | 8 >

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

On Mon, May 02, 2016 at 04:28:18PM +0300, Pohjolainen, Topi wrote: > On Fri, Apr 29, 2016 at 01:29:53PM +0200, Samuel Iglesias Gons?lvez wrote: > > When there is a mix of definitions of uniforms with 32-bit or 64-bit > > data type sizes, the driver ends up doing misaligned access to double > >

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

On Fri, Apr 29, 2016 at 01:29:53PM +0200, Samuel Iglesias Gons?lvez wrote: > When there is a mix of definitions of uniforms with 32-bit or 64-bit > data type sizes, the driver ends up doing misaligned access to double > based variables in the push constant buffer. > > To fix this, the driver adds

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

On Sun, May 01, 2016 at 07:42:42PM -0700, Jordan Justen wrote: > On 2016-04-29 04:29:53, Samuel Iglesias Gonsálvez wrote: > > When there is a mix of definitions of uniforms with 32-bit or 64-bit > > data type sizes, the driver ends up doing misaligned access to double > > based variables in the

Re: [Mesa-dev] [PATCH 58/59] i965/fs: take into account doubles when calculating read_size for MOV_INDIRECT

On Fri, Apr 29, 2016 at 01:29:55PM +0200, Samuel Iglesias Gons?lvez wrote: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

Hi, On 2 May 2016 at 11:44, Rob Clark wrote: > On Mon, May 2, 2016 at 2:15 AM, Michel Dänzer wrote: >> So, what is this based on? Maybe I'm not looking in the right place, but >> out of hundreds of changes in Git touching those files, I see one change >>

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

On Mon, May 2, 2016 at 2:15 AM, Michel Dänzer wrote: > On 25.04.2016 21:36, Daniel Stone wrote: >> On 20 April 2016 at 00:32, Rob Clark wrote: >>> On Tue, Apr 19, 2016 at 7:04 PM, Matt Turner wrote: Let's let people add

Re: [Mesa-dev] [PATCH 59/59] i965/fs: fix MOV_INDIRECT exec_size for doubles

On May 2, 2016 12:31 AM, "Iago Toral" wrote: > > On Sun, 2016-05-01 at 20:04 -0700, Jordan Justen wrote: > > On 2016-04-29 04:29:56, Samuel Iglesias Gonsálvez wrote: > > > In that case, the writes need two times the size of a 32-bit value. > > > We need to adjust the exec_size,

Re: [Mesa-dev] [PATCH] genxml: avoid using a GNU make pattern rule

On Mon, May 02, 2016 at 02:23:46AM -0700, Jason Ekstrand wrote: > On May 1, 2016 11:24 PM, "Jonathan Gray" wrote: > > > > % pattern rules are a GNU extension. Convert the use of one to a > > suffix rule to allow this to build on OpenBSD. > > > > Signed-off-by: Jonathan Gray

Re: [Mesa-dev] [PATCH] genxml: avoid using a GNU make pattern rule

On May 1, 2016 11:24 PM, "Jonathan Gray" wrote: > > % pattern rules are a GNU extension. Convert the use of one to a > suffix rule to allow this to build on OpenBSD. > > Signed-off-by: Jonathan Gray > --- > src/intel/genxml/Makefile.am | 4 +++- > 1 file

Re: [Mesa-dev] [PATCH 43/59] i965/fs: fix dst width calculation in CSE

On Fri, Apr 29, 2016 at 01:29:40PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Connor Abbott > > --- > src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp >

Re: [Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

On Fri, Apr 29, 2016 at 01:29:29PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Iago Toral Quiroga > > When we are actually unpacking from a double that we have previously > packed from its 32-bit components we can bypass the pack operation > and source from its arguments

Re: [Mesa-dev] [PATCH 31/59] i965/fs: optimize pack double

On Fri, Apr 29, 2016 at 01:29:28PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Iago Toral Quiroga > > When we are actually creating a double using values obtained from a > previous unpack operation we can bypass the unpack and source from > the original double value

Re: [Mesa-dev] [PATCH 30/59] i965/fs/nir: translate double pack/unpack

On Fri, Apr 29, 2016 at 01:29:27PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Connor Abbott > > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp >

Re: [Mesa-dev] [PATCH 18/59] i965: fix brw_saturate_immediate() for doubles

On Mon, 2016-05-02 at 10:54 +0300, Pohjolainen, Topi wrote: > On Mon, May 02, 2016 at 09:42:14AM +0200, Iago Toral wrote: > > On Mon, 2016-05-02 at 10:34 +0300, Pohjolainen, Topi wrote: > > > On Mon, May 02, 2016 at 09:22:49AM +0200, Iago Toral wrote: > > > > On Mon, 2016-05-02 at 10:08 +0300,

Re: [Mesa-dev] [PATCH 18/59] i965: fix brw_saturate_immediate() for doubles

On Mon, May 02, 2016 at 09:42:14AM +0200, Iago Toral wrote: > On Mon, 2016-05-02 at 10:34 +0300, Pohjolainen, Topi wrote: > > On Mon, May 02, 2016 at 09:22:49AM +0200, Iago Toral wrote: > > > On Mon, 2016-05-02 at 10:08 +0300, Pohjolainen, Topi wrote: > > > > On Mon, May 02, 2016 at 10:02:50AM

Re: [Mesa-dev] [PATCH 18/59] i965: fix brw_saturate_immediate() for doubles

On Mon, 2016-05-02 at 10:34 +0300, Pohjolainen, Topi wrote: > On Mon, May 02, 2016 at 09:22:49AM +0200, Iago Toral wrote: > > On Mon, 2016-05-02 at 10:08 +0300, Pohjolainen, Topi wrote: > > > On Mon, May 02, 2016 at 10:02:50AM +0300, Pohjolainen, Topi wrote: > > > > On Fri, Apr 29, 2016 at

Re: [Mesa-dev] [PATCH 18/59] i965: fix brw_saturate_immediate() for doubles

On Mon, May 02, 2016 at 09:22:49AM +0200, Iago Toral wrote: > On Mon, 2016-05-02 at 10:08 +0300, Pohjolainen, Topi wrote: > > On Mon, May 02, 2016 at 10:02:50AM +0300, Pohjolainen, Topi wrote: > > > On Fri, Apr 29, 2016 at 01:29:15PM +0200, Samuel Iglesias Gons?lvez wrote: > > > > From: Iago Toral

Re: [Mesa-dev] [PATCH 59/59] i965/fs: fix MOV_INDIRECT exec_size for doubles

On Sun, 2016-05-01 at 20:04 -0700, Jordan Justen wrote: > On 2016-04-29 04:29:56, Samuel Iglesias Gonsálvez wrote: > > In that case, the writes need two times the size of a 32-bit value. > > We need to adjust the exec_size, so it is not breaking any hardware > > rule. > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

On Fri, Apr 29, 2016 at 01:29:24PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Connor Abbott > > Similar to retype() and offset(). > --- > src/mesa/drivers/dri/i965/brw_ir_fs.h | 8 > 1 file changed, 8 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 18/59] i965: fix brw_saturate_immediate() for doubles

On Mon, 2016-05-02 at 10:08 +0300, Pohjolainen, Topi wrote: > On Mon, May 02, 2016 at 10:02:50AM +0300, Pohjolainen, Topi wrote: > > On Fri, Apr 29, 2016 at 01:29:15PM +0200, Samuel Iglesias Gons?lvez wrote: > > > From: Iago Toral Quiroga > > > > > > --- > > >

Re: [Mesa-dev] [PATCH 26/59] i965/fs: always pass the bitsize to brw_type_for_nir_type()

On Fri, Apr 29, 2016 at 01:29:23PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Connor Abbott > > v2 (Sam): > - Add bitsize to brw_type_for_nir_type() in optimize_extract_to_float() > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 12 +--- > 1 file

Re: [Mesa-dev] [PATCH 29/59] i965/fs: add a pass for lowering PACK opcodes

On Sat, 2016-04-30 at 00:50 -0700, Kenneth Graunke wrote: > On Friday, April 29, 2016 1:29:26 PM PDT Samuel Iglesias Gonsálvez wrote: > > From: Connor Abbott > > > > --- > > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > > src/mesa/drivers/dri/i965/brw_fs.cpp

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #18 from Ernst Sjöstrand --- Jamey: I have had your patch applied the whole time, now I tested with you patch + Karol's patches. It seems highly unlikely to me that the game would have any chance of working without

Re: [Mesa-dev] [PATCH 23/59] i965/fs: use the NIR bit size when creating registers

On Fri, Apr 29, 2016 at 01:29:20PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Connor Abbott > > v2 (Iago): > - Squashed bits from 'support double precission constant operands for > the implementation of 64-bit emit_load_const'. > - Do not use

Re: [Mesa-dev] [PATCH 18/59] i965: fix brw_saturate_immediate() for doubles

On Mon, May 02, 2016 at 10:02:50AM +0300, Pohjolainen, Topi wrote: > On Fri, Apr 29, 2016 at 01:29:15PM +0200, Samuel Iglesias Gons?lvez wrote: > > From: Iago Toral Quiroga > > > > --- > > src/mesa/drivers/dri/i965/brw_shader.cpp | 28 ++-- > > 1 file

Re: [Mesa-dev] [PATCH 18/59] i965: fix brw_saturate_immediate() for doubles

On Fri, Apr 29, 2016 at 01:29:15PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Iago Toral Quiroga > > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 28 ++-- > 1 file changed, 22 insertions(+), 6 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

Adding Greg Hackmann from the Android side. Greg, please add anyone else who might be relevant. On Sat, Apr 30, 2016 at 2:54 PM, Rob Clark wrote: > On Sat, Apr 30, 2016 at 8:26 AM, Marek Olšák wrote: >> On Sat, Apr 30, 2016 at 1:55 PM, Rob Clark

Re: [Mesa-dev] [PATCH 15/59] i965/eu: add support for DF immediates

On Fri, Apr 29, 2016 at 01:29:12PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Connor Abbott > > --- > src/mesa/drivers/dri/i965/brw_eu_emit.c | 28 +--- > 1 file changed, 21 insertions(+), 7 deletions(-) > > diff --git

[Mesa-dev] [PATCH] genxml: avoid using a GNU make pattern rule

% pattern rules are a GNU extension. Convert the use of one to a suffix rule to allow this to build on OpenBSD. Signed-off-by: Jonathan Gray --- src/intel/genxml/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/genxml/Makefile.am

Re: [Mesa-dev] [RFC] add MAINTAINERS and get_maintainer.pl script

On 25.04.2016 21:36, Daniel Stone wrote: > On 20 April 2016 at 00:32, Rob Clark wrote: >> On Tue, Apr 19, 2016 at 7:04 PM, Matt Turner wrote: >>> Let's let people add themselves to the file if they want. No point in >>> trying to populate it up front. >>

Re: [Mesa-dev] [PATCH 3/3] genxml: avoid using GNU make extensions

On Sun, May 01, 2016 at 10:32:18PM -0700, Jason Ekstrand wrote: > On May 1, 2016 1:56 AM, "Emil Velikov" wrote: > > > > On 1 May 2016 at 09:49, Jonathan Gray wrote: > > > On Fri, Apr 22, 2016 at 05:57:40PM +0100, Emil Velikov wrote: > > >> On 22 April