[Mesa-dev] [PATCH 2/3] egl/x11_dri3: provide an authentication function

2016-06-17 Thread Frank Binns
To support WL_bind_wayland_display an authentication function needs to be provided but this was not being done for this platform as it's not strictly necessary. However, as this isn't an optional function there's the potential for a segfault to occur if authentication is mistakenly performed.

[Mesa-dev] [PATCH] wayland-drm: add missing NULL check

2016-06-17 Thread Frank Binns
Although malloc is unlikely to fail check its return value nevertheless. Signed-off-by: Frank Binns --- src/egl/wayland/wayland-drm/wayland-drm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/wayland/wayland-drm/wayland-drm.c

[Mesa-dev] [PATCH] loader: fix sysfs uevent file parsing

2016-06-17 Thread Frank Binns
When trying to get a device name for an fd using sysfs, it would always fail as it was expecting key/value pairs to be delimited by '\0', which is not the case. Signed-off-by: Frank Binns --- src/loader/loader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

2016-06-17 Thread Ian Romanick
From: Ian Romanick Khronos recommends that the GLES 3.1 library also be called libGLESv2. It also requires that functions be statically linkable from that library. NOTE: Mesa has supported the EGL_KHR_get_all_proc_addresses extension since at least Mesa 10.5, so

[Mesa-dev] [PATCH v2] swr: Update screen->context pointer with multiple contexts.

2016-06-17 Thread Bruce Cherniak
A pipe pointer in the screen allows for access to current device context in flush_frontbuffer and resource_destroy. This wasn't tracking current context in multi-context situations. v2: More caffeine. Corrected compare, removed unnecessary set of screen-pipe in create_context, and added a few

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

2016-06-17 Thread Eric Engestrom
On Fri, Jun 17, 2016 at 04:09:55PM +0200, ⚛ wrote: > Hello. Are you editing those files by hand? Yup, editing everything by hand. You just need a magnetized needle and a steady hand. I'm still learning to use C-x M-c M-butterfly though, haven't mastered that yet.

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-17 Thread Eric Engestrom
On Thu, Jun 16, 2016 at 11:15:55AM -0600, Brian Paul wrote: > To match what's done in the automake build. > > v2: Use git rev-parse to get a 10-character hash ID > Fix Python imports > --- Perfect, thanks! Reviewed-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] scons: put the generated git_sha1.h file in top-level src/ directory

2016-06-17 Thread Jose Fonseca
On 16/06/16 18:15, Brian Paul wrote: To match what's done in the automake build. v2: Use git rev-parse to get a 10-character hash ID Fix Python imports --- src/SConscript | 49 - src/mesa/SConscript | 45

Re: [Mesa-dev] [PATCH v4] gallium: add API for setting window rectangles

2016-06-17 Thread Ilia Mirkin
On Fri, Jun 17, 2016 at 12:02 PM, Nicolai Hähnle wrote: > FYI, in case you haven't heard: the corresponding hardware feature on Radeon > allows four rectangles, and specifying an arbitrary logic function over > them. That is, there are 2^4 = 16 bits specifying when fragments

Re: [Mesa-dev] [PATCH v4] gallium: add API for setting window rectangles

2016-06-17 Thread Nicolai Hähnle
FYI, in case you haven't heard: the corresponding hardware feature on Radeon allows four rectangles, and specifying an arbitrary logic function over them. That is, there are 2^4 = 16 bits specifying when fragments are discarded. If we wanted to expose that at some point, we'd have to uglify

[Mesa-dev] [PATCH v2] swr: push/pop DEBUG macro around llvm includes

2016-06-17 Thread Tim Rowley
llvm redefines DEBUG; adding push/pop prevents a undefined reference to debug_refcnt_state in llvm-3.7+. v2: add undef DEBUG --- src/gallium/drivers/swr/swr_shader.cpp | 10 +++--- src/gallium/drivers/swr/swr_state.cpp | 7 ++- 2 files changed, 13 insertions(+), 4 deletions(-) diff

Re: [Mesa-dev] [PATCH 0/7] st/mesa: glReadPixels cache

2016-06-17 Thread Nicolai Hähnle
On 15.06.2016 17:16, Brian Paul wrote: On 06/15/2016 02:38 AM, Nicolai Hähnle wrote: Hi, some applications use successive calls to glReadPixels to read data back. This typically involves a GPU-based blit for each call for de-tiling or format conversions (e.g. BGRA -> RGBA). Even when the

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-17 Thread Christian König
Really nice work. I now understand where your problem is with the scaled surface. Please see the further comments below. Am 16.06.2016 um 20:15 schrieb Nayan Deshmukh: v2: fix a typo and add a newline to code Signed-off-by: Nayan Deshmukh ---

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

2016-06-17 Thread Rob Clark
On Fri, Jun 17, 2016 at 9:31 AM, Pekka Paalanen wrote: > On Fri, 17 Jun 2016 08:26:04 -0400 > Rob Clark wrote: > >> On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen wrote: >> > On Thu, 16 Jun 2016 10:40:51 -0400 >> > Rob Clark

Re: [Mesa-dev] [PATCH 1/3] radeonsi: raise SI_PM4_MAX_DW

2016-06-17 Thread Alex Deucher
On Fri, Jun 17, 2016 at 10:09 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The old limit, introduced in commit afa752d3f03ac6697581ff5d324e8ac0512ef513, > was exceeded by 4 SE configurations which hit > si_write_harvested_raster_configs. > >

Re: [Mesa-dev] [PATCH] swr: Update screen->context pointer with multiple contexts.

2016-06-17 Thread Chuck Atkins
Hey, we've all made those commits at one point or another. +1 for code review! - Chuck On Fri, Jun 17, 2016 at 10:18 AM, Cherniak, Bruce wrote: > > > On Jun 17, 2016, at 8:56 AM, Rowley, Timothy O < > timothy.o.row...@intel.com> wrote: > > > > > >> On Jun 17, 2016,

Re: [Mesa-dev] [PATCH] swr: Update screen->context pointer with multiple contexts.

2016-06-17 Thread Cherniak, Bruce
> On Jun 17, 2016, at 8:56 AM, Rowley, Timothy O > wrote: > > >> On Jun 17, 2016, at 8:58 AM, Bruce Cherniak wrote: >> >> A pipe pointer in the screen allows for access to current device context >> in flush_frontbuffer and

[Mesa-dev] [PATCH 3/3] radeonsi: emit PA_SC_RASTER_CONFIG_1 only once

2016-06-17 Thread Nicolai Hähnle
From: Nicolai Hähnle It is the same for all SEs. --- src/gallium/drivers/radeonsi/si_state.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

2016-06-17 Thread
Hello. Are you editing those files by hand? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/3] radeonsi: fix calculation of valid RB mask per SE

2016-06-17 Thread Nicolai Hähnle
From: Nicolai Hähnle The old calculation treated too many RBs as disabled. Cc: 11.0 11.1 11.2 12.0 --- src/gallium/drivers/radeonsi/si_state.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] radeonsi: raise SI_PM4_MAX_DW

2016-06-17 Thread Nicolai Hähnle
From: Nicolai Hähnle The old limit, introduced in commit afa752d3f03ac6697581ff5d324e8ac0512ef513, was exceeded by 4 SE configurations which hit si_write_harvested_raster_configs. Cc: 11.1 11.2 12.0 ---

Re: [Mesa-dev] [PATCH] swr: Update screen->context pointer with multiple contexts.

2016-06-17 Thread Rowley, Timothy O
> On Jun 17, 2016, at 8:58 AM, Bruce Cherniak wrote: > > A pipe pointer in the screen allows for access to current device context > in flush_frontbuffer and resource_destroy. This wasn't tracking current > context in multi-context situations. > --- >

[Mesa-dev] [PATCH] swr: Update screen->context pointer with multiple contexts.

2016-06-17 Thread Bruce Cherniak
A pipe pointer in the screen allows for access to current device context in flush_frontbuffer and resource_destroy. This wasn't tracking current context in multi-context situations. --- src/gallium/drivers/swr/swr_context.cpp |6 -- src/gallium/drivers/swr/swr_state.cpp |4 2

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

2016-06-17 Thread Pekka Paalanen
On Fri, 17 Jun 2016 08:26:04 -0400 Rob Clark wrote: > On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen wrote: > > On Thu, 16 Jun 2016 10:40:51 -0400 > > Rob Clark wrote: > > > >> So, if we wanted to extend this to support the

Re: [Mesa-dev] [PATCH] swr: switch from overriding -march to selecting features

2016-06-17 Thread Chuck Atkins
Using these adjusted flags, I can verify SWR running on Intel SandyBridge, Intel Haswell, and AMD Interlagos. Acked-by: Chuck Atkins Tested-by: Chuck Atkins - Chuck On Thu, Jun 16, 2016 at 4:07 PM, Tim Rowley

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

2016-06-17 Thread Rob Clark
On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen wrote: > On Thu, 16 Jun 2016 10:40:51 -0400 > Rob Clark wrote: > >> So, if we wanted to extend this to support the fourcc-modifiers that >> we have on the kernel side for compressed/tiled/etc formats, what

Re: [Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

2016-06-17 Thread Erik Faye-Lund
Now the subject no longer makes any sense. On Thu, Jun 16, 2016 at 7:02 AM, wrote: > From: Francesco Ansanelli > > --- > src/mesa/state_tracker/st_cb_fbo.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

2016-06-17 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 17/06/16 07:12, Timothy Arceri wrote: > --- > src/mesa/main/api_validate.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/src/mesa/main/api_validate.c

Re: [Mesa-dev] [PATCH] swr: push/pop DEBUG macro around llvm includes

2016-06-17 Thread Jose Fonseca
On 17/06/16 03:13, Tim Rowley wrote: llvm redefines DEBUG; adding push/pop prevents a undefined reference to debug_refcnt_state in llvm-3.7+. --- src/gallium/drivers/swr/swr_shader.cpp | 9 ++--- src/gallium/drivers/swr/swr_state.cpp | 6 +- 2 files changed, 11 insertions(+), 4

Re: [Mesa-dev] [PATCH v3] i965/fs: indirect addressing with doubles is not supported in CHV/BSW/BXT

2016-06-17 Thread Samuel Iglesias Gonsálvez
On 17/06/16 11:12, Kenneth Graunke wrote: > On Friday, June 17, 2016 11:10:28 AM PDT Samuel Iglesias Gonsálvez wrote: [...] >> What do you think Kenneth? >> >> Sam > > This sounds great to me. I like v4 (your suggestion above) the best. > Thanks for fixing this, and putting in the extra effort

Re: [Mesa-dev] [PATCH v3] i965/fs: indirect addressing with doubles is not supported in CHV/BSW/BXT

2016-06-17 Thread Kenneth Graunke
On Friday, June 17, 2016 11:10:28 AM PDT Samuel Iglesias Gonsálvez wrote: > > On 17/06/16 10:43, Samuel Iglesias Gonsálvez wrote: > > From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region > > Restrictions, page 844: > > > > "When source or destination datatype is 64b or

Re: [Mesa-dev] [PATCH v3] i965/fs: indirect addressing with doubles is not supported in CHV/BSW/BXT

2016-06-17 Thread Samuel Iglesias Gonsálvez
On 17/06/16 10:43, Samuel Iglesias Gonsálvez wrote: > From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region > Restrictions, page 844: > > "When source or destination datatype is 64b or operation is integer DWord >multiply, indirect addressing must not be used." > >

[Mesa-dev] [PATCH v3] i965/fs: indirect addressing with doubles is not supported in CHV/BSW/BXT

2016-06-17 Thread Samuel Iglesias Gonsálvez
From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region Restrictions, page 844: "When source or destination datatype is 64b or operation is integer DWord multiply, indirect addressing must not be used." v2: - Fix it for Broxton too. v3: - Simplify code by using

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

2016-06-17 Thread Pekka Paalanen
On Thu, 16 Jun 2016 10:40:51 -0400 Rob Clark wrote: > So, if we wanted to extend this to support the fourcc-modifiers that > we have on the kernel side for compressed/tiled/etc formats, what > would be the right approach? > > A new version of the existing extension or a new

Re: [Mesa-dev] [PATCH 2/2] i965/fs: indirect addressing with doubles is not supported in CHV/BSW

2016-06-17 Thread Samuel Iglesias Gonsálvez
On 17/06/16 08:57, Kenneth Graunke wrote: > On Wednesday, June 15, 2016 9:25:45 AM PDT Samuel Iglesias Gonsálvez wrote: >> From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region >> Restrictions, page 844: >> >> "When source or destination datatype is 64b or operation is

Re: [Mesa-dev] [PATCH 2/4] i965: Fix multiplication of immediates on Cherryview/Broxton.

2016-06-17 Thread Kenneth Graunke
On Saturday, June 11, 2016 4:06:32 PM PDT Jordan Justen wrote: > On 2016-06-10 14:19:44, Kenneth Graunke wrote: > > Cherryview and Broxton don't support DW x DW multiplication. We have > > piles of code to handle this, but apparently weren't retyping in the > > immediate case. > > > > For

Re: [Mesa-dev] [PATCH 2/2] i965/fs: indirect addressing with doubles is not supported in CHV/BSW

2016-06-17 Thread Kenneth Graunke
On Wednesday, June 15, 2016 9:25:45 AM PDT Samuel Iglesias Gonsálvez wrote: > From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region > Restrictions, page 844: > > "When source or destination datatype is 64b or operation is integer DWord >multiply, indirect addressing

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Fix single-precision to double-precision conversions for CHV/BSW

2016-06-17 Thread Kenneth Graunke
On Wednesday, June 15, 2016 9:25:44 AM PDT Samuel Iglesias Gonsálvez wrote: > From: Iago Toral Quiroga > > From the Cherryview PRM, Volume 7, 3D Media GPGPU Engine, > Register Region Restrictions: > >"When source or destination is 64b (...), regioning in Align1 > must

<    1   2