[Mesa-dev] [Bug 97420] "#version 0" crashes glsl_compiler

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97420 --- Comment #3 from Tapani Pälli --- There's also a small problem in '_define_object_macro' (which causes crash). It can be called with 'loc' being NULL, there's 2 usages of 'loc' but only one of them takes NULL in to account.

[Mesa-dev] [Bug 97420] "#version 0" crashes glsl_compiler

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97420 --- Comment #2 from Timothy Arceri --- Looks like version is set twice. Once explicitly by the shader and once by glcpp_parser_resolve_implicit_version() as we no longer set a bool to skip the implicit call but check the

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-22 Thread Francisco Jerez
Ilia Mirkin writes: > On Tue, Aug 23, 2016 at 12:05 AM, Francisco Jerez > wrote: >> Ilia Mirkin writes: >> >>> On Mon, Aug 22, 2016 at 10:55 PM, Francisco Jerez >>> wrote: Ilia Mirkin

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-22 Thread Ilia Mirkin
On Tue, Aug 23, 2016 at 12:05 AM, Francisco Jerez wrote: > Ilia Mirkin writes: > >> On Mon, Aug 22, 2016 at 10:55 PM, Francisco Jerez >> wrote: >>> Ilia Mirkin writes: >>> On Mon, Aug 22, 2016 at

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Nicholas Miell
On 08/22/2016 04:10 PM, Julien Cristau wrote: On Mon, Aug 22, 2016 at 14:18:51 -0700, Jason Ekstrand wrote: On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau wrote: On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: Not providing a path allows the ICD to work

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-22 Thread Ilia Mirkin
On Mon, Aug 22, 2016 at 10:55 PM, Francisco Jerez wrote: > Ilia Mirkin writes: > >> On Mon, Aug 22, 2016 at 9:59 PM, Francisco Jerez >> wrote: >>> gl_SecondaryFragColorEXT should have the same location as gl_FragColor >>> for

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-22 Thread Francisco Jerez
Ilia Mirkin writes: > On Mon, Aug 22, 2016 at 9:59 PM, Francisco Jerez > wrote: >> gl_SecondaryFragColorEXT should have the same location as gl_FragColor >> for the secondary fragment color to be replicated to all fragment >> outputs. The incorrect

Re: [Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-22 Thread Ilia Mirkin
On Mon, Aug 22, 2016 at 9:59 PM, Francisco Jerez wrote: > gl_SecondaryFragColorEXT should have the same location as gl_FragColor > for the secondary fragment color to be replicated to all fragment > outputs. The incorrect location of gl_SecondaryFragColorEXT would > cause

Re: [Mesa-dev] [PATCH] i965: report bound buffer size not underlying buffer size for image size (v2)

2016-08-22 Thread Francisco Jerez
Dave Airlie writes: > From: Dave Airlie > > This seems to make sense, the image is bound to a subset of the buffer > so the image size should be from the bound size not the underlying > object. > > This fixes: >

[Mesa-dev] [PATCH 1/3] glsl: Fix gl_program::OutputsWritten computation for dual-source blending.

2016-08-22 Thread Francisco Jerez
In the fragment shader OutputsWritten is a bitset of FRAG_RESULT_* enumerants, which represent the location of each color output written by the shader. The secondary and primary color outputs of a given render target using dual-source blending have the same location, so the 'idx' computation

[Mesa-dev] [PATCH 2/3] glsl: Fix incorrect hard-coded location of the gl_SecondaryFragColorEXT built-in.

2016-08-22 Thread Francisco Jerez
gl_SecondaryFragColorEXT should have the same location as gl_FragColor for the secondary fragment color to be replicated to all fragment outputs. The incorrect location of gl_SecondaryFragColorEXT would cause the linker to mark both FRAG_RESULT_COLOR and FRAG_RESULT_DATA0 as being written to,

[Mesa-dev] [PATCH 3/3] i965/fs: Don't consider the stencil output to be a color output.

2016-08-22 Thread Francisco Jerez
This would cause gl_FragStencilRef to be counted as a color output incorrectly during the precompile phase, which leads to unnecessary recompilation on master and could trigger an assertion failure in fs_visitor::emit_fb_writes() on my i965-fb-fetch branch. --- src/mesa/drivers/dri/i965/brw_wm.c

Re: [Mesa-dev] [PATCH] radeonsi: add support for cull distances.

2016-08-22 Thread Ilia Mirkin
On Mon, Aug 22, 2016 at 9:28 PM, Dave Airlie wrote: > From: Dave Airlie > > This should be all that is required for cull distances to work > on radeonsi. > > Signed-off-by: Dave Airlie > --- > src/gallium/drivers/radeonsi/si_pipe.c |

Re: [Mesa-dev] [PATCH 2/2] anv: Throw INCOMPATIBLE_DRIVER for non-fatal initialization errors

2016-08-22 Thread Bas Nieuwenhuizen
This patch is Reviewed-by: Bas Nieuwenhuizen Tested-by: Bas Nieuwenhuizen Thanks. On Tue, Aug 23, 2016 at 3:11 AM, Jason Ekstrand wrote: > The only reason we should throw INITIALIZATION_FAILED is if we have found >

Re: [Mesa-dev] [PATCH 1/2] anv: Add a --disable-vulkan-icd-full-driver-path option

2016-08-22 Thread Edward O'Callaghan
This series is, Acked-by: Edward O'Callaghan On 08/23/2016 11:11 AM, Jason Ekstrand wrote: > This option makes installed Vulkan ICD files contain only a driver library > name and not a path. This is intended for distros to help them work around > multi-arch issues.

Re: [Mesa-dev] [PATCH] st/mesa: set Const.MaxTextureMbytes

2016-08-22 Thread Edward O'Callaghan
On 08/23/2016 07:09 AM, Marek Olšák wrote: > On Mon, Aug 22, 2016 at 6:34 PM, Brian Paul wrote: >> On 08/22/2016 10:26 AM, Brian Paul wrote: >>> >>> On 08/22/2016 08:06 AM, Marek Olšák wrote: From: Marek Olšák ---

Re: [Mesa-dev] [PATCH] radeonsi: add support for cull distances.

2016-08-22 Thread Edward O'Callaghan
Thanks for getting this sent in Dave. On 08/23/2016 11:28 AM, Dave Airlie wrote: > From: Dave Airlie > > This should be all that is required for cull distances to work > on radeonsi. > > Signed-off-by: Dave Airlie Reviewed-by: Edward O'Callaghan

[Mesa-dev] [PATCH] radeonsi: add support for cull distances.

2016-08-22 Thread Dave Airlie
From: Dave Airlie This should be all that is required for cull distances to work on radeonsi. Signed-off-by: Dave Airlie --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- src/gallium/drivers/radeonsi/si_state.c | 8 2 files changed, 6

Re: [Mesa-dev] [PATCH] mesa: validate the indirect param before the shader in DispatchComputeIndirect

2016-08-22 Thread Dave Airlie
[Mesa-dev] [PATCH 1/2] mesa/compute: move compute checks around for tests. where this came up before. Dave. On 23 August 2016 at 06:35, Marek Olšák wrote: > On Mon, Aug 22, 2016 at 5:22 PM, Ilia Mirkin wrote: >> Both direct and indirect compute match

[Mesa-dev] [PATCH 1/2] anv: Add a --disable-vulkan-icd-full-driver-path option

2016-08-22 Thread Jason Ekstrand
This option makes installed Vulkan ICD files contain only a driver library name and not a path. This is intended for distros to help them work around multi-arch issues. --- configure.ac | 7 +++ src/intel/vulkan/Makefile.am | 8 +++-

[Mesa-dev] [PATCH 2/2] anv: Throw INCOMPATIBLE_DRIVER for non-fatal initialization errors

2016-08-22 Thread Jason Ekstrand
The only reason we should throw INITIALIZATION_FAILED is if we have found useable intel hardware but have failed to bring it up for some reason. Otherwise, we should just throw INCOMPATIBLE_DRIVER which will turn into successfully advertising 0 physical devices --- src/intel/vulkan/anv_device.c |

Re: [Mesa-dev] [PATCH] i965: report bound buffer size not underlying buffer size for image size (v2)

2016-08-22 Thread Dave Airlie
ping, esp Igalia CTS ppl. Dave. On 27 May 2016 at 15:11, Dave Airlie wrote: > From: Dave Airlie > > This seems to make sense, the image is bound to a subset of the buffer > so the image size should be from the bound size not the underlying > object. > >

Re: [Mesa-dev] [PATCH v2 12/16] glsl: Add a lowering pass to handle advanced blending modes.

2016-08-22 Thread Francisco Jerez
Kenneth Graunke writes: > Many GPUs cannot handle GL_KHR_blend_equation_advanced natively, and > need to emulate it in the pixel shader. This lowering pass implements > all the necessary math for advanced blending. It fetches the existing > framebuffer value using the

Re: [Mesa-dev] [PATCH 2/4] i965/vec4: make the offset() operate in terms of width and type

2016-08-22 Thread Michael Schellenberger Costa
Hi Iago, Am 22.08.2016 um 11:53 schrieb Iago Toral Quiroga: > This will make it more consistent with the FS implementation of the same > helper and will provide more flexibility that will come in handy, for > example, when we add a SIMD lowering pass in the vec4 backend. > --- >

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Jason Ekstrand
On Mon, Aug 22, 2016 at 2:56 PM, Dave Airlie wrote: > On 23 August 2016 at 07:18, Jason Ekstrand wrote: > > On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau > wrote: > >> > >> On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Julien Cristau
On Mon, Aug 22, 2016 at 14:18:51 -0700, Jason Ekstrand wrote: > On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau wrote: > > > On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: > > > > > Not providing a path allows the ICD to work on multi-arch systems but > > >

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Dave Airlie
On 23 August 2016 at 07:18, Jason Ekstrand wrote: > On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau wrote: >> >> On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: >> >> > Not providing a path allows the ICD to work on multi-arch systems but

[Mesa-dev] [Bug 97420] "#version 0" crashes glsl_compiler

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97420 Karol Herbst changed: What|Removed |Added CC|

[Mesa-dev] [Bug 97420] "#version 0" crashes glsl_compiler

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97420 --- Comment #1 from Karol Herbst --- seems to be a regression eda6349346616f3a45ca2d03e2c1a3da956df6b3 is the first bad commit commit eda6349346616f3a45ca2d03e2c1a3da956df6b3 Author: Ian Romanick

[Mesa-dev] [PATCH 2/2] intel: Flatten the makefile structure

2016-08-22 Thread Jason Ekstrand
This pulls isl and genxml into a single make file so that they can properly build in parallel. This isn't terribly important now as genxml just generates sources which happens serially first anyway but it will be more important as we add more stuff to src/intel. --- configure.ac

[Mesa-dev] [PATCH 1/2] isl/tests: Use a longer path for isl.h

2016-08-22 Thread Jason Ekstrand
The tests assumed that isl would be in the include path but that usually isn't the case. Instead, we usually have src/intel and you need to add an "isl/" prefix. --- src/intel/isl/tests/isl_surf_get_image_offset_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] anv: Give the installed intel_icd.json file an absolute path

2016-08-22 Thread Jason Ekstrand
On Mon, Aug 22, 2016 at 2:06 PM, Julien Cristau wrote: > On Fri, Aug 19, 2016 at 09:04:14 -0700, Jason Ekstrand wrote: > > > Not providing a path allows the ICD to work on multi-arch systems but > > breaks it if you install anywhere other than /usr/lib. Given that users > >

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Marek Olšák
On Mon, Aug 22, 2016 at 10:18 PM, Dave Airlie wrote: > On 23 August 2016 at 06:14, Marek Olšák wrote: >> On Mon, Aug 22, 2016 at 7:05 PM, Brian Paul wrote: >>> On 08/22/2016 08:38 AM, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH] st/mesa: set Const.MaxTextureMbytes

2016-08-22 Thread Marek Olšák
On Mon, Aug 22, 2016 at 6:34 PM, Brian Paul wrote: > On 08/22/2016 10:26 AM, Brian Paul wrote: >> >> On 08/22/2016 08:06 AM, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> --- >>> src/mesa/state_tracker/st_extensions.c | 2 ++ >>> 1 file changed,

[Mesa-dev] [PATCH mesa] egl: turn a couple asserts static (compile-time)

2016-08-22 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/egl/main/eglconfig.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c index 435d924..6161d26 100644 --- a/src/egl/main/eglconfig.c +++ b/src/egl/main/eglconfig.c

Re: [Mesa-dev] [PATCH v2 13/16] i965: Disable hardware blending if advanced blending is in use.

2016-08-22 Thread Francisco Jerez
Kenneth Graunke writes: > We'll do blending in the shader in this case, so just disable the > hardware blending. > > Signed-off-by: Kenneth Graunke Reviewed-by: Francisco Jerez > --- > src/mesa/drivers/dri/i965/brw_cc.c

Re: [Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

2016-08-22 Thread Eric Engestrom
On Mon, Aug 22, 2016 at 09:44:59AM +0200, Christian König wrote: > Am 21.08.2016 um 23:11 schrieb Eric Engestrom: > > Fixes: c59628d11b134fc01638 ("st/va: enable dual instances encode by sync > > surface") > > Signed-off-by: Eric Engestrom > > Reviewed-by: Christian König

[Mesa-dev] [Bug 97444] mesa git crashes in libxshmfence

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97444 Bug ID: 97444 Summary: mesa git crashes in libxshmfence Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

[Mesa-dev] [Bug 97444] mesa git crashes in libxshmfence

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97444 Fabian Maurer changed: What|Removed |Added CC||dark.shad...@web.de

Re: [Mesa-dev] [PATCH 0/2] st/va: minor clean-ups

2016-08-22 Thread Zhang, Boyuan
Hi Kai, Thanks for cleaning up the codes. The duplicated end_frame and unused variable are due to the new patch submitted last Friday. I have reviewed both patches. Regards, Boyuan -Original Message- From: Kai Wasserbäch [mailto:k...@dev.carbon-project.org] Sent: August-20-16 12:15 PM

Re: [Mesa-dev] [PATCH v2 11/16] compiler: Add a new STATE_VAR_ADVANCED_BLENDING_MODE built-in uniform.

2016-08-22 Thread Francisco Jerez
Kenneth Graunke writes: > This will be used for emulating GL_KHR_advanced_blend_equation features > in shader code. We'll pass in the blending mode that's in use, and use > that in (effectively) a switch statement in the shader. > > v2: Use the new _AdvancedBlendMode

Re: [Mesa-dev] [PATCH 2/2] st/va: Remove unused variable coded_size from vlVaEndPicture()

2016-08-22 Thread Zhang, Boyuan
Patch is Reviewed-by: Boyuan Zhang Regards, Boyuan -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Kai Wasserbäch Sent: August-20-16 12:15 PM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH 2/2] st/va:

Re: [Mesa-dev] [PATCH 1/2] st/va: Remove else case in vlVaEndPicture() made superfluous by c59628d11b

2016-08-22 Thread Zhang, Boyuan
Patch is Reviewed-by: Boyuan Zhang Regards, Boyuan -Original Message- From: Kai Wasserbäch [mailto:k...@dev.carbon-project.org] Sent: August-20-16 12:15 PM To: mesa-dev@lists.freedesktop.org Cc: Zhang, Boyuan Subject: [PATCH 1/2] st/va: Remove else case in

Re: [Mesa-dev] [PATCH v2 05/16] glsl: process blend_support_* qualifiers

2016-08-22 Thread Ilia Mirkin
On Sun, Aug 21, 2016 at 3:43 AM, Kenneth Graunke wrote: > From: Ilia Mirkin > > v2 (Ken): Add a BLEND_NONE enum value (no qualifiers in use). > v3 (Ken): Rename gl_blend_support_qualifier to gl_advanced_blend_mode. > > Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH] mesa: validate the indirect param before the shader in DispatchComputeIndirect

2016-08-22 Thread Marek Olšák
On Mon, Aug 22, 2016 at 5:22 PM, Ilia Mirkin wrote: > Both direct and indirect compute match right now - both check the > program, and then check the "other" parameters. If this change is > made, I believe that _mesa_validate_DispatchCompute should be adjusted > as well.

Re: [Mesa-dev] [PATCH 1/4] winsys/amdgpu: initial SI support

2016-08-22 Thread Alex Deucher
On Mon, Aug 22, 2016 at 4:20 PM, Marek Olšák wrote: > On Mon, Aug 22, 2016 at 5:00 PM, Alex Deucher wrote: >> On Fri, Aug 19, 2016 at 5:11 AM, Marek Olšák wrote: >>> From: Ronie Salgado >>> >>> --- >>>

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Dave Airlie
On 23 August 2016 at 06:14, Marek Olšák wrote: > On Mon, Aug 22, 2016 at 7:05 PM, Brian Paul wrote: >> On 08/22/2016 08:38 AM, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> Sampler view declarations have return types, but that

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Marek Olšák
On Mon, Aug 22, 2016 at 7:05 PM, Brian Paul wrote: > On 08/22/2016 08:38 AM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Sampler view declarations have return types, but that doesn't work with >> variable indexing (e.g. SAMP[-1+i]). >> >> Adding the

Re: [Mesa-dev] [PATCH v2 09/16] mesa: Restyle _mesa_check_blend_func_error().

2016-08-22 Thread Francisco Jerez
Kenneth Graunke writes: > I'm about to add more error conditions to this function, so I wanted to > move the current spec citation above the code that checks it. Indenting > it required reformatting, so I tried to move it to our newer style. > > While there, I also

Re: [Mesa-dev] [PATCH v2 03/16] mesa: add KHR_blend_equation_advanced enable and extension string

2016-08-22 Thread Francisco Jerez
Kenneth Graunke writes: > From: Ilia Mirkin > > Signed-off-by: Ilia Mirkin > Reviewed-by: Kenneth Graunke Reviewed-by: Francisco Jerez > --- > src/mesa/main/extensions_table.h

Re: [Mesa-dev] [PATCH v2 01/16] mesa: Rename _mesa_BlendBarrierMESA to _mesa_BlendBarrier.

2016-08-22 Thread Francisco Jerez
Kenneth Graunke writes: > Note that _mesa_BlendBarrierMESA is not currently hooked up in the > glapi XML, so we can just rename it. We'll hook it up for the > KHR_blend_equation_advanced extension shortly. > > We may as well use the ES 3.2 core name with no suffixes. > >

Re: [Mesa-dev] [PATCH v2 08/16] mesa: Track the current advanced blending mode.

2016-08-22 Thread Francisco Jerez
Kenneth Graunke writes: > This will be useful for a number of things: > - Checking the current advanced blending mode against the shader's > blend_support_* qualifiers. > - Disabling hardware blending when emulating advanced blending. > - Uploading the current advanced

Re: [Mesa-dev] [PATCH] nv50/ir: make sure cfg iterator always hits all blocks

2016-08-22 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 08/19/2016 06:45 AM, Ilia Mirkin wrote: In some very specially-crafted cases, we could attempt to visit a node that has already been visited, and then run out of bb's to visit, while there were still cross blocks on the list. Make sure

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread
On Mon, Aug 22, 2016 at 8:22 PM, Alex Deucher wrote: > On Mon, Aug 22, 2016 at 1:57 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >> On Mon, Aug 22, 2016 at 7:47 PM, Matt Turner wrote: >>> On Mon, Aug 22, 2016 at 10:41 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote:

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread Alex Deucher
On Mon, Aug 22, 2016 at 1:57 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Aug 22, 2016 at 7:47 PM, Matt Turner wrote: >> On Mon, Aug 22, 2016 at 10:41 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >>> On Mon, Aug 22, 2016 at 7:24 PM, Rob Clark wrote:

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread
On Mon, Aug 22, 2016 at 7:47 PM, Matt Turner wrote: > On Mon, Aug 22, 2016 at 10:41 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >> On Mon, Aug 22, 2016 at 7:24 PM, Rob Clark wrote: >>> On Mon, Aug 22, 2016 at 12:58 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote:

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread
On Mon, Aug 22, 2016 at 7:47 PM, Matt Turner wrote: > On Mon, Aug 22, 2016 at 10:41 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >> On Mon, Aug 22, 2016 at 7:24 PM, Rob Clark wrote: >>> On Mon, Aug 22, 2016 at 12:58 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote:

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread Matt Turner
On Mon, Aug 22, 2016 at 10:41 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Aug 22, 2016 at 7:24 PM, Rob Clark wrote: >> On Mon, Aug 22, 2016 at 12:58 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >>> I am marking this patch as rejected at Patchwork. >>> >>> Reason: The patch

Re: [Mesa-dev] [PATCH] isl: round format alignment to nearest power of 2

2016-08-22 Thread Lionel Landwerlin
The one I actually wanted to Cc you on :) On 20/08/16 00:44, Lionel Landwerlin wrote: A few inline asserts in anv assume alignments are power of 2, but with formats like R8G8B8 we have odd alignments. Signed-off-by: Lionel Landwerlin --- src/intel/isl/isl.c

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread
On Mon, Aug 22, 2016 at 7:24 PM, Rob Clark wrote: > On Mon, Aug 22, 2016 at 12:58 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: >> I am marking this patch as rejected at Patchwork. >> >> Reason: The patch moved from the 1st page to the 2nd page of >>

Re: [Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

2016-08-22 Thread Jason Ekstrand
pushed On Mon, Aug 22, 2016 at 10:15 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > I should start to remember to put someone in Cc... > > > On 13/08/16 01:30, Jason Ekstrand wrote: > > Much better. Thanks! > > Reviewed-by: Jason Ekstrand > > On Fri, Aug

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread Rob Clark
On Mon, Aug 22, 2016 at 12:58 PM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > I am marking this patch as rejected at Patchwork. > > Reason: The patch moved from the 1st page to the 2nd page of > https://patchwork.freedesktop.org/project/mesa/series/?ordering=-last_updated > > Although I am letting it go

[Mesa-dev] [Bug 97427] clear-repeat demo doesn't change update region on window resize

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97427 --- Comment #3 from Brian Paul --- (In reply to Ruslan Kabatsayev from comment #2) > Does this still remain true if the behavior depends on actual driver being > used? Again, I suspect nobody cares. If you do, feel free to

Re: [Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

2016-08-22 Thread Lionel Landwerlin
I should start to remember to put someone in Cc... On 13/08/16 01:30, Jason Ekstrand wrote: Much better. Thanks! Reviewed-by: Jason Ekstrand > On Fri, Aug 12, 2016 at 5:00 PM, Lionel Landwerlin

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread
It's an incompatibility between two rule systems. On Mon, Aug 22, 2016 at 7:09 PM, Jason Ekstrand wrote: > > You don't need to send an e-mail to the list every time you change something > in patchwork. Also, there's really nothing special about the first page of > the

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread Jason Ekstrand
You don't need to send an e-mail to the list every time you change something in patchwork. Also, there's really nothing special about the first page of the patch series list. Stuff makes it to later pages before getting merged all time time. On Mon, Aug 22, 2016 at 9:58 AM, ⚛

Re: [Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Brian Paul
On 08/22/2016 08:38 AM, Marek Olšák wrote: From: Marek Olšák Sampler view declarations have return types, but that doesn't work with variable indexing (e.g. SAMP[-1+i]). Adding the return type to the instruction is simpler. All sampler view declaration flags might have

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-22 Thread
I am marking this patch as rejected at Patchwork. Reason: The patch moved from the 1st page to the 2nd page of https://patchwork.freedesktop.org/project/mesa/series/?ordering=-last_updated Although I am letting it go you can still merge it to master if you want to.

Re: [Mesa-dev] [PATCH 2/3] gallium: add a pipe_context parameter to resource_get_handle

2016-08-22 Thread Brian Paul
On 08/22/2016 08:39 AM, Marek Olšák wrote: From: Marek Olšák radeonsi needs to do some operations (DCC decompression) for OpenGL-OpenCL interop and this is the only way to make it coherent with the current context. It can optionally be set to NULL. ---

[Mesa-dev] [PATCH] vl/rbsp: fix another three byte not detected

2016-08-22 Thread Leo Liu
This happens when three byte "00 00 03" is partly loaded to vlc->buffer, and left bytes like "00 03" or "03" in the data, so that it will not be detected by three byte emulation check. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 2 +- 1 file changed, 1

Re: [Mesa-dev] [PATCH 05/31] i965/gen6: Refactor gen6_upload_urb

2016-08-22 Thread Pohjolainen, Topi
On Fri, Aug 19, 2016 at 09:55:42AM -0700, Jason Ekstrand wrote: > This splits it into two functions very similar to gen7_upload_urb. > --- > src/mesa/drivers/dri/i965/brw_context.h | 3 ++ > src/mesa/drivers/dri/i965/gen6_urb.c| 56 > +++-- > 2 files changed, 35

Re: [Mesa-dev] [PATCH 3/3] gallium/noop: use 3-space indentation

2016-08-22 Thread Brian Paul
On 08/22/2016 08:06 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/noop/noop_pipe.c | 314 +- src/gallium/drivers/noop/noop_state.c | 270 ++--- 2 files changed, 292 insertions(+), 292

Re: [Mesa-dev] [PATCH] st/mesa: set Const.MaxTextureMbytes

2016-08-22 Thread Brian Paul
On 08/22/2016 10:26 AM, Brian Paul wrote: On 08/22/2016 08:06 AM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c

Re: [Mesa-dev] [PATCH mesa] st/va: add missing mutex_unlock

2016-08-22 Thread Eric Engestrom
CC'ing Boyuan Zhang (author of the original patch), who got somehow removed from the CC list when sending my patch. On Sun, Aug 21, 2016 at 10:11:48PM +0100, Eric Engestrom wrote: > Fixes: c59628d11b134fc01638 ("st/va: enable dual instances encode by sync > surface") > Signed-off-by: Eric

Re: [Mesa-dev] [PATCH] mesa: validate the indirect param before the shader in DispatchComputeIndirect

2016-08-22 Thread Ilia Mirkin
Both direct and indirect compute match right now - both check the program, and then check the "other" parameters. If this change is made, I believe that _mesa_validate_DispatchCompute should be adjusted as well. On Mon, Aug 22, 2016 at 10:06 AM, Marek Olšák wrote: > From:

Re: [Mesa-dev] [PATCH 1/4] winsys/amdgpu: initial SI support

2016-08-22 Thread Alex Deucher
On Fri, Aug 19, 2016 at 5:11 AM, Marek Olšák wrote: > From: Ronie Salgado > > --- > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 18 ++ > src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 9 +++-- >

[Mesa-dev] [PATCH 2/3] gallium: add a pipe_context parameter to resource_get_handle

2016-08-22 Thread Marek Olšák
From: Marek Olšák radeonsi needs to do some operations (DCC decompression) for OpenGL-OpenCL interop and this is the only way to make it coherent with the current context. It can optionally be set to NULL. --- src/gallium/auxiliary/util/u_transfer.c | 1 +

[Mesa-dev] [PATCH 1/3] gallium: add explicit return type to texture opcodes

2016-08-22 Thread Marek Olšák
From: Marek Olšák Sampler view declarations have return types, but that doesn't work with variable indexing (e.g. SAMP[-1+i]). Adding the return type to the instruction is simpler. All sampler view declaration flags might have to be removed since variable indexing makes

[Mesa-dev] [Bug 97427] clear-repeat demo doesn't change update region on window resize

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97427 --- Comment #2 from Ruslan Kabatsayev --- Does this still remain true if the behavior depends on actual driver being used? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 97426] glScissor gives vertically inverted result

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97426 --- Comment #1 from Brian Paul --- Hmm, works for me: ./clear-scissor Mesa: Initializing x86-64 optimizations GL_RENDERER = Mesa X11 GL_VERSION= 2.1 Mesa 12.1.0-devel (git-0abebec) GL_VENDOR = Brian Paul The

[Mesa-dev] [Bug 97427] clear-repeat demo doesn't change update region on window resize

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97427 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 1/3] dri: add a way to request that modes have matching color/zs depths

2016-08-22 Thread Marek Olšák
On Mon, Aug 22, 2016 at 3:48 PM, Ilia Mirkin wrote: > Did you not get them? Hmmm patchwork didn't get them either... > they're in the archives though: > > https://lists.freedesktop.org/archives/mesa-dev/2016-August/126495.html >

[Mesa-dev] [PATCH] st/mesa: set Const.MaxTextureMbytes

2016-08-22 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 1f53bdf..ebf1f04 100644 --- a/src/mesa/state_tracker/st_extensions.c +++

[Mesa-dev] [PATCH] mesa: validate the indirect param before the shader in DispatchComputeIndirect

2016-08-22 Thread Marek Olšák
From: Marek Olšák This is required by and fixes GL45-CTS.compute_shader.api-indirect. I know it's silly, but it's the path of least resistence. --- src/mesa/main/api_validate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 3/3] gallium/noop: use 3-space indentation

2016-08-22 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/noop/noop_pipe.c | 314 +- src/gallium/drivers/noop/noop_state.c | 270 ++--- 2 files changed, 292 insertions(+), 292 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] dri: add a way to request that modes have matching color/zs depths

2016-08-22 Thread Ilia Mirkin
Did you not get them? Hmmm patchwork didn't get them either... they're in the archives though: https://lists.freedesktop.org/archives/mesa-dev/2016-August/126495.html https://lists.freedesktop.org/archives/mesa-dev/2016-August/126496.html -ilia On Mon, Aug 22, 2016 at 9:43 AM, Marek Olšák

Re: [Mesa-dev] [PATCH 1/3] dri: add a way to request that modes have matching color/zs depths

2016-08-22 Thread Marek Olšák
Reviewed-by: Marek Olšák Where are patches 2 & 3? Marek On Mon, Aug 22, 2016 at 3:06 PM, Ilia Mirkin wrote: > Some GPUs, notably nv3x/nv4x can't render to mismatched color/zs > framebuffer depths. Fallbacks can be done by the driver, with shadow >

[Mesa-dev] [PATCH 1/3] dri: add a way to request that modes have matching color/zs depths

2016-08-22 Thread Ilia Mirkin
Some GPUs, notably nv3x/nv4x can't render to mismatched color/zs framebuffer depths. Fallbacks can be done by the driver, with shadow surfaces, but no reason to encourage applications to select non-matching glx visuals. Signed-off-by: Ilia Mirkin ---

[Mesa-dev] [PATCH 0/4] i965/vec4: Changes to the offset() helper

2016-08-22 Thread Iago Toral Quiroga
During the review of the align16/fp64 backend Curro suggested that we changed the implementation of the offset() helper to match the one in the FS backend, which, instead of taking an offset in register units takes a width and also considers the size of the register to compute a byte offset into

[Mesa-dev] [PATCH 3/4] i965/vec4/cse: adapt to changes in offset() helper

2016-08-22 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_vec4_cse.cpp | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp b/src/mesa/drivers/dri/i965/brw_vec4_cse.cpp index 0c1f0c3..eaf95c8 100644 ---

[Mesa-dev] [PATCH 4/4] i965/vec4: adapt to changes in the offset() helper

2016-08-22 Thread Iago Toral Quiroga
This commit should be squashed with the previous one. --- src/mesa/drivers/dri/i965/brw_vec4_dead_code_eliminate.cpp | 12 +++- src/mesa/drivers/dri/i965/brw_vec4_live_variables.cpp | 8 src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 2 +-

[Mesa-dev] [PATCH 2/4] i965/vec4: make the offset() operate in terms of width and type

2016-08-22 Thread Iago Toral Quiroga
This will make it more consistent with the FS implementation of the same helper and will provide more flexibility that will come in handy, for example, when we add a SIMD lowering pass in the vec4 backend. --- src/mesa/drivers/dri/i965/brw_ir_vec4.h | 47 ++--- 1 file

Re: [Mesa-dev] [PATCH] program_resource: subroutine active uniforms should return NumSubroutineUniforms

2016-08-22 Thread Tapani Pälli
On 08/19/2016 09:31 PM, Alejandro Piñeiro wrote: Before this commit, GetProgramInterfaceiv for pname ACTIVE_RESOURCES and all the _SUBROUTINE_UNIFORM programInterface were returning the count of resources on the shader program using that interface, instead of the number of active uniform

[Mesa-dev] [Bug 74988] Buffer overrun (segfault) decompressing ETC2 texture in GLBenchmark 3.0 Manhattan

2016-08-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74988 Tapani Pälli changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

2016-08-22 Thread Nicolas Boichat
Hi Emil, On Tue, Aug 16, 2016 at 1:17 AM, Emil Velikov wrote: > Hi Nicolas, > > On 4 August 2016 at 02:51, Nicolas Boichat wrote: >> On Thu, Aug 4, 2016 at 9:38 AM, Michel Dänzer wrote: >>> On 04.08.2016 09:53, Nicolas