Re: [Mesa-dev] [Mesa-stable] [PATCH] gbm: fix potential NULL deref of mapImage/unmapImage.

Ping for review. -Original Message- From: mesa-stable [mailto:mesa-stable-boun...@lists.freedesktop.org] On Behalf Of Chuanbo Weng Sent: Tuesday, September 6, 2016 5:29 PM To: mesa-dev@lists.freedesktop.org; emil.l.veli...@gmail.com Cc: mesa-sta...@lists.freedesktop.org; Weng, Chuanbo

[Mesa-dev] [Bug 97608] Account request

https://bugs.freedesktop.org/show_bug.cgi?id=97608 Brian Paul changed: What|Removed |Added Version|git |unspecified

Re: [Mesa-dev] [PATCH 1/2] i965: check for GL_TEXTURE_EXTERNAL_OES at miptree_create_for_teximage

I forgot to CC Jason, that made the review of the original commit. Sorry for the noise. On 11/09/16 00:07, Alejandro Piñeiro wrote: > Forgotten on commit "i965: Fix calculation of the image height at start > level". > > Thanks to Ilia Mirkin for point it. > > Fixes the following regressions

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

On Mon, Sep 12, 2016 at 10:10 AM, Emil Velikov wrote: > Keeping diff/patches in git always felt like a hack, imho. Plus > most/all(?) distros rely on the Mesa headers, so I'm not sure how that > is going to work. The alternatives are considerably more painful for just a

[Mesa-dev] [Bug 35607] glXWaitVideoSyncSGI() function freezes at resolution change

https://bugs.freedesktop.org/show_bug.cgi?id=35607 Eero Tamminen changed: What|Removed |Added Status|NEW |NEEDINFO

Re: [Mesa-dev] [PATCH 1/5] mesa: bump required GCC version to 4.8.0

I'm still using the MinGW gcc 4.6 compiler. I'd rather not go through the upgrade hassle if I don't have to. -Brian On 09/06/2016 10:28 PM, Timothy Arceri wrote: The last time this was bumped we settled on 4.2.0 because OpenBSD wasn't shipping anything greater than 4.2.1 (as that was the

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

On 12 September 2016 at 14:51, Ilia Mirkin wrote: > On Mon, Sep 12, 2016 at 8:37 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> A earlier sync with the Khronos headers added _extension_ prototype >> guards to

Re: [Mesa-dev] EGL_EXT_*_drm - primary vs render node (Was Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3))

Hi James, On 8 September 2016 at 17:27, Emil Velikov wrote: > In order to clear any ambiguity in EGL_EXT_device_drm we need to > "s/DRM driver./DRM driver which support KMS./". With that small change > things should be fine. > > Further to the above (trivial)

Re: [Mesa-dev] [PATCH] glsl: remove interpolateAt* instructions for demoted inputs

Since demoted inputs become global variables, wouldn't it be more efficient to simply turn it into a straight assignment? Then the backend wouldn't have to initialize it to a constant (since it would be undefined). On Fri, Sep 9, 2016 at 10:06 AM, Marek Olšák wrote: > From:

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

On Mon, Sep 12, 2016 at 9:01 AM, Marek Olšák wrote: > On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: >> Support multi-planar YUV for external EGLImage's (currently just in the >> dma-buf import path) by lowering to multiple texture fetch's for each >>

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

On Mon, Sep 12, 2016 at 8:37 AM, Emil Velikov wrote: > From: Emil Velikov > > A earlier sync with the Khronos headers added _extension_ prototype > guards to all the GLES2/3/31/32 core entry points. Effectively breaking > all the applications

Re: [Mesa-dev] [PATCH v3] vl/dri3: handle the case of different GPU

On 09/12/2016 04:31 AM, Michel Dänzer wrote: On 10/09/16 12:49 AM, Nayan Deshmukh wrote: In case of prime when rendering is done on GPU other then the server GPU, use a seprate linear buffer for each back buffer which will be displayed using present extension. v2: Use a seprate linear buffer

Re: [Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

Hi, On 12 September 2016 at 13:37, Emil Velikov wrote: > A earlier sync with the Khronos headers added _extension_ prototype > guards to all the GLES2/3/31/32 core entry points. Effectively breaking > all the applications that aim to be portable and do not set the

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

Am 12.09.2016 um 15:01 schrieb Marek Olšák: On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: Support multi-planar YUV for external EGLImage's (currently just in the dma-buf import path) by lowering to multiple texture fetch's for each plane and CSC in shader.

Re: [Mesa-dev] [PATCH 7/7] mesa/st: support for YUV in VS/VS/GS/TCS/TEC..

On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: > maybe we don't keep these bits? Yeah, I don't like this. It's just additional overhead for nothing. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 6/7] mesa/st: pass prog to st_get_basic_variant()

Reviewed-by: Marek Olšák Marek On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: > Needed in a following patch. > > Signed-off-by: Rob Clark > --- > src/mesa/state_tracker/st_atom_shader.c | 6 +++--- >

Re: [Mesa-dev] [PATCH 4/7] mesa/st: a bit of basic_variant refactoring

Reviewed-by: Marek Olšák Marek On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: > Add a helper to initialize the key, and pass the key into the helper > that iterates the variants, similar to how it works for vp/fp variants. > > The 'prog' arg to the

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

On Thu, Sep 8, 2016 at 10:30 PM, Rob Clark wrote: > Support multi-planar YUV for external EGLImage's (currently just in the > dma-buf import path) by lowering to multiple texture fetch's for each > plane and CSC in shader. > > Signed-off-by: Rob Clark >

[Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

From: Emil Velikov A earlier sync with the Khronos headers added _extension_ prototype guards to all the GLES2/3/31/32 core entry points. Effectively breaking all the applications that aim to be portable and do not set the define. The issue has been reported to

Re: [Mesa-dev] [PATCH 1/2] aubinator: rework print_help()

On Mon, Sep 12, 2016 at 12:59:11PM +0100, Emil Velikov wrote: > From: Emil Velikov > > Rather than using platform specific methods to retrieve the program > name pass it explicitly. The function is called directly from main(). > > Similarly - basename comes in two

Re: [Mesa-dev] [PATCH] tgsi/scan: don't set interp flags for inputs only used by INTERP instructions

Reviewed-by: Nicolai Hähnle On 09.09.2016 16:06, Marek Olšák wrote: From: Marek Olšák radeonsi depends on the interp flags a little bit too much. This fixes 9 randomly failing tests:

Re: [Mesa-dev] [PATCH] mesa: fix glGetFramebufferAttachmentParameteriv w/ on-demand FRONT_BACK alloc

Reviewed-by: Nicolai Hähnle On 09.09.2016 16:06, Marek Olšák wrote: From: Marek Olšák This fixes 66 CTS tests on st/mesa. Cc: 12.0 --- src/mesa/main/fbobject.c | 16 ++-- 1 file changed, 14

Re: [Mesa-dev] [PATCH] glsl: remove interpolateAt* instructions for demoted inputs

Reviewed-by: Nicolai Hähnle On 09.09.2016 16:06, Marek Olšák wrote: From: Marek Olšák This fixes 8 fs-interpolateat* piglit crashes on radeonsi, because it can't handle non-input operands in interpolateAt*. ---

[Mesa-dev] [PATCH 1/2] aubinator: rework print_help()

From: Emil Velikov Rather than using platform specific methods to retrieve the program name pass it explicitly. The function is called directly from main(). Similarly - basename comes in two versions POSIX (can modify string, always pass a copy) and GNU (never

[Mesa-dev] [PATCH 2/2] aubinator: print_help swap "FILE *file" with "bool critical"

From: Emil Velikov Derive file locally and exit() accordingly based on the bool. Allows us to save a couple lines of code. Signed-off-by: Emil Velikov --- s/print_help/print_help_and_exit/ and/or too bike sheddy ? ---

Re: [Mesa-dev] [PATCH v2] tgsi: document semantics for compute shaders

Thanks for doing this! Reviewed-by: Nicolai Hähnle On 10.09.2016 17:10, Samuel Pitoiset wrote: Cc: Nicolai Hähnle Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/tgsi.rst | 28

Re: [Mesa-dev] [PATCH 3/3] aubinator: only use program_invocation_short_name with glibc/cygwin

On 12 September 2016 at 07:44, Jonathan Gray wrote: > On Mon, Sep 12, 2016 at 09:28:58AM +1000, Timothy Arceri wrote: >> On Thu, 2016-09-08 at 18:39 +0100, Emil Velikov wrote: >> > On 1 September 2016 at 18:12, Jonathan Gray wrote: >> > > >> > >

Re: [Mesa-dev] [PATCH 2/7] EGL: Implement eglLabelObjectKHR

On 9 September 2016 at 18:51, Adam Jackson wrote: > On Fri, 2016-09-09 at 11:27 +0100, Emil Velikov wrote: >> > On 8 September 2016 at 18:46, Adam Jackson wrote: >> > From: Kyle Brenneman >> >> Added a label to the _EGLThreadInfo,

Re: [Mesa-dev] [PATCH v2 2/3] egl: return corresponding offset of EGLImage instead of 0.

On 9 September 2016 at 22:03, Axel Davy wrote: > I'm not sure calling queryImage with an unsupported attribute is legal, thus > I think a small check doesn't hurt. > > It'd give > > if (offsets) { >offsets[0] = 0; >if (dri2_dpy->image->base.version >= 13) { >

Re: [Mesa-dev] [PATCH 00/57] i965/ir: Switch representation of register offsets and sizes to byte units.

On Fri, 2016-09-09 at 11:37 +0200, Iago Toral wrote: > On Thu, 2016-09-08 at 11:36 +0200, Iago Toral wrote: > > > > On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > > > > > > > > > This series reworks the representation of register region offsets > > > in > > > the i965 IR to be

Re: [Mesa-dev] [PATCH 1/7] EGL: Update eglext.h

An easy-ish way of upgrading a single source file from an upstream and keeping the changes that were done on top, is to branch out from the last update-commit, and update there. Then when merged, git will understand that the changes on top should still be applied when merging. Unfortunately, it

Re: [Mesa-dev] [PATCH v3] vl/dri3: handle the case of different GPU

On 10/09/16 12:49 AM, Nayan Deshmukh wrote: > In case of prime when rendering is done on GPU other then the > server GPU, use a seprate linear buffer for each back buffer > which will be displayed using present extension. > > v2: Use a seprate linear buffer for each back buffer (Michel) > v3:

Re: [Mesa-dev] [PATCH 3/4] i965/blorp: Add a copy_miptrees helper

Hi Jason, On 09.09.2016 19:05, Jason Ekstrand wrote: --- src/mesa/drivers/dri/i965/brw_blorp.c | 71 +++ src/mesa/drivers/dri/i965/brw_blorp.h | 10 + 2 files changed, 81 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c

Re: [Mesa-dev] [PATCH] Disable the code that allocates W|X memory on OpenBSD

On Thu, 8 Sep 2016, Jonathan Gray wrote: > On Thu, Sep 08, 2016 at 06:57:44PM +0100, Emil Velikov wrote: ... > > For a long while the intent has been to use --enable-glx-tls by > > default and kill off the other codepaths. But with the write xor > > execute policy, it's going to be (close to)

Re: [Mesa-dev] [PATCH] egl: fix gcc warning braces around scalar initializer

Reviewed-by: Alejandro Piñeiro On 12/09/16 01:24, Timothy Arceri wrote: > --- > src/egl/main/eglcurrent.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/egl/main/eglcurrent.c b/src/egl/main/eglcurrent.c > index 345f4cc..2a225bc 100644 > ---

Re: [Mesa-dev] [PATCH 3/3] aubinator: only use program_invocation_short_name with glibc/cygwin

On Mon, Sep 12, 2016 at 09:28:58AM +1000, Timothy Arceri wrote: > On Thu, 2016-09-08 at 18:39 +0100, Emil Velikov wrote: > > On 1 September 2016 at 18:12, Jonathan Gray wrote: > > > > > > program_invocation_short_name is a gnu extension.Limit use of it > > > to glibc and

Re: [Mesa-dev] [PATCH] st/mesa: fix is_scissor_enabled when X/Y are negative

On 12/09/16 02:40 AM, Ilia Mirkin wrote: > Similar to commit 49c24d8a24 ("i965: fix noop_scissor range issue on > width/height") - take the X/Y into account to determine whether the > scissor covers the whole area or not. > > Fixes the recently-added gl-1.0-scissor-depth-clear-negative-xy piglit

Re: [Mesa-dev] [PATCH 16/57] i965/fs: Take into account trailing padding in regs_written() and regs_read().

On Fri, 2016-09-09 at 13:03 -0700, Francisco Jerez wrote: > Iago Toral writes: > > > > > On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > > > > > > This fixes regs_written() and regs_read() to return a more > > > accurate > > > value when the padding left between

Re: [Mesa-dev] [PATCH 15/57] i965/fs: Handle fixed HW GRF subnr in reg_offset().

On Fri, 2016-09-09 at 13:04 -0700, Francisco Jerez wrote: > Iago Toral writes: > > > > > On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > > > > > > This will be useful later on when we start using reg_offset() on > > > fixed > > > hardware registers. > > > --- > >

Re: [Mesa-dev] [PATCH 28/57] i965/fs: Take into account copy register offset during compute-to-mrf.

On Fri, 2016-09-09 at 13:30 -0700, Francisco Jerez wrote: > Iago Toral writes: > > > > > On Wed, 2016-09-07 at 18:48 -0700, Francisco Jerez wrote: > > > > > > This was dropping 'inst->dst.offset' on the floor.  Nothing in > > > the > > > code above seems to guarantee that

<    1   2