Re: [Mesa-dev] [PATCH 1/2] compiler: include shader_enums.h in shader_info.h

Both are rb me On Nov 15, 2016 7:03 PM, "Timothy Arceri" wrote: > We make use of some enums here. > --- > src/compiler/shader_info.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h > index

[Mesa-dev] [PATCH] i965: Use 3DSTATE_CLIP's User Clip Distance Enable bitmask on Gen8+.

Gen6-7.5 specify the user clip distance enable bitmask in 3DSTATE_CLIP. Gen8+ normally uses the new internal signalling mechanism to select the one specified in the last enabled shader stage (3DSTATE_VS, DS, or GS). This is a pretty good fit for Vulkan, or even newer GL, where the bitmask comes

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

On 15/11/16 11:24 PM, Varad Gautam wrote: > From: Varad Gautam > > drivers should implement pipe_screen->get_modifiers_for_format and > advertise it with PIPE_CAP_QUERY_DMABUF_MODIFIERS to support format > modifier queries. Is there any point in having the

Re: [Mesa-dev] [PATCH mesa] egl: fix helper function name

On Tue, Nov 15, 2016 at 3:43 PM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/egl/main/eglapi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c > index

Re: [Mesa-dev] [PATCH mesa] egl/x11: misc style fixes

Reviewed-by: Tapani Pälli On 11/16/2016 01:48 AM, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_x11.c | 2 +- src/egl/drivers/dri2/platform_x11_dri3.c | 2 +- 2 files changed, 2 insertions(+), 2

Re: [Mesa-dev] [PATCH mesa] egl/wayland: avoid double-return

I think it's cleaner the way it is, this double return would never happen, it's just another implementation of the function. On 11/16/2016 01:46 AM, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 4 +++- 1 file changed, 3

Re: [Mesa-dev] [PATCH mesa] egl: fix helper function name

why not .. Reviewed-by: Tapani Pälli (note that there are other static functions that don't have '_' in them in this file, also there is _eglConvertIntsToAttribs which looks like it could be static (only one caller in same file) but it is not) On 11/16/2016 01:43

Re: [Mesa-dev] [PATCH mesa] egl: fix function name in debug string

Reviewed-by: Tapani Pälli On 11/16/2016 01:41 AM, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/egl/main/eglconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/eglconfig.c

[Mesa-dev] [PATCH 1/2] compiler: include shader_enums.h in shader_info.h

We make use of some enums here. --- src/compiler/shader_info.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h index e36fe09..1605c82 100644 --- a/src/compiler/shader_info.h +++ b/src/compiler/shader_info.h @@ -25,6 +25,8 @@ #ifndef

[Mesa-dev] [PATCH 2/2] compiler: remove now unused copy_shader_info() declaration

Left over from 4ac66861 --- src/compiler/shader_info.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/src/compiler/shader_info.h b/src/compiler/shader_info.h index 1605c82..21128b8 100644 --- a/src/compiler/shader_info.h +++ b/src/compiler/shader_info.h @@ -146,13 +146,6 @@ typedef

[Mesa-dev] [PATCH 2/2] radeonsi: Use buffer_load intrinsics instead of llvm.SI.vs.load.input

--- src/gallium/drivers/radeonsi/si_shader.c | 69 +++- 1 file changed, 50 insertions(+), 19 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 306e12f..ee4fe2f 100644 ---

[Mesa-dev] [PATCH 1/2] radeonsi: Use amdgcn intrinsics for fs interpolation

--- src/gallium/drivers/radeonsi/si_shader.c | 197 ++- 1 file changed, 143 insertions(+), 54 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 0410a32..306e12f 100644 ---

[Mesa-dev] [PATCH] swr: [rasterizer] fix clear with multiple color attachments

Fixes fbo-mrt-alphatest --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 10 ++--- src/gallium/drivers/swr/rasterizer/core/api.h | 4 +- .../drivers/swr/rasterizer/core/backend.cpp| 46 +++--- src/gallium/drivers/swr/rasterizer/core/context.h | 11 +-

[Mesa-dev] [PATCH v3 09/10] gallium: Add support for SWR compilation

Include swr library and include -DHAVE_SWR in the compile line. --- src/gallium/targets/libgl-gdi/SConscript | 4 src/gallium/targets/libgl-xlib/SConscript | 4 src/gallium/targets/osmesa/SConscript | 4 3 files changed, 12 insertions(+) diff --git

[Mesa-dev] [PATCH v3 06/10] swr: Windows-related changes

- Handle dynamic library loading for windows - Implement swap for gdi - fix prototypes - update include paths on configure-based build for swr_loader.cpp --- src/gallium/drivers/swr/Makefile.am| 7 +++ src/gallium/drivers/swr/swr_loader.cpp | 28 +---

[Mesa-dev] [PATCH v3 07/10] scons: Add swr compile option

To buils The SWR driver (currently optional, not compiled by default) --- common.py | 1 + 1 file changed, 1 insertion(+) diff --git a/common.py b/common.py index fb0884e..704ad2e 100644 --- a/common.py +++ b/common.py @@ -110,5 +110,6 @@ def AddOptions(opts):

[Mesa-dev] [PATCH v3 05/10] swr: Handle windows.h and NOMINMAX

Reorder header files so that we have a chance to defined NOMINMAX before mesa include files include windows.h --- src/gallium/drivers/swr/swr_context.cpp | 16 src/gallium/drivers/swr/swr_context.h | 2 ++ src/gallium/drivers/swr/swr_screen.cpp | 25 +++--

[Mesa-dev] [PATCH v3 08/10] gallium: swr: Added swr build for windows

--- src/gallium/SConscript | 1 + src/gallium/drivers/swr/SConscript | 213 + 2 files changed, 214 insertions(+) create mode 100755 src/gallium/drivers/swr/SConscript diff --git a/src/gallium/SConscript b/src/gallium/SConscript index

[Mesa-dev] [PATCH v3 04/10] gallium: Added SWR support for gdi

Added hooks for screen creation and swap. Still keep llvmpipe the default software renderer. --- src/gallium/targets/libgl-gdi/libgl_gdi.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/src/gallium/targets/libgl-gdi/libgl_gdi.c

[Mesa-dev] [PATCH v3 10/10] swr: Modify gen_knobs.{cpp|h} creation script

Modify gen_knobs.py so that each invocation creates a single generated file. This is more similar to how the other generators behave. --- src/gallium/drivers/swr/Makefile.am| 14 +- src/gallium/drivers/swr/SConscript | 17 +---

[Mesa-dev] [PATCH v3 01/10] mesa: removed redundant #else

--- src/util/macros.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/macros.h b/src/util/macros.h index 0563fa5..3730abe 100644 --- a/src/util/macros.h +++ b/src/util/macros.h @@ -178,7 +178,6 @@ do { \ # elif defined(_MSC_VER) && !defined(__INTEL_COMPILER)

[Mesa-dev] [PATCH v3 03/10] scons: add llvm 3.9 support.

--- scons/llvm.py | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/scons/llvm.py b/scons/llvm.py index 1fc8a3f..977e47a 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -106,7 +106,24 @@ def generate(env): ]) env.Prepend(LIBPATH =

[Mesa-dev] [PATCH v3 00/10] Support windows builds for OpenSWR

Changes to support Windows scons builds for OpenSWR driver, since scons is the only supported build system for windows. Scons swr build will not work at this point. Also, windows scons swr build requires llvm version 3.9 (and above). Build on windows using the following command line: scons

[Mesa-dev] [PATCH v3 02/10] scons: ignore .hpp files in parse_source_list()

Drivers that contain C++ .hpp files need to ignore them too, along with .h files, when building source file lists. --- scons/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/custom.py b/scons/custom.py index bdb4039..544b15d 100644 --- a/scons/custom.py +++

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

https://bugs.freedesktop.org/show_bug.cgi?id=93551 daradib changed: What|Removed |Added CC||dara...@quietapple.org

[Mesa-dev] EGL/android: pbuffer implementation.

mesa android path didn't support pbuffer, so add pbuffer support to fix most deqp and cts pbuffer test cases fail; add single buffer config to support pbuffer, and create image for pbuffer when pbuffer type is front surface. The EGL 1.5 spec states that pbuffers have a back buffer but no front

[Mesa-dev] [PATCH 6/7] i965: Use arrays in Gen7+ URB code.

So much of this code was cut and pasted per stage. We can accomplish much of it by looping over shader stages. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen7_urb.c | 336 ++- 1 file changed, 134 insertions(+), 202

[Mesa-dev] [PATCH 2/7] intel: Convert devinfo->urb.min_*_entries into an array.

Signed-off-by: Kenneth Graunke --- src/intel/common/gen_device_info.c | 86 src/intel/common/gen_device_info.h | 6 ++- src/intel/vulkan/genX_pipeline.c | 6 +-- src/mesa/drivers/dri/i965/gen6_urb.c | 3 +-

[Mesa-dev] [PATCH 4/7] i965: Switch to roundf in HS/DS URB code.

Matt intentionally switched the VS calculation to be float-based in commit c1da15709a0c0c2775bd9e534f67c60f7dc95ce8. Tessellation support was written before this and rebased forward, and missed the change. Now it's consistent. Signed-off-by: Kenneth Graunke ---

[Mesa-dev] [PATCH 7/7] intel: Share URB configuration code between GL and Vulkan.

This code is far too complicated to cut and paste. Signed-off-by: Kenneth Graunke --- src/intel/Makefile.sources | 1 + src/intel/common/gen_l3_config.h | 6 ++ src/intel/common/gen_urb_config.c| 201 +++

[Mesa-dev] [PATCH 5/7] i965: Drop brw->urb.{nr_*_entries, *_start} assignments from gen7_urb.c.

The context fields are for Gen4-5; setting them has always been useless. There's no point in spending the cost in the hottest path in the driver. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen7_urb.c | 25 - 1 file changed, 8

[Mesa-dev] [PATCH 3/7] i965: Make URB code use prog_data for GS/tessellation enable checks.

If geometry/tessellation shaders are disabled, prog_data will be NULL (see brw_state_upload.c). This consolidates dirty bits a little. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen7_urb.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)

[Mesa-dev] [PATCH 1/7] intel: Convert devinfo->urb.max_*_entries into an array.

Signed-off-by: Kenneth Graunke --- src/intel/common/gen_device_info.c | 144 +-- src/intel/common/gen_device_info.h | 10 ++- src/intel/vulkan/genX_pipeline.c | 12 ++- src/mesa/drivers/dri/i965/gen6_urb.c | 8 +-

Re: [Mesa-dev] Fwd: New Defects reported by Coverity Scan for Mesa

On Tue, Nov 15, 2016 at 5:35 PM, Jordan Justen wrote: > On 2016-11-15 16:21:27, Matt Turner wrote: >> Jordan, >> >> In >> >> commit 0041169cacb300a882b4dc38cd341f98bf2a7c38 >> Author: Jordan Justen >> Date: Fri Oct 21 12:56:49 2016 +0100 >>

[Mesa-dev] [PATCH] i965: "Fix" aux offsets

From: Ben Widawsky When 1 BO is used for aux data, it needs to point to the correct offset, which will not be the BOs offset but instead an offset from the BOs offset. Since today there are always multiple BOs for aux, this doesn't actually change anything. Cc: Jason Ekstrand

Re: [Mesa-dev] Fwd: New Defects reported by Coverity Scan for Mesa

On 2016-11-15 16:21:27, Matt Turner wrote: > Jordan, > > In > > commit 0041169cacb300a882b4dc38cd341f98bf2a7c38 > Author: Jordan Justen > Date: Fri Oct 21 12:56:49 2016 +0100 > This date is not correct. In my branch it was: Date: Mon Jun 30 00:50:56 2014 + I

Re: [Mesa-dev] [PATCH] blorp: Use designated initializers in surf_convert_to_single_slice

On Tue, Nov 15, 2016 at 2:38 PM, Jordan Justen wrote: > On 2016-11-15 11:36:33, Jason Ekstrand wrote: > >Of you want to make it simpler, we have a macro wrapper called > >isl_surf_init that will turn those fields into named parameters. > Either > >way,

[Mesa-dev] [PATCH] radv: fix image view creation for depth and stencil only

From: Dave Airlie This fixes the image view for sampling just the depth. It removes some pointless swizzle code, and adds a missing case for the x8_d24 format. Fixes: dEQP-VK.renderpass.formats.d32_sfloat_s8_uint.input.* dEQP-VK.renderpass.formats.d24_unorm_s8_uint.input.*

[Mesa-dev] Fwd: New Defects reported by Coverity Scan for Mesa

Jordan, In commit 0041169cacb300a882b4dc38cd341f98bf2a7c38 Author: Jordan Justen Date: Fri Oct 21 12:56:49 2016 +0100 i965: Wrap MCS miptree in intel_miptree_aux_buffer you changed intel_miptree_alloc_mcs() to return mt->mcs_buf != NULL. mt->mcs_buf is

Re: [Mesa-dev] [PATCH] radv: don't crash on null swapchain destroy.

r-b On 15 Nov 2016 9:12 PM, "Dave Airlie" wrote: > From: Dave Airlie > > Just return if the passed in swapchain is NULL. > > Fixes: dEQP-VK.wsi.xlib.swapchain.destroy.null_handle > > Signed-off-by: Dave Airlie > --- >

[Mesa-dev] [PATCH mesa] egl/x11: misc style fixes

Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_x11.c | 2 +- src/egl/drivers/dri2/platform_x11_dri3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c index

[Mesa-dev] [Bug 77662] Fail to render to different faces of depth-stencil cube map

https://bugs.freedesktop.org/show_bug.cgi?id=77662 Nanley Chery changed: What|Removed |Added Status|NEW |ASSIGNED

[Mesa-dev] [PATCH mesa] egl/wayland: avoid double-return

Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 4fd4289..64eb4ef 100644 ---

[Mesa-dev] [PATCH mesa] egl: fix helper function name

Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 53340bf..934d585 100644 --- a/src/egl/main/eglapi.c +++ b/src/egl/main/eglapi.c @@ -1195,7

[Mesa-dev] [PATCH mesa] egl: fix function name in debug string

Signed-off-by: Eric Engestrom --- src/egl/main/eglconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c index 6161d26..876c8f0 100644 --- a/src/egl/main/eglconfig.c +++ b/src/egl/main/eglconfig.c @@

[Mesa-dev] [PATCH] mesa: if MESA_DEBUG=context, create a debug context

A number of drivers report useful debug/perf information accessible through GL_ARB_debug_output and with debug contexts (i.e. setting the GLX_CONTEXT_DEBUG_BIT_ARB flag). But few applications actually use the GL_ARB_debug_output extension. This change lets one set the MESA_DEBUG env var to

Re: [Mesa-dev] [PATCH] blorp: Use designated initializers in surf_convert_to_single_slice

On 2016-11-15 11:36:33, Jason Ekstrand wrote: >Of you want to make it simpler, we have a macro wrapper called >isl_surf_init that will turn those fields into named parameters. Either >way, thanks for fixing this up. Rb > >On Nov 15, 2016 11:23 AM, "Jordan Justen"

Re: [Mesa-dev] [PATCH] mesa: Drop PATH_MAX usage.

On Tue, Nov 15, 2016 at 11:05 PM, Kenneth Graunke wrote: > On Tuesday, November 15, 2016 10:28:11 PM PST Roland Mainz wrote: >> On Tue, Nov 15, 2016 at 9:56 PM, Emil Velikov >> wrote: >> > On 15 November 2016 at 20:04, Kenneth Graunke

Re: [Mesa-dev] [PATCH] mesa: Drop PATH_MAX usage.

On Tuesday, November 15, 2016 10:28:11 PM PST Roland Mainz wrote: > On Tue, Nov 15, 2016 at 9:56 PM, Emil Velikov > wrote: > > On 15 November 2016 at 20:04, Kenneth Graunke wrote: > >> GNU/Hurd does not define PATH_MAX since it doesn't have such

Re: [Mesa-dev] Rework use of gl program structures

Most of these patches are clean-ups on there own so I'd be grateful for even partial series reviews. Thanks, Tim On Fri, 2016-11-11 at 11:45 +1100, Timothy Arceri wrote: > I started out with a goal of freeing _LinkedShaders after linking as > this > would have allowed a bunch of code

Re: [Mesa-dev] [PATCH] wsi: fix VK_INCOMPLETE for vkGetSwapchainImagesKHR

Rb. Please cc stable On Nov 15, 2016 1:20 PM, "Dave Airlie" wrote: > From: Dave Airlie > > This fixes the x11 and wayland backends to not assert: > dEQP-VK.wsi.xcb.swapchain.get_images.incomplete > > Signed-off-by: Dave Airlie > ---

Re: [Mesa-dev] [PATCH] mesa: Drop PATH_MAX usage.

On Tue, Nov 15, 2016 at 9:56 PM, Emil Velikov wrote: > On 15 November 2016 at 20:04, Kenneth Graunke wrote: >> GNU/Hurd does not define PATH_MAX since it doesn't have such arbitrary >> limitation, so this failed to compile. Apparently glibc does

[Mesa-dev] [PATCH] wsi: fix VK_INCOMPLETE for vkGetSwapchainImagesKHR

From: Dave Airlie This fixes the x11 and wayland backends to not assert: dEQP-VK.wsi.xcb.swapchain.get_images.incomplete Signed-off-by: Dave Airlie --- src/vulkan/wsi/wsi_common_wayland.c | 16 +++- src/vulkan/wsi/wsi_common_x11.c | 16

Re: [Mesa-dev] [PATCH] mesa: Drop PATH_MAX usage.

On 15 November 2016 at 20:04, Kenneth Graunke wrote: > GNU/Hurd does not define PATH_MAX since it doesn't have such arbitrary > limitation, so this failed to compile. Apparently glibc does not > enforce PATH_MAX restrictions anyway, so it's kind of a hoax: > >

[Mesa-dev] [Bug 98699] "float[a+++4 ? 1:1] f; " crashes glsl_compiler

https://bugs.freedesktop.org/show_bug.cgi?id=98699 --- Comment #6 from Karol Herbst --- no, it doesn't. Just tested on current master. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 George Billios changed: What|Removed |Added CC||gbill...@gmail.com

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #46 from George Billios --- This is also valid for Trine 3. Big delay to start ~5mins setting MESA_SHADER_CAPTURE_PATH results in about 16k files!!! specs i7 860 Fury R9 4.7-staging kernel mesa-git Mesa

Re: [Mesa-dev] [PATCH] android: amd/common: add support for libmesa_amd_common

On 15 November 2016 at 09:15, Nicolai Hähnle wrote: > On 12.11.2016 22:26, Mauro Rossi wrote: >>> >>> We'd really want to do: >>> >>> git rm src/amd/common/Makefile.sources >>> git mv src/amd/common/Makefile.am src/amd/Makefile.common.am >>> sed -i s|common/||g

[Mesa-dev] [PATCH] radv: don't crash on null swapchain destroy.

From: Dave Airlie Just return if the passed in swapchain is NULL. Fixes: dEQP-VK.wsi.xlib.swapchain.destroy.null_handle Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_wsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Mesa-dev] Stable release process

On Nov 15, 2016 11:07 AM, "Ian Romanick" wrote: > > On 11/14/2016 02:31 PM, Matt Turner wrote: > > A long time ago, patch authors were tasked with cherry-picking their > > patches to stable branches. Today we Cc > > mesa-sta...@lists.freedesktop.org and Emil rebases those

[Mesa-dev] [PATCH] mesa: Drop PATH_MAX usage.

GNU/Hurd does not define PATH_MAX since it doesn't have such arbitrary limitation, so this failed to compile. Apparently glibc does not enforce PATH_MAX restrictions anyway, so it's kind of a hoax: https://www.gnu.org/software/libc/manual/html_node/Limits-for-Files.html MSVC uses a different

[Mesa-dev] [Bug 98699] "float[a+++4 ? 1:1] f; " crashes glsl_compiler

https://bugs.freedesktop.org/show_bug.cgi?id=98699 --- Comment #5 from Ian Romanick --- (In reply to Kenneth Graunke from comment #4) > My patches for Karol's other crashes have landed, but I haven't looked at > this one. This may be fixed by the fix for bug #98694. The

[Mesa-dev] [Bug 98740] bitcode.cpp:102:8: error: ‘Error’ is not a member of ‘llvm’

https://bugs.freedesktop.org/show_bug.cgi?id=98740 Vinson Lee changed: What|Removed |Added Keywords||bisected

[Mesa-dev] [PATCH v2 2/14] swr: [rasterizer memory] minify original sizes for block formats

There's no guarantee that mip width/height will be a multiple of the compressed block size. Doing a divide by the block size first yields different results than GL expects, so we do the divide at the end. Signed-off-by: Ilia Mirkin --- This replaces the previous patch,

[Mesa-dev] [Bug 98699] "float[a+++4 ? 1:1] f; " crashes glsl_compiler

https://bugs.freedesktop.org/show_bug.cgi?id=98699 Kenneth Graunke changed: What|Removed |Added Status|ASSIGNED|NEW

Re: [Mesa-dev] [PATCH] blorp: Use designated initializers in surf_convert_to_single_slice

Of you want to make it simpler, we have a macro wrapper called isl_surf_init that will turn those fields into named parameters. Either way, thanks for fixing this up. Rb On Nov 15, 2016 11:23 AM, "Jordan Justen" wrote: Signed-off-by: Jordan Justen

Re: [Mesa-dev] [PATCH] blorp: Use designated initializers in surf_convert_to_single_slice

On Tuesday, November 15, 2016 11:22:28 AM PST Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/intel/blorp/blorp_blit.c | 29 + > 1 file changed, 13 insertions(+), 16 deletions(-) > > diff --git a/src/intel/blorp/blorp_blit.c

Re: [Mesa-dev] [PATCH 2/3] i965: Consolidate GEN9 LP definition

On Thursday, November 10, 2016 10:20:12 AM PST Ben Widawsky wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > src/intel/common/gen_device_info.c | 116 > + > 1 file changed, 40 insertions(+), 76

Re: [Mesa-dev] [PATCH] isl: Fix height calculation in isl_msaa_interleaved_scale_px_to_sa

Oops... Please back-port. Rb On Nov 15, 2016 11:20 AM, "Jordan Justen" wrote: > No known fixed tests, but it looks like a typo from: > > commit 8ac99eabb6570f0f3c5f7d7da1332a99ce636362 > > intel/isl: Add a helper for getting the size of an interleaved pixel > >

[Mesa-dev] [Bug 98699] "float[a+++4 ? 1:1] f; " crashes glsl_compiler

https://bugs.freedesktop.org/show_bug.cgi?id=98699 Ian Romanick changed: What|Removed |Added Status|NEW |ASSIGNED

[Mesa-dev] [Bug 98699] "float[a+++4 ? 1:1] f; " crashes glsl_compiler

https://bugs.freedesktop.org/show_bug.cgi?id=98699 --- Comment #2 from Ian Romanick --- I don't even want to know how you came across that. :) Just looking at the backtrace, it seems the problem is the "a++" generates an assignment. The code that handles array sizes

[Mesa-dev] [AppVeyor] mesa master #2695 completed

Build mesa 2695 completed Commit a6ff2a3378 by Marek Olšák on 11/13/2016 3:54 PM: util/disk_cache: use unambiguous naming\n\nReviewed-by: Emil Velikov Configure your notification preferences

Re: [Mesa-dev] [PATCH] hurd: Fix build

On 13 November 2016 at 23:30, Samuel Thibault wrote: > GNU/Hurd does not define PATH_MAX since it doesn't have such arbitrary > limitation. This works around it in arbprogram.c and shaderapi.c by > defining PATH_MAX to an arbitrary value (4096, as on Linux). > >

[Mesa-dev] [PATCH] blorp: Use designated initializers in surf_convert_to_single_slice

Signed-off-by: Jordan Justen --- src/intel/blorp/blorp_blit.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 1108335..c0b56c3 100644 ---

[Mesa-dev] [PATCH] isl: Fix height calculation in isl_msaa_interleaved_scale_px_to_sa

No known fixed tests, but it looks like a typo from: commit 8ac99eabb6570f0f3c5f7d7da1332a99ce636362 intel/isl: Add a helper for getting the size of an interleaved pixel Cc: Jason Ekstrand Signed-off-by: Jordan Justen ---

Re: [Mesa-dev] [PATCH] ac/nir/llvm: fix channel in texture gather lowering code.

On 15 November 2016 at 17:33, Dave Airlie wrote: > From: Dave Airlie > > Just noticed this by inspection, while trying to locate other > CTS failures. Don't think it fixes anything, but it might be > needed once I find the proper fix. Just noticed it does

[Mesa-dev] [Bug 98740] bitcode.cpp:102:8: error: ‘Error’ is not a member of ‘llvm’

https://bugs.freedesktop.org/show_bug.cgi?id=98740 Emil Velikov changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 31/59] st/glsl_to_tgsi: add support for 64-bit integers. (v2)

On 11/15/2016 01:40 AM, Nicolai Hähnle wrote: > On 10.11.2016 23:59, Ian Romanick wrote: >> On 10/27/2016 06:32 AM, Nicolai Hähnle wrote: >>> This part is suspicious. It looks like the top two vector elements are >>> written into a temporary register that isn't used anywhere. >> >> Uh... I have no

Re: [Mesa-dev] [PATCH 1/2] util: import cache.c/h from glsl

On 15 November 2016 at 19:07, Marek Olšák wrote: > From: Marek Olšák > > It's not dependent on GLSL and it can be useful for shader caches that don't > deal with GLSL. > > v2: address review comments Thank you ! > --- > configure.ac

[Mesa-dev] [Bug 98740] bitcode.cpp:102:8: error: ‘Error’ is not a member of ‘llvm’

https://bugs.freedesktop.org/show_bug.cgi?id=98740 Bug ID: 98740 Summary: bitcode.cpp:102:8: error: ‘Error’ is not a member of ‘llvm’ Product: Mesa Version: 13.0 Hardware: x86-64 (AMD64) OS: Linux (All)

[Mesa-dev] [PATCH 1/2] util: import cache.c/h from glsl

From: Marek Olšák It's not dependent on GLSL and it can be useful for shader caches that don't deal with GLSL. v2: address review comments --- configure.ac | 4 src/compiler/Makefile.glsl.am| 4

[Mesa-dev] [PATCH 2/2] util/disk_cache: use unambiguous naming

From: Marek Olšák --- src/compiler/glsl/tests/cache_test.c | 140 +-- src/util/disk_cache.c| 30 src/util/disk_cache.h| 56 +++--- 3 files changed, 114 insertions(+), 112 deletions(-) diff

Re: [Mesa-dev] Stable release process

On 11/14/2016 02:31 PM, Matt Turner wrote: > A long time ago, patch authors were tasked with cherry-picking their > patches to stable branches. Today we Cc > mesa-sta...@lists.freedesktop.org and Emil rebases those patches onto > stable. Cc'ing the list happens even on patches sent for their first

Re: [Mesa-dev] Fwd: errors for mesa master Android build 554

On 15 November 2016 at 18:40, Brian Paul wrote: > It also broke our in-house Jenkins build on Ubuntu. Though, it's building > OK on my local system. Hmm. > > CC dri_common.lo > ../../../src/glx/dri_common.c: In function ‘driGetDriverExtensions’: >

Re: [Mesa-dev] [PATCH] gallivm: limit use of setFastMathFlags to LLVM 3.8 and later

On 11/15/2016 11:56 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp index

[Mesa-dev] [PATCH] gallivm: limit use of setFastMathFlags to LLVM 3.8 and later

From: Marek Olšák --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp index da3cbdd..a68428d 100644 ---

Re: [Mesa-dev] [PATCH 00/13] implement EGL_EXT_image_dma_buf_import_modifiers

On Tue, Nov 15, 2016 at 1:04 PM, Marek Olšák wrote: > On Tue, Nov 15, 2016 at 6:26 PM, Rob Clark wrote: >> On Tue, Nov 15, 2016 at 12:17 PM, Marek Olšák wrote: >>> On Tue, Nov 15, 2016 at 5:58 PM, Rob Clark wrote:

Re: [Mesa-dev] Fwd: errors for mesa master Android build 554

It also broke our in-house Jenkins build on Ubuntu. Though, it's building OK on my local system. Hmm. CC dri_common.lo ../../../src/glx/dri_common.c: In function ‘driGetDriverExtensions’: ../../../src/glx/dri_common.c:164:32: error: implicit declaration of function

[Mesa-dev] Fwd: errors for mesa master Android build 554

This commit breaks the build for Android. Looks like a prototype is missing and LLVM is stricter. Rob commit 1a21d21580965eff751414d140b3c1762eb3 Author: Christian Gmeiner Date: Thu Nov 3 15:25:21 2016 +0100 dri: make use of dri_get_extensions_name(..)

[Mesa-dev] [AppVeyor] mesa master #2692 failed

Build mesa 2692 failed Commit 358079da2d by Marek Olšák on 11/12/2016 10:10 PM: radeonsi: set unsafe fpmath on FP instructions when allowed by R600_DEBUG\n\nReviewed-by: Nicolai Hähnle Configure your notification preferences

Re: [Mesa-dev] [PATCH 00/13] implement EGL_EXT_image_dma_buf_import_modifiers

On Tue, Nov 15, 2016 at 6:26 PM, Rob Clark wrote: > On Tue, Nov 15, 2016 at 12:17 PM, Marek Olšák wrote: >> On Tue, Nov 15, 2016 at 5:58 PM, Rob Clark wrote: >>> On Tue, Nov 15, 2016 at 11:44 AM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 12/14] swr: remove unnecessary -1 entries in format mapping table

As per our IRC discussion… Reviewed-by: Bruce Cherniak > On Nov 14, 2016, at 7:46 PM, Cherniak, Bruce wrote: > > For book-keeping, to know which formats we have left to support/enable, we’d > like to leave the -1 entries. It’s a little

Re: [Mesa-dev] [PATCH 00/14] swr: resource-related (and misc) fixes

CI results are complete. Go ahead and push those I marked reviewed (all but patches 6 & 11). On Nov 14, 2016, at 10:40 PM, Ilia Mirkin > wrote: Should I push the ones you mark as r-b or wait for a separate go-ahead based on CI results? On

Re: [Mesa-dev] [PATCH 13/14] swr: remove formats from mapping table that don't have StoreTile impls

You’re absolutely correct, the gallivm sampler supports all formats regardless of our table. I stand corrected. Reviewed-by: Bruce Cherniak > On Nov 14, 2016, at 10:38 PM, Ilia Mirkin

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

see drm_fourcc.h (if the extension txt didn't mention that, perhaps it should) BR, -R On Tue, Nov 15, 2016 at 12:23 PM, Roland Scheidegger wrote: > It looks like there aren't any possible modifier bits defined, so how is > this supposed to work? > > Roland > > Am 15.11.2016

Re: [Mesa-dev] [PATCH 02/14] swr: [rasterizer memory] round up when dividing by block sizes

Ah OK. Yeah - I fully expect you to be running all these changes through some qualification process. You have other users, and other hardware. My hope is that you're running this through your target applications and making sure they don't regress. I'm mostly just worried about correctness for now.

Re: [Mesa-dev] [PATCH 00/13] implement EGL_EXT_image_dma_buf_import_modifiers

On Tue, Nov 15, 2016 at 12:17 PM, Marek Olšák wrote: > On Tue, Nov 15, 2016 at 5:58 PM, Rob Clark wrote: >> On Tue, Nov 15, 2016 at 11:44 AM, Marek Olšák wrote: >>> >>> Hi, >>> >>> Is the modifier just a driver-specific description of the

[Mesa-dev] [Bug 97879] [amdgpu] Rocket League: long hangs (several seconds) when loading assets (models/textures/shaders?)

https://bugs.freedesktop.org/show_bug.cgi?id=97879 --- Comment #45 from Gregor Münch --- No change with GIT of today. Slowdowns remain the same. -- You are receiving this mail because: You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH 10/13] gallium: introduce format modifier querying

It looks like there aren't any possible modifier bits defined, so how is this supposed to work? Roland Am 15.11.2016 um 15:24 schrieb Varad Gautam: > From: Varad Gautam > > drivers should implement pipe_screen->get_modifiers_for_format and > advertise it with

Re: [Mesa-dev] [PATCH 00/13] implement EGL_EXT_image_dma_buf_import_modifiers

On Tue, Nov 15, 2016 at 5:58 PM, Rob Clark wrote: > On Tue, Nov 15, 2016 at 11:44 AM, Marek Olšák wrote: >> >> Hi, >> >> Is the modifier just a driver-specific description of the tiling >> layout and compression? >> >> What makes you think that 8 bytes is

  1   2   >