Re: [Mesa-dev] [PATCH] nir: Remove nir_array from lower_locals_to_regs

Could I bother one of you to push it? I haven't yet acquired commit access. 2016-12-16 7:26 GMT+01:00 Jason Ekstrand : > Thanks! Rb. > > On Dec 15, 2016 3:30 PM, "Eric Anholt" wrote: >> >> Thomas Helland writes: >> >> > We do

Re: [Mesa-dev] [PATCH] nir: Remove nir_array from lower_locals_to_regs

Thanks! Rb. On Dec 15, 2016 3:30 PM, "Eric Anholt" wrote: > Thomas Helland writes: > > > We do nothing but initialize it, add to it, and delete it. > > This is a fallout from removing constant initializer support. > > Maybe in the summary do

Re: [Mesa-dev] [PATCH] anv: Fix uniform and storage buffer offset alignment limits.

On Dec 15, 2016 3:22 PM, "Francisco Jerez" wrote: This fixes an apparent regression in a bunch of image store vulkan CTS tests from commit ad38ba113491869ab0dffed937f7b3dd50e8a735, which started using OWORD block read messages to implement UBO loads. The reason for the

Re: [Mesa-dev] [PATCH] nir: Turn imov/fmov of undef into undef

On Dec 15, 2016 4:26 PM, "Kenneth Graunke" wrote: On Friday, December 16, 2016 10:17:33 AM PST Timothy Arceri wrote: > Reverting the previous attempt at this a5502a721fd30fd resulted in > the following Vulkan test failing. > >

[Mesa-dev] [PATCH 07/19] glsl: Mark a set of array elements as accessed using a list of array_deref_range

From: Ian Romanick Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/ir_array_refcount.cpp | 55 + src/compiler/glsl/ir_array_refcount.h | 49

[Mesa-dev] [PATCH 19/19] nir: Trivial clean ups in the generated nir_constant_expressions.c

From: Ian Romanick Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke --- src/compiler/nir/nir_constant_expressions.py | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 16/19] glsl: Silence "unused parameter" warnings in ast_type.cpp

From: Ian Romanick glsl/ast_type.cpp: In function ‘bool validate_point_mode(YYLTYPE*, _mesa_glsl_parse_state*, const ast_type_qualifier&, const ast_type_qualifier&)’: glsl/ast_type.cpp:173:30: warning: unused parameter ‘loc’ [-Wunused-parameter]

[Mesa-dev] [PATCH 03/19] glsl: Track the linearized array index for each UBO instance array element

From: Ian Romanick Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/link_uniform_blocks.cpp | 17 ++--- src/mesa/main/mtypes.h| 15 +++ 2 files changed, 29

[Mesa-dev] [PATCH 13/19] glsl: Minor formatting fixes in link_uniform_blocks.cpp

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/link_uniform_blocks.cpp | 79 --- 1 file changed, 42 insertions(+), 37 deletions(-) diff --git a/src/compiler/glsl/link_uniform_blocks.cpp

[Mesa-dev] [PATCH 06/19] glsl: Add structures to track accessed elements of a single array

From: Ian Romanick Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/ir_array_refcount.cpp | 21 src/compiler/glsl/ir_array_refcount.h | 35 + 2

[Mesa-dev] [PATCH 12/19] glsl: Fix all the whitespace errors in link_uniform_block_active_visitor.cpp

From: Ian Romanick Signed-off-by: Ian Romanick --- .../glsl/link_uniform_block_active_visitor.cpp | 46 ++ 1 file changed, 21 insertions(+), 25 deletions(-) diff --git

[Mesa-dev] [PATCH 05/19] glsl: Add tracking for elements of an array-of-arrays that have been accessed

From: Ian Romanick If there's a better way to provide access to ir_array_refcount_entry private members to the test functions, I am very interested to know about it. Signed-off-by: Ian Romanick Cc: Francisco Jerez Cc:

[Mesa-dev] [PATCH 15/19] glsl: Trivial whitespace fixes in link_uniforms.cpp

From: Ian Romanick Signed-off-by: Ian Romanick --- src/compiler/glsl/link_uniforms.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index

[Mesa-dev] [PATCH 11/19] mesa: Silence numerous "unused parameter" warnings in dlist.c

From: Ian Romanick main/dlist.c: In function ‘save_DrawArraysInstancedARB’: main/dlist.c:1748:36: warning: unused parameter ‘mode’ [-Wunused-parameter] save_DrawArraysInstancedARB(GLenum mode, ^~~~ main/dlist.c:1749:35: warning:

[Mesa-dev] [PATCH 17/19] nir: Silence missing field initializer warnings for vectors in nir_constant_expressions

From: Ian Romanick nir/nir_constant_expressions.c: In function 'evaluate_ball2': nir/nir_constant_expressions.c:279:7: warning: missing initializer for field 'z' of 'struct bool_vec' [-Wmissing-field-initializers] }; ^

[Mesa-dev] [PATCH 01/19] glsl: Split process_block_array into two functions

From: Ian Romanick One for the array parts and one for the leaf members. This will simplify later changes. The indentation is wonkey after this patch. This was done to make it more obvious that the function is just getting split. The next patch will fix the

[Mesa-dev] [PATCH 04/19] glsl: Use simpler visitor to determine which UBO and SSBO blocks are used

From: Ian Romanick Very soon this visitor will get more complicated. The users of the existing ir_variable_refcount visitor won't need the coming functionality, and this use doesn't need much of the functionality of ir_variable_refcount. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 02/19] glsl: Fix wonkey indentation left from previous commit

From: Ian Romanick Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/link_uniform_blocks.cpp | 89 +++ 1 file changed, 44 insertions(+), 45 deletions(-) diff --git

[Mesa-dev] [PATCH 18/19] nir: Silence unused parameter warnings in nir_constant_expression.c

From: Ian Romanick nir/nir_constant_expressions.c:290:25: warning: unused parameter 'num_components' [-Wunused-parameter] evaluate_ball3(unsigned num_components, nir_const_value *_src) ^ nir/nir_constant_expressions.c: In function

[Mesa-dev] [PATCH 14/19] glsl: Silence unused parameter warning in propagate_invariance.cpp

From: Ian Romanick glsl/propagate_invariance.cpp: In member function ‘virtual ir_visitor_status {anonymous}::ir_invariance_propagation_visitor::visit_leave(ir_assignment*)’: glsl/propagate_invariance.cpp:86:63: warning: unused parameter ‘ir’ [-Wunused-parameter]

[Mesa-dev] [PATCH 09/19] linker: Accurately mark a uniform block instance array element as used in a stage

From: Ian Romanick Now that information about which array-of-arrays elements are accessed is tracked, use that information to only mark an instance array element as used-by-stage if, in fact, it is. Fixes GL45-CTS.program_interface_query.uniform-block-types.

[Mesa-dev] [PATCH 10/19] mesa: Fix all the whitespace errors in dlist.c

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/dlist.c | 373 +- 1 file changed, 186 insertions(+), 187 deletions(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c

[Mesa-dev] [PATCH 08/19] glsl: Walk a list of ir_dereference_array to mark array elements as accessed

From: Ian Romanick Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/ir_array_refcount.cpp | 73 +++- src/compiler/glsl/ir_array_refcount.h | 10 +

[Mesa-dev] [PATCH 00/19] Track block instance array access per element

This series can also be found at: https://cgit.freedesktop.org/~idr/mesa/log/?h=fix-GL45-CTS.program_interface_query.uniform-block-types The first 9 patches in the series are the bug fix. This conformance test expects per-block used-by tracking for UBO and SSBO instance array blocks. So,

Re: [Mesa-dev] Problem using GLVND enabled mesa with Intel DDX

Thanks for your info, Emil. Same bug as 98428. Regards, Qiang From: Emil Velikov Sent: Thursday, December 15, 2016 9:58:34 PM To: Yu, Qiang Cc: mesa-dev@lists.freedesktop.org; kbrenne...@nvidia.com; Daenzer, Michel Subject: Re:

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

Reviewed-by: Edward O'Callaghan On 12/16/2016 12:56 PM, Randy Xu wrote: > From: "Xu,Randy" > > The ES specification says that TexImage3D should return GL_INVALID_OPERATION > if the internal format is DEPTH_COMPONENT, DEPTH_-STENCIL or

Re: [Mesa-dev] [PATCH 3/3] nir: Rewrite lower_regs_to_ssa to use the phi builder

On Dec 15, 2016 3:08 PM, "Eric Anholt" wrote: Jason Ekstrand writes: > This keeps some of Connor's original code. However, while I was at it, > I updated this very old pass to a bit more modern NIR. I love how much smaller this code is. Assuming that

[Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

From: "Xu,Randy" The ES specification says that TexImage3D should return GL_INVALID_OPERATION if the internal format is DEPTH_COMPONENT, DEPTH_-STENCIL or STENCIL_INDEX. The current code returns INVALID_ENUM as _mesa_error_check_format_and_type is used by glReadPixels also

[Mesa-dev] [PATCH] radv: fix dual source blending

Add the index to the location when assigning driver locations for output variables. Otherwise two fragment shader outputs declared as: layout (location = 0, index = 0) out vec4 output1; layout (location = 0, index = 1) out vec4 output2; will end up aliasing one another. Note that this

Re: [Mesa-dev] [PATCH] Mesa: Return GL error INVALID_OPERATION in case invalid format/type

Thanks, Matt I have run "git config --global user.name "Randy Xu"" and see it in ~/.gitconfig [user] email = randy...@intel.com name = Randy Xu While I don’t know why the "git send-email --smtp-server=smtp.intel.com --to=mesa-dev@lists.freedesktop.org 0001-.patch" command

Re: [Mesa-dev] [PATCH] Mesa: Return GL error INVALID_OPERATION in case invalid format/type

On Thu, Dec 15, 2016 at 5:19 PM, Matt Turner wrote: > On Wed, Dec 14, 2016 at 5:10 PM, Randy Xu wrote: >> From: "Xu,Randy" > > Reminder to fix your configured name. And also please stop Cc'ing the non-existent x...@freedesktop.org on

Re: [Mesa-dev] [PATCH] Mesa: Return GL error INVALID_OPERATION in case invalid format/type

On Wed, Dec 14, 2016 at 5:10 PM, Randy Xu wrote: > From: "Xu,Randy" Reminder to fix your configured name. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] Mesa: Return GL error INVALID_OPERATION in case invalid format/type

Thanks, Emil & Ilia I will revise the patch per your suggestion below. 1. Refer 19f13b2096a9fdd986e5a12d4e9d8b0d6a4632f3 to update comment 2. s/can fix/fixes/ 3. s/failure// 4. s/Bug/Bugzilla/ 5. Cc: "13.0" As for "Matt pointed out that desktop GL actually

Re: [Mesa-dev] [PATCH] swr: Implement fence attached work queues for deferred deletion.

Reviewed-by: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Bruce Cherniak > Sent: Monday, December 12, 2016 7:25 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] swr:

Re: [Mesa-dev] [PATCH] nir: Turn imov/fmov of undef into undef

On Friday, December 16, 2016 10:17:33 AM PST Timothy Arceri wrote: > Reverting the previous attempt at this a5502a721fd30fd resulted in > the following Vulkan test failing. > > dEQP-VK.glsl.return.return_in_dynamic_loop_dynamic_vertex > > This time we use the num_components from the alu dest

Re: [Mesa-dev] [PATCH 45/84] st/nine: Pass size of memory to nine_state

This patch breaks build because it doesn't replace some calls. The replacements are introduced by the patch after. I suggest to just merge the two patches. I'm not so sure this patch makes sense alone. Axel On 07/12/2016 23:55, Axel Davy wrote: From: Patrick Rudolph

[Mesa-dev] [PATCH 39/84 v2] st/nine: Reimplement nine_context_apply_stateblock

The new version uses nine_context functions instead of applying the changes directly to nine_context. This will enable it to work with CSMT. v2: Fix nine_context_light_enable_stateblock. The memcpy arguments were wrong, and the state wasn't set dirty. Signed-off-by: Axel Davy

Re: [Mesa-dev] [PATCH] nir: Remove nir_array from lower_locals_to_regs

Thomas Helland writes: > We do nothing but initialize it, add to it, and delete it. > This is a fallout from removing constant initializer support. Maybe in the summary do s/nir_array/derefs_array/, but either way: Reviewed-by: Eric Anholt

[Mesa-dev] [PATCH] anv: Fix uniform and storage buffer offset alignment limits.

This fixes an apparent regression in a bunch of image store vulkan CTS tests from commit ad38ba113491869ab0dffed937f7b3dd50e8a735, which started using OWORD block read messages to implement UBO loads. The reason for the failure is that we were giving bogus buffer alignment limits to the

[Mesa-dev] [PATCH] nir: Turn imov/fmov of undef into undef

Reverting the previous attempt at this a5502a721fd30fd resulted in the following Vulkan test failing. dEQP-VK.glsl.return.return_in_dynamic_loop_dynamic_vertex This time we use the num_components from the alu dest rather than num_inputs to the op to determine the size of the undef. Cc: "13.0"

Re: [Mesa-dev] [PATCH 3/3] nir: Rewrite lower_regs_to_ssa to use the phi builder

Jason Ekstrand writes: > This keeps some of Connor's original code. However, while I was at it, > I updated this very old pass to a bit more modern NIR. I love how much smaller this code is. Assuming that the phi builder does that job correctly, this is pretty trivial to

[Mesa-dev] [PATCH] nir: Remove nir_array from lower_locals_to_regs

We do nothing but initialize it, add to it, and delete it. This is a fallout from removing constant initializer support. CC: Jason Ekstrand --- src/compiler/nir/nir_lower_locals_to_regs.c | 9 - 1 file changed, 9 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 0/3] nir: Rewrite the register-based into-SSA pass to use

Jason Ekstrand writes: > Ever since I wrote the phi builder and converted vars_to_ssa to use it, > I've been meaning to convert the other into-SSA pass to use it as well. > This little series does just that. While I was at it, I also renamed it to > nir_lower_regs_to_ssa

[Mesa-dev] [PATCH] radeonsi: Use build_buffer_load helper function for geometry shaders

Also add a need_range_checks parameter to this function, which can be set to false to enable some additional optimizations. Currently, this will cause the compiler to emit the llvm.SI.buffer.load.dword intrinsic instead of llvm.amdgcn.buffer.load. Eventually, this information will be passed to

Re: [Mesa-dev] [PATCH v2 2/4] nir: Add foreach_register helper macros

On Dec 15, 2016 9:45 AM, "Gustaw Smolarczyk" wrote: 15 gru 2016 18:19 "Jason Ekstrand" napisał(a): --- src/compiler/nir/nir.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

[Mesa-dev] [PATCH] radeonsi: Set datalayout on the llvm module

This prevents LLVM from using sext instructions for local memory offsets and allows the backend to fold immediate offsets into the instruction. This also prevents some incorrect code generation for ptrtoint and inttoptr instructions. --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 6

Re: [Mesa-dev] [PATCH v2 4/4] nir: Rewrite lower_regs_to_ssa to use the phi builder

15 gru 2016 18:19 "Jason Ekstrand" napisał(a): This keeps some of Connor's original code. However, while I was at it, I updated this very old pass to a bit more modern NIR. --- src/compiler/nir/nir_lower_regs_to_ssa.c | 582 --- 1 file changed,

Re: [Mesa-dev] [PATCH v2 2/4] nir: Add foreach_register helper macros

15 gru 2016 18:19 "Jason Ekstrand" napisał(a): --- src/compiler/nir/nir.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f1c99ce..4a9fe65 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@

[Mesa-dev] [PATCH v2 4/4] nir: Rewrite lower_regs_to_ssa to use the phi builder

This keeps some of Connor's original code. However, while I was at it, I updated this very old pass to a bit more modern NIR. --- src/compiler/nir/nir_lower_regs_to_ssa.c | 582 --- 1 file changed, 155 insertions(+), 427 deletions(-) diff --git

[Mesa-dev] [PATCH v2 2/4] nir: Add foreach_register helper macros

--- src/compiler/nir/nir.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index f1c99ce..4a9fe65 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -373,6 +373,11 @@ typedef struct nir_register { struct list_head

[Mesa-dev] [PATCH v2 3/4] nir/phi-builder: Set the value in the block when creating a phi

After we figure out the value that we are going to return, we have a loop that walks up the dominance tree and sets the value in each of the blocks that doesn't have one yet. In the case of the phi, the def is set to NEEDS_PHI not NULL, so the last one where the phi node actually goes never gets

[Mesa-dev] [PATCH v2 1/4] nir: Rename convert_to_ssa lower_regs_to_ssa

This matches the naming of nir_lower_vars_to_ssa, the other to-SSA pass. --- src/compiler/Makefile.sources | 2 +- src/compiler/nir/nir.h | 4 +--- src/compiler/nir/{nir_to_ssa.c => nir_lower_regs_to_ssa.c} | 8

[Mesa-dev] [PATCH v2 0/4] Rewrite the register-based into-SSA pass to use the phi builder API

This is a quick v2 of the regs_to_ssa rewrite. Immediately after sending it out and asking Rob and Eric to test it because we didn't use it for anything with control-flow, I realized I could easily test it by hacking our driver to call regs_to_ssa immediately after going out of SSA and then go

Re: [Mesa-dev] [PATCH 1/3] i965/blit: Break the guts of intel_miptree_blit into a helper

On Thu, Dec 15, 2016 at 8:42 AM, Emil Velikov wrote: > Hi Jason, > > Double-checking things and I've noticed that this has gone under the > radar since due to simple typo - mesa-dev vs mesa-stable. > Regardless, the patch in question seems to depend on at least Sorry

Re: [Mesa-dev] [PATCH 2/2] radeonsi: fix gl_ClipDistance and gl_ClipVertex for points

On Thu, Dec 15, 2016 at 11:45 AM, Nicolai Hähnle wrote: > On 15.12.2016 17:19, Ilia Mirkin wrote: >> >> Perhaps this is a point-specific function, but if this is applying to >> all primitives, won't this end up culling primitives that have *any* >> clip distance value < 0? > >

Re: [Mesa-dev] [PATCH 1/3] i965/blit: Break the guts of intel_miptree_blit into a helper

On 15 December 2016 at 16:42, Emil Velikov wrote: > Hi Jason, > > Double-checking things and I've noticed that this has gone under the > radar since due to simple typo - mesa-dev vs mesa-stable. JFYI skimming through the nominations - there are ~5 missing ones for 13.0

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965/blit: Fix the src dimension sanity check in miptree_copy

Hi Jason, On 6 December 2016 at 20:37, Jason Ekstrand wrote: > Cc: "13.0" > --- > src/mesa/drivers/dri/i965/intel_blit.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] radeonsi: fix gl_ClipDistance and gl_ClipVertex for points

On 15.12.2016 17:19, Ilia Mirkin wrote: Perhaps this is a point-specific function, but if this is applying to all primitives, won't this end up culling primitives that have *any* clip distance value < 0? Setting the cull bit here just enables the normal gl_CullDistance logic for whatever the

Re: [Mesa-dev] [PATCH 1/3] i965/blit: Break the guts of intel_miptree_blit into a helper

Hi Jason, Double-checking things and I've noticed that this has gone under the radar since due to simple typo - mesa-dev vs mesa-stable. Regardless, the patch in question seems to depend on at least 174f4900b294f939c85cfa94f5d8401ce73e5522 b7979a849bc185fbcab93a841eed692a10d61e25

Re: [Mesa-dev] [PATCH 2/2] radeonsi: fix gl_ClipDistance and gl_ClipVertex for points

Perhaps this is a point-specific function, but if this is applying to all primitives, won't this end up culling primitives that have *any* clip distance value < 0? On Thu, Dec 15, 2016 at 10:42 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] i965/mt: Disable HiZ when sharing depth buffer externally (v2)

Hi Chad, On 10 December 2016 at 00:40, Chad Versace wrote: > intel_miptree_make_shareable() discarded and disabled CCS. Fix it so > that it discards and disables HiZ too. > > Fixes >

Re: [Mesa-dev] Documenting with Sphinx

On Dec 15, 2016 6:40 AM, "Jani Nikula" wrote: On Thu, 15 Dec 2016, Robert Bragg wrote: > On Wed, Dec 14, 2016 at 7:17 PM, Jani Nikula > wrote: >> On Wed, 14 Dec 2016, Robert Bragg wrote: >>

[Mesa-dev] [PATCH 2/2] radeonsi: fix gl_ClipDistance and gl_ClipVertex for points

From: Nicolai Hähnle The clipper hardware doesn't consider points as primitives that can be clipped. Simply setting the corresponding cull bits works, and should not have an adverse effect on other primitive types according to the hardware team. ---

[Mesa-dev] [PATCH 1/2] radeonsi: only set VS_OUT_MISC_SIDE_BUS_ENA when the misc vector is used

From: Nicolai Hähnle Should have no effect (other than perhaps on power consumption), but Vulkan does this. --- src/gallium/drivers/radeonsi/si_state.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [Bug 98428] Undefined non-weak-symbol in dri-drivers

https://bugs.freedesktop.org/show_bug.cgi?id=98428 Eugene A. Shatokhin changed: What|Removed |Added CC|

[Mesa-dev] [Bug 99027] gtk+ apps segfault on Xvfb with mesa 13

https://bugs.freedesktop.org/show_bug.cgi?id=99027 --- Comment #9 from Emil Velikov --- Almost but not quite: getVisualConfigs() seems to fail since the xserver advertises zero visuals (reply.numVisuals). Which in itself is not at all surprising. For both 24 and 8 bpp

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-12-12 20:01 GMT+01:00 Emil Velikov : > [Re-adding mesa-maintainers] > > On 12 December 2016 at 18:08, Laurent Carlier wrote: >> Le lundi 12 décembre 2016, 17:57:28 CET Marek Olšák a écrit : >>> >>> I second that. YY.AA where YY=year, AA \in

[Mesa-dev] [Bug 99027] gtk+ apps segfault on Xvfb with mesa 13

https://bugs.freedesktop.org/show_bug.cgi?id=99027 --- Comment #8 from Emil Velikov --- Using 8bpp, not sure if that's supposed to work even ;-) Joking aside, the bisect result is a surprise and from a quick look the only thing that might be wrong on our end is

Re: [Mesa-dev] Documenting with Sphinx

On Thu, 15 Dec 2016, Robert Bragg wrote: > On Wed, Dec 14, 2016 at 7:17 PM, Jani Nikula > wrote: >> On Wed, 14 Dec 2016, Robert Bragg wrote: >> The AST does include comments right above each cursor, but it falls >> short

Re: [Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

My apologies for sending the wrong series. On Thu, Dec 15, 2016 at 7:45 PM, Christian König wrote: > Am 15.12.2016 um 15:07 schrieb Emil Velikov: >> >> On 15 December 2016 at 13:57, Nayan Deshmukh >> wrote: >>> >>> I send out the wrong

Re: [Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

Am 15.12.2016 um 15:07 schrieb Emil Velikov: On 15 December 2016 at 13:57, Nayan Deshmukh wrote: I send out the wrong series, the earlier one. I am sending the v2. I am not sure of the reason as to why it was returning a bool anyways. So I was hoping that someone

[Mesa-dev] [PATCH v2 4/4] st/xvmc: remove dead code

vl_compositor_init_state always return true so we don't need to handle false case Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/xvmc/context.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH v2 3/4] st/vdpau: check if compositor is initilized successfully

Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/device.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/device.c b/src/gallium/state_trackers/vdpau/device.c index 81b7582..8bae064 100644

[Mesa-dev] [PATCH v2 1/4] st/xvmc: use goto to make code more readable

Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/xvmc/context.c | 40 +++ 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/context.c b/src/gallium/state_trackers/xvmc/context.c

[Mesa-dev] [PATCH v2 2/4] st/vdpau: remove dead code

vl_compositor_init_state always return true so we don't need to handle false case v2: add missing semicolon Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/presentation.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

On 15 December 2016 at 13:57, Nayan Deshmukh wrote: > I send out the wrong series, the earlier one. I am sending the v2. > > I am not sure of the reason as to why it was returning a bool anyways. > So I was hoping that someone could point out the reason. > Looking

Re: [Mesa-dev] [PATCH] Mesa: Return GL error INVALID_OPERATION in case invalid format/type

On Thu, Dec 15, 2016 at 6:45 AM, Emil Velikov wrote: > On 15 December 2016 at 01:10, Randy Xu wrote: >> From: "Xu,Randy" >> >> Refer to GLES3.2 spec in 8.5 >> Textures with a base internal format of DEPTH_COMPONENT, DEPTH_- >>

Re: [Mesa-dev] Problem using GLVND enabled mesa with Intel DDX

On 15 December 2016 at 09:01, Yu, Qiang wrote: > > Hi guys, > > I'm trying GLVND with mesa, but the Intel DDX seems have some problem with it: > [ 2970.834] (EE) AIGLX error: dlopen of > /usr/lib/x86_64-linux-gnu/dri/i965_dri.so failed >

Re: [Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

I send out the wrong series, the earlier one. I am sending the v2. I am not sure of the reason as to why it was returning a bool anyways. So I was hoping that someone could point out the reason. Regards, Nayan On Thu, Dec 15, 2016 at 7:24 PM, Ilia Mirkin wrote: > Also,

Re: [Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

Also, please at least *compile test* your patches. This patch doesn't compile. On Thu, Dec 15, 2016 at 8:54 AM, Ilia Mirkin wrote: > Should there be a patch 5 which makes vl_compositor_init_state return void? > > On Thu, Dec 15, 2016 at 8:34 AM, Nayan Deshmukh >

Re: [Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

Should there be a patch 5 which makes vl_compositor_init_state return void? On Thu, Dec 15, 2016 at 8:34 AM, Nayan Deshmukh wrote: > vl_compositor_init_state always return true so we don't > need to handle false case > > Signed-off-by: Nayan Deshmukh

Re: [Mesa-dev] Documenting with Sphinx

On Wed, Dec 14, 2016 at 7:17 PM, Jani Nikula wrote: > On Wed, 14 Dec 2016, Robert Bragg wrote: >> On Tue, Dec 13, 2016 at 11:08 PM, Rob Clark wrote: >>> On Tue, Dec 13, 2016 at 5:47 PM, Eric Anholt wrote:

[Mesa-dev] [PATCH 3/4] st/vdpau: check if compositor is initilized successfully

Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/device.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vdpau/device.c b/src/gallium/state_trackers/vdpau/device.c index 81b7582..62709e3 100644

[Mesa-dev] [PATCH 2/4] st/vdpau: remove dead code

vl_compositor_init_state always return true so we don't need to handle false case Signed-off-by: Nayan Deshmukh --- We may as well make vl_compositor_init_state a void function but I don't know the reason as to why it is there in first place so haven't touched it yet

[Mesa-dev] [PATCH 1/4] st/xvmc: use goto to make code more readable

Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/xvmc/context.c | 40 +++ 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/src/gallium/state_trackers/xvmc/context.c b/src/gallium/state_trackers/xvmc/context.c

[Mesa-dev] [PATCH 4/4] st/xvmc: remove dead code

vl_compositor_init_state always return true so we don't need to handle false case Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/xvmc/context.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

Re: [Mesa-dev] [PATCH mesa] egl/x11: cleanup init code

On 13 December 2016 at 18:40, Eric Engestrom wrote: > On Thursday, 2016-12-08 20:17:21 +, Emil Velikov wrote: >> On 8 December 2016 at 00:30, Eric Engestrom wrote: >> > No functional change, just rewriting it in an easier-to-understand way. >> >

[Mesa-dev] [Bug 99055] Games hang / freeze completely

https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #19 from Eero Tamminen --- There are also few other libraries which too old versions can cause problems. E.g. some X ones, if you're using DRI3. Could you attach the list of libraries used by your game?

[Mesa-dev] [Bug 99055] Games hang / freeze completely

https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #18 from Etienne Bruines --- It turns out to be using this library (and nothing that shipped with it) : /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.22 The libraries in use are all part of the distro. -- You are

Re: [Mesa-dev] [PATCH] Mesa: Return GL error INVALID_OPERATION in case invalid format/type

On 15 December 2016 at 01:10, Randy Xu wrote: > From: "Xu,Randy" > > Refer to GLES3.2 spec in 8.5 > Textures with a base internal format of DEPTH_COMPONENT, DEPTH_- > STENCIL or STENCIL_INDEX are supported by texture image specification > commands only if

[Mesa-dev] Problem using GLVND enabled mesa with Intel DDX

Hi guys, I'm trying GLVND with mesa, but the Intel DDX seems have some problem with it: [ 2970.834] (EE) AIGLX error: dlopen of /usr/lib/x86_64-linux-gnu/dri/i965_dri.so failed (/usr/lib/x86_64-linux-gnu/dri/i965_dri.so: undefined symbol: _glapi_tls_Dispatch) [ 2970.834] (EE) AIGLX:

Re: [Mesa-dev] [PATCH] egl: Fix crashes in eglCreate*Surface()

On 14 December 2016 at 20:01, Chad Versace wrote: > On Wed 14 Dec 2016, Emil Velikov wrote: >> On 13 December 2016 at 22:40, Chad Versace wrote: >> > Don't dereference a null EGLDisplay. >> > >> > Fixes tests >> >

[Mesa-dev] [Bug 99055] Games hang / freeze completely

https://bugs.freedesktop.org/show_bug.cgi?id=99055 --- Comment #17 from Eero Tamminen --- (In reply to Kenneth Graunke from comment #15) > Renaming the binaries or editing scripts installed with the game is liable > to break when new updates for the game comes out,