[Mesa-dev] [PATCH 1/5] mesa: Do (TCS && !TES) draw time validation in ES as well.

2017-02-10 Thread Kenneth Graunke
Now that we have OES_tessellation_shader, the same situation can occur in ES too, not just GL core profile. Having a TCS but no TES may confuse drivers - i965 crashes, for example. This prevents regressions in ES31-CTS.core.tessellation_shader.single.xfb_captures_data_from_correct_stage with

[Mesa-dev] [PATCH 2/5] mesa: Do a draw time check for TES && !TCS in ES 3.x.

2017-02-10 Thread Kenneth Graunke
ES 3.x requires both TCS and TES to be present. We already checked the TCS && !TES case above, so we just have to check !TCS && TES here. Note that this is allowed in OpenGL, just not ES. This fixes a subcase of:

[Mesa-dev] [PATCH 5/5] glsl: Drop resize-to-MaxPatchVertices hack.

2017-02-10 Thread Kenneth Graunke
TCS and TES inputs without an array size are implicitly sized to gl_MaxPatchVertices. But TCS outputs are apparently not: "If no size is specified, it will be taken from the output patch size (gl_VerticesOut) declared in the shader." Fixes

[Mesa-dev] [PATCH 3/5] glsl: Update a comment about link errors for TCS && !TES.

2017-02-10 Thread Kenneth Graunke
OpenGL ES actually has spec text to prohibit this. It's just OpenGL that's confusing. Signed-off-by: Kenneth Graunke --- src/compiler/glsl/linker.cpp | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/linker.cpp

[Mesa-dev] [PATCH 4/5] mesa: Ignore per-vertex array size in SSO pipeline validation.

2017-02-10 Thread Kenneth Graunke
We were already unwrapping types when the producer was a non-array stage and the consumer was an arrayed-stage...but we ought to unwrap both ends for TCS -> TES matching too. This will allow us to drop the "resize to gl_MaxPatchVertices" check shortly, which breaks some things. Signed-off-by:

Re: [Mesa-dev] [PATCH] glsl: Actually enforce ES SSBO unsized array check for SSBOs.

2017-02-10 Thread Kenneth Graunke
On Friday, February 10, 2017 3:01:10 PM PST Ilia Mirkin wrote: > Seems pretty similar to https://patchwork.freedesktop.org/patch/138274/ So it does! I hadn't seen that patch yet. I just pushed his patch instead with my R-b. Thanks! signature.asc Description: This is a digitally signed

Re: [Mesa-dev] [PATCH] glsl: non-last member unsized array on SSBO must fail compilation on GLSL ES 3.1

2017-02-10 Thread Kenneth Graunke
On Friday, February 10, 2017 5:25:27 AM PST Jose Maria Casanova Crespo wrote: > From GLSL ES 3.10 spec, section 4.1.9 "Arrays": > > "If an array is declared as the last member of a shader storage block > and the size is not specified at compile-time, it is sized at run-time. > In all other

Re: [Mesa-dev] [PATCH] removed report to vendor message when dri3 is not detected

2017-02-10 Thread Jason Ekstrand
On Fri, Feb 10, 2017 at 5:44 PM, Jacob Lifshay wrote: > fixes bug 99715 > Not really... It fixes what the subject of the bug says but doesn't fully solve the problem. We need some way of detecting that we're on an X server that *could* support us but can't because of

[Mesa-dev] [PATCH v2] anv/cmd_buffer: Return a VkResult from verify_cmd_parser

2017-02-10 Thread Jason Ekstrand
This fixes a "statement with no effect" compiler warning --- src/intel/vulkan/genX_cmd_buffer.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 8db26e9..d07fe78 100644 ---

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Jason Ekstrand
On Fri, Feb 10, 2017 at 5:29 PM, Nanley Chery wrote: > On Fri, Feb 10, 2017 at 03:31:32PM -0800, Jason Ekstrand wrote: > > On Fri, Feb 10, 2017 at 3:18 PM, Nanley Chery > wrote: > > > > > On Fri, Feb 10, 2017 at 02:55:42PM -0800, Nanley Chery wrote:

[Mesa-dev] [PATCH] anv/cmd_buffer: Return a VkResult from verify_cmd_parser

2017-02-10 Thread Jason Ekstrand
This fixes a "statement with no effect" compiler warning --- src/intel/vulkan/genX_cmd_buffer.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 8db26e9..9c39754 100644 ---

Re: [Mesa-dev] [PATCH] util/radv/adv: move *_get_function_timestamp() to utils

2017-02-10 Thread Nils Wallménius
Hi Tim, one comment below BR Nils Den 10 feb. 2017 3:03 fm skrev "Timothy Arceri" : --- src/amd/vulkan/radv_device.c | 22 +++--- src/intel/vulkan/anv_device.c | 20 ++-- src/util/disk_cache.h | 17 + 3 files

[Mesa-dev] [PATCH] removed report to vendor message when dri3 is not detected

2017-02-10 Thread Jacob Lifshay
fixes bug 99715 Signed-off-by: Jacob Lifshay --- src/vulkan/wsi/wsi_common_x11.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index 64ba921..e092066 100644 --- a/src/vulkan/wsi/wsi_common_x11.c

Re: [Mesa-dev] GLSL IR & TGSI on-disk shader cache

2017-02-10 Thread Pierre-Loup A. Griffais
On 02/10/2017 04:01 AM, Nicolai Hähnle wrote: On 10.02.2017 12:46, Timothy Arceri wrote: On 10/02/17 21:35, Nicolai Hähnle wrote: On 08.02.2017 23:31, Eric Anholt wrote: Bas Nieuwenhuizen writes: On Wed, Feb 8, 2017, at 11:25, Matt Turner wrote: On Wed, Feb

[Mesa-dev] [Bug 99638] Mesa opengles Peppa Pig and openggles2 smurfs on Radeon PowerPC and PPC64

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99638 --- Comment #13 from Ilia Mirkin --- (In reply to Daniel Stone from comment #7) > At a blind guess, I'm going to say that this is because Wayland's formats > are defined as DRM's are, i.e. explicitly little-endian where

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Nanley Chery
On Fri, Feb 10, 2017 at 03:31:32PM -0800, Jason Ekstrand wrote: > On Fri, Feb 10, 2017 at 3:18 PM, Nanley Chery wrote: > > > On Fri, Feb 10, 2017 at 02:55:42PM -0800, Nanley Chery wrote: > > > On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote: > > > > It's a

[Mesa-dev] [Bug 99638] Mesa opengles Peppa Pig and openggles2 smurfs on Radeon PowerPC and PPC64

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99638 --- Comment #12 from Casey C --- Hello All, I'm experiencing the same issues. A-EON X5000 PowerPC (e5500 cores) Sapphire Radeon HD6870 1 GB VRAM ubuntu MATE 17.04 PowerPC (PPC32) on kernel 4.10.0-rc5 Mesa 13.0.4

[Mesa-dev] [Bug 99638] Mesa opengles Peppa Pig and openggles2 smurfs on Radeon PowerPC and PPC64

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99638 Casey C changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Jason Ekstrand
On Fri, Feb 10, 2017 at 4:47 PM, Nanley Chery wrote: > On Fri, Feb 10, 2017 at 03:21:38PM -0800, Jason Ekstrand wrote: > > On Fri, Feb 10, 2017 at 2:55 PM, Nanley Chery > wrote: > > > > > On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Nanley Chery
On Fri, Feb 10, 2017 at 03:21:38PM -0800, Jason Ekstrand wrote: > On Fri, Feb 10, 2017 at 2:55 PM, Nanley Chery wrote: > > > On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote: > > > It's a bit hard to measure because it almost gets lost in the noise, > > > but

[Mesa-dev] [PATCH 2/3] i965/sampler_state: Pass texObj into update_sampler_state

2017-02-10 Thread Jason Ekstrand
Cc: "17.0 13.0" --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_sampler_state.c b/src/mesa/drivers/dri/i965/brw_sampler_state.c index

[Mesa-dev] [PATCH 3/3] i965/sampler_state: Set the "Base Mip Level" field on Sandy Bridge

2017-02-10 Thread Jason Ekstrand
Fixes two GL ES 3.0 CTS tests on Sandy Bridge: ES3-CTS.functional.texture.mipmap.cube.base_level.linear_linear ES3-CTS.functional.texture.mipmap.cube.base_level.linear_nearest Cc: "17.0 13.0" --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 20

[Mesa-dev] [PATCH 1/3] i965/sampler_state: Clamp min/max LOD to 14 on gen7+

2017-02-10 Thread Jason Ekstrand
Cc: "17.0" --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_sampler_state.c b/src/mesa/drivers/dri/i965/brw_sampler_state.c index 412efb9..e677a75 100644

Re: [Mesa-dev] software implementation of vulkan for gsoc/evoc

2017-02-10 Thread Jacob Lifshay
I think vulkan is supposed to be reentrant already. Jacob Lifshay On Feb 10, 2017 3:38 PM, "Roland Mainz" wrote: > On Sat, Feb 11, 2017 at 12:03 AM, Jacob Lifshay > wrote: > > I would like to write a software implementation of Vulkan for

Re: [Mesa-dev] software implementation of vulkan for gsoc/evoc

2017-02-10 Thread Roland Mainz
On Sat, Feb 11, 2017 at 12:03 AM, Jacob Lifshay wrote: > I would like to write a software implementation of Vulkan for inclusion in > mesa3d. I wanted to use a tiled renderer coupled with llvm and either write > or use a whole-function-vectorization pass. Would anyone be

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Jason Ekstrand
On Fri, Feb 10, 2017 at 3:18 PM, Nanley Chery wrote: > On Fri, Feb 10, 2017 at 02:55:42PM -0800, Nanley Chery wrote: > > On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote: > > > It's a bit hard to measure because it almost gets lost in the noise, > > > but

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Jason Ekstrand
On Fri, Feb 10, 2017 at 2:55 PM, Nanley Chery wrote: > On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote: > > It's a bit hard to measure because it almost gets lost in the noise, > > but this seemed to help Dota 2 by a percent or two on my Broadwell > > GT3e

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Nanley Chery
On Fri, Feb 10, 2017 at 02:55:42PM -0800, Nanley Chery wrote: > On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote: > > It's a bit hard to measure because it almost gets lost in the noise, > > but this seemed to help Dota 2 by a percent or two on my Broadwell > > GT3e desktop. > > > >

[Mesa-dev] [PATCH 3/3] gallivm: Reenable PPC VSX (v3)

2017-02-10 Thread Ben Crocker
Reenable the PPC64LE Vector-Scalar Extension for LLVM versions >= 3.8.1, now that LLVM bug 26775 and its corollary, 25503, are fixed. Amendment: remove extraneous spaces in macro def & invocations. We would prefer a runtime check, e.g. via an LLVMQueryString (analogous to glGetString,

[Mesa-dev] [PATCH 2/3] gallivm: Override getHostCPUName() "generic" w/ "pwr8" (v4)

2017-02-10 Thread Ben Crocker
If llvm::sys::getHostCPUName() returns "generic", override it with "pwr8" (on PPC64LE). This is a work-around for a bug in LLVM: a table entry for "POWER8NVL" is missing, resulting in (big-endian) "generic" being returned on little-endian Power8NVL systems. The result is that code that attempts

[Mesa-dev] software implementation of vulkan for gsoc/evoc

2017-02-10 Thread Jacob Lifshay
I would like to write a software implementation of Vulkan for inclusion in mesa3d. I wanted to use a tiled renderer coupled with llvm and either write or use a whole-function-vectorization pass. Would anyone be willing to mentor me for this project? I would probably only need help getting it

[Mesa-dev] [PATCH] r300g: only allow byteswapped formats on big endian

2017-02-10 Thread Grazvydas Ignotas
They cause regressions on little endian. Fixes: 172bfdaa9e ("r300g: add support for PIPE_FORMAT_x8R8G8B8_*") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98869 Signed-off-by: Grazvydas Ignotas --- no commit access src/gallium/drivers/r300/r300_texture.c | 5 +

[Mesa-dev] [PATCH 1/3] gallivm: Improve debug output

2017-02-10 Thread Ben Crocker
Improve debug output from gallivm_compile_module and lp_build_create_jit_compiler_for_module, printing the -mcpu and -mattr options passed to LLC. Signed-off-by: Ben Crocker Cc: 12.0 13.0 17.0 ---

Re: [Mesa-dev] [PATCH] glsl: Actually enforce ES SSBO unsized array check for SSBOs.

2017-02-10 Thread Ilia Mirkin
Seems pretty similar to https://patchwork.freedesktop.org/patch/138274/ On Fri, Feb 10, 2017 at 5:48 PM, Kenneth Graunke wrote: > Commit b010fa85675b98962426fe8961466fbae2d25499 re-added this check > after it was erroneously dropped while fixing another bug. However, >

Re: [Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Nanley Chery
On Fri, Feb 10, 2017 at 11:02:19AM -0800, Jason Ekstrand wrote: > It's a bit hard to measure because it almost gets lost in the noise, > but this seemed to help Dota 2 by a percent or two on my Broadwell > GT3e desktop. > > Reviewed-by: Lionel Landwerlin > --- >

[Mesa-dev] [PATCH] glsl: Actually enforce ES SSBO unsized array check for SSBOs.

2017-02-10 Thread Kenneth Graunke
Commit b010fa85675b98962426fe8961466fbae2d25499 re-added this check after it was erroneously dropped while fixing another bug. However, the control flow was slightly off, and it ended up only applying to UBOs and not SSBOs. Fixes dEQP-GLES31.functional.debug.negative_coverage.

[Mesa-dev] [Bug 99517] [TRACKER] Mesa 17.0 release tracker

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99517 Bug 99517 depends on bug 99339, which changed state. Bug 99339 Summary: Blender line rendering broken after removing XY clipping of lines https://bugs.freedesktop.org/show_bug.cgi?id=99339 What|Removed |Added

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 87364, which changed state. Bug 87364 Summary: Flickering objects in Goat Simulator https://bugs.freedesktop.org/show_bug.cgi?id=87364 What|Removed |Added

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-10 Thread Timothy Arceri
Just to clarify my email, I wasn't saying shader-cache should land before this, or that we should prioritize one over the other. I was simply venting frustration that I had to keep it rebased out of tree and keep it passing piglit when it seems I didn't need too. This is nothing against this

Re: [Mesa-dev] [PATCH] tgsi: remove ureg_label_insn

2017-02-10 Thread Roland Scheidegger
Am 10.02.2017 um 20:23 schrieb Emil Velikov: > On 10 February 2017 at 19:03, Roland Scheidegger wrote: >> Sorry that I didn't catch that earlier, but I'll have to revert this. >> This is required when dealing with the TGSI_OPCODE_CAL (and >> TGSI_OPCODE_CALLNZ, albeit we don't

Re: [Mesa-dev] [PATCH V2] mesa: Add EXT_frag_depth bits and enable it on all drivers

2017-02-10 Thread Ilia Mirkin
On Fri, Feb 10, 2017 at 4:52 PM, Anuj Phogat wrote: > Passes the newly added piglit test for this extension on i965. > > V2: Fix comments by Ilia. > > Signed-off-by: Anuj Phogat > --- > src/compiler/glsl/builtin_variables.cpp | 3 +++ >

Re: [Mesa-dev] [PATCH 10/21] winsys/amdgpu: extract amdgpu_do_add_real_buffer

2017-02-10 Thread Marek Olšák
Assuming you address other people's comments, the first 10 are: Reviewed-by: Marek Olšák Marek On Wed, Feb 8, 2017 at 1:42 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > We will use it for delayed adding of sparse

[Mesa-dev] [PATCH V2] mesa: Add EXT_frag_depth bits and enable it on all drivers

2017-02-10 Thread Anuj Phogat
Passes the newly added piglit test for this extension on i965. V2: Fix comments by Ilia. Signed-off-by: Anuj Phogat --- src/compiler/glsl/builtin_variables.cpp | 3 +++ src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++

Re: [Mesa-dev] [PATCH] mesa: Add EXT_frag_depth bits and enable it on all drivers

2017-02-10 Thread Anuj Phogat
On Fri, Feb 10, 2017 at 1:38 PM, Ilia Mirkin wrote: > On Fri, Feb 10, 2017 at 4:36 PM, Anuj Phogat wrote: >> On Fri, Feb 10, 2017 at 1:21 PM, Ilia Mirkin wrote: >>> On Fri, Feb 10, 2017 at 4:15 PM, Anuj Phogat

Re: [Mesa-dev] [PATCH] mesa: Add EXT_frag_depth bits and enable it on all drivers

2017-02-10 Thread Ilia Mirkin
On Fri, Feb 10, 2017 at 4:36 PM, Anuj Phogat wrote: > On Fri, Feb 10, 2017 at 1:21 PM, Ilia Mirkin wrote: >> On Fri, Feb 10, 2017 at 4:15 PM, Anuj Phogat wrote: >>> Passes the newly added piglit test for this extension on i965.

Re: [Mesa-dev] [PATCH] mesa: Add EXT_frag_depth bits and enable it on all drivers

2017-02-10 Thread Anuj Phogat
On Fri, Feb 10, 2017 at 1:21 PM, Ilia Mirkin wrote: > On Fri, Feb 10, 2017 at 4:15 PM, Anuj Phogat wrote: >> Passes the newly added piglit test for this extension on i965. >> >> Signed-off-by: Anuj Phogat >> --- >> A quick look

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-10 Thread gregory hainaut
Hello, I ran piglit (glthread false vs true) on the Marek branch and Nouveau driver. Of course we can still debate, if piglit is good enough to detect multi threading issue. I spot a small typo that generate ~400 fails (*mat2x4* uniform got 6 scalar instead of 8). piglit status with the typo

Re: [Mesa-dev] [PATCH] mesa: Add EXT_frag_depth bits and enable it on all drivers

2017-02-10 Thread Ilia Mirkin
On Fri, Feb 10, 2017 at 4:15 PM, Anuj Phogat wrote: > Passes the newly added piglit test for this extension on i965. > > Signed-off-by: Anuj Phogat > --- > A quick look at other drivers didn't show any issues with > this new extension. Let me know if

[Mesa-dev] [PATCH] mesa: Add EXT_frag_depth bits and enable it on all drivers

2017-02-10 Thread Anuj Phogat
Passes the newly added piglit test for this extension on i965. Signed-off-by: Anuj Phogat --- A quick look at other drivers didn't show any issues with this new extension. Let me know if you think it won't work for any driver. --- docs/features.txt

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Nanley Chery
On Thu, Feb 09, 2017 at 05:32:55PM -0800, Nanley Chery wrote: > On Wed, Feb 01, 2017 at 05:43:55PM -0800, Jason Ekstrand wrote: > > This seemed to help Dota 2 by a percent or two. > > I wasn't able to reproduce this on SKL, could you qualify this with "on > BDW"? > > > --- > >

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

2017-02-10 Thread Emil Velikov
On 10 February 2017 at 21:04, Emil Velikov wrote: > Hi Samuel, > > On 10 February 2017 at 13:41, Samuel Pitoiset > wrote: >> Mesa currently doesn't allow to create 3.1+ compatibility profiles >> mainly because various features are

Re: [Mesa-dev] [RFC PATCH 1/4] driconf: add new force_compat_profile option

2017-02-10 Thread Emil Velikov
Hi Samuel, On 10 February 2017 at 13:41, Samuel Pitoiset wrote: > Mesa currently doesn't allow to create 3.1+ compatibility profiles > mainly because various features are unimplemented and bugs can > happen. > > However, some buggy apps request a compat profile without

Re: [Mesa-dev] [RFC PATCH 0/4] New drirc options for Worms WMD, Tropico 5 and Crookz

2017-02-10 Thread Kenneth Graunke
On Friday, February 10, 2017 5:45:03 AM PST Ilia Mirkin wrote: > On Fri, Feb 10, 2017 at 8:41 AM, Samuel Pitoiset > wrote: > > Hi, > > > > Mesa currently doesn't allow to create 3.1+ compatibility profiles mainly > > because various features are unimplemented and bugs

[Mesa-dev] [PATCH] radv: Fix radv_GetPhysicalDeviceQueueFamilyProperties2KHR.

2017-02-10 Thread Bas Nieuwenhuizen
The struct have different size, so the arrays have different stride. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 45 +++- 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/src/amd/vulkan/radv_device.c

[Mesa-dev] [Bug 99692] [radv] Mostly broken on Hawaii PRO/CIK ASICs

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99692 --- Comment #6 from l2055...@mvrht.com --- Can confirm the same with a 290 on Linux 4.9.8 using mesa-git, amdgpu-git. Sascha Willems' triangle demo flickers and clicking 'maximise' on the window results in this error in console: Fatal :

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Nanley Chery
On Fri, Feb 10, 2017 at 10:59:38AM -0800, Jason Ekstrand wrote: > On Thu, Feb 9, 2017 at 5:32 PM, Nanley Chery wrote: > > > On Wed, Feb 01, 2017 at 05:43:55PM -0800, Jason Ekstrand wrote: > > > This seemed to help Dota 2 by a percent or two. > > > > I wasn't able to

Re: [Mesa-dev] [PATCH v2 3/7] anv: Add support for the PMA fix on Broadwell

2017-02-10 Thread Nanley Chery
On Fri, Feb 10, 2017 at 11:02:17AM -0800, Jason Ekstrand wrote: > This helps Dota 2 on Broadwell by 8-9%. I also hacked up the driver and > used the Sascha "shadowmapping" demo to get some results. Setting > uses_kill to true dropped the framerate on the demo by 25-30%. Enabling > the PMA fix

Re: [Mesa-dev] [PATCH] tgsi: remove ureg_label_insn

2017-02-10 Thread Emil Velikov
On 10 February 2017 at 19:03, Roland Scheidegger wrote: > Sorry that I didn't catch that earlier, but I'll have to revert this. > This is required when dealing with the TGSI_OPCODE_CAL (and > TGSI_OPCODE_CALLNZ, albeit we don't actually need the latter and I don't > think

Re: [Mesa-dev] [PATCH] tgsi: remove ureg_label_insn

2017-02-10 Thread Roland Scheidegger
Err, "required" maybe isn't the right word. But nonetheless this helper simplifies translation nicely - you can just do something like ureg_label_insn(ureg, TGSI_OPCODE_CAL, 0, 0, _label); without having to worry about doing all that stuff yourself. Roland Am 10.02.2017 um 20:03 schrieb Roland

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Nanley Chery
On Fri, Feb 10, 2017 at 10:59:38AM -0800, Jason Ekstrand wrote: > On Thu, Feb 9, 2017 at 5:32 PM, Nanley Chery wrote: > > > On Wed, Feb 01, 2017 at 05:43:55PM -0800, Jason Ekstrand wrote: > > > This seemed to help Dota 2 by a percent or two. > > > > I wasn't able to

Re: [Mesa-dev] [PATCH] tgsi: remove ureg_label_insn

2017-02-10 Thread Roland Scheidegger
Sorry that I didn't catch that earlier, but I'll have to revert this. This is required when dealing with the TGSI_OPCODE_CAL (and TGSI_OPCODE_CALLNZ, albeit we don't actually need the latter and I don't think anyone implements that, since we just emit a uif/cal/endif instead). This corresponds to

[Mesa-dev] [PATCH v2 2/7] genxml: Add the CACHE_MODE_1 register on gen8

2017-02-10 Thread Jason Ekstrand
Reviewed-by: Lionel Landwerlin --- src/intel/genxml/gen8.xml | 21 + 1 file changed, 21 insertions(+) diff --git a/src/intel/genxml/gen8.xml b/src/intel/genxml/gen8.xml index 970e637..32ed764 100644 --- a/src/intel/genxml/gen8.xml +++

[Mesa-dev] [PATCH v2 4/7] anv/pipeline: Make a copy of VkPipelineDepthStencilStateCreateinfo

2017-02-10 Thread Jason Ekstrand
Reviewed-by: Lionel Landwerlin Reviewed-by: Nanley Chery --- src/intel/vulkan/genX_pipeline.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c

[Mesa-dev] [PATCH v2 7/7] anv: Implement the Skylake stencil PMA optimization

2017-02-10 Thread Jason Ekstrand
This improves the performance of Dota 2 on my Sky Lake Skull Canyon machine by about 2-3%. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/gen8_cmd_buffer.c | 157 -

[Mesa-dev] [PATCH v2 3/7] anv: Add support for the PMA fix on Broadwell

2017-02-10 Thread Jason Ekstrand
This helps Dota 2 on Broadwell by 8-9%. I also hacked up the driver and used the Sascha "shadowmapping" demo to get some results. Setting uses_kill to true dropped the framerate on the demo by 25-30%. Enabling the PMA fix brought it back up to around 90% of the original framerate. Reviewed-by:

[Mesa-dev] [PATCH v2 6/7] genxml: Add the CACHE_MODE_0 register on gen9

2017-02-10 Thread Jason Ekstrand
Reviewed-by: Lionel Landwerlin --- src/intel/genxml/gen9.xml | 28 1 file changed, 28 insertions(+) diff --git a/src/intel/genxml/gen9.xml b/src/intel/genxml/gen9.xml index 671322b..ec29d13 100644 --- a/src/intel/genxml/gen9.xml +++

[Mesa-dev] [PATCH v2 1/7] anv: Disable stencil writes when both write masks are zero

2017-02-10 Thread Jason Ekstrand
Vulkan doesn't have a stencilWriteEnable bit like it does for depth. Instead, you have a stencil mask. Since the stencil mask is handled as dynamic state, we have to handle it later during command buffer construction. This, combined with a later commit, seems to help Dota2 on my Broadwell GT3e

[Mesa-dev] [PATCH v2 5/7] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Jason Ekstrand
It's a bit hard to measure because it almost gets lost in the noise, but this seemed to help Dota 2 by a percent or two on my Broadwell GT3e desktop. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/genX_pipeline.c | 171 +++

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Be smarter about depth/stencil state

2017-02-10 Thread Jason Ekstrand
On Thu, Feb 9, 2017 at 5:32 PM, Nanley Chery wrote: > On Wed, Feb 01, 2017 at 05:43:55PM -0800, Jason Ekstrand wrote: > > This seemed to help Dota 2 by a percent or two. > > I wasn't able to reproduce this on SKL, could you qualify this with "on > BDW"? > I've changed it

Re: [Mesa-dev] [PATCHv3 09/20] i965/fs: Get 64-bit indirect moves working on IVB.

2017-02-10 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On Thu, 2017-02-09 at 10:16 -0800, Francisco Jerez wrote: >> --- >> This replaces "[PATCH v2 09/20] i965/fs: indirect addressing with >> doubles is not supported in IVB/BYT". >> >> src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 27 >>

Re: [Mesa-dev] [PATCHv3 09/20] i965/fs: Get 64-bit indirect moves working on IVB.

2017-02-10 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On Thu, 2017-02-09 at 18:28 -0800, Francisco Jerez wrote: >> Francisco Jerez writes: >> >> > --- >> > This replaces "[PATCH v2 09/20] i965/fs: indirect addressing with >> > doubles is not supported in IVB/BYT". >>

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-10 Thread Andy Furniss
Nayan Deshmukh wrote: Hi Andy, I am attaching the patches. Does it cause any difference in the corruption in this video? https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s Hi, it seems mpv and ffmpeg have been changing their vaapi code recently. With an old mpv the

Re: [Mesa-dev] [PATCH] radv: reduce CPU overhead merging bo lists.

2017-02-10 Thread Bas Nieuwenhuizen
Was thinking of a sort or other asymptotically more efficient merge method, but in the meantime this is Reviewed-by: Bas Nieuwenhuizen On Fri, Feb 10, 2017, at 02:07, Dave Airlie wrote: > From: Dave Airlie > > Just noticed we do a fair bit of

Re: [Mesa-dev] [PATCH] radv: detect command buffers that do no work and drop them

2017-02-10 Thread Bas Nieuwenhuizen
On Fri, Feb 10, 2017, at 05:25, Dave Airlie wrote: > From: Dave Airlie > > If a buffer is just full of flushes we flush things on command > buffer submission, so don't bother submitting these. > > This will reduce some CPU overhead on dota2, which submits a fair > few

Re: [Mesa-dev] [PATCH v2 09/20] i965/fs: indirect addressing with doubles is not supported in IVB/BYT

2017-02-10 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > On Thu, 2017-02-09 at 12:18 -0800, Francisco Jerez wrote: >> Samuel Iglesias Gonsálvez writes: >> >> > It is tested empirically that IVB/BYT don't support indirect >> > addressing >> > with doubles but it is not

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] gallivm: Override getHostCPUName() "generic" w/ "pwr8" (v3)

2017-02-10 Thread Ben Crocker
Hi Emil, Thanks for the feedback, and I agree. I'm adding such a comment now. -- Ben - Original Message - From: "Emil Velikov" To: "Ben Crocker" Cc: "ML mesa-dev" , "12.0 13.0 17.0"

Re: [Mesa-dev] [PATCH 14/26] mesa: Connect the generated GL command marshalling code to the build.

2017-02-10 Thread Steven Newbury
On Fri, 2017-02-10 at 17:15 +, Emil Velikov wrote: > On 8 February 2017 at 18:03, Marek Olšák wrote: > > From: Eric Anholt > > > > v2: Rebase on the Begin/End changes, and just disable this feature > > on > > non-GL-core. > > --- > >  

[Mesa-dev] [PATCH] anv: wsi: report presentation error per image request

2017-02-10 Thread Lionel Landwerlin
vkQueuePresentKHR() takes VkPresentInfoKHR pointer and includes a pResults fields which must holds the results of all the images requested to be presented. Currently we're not filling this field. Also as a side effect we probably want to go through all the images rather than stopping on the first

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-10 Thread Nayan Deshmukh
Hi Andy, I am attaching the patches. Does it cause any difference in the corruption in this video? https://drive.google.com/drive/folders/0BxP5-S1t9VEEbkR4dWhTUFozV2s Regards, Nayan On Fri, Feb 10, 2017 at 11:15 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: >

[Mesa-dev] [Bug 99692] [radv] Mostly broken on Hawaii PRO/CIK ASICs

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99692 --- Comment #5 from Luke A. Guest --- I haven't tried it in months as I've been using teh amdgpu-pro stack due to the same rendering issues on my R9 390, I did inform dave and baz about it then. -- You are receiving this

[Mesa-dev] [Bug 99764] Make OpenMM OpenCL support work on Clover and RadeonSI

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99764 Vedran Miletić changed: What|Removed |Added Component|Drivers/Vulkan/radeon

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

2017-02-10 Thread Andy Furniss
Nayan Deshmukh wrote: Any ideas why? I am attaching the diff for reference. Could be that the shader based decoder has a bug with multiple slices as well. It could be. Andy can you test it with your hardware decoder to see if its specific to shader decoder. Can you re-send or attach

Re: [Mesa-dev] [PATCH 06/26] egl: Implement __DRI_BACKGROUND_CALLABLE

2017-02-10 Thread Emil Velikov
On 10 February 2017 at 17:13, Marek Olšák wrote: > Yes, the egl stuff is untested. We can drop it if needed. We mainly need GLX > support for now. > In that case I'm leaning towards dropping it for now. As we get bug/crashes parity between glthreaded and !glthreaded on GLX we

Re: [Mesa-dev] Allow linear texture allocation for eglCreateDRMImageMESA

2017-02-10 Thread Eric Engestrom
On Friday, 2017-02-10 09:27:51 +0100, Volker Vogelhuber wrote: > Hi, > I'm currently try to stream video data to an OpenGL texture. > While using the EGL_DRM_BUFFER_USE_SCANOUT_MESA flag > when creating the memory for the texture makes it at least > a bit easier (only X-tiling instead of Y-tiling

Re: [Mesa-dev] [PATCH 25/26] st/dri: random cleanups

2017-02-10 Thread Emil Velikov
On 8 February 2017 at 18:03, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/state_trackers/dri/dri_drawable.c | 11 +++ > src/gallium/state_trackers/dri/dri_screen.c | 8 +--- > 2 files changed, 12 insertions(+), 7 deletions(-)

Re: [Mesa-dev] [PATCH 14/26] mesa: Connect the generated GL command marshalling code to the build.

2017-02-10 Thread Emil Velikov
On 8 February 2017 at 18:03, Marek Olšák wrote: > From: Eric Anholt > > v2: Rebase on the Begin/End changes, and just disable this feature on > non-GL-core. > --- > src/mapi/glapi/gen/gl_marshal.py | 10 ++ > src/mesa/Makefile.sources| 2

Re: [Mesa-dev] [PATCH] loader: unconditionally include unistd.h and stdlib.h

2017-02-10 Thread Eric Engestrom
On Thursday, 2017-02-09 22:10:00 +, Emil Velikov wrote: > From: Nicolai Hähnle > > Otherwise we would fail with "implicit declaration of function" geteuid > and getenv respectively. > > To trigger (re)move the libdrm.pc file and use the following: > > $

[Mesa-dev] [Bug 99692] [radv] Mostly broken on Hawaii PRO/CIK ASICs

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99692 --- Comment #4 from Luzipher --- The Radeon R9 290X (Hawaii XT) is affected by this as well (on today's mesa master). -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

Re: [Mesa-dev] [PATCH 06/26] egl: Implement __DRI_BACKGROUND_CALLABLE

2017-02-10 Thread Marek Olšák
On Feb 10, 2017 5:55 PM, "Emil Velikov" wrote: On 8 February 2017 at 18:03, Marek Olšák wrote: > +const __DRIbackgroundCallableExtension background_callable_extension = { > + { __DRI_BACKGROUND_CALLABLE, __DRI_BACKGROUND_CALLABLE_VERSION }, > +

Re: [Mesa-dev] [PATCH 11/26] mesa: Add infrastructure for a worker thread to process GL commands.

2017-02-10 Thread Emil Velikov
On 8 February 2017 at 18:03, Marek Olšák wrote: > From: Eric Anholt > > v2: Keep an allocated buffer around instead of checking for one at the > start of every GL command. Inline the now-small space allocation > function. > v3: Remove duplicate

Re: [Mesa-dev] [PATCH 07/26] glapi: Annotate functions with "marshal" attribute.

2017-02-10 Thread Emil Velikov
On 8 February 2017 at 18:03, Marek Olšák wrote: > From: Paul Berry > > Several API functions require special treatment in order to be marshalled > to a background thread. Others can't be safely executed in a background > thread and need to be executed

Re: [Mesa-dev] [PATCH v2 15/20] i965/vec4: consider subregister offset in live variables

2017-02-10 Thread Juan A. Suarez Romero
On Thu, 2017-02-09 at 15:56 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > From: "Juan A. Suarez Romero" > > > > Take in account the offset value when getting the var from register. > > > > This is required when dealing with an

Re: [Mesa-dev] [PATCH 06/26] egl: Implement __DRI_BACKGROUND_CALLABLE

2017-02-10 Thread Emil Velikov
On 8 February 2017 at 18:03, Marek Olšák wrote: > +const __DRIbackgroundCallableExtension background_callable_extension = { > + { __DRI_BACKGROUND_CALLABLE, __DRI_BACKGROUND_CALLABLE_VERSION }, > + dri_set_background_context, Similar to the GLX patch - 1 + C99 initializers.

Re: [Mesa-dev] [PATCH 05/26] glx: Implement __DRI_BACKGROUND_CALLABLE (v2)

2017-02-10 Thread Emil Velikov
On 8 February 2017 at 18:03, Marek Olšák wrote: > From: Paul Berry > > v2: Marek: Add DRI3 support. > --- > src/glx/dri2_glx.c | 16 +++- > src/glx/dri3_glx.c | 13 + > 2 files changed, 28 insertions(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH] util/disk_cache: use stat() to check if entry is a directory

2017-02-10 Thread Jan Ziak
Hello Mesa should check that return value of stat() equals 0. if (stat_retval == 0 && !S_ISREG(sb.st_mode)) return false; ... if (stat_retval == 0 && !S_ISDIR(sb.st_mode)) return false; Jan ___ mesa-dev mailing list

[Mesa-dev] [Bug 99764] Make OpenMM OpenCL support work on Clover and RadeonSI

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99764 Vedran Miletić changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |ved...@miletic.net

[Mesa-dev] [Bug 99764] Make OpenMM OpenCL support work on Clover and RadeonSI

2017-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99764 Bug ID: 99764 Summary: Make OpenMM OpenCL support work on Clover and RadeonSI Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

[Mesa-dev] 24 hour period until Mesa 17.0.0 final

2017-02-10 Thread Emil Velikov
Hi all, I've just updated the 17.0 branch with what is planned to be Mesa 17.0.0. As requested in the past, we're going to have ~24 hour period for people to double-check their respective platforms. If you have some patches that must land and cannot wait for 17.0.1 let me know by replying to

Re: [Mesa-dev] [PATCH 38/40] st/mesa: implement a tgsi on-disk shader cache

2017-02-10 Thread Marek Olšák
On Tue, Feb 7, 2017 at 4:42 AM, Timothy Arceri wrote: > Implements a tgsi cache for the OpenGL state tracker. > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 217 > + > src/mesa/state_tracker/st_program.c| 133 +- >

Re: [Mesa-dev] [PATCH 05/40] glsl: add initial implementation of shader cache

2017-02-10 Thread Emil Velikov
FYI: There's a series which drops the return argument of _mesa_sha1_format (amongst others). That one is not reviewed yet, yet even now one could still use _mesa_sha1_format(foo...); printf("%s\n", foo); -Emil ___ mesa-dev mailing list

  1   2   3   >