Re: [Mesa-dev] [PATCH v2 1/3] i965/fs: fix indirect load DF uniforms on BSW/BXT

On Sat, 2017-02-18 at 18:58 -0800, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > The lowered BSW/BXT indirect move instructions had incorrect > > source types, which luckily wasn't causing incorrect assembly to be > > generated due to the bug fixed in the

Re: [Mesa-dev] [PATCH mesa] egl/dri3: implement query surface hook

Hi; On 02/17/2017 05:12 PM, Eric Engestrom wrote: From: Brendan King This is a DRI3 version of a change made for DRI2 (4d6d4f939e0af4252e0b, "egl/dri2: implement query surface hook"), that fixed failures in dEQP-EGL.functional.resize.surface_size.grow and

Re: [Mesa-dev] [PATCH 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

On 20/02/17 15:38, Edward O'Callaghan wrote: On 02/20/2017 11:15 AM, Timothy Arceri wrote: --- src/gallium/drivers/r600/r600_pipe.c | 19 +++ src/gallium/drivers/radeon/r600_pipe_common.c | 8 +++- src/gallium/drivers/radeon/r600_pipe_common.h | 5 +

Re: [Mesa-dev] [PATCH 1/2] isl: Return surface creation success from aux helpers

On Fri, Feb 17, 2017 at 04:03:48PM -0800, Jason Ekstrand wrote: > The isl_surf_init call that each of these helpers make can, in theory, > fail. We should propagate that up to the caller rather than just > silently ignoring it. Reviewed-by: Topi Pohjolainen > --- >

Re: [Mesa-dev] [PATCH] radv: handle subpass cache flushes

Reviewed-by: Edward O'Callaghan On 02/20/2017 04:17 PM, Dave Airlie wrote: > From: Dave Airlie > > This splits out the cache flush bit setting code > dependent on the src/dest access flags. > > It then calls it from the subpass barrier code. >

[Mesa-dev] [PATCH] radv: handle subpass cache flushes

From: Dave Airlie This splits out the cache flush bit setting code dependent on the src/dest access flags. It then calls it from the subpass barrier code. It also marks a TODO to remove the aggressive CS/PS flushes at some point. This fixes a bunch of the

Re: [Mesa-dev] [PATCH 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

On 02/20/2017 11:15 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/r600/r600_pipe.c | 19 +++ > src/gallium/drivers/radeon/r600_pipe_common.c | 8 +++- > src/gallium/drivers/radeon/r600_pipe_common.h | 5 + > src/gallium/drivers/radeonsi/si_pipe.c

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: add support to detect if we can support rendering (v3)

On Feb 19, 2017 2:33 PM, "Dave Airlie" wrote: From: Dave Airlie This adds support to radv_GetPhysicalDeviceXlibPresentationSupportKHR and radv_GetPhysicalDeviceXcbPresentationSupportKHR to check if the local device file descriptor is compatible with the

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: add support to detect if we can support rendering (v3)

tic bool > +wsi_x11_check_dri3_compatible(xcb_connection_t *conn, int local_fd) > +{ > + xcb_screen_iterator_t screen_iter = > + xcb_setup_roots_iterator(xcb_get_setup(conn)); > + xcb_screen_t *screen = screen_iter.data; > + > + int dri3_fd = wsi_dri3_open(conn, screen->root, None); > +

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: add support to detect if we can support rendering (v3)

On Feb 19, 2017 2:33 PM, "Dave Airlie" wrote: From: Dave Airlie This adds support to radv_GetPhysicalDeviceXlibPresentationSupportKHR and radv_GetPhysicalDeviceXcbPresentationSupportKHR to check if the local device file descriptor is compatible with the

Re: [Mesa-dev] [PATCH] mesa/blit: only error when the stencil and depth bits do not match (v3)

On Sun, Feb 19, 2017 at 6:11 AM, Max Qian wrote: > This fixes some situations where glBlitFrameBuffer would error in Mesa, glBlitFramebuffer > but wouldn't error in other drivers (e.g Nvidia) Please be descriptive here. What situations does this fix? Also, there's not a

[Mesa-dev] [PATCH 1/4] util/radv: move *_get_function_timestamp() to utils

V2: The functions we are now sharing used different return values update the callers to reflect the new common api. --- src/amd/vulkan/radv_device.c | 22 +++--- src/util/disk_cache.h| 17 + 2 files changed, 20 insertions(+), 19 deletions(-) diff --git

[Mesa-dev] [PATCH 4/4] r600/radeonsi: enable glsl/tgsi on-disk cache

--- src/gallium/drivers/r600/r600_pipe.c | 19 +++ src/gallium/drivers/radeon/r600_pipe_common.c | 8 +++- src/gallium/drivers/radeon/r600_pipe_common.h | 5 + src/gallium/drivers/radeonsi/si_pipe.c| 19 +++

[Mesa-dev] [PATCH 2/4] st/mesa: implement a tgsi on-disk shader cache

Implements a tgsi cache for the OpenGL state tracker. V2: add support for compute shaders --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 222 + src/mesa/state_tracker/st_program.c| 133 - 2 files changed, 350 insertions(+), 5 deletions(-)

[Mesa-dev] [PATCH 3/4] gallium: add disk_cache_create() callback

--- src/gallium/include/pipe/p_screen.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index b6203f1..43dcdf0 100644 --- a/src/gallium/include/pipe/p_screen.h +++ b/src/gallium/include/pipe/p_screen.h @@ -58,6

[Mesa-dev] V3 TGSI on-disk shader cache

Changes in V3: - split out change to pipe_screen into its own patch, and rework enablement patch. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR

On Sunday, 2017-02-19 18:54:51 -0500, Ilia Mirkin wrote: > On Sun, Feb 19, 2017 at 6:51 PM, Eric Engestrom wrote: > > On Sunday, 2017-02-19 18:33:16 -0500, Ilia Mirkin wrote: > >> Why are patches 1-3 necessary? > > > > They allow patch #4, which makes use of a macro to simplify

Re: [Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR

On Sun, Feb 19, 2017 at 6:51 PM, Eric Engestrom wrote: > On Sunday, 2017-02-19 18:33:16 -0500, Ilia Mirkin wrote: >> Why are patches 1-3 necessary? > > They allow patch #4, which makes use of a macro to simplify the list, > (requires a 1:1 mapping of entrypoint to function)

Re: [Mesa-dev] [PATCH mesa 8/8] eglapi: replace linear entrypoint search with binary search

On Sunday, 2017-02-19 15:38:05 -0800, Matt Turner wrote: > On Sun, Feb 19, 2017 at 3:23 PM, Eric Engestrom wrote: > > Tested with dEQP-EGL.functional.get_proc_address.* > > > > Signed-off-by: Eric Engestrom > > --- > > src/egl/main/eglapi.c | 37

Re: [Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR

On Sunday, 2017-02-19 18:33:16 -0500, Ilia Mirkin wrote: > Why are patches 1-3 necessary? They allow patch #4, which makes use of a macro to simplify the list, (requires a 1:1 mapping of entrypoint to function) which also allows for the simple sorting test script in patch #7. I could do without,

Re: [Mesa-dev] [PATCH mesa 8/8] eglapi: replace linear entrypoint search with binary search

On Sun, Feb 19, 2017 at 3:23 PM, Eric Engestrom wrote: > Tested with dEQP-EGL.functional.get_proc_address.* > > Signed-off-by: Eric Engestrom > --- > src/egl/main/eglapi.c | 37 - > 1 file changed, 24 insertions(+), 13

Re: [Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR

Why are patches 1-3 necessary? On Sun, Feb 19, 2017 at 6:23 PM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > src/egl/main/eglapi.c | 31 --- > 1 file changed, 24 insertions(+), 7 deletions(-) > > diff --git

[Mesa-dev] [PATCH mesa 4/8] eglapi: use macro to map entrypoints to functions

As of the last 3 commits, there's a function for each entrypoint. Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 149 +- 1 file changed, 75 insertions(+), 74 deletions(-) diff --git a/src/egl/main/eglapi.c

[Mesa-dev] [PATCH mesa 5/8] eglapi: sort list

Let's make that comment true. If will also be necessary in a couple commits (using bsearch). Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 74 +-- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git

[Mesa-dev] [PATCH mesa 8/8] eglapi: replace linear entrypoint search with binary search

Tested with dEQP-EGL.functional.get_proc_address.* Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index

[Mesa-dev] [PATCH mesa 7/8] eglapi: make sure list is always sorted

Starting with the next commit, badly sorting this list will break the eglGetProcAddress(). Signed-off-by: Eric Engestrom --- src/egl/Makefile.am | 3 ++- src/egl/egl-entrypoint-check | 4 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100755

[Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR

Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index e149c0f8d1..e44375a106 100644 --- a/src/egl/main/eglapi.c +++

[Mesa-dev] [PATCH mesa 1/8] eglapi: add entrypoint for eglDestroyImageKHR

Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index cab05c2301..251855cc3b 100644 --- a/src/egl/main/eglapi.c +++

[Mesa-dev] [PATCH mesa 2/8] eglapi: add entrypoint for eglDestroySyncKHR

Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 251855cc3b..e149c0f8d1 100644 --- a/src/egl/main/eglapi.c +++

[Mesa-dev] [PATCH mesa 6/8] eglapi: move list out to its own file

This will allow us to make sure the list is always sorted in the next commit. Signed-off-by: Eric Engestrom --- src/egl/main/eglapi.c | 78 +- src/egl/main/eglentrypoint.def | 77 + 2

[Mesa-dev] [PATCH] mesa: remove unused variable warning in release builds

This assert might have made sense before but we no longer use gl_linked_shader here. Unless the caller has really done something crazy this assert is fairly useless. We also do some small tidy ups in this change. --- src/mesa/main/uniforms.c | 9 ++--- 1 file changed, 2 insertions(+), 7

Re: [Mesa-dev] [PATCH] Revert "radv: detect command buffers that do no work and drop them (v2)"

Reviewed-by: Bas Nieuwenhuizen On Sun, Feb 19, 2017 at 11:48 PM, Dave Airlie wrote: > From: Dave Airlie > > This just keeps popping up minor problems and regressions we should > revisit in a more sustainable manner later. > >

[Mesa-dev] [PATCH] Revert "radv: detect command buffers that do no work and drop them (v2)"

From: Dave Airlie This just keeps popping up minor problems and regressions we should revisit in a more sustainable manner later. This also reverts: Revert "radv: query cmds should mark a cmd buffer as having draws." Revert "radv: also fixup event emission to not get

[Mesa-dev] [PATCH] vulkan/wsi/x11: add support to detect if we can support rendering (v3)

From: Dave Airlie This adds support to radv_GetPhysicalDeviceXlibPresentationSupportKHR and radv_GetPhysicalDeviceXcbPresentationSupportKHR to check if the local device file descriptor is compatible with the descriptor retrieved from the X server via DRI3. This will stop

[Mesa-dev] [PATCH] vulkan/wsi/x11: add support to detect if we can support rendering (v2)

From: Dave Airlie This adds support to radv_GetPhysicalDeviceXlibPresentationSupportKHR and radv_GetPhysicalDeviceXcbPresentationSupportKHR to check if the local device file descriptor is compatible with the descriptor retrieved from the X server via DRI3. This will stop

Re: [Mesa-dev] [PATCH] radv: fix common extensions getting registered twice.

On 20 February 2017 at 07:06, Bas Nieuwenhuizen wrote: > On Sun, Feb 19, 2017 at 9:56 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> physical devices can be enumerated multiple time per instance, >> this was causing the

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: add support to detect if we can support rendering

> @@ -270,6 +318,25 @@ VkBool32 > wsi_get_physical_device_xcb_presentation_support( >return false; > } > > + xcb_screen_iterator_t screen_iter = > + xcb_setup_roots_iterator(xcb_get_setup(connection)); > + xcb_screen_t *screen = screen_iter.data; > + > + char *local_dev =

Re: [Mesa-dev] [PATCH] vulkan/wsi/x11: add support to detect if we can support rendering

On Feb 18, 2017 9:48 PM, "Dave Airlie" wrote: From: Dave Airlie This adds support to radv_GetPhysicalDeviceXlibPresentationSupportKHR and radv_GetPhysicalDeviceXcbPresentationSupportKHR to check if the local device file descriptor is compatible with the

Re: [Mesa-dev] [PATCH] radv: fix common extensions getting registered twice.

On Sun, Feb 19, 2017 at 9:56 PM, Dave Airlie wrote: > From: Dave Airlie > > physical devices can be enumerated multiple time per instance, > this was causing the realloc to be hit for no reason, and > the CTS allocation verification would get angry. We

[Mesa-dev] [PATCH] radv: fix common extensions getting registered twice.

From: Dave Airlie physical devices can be enumerated multiple time per instance, this was causing the realloc to be hit for no reason, and the CTS allocation verification would get angry. We'd also be allocating common extensions onto the list each time for no reason. This

[Mesa-dev] [PATCH] winsys/amdgpu: reduce max_alloc_size based on GTT limits

From: Nicolai Hähnle Allocating huge buffers in VRAM is not a problem, but when those buffers start being migrated, the kernel runs into errors because it cannot split those buffer up for moving through GTT. This should fix intermittent failures of

[Mesa-dev] [Bug 99863] [llvmpipe] gtkopengl rendering glitches

https://bugs.freedesktop.org/show_bug.cgi?id=99863 Bug ID: 99863 Summary: [llvmpipe] gtkopengl rendering glitches Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH 2/6] radeonsi: skip LDS stores in TCS if there are no LDS output reads

From: Marek Olšák This removes a lot of useless LDS stores. A few games read TESSINNER/OUTER, but not any other outputs. Most games don't read any outputs. The only app doing LDS output reads is UE4 Lightsroom Interior. --- src/gallium/drivers/radeonsi/si_shader.c | 17

[Mesa-dev] [PATCH 4/6] gallivm: add no-signed-zeros-fp-math option to lp_create_builder (v2)

From: Marek Olšák v2: define lp_float_mode --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 15 --- src/gallium/auxiliary/gallivm/lp_bld_misc.h | 8 +++- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 6 +- 3 files changed, 24

[Mesa-dev] [PATCH 3/6] radeonsi: skip TESSINNER/OUTER offchip stores if TES doesn't read them

From: Marek Olšák We were unconditionally storing these outputs, sometimes even one component at a time, but apps never read them in TES. Move the TESSINNER/OUTER buffer stores into the TCS epilog where we can easily disable them on demand. ---

[Mesa-dev] [PATCH 1/6] tgsi/scan: add basic info about tessellation OUT and IN uses

From: Marek Olšák not all of them will be used immediately --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 26 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 8 2 files changed, 34 insertions(+) diff --git

[Mesa-dev] [PATCH 6/6] radeonsi: fix issues with monolithic shaders

From: Marek Olšák R600_DEBUG=mono has had no effect since: commit 1fabb297177069e95ec1bb7053acb32f8ec3e092 Author: Marek Olšák Date: Tue Feb 14 22:08:32 2017 +0100 radeonsi: have separate LS and ES main shader parts in the shader

[Mesa-dev] [PATCH 5/6] radeonsi: set no-signed-zeros-fp-math

From: Marek Olšák Recommended by Matt Arsenault. 46757 shaders in 28742 tests Totals: SGPRS: 2068851 -> 2066907 (-0.09 %) VGPRS: 1604056 -> 1602676 (-0.09 %) Spilled SGPRs: 1402 -> 1382 (-1.43 %) Spilled VGPRs: 113 -> 113 (0.00 %) Private memory VGPRs: 1332 -> 1332 (0.00 %)

Re: [Mesa-dev] [PATCH 1/4] anv: remove unused anv_dispatch_table dtable

Patches 1-3 are: Reviewed-by: Eduardo Lima Mitev I would let somebody else look at patch 4 because I'm not very familiar with entrypoints generation scripts. cheers, Eduardo On 02/19/2017 12:49 PM, Emil Velikov wrote: > Fixes: 4c9dec80ede ("anv: Get rid of the ANV_CALL

[Mesa-dev] [PATCH] radv: Handle VK_REMAINING_ARRAY_LAYERS in fast clear eliminate.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_meta_fast_clear.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c index 0902c455037..ffaa9a3d5e8 100644 ---

[Mesa-dev] [PATCH 3/4] radv: make radv_resolve_entrypoint static

Used only within the generated source file. Fixes: 12301c54186 ("radv: drop the RADV_CALL macro.") Signed-off-by: Emil Velikov --- src/amd/vulkan/radv_entrypoints_gen.py | 2 +- src/amd/vulkan/radv_private.h | 1 - 2 files changed, 1 insertion(+), 2

[Mesa-dev] [PATCH 2/4] radv: remove unused radv_dispatch_table dtable

Fixes: 12301c54186 ("radv: drop the RADV_CALL macro.") Signed-off-by: Emil Velikov --- src/amd/vulkan/radv_device.c | 1 - src/amd/vulkan/radv_private.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 1/4] anv: remove unused anv_dispatch_table dtable

Fixes: 4c9dec80ede ("anv: Get rid of the ANV_CALL macro") Signed-off-by: Emil Velikov --- src/intel/vulkan/anv_device.c | 2 -- src/intel/vulkan/anv_private.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH 4/4] radv/entrypoints: Only generate entrypoints for supported features

This changes the way radv_entrypoints_gen.py works from generating a table containing every single entrypoint in the XML to just the ones that we actually need. There's no reason for us to burn entrypoint table space on a bunch of NV extensions we never plan to implement. RADV implements

[Mesa-dev] [PATCH] mesa/blit: only error when the stencil and depth bits do not match (v3)

This fixes some situations where glBlitFrameBuffer would error in Mesa, but wouldn't error in other drivers (e.g Nvidia) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97921 v2 : fix unintentional line removal v3 : author correction, add commit message, and change the error message ---

Re: [Mesa-dev] [PATCH] blit : only error when the stencil and depth bits do not match (v2)

Yes, that's correct. Mesa was throwing errors for glBlitFramebuffer in the same situations other (e.g nvidia) drivers weren't, causing artifacting for some applications (e.g wine). The bugzilla link has a test apitrace for it. I'll work on the commit and post the revision when I'm done.

Re: [Mesa-dev] [PATCH] vulkan/wsi: Improve the DRI3 error message

Jason Ekstrand wrote on 19.02.2017 06:01: > On Feb 18, 2017 12:37 PM, "Kai Wasserbäch" > wrote: > > Hey Jacob, > sorry for not spotting this the first time, but I have an additional > comment. > Please see below. > > Jacob Lifshay wrote on 18.02.2017 18:48:> This

Re: [Mesa-dev] [PATCH] blit : only error when the stencil and depth bits do not match (v2)

Hi Max, can you explain a bit more about the error you're seeing? It looks like the actual functional change is that previously an INVALID_OPERATION error was generated when /mask/ includes DEPTH_BUFFER_BIT but either source or destination had no depth buffer, and with your change no error

Re: [Mesa-dev] [PATCH 2/2] radv: handle layered fast clears.

Series is Reviewed-by: Bas Nieuwenhuizen On Sun, Feb 19, 2017 at 7:33 AM, Dave Airlie wrote: > From: Dave Airlie > > This iterates the fast clear flush across the layers in the > specified range. > > It also moves the compute

Re: [Mesa-dev] [PATCH] radv: fix type in a2b10g10r10 fast clear calculation.

Reviewed-by: Bas Nieuwenhuizen On Sun, Feb 19, 2017 at 7:38 AM, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > dEQP-VK.renderpass.formats.a2b10g10r10_unorm_pack32* > regressions. > > Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH 5/5] gallium: remove PIPE_CAP_USER_INDEX_BUFFERS

On 17.02.2017 11:27, Marek Olšák wrote: From: Marek Olšák all drivers support it Patches 4 & 5: Reviewed-by: Nicolai Hähnle 1-3 look good to me as well, but I'd wait for feedback from the corresponding driver authors. ---

Re: [Mesa-dev] [PATCH] ac/llvm: fix various findMSB bugs

On 17.02.2017 14:26, Marek Olšák wrote: From: Marek Olšák sffbh needs to be suffixed with ".i32" Reviewed-by: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] gallium/u_index_modify: don't add PIPE_TRANSFER_UNSYNCHRONIZED unconditionally

On 17.02.2017 13:10, Marek Olšák wrote: From: Marek Olšák It's OK for r300g (because r300g can't write to buffers via the GPU), but not later hardware. This issue was spotted randomly. Cc: mesa-sta...@lists.freedesktop.org Both patches: Reviewed-by: Nicolai Hähnle