[Mesa-dev] [PATCH] egl: fix android logger compilation

this patch is a partial revert of 1ce5853 that break compilation since LOG_ERROR etc are not defined and also macro expansion won't work as planned (expands to 'ANDROID_egl2alog[level]') Fixes: 1ce5853 ("egl: simplify the Android logger") Signed-off-by: Tapani Pälli ---

[Mesa-dev] [PATCH] mesa: fix KHR_no_error SSO support

Fixes: 00c5119a5e821 ("mesa: add KHR_no_error support for glUseProgramStages()") --- Found with the new no_error piglit profile [1]. Up until now my testing has been adhoc, selecting a few tests that take the new KHR_no_error path. Going forward testing should be more thorough once tests are

Re: [Mesa-dev] [PATCH 4/4] intel/isl: Refactor gen8_choose_image_alignment_el

On Wed 10 May 2017, Jason Ekstrand wrote: > --- > src/intel/isl/isl_gen8.c | 193 > +-- > 1 file changed, 53 insertions(+), 140 deletions(-) > + /* For all other formats, the alignment is determined by the horizontal > and > +* vertical

[Mesa-dev] [PATCH 3/7] mesa: add KHR_no_error support for CompressedTex*SubImage1D()

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/teximage.c | 49 +- src/mesa/main/teximage.h | 11 ++ 4 files changed, 53 insertions(+), 11

[Mesa-dev] [PATCH 1/7] mesa: make _mesa_compressed_texture_sub_image() static

--- src/mesa/main/teximage.c | 69 +--- src/mesa/main/teximage.h | 12 - 2 files changed, 30 insertions(+), 51 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 1a00d25..2486704 100644 ---

[Mesa-dev] [PATCH 7/7] mesa: add KHR_no_error support for glCompressedTex*SubImage3D()

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 3 ++- src/mesa/main/teximage.c | 28 +- src/mesa/main/teximage.h | 14 + 4 files changed, 44

[Mesa-dev] [PATCH 4/7] mesa: add 2D support to compressed_tex_sub_image() helper

--- src/mesa/main/teximage.c | 83 ++-- 1 file changed, 16 insertions(+), 67 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 722d880..718af57 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@

[Mesa-dev] [PATCH 2/7] mesa: add compressed_tex_sub_image() helper

This reduces duplication between the dsa and non-dsa function and will also be used in the following commit to add KHR_no_error support. --- src/mesa/main/teximage.c | 82 ++-- 1 file changed, 38 insertions(+), 44 deletions(-) diff --git

[Mesa-dev] [PATCH 6/7] mesa: add 3D support to compressed_tex_sub_image() helper

--- src/mesa/main/teximage.c | 185 +-- 1 file changed, 66 insertions(+), 119 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 887740a..2f9ff30 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@

[Mesa-dev] [PATCH 5/7] mesa: add KHR_no_error support for glCompressedTex*SubImage2D()

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 3 ++- src/mesa/main/teximage.c | 27 ++ src/mesa/main/teximage.h | 12 4 files changed, 42 insertions(+),

Re: [Mesa-dev] [PATCH 3/4] intel/isl: Refactor gen6_choose_image_alignment_el

On Thu 11 May 2017, Jason Ekstrand wrote: > On Thu, May 11, 2017 at 7:03 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Wed, May 10, 2017 at 02:30:31PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/isl/isl_gen6.c | 30 -- > > > 1 file

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

Thanks, Emil dEQP has patch to exclude 565 blend cases (commit named "Exclude RGB565 blending cases from the must-pass"), so we don’t need any patches now. Thanks, Randy > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, May 11, 2017 8:55 PM

Re: [Mesa-dev] [PATCH 2/4] intel/isl: Refactor gen7_choose_image_alignment_el

On Thu 11 May 2017, Pohjolainen, Topi wrote: > On Wed, May 10, 2017 at 02:30:30PM -0700, Jason Ekstrand wrote: > > The Ivy Bridge PRM provides a nice table that handles most of the > > alignment cases in one place. For standard color buffers we have a > > little freedom of choice but for most

Re: [Mesa-dev] [PATCH 1/4] intel/isl/gen7: Use stencil vertical alignment of 8 instead of 4

On Wed 10 May 2017, Jason Ekstrand wrote: > From: "Pohjolainen, Topi" > > The reasoning Chad gave in the comment for choosing a valign of 4 is > entirely bunk. The fact that you have to multiply pitch by 2 is > completely unrelated to the halign/valign parameters

Re: [Mesa-dev] i965: Use isl for hiz and stencil

On Tue 09 May 2017, Jason Ekstrand wrote: > All of the below being said, I'm fine with landing things with a > BACK_TO_BACK layout and then making the switch to one isl_surf per miplevel > later if that's an easier path. I haven't read the series in full, but I agree with Jason here that an array

Re: [Mesa-dev] [RFC] intel/isl: Rewrite gen7_choose_image_alignment_el

On Wed 10 May 2017, Kenneth Graunke wrote: > On Wednesday, May 10, 2017 10:19:46 AM PDT Emil Velikov wrote: > > On 10 May 2017 at 16:38, Jason Ekstrand wrote: > > > On Wed, May 10, 2017 at 8:26 AM, Emil Velikov > > > wrote: > > >> > > >> Hi Jason,

Re: [Mesa-dev] [PATCH 08/13] egl/surfaceless: make use of the dri2_display_destroy() helper

Reviewed-by: Gurchetan Singh On Thu, May 11, 2017 at 11:57 AM, Emil Velikov wrote: > From: Emil Velikov > > Cc: Chad Versace > Cc: Gurchetan Singh >

[Mesa-dev] [PATCH 09/13] gallium/radeon: subclass threaded_transfer

From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 22 ++--- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_texture.c | 26 - 3 files changed, 25 insertions(+), 25

Re: [Mesa-dev] [PATCH 3/3] i965: Port Gen4-5 VS_STATE to genxml.

On Thursday, May 11, 2017 9:54:13 AM PDT Rafael Antognolli wrote: > On Wed, May 10, 2017 at 12:41:39PM -0700, Kenneth Graunke wrote: [snip] > > - struct brw_vs_unit_state *vs; > > It looks like brw_vs_unit_state is not used anywhere else, so maybe we could > delete it too. Also, it looks weird

Re: [Mesa-dev] [PATCH 09/13] gallium/radeon: subclass threaded_transfer

On Thu, May 11, 2017 at 8:42 PM, Nicolai Hähnle wrote: > On 11.05.2017 00:45, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/r600_buffer_common.c | 22 >> ++--- >>

[Mesa-dev] [PATCH 2/2] i965/formats: Update the RGB_DXT1 mappings

The DXT1_RGB* format does not provide the correct behavior for OpenGL in the case where color_0 <= color_1. BC1_RGB_UNORM with a alpha set to 1 provides the behavior which matches the spec. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100925 Cc:

[Mesa-dev] [PATCH 1/2] anv/formats: Update the BC1_RGB mappings

The DXT1_RGB* format does not provide the correct behavior for Vulkan in the case where color_0 <= color_1. BC1_RGB_UNORM with a alpha set to 1 provides the behavior which matches the spec. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100925 Cc:

Re: [Mesa-dev] Requests for Proposal for hosting XDC 2018

Hi Daniel, Is Call for Papers opened yet for XDC? When do they usually start accepting proposals? Regards Manasi On Fri, May 12, 2017 at 12:08:45AM +0200, Daniel Vetter wrote: > Hi all, > > The X.org board is soliciting proposals to host XDC in 2017. By the usual > rotation a location in

[Mesa-dev] [PATCH 4/9] genxml: Make a SCISSOR_RECT structure on Gen4-5.

Gen6+ support multiple scissor rectangles, and define a SCISSOR_RECT structure containing their dimensions. On Gen4-5, those same fields exist in SF_VIEWPORT. This patch extracts the SF_VIEWPORT fields into a SCISSOR_RECT structure. Although not a named concept on Gen4-5, it works just as well,

[Mesa-dev] [PATCH 5/9] i965: Move the scissoring code up near the viewport code.

These are fairly related. Gen4-5 combine the scissor rectangle and SF_VIEWPORT. Co-locating them will allow me to avoid forward declarations of helper functions in a few patches. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 172 +- 1 file changed, 86

[Mesa-dev] [PATCH 3/9] i965: Replace brw->gen and devinfo->gen with GEN_GEN.

--- src/mesa/drivers/dri/i965/genX_state_upload.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index 39801ecb259..a0695510b0c 100644 ---

[Mesa-dev] [PATCH 7/9] i965: Make a set_scissor_bits helper function.

Gen4-5 include a single SCISSOR_RECT in SF_VIEWPORT. Making a helper function will allow us to reuse this code for Gen4-5. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 73 +++ 1 file changed, 40 insertions(+), 33 deletions(-) diff --git

[Mesa-dev] [PATCH 9/9] i965: Always scissor on Gen4-5 instead of disabling guardband.

See commit ece0e535a44c228dd994861592deb155c14740d8. This makes Gen4-5 follow the behavior we use on Gen6+. It seems to have worked out there. --- src/mesa/drivers/dri/i965/brw_clip_state.c | 34 ++ src/mesa/drivers/dri/i965/brw_sf_state.c | 7 ++ 2 files

[Mesa-dev] [PATCH 8/9] i965: Unify Gen4-5 and Gen6 SF_VIEWPORT/CLIP_VIEWPORT code.

This brings the improved guardbanding we implemented on Gen6+ back to the older Gen4-5 code. It also deletes piles of code. --- src/mesa/drivers/dri/i965/brw_clip_state.c| 20 -- src/mesa/drivers/dri/i965/brw_sf_state.c | 89 ---

[Mesa-dev] [PATCH 6/9] i965: Use GENX(packet_length) rather than hardcoded dword counts.

This is clearer and less likely to break in the future. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index

[Mesa-dev] [PATCH 1/9] i965: Port CC_VIEWPORT to genxml.

--- src/mesa/drivers/dri/i965/brw_cc.c| 47 - src/mesa/drivers/dri/i965/brw_state.h | 1 - src/mesa/drivers/dri/i965/genX_state_upload.c | 59 +-- 3 files changed, 55 insertions(+), 52 deletions(-) diff --git

[Mesa-dev] [PATCH 2/9] i965: Rework Sandybridge 3DSTATE_VIEWPORT_STATE_POINTERS.

On Gen7+ we emit 3DSTATE_VIEWPORT_STATE_POINTERS_{SF_CL,CC} when emitting a new viewport. This patch makes us take the same approach on Sandybridge - but because we have a combined command, we just set the appropriate "change" bits. This eliminates an atom, some dirty flagging, and some

[Mesa-dev] [PATCH 1/3] egl/android: use the image_driver alongside the image_loader

From: Emil Velikov They are meant to be used together. Otherwise we'll need workarounds like egl/wayland. Namely register an image_loader_extension even thought we should be using only DRI2. Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 2/3] egl/surfaceless: use the image_driver for image_loader

Analogous to previous commit. Cc: Chad Versace Cc: Gurchetan Singh Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH 3/3] egl/wayland: use the image_driver alongside the image_loader

From: Emil Velikov Analogous to previous commit. Cc: Derek Foreman Signed-off-by: Emil Velikov --- Derek, afaict we should be able to revert commit 534ea2b5ba0 with this in place. Can you please apply this patch,

[Mesa-dev] Requests for Proposal for hosting XDC 2018

Hi all, The X.org board is soliciting proposals to host XDC in 2017. By the usual rotation a location in Europe is preferred, but the board will also consider other locations, especially if there's an interesting co-location with another conference. If you consider hosting XDC, we have assembled

Re: [Mesa-dev] [PATCH v2 1/2] glsl: add parcel_out_uniform_storage::set_opaque_indices() helper

On 12/05/17 01:43, Samuel Pitoiset wrote: In order to sort indices for images inside a struct array we need to do something similar to samplers. v2: - rename count_indices() to set_opaque_indices() - make the method returns a bool to skip the loop That makes sense :) both: Reviewed-by:

Re: [Mesa-dev] [PATCH 05/13] egl: split out a dri2_display_destroy() helper

Reviewed-by: Gurchetan Singh On Thu, May 11, 2017 at 11:57 AM, Emil Velikov wrote: > From: Emil Velikov > > Within dri2_display_release() we already tear down all the display > specifics. Within the platform

Re: [Mesa-dev] [PATCH 08/13] egl/surfaceless: make use of the dri2_display_destroy() helper

Reviewed-by: Gurchetan Singh On Thu, May 11, 2017 at 11:57 AM, Emil Velikov wrote: > From: Emil Velikov > > Cc: Chad Versace > Cc: Gurchetan Singh >

Re: [Mesa-dev] [PATCH 00/13] Threaded Gallium for RadeonSI

On Thu, May 11, 2017 at 9:02 PM, Nicolai Hähnle > Some general remarks: > > Violating the "async" promise on debug callbacks is a problem. This breaks > the OpenGL API in a place where it wasn't broken before, and that's not > okay. I'm not sure what to do about this

Re: [Mesa-dev] [PATCH] bin/get-fixes-pick-list.sh: bring back the warning

On 8 May 2017 at 18:57, Andres Gomez wrote: > We warn again if there is more than one line with the "fixes:" tag. > > The warning is only silenced when the commit has landed already or we > output a message with the specific commit the "fixes:" tag is > referring to. > Would be

Re: [Mesa-dev] [PATCH 00/13] egl: gbm: Misc cleanups and robustness patches

On 11 May 2017 at 19:57, Emil Velikov wrote: > egl: split out a dri2_display_destroy() helper > egl/android: make use of dri2_display_destroy() helper > egl/drm: make use of the dri2_display_destroy() helper > egl/surfaceless: make use of the

Re: [Mesa-dev] [PATCH] android: r600: fix libmesa_amd_common dependency

2017-05-11 14:08 GMT+02:00 Mauro Rossi : > 2017-05-11 13:28 GMT+02:00 Emil Velikov : >> On 13 March 2017 at 13:10, Emil Velikov wrote: >>> On 11 March 2017 at 16:26, Mauro Rossi wrote:

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] st/mesa: don't cast the incomplete framebufer to st_framebuffer

On Thu, 2017-05-11 at 21:05 +0200, Nicolai Hähnle wrote: > On 11.05.2017 21:01, Andres Gomez wrote: > > Michel, Nicolai, this patch is queued for 17.0. > > > > Does this finding mean that we rather shouldn't add it in the release? > > So far it seems to me that it is still better having it in

Re: [Mesa-dev] [PATCH 0/2] Extended the release calendar

Emil, Juan, could you give a look to this series? Thanks! On Sat, 2017-05-06 at 18:46 +0300, Andres Gomez wrote: > Calendar updated and extended until end of August. > > Andres Gomez (2): > docs: update "Release manager" column > docs: extend until the end of August > >

Re: [Mesa-dev] [PATCH] bin/get-fixes-pick-list.sh: don't warn if more than one, go over them

Emil, to bring the warning back in the same conditions there is: https://lists.freedesktop.org/archives/mesa-dev/2017-May/154907.html Could you give it a look and may be grant a R-b ? Thanks! On Tue, 2017-05-09 at 10:42 +0100, Emil Velikov wrote: > On 8 May 2017 at 14:49, Andres Gomez

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] st/mesa: don't cast the incomplete framebufer to st_framebuffer

On 11.05.2017 21:01, Andres Gomez wrote: Michel, Nicolai, this patch is queued for 17.0. Does this finding mean that we rather shouldn't add it in the release? So far it seems to me that it is still better having it in than not. Also, if we decide not to include it, should I keep the patch 2/2

Re: [Mesa-dev] [PATCH] intel/anv, genxml: Pull address canonicalization into a common header

On Thu, May 11, 2017 at 10:22:27AM -0700, Jason Ekstrand wrote: fwiw, Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 01/24] intel/blorp: Assert on subresource in surface_info_init

Forgot to add the V2 tag to this series. Sorry about that. -Nanley ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] anv: finishing bay trail support

Hello everyone, I'm a student who's looking to create a small Vulkan demo for my computer graphics class; my laptop (CPU: Intel N3540) has an integrated Bay Trail chip if I looked that up right, which should be capable of supporting Vulkan. I saw that Bay Trail support in anv is marked

[Mesa-dev] [PATCH 16/24] blorp/clear: Add a binding-table-based CCS resolve function

v2 (Jason Ekstrand): - Replace "bt" suffix with "attachment." - Rename helper function to prepare_ccs_resolve. - Move blorp_params_init() into helper function. Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.h | 9 +++ src/intel/blorp/blorp_clear.c |

[Mesa-dev] [PATCH 21/24] anv/blorp: Stop resolving CCS implicitly

With the previous patch, resolves are additionally performed on layout transitions. Remove the now unnecessary implicit resolves within render passes. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 139 --- 1 file

[Mesa-dev] [PATCH 22/24] anv/pass: Get rid of anv_subpass_usage

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 14 -- src/intel/vulkan/anv_private.h | 10 -- 2 files changed, 24 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index bb7ee45098..597939ab66

[Mesa-dev] [PATCH 17/24] anv/blorp: Add a surface-state-based CCS resolve function

This will be used in conjunction with the buffer of clear values. v2 (Jason Ekstrand): - Omit BLORP_BATCH_NO_EMIT_DEPTH_STENCIL Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 40 src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH 24/24] anv: Predicate fast-clear resolves

There's no image layout to represent a full-RT-cleared color attachment. That's one reason we can end up with redundant resolves. Testing has shown that such resolves can measurably hurt performance and that predicating them can avoid the penalty. Signed-off-by: Nanley Chery

[Mesa-dev] [PATCH 05/24] intel/isl: Add surface state clear value information

This will be used to load and store clear values from surface state objects. Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 + src/intel/isl/isl.h | 4 2 files changed, 13 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index

[Mesa-dev] [PATCH 19/24] anv/cmd_buffer: Add transition_color_buffer()

v2 (Jason Ekstrand): - Provide a more detailed comment for the CCS pipe controls Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 103 + 1 file changed, 103 insertions(+) diff --git

[Mesa-dev] [PATCH 15/24] anv/cmd_buffer: Ensure the fast clear values are correct

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 76 ++ 1 file changed, 76 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 935cee34c1..6e993ed276 100644

[Mesa-dev] [PATCH 14/24] anv/gpu_memcpy: Add a lighter-weight memcpy path

We'll be performing a GPU memcpy in more places to copy small amounts of data. Add a path that thrashes less state. v2: - Make a new function (Jason Ekstrand) - Move the #define into the function Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_genX.h| 5

[Mesa-dev] [PATCH 20/24] anv/cmd_buffer: Perform color buffer layout transitions

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 65 ++ 1 file changed, 52 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index

[Mesa-dev] [PATCH 09/24] anv/image: Initialize the clear values buffer

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 71 -- src/intel/vulkan/anv_private.h | 5 +++ 2 files changed, 67 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH 23/24] intel/blorp: Allow BLORP calls to be predicated

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.h | 3 +++ src/intel/blorp/blorp_genX_exec.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index 661e0380fd..de68fabc11 100644 ---

[Mesa-dev] [PATCH 13/24] anv/gpu_memcpy: Rename the gpu_memcpy function

We'll be adding another memcpy function in the next commit. Provide more detail into how this one operates. Suggested-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_genX.h| 8

[Mesa-dev] [PATCH 18/24] anv/cmd_buffer: Adjust the image view reloc function

Make the function take in an image instead of an image view. This enables us to record relocations for surfaces states created outside of the anv_CreateImageView path. v2 (Jason Ekstrand): - Use image->offset instead of surf_offset in aux_offset calculation. Signed-off-by: Nanley Chery

[Mesa-dev] [PATCH 10/24] anv/cmd_buffer: Always enable CCS_D in render passes

The lifespan of the fast-clear data will surpass the render pass scope. We need CCS_D to be enabled in order to invalidate blocks previously marked as cleared and to sample cleared data correctly. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 15

[Mesa-dev] [PATCH 12/24] anv/cmd_buffer: Disable fast clears in the GENERAL layout

v2 (Jason Ekstrand): - Initialize ::first_subpass_layout instead of asserting Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 22 ++ src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/genX_cmd_buffer.c | 10 --

[Mesa-dev] [PATCH 11/24] anv/cmd_buffer: Don't partially fast-clear image layers

v2 (Jason Ekstrand): - Don't pass in the command buffer Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH 08/24] anv/image: Remove incorrect assertion in anv_BindImage

According to the Linux kernel sources, the ioctl in anv_gem_mmap() will not fail if the size isn't a multiple of 4KB. Reviewed-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 5 ++--- 1 file changed, 2

[Mesa-dev] [PATCH 07/24] anv/image: Append CCS/MCS with a clear value buffer

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 67 1 file changed, 67 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index d21e055f02..30cdfdb0e5 100644 ---

[Mesa-dev] [PATCH 04/24] intel/isl: Only create a CCS buffer if the image supports rendering

This prevents assertion failures when initializing the clear value buffer on images with the E5B9G9R9 format. Reviewed-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH 06/24] anv: Add color auxiliary buffer helpers

v2 (Jason Ekstrand): - Check for aux levels in layer helper Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_private.h | 49 ++ 1 file changed, 49 insertions(+) diff --git a/src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH 03/24] intel/isl: Limit CCS to one subresource on gen7

Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index f89f351c15..ce5b35c47c 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1610,14

[Mesa-dev] [PATCH 02/24] intel/blorp: Assert on gen7 fast-cleared subresource

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp_clear.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index a9eb6b95e4..c72d3291c7 100644 --- a/src/intel/blorp/blorp_clear.c +++

[Mesa-dev] [PATCH 01/24] intel/blorp: Assert on subresource in surface_info_init

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/blorp/blorp.c b/src/intel/blorp/blorp.c index 9834275529..e972f721d0 100644 --- a/src/intel/blorp/blorp.c +++ b/src/intel/blorp/blorp.c @@ -66,6

[Mesa-dev] [PATCH 10/13] egl/x11: make use of the dri2_display_destroy() helper

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_x11.c | 78 +++-- 1 file changed, 23 insertions(+), 55 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c

[Mesa-dev] [PATCH 13/13] gbm: don't manage our set of DRI extensions

From: Emil Velikov Don't fetch/manage our set of extensions apart from __DRI_CORE, __DRI_DRI2 and __DRI_SWRAST. We require these to setup a screen and context (in case of bo map/unmap). The rest are fetched and kept in sync with the rest of EGL, via the egl/drm code.

[Mesa-dev] [PATCH 11/13] egl: refactor dri2_create_screen() into three separate functions

Split the create_screen into: - create screen - setup/bind extensions - setup screen This will allow us to reuse the latter two on egl/drm. Said platform does create its own screen and attempts to reinvent the later two functions itself. Since the GBM ones tend to get out of sync quite often,

[Mesa-dev] [PATCH 09/13] egl/wayland: make use of the dri2_display_destroy() helper

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 84 ++--- 1 file changed, 25 insertions(+), 59 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c

[Mesa-dev] [PATCH 08/13] egl/surfaceless: make use of the dri2_display_destroy() helper

From: Emil Velikov Cc: Chad Versace Cc: Gurchetan Singh Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 22 -- 1 file changed, 8

[Mesa-dev] [PATCH 07/13] egl/drm: make use of the dri2_display_destroy() helper

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c

[Mesa-dev] [PATCH 12/13] egl/drm: use dri2_setup_extensions() over the extensions provided by GBM

From: Emil Velikov Allows us to keep things in sync easier and lets us simplify the interface between the two even further. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 12 1 file changed, 8

[Mesa-dev] [PATCH 05/13] egl: split out a dri2_display_destroy() helper

From: Emil Velikov Within dri2_display_release() we already tear down all the display specifics. Within the platform specific dri initialize however we badly and partially duplicate that. Let's stop that by fleshing out the required functionality into a helper and

[Mesa-dev] [PATCH 01/13] gbm: remove unused gbm_dri_device::loader

From: Emil Velikov Introduced back in 2012 with fd6acb97fb9 ("gbm: Create hooks for dri2_loader_extension in dri backend") and hasn't been used since. Seemingly a copy/paste thinko from development stage. Cc: Ander Conselvan de Oliveira

[Mesa-dev] [PATCH 04/13] gbm: remove unneeded gbm_drm_device abstraction

From: Emil Velikov Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 2 +- src/egl/drivers/dri2/platform_drm.c | 17 +--- src/gbm/Makefile.sources| 1 - src/gbm/backends/dri/gbm_dri.c | 53

[Mesa-dev] [PATCH 06/13] egl/android: make use of dri2_display_destroy() helper

From: Emil Velikov Cc: Tomasz Figa Cc: Tapani Pälli Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 27 +-- 1 file changed, 9 insertions(+),

[Mesa-dev] [PATCH 03/13] gbm: move gbm_drm_device::driver_name to gbm_dri_device

From: Emil Velikov The former already keeps track of the DRI module opened, based on the driver_name provided. So let's keep them together. As a nice bonus this Will allows us to remove the gbm_drm_device all together with next patch. Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 00/13] egl: gbm: Misc cleanups and robustness patches

Hi all, I was around the EGL/GBM codebase and I've noticed that we do a few things, rather badly: - we have unnessesary layer of abstraction in GBM like the following gbm_dri_foo -> gbm_drm_foo -> gbm_foo - the teardown path of platform_foo initialize is in bad shape Destroying someone else's

[Mesa-dev] [PATCH 02/13] gbm: remove "struct gbm_drm_bo" abstraction

From: Emil Velikov The struct is a simple wraper around gbm_bo and brings no actual benefit. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_drm.c | 4 ++-- src/gbm/backends/dri/gbm_dri.c | 48

Re: [Mesa-dev] [PATCH 00/13] Threaded Gallium for RadeonSI

On 11.05.2017 00:45, Marek Olšák wrote: Hi, This series adds an optional module into gallium/util that wraps around pipe_context and moves execution of all pipe_context calls into a separate thread. It puts a lot of new requirements on the driver, especially on thread- safetiness of

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] st/mesa: don't cast the incomplete framebufer to st_framebuffer

Michel, Nicolai, this patch is queued for 17.0. Does this finding mean that we rather shouldn't add it in the release? So far it seems to me that it is still better having it in than not. Also, if we decide not to include it, should I keep the patch 2/2 of this series out too? Let me know what

Re: [Mesa-dev] [PATCH 18/21] anv: Implement support for exporting semaphores as FENCE_FD

On Tue 09 May 2017, Jason Ekstrand wrote: > On Tue, May 9, 2017 at 4:49 PM, Chad Versace > wrote: > > > I learned a lot by reviewing this patch. Before reviewing it, some parts > > of the external_semaphore spec still confused me. But reviewing this > > forced me to

Re: [Mesa-dev] [PATCH 09/13] gallium/radeon: subclass threaded_transfer

On 11.05.2017 00:45, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 22 ++--- src/gallium/drivers/radeon/r600_pipe_common.h | 2 +- src/gallium/drivers/radeon/r600_texture.c | 26

Re: [Mesa-dev] [PATCH 03/13] gallium/util: add threaded_context as a pipe_context wrapper

On 11.05.2017 00:45, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/Makefile.sources |3 + src/gallium/auxiliary/util/u_threaded_context.c| 2300 src/gallium/auxiliary/util/u_threaded_context.h| 349 +++

Re: [Mesa-dev] [PATCH 01/22] intel/isl: Limit CCS to one subresource on gen7

On Thu, May 11, 2017 at 11:00 AM, Nanley Chery wrote: > On Tue, May 02, 2017 at 02:48:09PM -0700, Jason Ekstrand wrote: > > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > > wrote: > > > > > Signed-off-by: Nanley Chery >

Re: [Mesa-dev] [PATCH 09/22] anv/cmd_buffer: Don't partially fast-clear image layers

On Thu, May 11, 2017 at 11:17:20AM -0700, Jason Ekstrand wrote: > On Thu, May 11, 2017 at 10:13 AM, Nanley Chery > wrote: > > > On Tue, May 02, 2017 at 05:23:49PM -0700, Jason Ekstrand wrote: > > > On Tue, May 2, 2017 at 4:37 PM, Nanley Chery > >

Re: [Mesa-dev] [PATCH 3/3] i965: Port Gen4-5 VS_STATE to genxml.

Ugh, and I also forgot: you can remove brw_vs_unit from brw_state.h too. On Thu, May 11, 2017 at 09:54:13AM -0700, Rafael Antognolli wrote: > On Wed, May 10, 2017 at 12:41:39PM -0700, Kenneth Graunke wrote: > > It's actually not that much code. > > --- > > src/intel/genxml/gen4.xml

Re: [Mesa-dev] [PATCH 09/22] anv/cmd_buffer: Don't partially fast-clear image layers

On Thu, May 11, 2017 at 10:13 AM, Nanley Chery wrote: > On Tue, May 02, 2017 at 05:23:49PM -0700, Jason Ekstrand wrote: > > On Tue, May 2, 2017 at 4:37 PM, Nanley Chery > wrote: > > > > > On Tue, May 02, 2017 at 04:25:42PM -0700, Jason Ekstrand

Re: [Mesa-dev] [PATCH 07/22] anv/image: Initialize the clear values buffer

On Tue, May 02, 2017 at 04:03:36PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/vulkan/anv_image.c | 75 ++ > >

Re: [Mesa-dev] [PATCH 01/22] intel/isl: Limit CCS to one subresource on gen7

On Tue, May 02, 2017 at 02:48:09PM -0700, Jason Ekstrand wrote: > On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery > wrote: > > > Signed-off-by: Nanley Chery > > --- > > src/intel/isl/isl.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2

[Mesa-dev] [PATCH] swr: don't use AttributeSet with llvm >= 5

This change fixes the build break with llvm-svn. r301981 of llvm-svn made add/remove of function attributes use AttrBuilder instead of AttributeList. Tested with llvm-3.9, llvm-4.0, llvm-svn. --- src/gallium/drivers/swr/swr_shader.cpp | 36 -- 1 file changed, 21

  1   2   >