[Mesa-dev] [Patch v2] osmesa: link with libunwind if enabled (v2)

Fixes linking error in libOSmesa when using libunwind. CXXLDlibOSMesa.la src/gallium/auxiliary/.libs/libgallium.a(u_debug_stack.o): In function `symbol_name_cached': ./src/gallium/auxiliary/util/u_debug_stack.c:87: undefined reference to `_ULx86_64_get_proc_name'

[Mesa-dev] [PATCH 1/2] i915g: make gears run again.

From: Dave Airlie We need to validate some structs exist before we dirty the states, and avoid the problem in some other places. Fixes: e027935a7 ("st/mesa: don't update unrelated states in non-draw calls such as Clear") --- src/gallium/drivers/i915/i915_state_derived.c

[Mesa-dev] [PATCH 2/2] i915g: remove some unknown cap warnings.

From: Dave Airlie --- src/gallium/drivers/i915/i915_screen.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c index 1cf9441..792b83f 100644 ---

Re: [Mesa-dev] Proposal to branch off old drivers

On 26/05/17 11:13, Ilia Mirkin wrote: On Thu, May 25, 2017 at 9:05 PM, Rob Clark wrote: On Thu, May 25, 2017 at 8:45 PM, Timothy Arceri wrote: My specific proposal is: - Rather than just pointing distros at the last Mesa release as we did for

Re: [Mesa-dev] Proposal to branch off old drivers

On Thu, May 25, 2017 at 9:05 PM, Rob Clark wrote: > On Thu, May 25, 2017 at 8:45 PM, Timothy Arceri wrote: >> >> My specific proposal is: >> >> - Rather than just pointing distros at the last Mesa release as we did for >> the DRI1 driver, we create a

Re: [Mesa-dev] Proposal to branch off old drivers

On 26/05/17 10:45, Timothy Arceri wrote: Hi all, Following on from the discussion here: https://lists.freedesktop.org/archives/mesa-dev/2017-May/155971.html Back in 2011/12 despite various concerns old hardware would become useless, dropping support for DRI1 drivers Mesa proved distros were

Re: [Mesa-dev] Proposal to branch off old drivers

On Thu, May 25, 2017 at 8:45 PM, Timothy Arceri wrote: > > My specific proposal is: > > - Rather than just pointing distros at the last Mesa release as we did for > the DRI1 driver, we create a mesa-pre-dx9-1.0 branch (branched from 17.1). > However unlikely this will at

Re: [Mesa-dev] [PATCH 19/43] intel/decoder: Handle the BLT ring in gen_group_get_length

Reviewed-by: Jordan Justen On 2017-05-16 15:45:13, Jason Ekstrand wrote: > --- > src/intel/common/gen_decoder.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c > index 6bb9a7a..1a99099

[Mesa-dev] Proposal to branch off old drivers

Hi all, Following on from the discussion here: https://lists.freedesktop.org/archives/mesa-dev/2017-May/155971.html Back in 2011/12 despite various concerns old hardware would become useless, dropping support for DRI1 drivers Mesa proved distros were up to the challenge of packaging up the

Re: [Mesa-dev] [PATCH 18/43] intel/decoder: Handle gen4 VF_STATISTICS and PIPELINE_SELECT

On 2017-05-16 15:45:12, Jason Ekstrand wrote: > These need special handling because they have no "DWord Length" > parameter and they have an unusual bias of 1. > --- > src/intel/common/gen_decoder.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] radeonsi: drop useless memcmp() check in si_set_blend_color()

err, used in si_begin_new_cs(). Ignore for now. On 05/26/2017 01:42 AM, Samuel Pitoiset wrote: cso_set_blend_color() already checks if the old state is different. Only Nine uses pipe::set_blend_color() directly but I guess it should use the cache too. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH] radeonsi: drop useless memcmp() check in si_set_blend_color()

cso_set_blend_color() already checks if the old state is different. Only Nine uses pipe::set_blend_color() directly but I guess it should use the cache too. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_state.c | 3 --- 1 file changed, 3

Re: [Mesa-dev] [PATCH v2] mesa: add KHR_no_error support for glActiveTexture()

Much better. Reviewed-by: Ian Romanick On 05/25/2017 03:18 AM, Samuel Pitoiset wrote: > v2: add active_texture() with ALWAYS_INLINE and no_error param > > Signed-off-by: Samuel Pitoiset > --- > src/mapi/glapi/gen/gl_API.xml | 2 +- >

Re: [Mesa-dev] [PATCH 1/2] mesa: add active_texture() helper

On 05/26/2017 01:38 AM, Ian Romanick wrote: On 05/23/2017 03:41 AM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstate.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] mesa: add active_texture() helper

On 05/23/2017 03:41 AM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/texstate.c | 24 ++-- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c >

Re: [Mesa-dev] [PATCH V2] util/disk_cache: compress individual cache entries

On 05/04/17 08:23, Brian Paul wrote: On 03/04/2017 07:12 AM, Emil Velikov wrote: On 2 March 2017 at 21:52, Timothy Arceri wrote: On 03/03/17 01:49, Emil Velikov wrote: Hi Tim, On 2 March 2017 at 01:36, Timothy Arceri wrote: This reduces the

Re: [Mesa-dev] [PATCH 03/24] i965/cnl: Add gen10.xml

On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > From: Jason Ekstrand > > This patch is truncated due to the size. You can find the full > patch in my review branch. > > V2(Anuj): Add default value for length of 3DPRIMITIVE command >

Re: [Mesa-dev] [PATCH v4 4/4] nv50/ir, nvc0: Add support for ARB_post_depth_coverage

Reviewed-by: Samuel Pitoiset On 05/24/2017 09:42 PM, Lyude wrote: This adds support for the GL_arb_post_depth_coverage extension on nvc0 GPUs, GM200+ and up. Similar to what we do for early fragment testing, we only call the method for updating the post depth

Re: [Mesa-dev] [PATCH 2/7] radeonsi: compute shaders w/out LDS/barriers don't have lower register limit

On Thu, May 25, 2017 at 11:11 PM, Samuel Pitoiset wrote: > > > On 05/25/2017 07:04 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Or do they? This doesn't hang, so it seems right, but I'm not 100% sure. >> Setting VGPRS=256 (i.e. above the

Re: [Mesa-dev] [PATCH 2/7] radeonsi: compute shaders w/out LDS/barriers don't have lower register limit

On 05/25/2017 07:04 PM, Marek Olšák wrote: From: Marek Olšák Or do they? This doesn't hang, so it seems right, but I'm not 100% sure. Setting VGPRS=256 (i.e. above the limit) with big threadgroups works fine. shader-db: Spilled VGPRs: 107 -> 50 (-53.27 %) DiRT Showdown

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

On Thu, May 25, 2017 at 10:49 PM, Samuel Pitoiset wrote: > > > On 05/25/2017 10:45 PM, Marek Olšák wrote: >> >> On Thu, May 25, 2017 at 9:56 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 05/25/2017 07:58 PM, Marek Olšák wrote:

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

On 05/25/2017 10:45 PM, Marek Olšák wrote: On Thu, May 25, 2017 at 9:56 PM, Samuel Pitoiset wrote: On 05/25/2017 07:58 PM, Marek Olšák wrote: Hi, 1) Patches 48 and 52 are missing code comments. I'd like to see code comments about how things work and why it was

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

On Thu, May 25, 2017 at 9:56 PM, Samuel Pitoiset wrote: > > > On 05/25/2017 07:58 PM, Marek Olšák wrote: >> >> Hi, >> >> 1) Patches 48 and 52 are missing code comments. I'd like to see code >> comments about how things work and why it was designed like that. > > > Okay,

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

On 05/25/2017 07:58 PM, Marek Olšák wrote: Hi, 1) Patches 48 and 52 are missing code comments. I'd like to see code comments about how things work and why it was designed like that. Okay, I will add some. 2) There is a lot of code duplication regarding managing the resizable arrays. I'd

Re: [Mesa-dev] [PATCH] radv: Also signal fence if vkAcquireNextImageKHR returns VK_SUBOPTIMAL_KHR.

Reviewed-by: Fredrik Höglund On Wednesday 24 May 2017, Bas Nieuwenhuizen wrote: > It is a successful return. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/amd/vulkan/radv_wsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH 4/6] glsl: teach opt_structure_splitting about images in structures

GL_ARB_bindless_texture allows images to be declared inside structures, but when memory/format qualifiers are used, they should be propagated when structures are splitted. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/opt_structure_splitting.cpp | 23

[Mesa-dev] [PATCH 6/6] glsl: fix a crash in ir_print_visitor() for bindless samplers/images

Bindless samplers/images are represented with 64-bit unsigned integers and they can be assigned with explicit constructors. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ir_print_visitor.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 5/6] glsl: teach opt_array_splitting about bindless images

Memory/format layout qualifiers shouldn't be lost when arrays of images are splitted by this pass. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/opt_array_splitting.cpp | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 1/6] glsl: handle memory qualifiers for struct with array of images

This handles a situation like: struct { image2D imgs[6]; } s; Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast_to_hir.cpp | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 2/6] glsl: handle format layout qualifiers for struct with array of images

This handles a situation like: struct { layout (r32f) image2D imgs[6]; } s; Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/ast_to_hir.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp

[Mesa-dev] [PATCH 3/6] glsl: fix broken indentation in do_structure_splitting()

Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/opt_structure_splitting.cpp | 29 --- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/compiler/glsl/opt_structure_splitting.cpp

Re: [Mesa-dev] [PATCH] docs: small release calendar fixes

Good catch! Reviewed-by: Eric Engestrom On 25 May 2017 10:26:18 BST, Andres Gomez wrote: >Signed-off-by: Andres Gomez >--- > docs/release-calendar.html | 2 +- > docs/releasing.html| 2 +- > 2 files changed, 2 insertions(+), 2

Re: [Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

Hi, 1) Patches 48 and 52 are missing code comments. I'd like to see code comments about how things work and why it was designed like that. 2) There is a lot of code duplication regarding managing the resizable arrays. I'd like to see some util module used here, e.g. u_vector or you can add new

Re: [Mesa-dev] [PATCH] i965: Remove an extra semicolon

Reviewed-by: Alejandro Piñeiro On 25/05/17 19:12, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [RFC PATCH 25/65] gallium: add ARB_bindless_texture interface

On 05/25/2017 07:36 PM, Marek Olšák wrote: On Thu, May 25, 2017 at 3:53 PM, Marek Olšák wrote: On Wed, May 24, 2017 at 1:52 PM, Nicolai Hähnle wrote: On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [RFC PATCH 25/65] gallium: add ARB_bindless_texture interface

On Thu, May 25, 2017 at 3:53 PM, Marek Olšák wrote: > On Wed, May 24, 2017 at 1:52 PM, Nicolai Hähnle wrote: >> On 19.05.2017 18:52, Samuel Pitoiset wrote: >>> >>> Signed-off-by: Samuel Pitoiset >>> --- >>>

[Mesa-dev] [PATCH] i965: Remove an extra semicolon

Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index 5fad3b7..6b8919b 100644 ---

Re: [Mesa-dev] [PATCH] spirv: Flip the tessellation winding order

On Thu, May 25, 2017 at 7:07 AM, Marek Olšák wrote: > On Wed, May 24, 2017 at 8:34 PM, Jason Ekstrand > wrote: > > It's not SPIR-V that's backwards from GLSL, it's Vulkan that's backwards > > from GL. Let's make NIR consistent with the source language

[Mesa-dev] [PATCH 3/7] util: slab_destroy_child should check whether it's been initialized

From: Marek Olšák --- src/util/slab.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/slab.c b/src/util/slab.c index 4264814..4ce0e9a 100644 --- a/src/util/slab.c +++ b/src/util/slab.c @@ -133,20 +133,23 @@ void slab_create_child(struct slab_child_pool

[Mesa-dev] [PATCH 6/7] radeonsi: move building llvm.SI.load.const into ac_build_buffer_load

From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 46 +++- src/amd/common/ac_llvm_build.h | 3 ++- src/amd/common/ac_nir_to_llvm.c | 2 +- src/gallium/drivers/radeonsi/si_shader.c | 23 +++- 4 files

[Mesa-dev] [PATCH 4/7] radeonsi: fix a crash in si_destroy_context if we fail early

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 909a959..de4e5da 100644 ---

[Mesa-dev] [PATCH 7/7] radeonsi: use ac_build_buffer_load for shader buffer loads

From: Marek Olšák and document why we can't use SMEM yet. --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 43 +++ 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c

[Mesa-dev] [PATCH 5/7] radeonsi: rename readonly_memory -> can_speculate

From: Marek Olšák This is more accurate. --- src/amd/common/ac_llvm_build.c| 8 src/amd/common/ac_llvm_build.h| 4 ++-- src/gallium/drivers/radeonsi/si_shader.c | 10 +-

[Mesa-dev] [PATCH 1/7] tgsi/scan: record barrier instruction usage

From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 6 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index 847f4fc..cfe9f15

[Mesa-dev] [PATCH 2/7] radeonsi: compute shaders w/out LDS/barriers don't have lower register limit

From: Marek Olšák Or do they? This doesn't hang, so it seems right, but I'm not 100% sure. Setting VGPRS=256 (i.e. above the limit) with big threadgroups works fine. shader-db: Spilled VGPRs: 107 -> 50 (-53.27 %) DiRT Showdown and GRID Autosport have 100% reduction in VGPR

Re: [Mesa-dev] [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

On Wed, May 24, 2017 at 12:28:07PM +0100, Tvrtko Ursulin wrote: > > On 18/05/2017 18:00, Chris Wilson wrote: > >On Thu, May 18, 2017 at 05:20:38PM +0100, Tvrtko Ursulin wrote: > >> > >>On 18/05/2017 14:37, Chris Wilson wrote: > >>>On Thu, May 18, 2017 at 02:06:35PM +0100, Tvrtko Ursulin wrote: >

Re: [Mesa-dev] [PATCH] spirv: Flip the tessellation winding order

On Wed, May 24, 2017 at 8:34 PM, Jason Ekstrand wrote: > It's not SPIR-V that's backwards from GLSL, it's Vulkan that's backwards > from GL. Let's make NIR consistent with the source language and do the > flipping inside the Vulkan driver instead. I wonder why that is.

Re: [Mesa-dev] [RFC PATCH 25/65] gallium: add ARB_bindless_texture interface

On Wed, May 24, 2017 at 1:52 PM, Nicolai Hähnle wrote: > On 19.05.2017 18:52, Samuel Pitoiset wrote: >> >> Signed-off-by: Samuel Pitoiset >> --- >> src/gallium/include/pipe/p_context.h | 16 >> 1 file changed, 16 insertions(+) >>

Re: [Mesa-dev] [PATCH v4 3/4] st/mesa: Add support for ARB_post_depth_coverage

For patches 1-3: Reviewed-by: Marek Olšák Marek On Wed, May 24, 2017 at 9:42 PM, Lyude wrote: > Changes since v3: > - Add logic to the GL plumbing to implicitly enable early_fragment_tests > for the fragment shader when post_depth_coverage is enabled.

[Mesa-dev] [Bug 101186] Add account for Rob Herring

https://bugs.freedesktop.org/show_bug.cgi?id=101186 Brian Paul changed: What|Removed |Added Product|Mesa|freedesktop.org

[Mesa-dev] [Bug 101186] Add account for Rob Herring

https://bugs.freedesktop.org/show_bug.cgi?id=101186 --- Comment #3 from Emil Velikov --- Ack from me. Rob has 70+ patches in master and although most of those are Android related, he has also addressed issues in freedreno and other drivers. -- You are receiving this

[Mesa-dev] [Bug 101186] Add account for Rob Herring

https://bugs.freedesktop.org/show_bug.cgi?id=101186 --- Comment #2 from Rob Herring --- Created attachment 131507 --> https://bugs.freedesktop.org/attachment.cgi?id=131507=edit ssh pub key -- You are receiving this mail because: You are the assignee for the bug. You are the

[Mesa-dev] [Bug 101186] Add account for Rob Herring

https://bugs.freedesktop.org/show_bug.cgi?id=101186 --- Comment #1 from Rob Herring --- Created attachment 131506 --> https://bugs.freedesktop.org/attachment.cgi?id=131506=edit GPG pub key GPG key -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [Bug 101186] Add account for Rob Herring

https://bugs.freedesktop.org/show_bug.cgi?id=101186 Bug ID: 101186 Summary: Add account for Rob Herring Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: minor

Re: [Mesa-dev] [RFC PATCH 33/65] st/glsl_to_tgsi: add support for bindless images

On 05/24/2017 01:34 PM, Nicolai Hähnle wrote: On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 78 -- 1 file changed, 63 insertions(+), 15 deletions(-) diff

Re: [Mesa-dev] [PATCH 0/5] Android ifdef clean-ups

On 23 May 2017 at 20:49, Rob Herring wrote: > This is a series of clean-ups of Android related ifdefs. They are either > pre-Lollipop things no longer needed or things fixed in Android since > before Lollipop. > > Rob Herring (5): > gallium/os: use mmap64 for Android > i965:

Re: [Mesa-dev] [PATCH 3/5] Android: generate an error if building on Android 4.4 or earlier

On 23 May 2017 at 20:49, Rob Herring wrote: > Android 4.4 or earlier is no longer supported, so exit with an error if we > try building on it. > Perhaps reference the commit that dropped 4.4 support - 7a5b5f52260. That would have helped with Ian's comment. Can amend locally -

Re: [Mesa-dev] [RFC PATCH 22/65] mesa: handle bindless uniforms bound to texture/image units

On 05/24/2017 01:01 PM, Nicolai Hähnle wrote: Something else just occurred to me. Do you have a test case where an array of bindless sampler uniforms is set at once with glUniform1iv? https://hastebin.com/jiduzevage Works fine. That should have a 32- vs. 64-bit mismatch when the

[Mesa-dev] [PATCH v2] mesa: add KHR_no_error support for glActiveTexture()

v2: add active_texture() with ALWAYS_INLINE and no_error param Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/texstate.c | 36 +--- src/mesa/main/texstate.h | 3 +++ 3 files changed,

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #26 from Rob Clark --- (In reply to Ben Crocker from comment #25) > > Regarding Ray's specific comment about getting scalar fetch to work > with "sufficient twiddling," I think it's perfectly acceptable to

Re: [Mesa-dev] [PATCH v2] mesa: add KHR_no_error support for glBindImageTextures()

On 05/25/2017 11:51 AM, Timothy Arceri wrote: On 25/05/17 19:19, Samuel Pitoiset wrote: v2: - add bind_image_textures() helper Thanks, looks good. Reviewed-by: Timothy Arceri Are there also piglit updates to go with the no error mesa patches you have sent so far?

[Mesa-dev] [PATCH v2] mesa: throw an INVALID_OPERATION error in get_texobj_by_name()

While we are at it, rename obj to texObj for consistency. v2: - fix function name Signed-off-by: Samuel Pitoiset --- src/mesa/main/texparam.c | 74 1 file changed, 18 insertions(+), 56 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: throw an INVALID_OPERATION error in get_texobj_by_name()

On 05/25/2017 11:47 AM, Timothy Arceri wrote: On 25/05/17 19:24, Samuel Pitoiset wrote: While we are at it, rename obj to texObj for consistency. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texparam.c | 74

Re: [Mesa-dev] [PATCH v2] mesa: add KHR_no_error support for glBindImageTextures()

On 25/05/17 19:19, Samuel Pitoiset wrote: v2: - add bind_image_textures() helper Thanks, looks good. Reviewed-by: Timothy Arceri Are there also piglit updates to go with the no error mesa patches you have sent so far? Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] mesa: throw an INVALID_OPERATION error in get_texobj_by_name()

On 25/05/17 19:24, Samuel Pitoiset wrote: While we are at it, rename obj to texObj for consistency. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texparam.c | 74 1 file changed, 18 insertions(+), 56

Re: [Mesa-dev] [PATCH 1/2] mesa: add active_texture() helper

On 05/25/2017 11:42 AM, Timothy Arceri wrote: On 23/05/17 20:41, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstate.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/2] mesa: add active_texture() helper

On 23/05/17 20:41, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstate.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index

Re: [Mesa-dev] [RFC PATCH 22/65] mesa: handle bindless uniforms bound to texture/image units

On 05/24/2017 01:01 PM, Nicolai Hähnle wrote: Something else just occurred to me. Do you have a test case where an array of bindless sampler uniforms is set at once with glUniform1iv? I don't have, but I will write one right now. That should have a 32- vs. 64-bit mismatch when the

Re: [Mesa-dev] [RFC PATCH 22/65] mesa: handle bindless uniforms bound to texture/image units

On 05/24/2017 12:53 PM, Nicolai Hähnle wrote: On 19.05.2017 18:52, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniform_query.cpp | 122 ++-- 1 file changed, 116 insertions(+), 6 deletions(-) diff

[Mesa-dev] [PATCH] docs: small release calendar fixes

Signed-off-by: Andres Gomez --- docs/release-calendar.html | 2 +- docs/releasing.html| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index 19f518db1a..730cff8921 100644 ---

[Mesa-dev] [PATCH] mesa: throw an INVALID_OPERATION error in get_texobj_by_name()

While we are at it, rename obj to texObj for consistency. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texparam.c | 74 1 file changed, 18 insertions(+), 56 deletions(-) diff --git a/src/mesa/main/texparam.c

[Mesa-dev] [PATCH v2] mesa: add KHR_no_error support for glBindImageTextures()

v2: - add bind_image_textures() helper Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_multi_bind.xml | 2 +- src/mesa/main/shaderimage.c | 78 +-- src/mesa/main/shaderimage.h | 4 ++ 3 files changed, 52

Re: [Mesa-dev] [PATCH 5/5] mesa: add KHR_no_error support for glBindImageTextures()

On 05/25/2017 06:41 AM, Timothy Arceri wrote: On 24/05/17 07:45, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_multi_bind.xml | 2 +- src/mesa/main/shaderimage.c | 43 +++

[Mesa-dev] [ANNOUNCE] mesa 17.1.1

Mesa 17.1.1 is now available. In this release we have: The mesa GLVND GLX library now handles glXGetDriverConfig, as used by driconf. The GBM module has a bugfix for the newly added modifier API. While in EGL the error checking within eglMakeCurrent has been relaxed. On the driver side:

Re: [Mesa-dev] [PATCH 04/16] i965: Add a cache_coherent field to brw_bo

On Wed, May 24, 2017 at 01:04:46PM -0700, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c| 1 + > src/mesa/drivers/dri/i965/brw_bufmgr.h| 5 + > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 12/16] i965: Use write-combine mappings where available

On Thu, May 25, 2017 at 07:47:56AM +0100, Chris Wilson wrote: > On Wed, May 24, 2017 at 01:04:54PM -0700, Matt Turner wrote: > > +static bool > > +test_has_mmap_wc(int fd) > > +{ > > + return gem_param(fd, I915_PARAM_MMAP_VERSION) > 0; > > Of course I had to make this more complicated :( > >

Re: [Mesa-dev] [PATCH 16/16] i965: Enable tiled memcpy tex image path on non-LLC

On Wed, May 24, 2017 at 01:04:58PM -0700, Matt Turner wrote: I found the performance of the Y-detiling to be atrocious into WC (due to the access pattern jumping 64 bytes and so neatly sabotaging the WCB). I did a very rough sketch for using a temporary page to detile into:

Re: [Mesa-dev] [PATCH 12/16] i965: Use write-combine mappings where available

On Wed, May 24, 2017 at 01:04:54PM -0700, Matt Turner wrote: > Write-combine mappings give much better performance on writes than > uncached access through the GTT. > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c | 69 > ++ > 1 file changed, 69 insertions(+) > >

Re: [Mesa-dev] [PATCH 11/16] i965: Replace brw_bo_map_unsynchronized with MAP_ASYNC

On Wed, May 24, 2017 at 01:04:53PM -0700, Matt Turner wrote: > This way we can let brw_bo_map() choose the best mapping type. > > Part of the patch inlines map_gtt() into brw_bo_map_gtt() (and removes > map_gtt()). brw_bo_map_gtt() just wrapped map_gtt() with locking and a > call to set_domain().

Re: [Mesa-dev] [PATCH 07/16] i965: Rename brw_bo_map() -> brw_bo_map_cpu()

On Wed, May 24, 2017 at 01:04:49PM -0700, Matt Turner wrote: > I'm going to make a new function named brw_bo_map() in a later patch > that is responsible for choosing the mapping type, so this patch clears > the way. map_cpu was chosen when we only had the two types of cpu (wb, linear) or gtt