[Mesa-dev] [PATCH 24.5/24] i965/cnl: Add a preliminary device for Cannonlake

From: Ben Widawsky v2 (Anuj): Rebased on master and updated pci ids Remove redundant initialization of max_wm_threads to 64 * 12. For gen9+ max_wm_threads are initialized in gen_get_device_info(). v3 (Anuj): Move the patch to end of series. Remove unused gt1, gt2,

Re: [Mesa-dev] [PATCH] nvc0: Disable BGRA8 images on Fermi

Actually, for unknown reasons, storing to BGRA8 images doesn't work on Fermi. This breaks PBO downloads. Reviewed-by: Ilia Mirkin On Fri, Jun 2, 2017 at 8:45 PM, Lyude wrote: > For unknown reasons, using BGRA8 images on Fermi results in breaking > reads

Re: [Mesa-dev] [PATCH 02/24] i965/cnl: Add a preliminary device for Cannonlake

On Fri, Jun 2, 2017 at 4:56 PM, Jason Ekstrand wrote: > Perhaps this should probably be the last patch in the series as it's the one > that actually enables CNL support? Otherwise, you could get a commit with > PCI ids but a completely busted driver. > That's a good point.

Re: [Mesa-dev] [PATCH V2 00/24] Add Cannonlake support

On Fri, Jun 2, 2017 at 4:48 PM, Jason Ekstrand wrote: > On Mon, May 22, 2017 at 9:32 AM, Anuj Phogat wrote: >> >> On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat >> wrote: >> > This series adds support for Cannonlake. >> > >> >

[Mesa-dev] [PATCH] nvc0: Disable BGRA8 images on Fermi

For unknown reasons, using BGRA8 images on Fermi results in breaking reads from PBOs, such that they always return 0x0. Discovered this through a glamor bug, and confirmed it does indeed break a good number of piglit tests such as spec/arb_pixel_buffer_object/pbo-read-argb Until we have a

Re: [Mesa-dev] [PATCH 15/30] i965/miptree: Add new entrypoints for resolve management

On Fri, Jun 2, 2017 at 4:30 PM, Nanley Chery wrote: > On Fri, May 26, 2017 at 04:30:19PM -0700, Jason Ekstrand wrote: > > This commit adds a new unified interface for doing resolves. The basic > > format is that, prior to any surface access such as texturing or > >

Re: [Mesa-dev] [PATCH 17/24] i965/cnl: Implement new pipe control workaround

On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > From: Ben Widawsky > > GEN10 requires flushing all previous pipe controls before issuing a render > target cache flush. The docs seem to fairly explicitly say this is gen10 > only. > > V2

Re: [Mesa-dev] [PATCH 02/24] i965/cnl: Add a preliminary device for Cannonlake

Perhaps this should probably be the last patch in the series as it's the one that actually enables CNL support? Otherwise, you could get a commit with PCI ids but a completely busted driver. On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > From: Ben Widawsky

Re: [Mesa-dev] [PATCH 11/24] i965/cnl: Add pci id for INTEL_DEVID_OVERRIDE

Reviewed-by: Jason Ekstrand On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/intel_screen.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Mesa-dev] [PATCH V2 14/24] i965/cnl: Handle gen10 in switch cases across the driver

On Fri, Jun 2, 2017 at 4:45 PM, Jason Ekstrand wrote: > I had to squash 6, 9, 14, and 15 together in order to be able to review > properly. It would be much easier if we split things by component rather > than by what mechanical change is being done. I've got more to say

Re: [Mesa-dev] [PATCH 10/24] i965/cnl: Wire up android Mesa build files for gen10

Acked-by: Jason Ekstrand Maybe one of the android people would like to test it? On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > Note: This patch is untested. > > Signed-off-by: Anuj Phogat > --- >

Re: [Mesa-dev] [PATCH 01/24] i965: Make feature macros gen8 based

Reviewed-by: Jason Ekstrand On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > From: Ben Widawsky > > All the "features" of the hardware are similar starting with GEN8, so > remove as > much of the GEN9 uniqueness as

Re: [Mesa-dev] [PATCH V2 00/24] Add Cannonlake support

On Mon, May 22, 2017 at 9:32 AM, Anuj Phogat wrote: > On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat > wrote: > > This series adds support for Cannonlake. > > > > Changes from V1 to V2: > > - Incorporated the review comments from V1. > > - Rebased 8

Re: [Mesa-dev] [PATCH V2 14/24] i965/cnl: Handle gen10 in switch cases across the driver

I had to squash 6, 9, 14, and 15 together in order to be able to review properly. It would be much easier if we split things by component rather than by what mechanical change is being done. I've got more to say on the cover letter. In any case, 6, 9, 14, and 15 are Reviewed-by: Jason Ekstrand

Re: [Mesa-dev] [PATCH 05/24] i965/cnl: Include gen10_pack.h

4-5 are Reviewed-by: Jason Ekstrand On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/genX_pack.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[Mesa-dev] [PATCH] mapi: Enable assembly language API acceleration for PPC64LE (V2)

Implement assembly language API acceleration for PPC64LE, analogous to long-standing implementations for X86 and X86-64. See also similar implementation in libglvnd. Tested with Piglit. Signed-off-by: Ben Crocker --- configure.ac | 12 +++

Re: [Mesa-dev] [PATCH 00/12] Add Cannonlake support

I now have a v2 of this series on the list with 24 patches. So, please don't spend any time reviewing this v1 series. Thanks. On Fri, Apr 14, 2017 at 5:35 PM, Anuj Phogat wrote: > This series adds a preliminary support for Cannonlake. We > still end up using gen9 paths in

Re: [Mesa-dev] [PATCH 15/30] i965/miptree: Add new entrypoints for resolve management

On Fri, May 26, 2017 at 04:30:19PM -0700, Jason Ekstrand wrote: > This commit adds a new unified interface for doing resolves. The basic > format is that, prior to any surface access such as texturing or > rendering, you call intel_miptree_prepare_access. If the surface was > written, you call

Re: [Mesa-dev] [PATCH 06/12] i965/cnl: Modify thread count shift for VS

I just realized that I already dropped this patch in v2 of the series. Please review the latest series with 24 patches. Thanks. On Fri, Jun 2, 2017 at 4:23 PM, Anuj Phogat wrote: > Yes, I'll drop the patch. > > On Fri, Jun 2, 2017 at 11:38 AM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 06/12] i965/cnl: Modify thread count shift for VS

Yes, I'll drop the patch. On Fri, Jun 2, 2017 at 11:38 AM, Jason Ekstrand wrote: > I think this patch can be dropped with Rafiel's genxml work. > > On Fri, Apr 14, 2017 at 5:35 PM, Anuj Phogat wrote: >> >> From: Ben Widawsky

Re: [Mesa-dev] [PATCH V2 15/24] i965/cnl: Start using CNL MOCS defines

Reviewed-by: Jason Ekstrand On Fri, Jun 2, 2017 at 4:06 PM, Jason Ekstrand wrote: > On Mon, May 22, 2017 at 9:54 AM, Rafael Antognolli < > rafael.antogno...@intel.com> wrote: > >> On Tue, May 16, 2017 at 04:01:30PM -0700, Anuj Phogat wrote: >> > On

Re: [Mesa-dev] [PATCH V2 15/24] i965/cnl: Start using CNL MOCS defines

On Mon, May 22, 2017 at 9:54 AM, Rafael Antognolli < rafael.antogno...@intel.com> wrote: > On Tue, May 16, 2017 at 04:01:30PM -0700, Anuj Phogat wrote: > > On Tue, May 16, 2017 at 10:34 AM, Anuj Phogat > wrote: > > > CNL MOCS defines are duplicates of SKL MOCS defines. > >

Re: [Mesa-dev] [PATCH 08/30] i965: Inline renderbuffer_att_set_needs_depth_resolve

On Fri, Jun 2, 2017 at 2:41 PM, Chad Versace wrote: > On Fri 26 May 2017, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_clear.c | 12 ++-- > > src/mesa/drivers/dri/i965/brw_draw.c | 12 +++- > > src/mesa/drivers/dri/i965/intel_fbo.c |

Re: [Mesa-dev] [PATCH 09/30] i965/miptree: Move color resolve on map to intel_miptree_map

On Fri, Jun 2, 2017 at 3:03 PM, Chad Versace wrote: > On Fri 26 May 2017, Jason Ekstrand wrote: > > None of the other methods such as blit work with CCS either so we need > > to do the resolve for all maps. > > Not exactly. No down-resolve is needed for maps with >

[Mesa-dev] [PATCH 2/2] radv: Dirty all descriptors sets when changng the pipeline.

Sets could have been ignored during previous descriptor set flush due to the shader not using them and therefore no SGPR being assigned. Signed-off-by: Bas Nieuwenhuizen Fixes: ae61ddabe8c "radv: move userdata sgpr ownership to compiler side." ---

[Mesa-dev] [PATCH 1/2] radv: Set both compute and graphics SGPRS on descriptor set flush.

We clear the descriptors_dirty array afterwards, so the SGPRs for the other pipeline don't get updated on the flush for that other draw/dispatch, so we have to make sure we do it immediately. Signed-off-by: Bas Nieuwenhuizen Fixes: ae61ddabe8c "radv: move userdata sgpr

Re: [Mesa-dev] [PATCH 10/30] i965/blorp: Take an explicit fast clear op in resolve_color

On Fri 26 May 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 15 ++- > src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 15 ++- > 3 files changed, 18 insertions(+), 15

Re: [Mesa-dev] [PATCH 09/30] i965/miptree: Move color resolve on map to intel_miptree_map

On Fri 26 May 2017, Jason Ekstrand wrote: > None of the other methods such as blit work with CCS either so we need > to do the resolve for all maps. Not exactly. No down-resolve is needed for maps with GL_MAP_INVALIDATE_RANGE_BIT. But that's a separate problem for a separate patch. Reviewed-by:

Re: [Mesa-dev] [PATCH 08/30] i965: Inline renderbuffer_att_set_needs_depth_resolve

On Fri 26 May 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_clear.c | 12 ++-- > src/mesa/drivers/dri/i965/brw_draw.c | 12 +++- > src/mesa/drivers/dri/i965/intel_fbo.c | 15 --- > src/mesa/drivers/dri/i965/intel_fbo.h | 3 --- > 4 files changed,

Re: [Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

On Fri, Jun 02, 2017 at 01:05:47PM -0700, Jason Ekstrand wrote: > On Fri, Jun 2, 2017 at 12:57 PM, Nanley Chery wrote: > > > On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote: > > > This enum describes all of the states that a auxiliary compressed > >

Re: [Mesa-dev] [PATCH 07/30] i965: Get rid of intel_renderbuffer_resolve_*

On Fri 26 May 2017, Jason Ekstrand wrote: > There is exactly one caller so it's a bit pointless to have all of this > plumbing. Just inline it at the one place it's used. > --- > src/mesa/drivers/dri/i965/brw_context.c | 7 +-- > src/mesa/drivers/dri/i965/intel_fbo.c | 26

Re: [Mesa-dev] [PATCH 06/30] i965/miptree: Refactor intel_miptree_resolve_color

On Wed 31 May 2017, Jason Ekstrand wrote: > On Tue, May 30, 2017 at 12:40 AM, Pohjolainen, Topi <[1] > topi.pohjolai...@gmail.com> wrote: > > On Fri, May 26, 2017 at 04:30:10PM -0700, Jason Ekstrand wrote: > > The new version now takes a range of levels as well as a range of > >

Re: [Mesa-dev] [PATCH 05/30] i965/miptree: Clean up the depth resolve helpers a little

On Fri 26 May 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 70 > --- > 1 file changed, 30 insertions(+), 40 deletions(-) Patch 5 is Reviewed-by: Chad Versace ___

Re: [Mesa-dev] [PATCH 04/30] i965/miptree: Store fast clear colors in an isl_color_value

On Fri 26 May 2017, Jason Ekstrand wrote: > This commit, out of necessity, makes a number of changes at once: > > 1) Changes intel_mipmap_tree to store the clear color for both color > and depth as an isl_color_value. > > 2) Changes the depth/stencil emit code to do the format conversion

Re: [Mesa-dev] [PATCH 01/30] i965: Mark depth surfaces as needing a HiZ resolve after blitting

On Fri 02 Jun 2017, Jason Ekstrand wrote: > On Fri, Jun 2, 2017 at 1:01 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Wed 31 May 2017, Pohjolainen, Topi wrote: > > On Wed, May 31, 2017 at 10:22:09AM -0700, Jason Ekstrand wrote: > > > On Tue, May 30, 2017 at 7:29 AM,

Re: [Mesa-dev] [PATCH 01/30] i965: Mark depth surfaces as needing a HiZ resolve after blitting

On Fri, Jun 2, 2017 at 1:01 PM, Chad Versace wrote: > On Wed 31 May 2017, Pohjolainen, Topi wrote: > > On Wed, May 31, 2017 at 10:22:09AM -0700, Jason Ekstrand wrote: > > > On Tue, May 30, 2017 at 7:29 AM, Pohjolainen, Topi < > > > topi.pohjolai...@gmail.com> wrote: > >

Re: [Mesa-dev] [PATCH 03/30] intel/isl: Add a helper for determining if a color is 0/1

On Fri 26 May 2017, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 19 +++ > src/intel/isl/isl.h | 4 > 2 files changed, 23 insertions(+) > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index 321850e..4eec2fd 100644 > --- a/src/intel/isl/isl.c > +++

Re: [Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

On Fri, Jun 2, 2017 at 12:57 PM, Nanley Chery wrote: > On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote: > > This enum describes all of the states that a auxiliary compressed > ^ >

Re: [Mesa-dev] [PATCH 02/30] i965/surface_state: Images can't handle CCS at all

On Fri 26 May 2017, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Patch 2 is Reviewed-by: Chad Versace ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 01/30] i965: Mark depth surfaces as needing a HiZ resolve after blitting

On Wed 31 May 2017, Pohjolainen, Topi wrote: > On Wed, May 31, 2017 at 10:22:09AM -0700, Jason Ekstrand wrote: > > On Tue, May 30, 2017 at 7:29 AM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > On Fri, May 26, 2017 at 04:30:05PM -0700, Jason Ekstrand wrote: > > > > > Cc:

Re: [Mesa-dev] [PATCH 14/30] intel/isl: Add an enum for describing auxiliary compression state

On Fri, May 26, 2017 at 04:30:18PM -0700, Jason Ekstrand wrote: > This enum describes all of the states that a auxiliary compressed ^ an > surface can have. All of the states as well as normative language

Re: [Mesa-dev] [PATCH] tgsi/scan: fix scanning fragment shaders with PrimID and Position/Face

On 06/01/2017 12:10 PM, Marek Olšák wrote: From: Marek Olšák Not relevant to radeonsi, because Position/Face are system values with radeonsi, while this codepath is for drivers where Position and Face are ordinary inputs. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 17

Re: [Mesa-dev] [PATCH 1/3] mesa: only emit _NEW_MULTISAMPLE when coverage parameters change

On 06/02/2017 09:52 AM, Samuel Pitoiset wrote: We usually check that given parameters are different before updating the state. Signed-off-by: Samuel Pitoiset --- src/mesa/main/multisample.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

Re: [Mesa-dev] [PATCH 20/24] i965/cnl: Don't resolve single sampled color rb in case of sRGB formats

On Tue, May 16, 2017 at 3:41 PM, Anuj Phogat wrote: > On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat > wrote: > > As sRGB now supports lossless compression, don't we also need to stop > > resolving single sampled color render buffers for sRGB formats

Re: [Mesa-dev] [PATCH 06/12] i965/cnl: Modify thread count shift for VS

I think this patch can be dropped with Rafiel's genxml work. On Fri, Apr 14, 2017 at 5:35 PM, Anuj Phogat wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- >

[Mesa-dev] [Bug 101071] compiling glsl fails with undefined reference to `pthread_create'

https://bugs.freedesktop.org/show_bug.cgi?id=101071 --- Comment #13 from Emil Velikov --- Created attachment 131682 --> https://bugs.freedesktop.org/attachment.cgi?id=131682=edit configure.ac: add -pthread to PTHREAD_LIBS Right, so util_queue_init() pulls

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #9 from jdr...@gmail.com --- Created attachment 131681 --> https://bugs.freedesktop.org/attachment.cgi?id=131681=edit opengl renderer: water is ok -- You are receiving this mail because: You are the assignee for the bug. You are

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #8 from jdr...@gmail.com --- Created attachment 131680 --> https://bugs.freedesktop.org/attachment.cgi?id=131680=edit vulkan renderer: water is missing -- You are receiving this mail because: You are the assignee for the bug. You

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #7 from jdr...@gmail.com --- Created attachment 131679 --> https://bugs.freedesktop.org/attachment.cgi?id=131679=edit fifo log file (missing water) -- You are receiving this mail because: You are the QA Contact for the bug. You

[Mesa-dev] [Bug 100430] [radv] graphical glitches on dolphin emulator

https://bugs.freedesktop.org/show_bug.cgi?id=100430 --- Comment #6 from jdr...@gmail.com --- Back to mesa stable 17.1, arch x64, fury r9, I still have some problems with vulkan. The game tested is "Wii Sport Resort". I've recorded a fifolog If I select "Vulkan Renderer" in dolphin and if I launch

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #40 from Ben Crocker --- (In reply to Stefan Dirsch from comment #39) > (In reply to Ben Crocker from comment #36) > > So far, at least on this bug (or cluster of bugs), we have seen the > > same behavior on

[Mesa-dev] [PATCH v2 1/2] Android: amdgpu_common is only required when building OpenCL

v2: split off Android changes Signed-off-by: Jan Vesely --- src/gallium/drivers/r600/Android.mk | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/r600/Android.mk b/src/gallium/drivers/r600/Android.mk index 87f433d..18c5bb6 100644 ---

[Mesa-dev] [PATCH v2 2/2] configure, r600: amd_common is needed only for OpenCL

v2: split off Android changes add comments Signed-off-by: Jan Vesely Tested-By: Aaron Watry --- Aaron, the diff is mostly the same as v1 (modulo comments), hope you don't mind reusing your tested by. Jan configure.ac

Re: [Mesa-dev] [PATCH 1/1] automake: r600 should only depend on libamd_common if opencl is enabled

On Fri, 2017-06-02 at 17:22 +0100, Emil Velikov wrote: > On 2 June 2017 at 16:34, Jan Vesely wrote: > > On Fri, 2017-06-02 at 12:19 +0100, Emil Velikov wrote: > > > On 1 June 2017 at 21:28, Jan Vesely wrote: > > > > Signed-off-by: Jan Vesely

Re: [Mesa-dev] [PATCH 1/1] automake: r600 should only depend on libamd_common if opencl is enabled

On 2 June 2017 at 16:34, Jan Vesely wrote: > On Fri, 2017-06-02 at 12:19 +0100, Emil Velikov wrote: >> On 1 June 2017 at 21:28, Jan Vesely wrote: >> > Signed-off-by: Jan Vesely >> > --- >> > Hi guys, >> > >> > this is the

[Mesa-dev] [Bug 101071] compiling glsl fails with undefined reference to `pthread_create'

https://bugs.freedesktop.org/show_bug.cgi?id=101071 --- Comment #12 from war...@o2.pl --- Emil, Due 762a6333f21fd8606f69db6060027c4522d46678 I can't use git auto bisect and need to do it manually with this commit reverted. Here are results: 2e98db6... util/vk: Add helpers for finding an

[Mesa-dev] [PATCH 2/3] mesa: only emit _NEW_MULTISAMPLE when sample mask changes

We usually check that given parameters are different before updating the state. Signed-off-by: Samuel Pitoiset --- src/mesa/main/multisample.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c index

[Mesa-dev] [PATCH 3/3] mesa: only emit _NEW_MULTISAMPLE when min sample shading changes

We usually check that given parameters are different before updating the state. Signed-off-by: Samuel Pitoiset --- src/mesa/main/multisample.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/multisample.c

[Mesa-dev] [PATCH 1/3] mesa: only emit _NEW_MULTISAMPLE when coverage parameters change

We usually check that given parameters are different before updating the state. Signed-off-by: Samuel Pitoiset --- src/mesa/main/multisample.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/multisample.c

Re: [Mesa-dev] [PATCH 1/1] automake: r600 should only depend on libamd_common if opencl is enabled

On Thu, 2017-06-01 at 16:22 -0500, Aaron Watry wrote: > On Thu, Jun 1, 2017 at 3:28 PM, Jan Vesely wrote: > > > Signed-off-by: Jan Vesely > > --- > > Hi guys, > > > > this is the first step towards dropping libamd_common dependency. > > It's

Re: [Mesa-dev] [PATCH 1/1] automake: r600 should only depend on libamd_common if opencl is enabled

On Fri, 2017-06-02 at 12:19 +0100, Emil Velikov wrote: > On 1 June 2017 at 21:28, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > Hi guys, > > > > this is the first step towards dropping libamd_common dependency. > > It's based on

Re: [Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal number

On 2 June 2017 at 14:56, Vlad Golovkin wrote: > -- Forwarded message -- > From: Vlad Golovkin > Date: 2017-06-02 16:55 GMT+03:00 > Subject: Re: [Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal > number > To:

[Mesa-dev] [Bug 100988] glXGetCurrentDisplay() no longer works for FakeGLX contexts?

https://bugs.freedesktop.org/show_bug.cgi?id=100988 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] Fwd: [PATCH] glcpp: simplify the check for hexadecimal number

-- Forwarded message -- From: Vlad Golovkin Date: 2017-06-02 16:55 GMT+03:00 Subject: Re: [Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal number To: Emil Velikov 2017-06-02 16:07 GMT+03:00 Emil Velikov

Re: [Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal number

Hi Vlad, Welcome to Mesa. Have you don't any benchmarking on this patch via something like shader-db [1]? Mentioning the results in the commit message is encouraged. On 2 June 2017 at 13:37, Vlad Golovkin wrote: > This will make it possible to remove unnecessary

Re: [Mesa-dev] [PATCH 3/4] radeonsi: fix gl_PrimitiveID in tessellation with instanced draws on SI

On Wed, May 3, 2017 at 3:58 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/gallium/drivers/radeonsi/si_state_draw.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 1/3] mesa: remove call to Driver.Scissor() in _mesa_WindowRectanglesEXT()

On 06/02/2017 02:44 PM, Ilia Mirkin wrote: On Fri, Jun 2, 2017 at 8:40 AM, Samuel Pitoiset wrote: On 06/02/2017 02:34 PM, Ilia Mirkin wrote: As I mentioned to you on IRC... my understanding of the Driver.Scissor callback is that it's a guarantee by the mesa

Re: [Mesa-dev] [PATCH 1/3] mesa: remove call to Driver.Scissor() in _mesa_WindowRectanglesEXT()

On Fri, Jun 2, 2017 at 8:40 AM, Samuel Pitoiset wrote: > > > On 06/02/2017 02:34 PM, Ilia Mirkin wrote: >> >> As I mentioned to you on IRC... my understanding of the Driver.Scissor >> callback is that it's a guarantee by the mesa core that whenever >> Scissor.* changes,

Re: [Mesa-dev] [PATCH mesa 2/2] egl/display: make platform detection thread-safe

On 1 June 2017 at 15:52, Grazvydas Ignotas wrote: > On Thu, Jun 1, 2017 at 4:23 PM, Emil Velikov wrote: >> Hi guys, >> >> On 1 June 2017 at 12:56, Grazvydas Ignotas wrote: >>> On Thu, Jun 1, 2017 at 2:15 PM, Eric Engestrom >>>

Re: [Mesa-dev] [PATCH 1/3] mesa: remove call to Driver.Scissor() in _mesa_WindowRectanglesEXT()

On 06/02/2017 02:34 PM, Ilia Mirkin wrote: As I mentioned to you on IRC... my understanding of the Driver.Scissor callback is that it's a guarantee by the mesa core that whenever Scissor.* changes, Driver.Scissor() gets called if it's there. Just because nothing cares on the other side of the

[Mesa-dev] [PATCH] glcpp: simplify the check for hexadecimal number

This will make it possible to remove unnecessary strlen and strncmp calls. --- src/compiler/glsl/glcpp/glcpp-parse.y | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y b/src/compiler/glsl/glcpp/glcpp-parse.y index

Re: [Mesa-dev] [PATCH 1/3] mesa: remove call to Driver.Scissor() in _mesa_WindowRectanglesEXT()

As I mentioned to you on IRC... my understanding of the Driver.Scissor callback is that it's a guarantee by the mesa core that whenever Scissor.* changes, Driver.Scissor() gets called if it's there. Just because nothing cares on the other side of the abstraction barrier doesn't implicitly mean it

[Mesa-dev] [PATCH 2/3] mesa: add new gl_driver_flags::NewWindowRectangles

This new driver flag will replace _NEW_SCISSOR which is emitted when setting new window rectangles but it actually triggers useless changes in the state tracker (like scissor and rasterizer). EXT_window_rectangles is currently only supported by Nouveau. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH 3/3] mesa: make use of NewWindowRectangles driver flags

Now, st_update_window_rectangles() won't be called when the scissor is going to be updated. Signed-off-by: Samuel Pitoiset --- src/mesa/main/scissor.c | 4 +++- src/mesa/state_tracker/st_context.c | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-)

[Mesa-dev] [PATCH 1/3] mesa: remove call to Driver.Scissor() in _mesa_WindowRectanglesEXT()

This is actually useless because this driver call is only used by the classic DRI drivers which don't support that extension and probably won't never support it. Signed-off-by: Samuel Pitoiset --- src/mesa/main/scissor.c | 3 --- 1 file changed, 3 deletions(-) diff

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #39 from Stefan Dirsch --- (In reply to Ben Crocker from comment #36) > So far, at least on this bug (or cluster of bugs), we have seen the > same behavior on both S390 and big-endian Power8 (PPC64). Power8 is

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #38 from Stefan Dirsch --- (In reply to intermedi...@hotmail.com from comment #35) > just for information > here my story about with Michel Danze reply > https://bugs.freedesktop.org/show_bug.cgi?id=99859#c19 > >

Re: [Mesa-dev] [PATCH 1/1] automake: r600 should only depend on libamd_common if opencl is enabled

On 1 June 2017 at 21:28, Jan Vesely wrote: > Signed-off-by: Jan Vesely > --- > Hi guys, > > this is the first step towards dropping libamd_common dependency. > It's based on Emil's patches 3/5 and 4/5. > Enabling opencl still falls back to the old

Re: [Mesa-dev] [PATCH] mapi: Enable assembly language API acceleration for PPC64LE

Hi guys, Ben please add some commit message. If nothing obvious comes to mind, do mention how you tested the patch. My PPC ASM is quite limited, so there's only minor suggestions below. > --- a/src/mapi/Makefile.sources > +++ b/src/mapi/Makefile.sources > @@ -15,6 +15,7 @@ > #this mode,

Re: [Mesa-dev] [PATCH 03/11] radeonsi: decrease the number of compiler threads to num CPUs - 1

On Fri, Jun 2, 2017 at 11:26 AM, Grazvydas Ignotas wrote: > With the "core wars" starting (16core/32thread "consumer" CPUs > announced), maybe it's time to add an upper limit? Waking up a core > from low power state has it's latency, it's sometimes faster to just > do several

Re: [Mesa-dev] [PATCH 03/11] radeonsi: decrease the number of compiler threads to num CPUs - 1

With the "core wars" starting (16core/32thread "consumer" CPUs announced), maybe it's time to add an upper limit? Waking up a core from low power state has it's latency, it's sometimes faster to just do several jobs on an active core than to wake another one (which will also cause more lock