Re: [Mesa-dev] [Mesa-stable] [PATCH 00/16] anv: Fix our 48-bit problems

On July 3, 2017 12:31:48 PM Andres Gomez wrote: Never too late! ☺ On Fri, 2017-06-30 at 16:45 -0700, Jason Ekstrand wrote: I know this is rather late but On June 26, 2017 1:15:16 PM Andres Gomez wrote: > Jason, you CCed this whole series for

Re: [Mesa-dev] [RFC PATCH 2/2] ac/nir: Don't treat each element as a vec4 in compute shared memory

I'm going to do a full CTS run later this week before I send the patches to the list, but can you confirm that this series fixes your problems: https://cgit.freedesktop.org/~cwabbott0/mesa/log/?h=radv-rewrite-vars (it passes all the CTS dEQP.compute.* tests, but that's not saying much...) On Mon,

Re: [Mesa-dev] [RFC PATCH 2/2] ac/nir: Don't treat each element as a vec4 in compute shared memory

I think a better approach would be to translate the NIR variables directly to LLVM variables instead of creating one giant LLVM variable. I have a series coming up that does a similar thing for local variables, I can try and convert shared variables too. On Tue, Jun 27, 2017 at 8:53 AM, Alex

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

What check is configure doing? Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV? Cheers, Rafael Andy Furniss writes: > Don't know if mesa needs changing or it's an llvm needs fixing issue, > but since llvm commit > > commit

Re: [Mesa-dev] [PATCH 00/16]: Allow Gallium drivers to support driver-specific drirc options

For all patches except 5: Reviewed-by: Marek Olšák For patch 5: Acked-by: Marek Olšák Marek On Fri, Jun 30, 2017 at 2:45 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Hi all, > > This is a big

Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

Looks good to me, but admittedly not an expert. Acked-by: Lionel Landwerlin On 03/07/17 22:08, Ilia Mirkin wrote: _mesa_glsl_has_builtin_function is used to determine whether any variant of a builtin are available, for the purpose of enforcing the GLSL ES 3.00+

Re: [Mesa-dev] [PATCH 18/92] gallium: add PIPE_CAP_NIR_LOWER_IO

On Mon, Jul 3, 2017 at 3:10 PM, Nicolai Hähnle wrote: > On 03.07.2017 23:10, Connor Abbott wrote: >> >> Hi Nicolai, >> >> On Mon, Jul 3, 2017 at 6:23 AM, Nicolai Hähnle wrote: >>> >>> Hi Connor, >>> >>> On 27.06.2017 02:25, Connor Abbott wrote:

Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

On 04/07/17 08:11, Ilia Mirkin wrote: Yeah I'll add a compiler test. Thanks :) Reviewed-by: Timothy Arceri On Mon, Jul 3, 2017 at 6:02 PM, Timothy Arceri wrote: This seems reasonable, but are there some piglit tests to go with this? I didn't

Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

Yeah I'll add a compiler test. On Mon, Jul 3, 2017 at 6:02 PM, Timothy Arceri wrote: > This seems reasonable, but are there some piglit tests to go with this? I > didn't see any on the list. At least one test for this would be nice. > > > On 04/07/17 07:08, Ilia Mirkin

Re: [Mesa-dev] [PATCH 18/92] gallium: add PIPE_CAP_NIR_LOWER_IO

On 03.07.2017 23:10, Connor Abbott wrote: Hi Nicolai, On Mon, Jul 3, 2017 at 6:23 AM, Nicolai Hähnle wrote: Hi Connor, On 27.06.2017 02:25, Connor Abbott wrote: Ok, so I just looked into it a little further, and I guess that since nir_to_llvm needs to know about the ABI

Re: [Mesa-dev] [PATCH 17.5/18] nir/spirv: Stop trying to convert pointers to SSA in glsl450

This, and patch 18 updated to delete the case in vtn_ssa_value() are: Reviewed-by: Connor Abbott On Fri, Jun 30, 2017 at 10:30 PM, Jason Ekstrand wrote: > Cc: Connor Abbott > > --- > src/compiler/spirv/vtn_glsl450.c | 7 ++-

Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

This seems reasonable, but are there some piglit tests to go with this? I didn't see any on the list. At least one test for this would be nice. On 04/07/17 07:08, Ilia Mirkin wrote: _mesa_glsl_has_builtin_function is used to determine whether any variant of a builtin are available, for the

Re: [Mesa-dev] [PATCH 06/92] nir/lower_system_values: add support for the FRAG_COORD system value

On Mon, Jul 3, 2017 at 2:34 PM, Timothy Arceri wrote: > On 04/07/17 06:19, Connor Abbott wrote: >> >> On Mon, Jul 3, 2017 at 8:51 AM, Nicolai Hähnle wrote: >>> >>> On 03.07.2017 02:50, Timothy Arceri wrote: On 03/07/17 10:46, Timothy

[Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

https://bugs.freedesktop.org/show_bug.cgi?id=101666 --- Comment #7 from Ilia Mirkin --- https://patchwork.freedesktop.org/patch/164980/ should do the trick. -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

Emil Velikov wrote: On 3 July 2017 at 16:31, Andy Furniss wrote: Rafael Avila de Espindola wrote: What check is configure doing? Not sure just a user. Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV? It is a clean build. A reply to the list

Re: [Mesa-dev] [PATCH 06/92] nir/lower_system_values: add support for the FRAG_COORD system value

On 04/07/17 06:19, Connor Abbott wrote: On Mon, Jul 3, 2017 at 8:51 AM, Nicolai Hähnle wrote: On 03.07.2017 02:50, Timothy Arceri wrote: On 03/07/17 10:46, Timothy Arceri wrote: This and the previous patch seem a bit hacky to me. It seems it would be better to either

Re: [Mesa-dev] [PATCH 18/92] gallium: add PIPE_CAP_NIR_LOWER_IO

Hi Nicolai, On Mon, Jul 3, 2017 at 6:23 AM, Nicolai Hähnle wrote: > Hi Connor, > > On 27.06.2017 02:25, Connor Abbott wrote: >> >> Ok, so I just looked into it a little further, and I guess that since >> nir_to_llvm needs to know about the ABI to know where all the >>

[Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

_mesa_glsl_has_builtin_function is used to determine whether any variant of a builtin are available, for the purpose of enforcing the GLSL ES 3.00+ rule that overloads or overrides of builtins are disallowed. However the builtin_builder contains information on all builtins, irrespective of parse

Re: [Mesa-dev] [PATCH 1/2] i965: Use true AA line distance on G45/Ironlake.

It looks like we could want these 2 into -stable (?) On Wed, 2017-04-26 at 15:15 -0700, Kenneth Graunke wrote: > The original Broadwater and Crestline platforms computed antialiased > line distances using "manhattan" distance, aka a + b = c. Eaglelake > and Cantiga added "true" distance, aka a^2

Re: [Mesa-dev] [PATCH 10/14] gallium/radeon: clean up pb_cache bucket/usage determination

On 03.07.2017 22:26, Marek Olšák wrote: On Mon, Jul 3, 2017 at 9:51 PM, Nicolai Hähnle wrote: On 29.06.2017 21:47, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h| 20

[Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

https://bugs.freedesktop.org/show_bug.cgi?id=101666 --- Comment #6 from Ilia Mirkin --- Just to illustrate my point further (and apologies for not properly compensating for bz's unfortunate email-to-bug integration): $ cat foo.shader_test [require] GL ES >= 3.0 GLSL ES

Re: [Mesa-dev] [PATCH 08/14] gallium/radeon: clean up (domain, flags) <-> (slab heap) translations

On 03.07.2017 22:09, Marek Olšák wrote: On Mon, Jul 3, 2017 at 9:47 PM, Nicolai Hähnle wrote: On 29.06.2017 21:47, Marek Olšák wrote: From: Marek Olšák This is cleaner, and we are down to 4 slabs. --- src/gallium/drivers/radeon/radeon_winsys.h

[Mesa-dev] [Bug 101467] swr driver leaks memory (texture management)

https://bugs.freedesktop.org/show_bug.cgi?id=101467 --- Comment #6 from Bruce Cherniak --- Fixed in master by commit 32c1a54b. cc'd for inclusion in 17.1 stable. This patch limits the number of items on the fence work queue (the deferred deletion list) by submitting a

Re: [Mesa-dev] [PATCH 10/14] gallium/radeon: clean up pb_cache bucket/usage determination

On Mon, Jul 3, 2017 at 9:51 PM, Nicolai Hähnle wrote: > On 29.06.2017 21:47, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/radeon_winsys.h| 20 >> src/gallium/winsys/amdgpu/drm/amdgpu_bo.c

Re: [Mesa-dev] [PATCH 06/92] nir/lower_system_values: add support for the FRAG_COORD system value

On Mon, Jul 3, 2017 at 8:51 AM, Nicolai Hähnle wrote: > On 03.07.2017 02:50, Timothy Arceri wrote: >> >> On 03/07/17 10:46, Timothy Arceri wrote: >>> >>> This and the previous patch seem a bit hacky to me. It seems it would be >>> better to either plum the system value all the

Re: [Mesa-dev] [PATCH 08/14] gallium/radeon: clean up (domain, flags) <-> (slab heap) translations

On Mon, Jul 3, 2017 at 9:47 PM, Nicolai Hähnle wrote: > On 29.06.2017 21:47, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This is cleaner, and we are down to 4 slabs. >> --- >> src/gallium/drivers/radeon/radeon_winsys.h| 62 >>

Re: [Mesa-dev] [PATCH 1/6] i965: Make Gen4-5 SF_STATE use the point size calculations from Gen6+.

It looks like we could want this whole series into -stable (?) On Wed, 2017-05-10 at 11:47 -0700, Kenneth Graunke wrote: > Apparently, Nanhai made the Gen4-5 point size calculations round to the > nearest integer in commit 8d5231a3582e4f2769ac0685cf0174e09750700e, > "according to spec". When

Re: [Mesa-dev] [PATCH 1/2] intel/isl: Use uint64_t to store total surface size

It looks like we could want these 2 into -stable (?) On Tue, 2017-05-23 at 14:37 -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/isl/isl.c | 3 ++- > src/intel/isl/isl.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 14/14] winsys/amdgpu: use 128KB BOs for suballocations of up to 64KB BOs

On 29.06.2017 21:47, Marek Olšák wrote: From: Marek Olšák This decreases the number of BOs, but might also increase memory usage. It's better for small textures. The gameplay is on the far right: https://people.freedesktop.org/~mareko/suballoc.svg Patches 11-14:

Re: [Mesa-dev] [PATCH 10/14] gallium/radeon: clean up pb_cache bucket/usage determination

On 29.06.2017 21:47, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h| 20 src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 21 + src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 21

Re: [Mesa-dev] [PATCH 09/14] gallium/radeon: enable suballocations for VRAM with no CPU access

On 29.06.2017 21:47, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/radeon_winsys.h| 15 --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 3 +++ src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 +++ 3 files changed, 18

Re: [Mesa-dev] [PATCH 08/14] gallium/radeon: clean up (domain, flags) <-> (slab heap) translations

On 29.06.2017 21:47, Marek Olšák wrote: From: Marek Olšák This is cleaner, and we are down to 4 slabs. --- src/gallium/drivers/radeon/radeon_winsys.h| 62 +++ src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 44 +++-

Re: [Mesa-dev] [PATCH 07/14] gallium/radeon: remove RADEON_FLAG_CPU_ACCESS

On 30.06.2017 13:52, Marek Olšák wrote: On Fri, Jun 30, 2017 at 4:49 AM, Michel Dänzer wrote: On 30/06/17 04:47 AM, Marek Olšák wrote: From: Marek Olšák https://lists.freedesktop.org/archives/amd-gfx/2017-June/010591.html This is premature. The

Re: [Mesa-dev] [Mesa-stable] [PATCH 00/16] anv: Fix our 48-bit problems

Never too late! ☺ On Fri, 2017-06-30 at 16:45 -0700, Jason Ekstrand wrote: > I know this is rather late but > > On June 26, 2017 1:15:16 PM Andres Gomez wrote: > > > Jason, you CCed this whole series for stable. However: > > * Patch 1/16 already landed, but without the

Re: [Mesa-dev] [PATCH] st/mesa: fix tessellation shaders with no support for shareable shaders

Reviewed-by: Nicolai Hähnle On 01.07.2017 17:41, Marek Olšák wrote: From: Marek Olšák Broken by: b43c887a9bf1e3fb99b0dc22bfea5db81375a06e Reported by Gert Wollny. --- src/mesa/state_tracker/st_atom_shader.c | 4 ++-- 1 file changed, 2

Re: [Mesa-dev] [PATCH 2/2] radeonsi: drop few partial flushes when uploading bindless descriptors

On 03.07.2017 18:33, Samuel Pitoiset wrote: On 07/03/2017 06:16 PM, Samuel Pitoiset wrote: On 07/03/2017 06:09 PM, Nicolai Hähnle wrote: On 03.07.2017 18:03, Nicolai Hähnle wrote: On 29.06.2017 21:59, Samuel Pitoiset wrote: Only emit partial flushes when the underlying shader stages are

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

On 3 July 2017 at 16:31, Andy Furniss wrote: > Rafael Avila de Espindola wrote: >> >> What check is configure doing? > > > Not sure just a user. > >> Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV? > > > It is a clean build. > A reply to the list

Re: [Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

I'd like the chance to look at these, please. I'm on vacation today and tomorrow though. On July 3, 2017 7:19:04 AM funfunc...@folklore1984.net wrote: On 2017-07-03 08:47, Timothy Arceri wrote: While it produces functioning code the pass creates worse code for arrays of arrays. See the

Re: [Mesa-dev] [PATCH v2 3/4] glsl: explicitly zero out padding to gl_shader_variable bitfield

Reviewed-by: Marek Olšák Marek On Mon, Jul 3, 2017 at 2:34 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Otherwise, the padding bits remain undefined, which leads to valgrind > errors when storing the gl_shader_variable

Re: [Mesa-dev] [PATCH 2/2] radeonsi: drop few partial flushes when uploading bindless descriptors

On 07/03/2017 06:16 PM, Samuel Pitoiset wrote: On 07/03/2017 06:09 PM, Nicolai Hähnle wrote: On 03.07.2017 18:03, Nicolai Hähnle wrote: On 29.06.2017 21:59, Samuel Pitoiset wrote: Only emit partial flushes when the underlying shader stages are using bindless samplers or images. This gets

Re: [Mesa-dev] [PATCH 04/11] gbm: Axe buffer import format conversion table

On 3 July 2017 at 14:22, Daniel Stone wrote: > Hi Emil, > > On 3 July 2017 at 12:06, Emil Velikov wrote: >> On 16 June 2017 at 18:14, Daniel Stone wrote: >>> + /* GBM_FORMAT_* is identical to WL_DRM_FORMAT_*, so no

Re: [Mesa-dev] [PATCH 2/2] radeonsi: drop few partial flushes when uploading bindless descriptors

On 07/03/2017 06:09 PM, Nicolai Hähnle wrote: On 03.07.2017 18:03, Nicolai Hähnle wrote: On 29.06.2017 21:59, Samuel Pitoiset wrote: Only emit partial flushes when the underlying shader stages are using bindless samplers or images. This gets rid of 4% of partial flushes in the DOW3

Re: [Mesa-dev] [PATCH 1/4] svga: fix buffer binding flags initialization

>From: Brian Paul >Sent: Sunday, July 2, 2017 8:12 AM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH 1/4] svga: fix buffer binding flags initialization >If a buffer is created/initialized with glNamedBufferData we will >have no target

Re: [Mesa-dev] [PATCH 2/2] radeonsi: drop few partial flushes when uploading bindless descriptors

On 03.07.2017 18:03, Nicolai Hähnle wrote: On 29.06.2017 21:59, Samuel Pitoiset wrote: Only emit partial flushes when the underlying shader stages are using bindless samplers or images. This gets rid of 4% of partial flushes in the DOW3 benchmark. Do those flushes still trigger during play?

Re: [Mesa-dev] [PATCH 1/4] svga: fix buffer binding flags initialization

On 07/03/2017 09:57 AM, Charmaine Lee wrote: From: Brian Paul Sent: Sunday, July 2, 2017 8:12 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 1/4] svga: fix buffer binding flags initialization If a buffer is created/initialized with

Re: [Mesa-dev] [PATCH] radeonsi: fix invalidating bindless buffer descriptors

Reviewed-by: Nicolai Hähnle On 30.06.2017 18:48, Samuel Pitoiset wrote: The VA is stored at [4:5], not [0:1]. This invalidated all texture buffer descriptors when they were made resident in the current context. This removes few partial flushes and cache invalidations

Re: [Mesa-dev] [PATCH 1/2] radeonsi: use a bitfield for tracking which shaders use bindless

On 30.06.2017 00:11, Timothy Arceri wrote: On 30/06/17 05:59, Samuel Pitoiset wrote: This will allow to skip few partial flushes when bindless descriptors have to be re-uploaded. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_blit.c

Re: [Mesa-dev] [PATCH 2/2] radeonsi: drop few partial flushes when uploading bindless descriptors

On 29.06.2017 21:59, Samuel Pitoiset wrote: Only emit partial flushes when the underlying shader stages are using bindless samplers or images. This gets rid of 4% of partial flushes in the DOW3 benchmark. Do those flushes still trigger during play? I'd think it should be possible to

Re: [Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

On 03.07.2017 16:38, Brian Paul wrote: On 07/03/2017 04:45 AM, Nicolai Hähnle wrote: On 03.07.2017 12:44, Nicolai Hähnle wrote: On 03.07.2017 09:43, Gustaw Smolarczyk wrote: 2017-07-03 6:10 GMT+02:00 Robert Foss : On Sun, 2017-07-02 at 21:06 -0700, Matt Turner

Re: [Mesa-dev] [PATCH 06/92] nir/lower_system_values: add support for the FRAG_COORD system value

On 03.07.2017 02:50, Timothy Arceri wrote: On 03/07/17 10:46, Timothy Arceri wrote: This and the previous patch seem a bit hacky to me. It seems it would be better to either plum the system value all the way through NIR for all drivers or simply disable GLSLFragCoordIsSysVal when radeonsi is

Re: [Mesa-dev] [PATCH 12/92] tgsi_from_mesa: add tgsi_get_gl_frag_result_semantic

Reviewed-by: Samuel Pitoiset On 06/26/2017 04:09 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_from_mesa.c | 35 + src/gallium/auxiliary/tgsi/tgsi_from_mesa.h | 5 +

Re: [Mesa-dev] [PATCH 10/92] tgsi, st/mesa: move varying slot to semantic mapping into a helper for VS

Reviewed-by: Samuel Pitoiset On 06/26/2017 04:09 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle We will use this helper in radeonsi's NIR path. --- src/gallium/auxiliary/Makefile.sources | 2 +

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

Rafael Avila de Espindola wrote: What check is configure doing? Not sure just a user. Is the llvm build a clean one? What is the value of LLVM_APPEND_VC_REV? It is a clean build. A reply to the list advised to start using -DLLVM_APPEND_VC_REV=OFF With this it is OK.

Re: [Mesa-dev] [PATCH 11/11] egl/wayland: Use linux-dmabuf interface for buffers

On 3 July 2017 at 13:49, Daniel Stone wrote: > Hey Emil, > > On 3 July 2017 at 13:36, Emil Velikov wrote: >> Not familiar with the linux-dmabuf protocol - Dan, any ideas if we can >> "get away" w/o using u_vector? > > What would you suggest instead

Re: [Mesa-dev] Why are we using server-side GLX fbconfigs?

On Mon, Jul 3, 2017 at 5:58 AM, Michel Dänzer wrote: > On 01/07/17 02:16 AM, Kristian Høgsberg wrote: >> On Fri, Jun 30, 2017 at 2:49 AM, Thomas Hellstrom >> wrote: >>> On 06/29/2017 07:30 PM, Kristian Høgsberg wrote: On Thu, Jun 29, 2017 at 7:36

Re: [Mesa-dev] [PATCH] wglcontext: assorted updates

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Sunday, July 2, 2017 8:07 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] wglcontext: assorted updates Print context flags, vendor,

Re: [Mesa-dev] [PATCH] st/mesa: release EGLImage on EGLImageTarget* error

Reviewed-by: Marek Olšák Marek On Fri, Jun 30, 2017 at 11:03 AM, Philipp Zabel wrote: > The smapi->get_egl_image() call in st_egl_image_get_surface() stores a > reference to the EGLImage's texture in stimg.texture. That reference is > released via

Re: [Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

On 07/03/2017 04:45 AM, Nicolai Hähnle wrote: On 03.07.2017 12:44, Nicolai Hähnle wrote: On 03.07.2017 09:43, Gustaw Smolarczyk wrote: 2017-07-03 6:10 GMT+02:00 Robert Foss : On Sun, 2017-07-02 at 21:06 -0700, Matt Turner wrote: Otherwise known as strlcpy()? I

Re: [Mesa-dev] [PATCH v2 2/3] nir: fix nir_opt_copy_prop_vars() for arrays of arrays

On 2017-07-03 08:47, Timothy Arceri wrote: Previous we only incremented the guide for a single dimension/wildcard. V2: rework logic to avoid code duplication Reviewed-by: Edward O'Callaghan --- src/compiler/nir/nir_opt_copy_prop_vars.c | 12 ++-- 1

Re: [Mesa-dev] [PATCH v2 3/3] glsl: disable array splitting for AoA

On 2017-07-03 08:47, Timothy Arceri wrote: While it produces functioning code the pass creates worse code for arrays of arrays. See the comment added in this patch for more detail. V2: skip splitting of AoA of matrices too. Reviewed-by: Edward O'Callaghan ---

Re: [Mesa-dev] [PATCH v2 1/3] nir: NULL check lower_copies_to_load_store()

On 2017-07-03 08:47, Timothy Arceri wrote: Allows us to disable array spliting for arrays of arrays without regressing tests such as: ES31-CTS.functional.shaders.arrays_of_arrays.return.explicit.struct_3x1x3_fragment Reviewed-by: Edward O'Callaghan ---

Re: [Mesa-dev] [PATCH 09/92] ddebug: handle some cases of non-TGSI shaders

On Tue, Jun 27, 2017 at 10:38 AM, Samuel Pitoiset wrote: > Don't you need to also update dd_unreference_copy_of_draw_state() and > dd_copy_draw_state() ? Indeed. I guess you may wanna do that as a follow-up. Patches 9-15, 17, 20-21, 23-29: Reviewed-by: Marek Olšák

Re: [Mesa-dev] [PATCH 18/92] gallium: add PIPE_CAP_NIR_LOWER_IO

Hi Connor, On 27.06.2017 02:25, Connor Abbott wrote: Ok, so I just looked into it a little further, and I guess that since nir_to_llvm needs to know about the ABI to know where all the "special" inputs/outputs like tess factors, position etc. are, switching radv to using the normal input/output

Re: [Mesa-dev] [PATCH 04/11] gbm: Axe buffer import format conversion table

Hi Emil, On 3 July 2017 at 12:06, Emil Velikov wrote: > On 16 June 2017 at 18:14, Daniel Stone wrote: >> + /* GBM_FORMAT_* is identical to WL_DRM_FORMAT_*, so no conversion >> + * required. */ >> + gbm_format = wb->format; >

Re: [Mesa-dev] [PATCH 11/11] egl/wayland: Use linux-dmabuf interface for buffers

Hey Emil, On 3 July 2017 at 13:36, Emil Velikov wrote: > Not familiar with the linux-dmabuf protocol - Dan, any ideas if we can > "get away" w/o using u_vector? What would you suggest instead of u_vector? When the client connects, for each format, it will receive a

Re: [Mesa-dev] [PATCH] vc4: automake: include vc4_cl_dump.h in

On 3 July 2017 at 13:25, Juan A. Suarez Romero wrote: > Ensure vc4_cl_dump.h and $(BROADCOM_FILES) are distributed in the > dist-file. > > This fixes `make distcheck` Doesn't seem like the patch which introduces the file made it to the list. Either way patch does the right

Re: [Mesa-dev] [PATCH 11/11] egl/wayland: Use linux-dmabuf interface for buffers

On 22 June 2017 at 17:52, Lucas Stach wrote: > Am Freitag, den 16.06.2017, 18:14 +0100 schrieb Daniel Stone: >> When available, use the zwp_linux_dambuf_v1 interface to create buffers, >> which allows multiple planes and buffer modifiers to be used. >> >> Signed-off-by:

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

Laurent Carlier wrote: Le lundi 3 juillet 2017, 13:53:12 CEST Andy Furniss a écrit : Don't know if mesa needs changing or it's an llvm needs fixing issue, but since llvm commit commit 78fbc18aed8024139cb87c5db69ab5b43dc615d6 Author: Rafael Espindola Date: Fri Jun

[Mesa-dev] [PATCH v2 1/4] glsl: look for multiple variables simultaneously with find_assignment_visitor

From: Nicolai Hähnle Save some passes over the IR. v2: redesign to make the users of find_assignments more readable Reviewed-by: Ian Romanick (v1) --- src/compiler/glsl/linker.cpp | 120 --- 1 file

[Mesa-dev] [PATCH v2 3/4] glsl: explicitly zero out padding to gl_shader_variable bitfield

From: Nicolai Hähnle Otherwise, the padding bits remain undefined, which leads to valgrind errors when storing the gl_shader_variable in the disk cache. v2: use rzalloc instead of an explicit padding member variable --- src/compiler/glsl/linker.cpp | 5 - 1 file

[Mesa-dev] [PATCH v2 4/4] glsl/blob: add valgrind checks that written data is defined

From: Nicolai Hähnle Undefined data will eventually trigger a valgrind error while computing its CRC32 while writing it into the disk cache, but at that point, it is basically impossible to track down where the undefined data came from. With this change, finding the

[Mesa-dev] [PATCH v2 0/4] glsl misc cleanups and improvements

From: Nicolai Hähnle Hi all, This is v2 of the remaining part of my recent GLSL misc cleanup series. Patch 1 uses perhaps a bit more ceremony than usual now, but it does look much nicer at the call sites. Patch 2 is unchanged; Timothy was okay with it, but Ian was

[Mesa-dev] [PATCH v2 2/4] glsl: simplify add_uniform_to_shader::visit_field

From: Nicolai Hähnle Each field gets a distinct name, so we should never hit the case where the name already exists in the parameter list. Reviewed-by: Timothy Arceri --- src/mesa/program/ir_to_mesa.cpp | 11 +-- 1 file changed, 5

[Mesa-dev] [PATCH] vc4: automake: include vc4_cl_dump.h in

Ensure vc4_cl_dump.h and $(BROADCOM_FILES) are distributed in the dist-file. This fixes `make distcheck` --- src/broadcom/Makefile.am | 2 +- src/gallium/drivers/vc4/Makefile.sources | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/broadcom/Makefile.am

Re: [Mesa-dev] configure fails to find llvm since recent llvm commit.

Le lundi 3 juillet 2017, 13:53:12 CEST Andy Furniss a écrit : > Don't know if mesa needs changing or it's an llvm needs fixing issue, > but since llvm commit > > commit 78fbc18aed8024139cb87c5db69ab5b43dc615d6 > Author: Rafael Espindola > Date: Fri Jun 30 18:48:33

[Mesa-dev] configure fails to find llvm since recent llvm commit.

Don't know if mesa needs changing or it's an llvm needs fixing issue, but since llvm commit commit 78fbc18aed8024139cb87c5db69ab5b43dc615d6 Author: Rafael Espindola Date: Fri Jun 30 18:48:33 2017 + Completely disable git/svn version checking if not

Re: [Mesa-dev] [PATCH 05/11] gbm: Pull out FourCC <-> DRIimage format table

On 28 June 2017 at 16:02, Lucas Stach wrote: > Am Freitag, den 16.06.2017, 18:14 +0100 schrieb Daniel Stone: >> Rather than duplicated (yet asymmetric) open-coded tables, pull them out >> to a common structure. >> >> Signed-off-by: Daniel Stone >>

Re: [Mesa-dev] [PATCH 04/11] gbm: Axe buffer import format conversion table

Hi Dan, On 16 June 2017 at 18:14, Daniel Stone wrote: > Wayland buffers coming from wl_drm use the WL_DRM_FORMAT_* enums, which > are identical to GBM_FORMAT_*. Similarly, FD imports do not need to > convert between GBM and DRI FourCC, since they are (almost) completely >

Re: [Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

On 03.07.2017 12:44, Nicolai Hähnle wrote: On 03.07.2017 09:43, Gustaw Smolarczyk wrote: 2017-07-03 6:10 GMT+02:00 Robert Foss : On Sun, 2017-07-02 at 21:06 -0700, Matt Turner wrote: Otherwise known as strlcpy()? I didn't realize this, a wrapper would be needed

Re: [Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

On 03.07.2017 09:43, Gustaw Smolarczyk wrote: 2017-07-03 6:10 GMT+02:00 Robert Foss : On Sun, 2017-07-02 at 21:06 -0700, Matt Turner wrote: Otherwise known as strlcpy()? I didn't realize this, a wrapper would be needed for all platformsou that don't support it

Re: [Mesa-dev] [PATCH 15/19] mesa: hook up UUID queries for driver and device

On 01/07/17 09:58 AM, Andres Rodriguez wrote: > On 2017-06-30 07:21 PM, Jason Ekstrand wrote: >> On June 30, 2017 4:04:31 PM Andres Rodriguez wrote: >> >>> diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c >>> index 34f8bbb..402fc01 100644 >>> ---

Re: [Mesa-dev] [PATCH v3 1/3] util: Add util_strncpy

2017-07-03 6:10 GMT+02:00 Robert Foss : > On Sun, 2017-07-02 at 21:06 -0700, Matt Turner wrote: >> Otherwise known as strlcpy()? > > I didn't realize this, a wrapper would be needed for all platformsou > that don't support it natively. > > Do you know which platforms