Re: [Mesa-dev] [7.5/22] i965/wm: Fix number of layers in 3D images

Reviewed-by: Jason Ekstrand On Wed, Jul 19, 2017 at 2:29 PM, Kenneth Graunke wrote: > On Wednesday, July 19, 2017 12:53:45 PM PDT Topi Pohjolainen wrote: > > CC: mesa-sta...@lists.freedesktop.org > > CC: Kenneth Graunke > >

Re: [Mesa-dev] Mesa 17.2.0 release plan

On Mon, Jul 17, 2017 at 7:54 AM, Emil Velikov wrote: > On 16 July 2017 at 06:35, Jason Ekstrand wrote: > > n Fri, Jul 7, 2017 at 11:07 AM, Emil Velikov > > wrote: > >> > >> Hi all, > >> > >> As you may have noticed, for

Re: [Mesa-dev] [PATCH 18/22] i965/miptree: Prepare aux state map for isl based

On Wed, Jul 19, 2017 at 6:57 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, Jul 18, 2017 at 02:11:59PM -0700, Jason Ekstrand wrote: > > On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < > > topi.pohjolai...@gmail.com> wrote: > > > > > Signed-off-by: Topi Pohjolainen

Re: [Mesa-dev] [3.1/22] i965/miptree: Take interleaving into account in stencil pitch

On Wed, Jul 19, 2017 at 1:37 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Jul 19, 2017 at 01:27:16PM -0700, Jason Ekstrand wrote: > > On Wed, Jul 19, 2017 at 12:51 PM, Topi Pohjolainen < > > topi.pohjolai...@gmail.com> wrote: > > > > > This makes intel_mipmap_tree::pitch

Re: [Mesa-dev] [PATCH 22/22] i965: Represent depth surfaces with isl

On Tue, Jul 18, 2017 at 02:42:21PM -0700, Jason Ekstrand wrote: > On Tue, Jul 18, 2017 at 1:46 AM, Topi Pohjolainen < > topi.pohjolai...@gmail.com> wrote: > > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/brw_clear.c | 5 +- > >

Re: [Mesa-dev] [v2 20/22] intel/isl/gen4: Represent cube maps with 3D layout

Reviewed-by: Jason Ekstrand On Wed, Jul 19, 2017 at 9:45 PM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > v2 (Jason): Check for !ISL_SURF_DIM_3D instead of CUBE_BIT. > > Signed-off-by: Topi Pohjolainen > --- > src/intel/isl/isl.c |

[Mesa-dev] [v2 20/22] intel/isl/gen4: Represent cube maps with 3D layout

v2 (Jason): Check for !ISL_SURF_DIM_3D instead of CUBE_BIT. Signed-off-by: Topi Pohjolainen --- src/intel/isl/isl.c | 41 +++-- 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/src/intel/isl/isl.c

[Mesa-dev] [PATCH 1/4] ac/gpu: add code to detect if kernel supports sync objects.

From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/common/ac_gpu_info.c | 9 + src/amd/common/ac_gpu_info.h | 1 + 2 files changed, 10 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index

[Mesa-dev] radv shared semaphores

This set of patches adds support for the vulkan external semaphore extensions on radv, when the kernel supports sync objects. It currently only deals with permanent semaphore import semantics, since that is all SteamVR requires so far, and the temporary stuff might be a bit messier. I'd like to

[Mesa-dev] [PATCH 3/4] radv/winsys: add syncobj hooks

From: Dave Airlie This just adds syncobj create/destroy/export/import paths into the winsys interface. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_radeon_winsys.h | 8 ++ src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 36

[Mesa-dev] [PATCH 2/4] radv: handle signal semaphore on image acquire properly

From: Dave Airlie We haven't done anything with this before, and this seems to lead to a slow down in deferred of about 40-50 fps, but we do need to start signalling semaphores properly with syncobjs. Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 4/4] radv: initial support for shared semaphores

From: Dave Airlie This adds support for permanent semaphore import/export only. It ports all semaphores to using syncobjs when the kernel supports them, and exposes the extensions to the user. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c

[Mesa-dev] [Bug 101843] Latest mesa git fails to compile in mesa/main/marshal.c

https://bugs.freedesktop.org/show_bug.cgi?id=101843 --- Comment #2 from Fabian Maurer --- Bisected to 95fb1c187a0ea8d13f401145282363228b91b246. But I think I know the problem, did you try building out of tree? Because I have the build folder on the same level as my mesa-git

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

On 2017年07月19日 23:34, Marek Olšák wrote: On Jul 19, 2017 3:36 AM, "zhoucm1" > wrote: On 2017年07月19日 04:08, Marek Olšák wrote: From: Marek Olšák > For lower

[Mesa-dev] [Bug 101844] Artifacts in form of wrong pixels appearing on some surfaces

https://bugs.freedesktop.org/show_bug.cgi?id=101844 --- Comment #6 from Timothy Arceri --- (In reply to Timothy Arceri from comment #3) > A quick look at the trace shows a bunch of errors messages due to the game > expecting the GL_NV_fog_distance extensions functionality

Re: [Mesa-dev] [PATCH] radv: rebase radv_entrypoints_gen.py on anv_entrypoints_gen.py

On 20 July 2017 at 11:06, Dylan Baker wrote: > The two generators forked from each other, and they remain basically the > same. This rebases the radv version on the anv version, but with the > radv changes ported over. The result is that we get rid of the "cat |" > madness

[Mesa-dev] [PATCH] radv: rebase radv_entrypoints_gen.py on anv_entrypoints_gen.py

The two generators forked from each other, and they remain basically the same. This rebases the radv version on the anv version, but with the radv changes ported over. The result is that we get rid of the "cat |" madness and gain mako, correct "generated by" attributions, and write files out

Re: [Mesa-dev] [PATCH mesa 5/5] wayland-egl: Update ABI checker

On Wed, 19 Jul 2017 12:19:30 +0100 Emil Velikov wrote: > On 18 July 2017 at 21:49, Miguel A. Vico wrote: > > This change updates wayland-egl-abi-check.c with the latest changes to > > wl_egl_window. > > > > Signed-off-by: Miguel A. Vico

[Mesa-dev] [Bug 101843] Latest mesa git fails to compile in mesa/main/marshal.c

https://bugs.freedesktop.org/show_bug.cgi?id=101843 --- Comment #1 from Timothy Arceri --- It's working for me, if you could use git bisect to identify the bad commit that would be helpful. -- You are receiving this mail because: You are the QA Contact for the bug. You

[Mesa-dev] [Bug 101844] Artifacts in form of wrong pixels appearing on some surfaces

https://bugs.freedesktop.org/show_bug.cgi?id=101844 --- Comment #5 from Timothy Arceri --- (In reply to Fabian Maurer from comment #4) > Yes, the fog is buggy too. But is this relevant to the pixel errors? It used > to work, after all. Ok I see what you are talking about

Re: [Mesa-dev] [PATCH mesa 4/5] wayland-egl: Make wl_egl_window a versioned struct

On Wed, 19 Jul 2017 12:06:06 +0100 Emil Velikov wrote: > On 18 July 2017 at 21:49, Miguel A. Vico wrote: > > We need wl_egl_window to be a versioned struct in order to keep track of > > ABI changes. > > > > This change makes the first member of

Re: [Mesa-dev] [PATCH mesa 3/5] egl: Fix _eglPointerIsDereferencable() to ignore page residency

On Wed, 19 Jul 2017 11:43:43 +0100 Emil Velikov wrote: > On 18 July 2017 at 21:49, Miguel A. Vico wrote: > > mincore() returns 0 on success, and -1 on failure. The last parameter > > is a vector of bytes with one entry for each page queried.

Re: [Mesa-dev] [PATCH mesa 2/5] egl: Move _eglPointerIsDereferencable() to eglglobals.[ch]

On Wed, 19 Jul 2017 11:36:59 +0100 Emil Velikov wrote: > On 18 July 2017 at 21:49, Miguel A. Vico wrote: > > More _eglPointerIsDereferencable() to eglglobals.[ch] and make it a > > non-static function so it can be used out of egldisplay.c > >

[Mesa-dev] [Bug 101844] Artifacts in form of wrong pixels appearing on some surfaces

https://bugs.freedesktop.org/show_bug.cgi?id=101844 --- Comment #4 from Fabian Maurer --- Yes, the fog is buggy too. But is this relevant to the pixel errors? It used to work, after all. -- You are receiving this mail because: You are the QA Contact for the bug. You are

Re: [Mesa-dev] [PATCH mesa 1/5] wayland-egl: Add wl_egl_window ABI checker

Thanks for all the reviews, Emil. Inline. On Wed, 19 Jul 2017 11:35:04 +0100 Emil Velikov wrote: > Hi Miguel, > > Thanks for looking into this. There's a couple of small nits below but > it overall looks good. > > On 18 July 2017 at 21:49, Miguel A. Vico

[Mesa-dev] [Bug 101844] Artifacts in form of wrong pixels appearing on some surfaces

https://bugs.freedesktop.org/show_bug.cgi?id=101844 --- Comment #3 from Timothy Arceri --- A quick look at the trace shows a bunch of errors messages due to the game expecting the GL_NV_fog_distance extensions functionality to be available. -- You are receiving this mail

[Mesa-dev] [PATCH mesa 5/5 v2] wayland-egl: Update ABI checker

This change updates wayland-egl-abi-check.c with the latest changes to wl_egl_window. Signed-off-by: Miguel A. Vico Reviewed-by: James Jones --- .../wayland/wayland-egl/wayland-egl-abi-check.c| 90 ++ 1 file changed, 75

[Mesa-dev] [PATCH mesa 4/5 v2] wayland-egl: Make wl_egl_window a versioned struct

We need wl_egl_window to be a versioned struct in order to keep track of ABI changes. This change makes the first member of wl_egl_window the version number. An heuristic in the wayland driver is added so that we don't break backwards compatibility: - If the first field (version) is an actual

[Mesa-dev] [PATCH mesa 3/5 v2] egl: Fix _eglPointerIsDereferencable() to ignore page residency

mincore() returns 0 on success, and -1 on failure. The last parameter is a vector of bytes with one entry for each page queried. mincore returns page residency information in the first bit of each byte in the vector. Residency doesn't actually matter when determining whether a pointer is

[Mesa-dev] [PATCH mesa 2/5 v2] egl: Move _eglPointerIsDereferencable() to eglglobals.[ch]

Move _eglPointerIsDereferencable() to eglglobals.[ch] and make it a non-static function so it can be used out of egldisplay.c Signed-off-by: Miguel A. Vico Reviewed-by: James Jones Reviewed-by: Emil Velikov ---

[Mesa-dev] [PATCH mesa 1/5 v2] wayland-egl: Add wl_egl_window ABI checker

Add a small ABI checker for wl_egl_window so that we can check for backwards incompatible changes at 'make check' time. Signed-off-by: Miguel A. Vico Reviewed-by: James Jones --- src/egl/wayland/wayland-egl/Makefile.am| 6 +-

[Mesa-dev] [PATCH 2/3] mesa/st: move st_pipe_format_to_mesa_format() call to where its used

--- src/mesa/state_tracker/st_format.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_format.c b/src/mesa/state_tracker/st_format.c index 012f1a4..64a3a81 100644 --- a/src/mesa/state_tracker/st_format.c +++ b/src/mesa/state_tracker/st_format.c @@

[Mesa-dev] [PATCH 1/3] gallium/util: fix unused variable warning

--- src/gallium/auxiliary/util/u_threaded_context.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_threaded_context.c b/src/gallium/auxiliary/util/u_threaded_context.c index cb9ea3a..a9fc670 100644 ---

[Mesa-dev] [PATCH 3/3] mesa/st: fix unused variable warnings

--- src/mesa/state_tracker/st_cb_bitmap.c | 5 +++-- src/mesa/state_tracker/st_cb_drawpixels.c | 9 - src/mesa/state_tracker/st_cb_texture.c| 2 +- src/mesa/state_tracker/st_format.c| 5 +++-- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [Bug 101851] [regression] libEGL_common.a undefined reference to '__gxx_personality_v0'

https://bugs.freedesktop.org/show_bug.cgi?id=101851 Bug ID: 101851 Summary: [regression] libEGL_common.a undefined reference to '__gxx_personality_v0' Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [PATCH 1/2] broadcom: correct header file in BROADCOM_FILES

This fixes `make distcheck` > make[3]: *** No rule to make target 'common/v3d_devinfo.h', needed by > 'distdir'. Stop. > make[3]: Leaving directory '/home/local/mesa/src/broadcom' > Makefile:945: recipe for target 'distdir' failed > make[2]: Leaving directory '/home/local/mesa/src' > make[2]:

[Mesa-dev] [PATCH 2/2] egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist"

This fixes `make distcheck` > make[3]: *** No rule to make target > 'drivers/dri2/linux-dmabuf-unstable-v1-protocol.c', needed by 'distdir'. > Stop. > make[3]: Entering directory '/home/local/mesa/src/egl' > make[3]: Leaving directory '/home/local/mesa/src/egl' > make[2]: *** [distdir] Error 1

[Mesa-dev] [PATCH 0/2] Fix distcheck

A couple of patches to fix recent problems while running make distcheck. Andres Gomez (2): broadcom: correct header file in BROADCOM_FILES egl: add linux-dmabuf-unstable-v1-protocol.c to "nodist" src/broadcom/Makefile.sources | 2 +- src/egl/Makefile.am | 10 -- 2 files

Re: [Mesa-dev] [PATCH 09/13] i965: Always create the batch with the batch object in the first execobject slot

On Wednesday, July 19, 2017 3:09:17 AM PDT Chris Wilson wrote: > Even if we are using older kernels that do not accept the batch in the > first slot, we can simplify our code by creating the batch with itself > in the first slot and moving it to the end on execbuf submission. > --- >

Re: [Mesa-dev] [PATCH 08/13] i965: Convert reloc.target_handle into an index for I915_EXEC_HANDLE_LUT

On Wednesday, July 19, 2017 3:09:16 AM PDT Chris Wilson wrote: > Passing the index of the target buffer via the reloc.target_handle is > marginally more efficient for the kernel (it can avoid some allocations, > and can use a direct lookup rather than a hash or search). It is also > useful for

Re: [Mesa-dev] [PATCH 2/2] radv: Add support for VK_KHR_variable_pointers.

For both: Reviewed-by: Connor Abbott You beat me to it! On Wed, Jul 19, 2017 at 3:29 PM, Bas Nieuwenhuizen wrote: > Just a trivial enable. > > Signed-off-by: Bas Nieuwenhuizen > --- > src/amd/vulkan/radv_device.c |

[Mesa-dev] [PATCH 1/2] radv: Add VK_KHR_storage_buffer_storage_class support.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 4 src/amd/vulkan/radv_entrypoints_gen.py | 1 + 2 files changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index a91b366721b..e3655dabe3a 100644

[Mesa-dev] [PATCH 2/2] radv: Add support for VK_KHR_variable_pointers.

Just a trivial enable. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 16 src/amd/vulkan/radv_entrypoints_gen.py | 1 + src/amd/vulkan/radv_pipeline.c | 1 + 3 files changed, 18 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 06/13] i965: Use I915_EXEC_NO_RELOC

On Wednesday, July 19, 2017 3:09:14 AM PDT Chris Wilson wrote: > If we correctly fill the batch with the right relocation value, and that > matches the expected location of the object, we can then tell the kernel > it can forgo checking each individual relocation by only checking > whether the

Re: [Mesa-dev] [PATCH 01/13] i965: Assert that 64b immediate writes are correctly aligned

On Wednesday, July 19, 2017 3:09:09 AM PDT Chris Wilson wrote: > The HW can only write a 64b immediate into a 64b aligned address, so > add an assert. > > Signed-off-by: Chris Wilson > --- > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 1 + > 1 file changed, 1

Re: [Mesa-dev] [PATCH] mesa: check API profile for GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION

On 07/19/2017 07:21 AM, Brian Paul wrote: > On 07/18/2017 05:28 PM, Ian Romanick wrote: >> On 07/18/2017 01:20 PM, Brian Paul wrote: >>> If we have a compat profile context, it means that GL_QUADS[_STRIP] are >>> supported so this query makes sense. It's also legal for 3.2 core >>> profile >>>

Re: [Mesa-dev] [PATCH] egl: Add MKDIR_GEN definition

Hi all, On Wed, Jul 19, 2017 at 4:57 AM, Daniel Stone wrote: > Adding linux-dmabuf Wayland protocol files as generated did the right > thing, by prepending $(MKDIR_GEN) so autotools didn't try to write into > a build directory which didn't yet exist. > > Unfortunately

[Mesa-dev] [PATCH] egl: fix check for KHR_no_error vs debug/robustness

The check is too aggressive and might also fail if context flags appear after the no-error attribute in the context attribute list. Delay the check to after attribute parsing to fix this. --- This was found by the piglit test I just sent to the piglit ML. I promise, next time I'll write tests

Re: [Mesa-dev] [7.5/22] i965/wm: Fix number of layers in 3D images

On Wednesday, July 19, 2017 12:53:45 PM PDT Topi Pohjolainen wrote: > CC: mesa-sta...@lists.freedesktop.org > CC: Kenneth Graunke > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 16 +--- >

Re: [Mesa-dev] [PATCH v4 00/18] anv: Do CCS resolves at layout transitions

On Wed, Jul 19, 2017 at 02:21:52PM -0700, Nanley Chery wrote: > In this revision: > * review feedback is incorporated. > * a couple of bugs caught by a new dEQP version are fixed: > - image data could be lost if CCS_D wasn't enabled in render passes > before we started doing explicit layout

[Mesa-dev] [PATCH v4 18/18] anv: Predicate fast-clear resolves

Image layouts only let us know that an image *may* be fast-cleared. For this reason we can end up with redundant resolves. Testing has shown that such resolves can measurably hurt performance and that predicating them can avoid the penalty. v2: - Introduce additional resolve state management

[Mesa-dev] [PATCH v4 17/18] intel/blorp: Allow BLORP calls to be predicated

Signed-off-by: Nanley Chery --- src/intel/blorp/blorp.h | 3 +++ src/intel/blorp/blorp_genX_exec.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h index d5226c2248..1e96fb42b0 100644 ---

[Mesa-dev] [PATCH v4 11/18] anv/cmd_buffer: Always enable CCS_D in render passes

The lifespan of the fast-clear data will surpass the render pass scope. We need CCS_D to be enabled in order to invalidate blocks previously marked as cleared and to sample cleared data correctly. v2: Avoid refactoring. v3: Allow CCS_D for subpass resolves. Signed-off-by: Nanley Chery

[Mesa-dev] [PATCH v4 16/18] anv/cmd_buffer: Skip some input attachment transitions

Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 7b2a3551b6..611e77bddb

[Mesa-dev] [PATCH v4 14/18] anv: Transition more color buffer layouts

v2: Expound on comment for the pipe controls (Jason Ekstrand). v3: - Cast base_layer to uint64_t to avoid overflow. - Remove "seems" from the pipe control comment. - Fix clamp of layer_count (Jason Ekstrand). Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c

[Mesa-dev] [PATCH v4 10/18] anv/cmd_buffer: Disable CCS on gen7 color attachments upfront

The next patch enables the use of CCS_D even when the color attachment will not be fast-cleared. Catch the gen7 case early to simplify the changes required. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 16 +--- 1 file changed, 5

[Mesa-dev] [PATCH v4 09/18] anv/cmd_buffer: Ensure fast-clear values are current

v2: Rewrite functions, change location of synchronization. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 114 + 1 file changed, 114 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH v4 15/18] anv: Stop resolving CCS implicitly

With an earlier patch from this series, resolves are additionally performed on layout transitions. Remove the now unnecessary implicit resolves within render passes. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 150

[Mesa-dev] [PATCH v4 13/18] anv/cmd_buffer: Warn about not enabling CCS_E

Use the performance warning infrastructure to provide helpful information when testing applications. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH v4 12/18] anv/cmd_buffer: Move aux_usage assignment up

For readability, bring the assignment of CCS closer to the assignment of NONE and MCS. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 62 ++ 1 file changed, 30 insertions(+), 32 deletions(-) diff --git

[Mesa-dev] [PATCH v4 07/18] anv/cmd_buffer: Restrict fast clears in the GENERAL layout

v2: Remove ::first_subpass_layout assertion (Jason Ekstrand). v3: Allow some fast clears in the GENERAL layout. v4: Remove extra '||' and adjust line break (Jason Ekstrand). Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 22 ++

[Mesa-dev] [PATCH v4 05/18] anv/cmd_buffer: Initialize the clear values buffer

v2: Rewrite functions. v3 (Jason Ekstrand): - Don't set ResourceMinLOD. - Fix clamp of level_count. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v4 08/18] anv/gpu_memcpy: Add a lighter-weight GPU memcpy function

We'll be performing a GPU memcpy in more places to copy small amounts of data. Add an alternate function that thrashes less state. v2: - Make a new function (Jason Ekstrand). - Move the #define into the function. v3: - Update the function name (Jason). - Update comments. v4: Use an indirect

[Mesa-dev] [PATCH v4 02/18] intel/isl: Add surface state clear value information

This will be used to load and store clear values from surface state objects. Signed-off-by: Nanley Chery --- src/intel/isl/isl.c | 9 + src/intel/isl/isl.h | 4 2 files changed, 13 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index

[Mesa-dev] [PATCH v4 04/18] anv/image: Append CCS/MCS with a fast-clear state buffer

v2: Update comments, function signatures, and add assertions. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 78 ++ src/intel/vulkan/anv_private.h | 12 +++ 2 files changed, 90 insertions(+) diff --git

[Mesa-dev] [PATCH v4 03/18] anv/image: Disable CCS if the image doesn't support rendering

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 4f0057c952..f33a445d1d 100644 --- a/src/intel/vulkan/anv_image.c +++

[Mesa-dev] [PATCH v4 06/18] anv/cmd_buffer: Don't partially fast clear image layers

v2: Don't pass in the command buffer (Jason Ekstrand). v3: Remove an incorrect assertion and an if condition for gen7. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 31 +++ 1 file changed, 23 insertions(+), 8

[Mesa-dev] [PATCH v4 01/18] anv: Transition MCS buffers from the undefined layout

Cc: Suggested-by: Jason Ekstrand Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 8 src/intel/vulkan/anv_private.h | 8 src/intel/vulkan/genX_cmd_buffer.c | 25

[Mesa-dev] [PATCH v4 00/18] anv: Do CCS resolves at layout transitions

In this revision: * review feedback is incorporated. * a couple of bugs caught by a new dEQP version are fixed: - image data could be lost if CCS_D wasn't enabled in render passes before we started doing explicit layout transitions on images with that auxiliary buffer. - subpass

[Mesa-dev] [PATCH 00/32] i965: Enabale CCS_E for sRGB render buffers

Gen9 hardware has this annoying little corner where CCS_E is not allowed for any sRGB formats. This is fixed on gen10 but on gen9 there's nothing we can do; it just doesn't work. The old approach to working around this was to just disable CCS_E the moment we saw sRGB. This is bad because GLX

Re: [Mesa-dev] [2.2/22] intel/isl: Add i915 to isl_tiling converter

On 19 July 2017 at 21:24, Jason Ekstrand wrote: > I don't really like the lack of isl_ prefix. We could call it > isl_tiling_from_i915_tiling(). I don't care all that much though. That works for me, but equally I don't really mind, so either way: Reviewed-by: Daniel Stone

[Mesa-dev] [PATCH 31/32] intel/isl: Add a helper for determining if a color is 0/1

--- src/intel/isl/isl.c | 27 +++ src/intel/isl/isl.h | 3 +++ 2 files changed, 30 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 12ffe3b..2976e32 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -259,6 +259,33 @@

[Mesa-dev] [PATCH 30/32] intel/blorp: Allow blorp_copy on sRGB formats

--- src/intel/blorp/blorp_blit.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 973e3ef..91d2a22 100644 --- a/src/intel/blorp/blorp_blit.c +++ b/src/intel/blorp/blorp_blit.c @@ -2459,16

[Mesa-dev] [PATCH 26/32] i965/surface_state: Get the aux usage from the miptree code

--- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 108 +++ 1 file changed, 13 insertions(+), 95 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index 30b5e61..2fefba5 100644 ---

[Mesa-dev] [PATCH 22/32] i965/miptree: Allow for accessing a CCS_E image as CCS_D

This requires us to start using the partial clear state. It makes things quite a bit more complicated but it's still a fairly straightforward exercise in diagram following. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 36 +-- 1 file changed, 28 insertions(+), 8

[Mesa-dev] [PATCH 27/32] intel/isl/format: Dedent the template in gen_format_layout.py

This makes it much easier to edit the template and doesn't really dirty the python all that much. --- src/intel/isl/gen_format_layout.py | 115 ++--- 1 file changed, 57 insertions(+), 58 deletions(-) diff --git a/src/intel/isl/gen_format_layout.py

[Mesa-dev] [PATCH 32/32] i965: Enable regular fast-clears (CCS_D) on gen9+

The set of formats which supports CCS_E is actually fairly small on gen9. However, everything that supports fast-clears on gen8 also supports fast-clears on gen9+. The one very annoying exception is that blending is broken for non-0/1 clear colors with sRGB formats. In order to solve that

[Mesa-dev] [PATCH 21/32] i965/miptree: Use ISL_AUX_STATE_PARTIAL_CLEAR for CCS_D

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 91fcd0b..68e0246 100644 ---

[Mesa-dev] [PATCH 29/32] i965: Weaken the texture view rules for formats slightly

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 801d830..ebc414c 100644 ---

[Mesa-dev] [PATCH 28/32] intel/isl/format: Add an srgb_to_linear helper

--- src/intel/isl/gen_format_layout.py | 46 +- src/intel/isl/isl.h| 8 +++ 2 files changed, 53 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/gen_format_layout.py b/src/intel/isl/gen_format_layout.py index aa4e2d8..0ca42db

[Mesa-dev] [PATCH 24/32] i965/miptree: Take an isl_format in prepare_texture

This will be a bit more convenient momentarily. It's also more correct because it makes prepare_texture take sRGB into account. --- src/mesa/drivers/dri/i965/brw_draw.c | 7 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 15 +++

[Mesa-dev] [PATCH 25/32] i965/surface_state: Take an isl_aux_usage in emit_surface_state

This commit replaces the generic "flags" parameter with a more explicit aux usage parameter. This leads to a lot of duplicated code at the moment but this will all get cleaned up directly. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 73 +++- 1 file changed, 47

[Mesa-dev] [PATCH 23/32] i965/miptree: Use miptree range helpers in has_color_unresolved

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 104 +- 1 file changed, 51 insertions(+), 53 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 1bbf9a5..5696886 100644 ---

[Mesa-dev] [PATCH 20/32] intel/isl: Add an aux state for "partial clear"

--- src/intel/isl/isl.h | 88 --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 2 files changed, 64 insertions(+), 35 deletions(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index d81df31..68bfcee 100644 ---

[Mesa-dev] [PATCH 19/32] i965/miptree: Take an aux_usage in prepare/finish

--- src/mesa/drivers/dri/i965/brw_blorp.c | 25 ++--- src/mesa/drivers/dri/i965/brw_clear.c | 3 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 53 --- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 ++- 4 files changed, 48 insertions(+),

[Mesa-dev] [PATCH 17/32] i965/blorp: Use prepare/finish_depth for depth clears

We also simplify the way we handle stencil since we know a priori that it will have ISL_AUX_USAGE_NONE. --- src/mesa/drivers/dri/i965/brw_blorp.c | 57 +-- 1 file changed, 21 insertions(+), 36 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c

[Mesa-dev] [PATCH 15/32] i965/blorp: Be more accurate about aux usage in blorp_copy

The only real change here is that we now reject clear colors for MCS with certain formats on gen < 9 because we can't trust that the reinterpretation will work. This may cause some MCS partial resolves. --- src/mesa/drivers/dri/i965/brw_blorp.c | 57 +++ 1 file

[Mesa-dev] [PATCH 18/32] i965/miptree: Refactor some things to use mt->aux_usage

Now that we have this field, it's much easier to switch on it than to walk an if ladder that checks different things. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 94 --- 1 file changed, 56 insertions(+), 38 deletions(-) diff --git

[Mesa-dev] [PATCH 16/32] i965/blorp: Use render_aux_usage for color clears

--- src/mesa/drivers/dri/i965/brw_blorp.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 4c61afc..9bad366 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c +++

[Mesa-dev] [PATCH 11/32] i965/miptree: Add a helper for getting the aux usage for texturing

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 59 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 ++ 2 files changed, 43 insertions(+), 20 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [PATCH 13/32] i965/blorp: Do prepare/finsh manually

Our attempts to do it automatically are problematic at best. In order to really be precise, we need to know both the desired aux usage and whether or not clear is supported. The current automatic mechanism doesn't cover this. This commit itself is not a functional change since it just reworks

[Mesa-dev] [PATCH 05/32] i965/miptree: Remove some unneeded restrictions

intel_miptree_supports_ccs_e should handle the gen >= 9 requirement and there's no reason why we can't do CCS_E on window system buffers so long as we resolve. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 09/32] i965/miptree: Add support for partially resolving MCS

--- src/mesa/drivers/dri/i965/brw_blorp.c | 24 src/mesa/drivers/dri/i965/brw_blorp.h | 5 src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 +-- 3 files changed, 67 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 14/32] i965/blorp: Use texture/render_aux_usage for blits

--- src/mesa/drivers/dri/i965/brw_blorp.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index f62484f..5b5b4bc 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c

[Mesa-dev] [PATCH 07/32] i965/miptree: Make layer_range_length return locical layers

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 3eac077..8d8ea43 100644 ---

[Mesa-dev] [PATCH 12/32] i965/miptree: Rework prepare/finish_render to be in terms of aux_usage

We keep the old and possibly broken method of determining aux usage intact for now. Therefore, the only functional change here is that we may call finish_render a bit more accurately. --- src/mesa/drivers/dri/i965/brw_draw.c | 3 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 69

[Mesa-dev] [PATCH 10/32] i965/miptree: Partially resolve MCS for texture views

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 1fd39a1..2d2a813 100644 ---

[Mesa-dev] [PATCH 04/32] i965/miptree: Stop setting FOR_SCANOUT for renderbuffers

Nothing created through intel_miptree_create_for_renderbuffer will ever be exposed externally so there's no need to set FOR_SCANOUT. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 06/32] intel/blorp: Add a partial resolve pass for MCS

--- src/intel/blorp/blorp.h | 6 +++ src/intel/blorp/blorp_clear.c | 105 +++- src/intel/blorp/blorp_nir_builder.h | 102 +++ src/intel/blorp/blorp_priv.h| 1 + 4 files changed, 213 insertions(+), 1

[Mesa-dev] [PATCH 02/32] i965/blorp: Use the renderbuffer format for clears

This fixes the Piglit ARB_texture_views rendering-formats test. --- src/mesa/drivers/dri/i965/brw_blorp.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 11f2fae..5335fae 100644 ---

  1   2   3   >