[Mesa-dev] [PATCH 5/5] clover/llvm: Make __OPENCL_VERSION__ dynamic

Base it on the active language version Signed-off-by: Aaron Watry --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp

[Mesa-dev] [PATCH 2/5] clover/device: Move device version into core/device.cpp

The device version is the maximum CL version that the device supports. Eventually, this will query the pipe_driver itself, but for now move it a bit closer to its eventual destination. Signed-off-by: Aaron Watry --- src/gallium/state_trackers/clover/api/device.cpp | 4 ++--

[Mesa-dev] [PATCH 3/5] clover: Add device_version to llvm::[compile|link]_program

We'll be using it to select the default language version soon. Signed-off-by: Aaron Watry --- src/gallium/state_trackers/clover/core/program.cpp| 6 -- src/gallium/state_trackers/clover/llvm/invocation.cpp | 6 +-

[Mesa-dev] [PATCH 4/5] clover/llvm: Use -cl-std and device version to select language defaults

According to section 5.8.4.5 of the 2.0 spec, the CL C version is chosen by: 1) If you have -cl-std=CL1.1+ use the version specified 2) If not, use the highest 1.x version that the device supports Curiously, there is no valid value for -cl-std=CL1.0 Signed-off-by: Aaron Watry

[Mesa-dev] [PATCH 1/5] clover/memory: Copy data when creating buffers with CL_MEM_USE_HOST_PTR

Fixes: OpenCL CTS test/conformance/buffers/buffer_copy Signed-off-by: Aaron Watry CC: Francisco Jerez --- src/gallium/state_trackers/clover/core/memory.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] A few clover fixes for both CTS and eventual 1.2 support

The first patch is one I've been sitting on for a few weeks while I've tried to chase down other issues with clover/llvm/libclc. It fixes at least one CTS test that I know of for CL 1.2. The other 4 patches move the device version declaration to core/device and then use that along with the

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

Hi Christoph, Can you provide an apitrace of the test that crashes? Thanks. -Charmaine From: mesa-dev on behalf of Christoph Haag Sent: Friday, July 21, 2017 4:52:41 PM To:

[Mesa-dev] [PATCH 2/2] anv/blorp: Assert isl_surf_init success in do_buffer_copy

--- src/intel/vulkan/anv_blorp.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 1492802..eca7a7e 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/intel/vulkan/anv_blorp.c @@

[Mesa-dev] [PATCH 1/2] anv/blorp: Explicitly set row_pitch in do_buffer_copy

We have a very specific row pitch that we want and we don't want ISL to be changing it on us so just be explicit about it. --- src/intel/vulkan/anv_blorp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index

Re: [Mesa-dev] [PATCH] travis: add build configuration for SWR AVX512

On Thursday, 2017-07-20 22:16:36 +, Tim Rowley wrote: > --- > .travis.yml | 32 > 1 file changed, 32 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index 246ad30eff..da491e0396 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -82,6 +82,38 @@

Re: [Mesa-dev] [PATCH v4 18/18] anv: Predicate fast-clear resolves

On Fri, Jul 21, 2017 at 03:56:05PM -0700, Jason Ekstrand wrote: > On Wed, Jul 19, 2017 at 2:22 PM, Nanley Chery wrote: > > > Image layouts only let us know that an image *may* be fast-cleared. For > > this reason we can end up with redundant resolves. Testing has shown > >

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

This patch breaks steam for me. Segfault backtrace: #0 0x0023 in ?? () No symbol table info available. #1 0xf6b1a417 in _mesa_hash_table_search (ht=0x585bb7e8, key=0x5820ee88) at hash_table.c:246 __PRETTY_FUNCTION__ = "_mesa_hash_table_search" #2 0xf6a4488e in

Re: [Mesa-dev] [PATCH v4 11/18] anv/cmd_buffer: Always enable CCS_D in render passes

On Fri, Jul 21, 2017 at 03:43:20PM -0700, Jason Ekstrand wrote: > On Wed, Jul 19, 2017 at 2:22 PM, Nanley Chery wrote: > > > The lifespan of the fast-clear data will surpass the render pass scope. > > We need CCS_D to be enabled in order to invalidate blocks previously > >

[Mesa-dev] [PATCH 4/7] i965/bufmgr: Use write-combine mappings where available

From: Matt Turner Write-combine mappings give much better performance on writes than uncached access through the GTT. Improves performance of GFXBench 4's gl_driver2 benchmark at 1024x768 on Apollolake by 3.6086% +/- 0.674193% (n=15). v2: (by Ken) Rebase on lockless

[Mesa-dev] [PATCH 7/7] i965: Drop non-LLC lunacy in the program cache code.

The non-LLC story was a horror show. We uploaded data via pwrite (drm_intel_bo_subdata), which would stall if the cache BO was in use (being read) by the GPU. Obviously, we wanted to avoid that. So, we tried to detect whether the buffer was busy, and if so, we'd allocate a new BO, map the old

[Mesa-dev] [PATCH 6/7] i965: Set MAP_PERSISTENT on program cache buffers.

Chris Wilson pointed out that this mapping really is persistant. Shouldn't actually have any effect today, but best to set it anyway. --- src/mesa/drivers/dri/i965/brw_program_cache.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 1/7] i965/bufmgr: Explicitly wait instead of using I915_GEM_SET_DOMAIN.

With the advent of asynchronous maps, domain tracking doesn't make a whole lot of sense. Buffers can be in use on both the CPU and GPU at the same time. In order to avoid blocking, we stopped using set_domain for asynchronous mappings, which means that the kernel's tracking has lies. We can't

[Mesa-dev] [PATCH 5/7] i965: Correctly set MAP_WRITE when creating the LLC program cache map.

Using a read-only mapping is completely bogus - we use this mapping to write all new shaders to the cache. --- src/mesa/drivers/dri/i965/brw_program_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_program_cache.c

[Mesa-dev] [PATCH 2/7] i965/bufmgr: Skip wait ioctl when not busy.

If the buffer is idle, we I915_GEM_WAIT will return immediately, so we may as well skip the ioctl altogether. We can't trust the "idle" flag for external buffers, but for most, it should be fine. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH 3/7] i965/bufmgr: Allocate BO pages outside of the kernel's locking.

Suggested by Chris Wilson. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index 1669d26e990..78a4626d430 100644 ---

Re: [Mesa-dev] [PATCH 24/32] i965/miptree: Take an isl_format in prepare_texture

On Fri, Jul 21, 2017 at 1:50 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Jul 19, 2017 at 02:01:50PM -0700, Jason Ekstrand wrote: > > This will be a bit more convenient momentarily. It's also more correct > > because it makes prepare_texture take sRGB into account. > >

Re: [Mesa-dev] [PATCH v4 00/18] anv: Do CCS resolves at layout transitions

On Wed, Jul 19, 2017 at 2:28 PM, Nanley Chery wrote: > On Wed, Jul 19, 2017 at 02:21:52PM -0700, Nanley Chery wrote: > > In this revision: > > * review feedback is incorporated. > > * a couple of bugs caught by a new dEQP version are fixed: > > - image data could be lost

[Mesa-dev] [PATCH] radv: reset non-syncobj semaphore context after wait.

From: Dave Airlie When I ported from libdrm, I forgot to add the line to reset the sem, we just need to reset the context. This fixes a regression in DOOM. Fixes: 9ac1432a571 "radv: port to new libdrm API." Reported-by: Grazvydas Ignotas Signed-off-by:

Re: [Mesa-dev] [PATCH v4 18/18] anv: Predicate fast-clear resolves

On Wed, Jul 19, 2017 at 2:22 PM, Nanley Chery wrote: > Image layouts only let us know that an image *may* be fast-cleared. For > this reason we can end up with redundant resolves. Testing has shown > that such resolves can measurably hurt performance and that predicating >

Re: [Mesa-dev] [PATCH v4 11/18] anv/cmd_buffer: Always enable CCS_D in render passes

On Wed, Jul 19, 2017 at 2:22 PM, Nanley Chery wrote: > The lifespan of the fast-clear data will surpass the render pass scope. > We need CCS_D to be enabled in order to invalidate blocks previously > marked as cleared and to sample cleared data correctly. > > v2: Avoid

[Mesa-dev] [PATCH] gallium/util: s/unsigned/enum tgsi_texture_type/

--- src/gallium/auxiliary/util/u_blitter.c| 15 --- src/gallium/auxiliary/util/u_inlines.h| 2 +- src/gallium/auxiliary/util/u_simple_shaders.c | 15 --- src/gallium/auxiliary/util/u_simple_shaders.h | 13 +++-- 4 files changed, 24 insertions(+),

Re: [Mesa-dev] [PATCH v4 01/18] anv: Transition MCS buffers from the undefined layout

On Wed, Jul 19, 2017 at 2:21 PM, Nanley Chery wrote: > Cc: > Suggested-by: Jason Ekstrand > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/anv_blorp.c | 8 >

Re: [Mesa-dev] [PATCH 25/32] i965/surface_state: Take an isl_aux_usage in emit_surface_state

On Sat, Jul 22, 2017 at 12:01:19AM +0300, Pohjolainen, Topi wrote: > On Wed, Jul 19, 2017 at 02:01:51PM -0700, Jason Ekstrand wrote: > > This commit replaces the generic "flags" parameter with a more explicit > > aux usage parameter. This leads to a lot of duplicated code at the > > moment but

Re: [Mesa-dev] [PATCH 25/32] i965/surface_state: Take an isl_aux_usage in emit_surface_state

On Wed, Jul 19, 2017 at 02:01:51PM -0700, Jason Ekstrand wrote: > This commit replaces the generic "flags" parameter with a more explicit > aux usage parameter. This leads to a lot of duplicated code at the > moment but this will all get cleaned up directly. > --- >

Re: [Mesa-dev] [PATCH 2/4] i965: Fix up a failed CPU/WC mmaping with a GTT mapping

Quoting Kenneth Graunke (2017-07-12 08:22:23) > From: Chris Wilson > +static void * > brw_bo_map_gtt(struct brw_context *brw, struct brw_bo *bo, unsigned flags) > { > struct brw_bufmgr *bufmgr = bo->bufmgr; > @@ -824,10 +831,30 @@ brw_bo_map(struct brw_context

Re: [Mesa-dev] [PATCH 24/32] i965/miptree: Take an isl_format in prepare_texture

On Wed, Jul 19, 2017 at 02:01:50PM -0700, Jason Ekstrand wrote: > This will be a bit more convenient momentarily. It's also more correct > because it makes prepare_texture take sRGB into account. > --- > src/mesa/drivers/dri/i965/brw_draw.c | 7 ++- >

Re: [Mesa-dev] [PATCH 2/2] i965/bufmgr: Skip wait ioctl when busy.

Quoting Kenneth Graunke (2017-07-18 06:14:53) > If the buffer is idle, we I915_GEM_WAIT will return immediately, > so we may as well skip the ioctl altogether. We can't trust the > "idle" flag for external buffers, but for most, it should be fine. > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c |

Re: [Mesa-dev] [PATCH 1/2] i965/bufmgr: Explicitly wait instead of using I915_GEM_SET_DOMAIN.

Quoting Kenneth Graunke (2017-07-18 06:14:52) > With the advent of asynchronous maps, domain tracking doesn't make a > whole lot of sense. Buffers can be in use on both the CPU and GPU at > the same time. In order to avoid blocking, we stopped using set_domain > for asynchronous mappings, which

Re: [Mesa-dev] [PATCH 21/32] i965/miptree: Use ISL_AUX_STATE_PARTIAL_CLEAR for CCS_D

On Fri, Jul 21, 2017 at 1:13 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Jul 19, 2017 at 02:01:47PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ++- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff

Re: [Mesa-dev] [PATCH 20/32] intel/isl: Add an aux state for "partial clear"

On Fri, Jul 21, 2017 at 12:51 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Jul 19, 2017 at 02:01:46PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.h | 88 > --- > >

Re: [Mesa-dev] [PATCH v2] swr/rast: quit using linux-specific gettid()

Reviewed-by: Bruce Cherniak > On Jul 21, 2017, at 2:17 PM, Tim Rowley wrote: > > Linux-specific gettid() syscall shouldn't be used in portable code. > Fix does assume a 1:1 thread:LWP architecture, but works for our > current target

Re: [Mesa-dev] [PATCH] swr/rast: quit using linux-specific gettid()

Reviewed-by: Bruce Cherniak > On Jul 21, 2017, at 11:46 AM, Tim Rowley wrote: > > Linux-specific gettid() syscall shouldn't be used in portable code. > Fix does assume a 1:1 thread:LWP architecture, but works for our > current target

Re: [Mesa-dev] [PATCH 1/3] swr/rast: simdlib changes for clang/gcc

Reviewed-by: Bruce Cherniak > On Jul 20, 2017, at 5:09 PM, Tim Rowley wrote: > > Tested with clang-4.0 and gcc-6.3. > --- > .../swr/rasterizer/common/simdlib_512_avx512.inl | 43 +- >

Re: [Mesa-dev] [PATCH 21/32] i965/miptree: Use ISL_AUX_STATE_PARTIAL_CLEAR for CCS_D

On Wed, Jul 19, 2017 at 02:01:47PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c >

Re: [Mesa-dev] [PATCH 3/3] swr/rast: fix memory paths for avx512 optimized avx/sse

Reviewed-by: Bruce Cherniak > On Jul 20, 2017, at 5:09 PM, Tim Rowley wrote: > > Source/destination will not be AVX512 aligned, use the > unaligned load/store intrinsics. > --- > .../drivers/swr/rasterizer/common/simdlib_128_avx512.inl

Re: [Mesa-dev] [PATCH 2/3] swr/rast: cache line align hottile buffers

Reviewed-by: Bruce Cherniak > On Jul 20, 2017, at 5:09 PM, Tim Rowley wrote: > > Prevents unalignment crashes with avx512 code on gcc/clang. > --- > src/gallium/drivers/swr/rasterizer/core/tilemgr.cpp | 6 +++--- > 1 file changed, 3

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] swr: use the correct variable for no undefined symbols

Reviewed-by: Tim Rowley > On Jul 21, 2017, at 1:05 PM, Emil Velikov wrote: > > From: Emil Velikov > > The variable name was missing a leading LD_, which resulted in the > backend binaries having unresolved

Re: [Mesa-dev] [PATCH 1/3] swr: don't forget to link AVX/AVX2 against pthreads

Reviewed-by: Tim Rowley > On Jul 21, 2017, at 1:05 PM, Emil Velikov wrote: > > From: Emil Velikov > > Seems like the backends have been using pthreads since day one, yet > we've been missing the link. > > With

Re: [Mesa-dev] [PATCH 20/32] intel/isl: Add an aux state for "partial clear"

On Wed, Jul 19, 2017 at 02:01:46PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 88 > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 > 2 files changed, 64 insertions(+), 35 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/3] swr: don't forget to link KNL/SKX against pthreads

Reviewed-by: Tim Rowley > On Jul 21, 2017, at 1:05 PM, Emil Velikov wrote: > > From: Emil Velikov > > Analogous to previous commit but for the KNL/SKX backends. > > Cc: Bruce Cherniak

Re: [Mesa-dev] [PATCH] gallivm: handle call attributes for llvm < 4.0 in lp_add_function_attr

On 07/21/2017 12:31 PM, srol...@vmware.com wrote: From: Roland Scheidegger We had some caller using LLVMAddInstrAttributes, which couldn't be converted to lp_add_function_attr, because attributes were only handled for functions in this case, so fix this. For llvm >= 4.0,

Re: [Mesa-dev] [PATCH] intel/isl: Add support for blitter restrictions

On Fri, Jul 21, 2017 at 12:27 PM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-07-21 20:11:27) > > + if (surf_info->usage & ISL_SURF_USAGE_BLIT_BIT) { > > + /* According to the Ivy Bridge PRM, Vol1 Part4, section 1.2.1.2 > > + * (Graphics Data Size

Re: [Mesa-dev] [PATCH 05/17] intel/isl: Aling non-tiled horizontally by cache line

On Fri, Jul 21, 2017 at 11:29 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jul 21, 2017 at 11:09:47AM -0700, Jason Ekstrand wrote: > > s/Aling/Align/ > > > > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > > topi.pohjolai...@gmail.com> wrote: > > > > > in order to

Re: [Mesa-dev] [PATCH] intel/isl: Add support for blitter restrictions

Quoting Jason Ekstrand (2017-07-21 20:11:27) > + if (surf_info->usage & ISL_SURF_USAGE_BLIT_BIT) { > + /* According to the Ivy Bridge PRM, Vol1 Part4, section 1.2.1.2 > + * (Graphics Data Size Limitations): > + * > + *The BLT engine is capable of transferring very

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Prepare non-tiled fallback for isl based

On Fri, Jul 21, 2017 at 12:22:48PM -0700, Jason Ekstrand wrote: > On Fri, Jul 21, 2017 at 11:23 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Fri, Jul 21, 2017 at 10:54:34AM -0700, Jason Ekstrand wrote: > > > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > > >

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Prepare non-tiled fallback for isl based

On Fri, Jul 21, 2017 at 11:23 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jul 21, 2017 at 10:54:34AM -0700, Jason Ekstrand wrote: > > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > > topi.pohjolai...@gmail.com> wrote: > > > > > See brw_miptree_choose_tiling(). > >

[Mesa-dev] [PATCH v2] swr/rast: quit using linux-specific gettid()

Linux-specific gettid() syscall shouldn't be used in portable code. Fix does assume a 1:1 thread:LWP architecture, but works for our current target platforms and can be revisited later if needed. Fixes unresolved symbol in linux scons builds. v2: add comment in code about the 1:1 assumption.

Re: [Mesa-dev] [PATCH 17/17] i965/miptree: Clean-up unused

On Fri, Jul 21, 2017 at 11:43:16AM -0700, Jason Ekstrand wrote: > On Fri, Jul 21, 2017 at 8:01 AM, Topi Pohjolainen < > topi.pohjolai...@gmail.com> wrote: > > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/Makefile.sources | 1 - > >

[Mesa-dev] [PATCH] intel/isl: Add support for blitter restrictions

--- src/intel/isl/isl.c | 42 +++--- src/intel/isl/isl.h | 1 + src/intel/isl/isl_gen4.c | 5 + 3 files changed, 45 insertions(+), 3 deletions(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 7d1356f..26310bf 100644 ---

Re: [Mesa-dev] [PATCH 15/17] i965/miptree: Switch remaining surfaces to isl

11-15 are Reviewed-by: Jason Ekstrand On Fri, Jul 21, 2017 at 8:01 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 10 +- >

Re: [Mesa-dev] [PATCH V3] i965 : Optimize atom state flag checks

On 07/21, aravindan.muthuku...@intel.com wrote: From: Aravindan Muthukumar This patch improves CPI Rate(Cycles per Instruction) and branch miss predict for i965. The function check_state() was showing CPI retired rate. Performance stats with android: - CPI

[Mesa-dev] [PATCH] gallivm: handle call attributes for llvm < 4.0 in lp_add_function_attr

From: Roland Scheidegger We had some caller using LLVMAddInstrAttributes, which couldn't be converted to lp_add_function_attr, because attributes were only handled for functions in this case, so fix this. For llvm >= 4.0, this already works correctly. (radeonsi seems to avoid

Re: [Mesa-dev] [PATCH 05/17] intel/isl: Aling non-tiled horizontally by cache line

On Fri, Jul 21, 2017 at 11:09:47AM -0700, Jason Ekstrand wrote: > s/Aling/Align/ > > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > topi.pohjolai...@gmail.com> wrote: > > > in order to support blit engine. > > > > Signed-off-by: Topi Pohjolainen > > --- > >

Re: [Mesa-dev] [PATCH 01/17] intel/isl: Add missing stencil pitch validation

On Fri, Jul 21, 2017 at 10:47:34AM -0700, Jason Ekstrand wrote: > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > topi.pohjolai...@gmail.com> wrote: > > > Signed-off-by: Topi Pohjolainen > > --- > > src/intel/isl/isl.c | 6 -- > > 1 file changed, 4

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Prepare non-tiled fallback for isl based

On Fri, Jul 21, 2017 at 10:54:34AM -0700, Jason Ekstrand wrote: > On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < > topi.pohjolai...@gmail.com> wrote: > > > See brw_miptree_choose_tiling(). > > > > Signed-off-by: Topi Pohjolainen > > --- > >

Re: [Mesa-dev] [PATCH 10/17] main/teximage: Even on failure use valid format for init()

Reviewed-by: Jason Ekstrand Cc stable? On Fri, Jul 21, 2017 at 8:01 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Otherwise init_teximage_fields_ms() (called by > _mesa_init_teximage_fields()) will always assert as it can't > find valid base format. > >

Re: [Mesa-dev] [PATCH 09/17] intel/isl/gen7: Don't allow multisampled surfaces with valign2

6-9 are Reviewed-by: Jason Ekstrand On Fri, Jul 21, 2017 at 8:01 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > There is the same constraintg later on as assert in > isl_gen7_choose_image_alignment_el() so catch it earlier in order > to return error instead

Re: [Mesa-dev] [PATCH 02/17] i965/miptree: Prepare has_color_unresolved() for isl based

Reviewed-by: Jason Ekstrand On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +- > 1 file changed, 5

Re: [Mesa-dev] [PATCH] swr/rast: quit using linux-specific gettid()

On 21 July 2017 at 17:46, Tim Rowley wrote: > Linux-specific gettid() syscall shouldn't be used in portable code. > Fix does assume a 1:1 thread:LWP architecture, but works for our > current target platforms and can be revisited later if needed. > I'm not familiar with

Re: [Mesa-dev] [PATCH 05/17] intel/isl: Aling non-tiled horizontally by cache line

s/Aling/Align/ On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > in order to support blit engine. > > Signed-off-by: Topi Pohjolainen > --- > src/intel/isl/isl.c | 16 +++- > 1 file changed, 15 insertions(+), 1

[Mesa-dev] [PATCH 1/3] swr: don't forget to link AVX/AVX2 against pthreads

From: Emil Velikov Seems like the backends have been using pthreads since day one, yet we've been missing the link. With later commit we'll fix a typo, hence the libraries will be build with -Wl,no-undefined, aka failing the build on unresolved symbols. v2: Split

[Mesa-dev] [PATCH 2/3] swr: don't forget to link KNL/SKX against pthreads

From: Emil Velikov Analogous to previous commit but for the KNL/SKX backends. Cc: Bruce Cherniak Cc: Tim Rowley Cc: Laurent Carlier Fixes: 1cb5a6061ce ("configure/swr: add KNL and SKX

[Mesa-dev] [PATCH 3/3] swr: use the correct variable for no undefined symbols

From: Emil Velikov The variable name was missing a leading LD_, which resulted in the backend binaries having unresolved symbols. With the link addressed with earlier patches, we can correct the typo. Thanks to Laurent for the help spotting this. v2: Split from a

Re: [Mesa-dev] Mesa 17.2.0 release plan

On 20 July 2017 at 06:09, Jason Ekstrand wrote: > On Mon, Jul 17, 2017 at 7:54 AM, Emil Velikov > wrote: >> >> On 16 July 2017 at 06:35, Jason Ekstrand wrote: >> > n Fri, Jul 7, 2017 at 11:07 AM, Emil Velikov

Re: [Mesa-dev] [PATCH 03/17] i965/miptree: Prepare non-tiled fallback for isl based

On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > See brw_miptree_choose_tiling(). > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 36 > +++ > 1 file changed,

[Mesa-dev] [PATCH 080/101] mesa: add buffer_data() and buffer_data_error() helpers

And call buffer_data_error() from _mesa_buffer_data(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 112 ++ 1 file changed, 64 insertions(+), 48 deletions(-) diff --git a/src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH 087/101] mesa: add shader_source() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index ae5647b4c0..941419b6f1 100644 ---

Re: [Mesa-dev] [PATCH 01/17] intel/isl: Add missing stencil pitch validation

On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/intel/isl/isl.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/intel/isl/isl.c

[Mesa-dev] [PATCH 038/101] mesa: add delete_samplers() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/samplerobj.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/samplerobj.c b/src/mesa/main/samplerobj.c index d182ee03c0..aae2a6bbbf 100644 ---

[Mesa-dev] [PATCH 067/101] mesa: add KHR_no_error support to glDrawBuffers()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/buffers.c | 16 src/mesa/main/buffers.h | 3 +++ 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 084/101] mesa: add end_conditional_render() render

Signed-off-by: Samuel Pitoiset --- src/mesa/main/condrender.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c index 24a7f4b694..051cd8f962 100644 ---

[Mesa-dev] [PATCH 082/101] mesa: add begin_conditional_render() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/condrender.c | 121 - 1 file changed, 66 insertions(+), 55 deletions(-) diff --git a/src/mesa/main/condrender.c b/src/mesa/main/condrender.c index 2ea2c8821d..95d6d6ad5f

[Mesa-dev] [PATCH 090/101] mesa: add KHR_no_error support to glLinkProgram()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 18 ++ src/mesa/main/shaderapi.h | 3 +++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 073/101] mesa: add KHR_no_error support to glTextureSubImage*D()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +-- src/mesa/main/teximage.c | 52 ++ src/mesa/main/teximage.h | 16 3 files changed, 71 insertions(+),

[Mesa-dev] [PATCH 086/101] mesa: rename shader_source() to set_shader_source()

There is already get_shader_source(), and shader_source() will be used for adding KHR_no_error support. Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 088/101] mesa: add KHR_no_error support to glShaderSource()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/shaderapi.c | 9 + src/mesa/main/shaderapi.h | 4 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 089/101] mesa: add link_program() and link_program_error() helpers

And call link_program_error() from _mesa_link_program(). Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 46 +- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 053/101] mesa: add KHR_no_error support to glBindTexture()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/texobj.c| 8 src/mesa/main/texobj.h| 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 083/101] mesa: add KHR_no_error support to glBeginConditionalRender()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/condrender.c | 8 src/mesa/main/condrender.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [PATCH 085/101] mesa: add KHR_no_error support to glEndConditionalRender()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/GL3x.xml | 2 +- src/mesa/main/condrender.c | 8 src/mesa/main/condrender.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/GL3x.xml

[Mesa-dev] [PATCH 076/101] mesa: add point_size() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/points.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/points.c b/src/mesa/main/points.c index 2d62e73c12..012fac5b3c 100644 --- a/src/mesa/main/points.c +++

[Mesa-dev] [PATCH 079/101] mesa: add KHR_no_error support to glLineWidth()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/lines.c | 8 src/mesa/main/lines.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 046/101] mesa: add min_sample_shading() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/multisample.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c index f8b117f143..037c8a6a15 100644 ---

[Mesa-dev] [PATCH 077/101] mesa: add KHR_no_error support to glPointSize()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/points.c| 8 src/mesa/main/points.h| 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 071/101] mesa: add KHR_no_error support to glDetachShader() and glDetachObjectARB()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 4 ++-- src/mesa/main/shaderapi.c | 23 +++ src/mesa/main/shaderapi.h | 6 ++ 3 files changed, 31 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 078/101] mesa: add line_width() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/lines.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/lines.c b/src/mesa/main/lines.c index d83a7d88d1..6586bb6ebf 100644 --- a/src/mesa/main/lines.c +++

[Mesa-dev] [PATCH 081/101] mesa: add KHR_no_error support to glNamedBufferData() and glBufferData()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/bufferobj.c | 30 ++ src/mesa/main/bufferobj.h

[Mesa-dev] [PATCH 070/101] mesa: add detach_shader_error() helper

And make detach_shader() always inline. Signed-off-by: Samuel Pitoiset --- src/mesa/main/shaderapi.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index

[Mesa-dev] [PATCH 075/101] mesa: add KHR_no_error support to glVertexArrayElementBuffer()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/arrayobj.c | 8 src/mesa/main/arrayobj.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 065/101] mesa: add KHR_no_error support to glDeleteBuffers()

Signed-off-by: Samuel Pitoiset --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/bufferobj.c | 8 src/mesa/main/bufferobj.h | 3 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml

[Mesa-dev] [PATCH 056/101] mesa: add draw_buffer_error() helper

And make draw_buffer() always inline. Signed-off-by: Samuel Pitoiset --- src/mesa/main/buffers.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index 6359e1b51f..a37b39cf52

[Mesa-dev] [PATCH 074/101] mesa: add vertex_array_element_buffer() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/arrayobj.c | 59 +++- 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index f0a3f7b1fd..2ce49c7c8c 100644

[Mesa-dev] [PATCH 064/101] mesa: add delete_buffers() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/main/bufferobj.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 419972e371..a3b871f0ad 100644 ---

[Mesa-dev] [PATCH 066/101] mesa: add draw_buffers_error() helper

And make draw_buffers() always inline. Signed-off-by: Samuel Pitoiset --- src/mesa/main/buffers.c | 223 ++-- 1 file changed, 119 insertions(+), 104 deletions(-) diff --git a/src/mesa/main/buffers.c

[Mesa-dev] [PATCH 072/101] mesa: add texturesubimage_error() helper

And make texturesubimage() always inline. Signed-off-by: Samuel Pitoiset --- src/mesa/main/teximage.c | 75 +--- 1 file changed, 45 insertions(+), 30 deletions(-) diff --git a/src/mesa/main/teximage.c

  1   2   3   >