Re: [Mesa-dev] [PATCH 1/5] clover/memory: Copy data when creating buffers with CL_MEM_USE_HOST_PTR

/ On Sat, Jul 22, 2017 at 2:27 PM, Jan Vesely wrote: > On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote: >> Fixes: OpenCL CTS test/conformance/buffers/buffer_copy > > Similar patch was pushed in 2013: > 56647c5d8f8e60269f0a3277e3caa7ee57d1fe6a > "clover: Append

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #7 from Kenneth Graunke --- You might also want to try with UNITY_DISABLE_GRAPHICS_DRIVER_WORKAROUNDS=yes - Cities Skylines has broken in the past due to bugs in Unity (which were fixed in a newer version of

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: add osmesa framebuffer iface hash table per st manager

Change looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, August 2, 2017 8:30 PM To: Bruce Cherniak; mesa-dev@lists.freedesktop.org Cc: 17 . 2; Charmaine Lee Subject: Re: [Mesa-stable] [PATCH] st/mesa: add

[Mesa-dev] [PATCH] intel/vec4/gs: reset nr_pull_param if DUAL_INSTANCED compile failed.

If dual instanced compile fails (as seems to happen with virgl a fair bit, and does piglit even have any tests for it?), we end up not restarting the pull params, so we call vec4_visitor::move_uniform_array_access_to_pull_constant a second time and it runs over the ends of the alloc. Fixes:

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

Yes, I'm not proposing otherwise. -Brian On 08/02/2017 03:53 PM, Marek Olšák wrote: Can the issue be fixed such that gallium drivers keep getting nr_samples = 0? Marek On Wed, Aug 2, 2017 at 7:07 PM, Brian Paul wrote: We pretty much use the convention that if

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: add osmesa framebuffer iface hash table per st manager

I'll let Charmaine review, but the subject line prefix should probably be "st/osmesa". -Brian On 08/02/2017 05:28 PM, Bruce Cherniak wrote: Commit bbc29393d3 didn't include osmesa state_tracker. This patch adds necessary initialization. Fixes crash in OSMesa initialization. Created-by:

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #6 from MWATTT --- This game always worked fine for me with an HD 5770, and is still OK with Oibaf PPA. It was also OK with an HD 4850. The problem might be specific to Cayman. Can you try running the game with

Re: [Mesa-dev] [PATCH 2/2] configure.ac: drop support for ancient expat versions

On 03/08/17 03:39 AM, Emil Velikov wrote: > From: Emil Velikov > > Expat versions prior to 2.1.0 lack the .pc file, so we need to do extra > gymnastics to detect it. > > Version 2.1.0 was released back in Mar 2012 and all major distributions > use it. > > Cc: Michel

Re: [Mesa-dev] [PATCH] pipe-loader: fix build of dynamic pipe-drivers

On 03/08/17 01:14 AM, Nicolai Hähnle wrote: > On 02.08.2017 18:04, Emil Velikov wrote: >> On 2 August 2017 at 16:29, Nicolai Hähnle wrote: >>> From: Nicolai Hähnle >>> >>> Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create >>>

Re: [Mesa-dev] [PATCH] i965/blit: Remember to include miptree buffer offset in relocs

On Monday, July 31, 2017 2:56:15 AM PDT Chris Wilson wrote: > Remember to add the offset to the start of the buffer in the relocation > or else we write 0xff into random bytes elsewhere. > --- > src/mesa/drivers/dri/i965/intel_blit.c | 4 ++-- >

[Mesa-dev] [PATCH] i965/bufmgr: Set bo->idle after waiting.

After a successful wait, we know the buffer ought to be idle. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c index f70365eba2a..1df812a711a 100644 ---

[Mesa-dev] Android fixes for radeonsi building errors introduced by recent commits

[PATCH 1/3] android: radeonsi: add nir include paths [PATCH 2/3] android: ac/common: always build NIR translation [PATCH 3/3] android: radeonsi: prepare for driver-specific driconf ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 1/3] android: radeonsi: add nir include paths

Android build changes to avoid the following building error: target C: libmesa_pipe_radeonsi <= external/mesa/src/gallium/drivers/radeonsi/si_pipe.c ... In file included from external/mesa/src/gallium/drivers/radeonsi/si_pipe.c:38: external/mesa/src/compiler/nir/nir.h:48:10: fatal error:

[Mesa-dev] [PATCH 2/3] android: ac/common: always build NIR translation

Android build changes to avoid the following building error: external/mesa/src/gallium/drivers/radeonsi/si_shader_nir.c:505: error: undefined reference to 'ac_nir_translate' Fixes: 86d4b46d66 "ac/common: always build NIR translation" --- src/amd/Android.common.mk | 3 ++- 1 file changed, 2

[Mesa-dev] [PATCH 3/3] android: radeonsi: prepare for driver-specific driconf options

Android build changes to avoid the following building error: In file included from external/mesa/src/gallium/targets/dri/target.c:1: external/mesa/src/gallium/auxiliary/target-helpers/drm_helper.h:185:10: fatal error: 'radeonsi/si_driinfo.h' file not found #include "radeonsi/si_driinfo.h"

Re: [Mesa-dev] [PATCH v3] glsl: update the extensions that are enabled for 460

Can you go through all the others and work out the suffixes too? Just going by memory, but the vote extension functions have suffixes, as do the atomic counter ones, maybe there's other stuff too... On Aug 2, 2017 2:15 PM, "Samuel Pitoiset" wrote: > Other ones are

Re: [Mesa-dev] [PATCH 2/2] mesa: only check errors when the state change in glLogicOp()

Both: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] st/mesa: add osmesa framebuffer iface hash table per st manager

Commit bbc29393d3 didn't include osmesa state_tracker. This patch adds necessary initialization. Fixes crash in OSMesa initialization. Created-by: Charmaine Lee Tested-by: Bruce Cherniak Cc: Charmaine Lee Cc: 17.2

[Mesa-dev] [PATCH] st/mesa: add osmesa framebuffer iface hash table per st manager

Commit bbc29393d3 didn't include osmesa state_tracker. This patch adds necessary initialization. Fixes crash in OSMesa initialization. Created-by: Charmaine Lee Tested-by: Bruce Cherniak Cc: 17.2 ---

Re: [Mesa-dev] [PATCH 03/11] i965/blit: Stop asserting linear row_pitches are 64B-aligned

Ken committed this as 595a47b8293 earlier today. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] anv/allocator: Loosen the size restriction on imported BOs

It's possible for a buffer manager to issue the application a BO that is larger than what is requested. The out-of-bounds access issue would only apply in cases where the size of the imported buffer exceeds that of the underlying BO, as such we should only reject import requests sizes that exceed

Re: [Mesa-dev] [PATCH v2 1/1] clover: Wait for requested operation if blocking flag is set

These changes are somewhat redundant and potentially performance-impacting, the reason is that in the OpenCL API, clEnqueueWrite* commands are specified to block until the memory provided by the application as origin can be reused safely (i.e. until soft_copy_op()() runs), not necessarily until

Re: [Mesa-dev] [PATCH 1/3] radv: Add VK_KHR_display, VK_KEITHP_kms_display and VK_EXT_direct_mode_display [v2]

Emil Velikov writes: > Is the VK_KEITHP_kms_display spec available somewhere? Here's a rough version: VK_KEITHP_kms_display = **Name String** VK_KEITHP_kms_display **Extension Type** Instance Extension **Registered Extension

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

Can the issue be fixed such that gallium drivers keep getting nr_samples = 0? Marek On Wed, Aug 2, 2017 at 7:07 PM, Brian Paul wrote: > We pretty much use the convention that if gl_renderbuffer::NumSamples > or gl_texture_image::NumSamples is zero, it's a non-MSAA surface. >

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #5 from Gert Wollny --- Can you also run the game from the command line and see whether there are any error messages, specifically whether you get any messages saying something like r600_shader_select -

[Mesa-dev] [PATCH v2 1/1] clover: Wait for requested operation if blocking flag is set

v2: wait in map_buffer and map_image as well Signed-off-by: Jan Vesely --- Hi Aaron, yes, I think you're right, we should wait in Map* as well. If nothing else it's consistent, even if passing the flag to add_map might make it unnecessary (haven't actually checked).

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

probably. The original changeset passes NULL(which is then unconditionally accessed) at least in: src/gallium/auxiliary/vl/vl_winsys_dri.c src/gallium/auxiliary/vl/vl_winsys_dri3.c src/gallium/auxiliary/vl/vl_winsys_drm.c src/gallium/state_trackers/xa/xa_tracker.c

Re: [Mesa-dev] [PATCH v2] mesa: Fix swizzling for luminance/intensity in _mesa_readpixels

On Wednesday, August 2, 2017 3:28:23 AM PDT Nicolai Hähnle wrote: > On 01.08.2017 00:15, Chris Wilson wrote: > > Quoting Chris Wilson (2017-07-31 22:51:25) > >> Luminance/Intensity when converted to RGB should be replicated to fill > >> the RGB channels, but they differ on how the alpha channel is

[Mesa-dev] [PATCH 11/11] i965/miptree: Rework create flags

The only one of the three remaining flags that has anything whatsoever to do with layout is TILING_NONE. This commit renames them to MIPTREE_CREATE_*, documents the meaning of each flag, and makes the create functions take an actual enum type so GDB will print them nicely. ---

[Mesa-dev] [PATCH 09/11] i965/miptree: Delete an unused function declaration

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h index 7636172..70acb96 100644 --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h +++

[Mesa-dev] [PATCH 08/11] i965/miptree: Call alloc_aux in create_for_bo

Originally, I had moved it to the caller to make some things easier when adding the CCS modifier. However, this broke DRI2 because intel_process_dri2_buffer calls intel_miptree_create_for_bo but never calls intel_miptree_alloc_aux. Also, in hindsight, it should be pretty easy to make the CCS

[Mesa-dev] [PATCH 10/11] i965/miptree: Delete MIPTREE_LAYOUT_TILING_(Y|ANY)

The only force tiling flag we really care about is LAYOUT_TILING_NONE. The others don't actually do anything but add confusion. --- src/mesa/drivers/dri/i965/intel_fbo.c | 3 +-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 19 ---

[Mesa-dev] [PATCH 02/11] intel/isl: Don't align the height of the last array slice

We were calculating the total height of 2D surfaces by multiplying the row pitch by the number of slices. This means that we actually request slightly more space than actually needed since the padding on the last slice is unnecessary. For tiled surfaces this is not likely to make a difference.

[Mesa-dev] [PATCH 06/11] i965/miptree: Delete some unused layout flags

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 ++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 --- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index

[Mesa-dev] [PATCH 04/11] i965/miptree Remove layout_flags parameter form is_mcs_supported

--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index daa49f9..0e0aaa8 100644 ---

[Mesa-dev] [PATCH 01/11] intel/isl: Stop padding surfaces

The docs contain a bunch of commentary about the need to pad various surfaces out to multiples of something or other. However, all of those requirements are about avoiding GTT errors due to missing pages when the data port or sampler accesses slightly out-of-bounds. However, because the kernel

[Mesa-dev] [PATCH 07/11] i965/miptree: Delete MIPTREE_LAYOUT_FOR_SCANOUT

The flag hasn't affected actual surface layout for some time. The only purpose it served was to set bo->cache_coherent = false on the BO used to create the miptree. This is fairly silly because we can just set that directly from the caller where it makes much more sense. ---

[Mesa-dev] [PATCH 00/11] i965: Clean up miptrees a bit

This patch series is the start of what I'm sure will be a decent sized effort to clean up intel_mipmap_tree.c after the ISL conversion. Patches 1, 2, 3, and 8 are actually bugfixes that will need to get landed in 17.2. The rest just makes the miptree create flags more sane. Cc: Topi Pohjolainen

[Mesa-dev] [PATCH 03/11] i965/blit: Stop asserting linear row_pitches are 64B-aligned

The 64B alignment restriction is on the base address and not the row pitch. This code already ensures that the base address is aligned by adding a small X offset if needed. The assertion serves no purpose and is actually causing people problems. Cc: "17.2"

[Mesa-dev] [PATCH 05/11] i965/miptree: Refactor is_mcs_supported

We rename it to intel_miptree_supports_mcs and make the function signature match intel_miptree_supports_ccs/hiz. We also move the sample count check into the function so it returns false for single-sampled surfaces. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 13 + 1 file

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

Hmm, been AFK, but now have actually installed as well as just testing build. Testing with this and the patch that avoids segfaults for cl. I am getting segfaults when using vdpau for video, so maybe that needs something similar. Jan Vesely wrote: The patch still causes segfaults because

[Mesa-dev] [PATCH 3/3] specs: Add EGL_MESA_platform_device

This extension name is bad, but I don't have an idea for a better one. Signed-off-by: Adam Jackson --- docs/specs/EGL_MESA_platform_device.txt | 94 + 1 file changed, 94 insertions(+) create mode 100644 docs/specs/EGL_MESA_platform_device.txt

[Mesa-dev] [PATCH 2/3] specs: Add EGL_MESA_device_software

The device extension string is expected to contain the name of the extension defining what kind of device it is, so the caller can know what kinds of operations it can perform with it. So that string had better be non-empty, hence this trivial extension. Signed-off-by: Adam Jackson

[Mesa-dev] [RFC PATCH 0/3] EGL spec updates and proposals

I've been looking at finishing up the EGL_EXT_device_base work properly as I'd like to consume it in xserver. I think I'm going to need some additional extensions to be able to consume it sanely though, so, here's some draft specs. Any feedback would be greatly appreciated. 1/3 is a bit

[Mesa-dev] [PATCH 1/3] specs: Update Mesa EGL enums

Note that, presumably because Khronos never got a copy of WL_bind_wayland_display in the registry, we've double-allocated some enums into the (now KHR) platform extensions, and we should consider retiring the wayland extension at some point to fix it. Signed-off-by: Adam Jackson

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

Am 02.08.2017 um 21:49 schrieb Brian Paul: > On 08/02/2017 01:18 PM, Roland Scheidegger wrote: >> Am 02.08.2017 um 20:35 schrieb Brian Paul: >>> On 08/02/2017 11:59 AM, Roland Scheidegger wrote: I think the problem here is that msaa surfaces with sample count 1 are not really supposed to

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

On 08/02/2017 01:18 PM, Roland Scheidegger wrote: Am 02.08.2017 um 20:35 schrieb Brian Paul: On 08/02/2017 11:59 AM, Roland Scheidegger wrote: I think the problem here is that msaa surfaces with sample count 1 are not really supposed to exist in gallium. This is a rather awkward gl-ism, which

[Mesa-dev] [PATCH 2/2] mesa: reduce CPU overhead when updating the viewport

Before: DrawElements (1 VBO, 8 UBO, 8 Tex) w/ viewport change: 3.61 million (43.7%) After: DrawElements (1 VBO, 8 UBO, 8 Tex) w/ viewport change: 4.95 million (60.2%) Signed-off-by: Samuel Pitoiset --- src/mesa/main/viewport.c | 89

[Mesa-dev] [PATCH 1/2] mesa: reduce CPU overhead when updating the scissor

Before: DrawElements (1 VBO, 8 UBO, 8 Tex) w/ scissor change: 3.67 million (44.4%) After: DrawElements (1 VBO, 8 UBO, 8 Tex) w/ scissor change: 5.02 million (62.1%) Signed-off-by: Samuel Pitoiset --- src/mesa/main/scissor.c | 79

Re: [Mesa-dev] [PATCH 1/2] gallium: add CAPs to support HW atomic counters.

On 2 August 2017 at 20:56, Nicolai Hähnle wrote: > On 02.08.2017 01:00, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This looks like an evergreen specific feature, but with atomic >> counters AMD have hw specific counters they use instead of operating

Re: [Mesa-dev] [PATCH] intel/isl: Stop padding surfaces

On Wed, Aug 2, 2017 at 8:23 AM, Tomasz Figa wrote: > On Tue, Aug 1, 2017 at 3:27 AM, Jason Ekstrand > wrote: > > The docs contain a bunch of commentary about the need to pad various > > surfaces out to multiples of something or other. However, all of

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

Am 02.08.2017 um 20:35 schrieb Brian Paul: > On 08/02/2017 11:59 AM, Roland Scheidegger wrote: >> I think the problem here is that msaa surfaces with sample count 1 are >> not really supposed to exist in gallium. >> This is a rather awkward gl-ism, which isn't possible anywhere else, >> other apis

[Mesa-dev] [PATCH v3] glsl: update the extensions that are enabled for 460

Other ones are either unsupported or don't have any helper function checks. v3: - always add gl_BaseVertex & co when 460 is enabled v2: - fix ARB_shader_draw_parameters system value names Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 6

[Mesa-dev] [PATCH v5 2/2] i965: Queue the buffer with a sync fence for Android OS

From: Zhongmin Wu Before we queued the buffer with a invalid fence (-1), it causes benchmarks such as flatland to fail. This patch enables explicit sync feature on android. Now we get the out fence during the flushing buffer and then pass it to SurfaceFlinger in

[Mesa-dev] [PATCH v5 1/2] i965: Return the last fence if the batch buffer is empty

From: Zhongmin Wu Always save the last fence in the brw context when flushing buffer. If there is nothing to be flushed, return the last fence if asked for. Nothing to be flushed when _intel_batchbuffer_flush_fence. Signed-off-by: Zhongmin Wu

Re: [Mesa-dev] [PATCH v2] glsl: update the extensions that are enabled for 460

On 08/02/2017 09:06 PM, Gustaw Smolarczyk wrote: 2017-08-02 20:57 GMT+02:00 Samuel Pitoiset : Other ones are either unsupported or don't have any helper function checks. v2: - fix ARB_shader_draw_parameters system value names Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH 2/2] calibrate_rast: add command line arguments

To skip swapbuffers, or only test points/lines/quads. --- src/tests/calibrate_rast.c | 130 ++--- 1 file changed, 88 insertions(+), 42 deletions(-) diff --git a/src/tests/calibrate_rast.c b/src/tests/calibrate_rast.c index ae9ff10..0bbbf84 100644 ---

[Mesa-dev] [PATCH 1/2] calibrate_rast: add vertical line test

Print GL_VERSION string. Call glutSwapBuffers() and fflush() more frequently so we can see what's happening. --- src/tests/calibrate_rast.c | 141 +++-- 1 file changed, 136 insertions(+), 5 deletions(-) diff --git a/src/tests/calibrate_rast.c

Re: [Mesa-dev] [PATCH v2] glsl: update the extensions that are enabled for 460

2017-08-02 20:57 GMT+02:00 Samuel Pitoiset : > Other ones are either unsupported or don't have any helper > function checks. > > v2: - fix ARB_shader_draw_parameters system value names > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH v2] glsl: update the extensions that are enabled for 460

Other ones are either unsupported or don't have any helper function checks. v2: - fix ARB_shader_draw_parameters system value names Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 6 -- src/compiler/glsl/builtin_variables.cpp | 12

Re: [Mesa-dev] [PATCH] glsl: update the extensions that are enabled for 460

On 08/02/2017 06:24 PM, Ilia Mirkin wrote: On Aug 2, 2017 6:56 AM, "Samuel Pitoiset" > wrote: Other ones are either unsupported or don't have any helper function checks. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH 2/2] mesa: only check errors when the state change in glLogicOp()

When this GL call is a no-op, it should be a little faster. Signed-off-by: Samuel Pitoiset --- src/mesa/main/blend.c | 56 ++- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/src/mesa/main/blend.c

[Mesa-dev] [PATCH 1/2] mesa: only check errors when the state change in glBlendEquationSeparateiARB()

When this GL call is a no-op, it should be a little faster. Signed-off-by: Samuel Pitoiset --- src/mesa/main/blend.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/blend.c

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

On 2 August 2017 at 18:29, Rafael Antognolli wrote: > On Wed, Aug 02, 2017 at 02:56:34PM +0100, Emil Velikov wrote: >> On 1 August 2017 at 16:29, Rafael Antognolli >> wrote: >> > On Mon, Jul 31, 2017 at 09:58:24AM -0700, Marathe, Yogesh

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #4 from Marcin Gałązka --- Created attachment 133209 --> https://bugs.freedesktop.org/attachment.cgi?id=133209=edit Dump from lspci (gfx only) -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #3 from Marcin Gałązka --- Created attachment 133208 --> https://bugs.freedesktop.org/attachment.cgi?id=133208=edit Dump from glxinfo -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [PATCH 1/2] configure.ac: unconditionally check for expat

From: Emil Velikov Earlier commits moved the xmlconfig library to a wider userbase. Thus having the check within --enable-dri is insufficient. Upon closer nine needed it from it's early days - 948e6c52282 ("nine: Add drirc options (v2)") Fixes: 601093f95ddf

[Mesa-dev] [PATCH 2/2] configure.ac: drop support for ancient expat versions

From: Emil Velikov Expat versions prior to 2.1.0 lack the .pc file, so we need to do extra gymnastics to detect it. Version 2.1.0 was released back in Mar 2012 and all major distributions use it. Cc: Michel Dänzer Signed-off-by: Emil Velikov

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #2 from Marcin Gałązka --- Created attachment 133207 --> https://bugs.freedesktop.org/attachment.cgi?id=133207=edit Screenshot from menu -- You are receiving this mail because: You are the QA Contact

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 --- Comment #1 from Marcin Gałązka --- Created attachment 133206 --> https://bugs.freedesktop.org/attachment.cgi?id=133206=edit Screenshot from game -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 102017] Wrong colours in Cities Skyline

https://bugs.freedesktop.org/show_bug.cgi?id=102017 Bug ID: 102017 Summary: Wrong colours in Cities Skyline Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH v2] docs: Add Vulkan to features.txt

Acked-by: Bas Nieuwenhuizen On Wed, Aug 2, 2017 at 7:57 PM, Jason Ekstrand wrote: > lgtm > > On Wed, Aug 2, 2017 at 10:51 AM, Jordan Justen > wrote: >> >> To get the extension list: >> >> $ git grep -hE "extension

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

On 08/02/2017 11:59 AM, Roland Scheidegger wrote: I think the problem here is that msaa surfaces with sample count 1 are not really supposed to exist in gallium. This is a rather awkward gl-ism, which isn't possible anywhere else, other apis have no distinction between a multisampled surface

Re: [Mesa-dev] [PATCH 1/3] radv: Add VK_KHR_display, VK_KEITHP_kms_display and VK_EXT_direct_mode_display [v2]

Emil Velikov writes: > Is the VK_KEITHP_kms_display spec available somewhere? I haven't written one yet. I'll go draft one. > Since there are multiple companies [participating in Mesa] with > Khronos membership, could we make this an EXT extension? Once > everything

Re: [Mesa-dev] [PATCH 0/4] dri3, gallium: Correctness and performance fixes v2

On 08/02/2017 06:10 PM, Sinclair Yeh wrote: Reviewed-by: Sinclair Yeh On Wed, Aug 02, 2017 at 02:23:52PM +0200, Thomas Hellstrom wrote: In v2 of the patch series, one freestanding patch has already been committed and the back-to-fake-front flip patch has been dropped since it

[Mesa-dev] [PATCH 1/1] clover: Pass valid config structure to pipe_loader_create_screen

Fixes: Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Signed-off-by: Jan Vesely --- apply with the other build/link fixes src/gallium/state_trackers/clover/core/device.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH 3/3] gallium/docs: add more info about TXF and MSAA textures

On 08/02/2017 12:03 PM, Roland Scheidegger wrote: Am 02.08.2017 um 19:07 schrieb Brian Paul: If the texture is multisampled, the coord.w component indicates which sample to fetch. --- src/gallium/docs/source/tgsi.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 3/3] gallium/docs: add more info about TXF and MSAA textures

Am 02.08.2017 um 19:07 schrieb Brian Paul: > If the texture is multisampled, the coord.w component indicates which > sample to fetch. > --- > src/gallium/docs/source/tgsi.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/docs/source/tgsi.rst >

Re: [Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

I think the problem here is that msaa surfaces with sample count 1 are not really supposed to exist in gallium. This is a rather awkward gl-ism, which isn't possible anywhere else, other apis have no distinction between a multisampled surface with sample count 1 and a non-multisampled surface with

Re: [Mesa-dev] [PATCH v2] docs: Add Vulkan to features.txt

lgtm On Wed, Aug 2, 2017 at 10:51 AM, Jordan Justen wrote: > To get the extension list: > > $ git grep -hE "extension name=\"VK_KHR" src/vulkan/registry/vk.xml | \ > grep -v disabled | awk '{print $2}' | sed -E 's/(name=)?"//g' | sort > > To find anv(il) and radv

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

The patch still causes segfaults because you pass NULL at core/device.cpp:45 yet unconditionally access the pointer at pipe_loader.c:130 Jan On Wed, 2017-08-02 at 18:44 +0200, Nicolai Hähnle wrote: > Thanks! I'll take that as a Tested-by. > > On 02.08.2017 18:43, Andy Furniss wrote: > >

Re: [Mesa-dev] [PATCH 2/4] glx/dri3: Implement the flush_swapbuffers method

On 08/02/2017 06:31 PM, Emil Velikov wrote: On 2 August 2017 at 13:23, Thomas Hellstrom wrote: Provide a dri3 implementation for the image loader extension method. Signed-off-by: Thomas Hellstrom --- src/glx/dri3_glx.c | 30

[Mesa-dev] [PATCH v2] docs: Add Vulkan to features.txt

To get the extension list: $ git grep -hE "extension name=\"VK_KHR" src/vulkan/registry/vk.xml | \ grep -v disabled | awk '{print $2}' | sed -E 's/(name=)?"//g' | sort To find anv(il) and radv supported extensions: $ git grep -hE "'VK_([A-Z]+)_[a-z]" src/intel/ $ git grep -hE

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

On Wed, Aug 02, 2017 at 02:56:34PM +0100, Emil Velikov wrote: > On 1 August 2017 at 16:29, Rafael Antognolli > wrote: > > On Mon, Jul 31, 2017 at 09:58:24AM -0700, Marathe, Yogesh wrote: > >> Rafael, Tomasz, > >> > >> > -Original Message- > >> > From:

Re: [Mesa-dev] [PATCH mesa] egl: check the correct function pointer

On 2 August 2017 at 17:47, Eric Engestrom wrote: > `.swap_interval` != `.SwapInterval`... > Had a bit of a brain freeze when I read this - can you please elaborate a bit. Feel free to reuse any of the following: "Earlier commit made the platform .swap_interval

[Mesa-dev] [PATCH 3/3] gallium/docs: add more info about TXF and MSAA textures

If the texture is multisampled, the coord.w component indicates which sample to fetch. --- src/gallium/docs/source/tgsi.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index d7817cc..5bf9e95 100644 ---

[Mesa-dev] [PATCH 2/3] svga: check for sample_count > 0 in svga_is_format_supported()

See previous commit for more info. If sample_count=1, we want to return failure here since we don't support 1x MSAA. --- src/gallium/drivers/svga/svga_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen.c

[Mesa-dev] [PATCH 1/3] st/mesa: fix handling of NumSamples=1

We pretty much use the convention that if gl_renderbuffer::NumSamples or gl_texture_image::NumSamples is zero, it's a non-MSAA surface. Otherwise, it's an MSAA surface. This patch changes the sample count checks in st_AllocTextureStorage() and st_renderbuffer_alloc_storage() to test for samples >

[Mesa-dev] [PATCH mesa] egl: check the correct function pointer

`.swap_interval` != `.SwapInterval`... Fixes: 991ec1b81a76de24fd01 "egl: make platform's SwapInterval() optional" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102015 Cc: Cedric Sodhi Signed-off-by: Eric Engestrom ---

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

Thanks! I'll take that as a Tested-by. On 02.08.2017 18:43, Andy Furniss wrote: Building OK with this. Nicolai Hähnle wrote: From: Nicolai Hähnle v2: add libxmlconfig.la to the dynamic pipe_radeonsi driver Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to

Re: [Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

Building OK with this. Nicolai Hähnle wrote: From: Nicolai Hähnle v2: add libxmlconfig.la to the dynamic pipe_radeonsi driver Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Bugzilla:

Re: [Mesa-dev] [PATCH mesa] git_sha1_gen: fix output on python3

Either way Reviewed-by: Jose Fonseca Thanks On 02/08/17 15:10, Eric Engestrom wrote: String handling has changed on python3. Before this patch: After: (No change on python2, it always looked ok) Cc: Jose Fonseca Fixes: b99dcbfeb344390fea99

Re: [Mesa-dev] [PATCH 2/4] glx/dri3: Implement the flush_swapbuffers method

On 2 August 2017 at 13:23, Thomas Hellstrom wrote: > Provide a dri3 implementation for the image loader extension method. > > Signed-off-by: Thomas Hellstrom > --- > src/glx/dri3_glx.c | 30 +- > 1 file changed, 29

Re: [Mesa-dev] [PATCH] pipe-loader: fix build of dynamic pipe-drivers

On 2 August 2017 at 17:14, Nicolai Hähnle wrote: > On 02.08.2017 18:04, Emil Velikov wrote: >> >> On 2 August 2017 at 16:29, Nicolai Hähnle wrote: >>> >>> From: Nicolai Hähnle >>> >>> Fixes: bc7f41e11d3 ("gallium: add

Re: [Mesa-dev] [PATCH 0/4] dri3, gallium: Correctness and performance fixes v2

Reviewed-by: Sinclair Yeh On Wed, Aug 02, 2017 at 02:23:52PM +0200, Thomas Hellstrom wrote: > In v2 of the patch series, one freestanding patch has already been committed > and the back-to-fake-front flip patch has been dropped since it requires some > more work to not break

Re: [Mesa-dev] [PATCH] glsl: update the extensions that are enabled for 460

On Aug 2, 2017 6:56 AM, "Samuel Pitoiset" wrote: Other ones are either unsupported or don't have any helper function checks. Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_functions.cpp | 6 --

[Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

From: Nicolai Hähnle v2: add libxmlconfig.la to the dynamic pipe_radeonsi driver Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102014 -- I believe this is the right place to add

Re: [Mesa-dev] [PATCH] pipe-loader: fix build of dynamic pipe-drivers

On 02.08.2017 18:04, Emil Velikov wrote: On 2 August 2017 at 16:29, Nicolai Hähnle wrote: From: Nicolai Hähnle Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions") Bugzilla:

Re: [Mesa-dev] [PATCH 1/2] anv: Advertise support for two more sRGB formats

So, it looks like I'll need some blorp patches before we can land this for real. I'll try and cook some up. On Wed, Aug 2, 2017 at 2:35 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Both are : > > Reviewed-by: Lionel Landwerlin > > > On 02/08/17

Re: [Mesa-dev] [PATCH 1/4] dri: Add a flushSwapBuffers method to the image loader extension

On 2 August 2017 at 13:23, Thomas Hellstrom wrote: > This method may be used by dri drivers to make sure all outstanding > buffer swaps have been flushed to hardware. > Also make sure we're allowed to bump the image loader extension version > without actually providing the

  1   2   >