Re: [Mesa-dev] [PATCH] nir/spirv: add support for chain access with different index bit sizes

On Mon, 2017-08-28 at 07:08 -0700, Jason Ekstrand wrote: > On August 28, 2017 1:18:33 AM Samuel Iglesias Gonsálvez  > wrote: > > > Fixes dEQP-VK.spirv_assembly.instruction.*.indexing.* > > > > Signed-off-by: Samuel Iglesias Gonsálvez > > --- > >  

[Mesa-dev] [PATCH v2 4/5] anv: move brw_process_intel_debug_variable to happen early

Currently anv_perf_warn call in anv_compute_heap_size does not ever report a perf warning. Move debug variable read as the first thing in case there will be other perf_warn calls added. Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_device.c | 4 ++-- 1 file

[Mesa-dev] [PATCH v2 1/5] anv: implementation of VK_EXT_debug_report extension

Patch adds required functionality for extension to manage a list of application provided callbacks and handle debug reporting from driver and application side. v2: remove useless helper anv_debug_report_call add locking around callbacks list use vk_alloc2, vk_free2 helpers refactor

[Mesa-dev] [PATCH v2 2/5] anv: wire up anv_perf_warn macro to do debug reporting

Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_device.c | 3 +- src/intel/vulkan/anv_image.c | 12 ++-- src/intel/vulkan/anv_private.h | 112 +++-- src/intel/vulkan/anv_util.c| 18 +-

[Mesa-dev] [PATCH v2 5/5] anv: remove extra 'debug:' from anv_debug_ignored_stype

anv_debug adds 'debug:' already, this is to clean following: debug: debug: anv_CreateDebugReportCallbackEXT: ignored VkStructureType 111000 Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v2 3/5] anv: wire up vk_errorf macro to do debug reporting

Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_allocator.c | 8 +--- src/intel/vulkan/anv_device.c| 38 -- src/intel/vulkan/anv_formats.c | 3 ++- src/intel/vulkan/anv_private.h | 12 +---

[Mesa-dev] [PATCH v2 0/5] VK_EXT_debug_report

Hi; Here's v2 of VK_EXT_debug_report with fixes to issues found by Jason and for some issues that came up with crucible testing, I've pushed VK_EXT_debug_report support for crucible so that can be used for verifying the functionality. 2 last patches are resent, I think they got lost in the noise

Re: [Mesa-dev] [PATCH 1/2] util: add stringbuf library

2017-08-28 11:47 GMT+02:00 Nicolai Hähnle : > On 28.08.2017 11:13, Nicolai Hähnle wrote: >> >> On 28.08.2017 03:51, Timothy Arceri wrote: >>> >>> On 27/08/17 05:18, Thomas Helland wrote: Plowed through it a couple times, and it looks solid to me. After thinking

[Mesa-dev] Vulkan on CPU Google Summer of Code project

GSOC 2017 is effectively over for me, Here's the link to the GSOC landing page that I will be submitting later: https://github.com/programmerjake/vulkan-cpu/blob/gsoc-2017/docs/gsoc-2017-landing-page.md I've only completed part of the Vulkan on CPU project: - I've completely implemented

[Mesa-dev] [PATCH 1/6] vl/compositor: make a helper function for YUV deinterlacing

The similar function is in OMX, and only used by OMX. Now have it to vl/compositor for other state tracker to use later. Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_compositor.c | 31 +++ src/gallium/auxiliary/vl/vl_compositor.h | 9

[Mesa-dev] [PATCH 2/6] st/omx: use vl/compositor helper function for YUV deinterlacing

v2: separate helper function in different patch Signed-off-by: Leo Liu --- src/gallium/state_trackers/omx/vid_dec.c | 32 ++-- 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/src/gallium/state_trackers/omx/vid_dec.c

[Mesa-dev] [PATCH 6/6] Revert "st/va: add enviromental variable to disable interlace"

This reverts commit 10dec2de2d9f568675d66d736b48701fa26f7b50. The environment variable is no longer needed with the previous change --- src/gallium/state_trackers/va/surface.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/state_trackers/va/surface.c

[Mesa-dev] [PATCH 5/6] st/va: move YUV content to deinterlaced buffer when reallocated for encoder

v2: use deinterlace common function v3: make sure deinterlace only Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c

[Mesa-dev] [PATCH 4/6] st/va: reallocate the buffer if the layout isn't supported

So that it makes more clear for buffer reallocation based on buffers layout for both decoder and encoder. Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 3/6] vl/compositor: make vl_compositor_set_yuv_layer() static

Since it's no longer being called outside of compositor Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_compositor.c | 60 +++- 1 file changed, 28 insertions(+), 32 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_compositor.c

Re: [Mesa-dev] [PATCH] nir/opcodes: Fix constant-folding of ufind_msb

Reviewed-by: Connor Abbott On Aug 28, 2017 11:11 PM, "Jason Ekstrand" wrote: > We didn't fold correctly in the case of 0x1 because we never let the > loop counter hit 0. Switching it to bit >= 0 solves this problem. > > Cc:

[Mesa-dev] [Bug 102463] SpaceEngine can't render main scenery properly

https://bugs.freedesktop.org/show_bug.cgi?id=102463 Timothy Arceri changed: What|Removed |Added Resolution|--- |NOTOURBUG

Re: [Mesa-dev] [PATCH 3/3] radv: Add trace ids for secondary buffers.

Nice, I started reinventing the same wheel yesterday so this is 90% of what I had done, but right. The only other thing I did was tie secondary execution into the primary for lookups instead of debug all bos. Once this lands I might clean that up if we want it. Otherwise, for all 3 Reviewed-by:

Re: [Mesa-dev] [PATCH v2 12/12] radeonsi: add an assertion that only two-dimensional constant references are used

On 29/08/17 10:32, Timothy Arceri wrote: I'd like to see the clean-ups mentioned in patch 3, that would mean you need to remove this assert. I guess you could leave this patch and do the clean-up as a follow-up so that you can more easily debug/bisect if something has gone wrong, up to you.

Re: [Mesa-dev] [PATCH v2 03/12] tgsi/build: always generate two-dimensional constant file accesses

On 29/08/17 10:22, Timothy Arceri wrote: On 28/08/17 18:58, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_build.c | 11 + src/gallium/auxiliary/tgsi/tgsi_transform.h | 65 +++-- 2 files changed,

Re: [Mesa-dev] [PATCH v2 12/12] radeonsi: add an assertion that only two-dimensional constant references are used

I'd like to see the clean-ups mentioned in patch 3, that would mean you need to remove this assert. I guess you could leave this patch and do the clean-up as a follow-up so that you can more easily debug/bisect if something has gone wrong, up to you. Either way series: Reviewed-by: Timothy

Re: [Mesa-dev] [PATCH v2 03/12] tgsi/build: always generate two-dimensional constant file accesses

On 28/08/17 18:58, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_build.c | 11 + src/gallium/auxiliary/tgsi/tgsi_transform.h | 65 +++-- 2 files changed, 45 insertions(+), 31 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 7/7] i965/fs: Fix readInvocationARB and readFirstInvocationARB

On Mon, Aug 28, 2017 at 2:50 PM, Matt Turner wrote: > On Mon, Aug 28, 2017 at 7:51 AM, Jason Ekstrand > wrote: > > The readInvocationARB built-in maps fairly nicely to our BROADCAST > > opcode. However, the current implementation isn't quite right.

Re: [Mesa-dev] [PATCH] nir/opcodes: Fix constant-folding of ufind_msb

Reviewed-by: Bas Nieuwenhuizen On Tue, Aug 29, 2017, at 00:10, Jason Ekstrand wrote: > We didn't fold correctly in the case of 0x1 because we never let the > loop counter hit 0. Switching it to bit >= 0 solves this problem. > > Cc: mesa-sta...@lists.freedesktop.org >

[Mesa-dev] [Bug 95338] build fails with python3 version of mako

https://bugs.freedesktop.org/show_bug.cgi?id=95338 --- Comment #1 from Dylan Baker --- mesa cannot (yet) use python3 for code gen. If the check found python3 instead of python2 that would be a bug, but currently python3 is unusable. We're working on getting python2/3

[Mesa-dev] [PATCH] nir/opcodes: Fix constant-folding of ufind_msb

We didn't fold correctly in the case of 0x1 because we never let the loop counter hit 0. Switching it to bit >= 0 solves this problem. Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/nir/nir_opcodes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 08/19] i965: Explicitly cast between different enums

Fixes warnings like warning: implicit conversion from enumeration type 'enum isl_format' to different enumeration type 'enum GEN10_SURFACE_FORMAT' [-Wenum-conversion] .SourceElementFormat = ISL_FORMAT_R32_UINT, ^~~ ---

[Mesa-dev] [PATCH 14/19] anv: Mark functions used conditionally as UNUSED

The functions we're marking as UNUSED in genX_pipeline.c are used only when compiling for particular generations. --- src/intel/vulkan/anv_allocator.c | 2 +- src/intel/vulkan/gen8_cmd_buffer.c | 4 ++-- src/intel/vulkan/genX_cmd_buffer.c | 2 +- src/intel/vulkan/genX_pipeline.c | 4 ++-- 4

[Mesa-dev] [PATCH 18/19] blorp: Explicitly cast between different enums

Fixes warnings like warning: implicit conversion from enumeration type 'enum isl_format' to different enumeration type 'enum GEN10_SURFACE_FORMAT' [-Wenum-conversion] .SourceElementFormat = ISL_FORMAT_R32_UINT, ^~~ ---

[Mesa-dev] [PATCH 19/19] glsl: define YY_NO_INPUT to prevent unused symbol warnings

Otherwise clang warns: glsl/glsl_lexer.cpp:3507:16: warning: function 'yyinput' is not needed and will not be emitted [-Wunneeded-internal-declaration] static int yyinput (yyscan_t yyscanner) ^ --- src/compiler/glsl/glsl_lexer.ll | 1 + 1 file changed, 1 insertion(+) diff

[Mesa-dev] [PATCH 15/19] intel/isl: Remove 'inline' keywords

Unless you have data, the compiler knows better than you whether a function should be inlined. Unlike all other cases in this series, the removal of the inline keyword from isl_format_has_channel_type actually changes the resulting binary with gcc-6.3.0: textdata bss dec hex

[Mesa-dev] [PATCH 13/19] anv: Explicitly cast between different enums

Fixes warnings like warning: implicit conversion from enumeration type 'enum isl_format' to different enumeration type 'enum GEN10_SURFACE_FORMAT' [-Wenum-conversion] .SourceElementFormat = ISL_FORMAT_R32_UINT, ^~~ ---

[Mesa-dev] [PATCH 11/19] anv: Use GNU C empty brace initializer

Avoids Clang's warning about the current code: warning: suggest braces around initialization of subobject --- src/intel/vulkan/anv_formats.c | 2 +- src/intel/vulkan/anv_pipeline.c | 20 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 12/19] anv: Remove 'inline' keywords

Unless you have data, the compiler knows better than you whether a function should be inlined. No difference in the resulting binary with gcc-6.3.0 or clang-4.0. --- src/intel/vulkan/anv_batch_chain.c | 4 ++-- src/intel/vulkan/anv_blorp.c | 2 +- src/intel/vulkan/gen7_cmd_buffer.c | 2

[Mesa-dev] [PATCH 07/19] i965: Drop unnecessary conditional

Clang doesn't realize that 0 and 1 are the only possibilities, a thinks lots of variables might be uninitialized. --- src/intel/compiler/brw_eu_validate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/compiler/brw_eu_validate.c

[Mesa-dev] [PATCH 16/19] intel/isl: Explicitly cast between different enums

Fixes warnings like warning: implicit conversion from enumeration type 'enum isl_format' to different enumeration type 'enum GEN10_SURFACE_FORMAT' [-Wenum-conversion] .SourceElementFormat = ISL_FORMAT_R32_UINT, ^~~ ---

[Mesa-dev] [PATCH 10/19] i965: Add $(WNO_OVERRIDE_INIT) to AM_CFLAGS

brw_surface_formats.c and genX_blorp_exec.c do this a lot, causing lots of warnings from clang. --- src/mesa/drivers/dri/i965/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index f884a530eb..eccca643c3

[Mesa-dev] [PATCH 17/19] intel/isl: Mark functions used conditionally as UNUSED

The functions we're marking as UNUSED in isl_surface_state.c are used only when compiling for particular generations. --- src/intel/isl/isl_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c

[Mesa-dev] [PATCH 02/19] configure: Test for -Wno-initializer-overrides

Clang has "-Wno-initializer-overrides", while gcc has "-Wno-override-init". Quiets a lot of warnings with clang. --- configure.ac | 4 src/intel/Makefile.am | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 84b0805401..218c03dad5

[Mesa-dev] [PATCH 06/19] i965: Remove some 'inline' keywords

brw_texture_view_sane() is only used by an assert()... No difference in the resulting binary with gcc-6.3.0 or clang-4.0. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH 09/19] i965: Mark functions used conditionally as UNUSED

The functions we're marking as UNUSED in genX_state_upload.c are used only when compiling for particular generations. --- src/mesa/drivers/dri/i965/genX_state_upload.c | 4 ++-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 03/19] compiler: Add $(WNO_OVERRIDE_INIT) to AM_CFLAGS

nir_intrinsics.h does this a lot, causing lots of warnings from clang. --- src/compiler/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/Makefile.am b/src/compiler/Makefile.am index 001ff81aeb..45b9cc5854 100644 --- a/src/compiler/Makefile.am +++

[Mesa-dev] [PATCH 05/19] nir: Remove series of unnecessary conversions

Clang warns: warning: absolute value function 'fabsf' given an argument of type 'const float64_t' (aka 'const double') but has parameter of type 'float' which may cause truncation of value [-Wabsolute-value] float64_t dst = bit_size == 64 ? fabs(src0) : fabsf(src0); The type of the

[Mesa-dev] [PATCH 01/19] configure: Add and use AX_CHECK_COMPILE_FLAG

This makes it a lot clearer what's happening (at least I think so), and will make future additions much simpler. --- configure.ac| 94 - m4/ax_check_compile_flag.m4 | 74 +++ 2 files changed, 99

[Mesa-dev] [PATCH 04/19] nir/spirv: Use unreachable("...") rather than assert(!"...")

Quiets a number of uninitialized variable warnings in clang. Reviewed-by: Jordan Justen --- src/compiler/spirv/spirv_to_nir.c | 18 +- src/compiler/spirv/vtn_variables.c | 8 2 files changed, 13 insertions(+), 13 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 7/7] i965/fs: Fix readInvocationARB and readFirstInvocationARB

On Mon, Aug 28, 2017 at 7:51 AM, Jason Ekstrand wrote: > The readInvocationARB built-in maps fairly nicely to our BROADCAST > opcode. However, the current implementation isn't quite right. This > commit fixes three different issues: > > 1) It was blindly taking component

Re: [Mesa-dev] [PATCH] st/mesa: fix XPD lowering - don't read dst

Reviewed-by: Brian Paul On 08/28/2017 03:30 PM, Marek Olšák wrote: From: Marek Olšák Bugzilla:

[Mesa-dev] [PATCH] st/mesa: fix XPD lowering - don't read dst

From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102461 --- src/mesa/state_tracker/st_mesa_to_tgsi.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c

[Mesa-dev] [PATCH 2/3] ac/debug: Support multiple trace ids for nested IBs.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_debug.c | 54 ++- src/amd/common/ac_debug.h | 8 ++-- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 4 +- src/gallium/drivers/radeonsi/si_debug.c |

[Mesa-dev] [PATCH 1/3] radv/amdgpu: Enable dumping of all IBs with RADV_DEBUG=allbos.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c index ad4b0b3f9dc..adb855f97de

[Mesa-dev] [PATCH 3/3] radv: Add trace ids for secondary buffers.

Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_cmd_buffer.c | 2 ++ src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_radeon_winsys.h | 2 +- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 4 ++-- 4 files changed, 6

Re: [Mesa-dev] [PATCH v3 01/12] anv/queue: Allow temporary import of SYNC_FD semaphores

This series is : Reviewed-by: Lionel Landwerlin On 25/08/17 19:54, Jason Ekstrand wrote: We didn't allow them before because it didn't look like the spec allowed it. It certainly doesn't make much sense. However, there are CTS tests that apparently hit this.

[Mesa-dev] [Bug 102463] SpaceEngine can't render main scenery properly

https://bugs.freedesktop.org/show_bug.cgi?id=102463 Bug ID: 102463 Summary: SpaceEngine can't render main scenery properly Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH v2 6/7] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

On Mon, Aug 28, 2017 at 11:13 AM, Jason Ekstrand wrote: > --- > src/intel/compiler/brw_fs_nir.cpp | 33 + > 1 file changed, 21 insertions(+), 12 deletions(-) > > diff --git a/src/intel/compiler/brw_fs_nir.cpp >

Re: [Mesa-dev] [PATCH 2/2] radeonsi: rewrite late alloc VS limit computation

On 28.08.2017 21:43, Marek Olšák wrote: On Mon, Aug 28, 2017 at 12:50 PM, Nicolai Hähnle wrote: On 25.08.2017 02:57, Marek Olšák wrote: From: Marek Olšák This is still very simple, but it's better than before. Loosely ported from Vulkan. ---

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/query: init result data with 0

You can also call util_query_clear_result in the driver. Marek On Sat, Aug 26, 2017 at 1:15 AM, Karol Herbst wrote: > otherwise the result might contain random data. > > fixes on nvc0: > * KHR-GL45.pipeline_statistics_query_tests_ARB.functional_default_qo_values > * >

[Mesa-dev] [Bug 101709] [llvmpipe] piglit gl-1.0-scissor-offscreen regression

https://bugs.freedesktop.org/show_bug.cgi?id=101709 --- Comment #3 from Brian Paul --- OK, I must have had something wrong. I see the issue. Patch posted to mesa-dev for review. -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [PATCH] llvmpipe: initialize llvmpipe->dirty with LP_NEW_SCISSOR

If llvmpipe_set_scissor_states() is never called, we still need to be sure that derived scissor/clip state is updated. As of commit 743ad599a97d09b1 that function might not be called. Fixes regressed Piglit gl-1.0-scissor-offscreen -fbo -auto test. Bugzilla:

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

Please makes this a non-shader cap if the value doesn't vary between shaders. Marek On Sun, Aug 27, 2017 at 12:59 PM, Karol Herbst wrote: > this way Nouveau can report 128 inputs, but only 124 varyings. > > Fixes: 'KHR-GL45.limits.max_fragment_input_components' >

[Mesa-dev] [Bug 102461] [llvmpipe] piglit glean fragprog1 XPD test 1 regression

https://bugs.freedesktop.org/show_bug.cgi?id=102461 Bug ID: 102461 Summary: [llvmpipe] piglit glean fragprog1 XPD test 1 regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 2/2] radeonsi: rewrite late alloc VS limit computation

On Mon, Aug 28, 2017 at 12:50 PM, Nicolai Hähnle wrote: > On 25.08.2017 02:57, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This is still very simple, but it's better than before. >> >> Loosely ported from Vulkan. >> --- >>

[Mesa-dev] [Bug 95338] build fails with python3 version of mako

https://bugs.freedesktop.org/show_bug.cgi?id=95338 Bug ID: 95338 Summary: build fails with python3 version of mako Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

[Mesa-dev] [Bug 101709] [llvmpipe] piglit gl-1.0-scissor-offscreen regression

https://bugs.freedesktop.org/show_bug.cgi?id=101709 --- Comment #2 from Vinson Lee --- (In reply to Brian Paul from comment #1) > Vinson, this test seems to pass for me with current Mesa (fe2f5cfdc7). Can > you re-test and close this if it's OK for you? Retested with Mesa

[Mesa-dev] [PATCH v2 6/7] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

--- src/intel/compiler/brw_fs_nir.cpp | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index c46998a..04deaed 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++

Re: [Mesa-dev] [PATCH 6/7] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

Hi Jason, given that 16bit types are already on the horizon a switch(nir_src_bit_size(src)) seems more future-proof --Michael Am 28.08.2017 um 16:51 schrieb Jason Ekstrand: --- src/intel/compiler/brw_fs_nir.cpp | 38 ++ 1 file changed, 26

[Mesa-dev] [Bug 102454] glibc 2.26 doesn't provide anymore xlocale.h

https://bugs.freedesktop.org/show_bug.cgi?id=102454 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net

Re: [Mesa-dev] Question about implementing viewport transfer and const load in nir

Kenneth Graunke writes: > [ Unknown signature status ] > On Saturday, August 26, 2017 6:40:14 AM PDT Qiang Yu wrote: >> Hi guys, >> >> When working on lima gp compiler, I come across two problems about >> inserting extra uniform >> and instructions in nir for the driver

Re: [Mesa-dev] [RFC PATCH 2/2] main/format: skip format conversion if src and dst format are equal

On Wed, Aug 16, 2017 at 11:32 AM, Karol Herbst wrote: > Fixes 'KHR-GL45.copy_image.functional' on Nouveau > > Signed-off-by: Karol Herbst > --- > src/mesa/main/format_utils.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff

[Mesa-dev] [PATCH 7/7] i965/fs: Fix readInvocationARB and readFirstInvocationARB

The readInvocationARB built-in maps fairly nicely to our BROADCAST opcode. However, the current implementation isn't quite right. This commit fixes three different issues: 1) It was blindly taking component 0 of the index value even if that channel is disabled. We need emit_uniformize()

[Mesa-dev] [PATCH 5/7] i965/fs/nir: Minor refactor of store_output

Stop retyping the output of shuffle_64bit_data_for_32bit_write. It's always BRW_REGISTER_TYPE_D which is perfectly fine for writing out. Also, when we change get_nir_src to return something with a 64-bit type for 64-bit values, the retyping will not be at all what we want. Also, retyping the

[Mesa-dev] [PATCH 2/7] i965/fs: Add brw_reg_type_from_bit_size utility method

From: Alejandro Piñeiro Returns the brw_type for a given ssa.bit_size, and a reference type. So if bit_size is 64, and the reference type is BRW_REGISTER_TYPE_F, it returns BRW_REGISTER_TYPE_DF. The same applies if bit_size is 32 and reference type is BRW_REGISTER_TYPE_HF

[Mesa-dev] [PATCH 6/7] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

--- src/intel/compiler/brw_fs_nir.cpp | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index c46998a..a882979 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++

[Mesa-dev] [PATCH 4/7] i965/fs: Return a fs_reg from shuffle_64bit_data_for_32bit_write

All callers of this function allocate a fs_reg expressly to pass into it. It's much easier if we just let the helper allocate the register. While we're here, we switch it to doing the MOVs with an integer type so that we don't accidentally canonicalize floats on half of a double. ---

[Mesa-dev] [PATCH 3/7] i965/fs/nir: Simplify 64-bit store_output

The swizzles weren't doing any good because swiz is just XYZW. Also, we were emitting an extra set of MOVs because shuffle_64bit_data_for_32bit already does a MOV for us. Finally, the temporary was only ever used inside the inner loop so there's no need for it to actually be an array. ---

[Mesa-dev] [PATCH 0/7] i965/fs/nir: Fix readInvocationARB and readFirstInvocationARB

This little series contains some fixes I found when working on SPIR-V subgroup operations. From my reading of GL_ARB_shader_ballot, the readInvocationARB and readFirstInvocationARB intrinsics only support 32-bit values. This seems weird to me, but whatever. The SPIR-V subgroup extensions, on

[Mesa-dev] [PATCH 1/7] i965/fs/nir: Use the nir_src_bit_size helper

--- src/intel/compiler/brw_fs_nir.cpp | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index d760946..18c5fc6 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++

Re: [Mesa-dev] [PATCH 3/5] i965/screen: Make a parameter const

On 16 August 2017 at 20:30, Jason Ekstrand wrote: > This gets rid of some compiler warnings. Reviewed-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/5] gbm: Add a gbm_device_get_format_modifier_plane_count function

On 16 August 2017 at 20:30, Jason Ekstrand wrote: > +/** Get the number of planes that are required for a given format+modifier > + * > + * \param gbm The gbm device returned from gbm_create_device() > + * \param format The format to query > + * \param modifier The modifier

Re: [Mesa-dev] [PATCH 1/5] dri/image: Add a format modifier attributes query

On 16 August 2017 at 20:30, Jason Ekstrand wrote: > + /** > +* dmabuf format modifier attribute query for a given format and modifier. > +* > +* \param fourccThe format to query. If this format is not supported > by > +* the driver,

Re: [Mesa-dev] [PATCH] i965: Set "Subslice Hashing Mode" to 16x16 on Apollolake.

Kenneth, would we want this patch in 17.1 or we shouldn't bother ? On Tue, 2017-05-30 at 16:28 -0700, Kenneth Graunke wrote: > As of 4.11, the kernel isn't bothering to set the subslice hashing mode > on Apollolake, leaving it at the default of 8x8. (It initializes it to > 16x4 on most

Re: [Mesa-dev] [PATCH] nir/spirv: add support for chain access with different index bit sizes

On August 28, 2017 1:18:33 AM Samuel Iglesias Gonsálvez wrote: Fixes dEQP-VK.spirv_assembly.instruction.*.indexing.* Signed-off-by: Samuel Iglesias Gonsálvez --- src/compiler/spirv/vtn_variables.c | 31 +-- 1 file

[Mesa-dev] [Bug 102454] glibc 2.26 doesn't provide anymore xlocale.h

https://bugs.freedesktop.org/show_bug.cgi?id=102454 Andreas Radke changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 00/10] egl: mixed bag of fixes/cleanups

Hi Emil, On 27 August 2017 at 11:20, Emil Velikov wrote: > egl: simplify refcounting after screen creation Acked-by: Daniel Stone > egl/wayland: plug leaks in dri2_wl_create_window_surface() error path > egl/wayland: polish object

[Mesa-dev] [Bug 102454] glibc 2.26 doesn't provide anymore xlocale.h

https://bugs.freedesktop.org/show_bug.cgi?id=102454 Bug ID: 102454 Summary: glibc 2.26 doesn't provide anymore xlocale.h Product: Mesa Version: unspecified Hardware: All OS: Linux (All) Status: NEW

[Mesa-dev] [ANNOUNCE] mesa 17.1.8

Mesa 17.1.8 is now available. In this release we have: In Mesa Core we include a fix to prevent a crash in glCompressedTextureSubImage3D. The GLSL compiler now includes a fix to add some int64 constant propagation cases. Intel drivers have received several patches. Among those, i965 has gotten

Re: [Mesa-dev] [PATCH] gallium: add PIPE_SHADER_CAP_MAX_VARYINGS

On Mon, Aug 28, 2017 at 4:23 AM, Nicolai Hähnle wrote: > On 27.08.2017 12:59, Karol Herbst wrote: >> >> this way Nouveau can report 128 inputs, but only 124 varyings. >> >> Fixes: 'KHR-GL45.limits.max_fragment_input_components' > > > Can you explain a bit more why this is

[Mesa-dev] [Bug 102318] Mesa3D Scons build - LLVM 5.0 not supported

https://bugs.freedesktop.org/show_bug.cgi?id=102318 Alex Granni changed: What|Removed |Added Attachment #133638|Mesa3D scons build with |Mesa3D scons build

Re: [Mesa-dev] [PATCH 12/47] i965/fs: Add brw_reg_type_from_bit_size utility method

El 26/08/17 a las 19:19, Jason Ekstrand escribió: > On Thu, Aug 24, 2017 at 6:54 AM, Alejandro Piñeiro > > wrote: > > Returns the brw_type for a given ssa.bit_size, and a reference type. > So if bit_size is 64, and the reference type is

Re: [Mesa-dev] [PATCH 1/3] st/omx: move YUV deinterlace function to common

On 08/28/2017 05:01 AM, Emil Velikov wrote: On 28 August 2017 at 03:43, Leo Liu wrote: On 08/27/2017 01:49 PM, Emil Velikov wrote: Hi Leo, On 24 August 2017 at 16:11, Leo Liu wrote: Signed-off-by: Leo Liu ---

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

On 08/28/2017 04:53 AM, Emil Velikov wrote: On 28 August 2017 at 03:33, Leo Liu wrote: On 08/27/2017 01:52 PM, Emil Velikov wrote: On 25 August 2017 at 18:17, Leo Liu wrote: Signed-off-by: Leo Liu ---

Re: [Mesa-dev] [PATCH 2/2] radeon/uvd: add Define Restart Interval to MJPEG bitstream reconstruction

On 08/28/2017 05:04 AM, Emil Velikov wrote: On 28 August 2017 at 04:45, Leo Liu wrote: On 08/27/2017 01:53 PM, Emil Velikov wrote: On 25 August 2017 at 18:17, Leo Liu wrote: Signed-off-by: Leo Liu Same here - please add a couple words

Re: [Mesa-dev] [PATCH 2/2] radeonsi: rewrite late alloc VS limit computation

On 25.08.2017 02:57, Marek Olšák wrote: From: Marek Olšák This is still very simple, but it's better than before. Loosely ported from Vulkan. --- src/gallium/drivers/radeonsi/si_state.c | 38 ++--- 1 file changed, 26 insertions(+), 12

Re: [Mesa-dev] [PATCH] configure.ac: Check for expat when building just vulkan

On 28 August 2017 at 11:47, Emil Velikov wrote: > Hi Jussi, > > On 28 August 2017 at 08:07, Jussi Kukkonen > wrote: > > Intel vulkan drivers also need expat: make sure EXPAT_LIBS is set even > > if dri is disabled. > > We've got a similar

Re: [Mesa-dev] [PATCH 2/2] gallium/u_threaded: rename IGNORE_VALID_RANGE -> NO_INFER_UNSYNCHRONIZED

Both patches: Reviewed-by: Nicolai Hähnle On 25.08.2017 15:41, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/util/u_threaded_context.c | 4 ++-- src/gallium/auxiliary/util/u_threaded_context.h | 4 ++--

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: set EVENT_WRITE_EOP.INT_SEL = wait for write confirmation

On 25.08.2017 02:57, Marek Olšák wrote: From: Marek Olšák Ported from Vulkan. Not sure what this is good for.. maybe write confirmation from L2 flushes? I think so, yes. Reviewed-by: Nicolai Hähnle --- src/amd/common/r600d_common.h

Re: [Mesa-dev] [PATCH v6.2] egl: Allow creation of per surface out fence

This still doesn't seem to be merged. Can someone please look at it? It does have Rbs. Regards, Yogesh. > -Original Message- > From: Marathe, Yogesh > Sent: Wednesday, August 23, 2017 11:35 PM > To: mesa-dev@lists.freedesktop.org > Cc: tf...@chromium.org; emil.l.veli...@gmail.com; Gao,

Re: [Mesa-dev] [PATCH 41/47] i965/fs: Add reuse_16bit_conversions_register optimization

On 27/08/17 20:24, Connor Abbott wrote: > Hi, > > On Aug 25, 2017 9:28 AM, "Alejandro Piñeiro" > wrote: > > On 24/08/17 21:07, Connor Abbott wrote: > > > > Hi Alejandro, > > Hi Connor, > > > > > This seems really

Re: [Mesa-dev] [PATCH 20/47] i965/fs: Define new shader opcodes to set rounding modes

On 25/08/17 20:09, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> Although it is possible to emit them directly as AND/OR on brw_fs_nir, >> having specific opcodes makes it easier to remove duplicate settings >> later. >> >> Signed-off-by: Alejandro Piñeiro

[Mesa-dev] [PATCH] radv: silent a compiler warning in radv_emit_framebuffer_state()

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index fcc14dd936..b567bee329 100644 ---

Re: [Mesa-dev] [PATCH] gallium/docs: Fix an inequality sign of TGSI_SEMANTIC_SUBGROUP_LT_MASK

On 23.08.2017 18:54, Gwan-gyeong Mun wrote: A previous expression presents same as TGSI_SEMANTIC_SUBGROUP_GT_MASK. It fixes a direction of an inequality for TGSI_SEMANTIC_SUBGROUP_LT_MASK. before: bit index > TGSI_SEMANTIC_SUBGROUP_INVOCATION after: bit index <

  1   2   >