https://bugs.freedesktop.org/show_bug.cgi?id=102530
--- Comment #7 from Erik Faye-Lund ---
Timothy Arceri: In either case, it looks like the handling of location = -1 is
incorrect in the no-error case. I think we should ignore the command in this
case...
--
You are
On 04/09/2017 14:27, Thomas Hellstrom wrote:
The copySubBuffer functionality always attempted a server side blit from
back to fake front if a fake front was present, and we weren't displaying
on a remote GPU.
Now that we always have local blit capability on modern drivers, first
attempt a local
Successfully tested under Weston 3.0, both with the new
(experimental) dmabuf+modifiers path, and the old buffer
import path. Photometer confirms 10 rgb bits from rendering
to display.
Signed-off-by: Mario Kleiner
---
src/egl/drivers/dri2/egl_dri2.c | 3 ++
Allows to prevent exposing RGB10 configs and visuals to
clients.
Signed-off-by: Mario Kleiner
---
src/mesa/drivers/dri/i965/intel_screen.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
Set 'expose_rgb10_configs' false when gnome-shell is the
client.
Gnome-Shell/Wayland (= Mutter drm/kms wayland backend)
currently can't handle non RGB8 configs. It will treat
any framebuffer as RGBX8 or RGBA8, so if provided with
a RGB10A2 or RGB10X2 framebuffer, the compositors
kms backend will
Similar to the matching of 24 bit RGB visuals to 32-bit
RGBA EGLConfigs.
Fixes failure of piglit egl tests to select ARGB2101010
visuals via eglChooseConfig() with EGL_ALPHA_BITS 2 on
a depth 30 X-Screen.
Signed-off-by: Mario Kleiner
---
A few clients don't like RGB10X2 and RGB10A2 fbconfigs and
visuals. Add a new driconf option 'expose_rgb10_configs' to
allow per application enable/disable.
The option defaults to enabled.
Signed-off-by: Mario Kleiner
---
src/mesa/drivers/dri/common/dri_util.c | 11
Hi,
this patch series adds support to the i965 classic Mesa driver for
ARGB2101010 and XRGB2101010 fbconfigs/visuals for X11/GLX, X11/EGL
and Wayland/EGL, and for rendering into those winsys framebuffers
with 10 bpc precision.
Tested hw/sw configs on top of Ubuntu 16.04.3 LTS, on top of mesa
Allow DRI3/Present buffer sharing for 10 bpc buffers.
Otherwise composited desktops under DRI3 will only display
black client areas for redirected windows.
Signed-off-by: Mario Kleiner
---
src/mesa/drivers/dri/i965/intel_screen.c | 6 ++
1 file changed, 6
Expose formats which are supported at least back to Gen 5 Ironlake,
possibly further. Allow creation of 10 bpc winsys buffers for drawables.
glxinfo now lists new RGBA 10 10 10 2/0 formats.
Works correctly under DRI2 without compositing.
Signed-off-by: Mario Kleiner
This works well as tested under Compiz, KDE-5, Gnome-Shell.
Signed-off-by: Mario Kleiner
---
src/mesa/drivers/dri/i965/intel_blit.c | 8
src/mesa/drivers/dri/i965/intel_tex_image.c | 12 ++--
2 files changed, 18 insertions(+), 2 deletions(-)
To allow DRI3/Present buffer sharing for 10 bpc buffers.
Signed-off-by: Mario Kleiner
---
src/loader/loader_dri3_helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c
index e3120f5..e3d819f
Used to support ARGB2101010 and XRGB2101010
winsys framebuffers / drawables, but added
other 10 bpc fourcc's as well for consistency
with definitions in wayland_drm.h, gbm.h, and
drm_fourcc.h.
Signed-off-by: Mario Kleiner
---
include/GL/internal/dri_interface.h | 8
On 04/09/17 09:27 PM, Thomas Hellstrom wrote:
> Anyone using copySubBuffer as a replacement for swapBuffers would probably
> want window resizing to update the viewport.
>
> Signed-off-by: Thomas Hellstrom
> ---
> src/loader/loader_dri3_helper.c | 2 ++
> 1 file changed,
On 04/09/17 09:27 PM, Thomas Hellstrom wrote:
> The copySubBuffer functionality always attempted a server side blit from
> back to fake front if a fake front was present, and we weren't displaying
> on a remote GPU.
>
> Now that we always have local blit capability on modern drivers, first
>
https://bugs.freedesktop.org/show_bug.cgi?id=102522
Michel Dänzer changed:
What|Removed |Added
QA Contact|dri-devel@lists.freedesktop
https://bugs.freedesktop.org/show_bug.cgi?id=102530
--- Comment #6 from Timothy Arceri ---
(In reply to Alexandre Demers from comment #5)
> Created attachment 133967 [details]
> Kodi's log after segfault
>
> This is the core dump produced by Kodi when segfaulting.
>
From: Roland Scheidegger
We're not particularly concerned with memory usage, if the tradeoff is
shader recompiles. And it's common for apps to have a lot of shaders
nowadays (and, since our shaders include a LOT of context state of course
we may create quite a bit more
gfx9d.h contains almost no named values. Does it obtain named values
from sid.h when the same field is also present in gfx9d.h?
Marek
On Mon, Sep 4, 2017 at 2:11 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> There were some overlapping
On Mon, Sep 4, 2017 at 3:56 PM, Nicolai Hähnle wrote:
> On 04.09.2017 15:38, Aaron Watry wrote:
>>
>> On Sun, Sep 3, 2017 at 3:20 PM, David Niklas wrote:
>>>
>>> Hello,
>>> I'm interested in knowing why there are two different OpenCL
>>> implementations of
https://bugs.freedesktop.org/show_bug.cgi?id=102530
--- Comment #5 from Alexandre Demers ---
Created attachment 133967
--> https://bugs.freedesktop.org/attachment.cgi?id=133967=edit
Kodi's log after segfault
This is the core dump produced by Kodi when
Reviewed-by: Marek Olšák
Marek
On Mon, Sep 4, 2017 at 2:16 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> This fixes GL45-CTS.shader_image_load_store.basic-glsl-earlyFragTests.
>
> Cc: mesa-sta...@lists.freedesktop.org
>
Would it be possible to use this workaround only when LS vertices > HS
vertices? (which should be rare)
Marek
On Mon, Sep 4, 2017 at 8:11 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> When the HS wave is empty, the hardware writes the LS
Jan Vesely writes:
> v2: wait in map_buffer and map_image as well
> v3: use event::wait instead of wait (skips fence wait for hard_event)
> v4: use wait_signalled()
>
> Signed-off-by: Jan Vesely
> ---
> Hi Francisco,
>
> once again sorry for the
From: Marek Olšák
Building gallium is faster by 7.5 seconds on a 4core/8thread 3GHz CPU.
(gallium build time is reduced by 15% when building only radeonsi)
Non-recursive makefiles are great!
---
src/gallium/Makefile.am| 12
Jan Vesely writes:
> Signed-off-by: Jan Vesely
With the spelling fixed up (s/has_halfs/has_halves/) patch is:
Reviewed-by: Francisco Jerez
> ---
>
> src/gallium/state_trackers/clover/api/device.cpp | 14 +++---
From: Nicolai Hähnle
When the HS wave is empty, the hardware writes the LS VGPRs starting at
v0 instead of v2. Workaround by shifting them back into place when
necessary. For simplicity, this is always done in the LS prolog.
According to the hardware team, this will be
I actually made a mistake while porting the code. All UINT_MAX
occurences should stay, and UINT_MAX should be the terminator, so I'm
adding this:
diff --git a/src/gallium/drivers/radeonsi/si_state_binning.c
b/src/gallium/drivers/radeonsi/si_state_binning.c
index 56bcdc8..d75e86e 100644
---
On Mon, Sep 4, 2017 at 3:56 PM, Nicolai Hähnle wrote:
> On 01.09.2017 02:57, Marek Olšák wrote:
>>
>> From: Marek Olšák
>>
>> This increases performance, but it was tuned for Raven, not Vega.
>> We don't know yet how Vega will perform, hopefully not
https://bugs.freedesktop.org/show_bug.cgi?id=101340
Emil Velikov changed:
What|Removed |Added
Status|NEW |RESOLVED
On 09/04/2017 07:13 PM, Jason Ekstrand wrote:
A quick scan through and this looks pretty gross. There may be no
better way to do it but I'm not sure with only a cursory glance. Is
like this to wait on either me or Ken spending enough brain cells in it
to do a proper review.
Sure, no
Hi;
On 09/04/2017 06:42 PM, Emil Velikov wrote:
Hi Tapani,
On 4 September 2017 at 14:11, Tapani Pälli wrote:
Patch exposes sRGB visuals and adds DRI integer query support for
__DRI2_RENDERER_HAS_FRAMEBUFFER_SRGB. Further changes make sure that
we mark if the app
https://bugs.freedesktop.org/show_bug.cgi?id=102463
Hi-Angel changed:
What|Removed |Added
CC||hi-an...@yandex.ru
--
https://bugs.freedesktop.org/show_bug.cgi?id=102518
Marc Di Luzio changed:
What|Removed |Added
CC|
https://bugs.freedesktop.org/show_bug.cgi?id=102518
--- Comment #8 from Marc Di Luzio ---
Cheers Kai.
That line is being removed from the default branch as we speak, while we sort
out the actual error on our side. Apologies for any wasted time.
--
You are
Yeah, just haven't gotten around to pushing it. Feel free.
On September 4, 2017 7:33:38 AM Andres Gomez wrote:
Jason, has this patch fallen through the cracks ?
On Mon, 2017-08-21 at 22:11 -0700, Jason Ekstrand wrote:
I have no idea how this got missed but it's been
A quick scan through and this looks pretty gross. There may be no better
way to do it but I'm not sure with only a cursory glance. Is like this to
wait on either me or Ken spending enough brain cells in it to do a proper
review.
On September 4, 2017 6:12:20 AM Tapani Pälli
Hi Tapani,
On 4 September 2017 at 14:11, Tapani Pälli wrote:
> Patch exposes sRGB visuals and adds DRI integer query support for
> __DRI2_RENDERER_HAS_FRAMEBUFFER_SRGB. Further changes make sure that
> we mark if the app explicitly wanted sRGB and for these framebuffers
>
On Mon, Sep 4, 2017 at 4:13 PM, Jan Vesely wrote:
> On Sat, 2017-09-02 at 22:21 +0200, Erik Faye-Lund wrote:
>> On Sat, Sep 2, 2017 at 2:55 AM, Jan Vesely wrote:
>> > Denotes native half precision float operations capability
>> >
>> >
On Mon, 2017-09-04 at 15:56 +0200, Nicolai Hähnle wrote:
> On 02.09.2017 02:55, Jan Vesely wrote:
> > Denotes native half precision float operations capability
> >
> > Signed-off-by: Jan Vesely
> > ---
> > I can change the spelling to HALVES, but simplified english
Jason, has this patch fallen through the cracks ?
On Mon, 2017-08-21 at 22:11 -0700, Jason Ekstrand wrote:
> I have no idea how this got missed but it's been missing since forever.
>
> Cc: mesa-sta...@lists.freedesktop.org
> ---
> src/compiler/spirv/vtn_variables.c | 5 -
> 1 file changed,
On Monday, 2017-09-04 14:06:30 +0200, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Found by inspection.
>
> I'm not aware of any actual failures caused by this, but a precise
> sequence of ralloc_adopt and ralloc_free should be able to cause
> problems.
> ---
>
On Sat, 2017-09-02 at 22:21 +0200, Erik Faye-Lund wrote:
> On Sat, Sep 2, 2017 at 2:55 AM, Jan Vesely wrote:
> > Denotes native half precision float operations capability
> >
> > Signed-off-by: Jan Vesely
> > ---
> > I can change the spelling to
On 02.09.2017 02:55, Jan Vesely wrote:
Denotes native half precision float operations capability
Signed-off-by: Jan Vesely
---
I can change the spelling to HALVES, but simplified english sounded more
appropriate.
src/gallium/docs/source/screen.rst | 1 +
On 04.09.2017 15:38, Aaron Watry wrote:
On Sun, Sep 3, 2017 at 3:20 PM, David Niklas wrote:
Hello,
I'm interested in knowing why there are two different OpenCL
implementations of OpenCL drivers for AMD cards.
Is it because they support different ASICs?
One is older and going to
On 01.09.2017 02:57, Marek Olšák wrote:
From: Marek Olšák
This increases performance, but it was tuned for Raven, not Vega.
We don't know yet how Vega will perform, hopefully not worse.
---
src/gallium/drivers/radeon/r600_pipe_common.c | 2 +
Thanks Eero!
On Tue, 2017-08-29 at 12:26 +0300, Eero Tamminen wrote:
> Hi,
>
> On 28.08.2017 17:33, Andres Gomez wrote:
> > Kenneth, would we want this patch in 17.1 or we shouldn't bother ?
>
> See this for more extensive info on its impact:
>
On Sun, Sep 3, 2017 at 3:20 PM, David Niklas wrote:
> Hello,
> I'm interested in knowing why there are two different OpenCL
> implementations of OpenCL drivers for AMD cards.
> Is it because they support different ASICs?
> One is older and going to be replaced?
As near as I can
Patch exposes sRGB visuals and adds DRI integer query support for
__DRI2_RENDERER_HAS_FRAMEBUFFER_SRGB. Further changes make sure that
we mark if the app explicitly wanted sRGB and for these framebuffers
we don't turn sRGB off in intel_gles3_srgb_workaround. This way we
keep compatibility for
Hi,
On 02.09.2017 11:17, Chad Versace wrote:
I'm bringing up Vulkan in the Android container of Chrome OS (ARC++).
On Android, stdio goes to /dev/null. On Android, remote gdb is even more
painful than the usual remote gdb. On Android, nothing works like you
expect and debugging is hell. I need
Anyone using copySubBuffer as a replacement for swapBuffers would probably
want window resizing to update the viewport.
Signed-off-by: Thomas Hellstrom
---
src/loader/loader_dri3_helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
The copySubBuffer functionality always attempted a server side blit from
back to fake front if a fake front was present, and we weren't displaying
on a remote GPU.
Now that we always have local blit capability on modern drivers, first
attempt a local blit, and only if that fails, try the server
On 30.08.2017 16:44, Rob Clark wrote:
On Wed, Aug 30, 2017 at 10:18 AM, Qiang Yu wrote:
On Wed, Aug 30, 2017 at 9:03 PM, Rob Clark wrote:
On Wed, Aug 30, 2017 at 3:26 AM, Qiang Yu wrote:
btw, does lima have some way to write to
Both patches:
Reviewed-by: Nicolai Hähnle
On 30.08.2017 00:26, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state.c | 4
src/gallium/drivers/radeonsi/si_state.h | 1 +
Hallo David,
the following Reddit link might be interesting for you:
https://www.reddit.com/r/Amd/comments/5jqk54/what_is_the_status_of_opencl_in_amdgpumesa/
As far as I understand it, it basically says that ROCm is going to be the
future regarding OpenCL.
On 3 September 2017 at 22:20, David
On 4 September 2017 at 06:12, Tapani Pälli wrote:
> incompatible pointer to integer conversion assigning to 'GLintptr' (aka 'int')
> from 'const char *' [-Werror,-Wint-conversion]
>
> offset = indices;
> ^ ~~~
>
> Signed-off-by: Tapani Pälli
From: Nicolai Hähnle
This fixes GL45-CTS.shader_image_load_store.basic-glsl-earlyFragTests.
Cc: mesa-sta...@lists.freedesktop.org
--
FWIW, Vulkan also always flushes DB metadata on gfx9. Wait-for-idle
is not required here.
---
src/gallium/drivers/radeonsi/si_pipe.h
From: Nicolai Hähnle
There were some overlapping changes in gfx9 especially in the CB/DB
blocks which made register dumps rather misleading.
The split is along the lines of the header files, so we'll print VI-only
fields on SI and CI, for example, but we won't print
From: Nicolai Hähnle
---
src/amd/common/sid_tables.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/amd/common/sid_tables.py b/src/amd/common/sid_tables.py
index 0a2b7ef1fe4..01970caa7be 100644
--- a/src/amd/common/sid_tables.py
+++
From: Nicolai Hähnle
---
src/amd/common/ac_debug.c | 86 -
src/amd/common/ac_debug.h | 4 +-
src/gallium/drivers/radeonsi/si_debug.c | 45 +++--
3 files changed, 75 insertions(+), 60 deletions(-)
From: Nicolai Hähnle
Automatically re-use table entries like StringTable and IntTable do.
This allows us to get rid of the "fields_owner" logic, and simplifies
the next change.
---
src/amd/common/sid_tables.py | 115 ---
1 file
From: Nicolai Hähnle
Found by inspection.
I'm not aware of any actual failures caused by this, but a precise
sequence of ralloc_adopt and ralloc_free should be able to cause
problems.
---
src/util/ralloc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
On Mon, Sep 4, 2017 at 1:29 PM, Marek Olšák wrote:
> On Sun, Sep 3, 2017 at 1:18 PM, Dave Airlie wrote:
>> From: Dave Airlie
>>
>> reduces size from 1144 to 1128.
>>
>> Signed-off-by: Dave Airlie
>> ---
>>
On Sun, Sep 3, 2017 at 1:18 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> reduces size from 1144 to 1128.
>
> Signed-off-by: Dave Airlie
> ---
> src/mesa/main/mtypes.h | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Hi,
On 03.09.2017 14:22, Thomas Helland wrote:
2017-09-03 13:18 GMT+02:00 Dave Airlie :
From: Dave Airlie
reduces size from 1144 to 1128.
Signed-off-by: Dave Airlie
---
src/mesa/main/mtypes.h | 10 +-
1 file changed, 5
For the series:
Reviewed-by: Marek Olšák
Marek
On Sun, Sep 3, 2017 at 1:06 PM, Dave Airlie wrote:
> From: Dave Airlie
>
> This reduces each of these by 8 bytes.
>
> Signed-off-by: Dave Airlie
> ---
>
https://bugs.freedesktop.org/show_bug.cgi?id=102518
--- Comment #7 from Kai ---
I can confirm, that commenting out the export of MESA_NO_ERROR=1 in
XCOM2WotC/config/extra-environment.sh lets me launch the game. This was tested
on (fully updated Debian testing as a
Reviewed-by: Marek Olšák
Marek
On Mon, Sep 4, 2017 at 5:29 AM, Timothy Arceri wrote:
> This code incorrectly assumed that loop terminators will always be
> at the start of the loop. Fortunately we *seem* to avoid any bugs
> because the unrolling code
https://bugs.freedesktop.org/show_bug.cgi?id=77449
Bug 77449 depends on bug 102518, which changed state.
Bug 102518 Summary: [apitrace,backtrace] Crash in _mesa_is_bufferobj during
load of "XCOM 2: War of the Chosen"
https://bugs.freedesktop.org/show_bug.cgi?id=102518
What
https://bugs.freedesktop.org/show_bug.cgi?id=102518
Timothy Arceri changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugs.freedesktop.org/show_bug.cgi?id=102530
Timothy Arceri changed:
What|Removed |Added
Status|NEW |NEEDINFO
---
https://bugs.freedesktop.org/show_bug.cgi?id=102454
Eric Engestrom changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.freedesktop.org/show_bug.cgi?id=102518
--- Comment #5 from Marc Di Luzio ---
It appears some errors slipped through.
Example:
[GL_DEBUG] Error message from OpenGL API call with id 1281: GL_INVALID_VALUE
error generated. out of range.
We'll handle
https://bugs.freedesktop.org/show_bug.cgi?id=102518
--- Comment #4 from Marc Di Luzio ---
FWIW to clear up some confusion - our launch scripts turns on KHR_no_error for
WOTC for the extra performance.
See
Reviewed-by: Samuel Pitoiset
On 09/03/2017 01:12 PM, Dave Airlie wrote:
From: Dave Airlie
This reduces the size from 144 bytes to 128 bytes.
Signed-off-by: Dave Airlie
---
src/mesa/main/mtypes.h | 6 +++---
1 file
Reviewed-by: Samuel Pitoiset
On 09/03/2017 01:18 PM, Dave Airlie wrote:
From: Dave Airlie
reduces size from 1144 to 1128.
Signed-off-by: Dave Airlie
---
src/mesa/main/mtypes.h | 10 +-
1 file changed, 5
Reviewed-by: Samuel Pitoiset
On 09/03/2017 01:21 PM, Dave Airlie wrote:
From: Dave Airlie
160->152.
Signed-off-by: Dave Airlie
---
src/mesa/main/mtypes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Reviewed-by: Samuel Pitoiset
On 09/03/2017 01:09 PM, Dave Airlie wrote:
From: Dave Airlie
This reduces this from 200->182 bytes.
Signed-off-by: Dave Airlie
---
src/mesa/main/mtypes.h | 9 +
1 file changed, 5
https://bugs.freedesktop.org/show_bug.cgi?id=102530
--- Comment #3 from Tapani Pälli ---
(In reply to Tapani Pälli from comment #2)
> Just a guess but at least it looks possible for
> "UniformRemapTable[location]" to access garbage, there should be a check for
> location value
Reviewed-by: Charmaine Lee
> On Sep 3, 2017, at 10:13 PM, Tapani Pälli wrote:
>
> incompatible pointer to integer conversion assigning to 'GLintptr' (aka 'int')
> from 'const char *' [-Werror,-Wint-conversion]
>
> offset = indices;
>
On 08/29/2017 01:55 PM, Tapani Pälli wrote:
LGTM, patches 1-5
Reviewed-by: Tapani Pälli
With these changes we can add a nir_spirv_debug_callback that has
instance and shader object in private data so that we can call
VK_EXT_debug_report functionality from
On Monday, 2017-09-04 04:54:36 +, Jason Ekstrand wrote:
> I sent the same patch a few hours later. I don't care which one we land.
> You have a more descriptive commit message.
Alright then, I just pushed mine.
>
> Reviewed-by: Jason Ekstrand
>
> On Sun, Sep 3, 2017
82 matches
Mail list logo