Re: [Mesa-dev] [PATCH] glsl/linker: add check for compute shared memory size

Reviewed-by: Timothy Arceri On 07/10/17 07:17, Nicolai Hähnle wrote: From: Nicolai Hähnle Unlike uniforms, the limit on shared memory size is not called out explicitly in the list of things that cause linker errors, but presumably that's just

Re: [Mesa-dev] [PATCH v2] i965: Disable auxiliary buffers when there are self-dependencies.

On Friday, October 6, 2017 8:09:33 PM PDT Jason Ekstrand wrote: > On October 6, 2017 8:00:04 PM Kenneth Graunke wrote: > > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c > > b/src/mesa/drivers/dri/i965/brw_draw.c > > index c7ed7284501..fcb194dbe86 100644 > > ---

Re: [Mesa-dev] [PATCH v2] i965: Disable auxiliary buffers when there are self-dependencies.

On October 6, 2017 8:00:04 PM Kenneth Graunke wrote: Jason and I investigated several OpenGL CTS failures where the tests bind the same texture for rendering and texturing, at the same time. This has defined results as long as the reads happen before writes, or the

[Mesa-dev] [PATCH v2] i965: Disable auxiliary buffers when there are self-dependencies.

Jason and I investigated several OpenGL CTS failures where the tests bind the same texture for rendering and texturing, at the same time. This has defined results as long as the reads happen before writes, or the regions are non-overlapping. Normally, this just works out. However, CCS can cause

Re: [Mesa-dev] [PATCH 1/2] st/glsl_to_tgsi: ignore GL_TEXTURE_SRGB_DECODE_EXT for samplers used with texelFetch*()

On Friday, October 6, 2017 1:39:50 PM PDT Nicolai Hähnle wrote: > From: Nicolai Hähnle > > See the comment for the relevant spec quote. > > Fixes > dEQP-GLES31.functional.srgb_texture_decode.skip_decode.srgba8.texel_fetch > -- > Note that this is on top of the texture

Re: [Mesa-dev] [PATCH 2/2] st/mesa: don't assign prog->ShadowSamplers

On Friday, October 6, 2017 1:39:51 PM PDT Nicolai Hähnle wrote: > From: Nicolai Hähnle > > It's not used, and the assignment for the TGSI case was incorrect > for sampler arrays. > --- > src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 - >

Re: [Mesa-dev] [PATCH 3/3] st/mesa: whitespace fix

For the series: Reviewed-by: Marek Olšák Marek On Fri, Oct 6, 2017 at 10:19 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/mesa/state_tracker/st_texture.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH 3/3] radeonsi: add support for PIPE_FORMAT_A1R5G5B5_UNORM

Reviewed-by: Marek Olšák Instead of patches 1-2, I prefer Eric's version which also adds X1B5G5R5. You have my Rb for any leftover bits not present in Eric's patch. Marek On Fri, Oct 6, 2017 at 10:41 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle

Re: [Mesa-dev] [PATCH 2/6] gallium: Add support for 5551 with the 1-bit field in the low bit.

Reviewed-by: Marek Olšák Marek On Thu, Aug 17, 2017 at 6:10 PM, Eric Anholt wrote: > This is how VC4 stores 5551 textures, which we need to support for > GL_OES_required_internalformat. > > v2: Extend commit message, fix svga driver build, add BE ordering

Re: [Mesa-dev] [PATCH 1/3] gallium: add PIPE_FORMAT_A1B5G5R5_UNORM format

Nicolai Hähnle writes: > From: Nicolai Hähnle > > This matches the GL_UNSIGNED_SHORT_5_5_5_1 type. Sigh, I've sent a patch for this 3 times already and not been able to get review.

[Mesa-dev] [Bug 87925] SIGSEGV libX11 src/ImUtil.c:733

https://bugs.freedesktop.org/show_bug.cgi?id=87925 Vinson Lee changed: What|Removed |Added Version|unspecified |10.2 --- Comment #3

[Mesa-dev] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

There are few other (duplicate) workarounds which have similar recommendations: WaFlushHangWhenNonPipelineStateAndMarkerStalled WaCSStallBefore3DSamplePattern WaPipeControlBefore3DStateSamplePattern WaPipeControlBefore3DStateSamplePattern has some extra recommendations if driver is using mid

Re: [Mesa-dev] [PATCH 0/6] st/mesa: add locking around lazy texture/sampler updates

Am 07.10.2017 um 01:01 schrieb Nicolai Hähnle: > On 07.10.2017 00:36, Roland Scheidegger wrote: >> I can't help but think that there'd be none of those problems if those >> views were actually used as specced by gallium initially: all sampler >> views (and surfaces) are per context, and they

[Mesa-dev] [Bug 87926] [softpipe] SIGSEGV draw/draw_pt_fetch_shade_pipeline.c:161

https://bugs.freedesktop.org/show_bug.cgi?id=87926 Vinson Lee changed: What|Removed |Added Version|git |10.5 --- Comment #2

Re: [Mesa-dev] [PATCH 0/6] st/mesa: add locking around lazy texture/sampler updates

On 07.10.2017 00:36, Roland Scheidegger wrote: I can't help but think that there'd be none of those problems if those views were actually used as specced by gallium initially: all sampler views (and surfaces) are per context, and they simply cannot be used in another context. That is actually

[Mesa-dev] [Bug 103031] [llvmpipe] piglit fs-discard-exit-2 fails with llvm-6.0

https://bugs.freedesktop.org/show_bug.cgi?id=103031 Roland Scheidegger changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH 0/6] st/mesa: add locking around lazy texture/sampler updates

I can't help but think that there'd be none of those problems if those views were actually used as specced by gallium initially: all sampler views (and surfaces) are per context, and they simply cannot be used in another context. Roland Am 06.10.2017 um 22:38 schrieb Nicolai Hähnle: > Hi all, >

Re: [Mesa-dev] [PATCH 2/2] disk_cache: remove unnecessary NULL-pointer guards

Reviewed-by: Marek Olšák Marek On Fri, Oct 6, 2017 at 10:21 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/util/disk_cache.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] disk_cache: fix a memory leak

Reviewed-by: Marek Olšák Marek On Fri, Oct 6, 2017 at 10:21 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/util/disk_cache.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/util/disk_cache.c

Re: [Mesa-dev] [PATCH] u_threaded_context: fix a memory leak

Reviewed-by: Marek Olšák Marek On Fri, Oct 6, 2017 at 10:20 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The uploaders can own transfers which need to be unmapped. Destroy them > before the final sync (they're not used

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: don't clobber glGetInternalformat* buffer for GL_NUM_SAMPLE_COUNTS

Reviewed-by: Marek Olšák Marek On Fri, Oct 6, 2017 at 10:13 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Applications might pass in a buffer that is sized too large and rely > on the extra space of the buffer not being

[Mesa-dev] [PATCH v4 01/10] egl: add a treatment of tizen platform on egl display (v2)

It adds a _EGL_PLATFORM_TIZEN enum value to _EGLPlatformType for tizen platform. It adds a detecting routine of tizen platform to _eglNativePlatformDetectNativeDisplay() and _eglGetNativePlatform(). - As tizen platform internally distinguishes native displays of tbm, drm/gbm and wayland

[Mesa-dev] [PATCH v4 05/10] egl/tizen: add support of dri2_loader (v3)

It adds support of dri2_loader to egl dri2 tizen backend. - referenced a basic buffer flow and management implementation from android. And it implements a query buffer age extesion for tizen and turn on swap_buffers_with_damage extension. - it add color buffer related member variables to

[Mesa-dev] [PATCH v4 04/10] configure.ac: Add tizen to supported platforms (v2)

It checks tpl-egl/libtbm/libtdm packages and defines HAVE_PLATFORM_TIZEN. This feature is enabled by the config option '--with-platforms=tizen' v2: Fixes from Emil's review: - Add require_libdrm to tizen platform Signed-off-by: Mun Gwan-gyeong --- configure.ac | 10

[Mesa-dev] [PATCH v4 10/10] docs: add a high level info about Tizen / Tizen Porting Layer (TPL) for EGL / Tizen Buffer Manager (TBM) / etc (v2)

It gives a quick overview and references of developing OpenGLES / EGL Driver for Tizen. v2: - Fixes from Eric's review: Change links of Setup build environment for Tizen (Raspberry Pi 3) and Tizen Binary Download Instructions for Raspberry Pi 3 to `tizen-` prefixed pages. - Add Setup

[Mesa-dev] [PATCH v4 09/10] egl/tizen: add support of dri_image_loader (v3)

It adds support of dri_image_loader to egl dri2 tizen backend. - referenced a basic buffer flow and management implementation from android's. It adds dri_image_back/dri_image_back member variables to dri_egl_surface for a management of back/front buffers. v2: - Fixes from Emil's review:

[Mesa-dev] [PATCH v4 00/10] Mesa for Tizen serises

Hi, Patch series split out refactors and "mesa for tizen". Thease series only have mesa for tizen feature. these depend on splited out refactors. https://patchwork.freedesktop.org/patch/181055/ https://patchwork.freedesktop.org/patch/181056/ https://patchwork.freedesktop.org/patch/181060/

[Mesa-dev] [PATCH v4 07/10] egl/tizen: add tizen specific implementation for EGL_WAYLAND_BUFFER_WL target of eglCreateImageKHR() (v2)

In the tizen platform, a wl_buffer wraps a tbm_surface. The tbm_surface contains gem name or prime fd. For creating dri_image, we need to extract the tbm_surface from the wl_buffer and we use tpl_display_get_buffer_from_native_pixmap() api for that. v2: a) Add switch's default case to return

[Mesa-dev] [PATCH v4 06/10] egl/tizen: add tizen specific implementations for BindWaylandDisplayWL/UnbindWaylandDisplayWL/QueryWaylandBufferWL (v2)

Tizen platform (actually WL_TBM protocol) internally processes similiar actions such as mesa's BindWaylandDisplayWL/UnbindWaylandDisplayWL/QueryWaylandBufferWL. So the platform_tizen.c needs to implemment BindWaylandDisplayWL, UnbindWaylandDisplayWL and QueryWaylandBufferWL apart from mesa's. -

[Mesa-dev] [PATCH v4 03/10] egl/tizen: add support of the swrast related features for tizen platform (v2)

It implements the egl swrast related features for tizen platform on platform_tizen.c It works with libtpl-egl (Tizen Porting Layer for egl) and libtbm (Tizen Buffer Manager) where back buffers of windows are backed by GEM objects. In Tizen a native window has a queue (tbm_surface_queue) of

[Mesa-dev] [PATCH v4 08/10] egl/tizen: add EGL_NATIVE_SURFACE_TIZEN target of eglCreateImageKHR()

It adds TIZEN_image_native_surface extension string to _EGLExtensions. And it adds a routine of creating an EGLImage from a tbm_surface. - section overview from https://www.khronos.org/registry/EGL/extensions/TIZEN/EGL_TIZEN_image_native_surface.txt "Tizen Buffer Manager (TBM) is a

[Mesa-dev] [PATCH v4 02/10] egl/dri2: Add some member variables for tizen platform on dri2_egl_display and dri2_egl_surface (v2)

It adds some member variables for tizen platform on dri2_egl_display and dri2_egl_surface. - tpl_display stores a object which encapsulates native disply (wl_display, gbm_device, tbm_bufmgr) for tizen platfom. - native_win stores native window (wl_surface, gbm_surface,

[Mesa-dev] [PATCH v2 7/8] egl: add dri2_egl_surface_get_image_front() helper (v2)

To share common get and create dri_image_front code. In preparation to adding of new platform which uses this helper. v2: - Remove unneeded ifdef magic - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new helper function and use

[Mesa-dev] [PATCH v2 6/8] egl: add dri2_egl_surface_destroy_image_front() helper (v2)

To share common destroy dri_image_front code. In preparation to adding of new platform which uses this helper. v2: - Move dri_image_front to outside of android ifdef block for removing of ifdef magic on dri2_egl_surface_destroy_image_front(). - Fixes from Eric's review: a) Split out

[Mesa-dev] [PATCH v2 8/8] egl/wayland: add dri2_wl_free_buffers() helper

This deduplicates free routines of color_buffers array. Signed-off-by: Mun Gwan-gyeong --- src/egl/drivers/dri2/platform_wayland.c | 60 + 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c

[Mesa-dev] [PATCH v2 5/8] egl: add dri2_egl_surface_destroy_image_back() helper (v2)

To share common destroy dri_image_back code. In preparation to adding of new platform which uses this helper. v2: - Move dri_image_back to outside of android ifdef block for removing of ifdef magic on dri2_egl_surface_destroy_image_back(). - Fixes from Eric's review: a) Split out series

[Mesa-dev] [PATCH v2 2/8] egl: refactor color_buffers structure for deduplicating

This is added for preventing adding of new color buffers structure and back* when new platform backend is added. This refactoring separates out the common and platform specific bits. This makes odd casting in the platform_foo.c but it prevents adding of new ifdef magic. Because of color_buffers

[Mesa-dev] [PATCH v2 4/8] egl: add dri2_egl_surface_update_buffer_age() helper (v2)

To share common update buffer age code. This updates old buffer's age and sets current back buffer's age to 1. In preparation to adding of new platform which uses this helper. v2: - Fixes from Eric's review: a) Split out series of refactor for helpers to a separate series. b) Add the new

[Mesa-dev] [PATCH v2 3/8] egl: add dri2_egl_surface_record_buffers_and_update_back_buffer() helper (v2)

To share common record buffers and update back buffer code. This records all the buffers created by each platform's native window and update back buffer for updating buffer's age in swap_buffers. In preparation to adding of new platform which uses this helper. v2: - Remove unnedded ifdef magic

[Mesa-dev] [PATCH v2 1/8] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper (v2)

To share common free outdated buffers and update size code. This compares width and height arguments with current egl surface dimension, if the compared surface dimension is differ, then it free local buffers and updates dimension. In preparation to adding of new platform which uses this helper.

Re: [Mesa-dev] [PATCH 1/6] gallium: clarify the constraints on sampler_view_destroy

FWIW, the drivers that really are affected currently are SVGA and possibly virgl, because they pass Gallium calls on to a supervisor. Since we guarantee that the creation context is still alive, those drivers could fix any issues by adding samplers that are destroyed from a different context

[Mesa-dev] [PATCH 2/3] st/mesa: use PIPE_FORMAT_A1B5G5R5_UNORM when requested

From: Nicolai Hähnle This affects dEQP-EGL.functional.image.modify.tex_rgb5_a1_tex_subimage_rgba8, which implicitly tests that GLES really creates a 5551 texture when GL_UNSIGNED_SHORT_5_5_5_1 is passed as type parameter to glTexImage*() functions. ---

[Mesa-dev] [PATCH 1/3] gallium: add PIPE_FORMAT_A1B5G5R5_UNORM format

From: Nicolai Hähnle This matches the GL_UNSIGNED_SHORT_5_5_5_1 type. --- src/gallium/auxiliary/util/u_format.csv | 1 + src/gallium/auxiliary/util/u_format_tests.c | 7 +++ src/gallium/drivers/svga/svga_format.c | 1 + src/gallium/include/pipe/p_format.h

[Mesa-dev] [PATCH 3/3] radeonsi: add support for PIPE_FORMAT_A1R5G5B5_UNORM

From: Nicolai Hähnle Fixes dEQP-EGL.functional.image.modify.tex_rgb5_a1_tex_subimage_rgba8 --- src/gallium/drivers/radeonsi/si_state.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 1/2] st/glsl_to_tgsi: ignore GL_TEXTURE_SRGB_DECODE_EXT for samplers used with texelFetch*()

From: Nicolai Hähnle See the comment for the relevant spec quote. Fixes dEQP-GLES31.functional.srgb_texture_decode.skip_decode.srgba8.texel_fetch -- Note that this is on top of the texture locking series which I have sent out a minute ago. --- src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 2/2] st/mesa: don't assign prog->ShadowSamplers

From: Nicolai Hähnle It's not used, and the assignment for the TGSI case was incorrect for sampler arrays. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 1 - src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 2 files changed, 5 deletions(-) diff --git

[Mesa-dev] [PATCH 4/6] st/mesa: re-arrange st_finalize_texture

From: Nicolai Hähnle Move the early-out for surface-based textures earlier. This narrows the scope of the locking added in a follow-up commit. Fix one remaining case of initializing a surface-based texture without properly finalizing it. ---

[Mesa-dev] [PATCH 0/6] st/mesa: add locking around lazy texture/sampler updates

Hi all, This series is a first result of debugging some random crashes in dEQP's multi-threaded EGL tests. The OpenGL spec is pretty clear that application must not modify a texture in one context while simultaneously using it for texturing (or even modifying) it in another context. Texturing

[Mesa-dev] [PATCH 3/6] st/mesa: store state that affects sampler views per context

From: Nicolai Hähnle This fixes sequences like: 1. Context 1 samples from texture with sRGB decode enabled 2. Context 2 samples from texture with sRGB decode disabled 3. Context 1 samples from texture with sRGB decode disabled Previously, step 3 would see the

[Mesa-dev] [PATCH 5/6] st/mesa: guard st_finalize_texture by the texture validation mutex

From: Nicolai Hähnle Since finalization of textures is done lazily, a well-formed GL program might enter the main part of st_finalize_texture simultaneously in two threads. The mutex guards against corruption of our internal data structures. However, finalization may

[Mesa-dev] [PATCH 6/6] st/mesa: handle out-of-memory when resizing sampler views array

From: Nicolai Hähnle --- src/mesa/state_tracker/st_sampler_view.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_sampler_view.c b/src/mesa/state_tracker/st_sampler_view.c index 638fac671b2..de104355c04

[Mesa-dev] [PATCH 1/6] gallium: clarify the constraints on sampler_view_destroy

From: Nicolai Hähnle r600 expects the context that created the sampler view to still be alive (there is a per-context list of sampler views). svga currently bails when the context of destruction is not the same as creation. The GL state tracker, which is the only one

[Mesa-dev] [PATCH 2/6] st/mesa: guard sampler views changes with a mutex

From: Nicolai Hähnle Locking is unfortunately required, because well-formed GL programs can have multiple threads racing to access the same texture, e.g.: two threads/contexts rendering from the same texture, or one thread destroying a context while the other is

[Mesa-dev] [PATCH 1/2] disk_cache: fix a memory leak

From: Nicolai Hähnle --- src/util/disk_cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 17913a913bd..63fd8e1f93a 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@ -1138,20 +1138,21 @@

[Mesa-dev] [PATCH 2/2] disk_cache: remove unnecessary NULL-pointer guards

From: Nicolai Hähnle --- src/util/disk_cache.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index 63fd8e1f93a..e38cacb259b 100644 --- a/src/util/disk_cache.c +++ b/src/util/disk_cache.c @@

[Mesa-dev] [PATCH] u_threaded_context: fix a memory leak

From: Nicolai Hähnle The uploaders can own transfers which need to be unmapped. Destroy them before the final sync (they're not used from the driver thread anyway) so that the transfer_unmap call is processed by the driver. ---

[Mesa-dev] [PATCH 1/3] st/mesa: fix switching from surface-based to non-surface-based textures

From: Nicolai Hähnle This can happen with surface-based texture objects derived from EGL images, since those aren't immutable. Fixes tests in dEQP-EGL.functional.sharing.gles2.multithread.random.images.teximage2d.* and others --- src/mesa/main/texobj.c

[Mesa-dev] [PATCH 3/3] st/mesa: whitespace fix

From: Nicolai Hähnle --- src/mesa/state_tracker/st_texture.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_texture.h b/src/mesa/state_tracker/st_texture.h index 0cde0c1f409..ea459bf6e24 100644 ---

[Mesa-dev] [PATCH 2/3] st/mesa: fix import of EGL images with non-zero level or layer

From: Nicolai Hähnle In GL state, textures created from EGL images look like plain 2D textures with a single level, so we use the existing layer_override facility and add an analogous level_override one. Fixes

[Mesa-dev] [PATCH] glsl/linker: add check for compute shared memory size

From: Nicolai Hähnle Unlike uniforms, the limit on shared memory size is not called out explicitly in the list of things that cause linker errors, but presumably that's just an oversight in the spec. Fixes

[Mesa-dev] [PATCH 3/6] egl/dri: use createImageFromRenderbuffer2 when available

From: Nicolai Hähnle --- src/egl/drivers/dri2/egl_dri2.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 1407c96352e..171858bbcd9 100644 ---

[Mesa-dev] [PATCH 6/6] st/dri: implement createImageFromRenderbuffer(2)

From: Nicolai Hähnle Tested with dEQP-EGL tests. --- src/gallium/state_trackers/dri/dri2.c| 8 +++- src/gallium/state_trackers/dri/dri_helpers.c | 65 +--- src/gallium/state_trackers/dri/dri_helpers.h | 5 +++

[Mesa-dev] [PATCH 4/6] egl/dri: remove old left-overs

From: Nicolai Hähnle --- src/egl/drivers/dri2/platform_x11_dri3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11_dri3.c b/src/egl/drivers/dri2/platform_x11_dri3.c index 45bb56ca17e..eadd37141e0 100644 ---

[Mesa-dev] [PATCH 5/6] st_api: remove unused get_resource_for_egl_image

From: Nicolai Hähnle --- src/gallium/include/state_tracker/st_api.h | 37 -- 1 file changed, 37 deletions(-) diff --git a/src/gallium/include/state_tracker/st_api.h b/src/gallium/include/state_tracker/st_api.h index 4d27dad5c55..2232c3efa18

[Mesa-dev] [PATCH 2/6] egl/dri: factor out egl_error_from_dri_image_error

From: Nicolai Hähnle --- src/egl/drivers/dri2/egl_dri2.c | 54 - 1 file changed, 26 insertions(+), 28 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 0db80a091f8..1407c96352e

[Mesa-dev] [PATCH 1/6] dri_interface: add an error-returning version of createImageFromRenderbuffer

From: Nicolai Hähnle We ought to be able to distinguish between allocation errors and bad parameters (non-existent renderbuffer object). Bumps the version of the DRI Image extension to 17. --- include/GL/internal/dri_interface.h | 19 ++- 1 file

[Mesa-dev] [PATCH 0/6] egl/st/dri: implement createImageFromRenderbuffer and add proper error handling

Hi all, It turns out that creating an EGLImage from GL_RENDERBUFFER was never implement in st/dri, so do that. While at it, extend the DRIImage extension so that we can return the correct error code when e.g. a non-existing renderbuffer handle is passed in by the application. Please review!

[Mesa-dev] [PATCH] st/mesa: don't clobber glGetInternalformat* buffer for GL_NUM_SAMPLE_COUNTS

From: Nicolai Hähnle Applications might pass in a buffer that is sized too large and rely on the extra space of the buffer not being overwritten. Fixes dEQP-GLES31.functional.state_query.internal_format.partial_query.num_sample_counts Cc:

Re: [Mesa-dev] [PATCH 1/2] i965: Change intel_disable_rb_aux_buffer into get_drawbuffer_index().

On Friday, October 6, 2017 10:57:57 AM PDT Nanley Chery wrote: > On Thu, Oct 05, 2017 at 10:02:39PM -0700, Kenneth Graunke wrote: > > The bulk of the work in intel_disable_rb_aux_buffer() is finding the > > drawbuffer index for the given BO. After that, disabling the auxiliary > > buffers is an

[Mesa-dev] [Bug 103128] [softpipe] piglit fs-ldexp regression

https://bugs.freedesktop.org/show_bug.cgi?id=103128 Bug ID: 103128 Summary: [softpipe] piglit fs-ldexp regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords:

Re: [Mesa-dev] [PATCH 2/2] i965: Disable auxiliary buffers when there are self-dependencies.

On Fri, Oct 6, 2017 at 11:13 AM, Nanley Chery wrote: > On Thu, Oct 05, 2017 at 10:02:40PM -0700, Kenneth Graunke wrote: > > Jason and I investigated several OpenGL CTS failures where the tests > > bind the same texture for rendering and texturing, at the same time. > >

Re: [Mesa-dev] [PATCH 2/2] i965: Disable auxiliary buffers when there are self-dependencies.

On Thu, Oct 05, 2017 at 10:02:40PM -0700, Kenneth Graunke wrote: > Jason and I investigated several OpenGL CTS failures where the tests > bind the same texture for rendering and texturing, at the same time. > This has defined results as long as the reads happen before writes, > or the regions are

Re: [Mesa-dev] [PATCH 1/2] i965: Change intel_disable_rb_aux_buffer into get_drawbuffer_index().

On Fri, Oct 6, 2017 at 10:57 AM, Nanley Chery wrote: > On Thu, Oct 05, 2017 at 10:02:39PM -0700, Kenneth Graunke wrote: > > The bulk of the work in intel_disable_rb_aux_buffer() is finding the > > drawbuffer index for the given BO. After that, disabling the auxiliary > >

Re: [Mesa-dev] [PATCH 1/2] i965: Change intel_disable_rb_aux_buffer into get_drawbuffer_index().

On Thu, Oct 05, 2017 at 10:02:39PM -0700, Kenneth Graunke wrote: > The bulk of the work in intel_disable_rb_aux_buffer() is finding the > drawbuffer index for the given BO. After that, disabling the auxiliary > buffers is an easy one liner. > > This lets us ask whether a texture is also bound as

Re: [Mesa-dev] [PATCH] intel/compiler: Make brw_nir_lower_intrinsics compute-specific

Reviewed-by: Jordan Justen On 2017-10-06 10:20:28, Jason Ekstrand wrote: > It's already only ever called from brw_compile_cs and only handles > compute intrinsics. Let's just make it CS-specific. We can always > make it handle other stages again later if we want. >

Re: [Mesa-dev] [PATCH 00/21] intel/compiler: Rework the world of push/pull params

Series Reviewed-by: Jordan Justen Although, I think you said you might rewrite patch 13 (the thread_local_id_index patch). If you just add the small stage check I mentioned then you can add my r-b for it. -Jordan On 2017-09-29 14:25:00, Jason Ekstrand wrote: > This

Re: [Mesa-dev] [PATCH 10/21] i965: Only add the wpos state reference if we lowered something

On Wed, Oct 4, 2017 at 7:31 PM, Jordan Justen wrote: > On 2017-09-29 14:25:10, Jason Ekstrand wrote: > > Otherwise, in the ARB program case _mesa_add_state_reference may grow > > the parameter array which will cause brw_nir_setup_arb_uniforms to write > > past the end

[Mesa-dev] [PATCH] intel/compiler: Make brw_nir_lower_intrinsics compute-specific

It's already only ever called from brw_compile_cs and only handles compute intrinsics. Let's just make it CS-specific. We can always make it handle other stages again later if we want. Cc: Jordan Justen --- src/intel/Makefile.sources | 2 +-

Re: [Mesa-dev] [PATCH 20/21] intel/compiler: Allocate pull_param in assign_constant_locations

On Fri, Oct 6, 2017 at 9:40 AM, Jordan Justen wrote: > On 2017-09-29 14:25:20, Jason Ekstrand wrote: > > diff --git a/src/intel/compiler/brw_vec4_visitor.cpp > b/src/intel/compiler/brw_vec4_visitor.cpp > > index ff5cd2d..ae51619 100644 > > ---

[Mesa-dev] [Bug 103126] glthread doesn't offload anything in Witcher 2

https://bugs.freedesktop.org/show_bug.cgi?id=103126 --- Comment #1 from Alexander Tsoy --- My GPU: 01:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Tonga PRO [Radeon R9 285/380] [1002:6939] (rev f1) (prog-if 00 [VGA controller]) -- You are

[Mesa-dev] [Bug 103126] glthread doesn't offload anything in Witcher 2

https://bugs.freedesktop.org/show_bug.cgi?id=103126 Bug ID: 103126 Summary: glthread doesn't offload anything in Witcher 2 Product: Mesa Version: 17.2 Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 20/21] intel/compiler: Allocate pull_param in assign_constant_locations

On 2017-09-29 14:25:20, Jason Ekstrand wrote: > diff --git a/src/intel/compiler/brw_vec4_visitor.cpp > b/src/intel/compiler/brw_vec4_visitor.cpp > index ff5cd2d..ae51619 100644 > --- a/src/intel/compiler/brw_vec4_visitor.cpp > +++ b/src/intel/compiler/brw_vec4_visitor.cpp > @@ -1782,6 +1782,11 @@

Re: [Mesa-dev] [PATCH] Replace byte-swapping code with builtins in pack.c

Quoting Erik Faye-Lund (2017-10-06 00:31:20) > On Thu, Oct 5, 2017 at 8:59 PM, Jochen Rollwagen > wrote: > > Am 04.10.2017 um 05:59 schrieb Matt Turner: > >> > >> On Tue, Oct 3, 2017 at 11:01 AM, Jochen Rollwagen > >> wrote: > >>> > >>> From

Re: [Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

On Fri, Oct 6, 2017 at 4:39 AM, Dave Airlie wrote: > On 6 October 2017 at 12:31, Marek Olšák wrote: >> On Fri, Oct 6, 2017 at 4:10 AM, Connor Abbott wrote: >>> On Thu, Oct 5, 2017 at 10:08 PM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH v2 09/12] meson: build gbm

Quoting Daniel Stone (2017-10-06 03:28:48) > Hi, > > On 5 October 2017 at 22:22, Dylan Baker wrote: > > Quoting Eric Anholt (2017-10-05 12:43:47) > >> Dylan Baker writes: > >> > +install_headers('main/gbm.h') > >> > + > >> > +pkg.generate( > >> > +

Re: [Mesa-dev] [PATCH v2 06/12] meson: Build i965 and dri stack

Quoting Daniel Stone (2017-10-06 03:25:15) > Hi, > > On 5 October 2017 at 18:12, Dylan Baker wrote: > > This gets pretty much the entire classic tree building, as well as > > i965, including the various glapis. There are some workarounds for bugs > > that are fixed in meson

Re: [Mesa-dev] [PATCH v2 05/12] meson: de-tabularize meson_options.txt

Quoting Eero Tamminen (2017-10-06 03:22:56) > Hi, > > On 05.10.2017 20:12, Dylan Baker wrote: > > This ends up being unworkable as more options get added, and with > > description wrapped onto a new line it doesn't improve readability > > anyway. > > > > Signed-off-by: Dylan Baker

[Mesa-dev] [PATCH 15/15] egl/wayland: Add Wayland shm swrast support for RGB10 winsys buffers.

Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/platform_wayland.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 08b7084..20e31aa

[Mesa-dev] [PATCH 13/15] egl/wayland: Add Wayland drm support for RGB10 winsys buffers.

Successfully tested under Weston 3.0. Photometer confirms 10 rgb bits from rendering to display. Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/platform_wayland.c | 37 --- src/egl/wayland/wayland-drm/wayland-drm.c | 6 + 2

[Mesa-dev] [PATCH 02/15] i965/screen: Add basic support for rendering 10 bpc/depth 30 framebuffers. (v2)

Expose formats which are supported at least back to Gen 5 Ironlake, possibly further. Allow creation of 10 bpc winsys buffers for drawables. glxinfo now lists new RGBA 10 10 10 2/0 formats. Works correctly under DRI2 without compositing. v2: Move the BGRA/BGRX1010102 formats before the

[Mesa-dev] [PATCH 05/15] loader/dri3: Add XRGB2101010 and ARGB2101010 support.

To allow DRI3/Present buffer sharing for 10 bpc buffers. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli --- src/loader/loader_dri3_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/loader/loader_dri3_helper.c

[Mesa-dev] [PATCH 06/15] i965/screen: Add XRGB2101010 and ARGB2101010 support for DRI3.

Allow DRI3/Present buffer sharing for 10 bpc buffers. Otherwise composited desktops under DRI3 will only display black client areas for redirected windows. Signed-off-by: Mario Kleiner --- src/mesa/drivers/dri/i965/intel_screen.c | 6 ++ 1 file changed, 6

[Mesa-dev] [PATCH 12/15] egl/x11: Handle depth 30 drawables for EGL_KHR_image_pixmap.

Enables eglCreateImageKHR() with target set to EGL_NATIVE_PIXMAP_KHR to handle color depth 30 X11 drawables. Note that in theory the drawable depth 32 case in the current implementation is ambiguous: A depth 32 drawable could be of format ARGB or ARGB2101010, therefore an assignment of

[Mesa-dev] [PATCH 11/15] egl/x11: Handle depth 30 drawables under software rasterizer.

For fixing eglCreateWindowSurface() under swrast, as tested with LIBGL_ALWAYS_SOFTWARE=1. Suggested-by: Eric Engestrom Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/platform_x11.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH 04/15] dri: Add 10 bpc formats as available formats. (v2)

Used to support ARGB2101010 and XRGB2101010 winsys framebuffers / drawables, but added other 10 bpc fourcc's as well for consistency with definitions in wayland_drm.h, gbm.h, and drm_fourcc.h. v2: Align new defines with tabs instead of spaces, for consistency with remainder of that block of

[Mesa-dev] [PATCH 03/15] i965: Support accelerated blit for depth 30 formats. (v2)

Extend intel_miptree_blit() to handle at least ARGB2101010 -> XRGB2101010, ARGB2101010 -> ARGB2101010, and XRGB2101010 -> XRGB2101010 via the BLT engine, but not XRGB2101010 -> ARGB2101010 yet. This works as tested under Compiz, KDE-5, Gnome-Shell. v2: Restrict BLT fast path to exclude

[Mesa-dev] [PATCH 10/15] egl/x11: Match depth 30 RGB visuals to 32-bit RGBA EGLConfigs.

Similar to the matching of 24 bit RGB visuals to 32-bit RGBA EGLConfigs, so X11 compositors won't alpha-blend any config with a destination alpha buffer during compositing. Additionally this fixes failure to select ARGB2101010 configs via eglChooseConfig() with EGL_ALPHA_BITS 2 on a depth 30

[Mesa-dev] [PATCH 09/15] mesa: Add GL_RGBA + GL_UNSIGNED_INT_2_10_10_10_REV for OES read type.

This format + type combo is good for BGRA1010102 framebuffers for use with glReadPixels() under GLES, so add it for the GL_IMPLEMENTATION_COLOR_READ_TYPE_OES query. Allows successful testing of 10 bpc / depth 30 rendering with dEQP test case

[Mesa-dev] [PATCH 14/15] egl/wayland: Add Wayland dmabuf support for RGB10 winsys buffers.

Successfully tested under Weston 3.0. Photometer confirms 10 rgb bits from rendering to display. Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/egl_dri2.c | 3 +++ src/egl/drivers/dri2/egl_dri2.h | 2 ++

[Mesa-dev] [PATCH 08/15] i965/screen: Honor 'allow_rgb10_configs' option. (v2)

Allows to prevent exposing RGB10 configs and visuals to clients. v2: Rename expose_rgb10_configs to allow_rgb10_configs, as suggested by Emil. Signed-off-by: Mario Kleiner --- src/mesa/drivers/dri/i965/intel_screen.c | 19 +++ 1 file changed, 19

  1   2   >