[Mesa-dev] [Bug 90081] [llvmpipe] piglit ext_transform_feedback-immediate-reuse-uniform-buffer regression

https://bugs.freedesktop.org/show_bug.cgi?id=90081 Vinson Lee changed: What|Removed |Added Version|git |10.6 -- You are receiving this mail becaus

[Mesa-dev] [Bug 103062] Error starting game FS17

https://bugs.freedesktop.org/show_bug.cgi?id=103062 --- Comment #9 from alexander --- And another OpenGL context for compatibility me 3.0 and Shader 1.30. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing li

[Mesa-dev] [Bug 103062] Error starting game FS17

https://bugs.freedesktop.org/show_bug.cgi?id=103062 --- Comment #8 from alexander --- > The thread has nothing to do with using Core vs Compat GL context. > I suggest focusing on that - it's the first key obstacle. Compat for compatibility with older devices. In Innovations added to Mesa core. 4

[Mesa-dev] [PATCH 3/4] radeonsi: use postponed KILL only when derivatives are used

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 3 +-- src/gallium/drivers/radeonsi/si_shader.h | 1 + src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 2 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 6 ++ 4 files changed, 9 insertions(+), 3 de

[Mesa-dev] [PATCH 1/4] ac: replace ac_build_kill with ac_build_kill_if_false

From: Marek Olšák This will be a new LLVM intrinsic and will also work nicely with llvm.amdgcn.wqm.vote. --- src/amd/common/ac_llvm_build.c| 19 +++-- src/amd/common/ac_llvm_build.h| 2 +- src/amd/common/ac_nir_to_llvm.c | 16 ++-

[Mesa-dev] [PATCH 4/4] radeonsi: postponed KILL isn't postponed anymore, but maintains WQM

From: Marek Olšák This restores performance for the drirc workaround, i.e. KILL_IF does: visible = src0 >= 0; kill_flag &= visible; // accumulate kills amdgcn_kill(wqm_vote(visible)); // kill fully dead quads only And all helper pixels are killed at the end of the shader: amdgcn_kill

[Mesa-dev] [PATCH 2/4] ac: use llvm.amdgcn.kill with LLVM 6.0

From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 752c42e..0550f80 100644 --- a/src/amd/common/ac_llvm_build.c +++ b/src/amd/common/ac_llvm_build.c @@ -1400,20 +1400

Re: [Mesa-dev] [PATCH 1/2] meson: provide Makefile.sources variables to meson build

I'm not sure about this approach, we would need a way to add depends to meson, but I'm also worried that calling make adds another dependency that could be problematic for windows, and I really don't like the idea of having a half-and-half approach with the sources. Here's what I've been playing w

Re: [Mesa-dev] [PATCH] vulkan/wsi: Free the event in x11_manage_fifo_queues().

Reviewed-by: Lionel Landwerlin Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Henri Verbeet --- I should still have commit access. --- src/vulkan/wsi/wsi_common_x11.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c in

Re: [Mesa-dev] [PATCH] mapi/shared-glapi/test: rework glapitable.h handling

Quoting Emil Velikov (2017-10-13 13:20:37) > On 13 October 2017 at 19:13, Dylan Baker wrote: > > Quoting Emil Velikov (2017-10-13 08:35:47) > >> From: Emil Velikov > >> > >> Currently all the build systems but Meson generate the header in > >> src/mapi/glapi. Meson cannot do that since: > >> - i

Re: [Mesa-dev] [PATCH] meson: build mesa test.

Quoting Eric Anholt (2017-10-13 16:58:01) > Dylan Baker writes: > > > Signed-off-by: Dylan Baker > > --- > > src/mesa/main/tests/meson.build | 44 > > + > > src/mesa/meson.build| 3 +++ > > 2 files changed, 47 insertions(+) > > create mode

Re: [Mesa-dev] [PATCH] meson: build mesa test.

Dylan Baker writes: > Signed-off-by: Dylan Baker > --- > src/mesa/main/tests/meson.build | 44 > + > src/mesa/meson.build| 3 +++ > 2 files changed, 47 insertions(+) > create mode 100644 src/mesa/main/tests/meson.build > > diff --git a/src/

Re: [Mesa-dev] [PATCH v3 10/21] meson: split and simplify dependencies

Quoting Eric Anholt (2017-10-13 16:27:55) > Dylan Baker writes: > > > Rather than group dependencies in complex groups, use a flatter > > structure with split dependencies to avoid checking for the same > > dependencies twice. > > > > v2: - Fix building vulkan drivers without gallium or dri drive

Re: [Mesa-dev] MESA and KOTOR

Hello! I'm sorry for being late to the party. The patch you linked did land in mesa: https://cgit.freedesktop.org/mesa/mesa/commit/?id=baab345b192d207236253ce67b320fb32fa67625 However, that area of the code has since been altered a lot. Back then I made sure that KOTOR ran perfectly with Win

Re: [Mesa-dev] [PATCH v3 10/21] meson: split and simplify dependencies

Dylan Baker writes: > Rather than group dependencies in complex groups, use a flatter > structure with split dependencies to avoid checking for the same > dependencies twice. > > v2: - Fix building vulkan drivers without gallium or dri drivers > v3: - Drop TODO comment that is done > - Fix ty

[Mesa-dev] [PATCH 2/2] i965: use Makefile.sources source list in meson build

--- src/mesa/drivers/dri/i965/meson.build | 114 +- 1 file changed, 1 insertion(+), 113 deletions(-) diff --git a/src/mesa/drivers/dri/i965/meson.build b/src/mesa/drivers/dri/i965/meson.build index 144a254bd6..0101c8b91b 100644 --- a/src/mesa/drivers/dri/i965/meso

[Mesa-dev] [PATCH 1/2] meson: provide Makefile.sources variables to meson build

--- Caveat: meson won't pick up modifications to the Makefile.sources files without something like: https://github.com/mesonbuild/meson/pull/2490 bin/get-makefile-sources-vars.py | 50 +++ meson.build | 85 2 files

Re: [Mesa-dev] [PATCH v3 02/21] configure: commit test files

Dylan Baker writes: > These are currently auto-generated, but meson needs the same files, so > lets commit them to reduce duplication. > > v3: - Rename .build to build-support 2, 3 are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH] amd/common: run the EarlyCSEMemSSA LLVM pass

r-b On Thu, Oct 12, 2017 at 4:39 PM, Samuel Pitoiset wrote: > It's recommended by the instruction combining pass, and > RadeonSI also runs it. The code size should decrease but > the number of register might increase a little bit. > > Though, after comparing the shader stats with DOW3, it > appea

Re: [Mesa-dev] [PATCH] mesa: minor simplification in test_attachment_completeness()

Reviewed-by: Timothy Arceri On 14/10/17 09:17, Brian Paul wrote: We already have a pointer to the texture object. Use it here. --- src/mesa/main/fbobject.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index db8c207

Re: [Mesa-dev] [PATCH 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

On Wed, Oct 04, 2017 at 09:25:57AM -0700, Rafael Antognolli wrote: > Hi Anuj, > > On Mon, Oct 02, 2017 at 04:07:57PM -0700, Anuj Phogat wrote: > > WaFlushHangWhenNonPipelineStateAndMarkerStalled goes along > > with WaSampleOffsetIZ. Both recommends the same. > > > > Cc: mesa-sta...@lists.freedesk

Re: [Mesa-dev] [PATCH] radv: set correct INDEX_TYPE for indexed indirect draws on GFX9

r-b On Fri, Oct 13, 2017 at 6:01 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vulkan/radv_cmd_buffer.c > inde

Re: [Mesa-dev] [PATCH] radv: set correct INDEX_TYPE for indexed indirect draws on GFX9

r-b On Fri, Oct 13, 2017 at 6:01 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vulkan/radv_cmd_buffer.c > inde

Re: [Mesa-dev] [PATCH 4/4] radv: use CLEAR_STATE for initializing some registers

r-b for the series On Wed, Oct 11, 2017 at 7:15 PM, Samuel Pitoiset wrote: > Based on RadeonSI. > > This improves some Vulkan demos by +1% to +3%. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/si_cmd_buffer.c | 99 > +- > 1 file changed, 58 i

Re: [Mesa-dev] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

Hi Anuj, sorry that I missed this patch. Please see below. On Fri, Oct 06, 2017 at 04:30:47PM -0700, Anuj Phogat wrote: > There are few other (duplicate) workarounds which have similar > recommendations: > WaFlushHangWhenNonPipelineStateAndMarkerStalled > WaCSStallBefore3DSamplePattern > WaPipeCo

[Mesa-dev] [Bug 103268] [llvmpipe] piglit texdepth regression

https://bugs.freedesktop.org/show_bug.cgi?id=103268 Bug ID: 103268 Summary: [llvmpipe] piglit texdepth regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords: b

Re: [Mesa-dev] [Mesa-stable] [PATCH] vulkan/wsi: Free the event in x11_manage_fifo_queues().

On 13 October 2017 at 19:23, Emil Velikov wrote: > Please give it time for Vulkan devs to take a look. > Sure, I'm in no particular hurry. Henri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa

[Mesa-dev] [PATCH] mesa: minor simplification in test_attachment_completeness()

We already have a pointer to the texture object. Use it here. --- src/mesa/main/fbobject.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index db8c207..71e91f9 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbo

[Mesa-dev] [AppVeyor] mesa master #5796 completed

Build mesa 5796 completed Commit 1cec500c69 by Jason Ekstrand on 10/13/2017 5:40 PM: blob: Use intptr_t instead of ssize_t\n\nssize_t is a GNU extension and is not available on Windows or MacOS.\nInstead, we use intptr_t which should be effectively equivalent a

[Mesa-dev] [PATCH v3 18/21] meson: build softpipe

This doesn't include llvmpipe. v2: - Fix inconsistent use of with_gallium_swrast and with_gallium_softpipe. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 5 ++ meson_options.txt| 4 +- src/gallium/drivers/soft

[Mesa-dev] [PATCH v3 21/21] .travis: Add meson configuration for gallium drivers

--- .travis.yml | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 766ee158c70..c92a6b6f01c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -367,7 +367,7 @@ matrix: - env: - LABEL="meson Vulkan" - BUI

[Mesa-dev] [PATCH v3 01/21] meson: Add switch for texture float

Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 4 meson_options.txt | 2 ++ 2 files changed, 6 insertions(+) diff --git a/meson.build b/meson.build index 02264aeed4e..54230a91ed5 100644 --- a/meson.build +++ b/meson.build @@ -37,6 +37,10 @@ with_vulkan_icd_dir

[Mesa-dev] [PATCH v3 19/21] meson: build llvmpipe

Signed-off-by: Dylan Baker --- meson.build | 4 +- src/gallium/drivers/llvmpipe/meson.build | 116 +++ src/gallium/meson.build | 2 +- src/gallium/targets/dri/meson.build | 4 ++ 4 files changed, 124 insertions(+

[Mesa-dev] [PATCH v3 09/21] meson: Build gallium auxiliary

v2: - guard gallivm files with "with_llvm" instead of "dep_llvm.found()" Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt (v1) --- meson.build | 36 ++- meson_options.txt | 4 +- src/gallium/auxiliary/meson.build | 528

[Mesa-dev] [PATCH v3 15/21] meson: build gallium winsys for dri, null, and wrapper

Signed-off-by: Dylan Baker --- meson.build | 4 ++ src/gallium/auxiliary/pipe-loader/meson.build | 12 -- src/gallium/meson.build | 8 ++-- src/gallium/{ => winsys/sw/dri}/meson.build | 55 +++- src/galliu

[Mesa-dev] [PATCH v3 20/21] meson: refactor meson_options

To put one argument on each line. This results in the file being much longer, but I think much more readable. Suggested-by: Eero Tamminen Signed-off-by: Dylan Baker --- meson_options.txt | 170 +- 1 file changed, 129 insertions(+), 41 deletion

[Mesa-dev] [PATCH v3 14/21] meson: build radeonsi

This builds the radeonsi (and radeon) window system bits and gallium driver bits. Signed-off-by: Dylan Baker --- meson.build | 18 -- src/gallium/{ => drivers/radeon}/meson.build| 43 +++--- src/gallium/drivers/radeonsi/meson.build| 78

[Mesa-dev] [PATCH v3 11/21] meson: Build gallium pipe-loader

Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build | 2 + src/gallium/auxiliary/pipe-loader/meson.build | 63 +++ src/gallium/meson.build | 2 + 3 files changed, 67 insertions(+) create mode 100644 src/gallium/auxiliary/pi

[Mesa-dev] [PATCH v3 16/21] meson: build radeonsi gallium driver

This hooks up the bits necessary to build gallium dri drivers, with radeonSI as the first example driver. This isn't tested yet. --- meson.build | 4 +- src/gallium/drivers/radeonsi/meson.build | 2 +- src/gallium/meson.build | 3 +- src/gallium/tar

[Mesa-dev] [PATCH v3 05/21] meson: Don't try to install dri drivers unless one is built

This confused the with_dri flag which is meant to control Direct Rendering Infrastructure, not classic drivers Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- src/mesa/drivers/dri/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/meson.

[Mesa-dev] [PATCH v3 13/21] meson: Build gallium dri state tracker

Signed-off-by: Dylan Baker --- meson.build | 1 + src/gallium/meson.build | 1 + src/gallium/{ => state_trackers/dri}/meson.build | 46 +++- 3 files changed, 39 insertions(+), 9 deletions(-) copy src/gallium/{ =>

[Mesa-dev] [PATCH v3 03/21] meson: add checks for version script and dynamic list

These are used by gallium drivers. Signed-off-by: Dylan Baker --- meson.build | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 54230a91ed5..2f73215ca52 100644 --- a/meson.build +++ b/meson.build @@ -433,14 +433,28 @@ endif

[Mesa-dev] [PATCH v3 17/21] meson: build nouveau (gallium) driver

Tested with a GK107. v2: - Add target for nouveau standalone compiler. This target is not built by default. v3: - Add nouveau to list of drivers built by default Signed-off-by: Dylan Baker --- meson.build | 6 + meson_options.txt

[Mesa-dev] [PATCH v3 10/21] meson: split and simplify dependencies

Rather than group dependencies in complex groups, use a flatter structure with split dependencies to avoid checking for the same dependencies twice. v2: - Fix building vulkan drivers without gallium or dri drivers v3: - Drop TODO comment that is done - Fix typo in commit message Signed-off-by

[Mesa-dev] [PATCH v3 08/21] meson: build libmesa_gallium

Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 25 + meson_options.txt| 2 + src/mesa/meson.build | 143 ++- 3 files changed, 158 insertions(+), 12 deletions(-) diff --git a/meson.build b/meson.build

[Mesa-dev] [PATCH v3 04/21] meson: Set _GNU_SOURCE

When we start adding non-free software platforms support we'll need to guard this, but for now it should be fine as is. Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 2f73215ca52..e68469262b

[Mesa-dev] [PATCH v3 06/21] meson: always set GLX_USE_TLS

This can be applied to all GLX implementations, and in autotools this is guarded only by the --enable-glx-tls flag. Since this is on by default in autotools, and is strictly better than being off, the meson build doesn't even have a toggle for it. Signed-off-by: Dylan Baker Reviewed-by: Eric Anho

[Mesa-dev] [PATCH v3 07/21] meson: Add option to toggle LLVM

Signed-off-by: Dylan Baker Reviewed-by: Eric Anholt --- meson.build | 35 --- meson_options.txt | 1 + 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/meson.build b/meson.build index 17187f3d909..ff2ce55e924 100644 --- a/meson.build +++ b/m

[Mesa-dev] [PATCH v3 12/21] meson: build gallium helper drivers

This builds ddebug, noop, rbug, and trace drivers. Signed-off-by: Dylan Baker --- src/gallium/{ => drivers/ddebug}/meson.build | 13 - src/gallium/{ => drivers/noop}/meson.build | 12 +++- src/gallium/{ => drivers/rbug}/meson.build | 13 - src/gallium/{ => dri

[Mesa-dev] [PATCH v3 02/21] configure: commit test files

These are currently auto-generated, but meson needs the same files, so lets commit them to reduce duplication. v3: - Rename .build to build-support cc: Emil Velikov Signed-off-by: Dylan Baker --- I ran make dist and that works (after patching out the swr llvm 3.9 check). I alos built that tar

[Mesa-dev] [Bug 103265] [llvmpipe] piglit depth-tex-compare regression

https://bugs.freedesktop.org/show_bug.cgi?id=103265 --- Comment #1 from Roland Scheidegger --- (In reply to Vinson Lee from comment #0) > commit be3ab867bd444594f9d9e0f8e59d305d15769afd > Author: Marek Olšák > Date: Mon Oct 2 22:30:55 2017 +0200 > > tgsi: implement tgsi_util_get_inst_usag

[Mesa-dev] [Bug 103266] [llvmpipe] piglit sampler-cube-shadow regression

https://bugs.freedesktop.org/show_bug.cgi?id=103266 Bug ID: 103266 Summary: [llvmpipe] piglit sampler-cube-shadow regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 0/6] Prehash all the things

Thank you Thomas for the update, then. Awaiting your coming work. Regards, Dieter Am 10.10.2017 15:22, schrieb Thomas Helland: Hi! Thanks for keeping up with the long wait =) I revisited this not too long ago, and found that with the new pointer hashing function the benefits are zero to negati

[Mesa-dev] [Bug 103265] [llvmpipe] piglit depth-tex-compare regression

https://bugs.freedesktop.org/show_bug.cgi?id=103265 Bug ID: 103265 Summary: [llvmpipe] piglit depth-tex-compare regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Ke

[Mesa-dev] [Bug 103264] cache-test fails on Mac OS X 10.13

https://bugs.freedesktop.org/show_bug.cgi?id=103264 Bug ID: 103264 Summary: cache-test fails on Mac OS X 10.13 Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: NEW Severity: n

Re: [Mesa-dev] [PATCH] blob: Use intptr_t instead of ssize_t

On Fri, Oct 13, 2017 at 10:44 AM, Jason Ekstrand wrote: > ssize_t is a GNU extension and is not available on Windows or MacOS. > Instead, we use intptr_t which should be effectively equivalent and is > part of the C standard. This should fix the Windows and Mac OS builds. > > Cc: Jose Fonseca >

Re: [Mesa-dev] [PATCH] mapi/shared-glapi/test: rework glapitable.h handling

On 13 October 2017 at 19:13, Dylan Baker wrote: > Quoting Emil Velikov (2017-10-13 08:35:47) >> From: Emil Velikov >> >> Currently all the build systems but Meson generate the header in >> src/mapi/glapi. Meson cannot do that since: >> - it does not allow user control over the location of output

[Mesa-dev] [PATCH] meson: build mesa test.

Signed-off-by: Dylan Baker --- src/mesa/main/tests/meson.build | 44 + src/mesa/meson.build| 3 +++ 2 files changed, 47 insertions(+) create mode 100644 src/mesa/main/tests/meson.build diff --git a/src/mesa/main/tests/meson.build b/src/mesa/m

Re: [Mesa-dev] [PATCH v1] clover/llvm: Drop support for LLVM < 3.9.

Emil Velikov writes: > Hi Vedran, > > Just pushed the LLVM version bump, so this patch should be able to go in. > I won't be able to offer any review here, apart from a small suggestion. > > On 9 October 2017 at 00:08, Vedran Miletić wrote: > >> #include >> #include >> @@ -63,11 +56,7 @@ >>

[Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

This passes 33/37 deqp tests related to partial_update, 4 are not supported. Signed-off-by: Harish Krupo --- src/egl/drivers/dri2/platform_wayland.c | 68 - 1 file changed, 59 insertions(+), 9 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/s

Re: [Mesa-dev] [PATCH] mapi/shared-glapi/test: rework glapitable.h handling

Quoting Emil Velikov (2017-10-13 08:35:47) > From: Emil Velikov > > Currently all the build systems but Meson generate the header in > src/mapi/glapi. Meson cannot do that since: > - it does not allow user control over the location of output files > - moving the generation rule(s) causes explos

Re: [Mesa-dev] [PATCH v2 21/52] intel/cs: Drop min_dispatch_width checks from compile_cs

Hi Jason, you actually dropped max_dispatch_width so you might want to update the commit message. Michael Am 13.10.2017 08:13 schrieb "Jason Ekstrand" : The only things that adjust min_dispatch_width are render target writes which don't happen in compute shaders so they're pointless. --- src/in

Re: [Mesa-dev] [PATCH] mapi/shared-glapi/test: rework glapitable.h handling

For list posterity: Reviewed-by: Dylan Baker Quoting Emil Velikov (2017-10-13 08:35:47) > From: Emil Velikov > > Currently all the build systems but Meson generate the header in > src/mapi/glapi. Meson cannot do that since: > - it does not allow user control over the location of output files >

Re: [Mesa-dev] [PATCH v2 02/12] make: Fix test to be meson compatible

Quoting Emil Velikov (2017-10-13 10:27:38) > On 13 October 2017 at 18:21, Dylan Baker wrote: > > Quoting Emil Velikov (2017-10-13 07:01:24) > >> On 5 October 2017 at 20:12, Dylan Baker wrote: > >> > Quoting Emil Velikov (2017-10-05 11:26:40) > >> >> On 5 October 2017 at 18:12, Dylan Baker wrote:

Re: [Mesa-dev] [PATCH] mapi/shared-glapi/test: rework glapitable.h handling

Tested-by: Mark Janes Emil Velikov writes: > From: Emil Velikov > > Currently all the build systems but Meson generate the header in > src/mapi/glapi. Meson cannot do that since: > - it does not allow user control over the location of output files > - moving the generation rule(s) causes exp

[Mesa-dev] [PATCH] blob: Use intptr_t instead of ssize_t

ssize_t is a GNU extension and is not available on Windows or MacOS. Instead, we use intptr_t which should be effectively equivalent and is part of the C standard. This should fix the Windows and Mac OS builds. Cc: Jose Fonseca Cc: Vinson Lee Fixes: 3af1c829891a4530682bce113fdd512d4f2de3c6 Bugz

Re: [Mesa-dev] [PATCH] blob: Use intptr_t instead of ssize_t

On 13/10/17 18:44, Jason Ekstrand wrote: ssize_t is a GNU extension and is not available on Windows or MacOS. Instead, we use intptr_t which should be effectively equivalent and is part of the C standard. This should fix the Windows and Mac OS builds. Cc: Jose Fonseca Cc: Vinson Lee Fixes: 3a

Re: [Mesa-dev] [PATCH] radv: add the draw count buffer to the list of buffers

r-b On Fri, Oct 13, 2017 at 6:20 PM, Samuel Pitoiset wrote: > My guess is that the GPU is going to report VM faults if > vkCmdDrawIndirectCountAMD() (and friends) are used. > > Signed-off-by: Samuel Pitoiset > Cc: mesa-sta...@lists.freedesktop.org > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 ++

Re: [Mesa-dev] [PATCH v2 02/12] make: Fix test to be meson compatible

On 13 October 2017 at 18:21, Dylan Baker wrote: > Quoting Emil Velikov (2017-10-13 07:01:24) >> On 5 October 2017 at 20:12, Dylan Baker wrote: >> > Quoting Emil Velikov (2017-10-05 11:26:40) >> >> On 5 October 2017 at 18:12, Dylan Baker wrote: >> >> > This has the same problem as the previous co

Re: [Mesa-dev] [Mesa-stable] [PATCH] vulkan/wsi: Free the event in x11_manage_fifo_queues().

Hi Henri, On 13 October 2017 at 16:10, Henri Verbeet wrote: > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Henri Verbeet Fixes: e73d136a023 ("vulkan/wsi/x11: Implement FIFO mode.") Reviewed-by: Emil Velikov Please give it time for Vulkan devs to take a look. Thanks Emil ___

Re: [Mesa-dev] [PATCH v2 02/12] make: Fix test to be meson compatible

Quoting Emil Velikov (2017-10-13 07:01:24) > On 5 October 2017 at 20:12, Dylan Baker wrote: > > Quoting Emil Velikov (2017-10-05 11:26:40) > >> On 5 October 2017 at 18:12, Dylan Baker wrote: > >> > This has the same problem as the previous commit, generated headers and > >> > hardcoded paths. > >

[Mesa-dev] [PATCH] radv: add the draw count buffer to the list of buffers

My guess is that the GPU is going to report VM faults if vkCmdDrawIndirectCountAMD() (and friends) are used. Signed-off-by: Samuel Pitoiset Cc: mesa-sta...@lists.freedesktop.org --- src/amd/vulkan/radv_cmd_buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_cmd_buf

[Mesa-dev] [PATCH] radv: set correct INDEX_TYPE for indexed indirect draws on GFX9

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 78a250214a..c0fe12b489 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/s

[Mesa-dev] [PATCH] mapi/shared-glapi/test: rework glapitable.h handling

From: Emil Velikov Currently all the build systems but Meson generate the header in src/mapi/glapi. Meson cannot do that since: - it does not allow user control over the location of output files - moving the generation rule(s) causes explosion due to the unusual structure of glapi and friends

[Mesa-dev] [PATCH] vulkan/wsi: Free the event in x11_manage_fifo_queues().

Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Henri Verbeet --- I should still have commit access. --- src/vulkan/wsi/wsi_common_x11.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index ecdaf91..22b067b 100644 --- a/s

Re: [Mesa-dev] [PATCH 14/16] ac: use amdgpu-flat-work-group-size

Nevermind. I'm dropping this patch. It's incomplete. Marek On Fri, Oct 13, 2017 at 3:49 PM, Marek Olšák wrote: > Yes good point. > > Marek > > On Fri, Oct 13, 2017 at 3:39 PM, Ernst Sjöstrand wrote: >> Isn't the logic inverted here? >> >> 2017-10-13 14:04 GMT+02:00 Marek Olšák : >>> From: Marek

Re: [Mesa-dev] [PATCH v2 02/12] make: Fix test to be meson compatible

On 5 October 2017 at 20:12, Dylan Baker wrote: > Quoting Emil Velikov (2017-10-05 11:26:40) >> On 5 October 2017 at 18:12, Dylan Baker wrote: >> > This has the same problem as the previous commit, generated headers and >> > hardcoded paths. >> > >> Something's strange here. You already have the "

Re: [Mesa-dev] [PATCH 14/16] ac: use amdgpu-flat-work-group-size

Yes good point. Marek On Fri, Oct 13, 2017 at 3:39 PM, Ernst Sjöstrand wrote: > Isn't the logic inverted here? > > 2017-10-13 14:04 GMT+02:00 Marek Olšák : >> From: Marek Olšák >> >> the old one is being deprecated or removed >> --- >> src/amd/common/ac_nir_to_llvm.c | 3 ++- >> src/g

Re: [Mesa-dev] [PATCH 14/16] ac: use amdgpu-flat-work-group-size

Isn't the logic inverted here? 2017-10-13 14:04 GMT+02:00 Marek Olšák : > From: Marek Olšák > > the old one is being deprecated or removed > --- > src/amd/common/ac_nir_to_llvm.c | 3 ++- > src/gallium/drivers/radeonsi/si_shader.c | 4 +++- > 2 files changed, 5 insertions(+), 2 deletion

Re: [Mesa-dev] [PATCH 00/16] RadeonSI micro-optimizations

On Fri, Oct 13, 2017 at 2:24 PM, Mike Lothian wrote: > Hi > > Have you ran any benchmarks against these? No I haven't. For the IB placement, I measured the decrease in CP stalls using performance counters, but generally CP isn't memory-bound on radeonsi due to our optimized packet ordering. For

Re: [Mesa-dev] [PATCH v1] clover/llvm: Drop support for LLVM < 3.9.

Hi Vedran, Just pushed the LLVM version bump, so this patch should be able to go in. I won't be able to offer any review here, apart from a small suggestion. On 9 October 2017 at 00:08, Vedran Miletić wrote: > #include > #include > @@ -63,11 +56,7 @@ > namespace clover { > namespace ll

Re: [Mesa-dev] [PATCH 00/16] RadeonSI micro-optimizations

Hi Have you ran any benchmarks against these? Cheers Mike On Fri, 13 Oct 2017 at 13:04 Marek Olšák wrote: > Hi, > > This series: > - switches IB placement to GTT WC > - uses SPI_SHADER_USER_DATA_COMMON on GFX9 > - combines setting of 2 per-stage descriptor pointers into 1 SET_SH_REG > packet

Re: [Mesa-dev] [PATCH 01/15] i965: Complete 'expose RGBA visuals only on Android'

On 12 October 2017 at 16:34, Mario Kleiner wrote: > On 10/11/2017 05:25 PM, Emil Velikov wrote: >> >> On 10 October 2017 at 11:34, Tapani Pälli wrote: >>> >>> Reviewed-by: Tapani Pälli >>> >>> I think this fix can/should land separately from the set. >>> >> Yes, please. Thanks for catching that

[Mesa-dev] [PATCH 11/16] radeonsi: unify code for extracting a buffer address from a descriptor

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index cac203b..3c33e85 100644 --- a/src/gallium/drive

[Mesa-dev] [PATCH 07/16] radeonsi: split si_emit_shader_pointer

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 34 ++- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 6e1fd80..a0f3dcf 100644 --- a

[Mesa-dev] [PATCH 14/16] ac: use amdgpu-flat-work-group-size

From: Marek Olšák the old one is being deprecated or removed --- src/amd/common/ac_nir_to_llvm.c | 3 ++- src/gallium/drivers/radeonsi/si_shader.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c i

[Mesa-dev] [PATCH 13/16] radeonsi: handle 64-bit loads earlier in fetch_constant

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 62a056d..ff372ae 100644 --- a/src/gallium/dri

[Mesa-dev] [PATCH 10/16] radeonsi: remove atom parameter from si_upload_descriptors

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index a2b7c11..cac203b 100644 --- a/src/gallium/driv

[Mesa-dev] [PATCH 15/16] ac: clean up ac_build_indexed_load function interfaces

From: Marek Olšák --- src/amd/common/ac_llvm_build.c| 42 ++- src/amd/common/ac_llvm_build.h| 14 src/amd/common/ac_nir_to_llvm.c | 22 ++-- src/gallium/drivers/radeonsi/si_shader.c | 34 +

[Mesa-dev] [PATCH 16/16] radeonsi: if there's just const buffer 0, set it in place of CONST/SSBO pointer

From: Marek Olšák SI_SGPR_CONST_AND_SHADER_BUFFERS now contains the pointer to const buffer 0 if there is no other buffer there. Benefits: - there is no constbuf descriptor upload and shader load It's assumed that all constant addresses are within bounds. Non-constant addresses are clamped agai

[Mesa-dev] [PATCH 08/16] radeonsi: emit dirty consecutive pointers in one SET_SH_REG packet

From: Marek Olšák IB size: -1.6% --- src/gallium/drivers/radeonsi/si_descriptors.c | 66 --- 1 file changed, 39 insertions(+), 27 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index a0f3dcf..a2b7c

[Mesa-dev] [PATCH 01/16] winsys/amdgpu: don't do read-modify-write on command buffers

From: Marek Olšák i.e. don't use |= --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 19 +++ src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 1 + 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm

[Mesa-dev] [PATCH 12/16] radeonsi: add si_descriptors::gpu_address and remove buffer_offset

From: Marek Olšák This allows us to change the pointer arbitrarily. --- src/gallium/drivers/radeonsi/si_cp_dma.c | 3 ++- src/gallium/drivers/radeonsi/si_descriptors.c | 27 +++ src/gallium/drivers/radeonsi/si_state.h | 2 +- 3 files changed, 18 insertions(+)

[Mesa-dev] [PATCH 06/16] radeonsi: generalize the SI_VS_SHADER_POINTER_MASK macro

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 2 +- src/gallium/drivers/radeonsi/si_state.h | 4 ++-- src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gall

[Mesa-dev] [PATCH 03/16] radeonsi: add GFX-IB-size query to the HUD

From: Marek Olšák It shows the sum of all IBs per frame. --- src/gallium/drivers/radeon/r600_query.c | 4 src/gallium/drivers/radeon/r600_query.h | 1 + src/gallium/drivers/radeon/radeon_winsys.h| 1 + src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 1 + src/

[Mesa-dev] [PATCH 02/16] winsys/amdgpu: disable CPU caching for GFX & SDMA IBs

From: Marek Olšák This should decrease IB fetch latency. --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index 0a657f7..8fbe8ae 1

[Mesa-dev] [PATCH 04/16] radeonsi/gfx9: move RW_BUFFERS from s[0:1] to s[8:9] for HS and GS

From: Marek Olšák Let's use the same user data SGPRs in all stages. (for SPI_SHADER_USER_DATA_COMMON_0) --- src/gallium/drivers/radeonsi/si_descriptors.c | 24 - src/gallium/drivers/radeonsi/si_shader.c | 31 +++ 2 files changed, 16 insertions(+),

[Mesa-dev] [PATCH 00/16] RadeonSI micro-optimizations

Hi, This series: - switches IB placement to GTT WC - uses SPI_SHADER_USER_DATA_COMMON on GFX9 - combines setting of 2 per-stage descriptor pointers into 1 SET_SH_REG packet - if there is only 1 constant buffer and 0 shader and atomic buffers, the constant buffer pointer is directly set into SI_S

[Mesa-dev] [PATCH 09/16] radeonsi: pack si_descriptors better again

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.h b/src/gallium/drivers/radeonsi/si_state.h index bc7e7b3..8ce3cdb 100644 --- a/src/gallium/drivers/radeonsi/si_state.h +++

[Mesa-dev] [PATCH 05/16] radeonsi/gfx9: use SPI_SHADER_USER_DATA_COMMON

From: Marek Olšák IB size: -0.4% --- src/gallium/drivers/radeonsi/si_descriptors.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 9ba8df6..6e1fd8

  1   2   >